Subject: [bug#29306] network-manager-vpnc

From: [email-masked] (Ludovic Courtès)
Date: Thu, 16 Nov 2017 10:25:27 +0100

Heya ng0,

ng0 <[email-masked]> skribis:

> From 0cf7c178f8453ffa0984d1f6e18efb61cf55d0d2 Mon Sep 17 00:00:00 2001
> From: ng0 <[email-masked]>
> Date: Wed, 15 Nov 2017 10:40:46 +0000
> Subject: [PATCH] gnu: Add network-manager-vpnc.
>
> * gnu/packages/gnome.scm (network-manager-vpnc): New variable.

I don’t think this patch is crude.  :-)

Minor issues:

> +    (arguments
> +     '(#:tests? #f ;test-import-export is failing

Do you think you could investigate a bit?

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-Makefile
> +           (lambda _
> +             (substitute* "nm-vpnc-service.conf"
> +               (("own_prefix")
> +                "own")))))))

Please add a comment explaining what this does.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("pkg-config" ,pkg-config)
> +       ("libtool" ,libtool)
> +       ("intltool" ,intltool)))

Autoconf/Automake/Libtool are probably unnecessary.

Otherwise LGTM, thanks!

Ludo’.