From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 04:21:41 2017 Received: (at submit) by debbugs.gnu.org; 15 Nov 2017 09:21:41 +0000 Received: from localhost ([127.0.0.1]:40962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEtt6-0005Qf-Sk for submit@debbugs.gnu.org; Wed, 15 Nov 2017 04:21:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEtt4-0005QR-G1 for submit@debbugs.gnu.org; Wed, 15 Nov 2017 04:21:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEtsy-0003yK-CN for submit@debbugs.gnu.org; Wed, 15 Nov 2017 04:21:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEtsy-0003yE-8i for submit@debbugs.gnu.org; Wed, 15 Nov 2017 04:21:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEtsx-0004dM-2B for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 04:21:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEtst-0003uN-Pl for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 04:21:31 -0500 Received: from mail.arstecnica.it ([144.76.81.238]:53332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEtst-0003q7-HI for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2017 04:21:27 -0500 Received: from nautilus (assp.arstecnica.it [192.168.1.102]) by mail.arstecnica.it (Postfix) with ESMTPSA id AF9B883EF11 for ; Wed, 15 Nov 2017 09:21:17 +0000 (UTC) Received: from nautilus ([31.44.165.109] helo=nautilus) by assp.arstecnica.it with SMTPS(AES256-GCM-SHA384) (2.3.3); 15 Nov 2017 09:21:11 +0000 From: Lele Gaifax To: bug-gnu-emacs@gnu.org Subject: 26.0.90; Typos in electric.el, with patch Date: Wed, 15 Nov 2017 10:21:11 +0100 Message-ID: <87bmk3x5h4.fsf@metapensiero.it> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Assp-Version: 2.3.3(14029) on assp.arstecnica.it X-Assp-ID: assp.arstecnica.it m1-37677-05532 X-Assp-Session: A785871C (mail 1) X-Assp-Envelope-From: lele@metapensiero.it X-Assp-Intended-For: bug-gnu-emacs@gnu.org X-Assp-Client-TLS: yes X-Assp-Server-TLS: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain There are two typos in the definition of the variable `electric-indent-functions-without-reindent' in lisp/electric.el: - its docstring mentions a non existing `line-indent-function' instead of the correct `indent-line-function'; - its value contains a reference to a non existing `py-indent-line' function, that should really be `python-indent-line-function'. The attached patch fixes both issues. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-typos-in-electric-indent-functions-without-reind.patch >From c340e5ef63c3bf163eb39b7db5f0c6c34814d97d Mon Sep 17 00:00:00 2001 From: Lele Gaifax Date: Wed, 15 Nov 2017 10:01:45 +0100 Subject: [PATCH 1/2] Fix typos in electric-indent-functions-without-reindent * lisp/electric.el (electric-indent-functions-without-reindent): Fix doc typo, `line-indent-function' -> `indent-line-function'; fix python specific indent line function name, `py-indent-line' -> `python-indent-line-function'. --- lisp/electric.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/electric.el b/lisp/electric.el index d7929945db..6a08554ed0 100644 --- a/lisp/electric.el +++ b/lisp/electric.el @@ -223,11 +223,11 @@ electric-indent-inhibit (defvar electric-indent-functions-without-reindent '(indent-relative indent-to-left-margin indent-relative-maybe - py-indent-line coffee-indent-line org-indent-line yaml-indent-line - haskell-indentation-indent-line haskell-indent-cycle haskell-simple-indent - yaml-indent-line) + python-indent-line-function coffee-indent-line org-indent-line + yaml-indent-line haskell-indentation-indent-line + haskell-indent-cycle haskell-simple-indent yaml-indent-line) "List of indent functions that can't reindent. -If `line-indent-function' is one of those, then `electric-indent-mode' will +If `indent-line-function' is one of those, then `electric-indent-mode' will not try to reindent lines. It is normally better to make the major mode set `electric-indent-inhibit', but this can be used as a workaround.") -- 2.15.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 nickname: Lele Gaifax | Quando vivr=C3=B2 di quello che ho pensato ieri real: Emanuele Gaifas | comincer=C3=B2 ad aver paura di chi mi copia. lele@metapensiero.it | -- Fortunato Depero, 1929. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 15 06:58:10 2017 Received: (at 29304) by debbugs.gnu.org; 15 Nov 2017 11:58:10 +0000 Received: from localhost ([127.0.0.1]:41048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEwKY-0000fp-JS for submit@debbugs.gnu.org; Wed, 15 Nov 2017 06:58:10 -0500 Received: from mail.arstecnica.it ([144.76.81.238]:56726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEwKX-0000fc-9a for 29304@debbugs.gnu.org; Wed, 15 Nov 2017 06:58:09 -0500 Received: from nautilus (assp.arstecnica.it [192.168.1.102]) by mail.arstecnica.it (Postfix) with ESMTPSA id 4AE1583EF45 for <29304@debbugs.gnu.org>; Wed, 15 Nov 2017 11:58:02 +0000 (UTC) Received: from nautilus ([31.44.165.109] helo=nautilus) by assp.arstecnica.it with SMTPS(AES256-GCM-SHA384) (2.3.3); 15 Nov 2017 11:58:01 +0000 From: Lele Gaifax To: 29304@debbugs.gnu.org Subject: py-indent-line comes from the external python-mode Date: Wed, 15 Nov 2017 12:58:01 +0100 Message-ID: <87inebah4m.fsf@metapensiero.it> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Assp-Version: 2.3.3(14029) on assp.arstecnica.it X-Assp-ID: assp.arstecnica.it m1-47082-04004 X-Assp-Session: B12EA03C (mail 1) X-Assp-Envelope-From: lele@metapensiero.it X-Assp-Intended-For: 29304@debbugs.gnu.org X-Assp-Client-TLS: yes X-Assp-Server-TLS: yes X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29304 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Further investigation reveals that the external python-mode (that is, https://gitlab.com/python-mode-devs/python-mode) effectively implements the `py-indent-line' function, so that was the target. I guess the attached patch should be ignored. The docstring typo seems real, though. --=20 nickname: Lele Gaifax | Quando vivr=C3=B2 di quello che ho pensato ieri real: Emanuele Gaifas | comincer=C3=B2 ad aver paura di chi mi copia. lele@metapensiero.it | -- Fortunato Depero, 1929. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 17 02:55:41 2017 Received: (at submit) by debbugs.gnu.org; 17 Nov 2017 07:55:42 +0000 Received: from localhost ([127.0.0.1]:44155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFbUz-0005y8-Mw for submit@debbugs.gnu.org; Fri, 17 Nov 2017 02:55:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFbUy-0005xw-88 for submit@debbugs.gnu.org; Fri, 17 Nov 2017 02:55:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFbUs-0006RD-4f for submit@debbugs.gnu.org; Fri, 17 Nov 2017 02:55:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:32930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eFbUs-0006Qy-1Y for submit@debbugs.gnu.org; Fri, 17 Nov 2017 02:55:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFbUq-0003Es-2V for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 02:55:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFbUn-0006LT-0a for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 02:55:32 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:49708) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eFbUm-0006Je-Lg for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2017 02:55:28 -0500 Received: from [192.168.178.35] ([77.12.50.13]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.183]) with ESMTPSA (Nemesis) id 0M57wk-1f6s0R23n4-00zDST for ; Fri, 17 Nov 2017 08:55:25 +0100 Subject: Re: bug#29304: py-indent-line comes from the external python-mode To: bug-gnu-emacs@gnu.org References: <87bmk3x5h4.fsf@metapensiero.it> <87inebah4m.fsf@metapensiero.it> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <3318a66e-7b8c-8c6a-2170-c2e4cd98902c@online.de> Date: Fri, 17 Nov 2017 09:13:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87inebah4m.fsf@metapensiero.it> Content-Type: multipart/alternative; boundary="------------6FB5FE31B86EA8871380187D" Content-Language: en-US X-Provags-ID: V03:K0:mp8168lgpx+6rq3XfvcXrbqBe4YuOSDTJDrzz2Azph1dvm4lzMx KI8Kw1i77RLgrN8n1TJWjr2BCKhYI/StBWhkwUouxdEZFa0L8Ja8PeZIW1ap/xpFIDl/5TU GBeHtCjX0e2Kx9wDSHs8VcQ8UA3SNp0ulSRxpjIMjwyBBbmVhttiVvigkpkVjoBEvXrGvCN 4dHR4swR5EzyOdWGNJkpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Phqr+Eq7DGI=:W6dL4Exe8kYJJ+63NL+0kY G7Ped/FbmsnTf0LCu2pmmxmsFxZt4eXD1GWNgbJVxdYkJeLCWduCi1Pplg3r/+TK4SCDWVSrr BXqLXnCy+vxDMdN1gtxWKxtHt+6RhWA0Drf66N8dUg5oME40z8HSIn9gKfw5EDH13qZki1Miy z+EzSxrx+yfmnnBFj9mQqF+5l+7/PpCJmGsr8AL5EtD+jK11sasdga8LiO53qYSsgUBq/E5Xd EZQXFKrP72l7l2pP2q+KEVlXlSZUvSVM3wDZhaXeqE1n1aEBSFZf/43Ij47GUh2Bn+siFlTcI T4LUm2D4l1zeKQ8E+TnNSoptZWOMPr5AmmjUItkJvh2DWRzAeDqAIvrygb83G2K3/60fdy9fz Qrx5edvWZz1CTSVAb48I7Uez4yZVeXkFQbaN1bXydxAZdXnSlzWUkscsQPl/XaUiY93ecV+AA LFSL72vqlAT1Qb8Iu5JJych8x8FTBy0szYz1nGY4Mrd2uGM5ag9yoUjMByVMsrrampp9dI54U vacwk5624n/AJ5qFhIaepODmO4aIfKjOiQLNtWoaOfzo1mWPPNKD9CH09Q5rPl8gYFXMKKF6H oW0wzskaVV7nBwPx0Fc2WtNZczQ+K2jEd58nzf6hxuhbMEQOPSPvAciGOwrY9G/rW00mxH0yw hjZ5+A1c6rDQzFdHbq5/Hp3nbZ8ExmDh+5I/CdY1+N91bL0O/mOdDLvtKzTM2+alXcjgw+vzy Tu6bVimIGVg2sRzyxnlc/fVCoY6AO00M/LNY1e+algjPnBcRO7YhUjjAB+Ljh/q60XzCAlDx+ CUhWCKO X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------6FB5FE31B86EA8871380187D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 15.11.2017 12:58, Lele Gaifax wrote: > Further investigation reveals that the external python-mode (that is, > https://gitlab.com/python-mode-devs/python-mode) effectively implements the > `py-indent-line' function, so that was the target. > > I guess the attached patch should be ignored. > > The docstring typo seems real, though. Hi Lele, could not reproduce the bug. BTW python-mode.el doesn't provide an electric indent at comma. At any case it should not get in the way of python.el. Bug reports are welcome at https://gitlab.com/python-mode-devs/python-mode/issues --------------6FB5FE31B86EA8871380187D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit



On 15.11.2017 12:58, Lele Gaifax wrote:
Further investigation reveals that the external python-mode (that is,
https://gitlab.com/python-mode-devs/python-mode) effectively implements the
`py-indent-line' function, so that was the target.

I guess the attached patch should be ignored.

The docstring typo seems real, though.

Hi Lele,

could not reproduce the bug.

BTW python-mode.el doesn't provide an electric indent at comma.
At any case it should not get in the way of python.el.
Bug reports are welcome at

https://gitlab.com/python-mode-devs/python-mode/issues


--------------6FB5FE31B86EA8871380187D-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 18 06:47:49 2017 Received: (at 29304-done) by debbugs.gnu.org; 18 Nov 2017 11:47:49 +0000 Received: from localhost ([127.0.0.1]:45618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG1bB-0002XK-A2 for submit@debbugs.gnu.org; Sat, 18 Nov 2017 06:47:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG1bA-0002X8-23 for 29304-done@debbugs.gnu.org; Sat, 18 Nov 2017 06:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eG1b1-0004PH-Td for 29304-done@debbugs.gnu.org; Sat, 18 Nov 2017 06:47:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eG1b1-0004PD-QB; Sat, 18 Nov 2017 06:47:39 -0500 Received: from [176.228.60.248] (port=4677 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eG1b1-0005av-8b; Sat, 18 Nov 2017 06:47:39 -0500 Date: Sat, 18 Nov 2017 13:47:26 +0200 Message-Id: <83o9nzg65t.fsf@gnu.org> From: Eli Zaretskii To: Lele Gaifax In-reply-to: <87bmk3x5h4.fsf@metapensiero.it> (message from Lele Gaifax on Wed, 15 Nov 2017 10:21:11 +0100) Subject: Re: bug#29304: 26.0.90; Typos in electric.el, with patch References: <87bmk3x5h4.fsf@metapensiero.it> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29304-done Cc: 29304-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Lele Gaifax > Date: Wed, 15 Nov 2017 10:21:11 +0100 > > There are two typos in the definition of the variable > `electric-indent-functions-without-reindent' in lisp/electric.el: > > - its docstring mentions a non existing `line-indent-function' instead of the > correct `indent-line-function'; Fixed, thanks. From unknown Tue Sep 23 15:45:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Dec 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator