From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 0/2] gexp: Add 'let-system' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Nov 2017 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 29296@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151067635910548 (code B ref -1); Tue, 14 Nov 2017 16:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2017 16:19:19 +0000 Received: from localhost ([127.0.0.1]:40384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEdvi-0002k1-Uj for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEdvg-0002j4-DD for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEdvY-0003cg-L4 for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEdvY-0003cI-IP for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEdvV-00070j-6M for guix-patches@gnu.org; Tue, 14 Nov 2017 11:19:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEdvR-0003SM-BD for guix-patches@gnu.org; Tue, 14 Nov 2017 11:19:05 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEdvJ-0003Kt-0I; Tue, 14 Nov 2017 11:18:53 -0500 Received: from [193.50.110.148] (port=53418 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eEdvI-0007Lh-Fc; Tue, 14 Nov 2017 11:18:52 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 14 Nov 2017 17:18:41 +0100 Message-Id: <20171114161841.8485-1-ludo@gnu.org> X-Mailer: git-send-email 2.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! This patch adds the ‘let-system’ form to (guix gexp), as discussed with Mathieu at . It allows you to insert system-dependent code inside a gexp, as in this example: #~(system* #+(let-system system (cond ((string-prefix? "armhf-" system) (file-append qemu "/bin/qemu-system-arm")) ((string-prefix? "x86_64-" system) (file-append qemu "/bin/qemu-system-x86_64")) (else (error "dunno!")))) "-net" "user" #$image) (Using (%current-system) and (%current-target-system) does *not* achieve this, in case you’re wondering, because at the time the gexp is defined they carry their default value.) Feedback welcome! Ludo’. Ludovic Courtès (2): gexp: Compilers can now return lowerable objects. gexp: Add 'let-system'. doc/guix.texi | 26 ++++++++++++++ guix/gexp.scm | 105 ++++++++++++++++++++++++++++++++++++++++++++++++--------- tests/gexp.scm | 50 +++++++++++++++++++++++++++ 3 files changed, 165 insertions(+), 16 deletions(-) -- 2.15.0 From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 1/2] gexp: Compilers can now return lowerable objects. References: <20171114161841.8485-1-ludo@gnu.org> In-Reply-To: <20171114161841.8485-1-ludo@gnu.org> Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Nov 2017 16:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 29296@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe Received: via spool by 29296-submit@debbugs.gnu.org id=B29296.151067674111543 (code B ref 29296); Tue, 14 Nov 2017 16:26:01 +0000 Received: (at 29296) by debbugs.gnu.org; 14 Nov 2017 16:25:41 +0000 Received: from localhost ([127.0.0.1]:40412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEe1t-000307-HN for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:25:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEe1r-0002zs-CI for 29296@debbugs.gnu.org; Tue, 14 Nov 2017 11:25:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEe1i-0002Ta-VZ for 29296@debbugs.gnu.org; Tue, 14 Nov 2017 11:25:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEe1g-0002Rs-Hj; Tue, 14 Nov 2017 11:25:28 -0500 Received: from [193.50.110.148] (port=53574 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eEe1g-0007zj-2Q; Tue, 14 Nov 2017 11:25:28 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 14 Nov 2017 17:25:14 +0100 Message-Id: <20171114162515.8743-1-ludo@gnu.org> X-Mailer: git-send-email 2.15.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * guix/gexp.scm (lower-object): Iterate if LOWERED is a struct. (lower+expand-object): New procedure. (gexp->sexp): Use it. (define-gexp-compiler): Adjust docstring. --- guix/gexp.scm | 54 +++++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index b9525603e..c2d942c7f 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -195,24 +195,50 @@ procedure to expand it; otherwise return #f." corresponding to OBJ for SYSTEM, cross-compiling for TARGET if TARGET is true. OBJ must be an object that has an associated gexp compiler, such as a ." - (match (lookup-compiler obj) - (#f - (raise (condition (&gexp-input-error (input obj))))) - (lower - (lower obj system target)))) + (let loop ((obj obj)) + (match (lookup-compiler obj) + (#f + (raise (condition (&gexp-input-error (input obj))))) + (lower + (mlet %store-monad ((lowered (lower obj system target))) + (if (and (struct? lowered) (not (eq? lowered obj))) + (loop lowered) + (return lowered))))))) + +(define* (lower+expand-object obj + #:optional (system (%current-system)) + #:key target (output "out")) + "Return as a value in %STORE-MONAD the output of object OBJ expands to for +SYSTEM and TARGET. Object such as , , or +expand to file names, but it's possible to expand to a plain data type." + (let loop ((obj obj) + (expand (and (struct? obj) (lookup-expander obj)))) + (match (lookup-compiler obj) + (#f + (raise (condition (&gexp-input-error (input obj))))) + (lower + (mlet %store-monad ((lowered (lower obj system target))) + ;; LOWER might return something that needs to be further lowered. + (if (struct? lowered) + ;; If we lack an expander, delegate to that of LOWERED. + (if (not expand) + (loop lowered (lookup-expander lowered)) + (return (expand obj lowered output))) + (return lowered))))))) ;lists, vectors, etc. (define-syntax define-gexp-compiler (syntax-rules (=> compiler expander) "Define NAME as a compiler for objects matching PREDICATE encountered in gexps. -In the simplest form of the macro, BODY must return a derivation for PARAM, an -object that matches PREDICATE, for SYSTEM and TARGET (the latter of which is -#f except when cross-compiling.) +In the simplest form of the macro, BODY must return (1) a derivation for +a record of the specified type, for SYSTEM and TARGET (the latter of which is +#f except when cross-compiling), (2) another record that can itself be +compiled down to a derivation, or (3) an object of a primitive data type. The more elaborate form allows you to specify an expander: - (define-gexp-compiler something something? + (define-gexp-compiler something-compiler compiler => (lambda (param system target) ...) expander => (lambda (param drv output) ...)) @@ -795,12 +821,10 @@ and in the current monad setting (system type, etc.)" (or n? native?))) refs))) (($ (? struct? thing) output n?) - (let ((target (if (or n? native?) #f target)) - (expand (lookup-expander thing))) - (mlet %store-monad ((obj (lower-object thing system - #:target target))) - ;; OBJ must be either a derivation or a store file name. - (return (expand thing obj output))))) + (let ((target (if (or n? native?) #f target))) + (lower+expand-object thing system + #:target target + #:output output))) (($ x) (return x)) (x -- 2.15.0 From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 2/2] gexp: Add 'let-system'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Nov 2017 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 29296@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe Received: via spool by 29296-submit@debbugs.gnu.org id=B29296.151067674611563 (code B ref 29296); Tue, 14 Nov 2017 16:26:02 +0000 Received: (at 29296) by debbugs.gnu.org; 14 Nov 2017 16:25:46 +0000 Received: from localhost ([127.0.0.1]:40415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEe1x-00030R-RX for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:25:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEe1v-0002zy-RC for 29296@debbugs.gnu.org; Tue, 14 Nov 2017 11:25:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEe1k-0002U9-ED for 29296@debbugs.gnu.org; Tue, 14 Nov 2017 11:25:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEe1h-0002SR-Ha; Tue, 14 Nov 2017 11:25:29 -0500 Received: from [193.50.110.148] (port=53574 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eEe1g-0007zj-Vg; Tue, 14 Nov 2017 11:25:29 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 14 Nov 2017 17:25:15 +0100 Message-Id: <20171114162515.8743-2-ludo@gnu.org> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171114162515.8743-1-ludo@gnu.org> References: <20171114162515.8743-1-ludo@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * guix/gexp.scm (): New record type. (let-system): New macro. (system-binding-compiler): New procedure. (default-expander): Add catch-all case. * tests/gexp.scm ("let-system", "let-system, target") ("let-system, ungexp-native, target") ("let-system, nested"): New tests. * doc/guix.texi (G-Expressions): Document it. --- doc/guix.texi | 26 ++++++++++++++++++++++++++ guix/gexp.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++- tests/gexp.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 126 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 098ff5e54..0e795ada6 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -4799,6 +4799,32 @@ procedures called from @var{body}@dots{}. Return @code{#t} if @var{obj} is a G-expression. @end deffn +@deffn {Scheme Syntax} let-system @var{system} @var{body}@dots{} +@deffnx {Scheme Syntax} let-system (@var{system} @var{target}) @var{body}@dots{} +Bind @var{system} to the currently targeted system---e.g., +@code{"x86_64-linux"}---within @var{body}. + +In the second case, additionally bind @var{target} to the current +cross-compilation target---a GNU triplet such as +@code{"arm-linux-gnueabihf"}---or @code{#f} if we are not +cross-compiling. + +@code{let-system} is useful in the occasional case where the object +spliced into the gexp depends on the target system, as in this example: + +@example +#~(system* + #+(let-system system + (cond ((string-prefix? "armhf-" system) + (file-append qemu "/bin/qemu-system-arm")) + ((string-prefix? "x86_64-" system) + (file-append qemu "/bin/qemu-system-x86_64")) + (else + (error "dunno!")))) + "-net" "user" #$image) +@end example +@end deffn + G-expressions are meant to be written to disk, either as code building some derivation, or as plain files in the store. The monadic procedures below allow you to do that (@pxref{The Store Monad}, for more diff --git a/guix/gexp.scm b/guix/gexp.scm index c2d942c7f..c65c6e5f3 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -32,6 +32,7 @@ #:export (gexp gexp? with-imported-modules + let-system gexp-input gexp-input? @@ -169,7 +170,9 @@ returns its output file name of OBJ's OUTPUT." ((? derivation? drv) (derivation->output-path drv output)) ((? string? file) - file))) + file) + (obj ;lists, vectors, etc. + obj))) (define (register-compiler! compiler) "Register COMPILER as a gexp compiler." @@ -262,6 +265,52 @@ The expander specifies how an object is converted to its sexp representation." (return drv))) +;;; +;;; System dependencies. +;;; + +;; Binding form for the current system and cross-compilation target. +(define-record-type + (system-binding proc) + system-binding? + (proc system-binding-proc)) + +(define-syntax let-system + (syntax-rules () + "Introduce a system binding in a gexp. The simplest form is: + + (let-system system + (cond ((string=? system \"x86_64-linux\") ...) + (else ...))) + +which binds SYSTEM to the currently targeted system. The second form is +similar, but it also shows the cross-compilation target: + + (let-system (system target) + ...) + +Here TARGET is bound to the cross-compilation triplet or #f." + ((_ (system target) exp0 exp ...) + (system-binding (lambda (system target) + exp0 exp ...))) + ((_ system exp0 exp ...) + (system-binding (lambda (system target) + exp0 exp ...))))) + +(define-gexp-compiler system-binding-compiler + compiler => (lambda (binding system target) + (match binding + (($ proc) + (with-monad %store-monad + ;; PROC is expected to return a lowerable object. + ;; 'lower-object' takes care of residualizing it to a + ;; derivation or similar. + (return (proc system target)))))) + + ;; Delegate to the expander of the object returned by PROC. + expander => #f) + + ;;; ;;; File declarations. ;;; diff --git a/tests/gexp.scm b/tests/gexp.scm index 5873abdd4..f98d1e70e 100644 --- a/tests/gexp.scm +++ b/tests/gexp.scm @@ -258,6 +258,56 @@ (((thing "out")) (eq? thing file)))))) +(test-equal "let-system" + (list `(begin ,(%current-system) #t) '(system-binding) '()) + (let ((exp #~(begin + #$(let-system system system) + #t))) + (list (gexp->sexp* exp) + (match (gexp-inputs exp) + (((($ (@@ (guix gexp) )) "out")) + '(system-binding)) + (x x)) + (gexp-native-inputs exp)))) + +(test-equal "let-system, target" + (list `(list ,(%current-system) #f) + `(list ,(%current-system) "aarch64-linux-gnu")) + (let ((exp #~(list #$@(let-system (system target) + (list system target))))) + (list (gexp->sexp* exp) + (gexp->sexp* exp "aarch64-linux-gnu")))) + +(test-equal "let-system, ungexp-native, target" + `(here it is: ,(%current-system) #f) + (let ((exp #~(here it is: #+@(let-system (system target) + (list system target))))) + (gexp->sexp* exp "aarch64-linux-gnu"))) + +(test-equal "let-system, nested" + (list `(system* ,(string-append "qemu-system-" (%current-system)) + "-m" "256") + '() + '(system-binding)) + (let ((exp #~(system* + #+(let-system (system target) + (file-append (@@ (gnu packages virtualization) + qemu) + "/bin/qemu-system-" + system)) + "-m" "256"))) + (list (match (gexp->sexp* exp) + (('system* command rest ...) + `(system* ,(and (string-prefix? (%store-prefix) command) + (basename command)) + ,@rest)) + (x x)) + (gexp-inputs exp) + (match (gexp-native-inputs exp) + (((($ (@@ (guix gexp) )) "out")) + '(system-binding)) + (x x))))) + (test-assert "ungexp + ungexp-native" (let* ((exp (gexp (list (ungexp-native %bootstrap-guile) (ungexp coreutils) -- 2.15.0 From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 2/2] gexp: Add 'let-system'. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Nov 2017 11:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29296@debbugs.gnu.org Received: via spool by 29296-submit@debbugs.gnu.org id=B29296.151074524932326 (code B ref 29296); Wed, 15 Nov 2017 11:28:02 +0000 Received: (at 29296) by debbugs.gnu.org; 15 Nov 2017 11:27:29 +0000 Received: from localhost ([127.0.0.1]:41036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEvqq-0008PK-T7 for submit@debbugs.gnu.org; Wed, 15 Nov 2017 06:27:29 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEvqo-0008P7-P3 for 29296@debbugs.gnu.org; Wed, 15 Nov 2017 06:27:27 -0500 Received: by mail-wm0-f68.google.com with SMTP id r68so2296309wmr.1 for <29296@debbugs.gnu.org>; Wed, 15 Nov 2017 03:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=esQGZTkaKLwPThfCQiVOcfDoaVRK/1S0lxhU+WvqGRs=; b=Mwje9rjuXl4mYhG5SiUWOhAArSpqU9zqNjsofRrmVGRJ0pdAH5e70ATCbwu4IiX3L2 1sdQavHh9W6kMnlVmczJW4+gG2QeORlsPYXOFxp2IyXpHarr9pKuXmO2gIH3+b65kg2A NWjhWZ+DJRhy4YcbcTR9oB0zwWL8UY1KGFIGioi4eIMT4Hq0lb8MgPqM4Q4dvZ6+FJ7U AqflaT5GAHHj4aoeCae9FFa6a+f/FmkU1XIflG7np6mki+jeZFXhQmTbc9webXQMG1la dq5sPmTHR9jmOzViEEZM5v5cUevGassq9VJO/a6UqfxIla+lvbREHPaZqb+gRazghfCs O7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=esQGZTkaKLwPThfCQiVOcfDoaVRK/1S0lxhU+WvqGRs=; b=cpaQMgC+y44Z5zhf1xvyaElivgFxET0eVzrStMfVJg0VChgOFPWnnJOgWf66r65Xzb r8X3hHlz8bEFHnKw4AI11xahwuDEqTiyduqQpJquB1YC3FpKYXjMaxCZbrOK7MHqta1A qzAHMJvkFcIp6D0EWMGngEhYnejLSM9wYLkulJzVye8eLzaO75PqRDmdntC6upp0V3w0 r3RoK08Mu0kJgOly03CGbswpy2b5kwgzUP+0BEwnXzKUF6kurD4y1apijINNC1OCb1SM +e/lW6nD9YBiYasqY4jlQEDdIBqZmAk7Z+81SJ5pnOYWy0MXBXVSnzxAYQSuoC5fDhzo yzNw== X-Gm-Message-State: AJaThX6xmYH9shoNQMToRN2JiAp9K4HlnoZIZDNv9DwDC0xoajf6yQ0e lhlJWk/SC0LCOyJ+We4rzNcobw== X-Google-Smtp-Source: AGs4zMYNqK8H/xGE1TGpuniVpo3npoa3HG3jLV2+e913bduQgXJVdzI8PugaKW1/yatUXgyeFOeuQA== X-Received: by 10.28.227.136 with SMTP id a130mr8498767wmh.104.1510745240587; Wed, 15 Nov 2017 03:27:20 -0800 (PST) Received: from denali ([46.218.109.88]) by smtp.gmail.com with ESMTPSA id x75sm17095930wme.29.2017.11.15.03.27.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Nov 2017 03:27:19 -0800 (PST) References: <20171114162515.8743-1-ludo@gnu.org> <20171114162515.8743-2-ludo@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Mathieu Othacehe In-reply-to: <20171114162515.8743-2-ludo@gnu.org> Date: Wed, 15 Nov 2017 12:27:16 +0100 Message-ID: <87fu9fsrxn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Ludo, I must admit i don't have a perfect understanding of what is going on in gexp.scm but your serie LGTM. When diffing with the initial patch it seems that the entry in .dir-locals.el is gone but it is a minor point. About the integration of let-system in "system-disk-image", i'm not sure how to proceed. let-system is meant to be used in a gexp but the operating-system is not defined in a gexp. Do you have any advice on how to turn os declaration into a gexp so that i can use let-system to parameterize kernel field ? Thanks, Mathieu From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 2/2] gexp: Add 'let-system'. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Nov 2017 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 29296@debbugs.gnu.org Received: via spool by 29296-submit@debbugs.gnu.org id=B29296.151082346229698 (code B ref 29296); Thu, 16 Nov 2017 09:12:02 +0000 Received: (at 29296) by debbugs.gnu.org; 16 Nov 2017 09:11:02 +0000 Received: from localhost ([127.0.0.1]:42543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFGCL-0007ip-QA for submit@debbugs.gnu.org; Thu, 16 Nov 2017 04:11:02 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:45384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFGCK-0007iZ-BX for 29296@debbugs.gnu.org; Thu, 16 Nov 2017 04:11:00 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DA83AF15B; Thu, 16 Nov 2017 10:11:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jZuPMeiCS8DK; Thu, 16 Nov 2017 10:11:01 +0100 (CET) Received: from ribbon (unknown [193.50.110.175]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0D7C99A5E; Thu, 16 Nov 2017 10:11:00 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171114162515.8743-1-ludo@gnu.org> <20171114162515.8743-2-ludo@gnu.org> <87fu9fsrxn.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Brumaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 16 Nov 2017 10:10:58 +0100 In-Reply-To: <87fu9fsrxn.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 15 Nov 2017 12:27:16 +0100") Message-ID: <87mv3mk2ql.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Mathieu, Mathieu Othacehe skribis: > I must admit i don't have a perfect understanding of what is going on in > gexp.scm but your serie LGTM. > > When diffing with the initial patch it seems that the entry in > .dir-locals.el is gone but it is a minor point. Oops. > About the integration of let-system in "system-disk-image", i'm not sure > how to proceed. let-system is meant to be used in a gexp but the > operating-system is not defined in a gexp. > > Do you have any advice on how to turn os declaration into a gexp so that > i can use let-system to parameterize kernel field ? The idea is that you can write: (kernel (let-system system (if (string-prefix? "arm-" system) linux-libre-arm linux-libre))) and things will just work. Now I found a couple of issues. First one is addressed with the patch below. Second one is trickier: (file-append (let-system =E2=80=A6) =E2=80= =A6), as is used to compute the kernel file name, doesn=E2=80=99t work due to the way t= he expander works. I=E2=80=99ll see what I can do. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/system.scm b/gnu/system.scm index 9e05c4b21..a4804cf86 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -876,10 +876,12 @@ listed in OS. The C library expects to find it under (define (kernel->boot-label kernel) "Return a label for the bootloader menu entry that boots KERNEL." - (string-append "GNU with " - (string-titlecase (package-name kernel)) " " - (package-version kernel) - " (beta)")) + (if (package? kernel) + (string-append "GNU with " + (string-titlecase (package-name kernel)) " " + (package-version kernel) + " (beta)") + "GNU GuixSD (beta)")) (define (store-file-system file-systems) "Return the file system object among FILE-SYSTEMS that contains the store." --=-=-=-- From unknown Tue Sep 23 05:52:57 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#29296: closed (Re: bug#41120: uvesafb service is unsupported on aarch64) Message-ID: References: <87sgg0stt5.fsf@gnu.org> <20171114161841.8485-1-ludo@gnu.org> X-Gnu-PR-Message: they-closed 29296 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 29296@debbugs.gnu.org Date: Fri, 15 May 2020 22:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1589582642-13495-1" This is a multi-part message in MIME format... ------------=_1589582642-13495-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29296: [PATCH 0/2] gexp: Add 'let-system' which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29296@debbugs.gnu.org. --=20 29296: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29296 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1589582642-13495-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29296-done) by debbugs.gnu.org; 15 May 2020 22:43:48 +0000 Received: from localhost ([127.0.0.1]:39078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZj3Q-0003Uq-LD for submit@debbugs.gnu.org; Fri, 15 May 2020 18:43:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZj3P-0003Uc-Ah; Fri, 15 May 2020 18:43:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52450) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZj3J-0004LP-PI; Fri, 15 May 2020 18:43:37 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59400 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jZj3I-0008C9-Qq; Fri, 15 May 2020 18:43:37 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#41120: uvesafb service is unsupported on aarch64 References: <20200507054015.GG2359@E5400> <87wo5ody1e.fsf@gmail.com> <20200507081234.GJ2359@E5400> <20200507145511.zfw5474uzecs2oum@pelzflorian.localdomain> <20200507145801.nmedsi44wtparffh@pelzflorian.localdomain> <875zd6lro0.fsf@gmail.com> <87blms3snh.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Flor=C3=A9al?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 16 May 2020 00:43:34 +0200 In-Reply-To: <87blms3snh.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 13 May 2020 14:50:58 +0200") Message-ID: <87sgg0stt5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29296-done Cc: 29296-done@debbugs.gnu.org, janneke@gnu.org, "pelzflorian \(Florian Pelz\)" , 41120@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Mathieu, Mathieu Othacehe skribis: > Here's a rebased version of Ludo's patch. I'm not sure about the merge > resolution in "lower-object", but otherwise it works fine! I took another look, and you=E2=80=99re right, it does the job. There were= a couple of issues: returning a self-quoting value as in (let-system s s) wouldn=E2=80=99t work, and also caching wasn=E2=80=99t quite right (could b= e seen by comparing GUIX_PROFILING=3D"add-data-to-store-cache object-cache" before and after). Anyway, it took me much more time than I thought, but it=E2=80=99s here now: 502f609d05 vm: Use 'let-system'. 300a54bb98 utils: 'target-arm32?' & co. take an optional parameter. 644cb40cd8 gexp: Add 'let-system'. d03001a31a gexp: Compilers can now return lowerable objects. Let me know how it goes! Ludo=E2=80=99. ------------=_1589582642-13495-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Nov 2017 16:19:19 +0000 Received: from localhost ([127.0.0.1]:40384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEdvi-0002k1-Uj for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEdvg-0002j4-DD for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEdvY-0003cg-L4 for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEdvY-0003cI-IP for submit@debbugs.gnu.org; Tue, 14 Nov 2017 11:19:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEdvV-00070j-6M for guix-patches@gnu.org; Tue, 14 Nov 2017 11:19:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEdvR-0003SM-BD for guix-patches@gnu.org; Tue, 14 Nov 2017 11:19:05 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEdvJ-0003Kt-0I; Tue, 14 Nov 2017 11:18:53 -0500 Received: from [193.50.110.148] (port=53418 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eEdvI-0007Lh-Fc; Tue, 14 Nov 2017 11:18:52 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] gexp: Add 'let-system' Date: Tue, 14 Nov 2017 17:18:41 +0100 Message-Id: <20171114161841.8485-1-ludo@gnu.org> X-Mailer: git-send-email 2.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= , Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! This patch adds the ‘let-system’ form to (guix gexp), as discussed with Mathieu at . It allows you to insert system-dependent code inside a gexp, as in this example: #~(system* #+(let-system system (cond ((string-prefix? "armhf-" system) (file-append qemu "/bin/qemu-system-arm")) ((string-prefix? "x86_64-" system) (file-append qemu "/bin/qemu-system-x86_64")) (else (error "dunno!")))) "-net" "user" #$image) (Using (%current-system) and (%current-target-system) does *not* achieve this, in case you’re wondering, because at the time the gexp is defined they carry their default value.) Feedback welcome! Ludo’. Ludovic Courtès (2): gexp: Compilers can now return lowerable objects. gexp: Add 'let-system'. doc/guix.texi | 26 ++++++++++++++ guix/gexp.scm | 105 ++++++++++++++++++++++++++++++++++++++++++++++++--------- tests/gexp.scm | 50 +++++++++++++++++++++++++++ 3 files changed, 165 insertions(+), 16 deletions(-) -- 2.15.0 ------------=_1589582642-13495-1-- From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] bug#41120: uvesafb service is unsupported on aarch64 Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 May 2020 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29296-done@debbugs.gnu.org, 41120@debbugs.gnu.org Received: via spool by 29296-done@debbugs.gnu.org id=D29296.1589804222811 (code D ref 29296); Mon, 18 May 2020 12:18:02 +0000 Received: (at 29296-done) by debbugs.gnu.org; 18 May 2020 12:17:02 +0000 Received: from localhost ([127.0.0.1]:46166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaehM-0000CT-1B for submit@debbugs.gnu.org; Mon, 18 May 2020 08:17:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaehK-0000CC-6b; Mon, 18 May 2020 08:16:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56405) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaehF-0005ps-15; Mon, 18 May 2020 08:16:41 -0400 Received: from lfbn-ann-1-238-30.w86-200.abo.wanadoo.fr ([86.200.197.30]:46138 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jaehE-00046E-A4; Mon, 18 May 2020 08:16:40 -0400 From: Mathieu Othacehe References: <20200507054015.GG2359@E5400> <87wo5ody1e.fsf@gmail.com> <20200507081234.GJ2359@E5400> <20200507145511.zfw5474uzecs2oum@pelzflorian.localdomain> <20200507145801.nmedsi44wtparffh@pelzflorian.localdomain> <875zd6lro0.fsf@gmail.com> <87blms3snh.fsf@gnu.org> <87sgg0stt5.fsf@gnu.org> Date: Mon, 18 May 2020 14:16:36 +0200 In-Reply-To: <87sgg0stt5.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 16 May 2020 00:43:34 +0200") Message-ID: <87o8qlfnff.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Ludo, > Anyway, it took me much more time than I thought, but it=E2=80=99s here n= ow: > > 502f609d05 vm: Use 'let-system'. > 300a54bb98 utils: 'target-arm32?' & co. take an optional parameter. > 644cb40cd8 gexp: Add 'let-system'. > d03001a31a gexp: Compilers can now return lowerable objects. > > Let me know how it goes! Thanks a lot, it's a great addition. I plan to use it soon to have kernel/architecture specific services, as I proposed earlier in this thread. Mathieu From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 2/2] gexp: Add 'let-system'. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 May 2020 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Mathieu Othacehe , 29296@debbugs.gnu.org Received: via spool by 29296-submit@debbugs.gnu.org id=B29296.159018750912416 (code B ref 29296); Fri, 22 May 2020 22:46:01 +0000 Received: (at 29296) by debbugs.gnu.org; 22 May 2020 22:45:09 +0000 Received: from localhost ([127.0.0.1]:60657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcGPd-0003EB-GF for submit@debbugs.gnu.org; Fri, 22 May 2020 18:45:09 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:57428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcGPc-0003E2-2q for 29296@debbugs.gnu.org; Fri, 22 May 2020 18:45:08 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 9F1743367B08; Sat, 23 May 2020 00:45:05 +0200 (CEST) Date: Sat, 23 May 2020 00:44:34 +0200 From: Danny Milosavljevic Message-ID: <20200523004434.059d1960@scratchpost.org> In-Reply-To: <87mv3mk2ql.fsf@gnu.org> References: <20171114162515.8743-1-ludo@gnu.org> <20171114162515.8743-2-ludo@gnu.org> <87fu9fsrxn.fsf@gmail.com> <87mv3mk2ql.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/uXo.SvER5LRYD5PCHhR1jCz"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/uXo.SvER5LRYD5PCHhR1jCz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Ludo, maybe a little off-topic, but why do I have to use the following patch on armhf-linux (*not* cross compiling) in order to stop it from pulling in i686-cross-gcc? Makes no sense to me at all... diff --git a/gnu/packages/mes.scm b/gnu/packages/mes.scm index 347aef0..524b8e8 100644 --- a/gnu/packages/mes.scm +++ b/gnu/packages/mes.scm @@ -120,8 +120,9 @@ extensive examples, including parsers for the Javascrip= t and C99 languages.") ((string-prefix? "x86_64-linux" target-system) ;; Use cross-compiler rather than #:system "i686-linux" to get ;; MesCC 64 bit .go files installed ready for use with Guile. - `(("i686-linux-binutils" ,(cross-binutils "i686-unknown-linux= -gnu")) - ("i686-linux-gcc" ,(cross-gcc "i686-unknown-linux-gnu")))) + `( ;("i686-linux-binutils" ,(cross-binutils "i686-unknown-lin= ux-gnu")) + ;("i686-linux-gcc" ,(cross-gcc "i686-unknown-linux-gnu")) +)) (else '()))) ("graphviz" ,graphviz) --Sig_/uXo.SvER5LRYD5PCHhR1jCz Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl7IVdIACgkQ5xo1VCww uqXbMwf/dADyXhUuoZzv+Z9Wiqj7hH2lqWmg4usmpUx3ZLAPNti2b24e1KBGO4m6 8UlSB8A9T2wCZ/kBp1Ivl1B4bSzvQppEIc2Qnov+hb0ic6l7XfC42IvNs3EdQzm8 ETj355f7eSdGJyqjgw5Oigc4pPxeV57lKWHNMyCbrD+JUqx2fwxzUM3Xea+BOIjf fljPvz38a11OIXnkVwNkLKLCfWV3MBl/IwaPfdIa5r2EcuZK41kMxmMmXZsipxEa fCyWDAlewBl6hBnSF1ZUtMuioa44bLx11Ix+evsZ3hnExdlgVd0NGGP/kw1al9QK CdGUv2Jx9ERqsaoKt8+ryJSrKZWiLw== =mAwS -----END PGP SIGNATURE----- --Sig_/uXo.SvER5LRYD5PCHhR1jCz-- From unknown Tue Sep 23 05:52:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29296] [PATCH 2/2] gexp: Add 'let-system'. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 May 2020 23:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29296 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mathieu Othacehe , 29296@debbugs.gnu.org Received: via spool by 29296-submit@debbugs.gnu.org id=B29296.159018848514326 (code B ref 29296); Fri, 22 May 2020 23:02:02 +0000 Received: (at 29296) by debbugs.gnu.org; 22 May 2020 23:01:25 +0000 Received: from localhost ([127.0.0.1]:60778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcGfN-0003j0-DR for submit@debbugs.gnu.org; Fri, 22 May 2020 19:01:25 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcGfL-0003io-WF for 29296@debbugs.gnu.org; Fri, 22 May 2020 19:01:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D484A5C008E; Fri, 22 May 2020 19:01:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 22 May 2020 19:01:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=2yKUw4jWHpeZKVhvFsS22WJegU LA/Ti8qvmGJMCmfrs=; b=gkk5pAQC0V689x7ztpa4MEorzJ7NIs3Yo1XWlngKe1 oTHhcNeefqIIzhSA1GcqZ5Dcx8a7I+QH2SJnWDMMGInnZuEkl8PGVQW1HveOAuqm 8cpF9ZkabD60bP+HJ2VGlT+MBovKQYT6NvLhcmf0b1FWYEx/utYiI7ll5Hpr5LgR Jy12NB43crrg7LAzRl1rx7i6tvOV4qzugRsOWEt4a/bVB9mtNKHOmzGOqiigeFgI HgC/ktIMj/mUR3konDOlz4G3R1mYYFB6eCCkZch3E8Eqd8iic++b2ryVUMMKAIA/ RLACYutUjPcPDBa8dTg/VqNYVOUi7K9fOdpjG0u197jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2yKUw4 jWHpeZKVhvFsS22WJegULA/Ti8qvmGJMCmfrs=; b=gfJ/dplghXsZwlwDpZ45Gh lPC5qDav56ydMtgDlof7z1oFvH5+QSLxBOBYmoKqyke08RRqFfbU3VG+1r8aK76F r0SnmqDcv1j4QebXQE/ahPG4WFlrKPLNhp8gZneiSJkd6m7cyVDeiGJ5VnrrL+J0 EzkmMblEc8ZpKZ256TTPiidHkdu01zFKbMZv98h40Pr4NtsMe7OdlZfxlmR1P74/ mLkbK9xk7RG0//qpcNSUZ/n6byZWKvhqpGxrYLqI1NmgdvhfpSjuDU8AoQXCaIX7 WDtK2fxgu+jbYGlLih2qolWUKqQRckSrGa/euNF6rZOusMTl5pM8Ap6MyrkYPiaA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddugedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehgtderredtredtnecuhfhrohhmpeforghrihhu shcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpedtvdfggeevgeeivdffueejiedttedvkedtudfggfdtgeefiedtieekffdu gfeuffenucfkphepkeegrddvtddvrdeikedrjeehnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtgho mh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 1C48230664D9; Fri, 22 May 2020 19:01:17 -0400 (EDT) From: Marius Bakke In-Reply-To: <20200523004434.059d1960@scratchpost.org> References: <20171114162515.8743-1-ludo@gnu.org> <20171114162515.8743-2-ludo@gnu.org> <87fu9fsrxn.fsf@gmail.com> <87mv3mk2ql.fsf@gnu.org> <20200523004434.059d1960@scratchpost.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 23 May 2020 01:01:16 +0200 Message-ID: <87blmf8thf.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi Ludo, > > maybe a little off-topic, but why do I have to use the following patch on > armhf-linux (*not* cross compiling) in order to stop it from pulling in > i686-cross-gcc? Can you give a little more context? Did this occur after the let-system patch, or is this when using let-system? Can you paste the derivation for mes@0.19 in the context this occurs? Also, please file a new bug report. > Makes no sense to me at all... If only all bugs were obvious, our jobs would be so much easier! > diff --git a/gnu/packages/mes.scm b/gnu/packages/mes.scm > index 347aef0..524b8e8 100644 > --- a/gnu/packages/mes.scm > +++ b/gnu/packages/mes.scm > @@ -120,8 +120,9 @@ extensive examples, including parsers for the Javascript and C99 languages.") > ((string-prefix? "x86_64-linux" target-system) > ;; Use cross-compiler rather than #:system "i686-linux" to get > ;; MesCC 64 bit .go files installed ready for use with Guile. > - `(("i686-linux-binutils" ,(cross-binutils "i686-unknown-linux-gnu")) > - ("i686-linux-gcc" ,(cross-gcc "i686-unknown-linux-gnu")))) > + `( ;("i686-linux-binutils" ,(cross-binutils "i686-unknown-linux-gnu")) > + ;("i686-linux-gcc" ,(cross-gcc "i686-unknown-linux-gnu")) > +)) > (else > '()))) > ("graphviz" ,graphviz) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7IWbwACgkQoqBt8qM6 VPqZmAf/YsKv3Xx2cklU9UZkQn+QlEuJMm7GEq3hXvkrmIozyFiIYhNLPaFl7TWO Ed3dClkZDHiFN4VYFjaLa3q726m0ANrBc2uie/Ri7Xg8L5fqWJLdJgOJ0poPcTk0 0Qt0jIyaM7THrzHKt7wZN0xeVAFrI/RT0b9A2uDu9vrjPLNikXDS4LsxBaOu+0CL 3cQHFdjyc2afHM/4HJPPVUG5g2SvtmEq2TeF8tSmlJv0b7IZeeOPF1JRIWwi5Bkv n6YDA96BlTqbgL33663mcpQHa/1pdbyW/ezVC+DgQmngkEUJFoVWFgvUbknc+O1L zJ7x9rZAMjlj7XzbBmZYvcrdZEE63Q== =tSFq -----END PGP SIGNATURE----- --=-=-=--