GNU bug report logs - #29266
gzip-1.8.41 test results: help-version

Previous Next

Full log

Message #43 received at 29266-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Bruno Haible <bruno <at> clisp.org>
Cc: 29266-done <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#29266: gzip-1.8.41 test results: help-version and hard links
Date: Thu, 16 Nov 2017 07:29:14 -0800

[Message part 1 (text/plain, inline)]

On Thu, Nov 16, 2017 at 7:18 AM, Jim Meyering <jim <at> meyering.net> wrote:
> On Thu, Nov 16, 2017 at 2:37 AM, Bruno Haible <bruno <at> clisp.org> wrote:
>> Paul Eggert wrote:
>>> > +  ln -f "$file" "$file~" 2>/dev/null || cp -f "$file" "$file~" || {
>>>
>>> This will be problematic if the destination already exists, as the
>>> resulting permissions etc. may not be what the user intend. How about if
>>> we fall back on "mv -f" instead? Although this has the disadvantage of
>>> having a small window where "$file" does not exist, I think that's
>>> preferable to the disadvantage of using "cp".

P.S., thanks to both of you for the reviews and suggestions.

FYI, I've also pushed this:

[gzip-make-generated-unwritable.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.