From unknown Sun Jun 22 08:03:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29226: fresh-auto-compile =?UTF-8?Q?doesn=E2=80=99t?= invalidate the compilation cache Resent-From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 09 Nov 2017 12:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29226 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 29226@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15102320174770 (code B ref -1); Thu, 09 Nov 2017 12:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Nov 2017 12:53:37 +0000 Received: from localhost ([127.0.0.1]:59507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCmKv-0001Es-Hh for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCmKu-0001Eh-Pg for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCmKo-00063W-NE for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCmKo-00063Q-Jb for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCmKn-0000yu-6c for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCmKk-00062b-3n for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:29 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33733) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCmKj-00061p-Qc for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:26 -0500 X-IronPort-AV: E=Sophos;i="5.44,369,1505772000"; d="scan'208";a="300075012" Received: from unknown (HELO ribbon) ([193.50.110.150]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2017 13:53:22 +0100 From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 Brumaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 09 Nov 2017 13:53:22 +0100 Message-ID: <87zi7vmx4t.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, =E2=80=98%fresh-auto-compile=E2=80=99 is documented as a way to =E2=80=9Cfo= rcibly invalidate the auto-compilation cache=E2=80=9D (info "(guile) Compilation"), but it seems = that it doesn=E2=80=99t invalidate much. Specifically, =E2=80=98primitive-load-= path=E2=80=99 does: compiled_thunk =3D load_thunk_from_path (filename, full_filename, &stat_s= ource, &found_stale_compiled_file); if (scm_is_false (compiled_thunk) && scm_is_false (*scm_loc_fresh_auto_compile) =E2=80=A6) { =E2=80=A6 } =E2=80=A6 if (scm_is_true (compiled_thunk)) return scm_call_0 (compiled_thunk); else { SCM freshly_compiled =3D scm_try_auto_compile (full_filename); =E2=80=A6 } So if there=E2=80=99s a .go file in the search path, it is *always* loaded,= and there=E2=80=99s no way we reach =E2=80=98scm_try_auto_compile=E2=80=99. =E2=80=98load-absolute=E2=80=99 in boot-9.scm seems to have the same proble= m: (and scmstat (or (pre-compiled) (fallback))) I believe the attached patch fixes it. Thoughts? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/libguile/load.c b/libguile/load.c index 7b8136af8..3747dd9ad 100644 --- a/libguile/load.c +++ b/libguile/load.c @@ -1,5 +1,5 @@ /* Copyright (C) 1995, 1996, 1998, 1999, 2000, 2001, 2004, 2006, 2008, - * 2009, 2010, 2011, 2012, 2013, 2014 Free Software Foundation, Inc. + * 2009, 2010, 2011, 2012, 2013, 2014, 2017 Free Software Foundation, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public License @@ -1195,13 +1195,16 @@ SCM_DEFINE (scm_primitive_load_path, "primitive-load-path", 0, 0, 1, *scm_loc_load_extensions, SCM_BOOL_F, &stat_source); - compiled_thunk = load_thunk_from_path (filename, full_filename, &stat_source, - &found_stale_compiled_file); + if (scm_is_false (*scm_loc_fresh_auto_compile)) + compiled_thunk = load_thunk_from_path (filename, full_filename, + &stat_source, + &found_stale_compiled_file); + else + compiled_thunk = SCM_BOOL_F; if (scm_is_false (compiled_thunk) && scm_is_true (full_filename) && scm_is_true (*scm_loc_compile_fallback_path) - && scm_is_false (*scm_loc_fresh_auto_compile) && scm_is_pair (*scm_loc_load_compiled_extensions) && scm_is_string (scm_car (*scm_loc_load_compiled_extensions))) { diff --git a/module/ice-9/boot-9.scm b/module/ice-9/boot-9.scm index 7127d73f7..612040aa4 100644 --- a/module/ice-9/boot-9.scm +++ b/module/ice-9/boot-9.scm @@ -3812,7 +3812,10 @@ when none is available, reading FILE-NAME with READER." scmstat go-file-name)))))) - (let ((compiled (and scmstat (or (pre-compiled) (fallback))))) + (let ((compiled (and scmstat + (or (and (not %fresh-auto-compile) + (pre-compiled)) + (fallback))))) (if compiled (begin (if %load-hook --=-=-=-- From unknown Sun Jun 22 08:03:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#29226: closed (Re: bug#29226: fresh-auto-compile =?UTF-8?Q?doesn=E2=80=99t?= invalidate the compilation cache) Message-ID: References: <87y3mywbzg.fsf@gnu.org> <87zi7vmx4t.fsf@inria.fr> X-Gnu-PR-Message: they-closed 29226 X-Gnu-PR-Package: guile Reply-To: 29226@debbugs.gnu.org Date: Wed, 22 Nov 2017 15:49:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1511365742-30651-1" This is a multi-part message in MIME format... ------------=_1511365742-30651-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29226: fresh-auto-compile doesn=E2=80=99t invalidate the compilation cache which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29226@debbugs.gnu.org. --=20 29226: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29226 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1511365742-30651-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29226-done) by debbugs.gnu.org; 22 Nov 2017 15:48:40 +0000 Received: from localhost ([127.0.0.1]:52903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHXGS-0007xh-BL for submit@debbugs.gnu.org; Wed, 22 Nov 2017 10:48:40 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:60665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHXGQ-0007xZ-8h for 29226-done@debbugs.gnu.org; Wed, 22 Nov 2017 10:48:38 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1D8C3FF1C for <29226-done@debbugs.gnu.org>; Wed, 22 Nov 2017 16:48:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aVsXc5PIyYLE for <29226-done@debbugs.gnu.org>; Wed, 22 Nov 2017 16:48:38 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 8E7F8F382 for <29226-done@debbugs.gnu.org>; Wed, 22 Nov 2017 16:48:38 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: 29226-done@debbugs.gnu.org Subject: Re: bug#29226: fresh-auto-compile =?utf-8?Q?doesn=E2=80=99t?= invalidate the compilation cache References: <87zi7vmx4t.fsf@inria.fr> Date: Wed, 22 Nov 2017 16:48:35 +0100 In-Reply-To: <87zi7vmx4t.fsf@inria.fr> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22\?\= \=\?utf-8\?Q\?'s\?\= message of "Thu, 09 Nov 2017 13:53:22 +0100") Message-ID: <87y3mywbzg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29226-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) ludovic.courtes@inria.fr (Ludovic Court=C3=A8s) skribis: > I believe the attached patch fixes it. Pushed as 83d4c4d622b406ec0bc9d8139ec8182fa72b5720. Ludo=E2=80=99. ------------=_1511365742-30651-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Nov 2017 12:53:37 +0000 Received: from localhost ([127.0.0.1]:59507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCmKv-0001Es-Hh for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCmKu-0001Eh-Pg for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCmKo-00063W-NE for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCmKo-00063Q-Jb for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCmKn-0000yu-6c for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCmKk-00062b-3n for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:29 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33733) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCmKj-00061p-Qc for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:26 -0500 X-IronPort-AV: E=Sophos;i="5.44,369,1505772000"; d="scan'208";a="300075012" Received: from unknown (HELO ribbon) ([193.50.110.150]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2017 13:53:22 +0100 From: ludovic.courtes@inria.fr (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guile@gnu.org Subject: fresh-auto-compile =?utf-8?Q?doesn=E2=80=99t?= invalidate the compilation cache X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 Brumaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 09 Nov 2017 13:53:22 +0100 Message-ID: <87zi7vmx4t.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, =E2=80=98%fresh-auto-compile=E2=80=99 is documented as a way to =E2=80=9Cfo= rcibly invalidate the auto-compilation cache=E2=80=9D (info "(guile) Compilation"), but it seems = that it doesn=E2=80=99t invalidate much. Specifically, =E2=80=98primitive-load-= path=E2=80=99 does: compiled_thunk =3D load_thunk_from_path (filename, full_filename, &stat_s= ource, &found_stale_compiled_file); if (scm_is_false (compiled_thunk) && scm_is_false (*scm_loc_fresh_auto_compile) =E2=80=A6) { =E2=80=A6 } =E2=80=A6 if (scm_is_true (compiled_thunk)) return scm_call_0 (compiled_thunk); else { SCM freshly_compiled =3D scm_try_auto_compile (full_filename); =E2=80=A6 } So if there=E2=80=99s a .go file in the search path, it is *always* loaded,= and there=E2=80=99s no way we reach =E2=80=98scm_try_auto_compile=E2=80=99. =E2=80=98load-absolute=E2=80=99 in boot-9.scm seems to have the same proble= m: (and scmstat (or (pre-compiled) (fallback))) I believe the attached patch fixes it. Thoughts? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/libguile/load.c b/libguile/load.c index 7b8136af8..3747dd9ad 100644 --- a/libguile/load.c +++ b/libguile/load.c @@ -1,5 +1,5 @@ /* Copyright (C) 1995, 1996, 1998, 1999, 2000, 2001, 2004, 2006, 2008, - * 2009, 2010, 2011, 2012, 2013, 2014 Free Software Foundation, Inc. + * 2009, 2010, 2011, 2012, 2013, 2014, 2017 Free Software Foundation, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public License @@ -1195,13 +1195,16 @@ SCM_DEFINE (scm_primitive_load_path, "primitive-load-path", 0, 0, 1, *scm_loc_load_extensions, SCM_BOOL_F, &stat_source); - compiled_thunk = load_thunk_from_path (filename, full_filename, &stat_source, - &found_stale_compiled_file); + if (scm_is_false (*scm_loc_fresh_auto_compile)) + compiled_thunk = load_thunk_from_path (filename, full_filename, + &stat_source, + &found_stale_compiled_file); + else + compiled_thunk = SCM_BOOL_F; if (scm_is_false (compiled_thunk) && scm_is_true (full_filename) && scm_is_true (*scm_loc_compile_fallback_path) - && scm_is_false (*scm_loc_fresh_auto_compile) && scm_is_pair (*scm_loc_load_compiled_extensions) && scm_is_string (scm_car (*scm_loc_load_compiled_extensions))) { diff --git a/module/ice-9/boot-9.scm b/module/ice-9/boot-9.scm index 7127d73f7..612040aa4 100644 --- a/module/ice-9/boot-9.scm +++ b/module/ice-9/boot-9.scm @@ -3812,7 +3812,10 @@ when none is available, reading FILE-NAME with READER." scmstat go-file-name)))))) - (let ((compiled (and scmstat (or (pre-compiled) (fallback))))) + (let ((compiled (and scmstat + (or (and (not %fresh-auto-compile) + (pre-compiled)) + (fallback))))) (if compiled (begin (if %load-hook --=-=-=-- ------------=_1511365742-30651-1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 09:29:54 2018 Received: (at control) by debbugs.gnu.org; 15 Jan 2018 14:29:54 +0000 Received: from localhost ([127.0.0.1]:56834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb5lq-0006B5-Kn for submit@debbugs.gnu.org; Mon, 15 Jan 2018 09:29:54 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:40188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb5lo-0006Au-GX for control@debbugs.gnu.org; Mon, 15 Jan 2018 09:29:52 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1328D109C9 for ; Mon, 15 Jan 2018 15:29:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PQ5_U1PpLq4w for ; Mon, 15 Jan 2018 15:29:50 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 84403109AA for ; Mon, 15 Jan 2018 15:29:50 +0100 (CET) Date: Mon, 15 Jan 2018 15:29:50 +0100 Message-Id: <87y3kzfb4x.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #29226 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) severity 29226 important From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 17:19:03 2018 Received: (at control) by debbugs.gnu.org; 15 Jan 2018 22:19:03 +0000 Received: from localhost ([127.0.0.1]:57841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD5q-0003w7-R2 for submit@debbugs.gnu.org; Mon, 15 Jan 2018 17:19:02 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD5o-0003vT-Vk for control@debbugs.gnu.org; Mon, 15 Jan 2018 17:19:01 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 057FD10B76 for ; Mon, 15 Jan 2018 23:19:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jt2Rh2t1rI40 for ; Mon, 15 Jan 2018 23:18:59 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 27DCB109B6 for ; Mon, 15 Jan 2018 23:18:59 +0100 (CET) Date: Mon, 15 Jan 2018 23:18:58 +0100 Message-Id: <87mv1eg3zh.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #29226 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unarchive 29226 From unknown Sun Jun 22 08:03:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#29226: closed (Re: bug#29226: fresh-auto-compile =?UTF-8?Q?doesn=E2=80=99t?= invalidate the compilation cache) Message-ID: References: <87h8rmg3vk.fsf@gnu.org> <87zi7vmx4t.fsf@inria.fr> X-Gnu-PR-Message: they-closed 29226 X-Gnu-PR-Package: guile Reply-To: 29226@debbugs.gnu.org Date: Mon, 15 Jan 2018 22:22:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1516054923-15528-1" This is a multi-part message in MIME format... ------------=_1516054923-15528-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29226: fresh-auto-compile doesn=E2=80=99t invalidate the compilation cache which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29226@debbugs.gnu.org. --=20 29226: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29226 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1516054923-15528-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29226-done) by debbugs.gnu.org; 15 Jan 2018 22:21:29 +0000 Received: from localhost ([127.0.0.1]:57851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD8D-000417-EE for submit@debbugs.gnu.org; Mon, 15 Jan 2018 17:21:29 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD88-00040r-0A for 29226-done@debbugs.gnu.org; Mon, 15 Jan 2018 17:21:26 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 81A1410B76; Mon, 15 Jan 2018 23:21:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6mtPYyDtsXpD; Mon, 15 Jan 2018 23:21:20 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F18AF109B6; Mon, 15 Jan 2018 23:21:19 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Andy Wingo Subject: Re: bug#29226: fresh-auto-compile =?utf-8?Q?doesn=E2=80=99t?= invalidate the compilation cache References: <87zi7vmx4t.fsf@inria.fr> <87shb7fayt.fsf@gnu.org> <87h8rnb2no.fsf@igalia.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 =?utf-8?Q?Niv=C3=B4se?= an 226 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 15 Jan 2018 23:21:19 +0100 In-Reply-To: <87h8rnb2no.fsf@igalia.com> (Andy Wingo's message of "Mon, 15 Jan 2018 15:46:35 +0100") Message-ID: <87h8rmg3vk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29226-done Cc: 29226-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Andy Wingo skribis: > On Mon 15 Jan 2018 15:33, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Hello, >> >> ludovic.courtes@inria.fr (Ludovic Court=C3=A8s) skribis: >> >>> =E2=80=98%fresh-auto-compile=E2=80=99 is documented as a way to =E2=80= =9Cforcibly invalidate the >>> auto-compilation cache=E2=80=9D (info "(guile) Compilation"), but it se= ems that >>> it doesn=E2=80=99t invalidate much. Specifically, =E2=80=98primitive-l= oad-path=E2=80=99 does: >>> >>> compiled_thunk =3D load_thunk_from_path (filename, full_filename, &st= at_source, >>> &found_stale_compiled_file); >>> >>> if (scm_is_false (compiled_thunk) >>> && scm_is_false (*scm_loc_fresh_auto_compile) >>> =E2=80=A6) >>> { =E2=80=A6 } >>> >>> =E2=80=A6 >>> >>> if (scm_is_true (compiled_thunk)) >>> return scm_call_0 (compiled_thunk); >>> else >>> { >>> SCM freshly_compiled =3D scm_try_auto_compile (full_filename); >>> =E2=80=A6 >>> } >>> >>> So if there=E2=80=99s a .go file in the search path, it is *always* loa= ded, and >>> there=E2=80=99s no way we reach =E2=80=98scm_try_auto_compile=E2=80=99. >>> >>> =E2=80=98load-absolute=E2=80=99 in boot-9.scm seems to have the same pr= oblem: >>> >>> (and scmstat (or (pre-compiled) (fallback))) >>> >>> I believe the attached patch fixes it. >> >>> Pushed as 83d4c4d622b406ec0bc9d8139ec8182fa72b5720. >> >> As we=E2=80=99ve discussed since then, this patch was misguided: >> =E2=80=98%fresh-auto-compile=E2=80=99 is about ~/.cache, so the fact tha= t .go files >> found elsewhere in the search path get loaded is expected. >> >> My apologies for breaking this! >> >> So I guess we should revert 83d4c4d622b406ec0bc9d8139ec8182fa72b5720 and >> release 2.2.4 afterwards. Does that make sense, Andy? > > Makes sense to me, yes! OK, reverted in a1793bc904d947810d64175945218c2cdace38cc. Thanks, Ludo=E2=80=99. ------------=_1516054923-15528-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Nov 2017 12:53:37 +0000 Received: from localhost ([127.0.0.1]:59507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCmKv-0001Es-Hh for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCmKu-0001Eh-Pg for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCmKo-00063W-NE for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCmKo-00063Q-Jb for submit@debbugs.gnu.org; Thu, 09 Nov 2017 07:53:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCmKn-0000yu-6c for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCmKk-00062b-3n for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:29 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33733) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCmKj-00061p-Qc for bug-guile@gnu.org; Thu, 09 Nov 2017 07:53:26 -0500 X-IronPort-AV: E=Sophos;i="5.44,369,1505772000"; d="scan'208";a="300075012" Received: from unknown (HELO ribbon) ([193.50.110.150]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2017 13:53:22 +0100 From: ludovic.courtes@inria.fr (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: bug-guile@gnu.org Subject: fresh-auto-compile =?utf-8?Q?doesn=E2=80=99t?= invalidate the compilation cache X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 Brumaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 09 Nov 2017 13:53:22 +0100 Message-ID: <87zi7vmx4t.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, =E2=80=98%fresh-auto-compile=E2=80=99 is documented as a way to =E2=80=9Cfo= rcibly invalidate the auto-compilation cache=E2=80=9D (info "(guile) Compilation"), but it seems = that it doesn=E2=80=99t invalidate much. Specifically, =E2=80=98primitive-load-= path=E2=80=99 does: compiled_thunk =3D load_thunk_from_path (filename, full_filename, &stat_s= ource, &found_stale_compiled_file); if (scm_is_false (compiled_thunk) && scm_is_false (*scm_loc_fresh_auto_compile) =E2=80=A6) { =E2=80=A6 } =E2=80=A6 if (scm_is_true (compiled_thunk)) return scm_call_0 (compiled_thunk); else { SCM freshly_compiled =3D scm_try_auto_compile (full_filename); =E2=80=A6 } So if there=E2=80=99s a .go file in the search path, it is *always* loaded,= and there=E2=80=99s no way we reach =E2=80=98scm_try_auto_compile=E2=80=99. =E2=80=98load-absolute=E2=80=99 in boot-9.scm seems to have the same proble= m: (and scmstat (or (pre-compiled) (fallback))) I believe the attached patch fixes it. Thoughts? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/libguile/load.c b/libguile/load.c index 7b8136af8..3747dd9ad 100644 --- a/libguile/load.c +++ b/libguile/load.c @@ -1,5 +1,5 @@ /* Copyright (C) 1995, 1996, 1998, 1999, 2000, 2001, 2004, 2006, 2008, - * 2009, 2010, 2011, 2012, 2013, 2014 Free Software Foundation, Inc. + * 2009, 2010, 2011, 2012, 2013, 2014, 2017 Free Software Foundation, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public License @@ -1195,13 +1195,16 @@ SCM_DEFINE (scm_primitive_load_path, "primitive-load-path", 0, 0, 1, *scm_loc_load_extensions, SCM_BOOL_F, &stat_source); - compiled_thunk = load_thunk_from_path (filename, full_filename, &stat_source, - &found_stale_compiled_file); + if (scm_is_false (*scm_loc_fresh_auto_compile)) + compiled_thunk = load_thunk_from_path (filename, full_filename, + &stat_source, + &found_stale_compiled_file); + else + compiled_thunk = SCM_BOOL_F; if (scm_is_false (compiled_thunk) && scm_is_true (full_filename) && scm_is_true (*scm_loc_compile_fallback_path) - && scm_is_false (*scm_loc_fresh_auto_compile) && scm_is_pair (*scm_loc_load_compiled_extensions) && scm_is_string (scm_car (*scm_loc_load_compiled_extensions))) { diff --git a/module/ice-9/boot-9.scm b/module/ice-9/boot-9.scm index 7127d73f7..612040aa4 100644 --- a/module/ice-9/boot-9.scm +++ b/module/ice-9/boot-9.scm @@ -3812,7 +3812,10 @@ when none is available, reading FILE-NAME with READER." scmstat go-file-name)))))) - (let ((compiled (and scmstat (or (pre-compiled) (fallback))))) + (let ((compiled (and scmstat + (or (and (not %fresh-auto-compile) + (pre-compiled)) + (fallback))))) (if compiled (begin (if %load-hook --=-=-=-- ------------=_1516054923-15528-1-- From unknown Sun Jun 22 08:03:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29226: fresh-auto-compile =?UTF-8?Q?doesn=E2=80=99t?= invalidate the compilation cache Resent-From: David Pirotte Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 16 Jan 2018 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29226 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Andy Wingo , 29226-done@debbugs.gnu.org Received: via spool by 29226-done@debbugs.gnu.org id=D29226.15161267408012 (code D ref 29226); Tue, 16 Jan 2018 18:19:02 +0000 Received: (at 29226-done) by debbugs.gnu.org; 16 Jan 2018 18:19:00 +0000 Received: from localhost ([127.0.0.1]:59045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVp6-000259-8h for submit@debbugs.gnu.org; Tue, 16 Jan 2018 13:19:00 -0500 Received: from maximusconfessor.all2all.org ([79.99.200.102]:45894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebVp4-000251-Q1 for 29226-done@debbugs.gnu.org; Tue, 16 Jan 2018 13:18:59 -0500 Received: from localhost (unknown [192.168.0.2]) by maximusconfessor.all2all.org (Postfix) with ESMTP id B98ECA04C1B9; Tue, 16 Jan 2018 19:18:57 +0100 (CET) Received: from maximusconfessor.all2all.org ([192.168.0.1]) by localhost (maximusconfessor.all2all.org [192.168.0.2]) (amavisd-new, port 10024) with ESMTP id NaP3LuTGqCzI; Tue, 16 Jan 2018 19:18:53 +0100 (CET) Received: from capac (unknown [179.210.16.19]) by maximusconfessor.all2all.org (Postfix) with ESMTPSA id BE4A0A04C1A9; Tue, 16 Jan 2018 19:18:52 +0100 (CET) Date: Tue, 16 Jan 2018 16:18:46 -0200 From: David Pirotte Message-ID: <20180116161846.082ed4ad@capac> In-Reply-To: <87h8rmg3vk.fsf@gnu.org> References: <87zi7vmx4t.fsf@inria.fr> <87shb7fayt.fsf@gnu.org> <87h8rnb2no.fsf@igalia.com> <87h8rmg3vk.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/OvFozeMkSyuzS4TktZOxT0N"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Sig_/OvFozeMkSyuzS4TktZOxT0N Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello Andy, Ludovic, Mark, > >> So I guess we should revert 83d4c4d622b406ec0bc9d8139ec8182fa72b5720 a= nd > >> release 2.2.4 afterwards. Does that make sense, Andy? =20 I hope (one of) you will find some time to look at=20 bug#29669: repl-print - requet for improvement bug#29684: exception printers - request for improvement so a solution could be part of 2.2.4 Thanls, David --Sig_/OvFozeMkSyuzS4TktZOxT0N Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhCJlRZtBM3furJHe83T9k6MFetcFAlpeQgYACgkQ83T9k6MF eteooQgAwd6QJFhlAsSyLlc+65D9CsE9F2wZMhRVEqvlhmx5yu5QrwpwQRx5KX/3 yyyxCnn9HGEzu7bH7bewhNX+/aER9caOB4JdSIRpZxJKcDFDq9UaLV7xCsfYweT4 L2s0U2LcD3JK5qeMKCxnz8BPEZH87d6JSGc9I1OKiIMoMdA/O7toS+zMw3x6SuEK Xu+7Y1Cq5uWoAr+NpymtSIKEpItCp5G4a82x6cqMpS4j8zLZRgwKlcSlYg23cpzp sCb84M9pLK8XD9uglGgAW/huQEKomn/5WUS1erJzz/NvLSGJBFnEvnVwJ0goMOqF 9D/13cTt0DfK8/VhMfi6UG/ywotX5w== =C+q9 -----END PGP SIGNATURE----- --Sig_/OvFozeMkSyuzS4TktZOxT0N--