From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 03:24:50 2017 Received: (at submit) by debbugs.gnu.org; 9 Nov 2017 08:24:50 +0000 Received: from localhost ([127.0.0.1]:59382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCi8o-0001AI-Ef for submit@debbugs.gnu.org; Thu, 09 Nov 2017 03:24:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCi8n-0001A6-6P for submit@debbugs.gnu.org; Thu, 09 Nov 2017 03:24:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCi8g-0007Qd-VE for submit@debbugs.gnu.org; Thu, 09 Nov 2017 03:24:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCi8g-0007QY-Qm for submit@debbugs.gnu.org; Thu, 09 Nov 2017 03:24:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCi8f-00012w-LE for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 03:24:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCi8e-0007PQ-IK for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 03:24:41 -0500 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:56110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCi8e-0007PC-EA for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 03:24:40 -0500 Received: by mail-qk0-x22d.google.com with SMTP id x195so6639400qkb.12 for ; Thu, 09 Nov 2017 00:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=KqGXwSjVLBOKgcAHhA5qTWwMozVBloOFzGmWhWSMB6A=; b=WFF79z5NU0/gHo1QfadytzcvVRCbF60glKe3bQPT/W/enaXVj8nN8ZxUsTNqRuB5Ix BYK3yVjJo+Z2WU8Bh+RWD95XaCbZsOPhc7ZkUMxUEqSD6gCCIHwrJgzQRxE0SnShs/xt MRhG+jRLY5H9DwavslI8o1O7zkP4IfQ94jsrsQnSZEqKA3YhvOAHrL+e7bATg25aChgr uupkw0DObENWhbRIKMiRqxbXwyNscgh3/WuUiMDLoeyT4xEGUfHiHZRH7TonOwcmvrFI X3P1zLwDdY9iRpilu34FJHGZeQIH6cgv5jYP0eV77+ilJH1llFhuoGQFZh9uvpqSYjJz Qkfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KqGXwSjVLBOKgcAHhA5qTWwMozVBloOFzGmWhWSMB6A=; b=iB3zJhHcyoLdZDODE/hD6cBhibnQAfEymixaNNzZl6Yi6Tw0cfvropzWiNRrQkJ5iG /7sqqIroVPuAgzl3NxKR21KRuUjlaAZlwqOpSgAjoRVsnJFrCZjlCRCbmVZHILNMdCsU e3d6pw6UZyIzAgeDbHp72bn1t8uJKlsLCgxngduH9gDZ4o16CZlBzt+Ml6l5/vbqMg/4 KFMFXZ05ZKclVNK1yiIt0kZNqDksIyWUUrAyBECe4Pee3gBvUp2nDX+p0pXk6M4rpW6I hSeUi+NgEtTRh76F3rXS+bm3v5fh/bLL8j5wROfIMzDMQT6bbGpEKsKDGpfrjGJrLVVM rAlg== X-Gm-Message-State: AJaThX50dy2xRUJWH+S14WHtC8Xm17yFvQ7meVK18ePHa5P18K3HcGOk C3LoTeH7UVCQ69qr6dqyb6hp8zO5gSLfG/u1aijkzA== X-Google-Smtp-Source: ABhQp+R885Y+ki0dIlimzCPpsQrGOFibzH/kOTeyx0m3NsbbZI7vkUfo0QxtUIUq7bybXTwbxxZHwJ7uAODr6zkX+3A= X-Received: by 10.55.159.74 with SMTP id i71mr5199560qke.46.1510215879747; Thu, 09 Nov 2017 00:24:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.46.68 with HTTP; Thu, 9 Nov 2017 00:24:39 -0800 (PST) From: Shuguang Sun Date: Thu, 9 Nov 2017 16:24:39 +0800 Message-ID: Subject: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="94eb2c06b72e0bed2e055d888958" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --94eb2c06b72e0bed2e055d888958 Content-Type: text/plain; charset="UTF-8" Hi, Windows 7 GNU Emacs 26.0.50 (build 1, x86_64-w64-mingw32) of 2017-08-27 (backup-by-copying t) When I tramp to a host (linux) and edit a file, and save it, I get an error about the backup as below. The ACL is in different format on Linus and on Windows. It is "user::..." on linux, however, it looks like "O:S-1-5-21-" on windows. Could we allow the user to set whether to copy ACl for certain type of files? Debugger entered--Lisp error: (file-error "Converting ACL" "Invalid argument" "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host !!!path!user!Ava!_mortality.R.~1~") set-file-acl("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~" "user::rw-\ngroup::rw-\nother::r--\n") set-file-extended-attributes("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~" ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil nil nil nil))) backup-buffer-copy("/plink:user@host:/path/user/Ava/_mortality.R" "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~" 436 ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil nil nil nil))) backup-buffer() basic-save-buffer-2() basic-save-buffer-1() basic-save-buffer(t) save-buffer(1) funcall-interactively(save-buffer 1) call-interactively(save-buffer nil nil) command-execute(save-buffer) Best Regards, Shuguang --94eb2c06b72e0bed2e055d888958 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Windows 7
= GNU Emacs 26.0.50 (build 1, x86_64-w64-mingw32) of 2017-08-27
(ba= ckup-by-copying t)

When I tramp to a host (linux) = and edit a file, and save it, I get an error about the backup as below. The= ACL is in different format on Linus and on Windows. It is "user::...&= quot; on linux, however, it looks like "O:S-1-5-21-" on windows. =

Could we allow the user to set whether to cop= y ACl for certain type of files?

Debugger ente= red--Lisp error: (file-error "Converting ACL" "Invalid argum= ent" "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!= !user@host!!!path!user!Ava!_mortality.R.~1~")
=C2=A0 set-file-acl(&= quot;c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!= !!path!user!Ava!_mortality.R.~1~" "user::rw-\ngroup::rw-\nother::= r--\n")
=C2=A0 set-file-extended-attributes("c:/Users/user/HOM= E/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_morta= lity.R.~1~" ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (= selinux-context nil nil nil nil)))
=C2=A0 backup-buffer-copy("/plin= k:user@host:/path/user/Ava/_mortality.R" "c:/Users/user/HOME/.ema= cs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R= .~1~" 436 ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (se= linux-context nil nil nil nil)))
=C2=A0 backup-buffer()
=C2=A0 basic-= save-buffer-2()
=C2=A0 basic-save-buffer-1()
=C2=A0 basic-save-buffer= (t)
=C2=A0 save-buffer(1)
=C2=A0 funcall-interactively(save-buffer 1)=
=C2=A0 call-interactively(save-buffer nil nil)
=C2=A0 command-execut= e(save-buffer)

Best Regards,
Shuguang
=

--94eb2c06b72e0bed2e055d888958-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 12:18:42 2017 Received: (at 29225) by debbugs.gnu.org; 9 Nov 2017 17:18:42 +0000 Received: from localhost ([127.0.0.1]:60642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCqTS-0007xu-F4 for submit@debbugs.gnu.org; Thu, 09 Nov 2017 12:18:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCqTR-0007xi-Bc for 29225@debbugs.gnu.org; Thu, 09 Nov 2017 12:18:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCqTI-00085S-Oe for 29225@debbugs.gnu.org; Thu, 09 Nov 2017 12:18:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCqTI-00085N-KZ; Thu, 09 Nov 2017 12:18:32 -0500 Received: from [176.228.60.248] (port=3084 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eCqTI-0003Iy-4U; Thu, 09 Nov 2017 12:18:32 -0500 Date: Thu, 09 Nov 2017 19:18:46 +0200 Message-Id: <83lgjfqsjt.fsf@gnu.org> From: Eli Zaretskii To: Shuguang Sun , Michael Albinus In-reply-to: (message from Shuguang Sun on Thu, 9 Nov 2017 16:24:39 +0800) Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29225 Cc: 29225@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Shuguang Sun > Date: Thu, 9 Nov 2017 16:24:39 +0800 > > Could we allow the user to set whether to copy ACl for certain type of files? That should work automatically. > Debugger entered--Lisp error: (file-error "Converting ACL" "Invalid argument" > "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~") > > set-file-acl > ("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~" > "user::rw-\ngroup::rw-\nother::r--\n") > set-file-extended-attributes > ("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~" > ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil nil nil nil))) > backup-buffer-copy("/plink:user@host:/path/user/Ava/_mortality.R" > "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!!path!user!Ava!_mortality.R.~1~" > 436 ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil nil nil nil))) This seems to indicate that Unix-style ACLs are passed to native Windows ACL functions, which won't work. Michael, could you please look into this? I'd expect ACLs derived from remote files never to be used on local files. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 10 07:41:16 2017 Received: (at 29225) by debbugs.gnu.org; 10 Nov 2017 12:41:16 +0000 Received: from localhost ([127.0.0.1]:33295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD8cW-0000IR-5z for submit@debbugs.gnu.org; Fri, 10 Nov 2017 07:41:16 -0500 Received: from mout.gmx.net ([212.227.15.18]:60752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD8cU-0000ID-9B for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 07:41:14 -0500 Received: from detlef.gmx.de ([79.140.124.106]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUI8w-1eeBe41GPS-00R1uJ; Fri, 10 Nov 2017 13:41:06 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: <83lgjfqsjt.fsf@gnu.org> Date: Fri, 10 Nov 2017 13:41:04 +0100 In-Reply-To: <83lgjfqsjt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Nov 2017 19:18:46 +0200") Message-ID: <87bmkal31b.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:KaLA650gtWckZcCRY2ILw8fDizlKG5Fcns1JoOGlPGh6235UPPk KFvyAZEGEeHz4/gRm+ZBggKox1nRuDfuscIDidX5qB2/cYqHqmjl3vu7AsdL4EkFGryVnof NO2mJRPr07hzbnUbWAYRjiiZLONtVVR9li3ER1wnQPVva5D4DjvF4wy5N/v3rIzJ0NY+X5M xW32BUxKgYXg/6PDILznQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ta7FMFT6fsE=:zTlaVONwI4Eo/To7CLbggw jZQMJDEMA8wpZelgdEs8mB35S2kDh34z3zlOshrCL3ZtIJ3SLVfjnBr4J91aQM6/ITpX2+MuS W3s5gA9NrTyXb7KPXrFEqXOVB7+b2TKFH1TtDkvw0rjtA60qwGQmMwIsM+xJPgLnglwI+HD+c rnnytKDL/G4+9eEeclzZIy/f6Oc6sti/tvy31iudNkzmXeSX9yfK93EJakelqN7HjJrqCSOsQ zPfedoI2NVkroJCLbdC7hL1KTvayIebZmODcavRopBjzEEyIIjK3QauthARV6tjiT41vkoG0u CRWV+9uNZg04BNNykbAJXuYnlcMTS6KaB4eVsU/rvcdFeXIqMPMbP71Vv70zhSSzpSWB2P0F5 YLWz3Iyea9m9BNV7/jKPkxZ0fZhvCw/hHuBmU6/yu7LIvZdPKRvKEM4PtkBbt+QNusWQsg5sU wPZWL37f1NGE9f1Gda1T/NiS87MSZDJ2rcQI04RNeas/sme0N8yAZMCS5hiiXvSLXRTwoPW12 eAPNPHmi1Shp4ABFEiXKvMvqWmQuXUyScBxgCgi6wK4MYe34i+mE2xs4k2/qHvkDBRFGS9Hph EcBx3+y0U2iv6shbFVA3nY4STnwYG6rn65/LZmKu97x23nVInSVug7M5kbXns15LMaf+ecBhW YNKNpIOBO9sm13Ik0lQQqB6b3YYR5byiqLjZxa2riPhl6MTjGqFXImUwg4YGTbdIgrZjw3/M5 I0eF+jlHD1QAb6HhjikOWdMeTtOAPk+buyRxRkh6MtHZTxobkOKpIf66CD3jySDWJQC0/+I9d D7KiFctV04WZN2K+XHmDDQrFEtXNsEfKj8mZRBTjV5eIVLt4e8= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29225 Cc: 29225@debbugs.gnu.org, Shuguang Sun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: Hi Eli, >> Debugger entered--Lisp error: (file-error "Converting ACL" "Invalid argu= ment" >> "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!= !path!user!Ava!_mortality.R.~1~") >>=20 >> set-file-acl >> ("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!= !!path!user!Ava!_mortality.R.~1~" >> "user::rw-\ngroup::rw-\nother::r--\n") >> set-file-extended-attributes >> ("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!= !!path!user!Ava!_mortality.R.~1~" >> ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil nil = nil nil))) >> backup-buffer-copy("/plink:user@host:/path/user/Ava/_mortality.R" >> "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!= !path!user!Ava!_mortality.R.~1~" >> 436 ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil = nil nil nil))) > > This seems to indicate that Unix-style ACLs are passed to native > Windows ACL functions, which won't work. Michael, could you please > look into this? I'd expect ACLs derived from remote files never to be > used on local files. And vice versa. However, Tramp has no chance to do something here. It offers own implementations of `file-acl' and `set-file-acl'; both functions don't know where the returned ACL shall be used (=C2=B4file-acl'), or where the A= CL comes from (`set-file-acl'). Therefore, the docstring of `set-file-acl' says "Value is t if setting of ACL was successful, nil otherwise." The error message "Converting ACL" "Invalid argument" comes from Ffile_acl of fileio.c. It *raises* an error instead of silently returning Qnil, as advertised by the docstring. A similar wrong behaviour I've found in `tramp-smb-handle-set-file-acl'. I would convert both functions to return nil instead of raising an error, in the emacs-26 branch. Any objection? > Thanks. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 10 08:07:11 2017 Received: (at 29225) by debbugs.gnu.org; 10 Nov 2017 13:07:11 +0000 Received: from localhost ([127.0.0.1]:33319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD91b-0000vW-Kp for submit@debbugs.gnu.org; Fri, 10 Nov 2017 08:07:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD91Z-0000vJ-RW for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 08:07:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eD91P-0000Ko-7Y for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 08:07:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD91P-0000Kj-3l; Fri, 10 Nov 2017 08:06:59 -0500 Received: from [176.228.60.248] (port=3897 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eD91N-0000sj-0F; Fri, 10 Nov 2017 08:06:58 -0500 Date: Fri, 10 Nov 2017 15:06:49 +0200 Message-Id: <83mv3up9jq.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-reply-to: <87bmkal31b.fsf@gmx.de> (message from Michael Albinus on Fri, 10 Nov 2017 13:41:04 +0100) Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: <83lgjfqsjt.fsf@gnu.org> <87bmkal31b.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29225 Cc: 29225@debbugs.gnu.org, shuguang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Albinus > Cc: Shuguang Sun , 29225@debbugs.gnu.org > Date: Fri, 10 Nov 2017 13:41:04 +0100 > > "Value is t if setting of ACL was successful, nil otherwise." > > The error message "Converting ACL" "Invalid argument" comes from > Ffile_acl of fileio.c. It *raises* an error instead of silently > returning Qnil, as advertised by the docstring. A similar wrong > behaviour I've found in `tramp-smb-handle-set-file-acl'. > > I would convert both functions to return nil instead of raising an > error, in the emacs-26 branch. Any objection? I think it should return nil when acl_errno_valid returns false, and otherwise signal an error. It currently calls acl_errno_valid in one of the two places where error could happen, but not in the other. And the doc string should be amended to say that. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 10 09:39:50 2017 Received: (at 29225) by debbugs.gnu.org; 10 Nov 2017 14:39:50 +0000 Received: from localhost ([127.0.0.1]:33388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDATF-00039G-Oo for submit@debbugs.gnu.org; Fri, 10 Nov 2017 09:39:49 -0500 Received: from mout.gmx.net ([212.227.15.15]:56138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDATE-000393-KL for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 09:39:49 -0500 Received: from detlef.gmx.de ([79.140.124.106]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MAQ0o-1eOfiR0T2w-00BZON; Fri, 10 Nov 2017 15:39:41 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: <83lgjfqsjt.fsf@gnu.org> <87bmkal31b.fsf@gmx.de> <83mv3up9jq.fsf@gnu.org> Date: Fri, 10 Nov 2017 15:39:39 +0100 In-Reply-To: <83mv3up9jq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Nov 2017 15:06:49 +0200") Message-ID: <874lq2kxjo.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:unfHKTBVhPM7/R/toniiCLGh3W36uBHawwpe8sYZfjAMINUQBOJ ZR2kPf8VYHc3VXS05OZb9l0H0Q9vpOMNeVFskHdP5RtB/gmYL2eu83ONAdQ0bSh9c8OQ/rY Pfq8kRn0afRJ+g7C/CZmB7u1uk2Z0cNHwOhhyqrN0VfXPGYYzvlD+EbjncIQt+Ev5IYQA6x BHKYNeI9rxeS5tIFFhSCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:0rD+jH6I7HU=:vDxDR8a3U0zunVAnPNFHAM MyYfhV/AH76CGSSy8r5a35nwOvrXVLiqre+KS7htSpchTEY2pNGrhxZgGlitBPlR3h8VLj4ZG BfxNi4h1CRAgRfCvW/SAdijwJTCKTF348bO5bk7YPX7oQj19fbDCVQ+jbQ8NQwhE3AXEr5Oph gz31fLfZsryXzfDZALEOXRDih6hAdaMvXhVYdZWcfwa+aZ7r1fkINS08vlOplT9X4WsopxPS8 97MWpmw27Onw8E3mFgAl4RPslQ2Fpkn5bEIJfI3Aa6fA08H452kiezGt3eVejGZy+exzHId2E 1jz+hl7uSV+GlBSnnwkc6AnZA2t2v3ugz2iMnvsISUWQjumXjGJjd/TZvJReGoDZA2mLfEUw0 naQZdIp6TfUJlQjRz7+OsfEE1/8i93wN388lT2zYKWpXLAszED7jHgAo71nEJfMS/FbF6Yh8M TUiP/c2zNEGy5aPsKe/5rESCRD53rX4Q/9aj1kpOscKPHf/07q3oA7zgNrB8ZDOpaxvY1XyQV AxLoJVxU+Fh/WrG+rgugfYGCitARuRXfTi4dcV19dB7ZRH63MJEFUL1OMQWIfq/vAPqLEJyVm hwssULNcw9n3Bl9vtr/Kp5ceRNzFJS7CoWcTI0ZBfxgjq3Gh7913hrtNX+d1RlVcbpqtqjCPO 0V+Q83BbQgVFoPYCGdH5p0khvYpix+oBEhCluHeFRscFouZLgiYYUPRTslLkoicQgEsO1p2h/ Bcch0Du+iDR8MTqmBNKOfAUjqrz2qAQ1dD55ibC4JHxIvZ6RLFy9Y5icvtP5xD7mXiuzG6IUg N7lqjx83um1YnufCDH5RxbS9A7yXQ== X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 29225 Cc: 29225@debbugs.gnu.org, shuguang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: Hi Eli, > I think it should return nil when acl_errno_valid returns false, and > otherwise signal an error. It currently calls acl_errno_valid in one > of the two places where error could happen, but not in the other. And > the doc string should be amended to say that. WDYT? Seems to work, yes. acl_from_text returns EINVAL for wrong ACLs, so the error would be suppressed, because acl_errno_valid returns false this case. I've tested successfully the appended patch on GNU/Linux. (set-file-acl "/tmp/123" "dummy") returns nil with the applied patch, and (file-error "Converting ACL" "Invalid argument" "/tmp/123") w/o the patch. I cannot test on MS Windows. I don't know whether we must extend the docstring. Summarizing probable errors is not the default in Emacs docstrings. And the docstring does not promise, that no error at all will happen. If you don't object, I'll commit the patch to emacs-26. Plus minor changes in Tramp. Maybe I'll find also the time next days, to add the missing tests for file-acl and set-file-acl in tramp-tests.el. See the TODO list at the end of that file. Best regards, Michael. --=-=-= Content-Type: text/plain Content-Disposition: attachment diff --git a/src/fileio.c b/src/fileio.c index cc1399e1bd..f538f12f9b 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -3047,7 +3047,7 @@ support. */) if (STRINGP (acl_string)) { acl = acl_from_text (SSDATA (acl_string)); - if (acl == NULL) + if (acl == NULL && acl_errno_valid (errno)) { report_file_error ("Converting ACL", absname); return Qnil; --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 10 10:13:21 2017 Received: (at 29225) by debbugs.gnu.org; 10 Nov 2017 15:13:21 +0000 Received: from localhost ([127.0.0.1]:34292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDAzh-0004CT-Es for submit@debbugs.gnu.org; Fri, 10 Nov 2017 10:13:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDAzf-0004CB-N1 for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 10:13:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDAzW-0003Dj-3v for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 10:13:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDAzW-0003Db-1Q; Fri, 10 Nov 2017 10:13:10 -0500 Received: from [176.228.60.248] (port=4996 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eDAzV-0004cx-9R; Fri, 10 Nov 2017 10:13:09 -0500 Date: Fri, 10 Nov 2017 17:13:06 +0200 Message-Id: <83lgjep3p9.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-reply-to: <874lq2kxjo.fsf@gmx.de> (message from Michael Albinus on Fri, 10 Nov 2017 15:39:39 +0100) Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: <83lgjfqsjt.fsf@gnu.org> <87bmkal31b.fsf@gmx.de> <83mv3up9jq.fsf@gnu.org> <874lq2kxjo.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29225 Cc: 29225@debbugs.gnu.org, shuguang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Albinus > Cc: shuguang@gmail.com, 29225@debbugs.gnu.org > Date: Fri, 10 Nov 2017 15:39:39 +0100 > > > I think it should return nil when acl_errno_valid returns false, and > > otherwise signal an error. It currently calls acl_errno_valid in one > > of the two places where error could happen, but not in the other. And > > the doc string should be amended to say that. WDYT? > > Seems to work, yes. acl_from_text returns EINVAL for wrong ACLs, so the > error would be suppressed, because acl_errno_valid returns false this case. > > I've tested successfully the appended patch on GNU/Linux. > > (set-file-acl "/tmp/123" "dummy") > > returns nil with the applied patch, and (file-error "Converting ACL" > "Invalid argument" "/tmp/123") w/o the patch. > > I cannot test on MS Windows. I don't see why it wouldn't work on Windows as well. > I don't know whether we must extend the docstring. Summarizing probable > errors is not the default in Emacs docstrings. And the docstring does > not promise, that no error at all will happen. That's okay, I can always amend the doc string later. > If you don't object, I'll commit the patch to emacs-26. Plus minor > changes in Tramp. No objection, but please only condition the call to 'error' on acl_errno_valid. I see no reason to proceed with calling acl_set_file if acl_from_text fails. > Maybe I'll find also the time next days, to add the missing tests > for file-acl and set-file-acl in tramp-tests.el. Sounds good, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 12 08:21:52 2017 Received: (at 29225) by debbugs.gnu.org; 12 Nov 2017 13:21:52 +0000 Received: from localhost ([127.0.0.1]:36148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDsCu-0008OZ-AS for submit@debbugs.gnu.org; Sun, 12 Nov 2017 08:21:52 -0500 Received: from mout.gmx.net ([212.227.17.20]:59248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDsCs-0008OM-RV for 29225@debbugs.gnu.org; Sun, 12 Nov 2017 08:21:51 -0500 Received: from detlef.gmx.de ([79.140.117.85]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKKaI-1eFWd62Y2I-001jvv; Sun, 12 Nov 2017 14:21:42 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: <83lgjfqsjt.fsf@gnu.org> <87bmkal31b.fsf@gmx.de> <83mv3up9jq.fsf@gnu.org> <874lq2kxjo.fsf@gmx.de> <83lgjep3p9.fsf@gnu.org> Date: Sun, 12 Nov 2017 14:21:41 +0100 Message-ID: <87mv3rhbtm.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:SKrW62SKPX28YGkDnOScGWJpK4+YpfyhRqgZnTy6L29O8hnBUMS B6XhUD5D8ihGX1jjbH9DM8fapROLgU6gnCE2evS5KQg5qBwN/PnO+6XaNIGlG34SVl14NFf 0be+4zih9eLRLgnAvK5I166ktM5lVok/9qqdERzlzVJW4hVYbLRNWuBeC49T2eOEfAeJ7AM pNCmg+ROLX6QWuHBqIP5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:6FhhY59t2zY=:6fc0ACDfNHggTy2QecMKnu D4Lad8EQYHTbjaQQrxv1o5X+qgB0OIPV+h0RNlFPAKp/PACNJq1OELWWcRm6HMjZP7KyU8Fdg pT+ofV6G6h1grCqVBloXyHlzK2I0g7r/l4mY7es5LM1ABIzgDo76RxyJHb+gA1Ab0i0V7rGUh lnp+Em8NvI15qdMwaMSKQpGrfN7k6JBStuFM0rDrMXJfqlvtWViOWfEVwWfNEfWCBaAzHU31f CLgklGAvccJmRMVeBVh/opGCV2Q+kYItOJfwtE3WtdPY0RoqaB/UzCkUaluON557buca5eoc7 GnireWfxHyfonrxw7AUVumSNdPFNkQcJJJZ5T/tG0AqXJTAUYrCgl9KTSB0IH5WqqIev2YSTW 33Doy+vM3JpTVowBD0IfBhllnTZkGFqGDg5rIwWj3pi1IVNgqxfxTCeWQqmvYi7EOW58BrIAP EmfHf+gKH/wG4q93LLW0rFgPL8ZZpr2OKhirUyroMRrqbO8z7y3726Uohm4hnpZ907NJnpjxe Ml2+3UGmcStwDBTOOh071BrOEC4p5jqZYK0rCkuTy6FK+uudgyepcFOGWUnMdWfJGevYZQYs8 YEADhn0vQ9AeTmdHFJt7Ecl1vbZz+8+GK3oh8++C0CUMDnJ8y2J61sKhV13DWQUVZbEDBWhPE KDAEPNUOAJMuost9hihHl2F/SPSywSggwIebJ0QEKk8McQg6bJ6b/UX51xWJx6q6TOvP0RD4X MNCfml5QVXlkYT1C3y+xgev8I28Oe8PULJqzkP7XF1u+U0V1oUs38vkuWSl4pPxUcvO19p9x+ pbXicSL+/kOjPVYeda+i+tQAvLGRn+d/u8JvhPMNPbyT6nQ8ys= X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 29225 Cc: 29225@debbugs.gnu.org, shuguang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Eli Zaretskii writes: > No objection, but please only condition the call to 'error' on > acl_errno_valid. I see no reason to proceed with calling acl_set_file > if acl_from_text fails. Done. >> Maybe I'll find also the time next days, to add the missing tests >> for file-acl and set-file-acl in tramp-tests.el. > > Sounds good, thanks. Also done. I've committed the patch to the emacs-26 branch. Shuguang, do you have a chance to check this? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 17 05:05:24 2018 Received: (at 29225-done) by debbugs.gnu.org; 17 Jan 2018 10:05:24 +0000 Received: from localhost ([127.0.0.1]:59428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebkaw-0002dQ-R8 for submit@debbugs.gnu.org; Wed, 17 Jan 2018 05:05:24 -0500 Received: from mout.gmx.net ([212.227.17.20]:49468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebkau-0002dE-Lf for 29225-done@debbugs.gnu.org; Wed, 17 Jan 2018 05:05:21 -0500 Received: from detlef.gmx.de ([212.86.42.191]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LsOsW-1f0BEn3QyG-011wGR; Wed, 17 Jan 2018 11:05:13 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 References: <83lgjfqsjt.fsf@gnu.org> <87bmkal31b.fsf@gmx.de> <83mv3up9jq.fsf@gnu.org> <874lq2kxjo.fsf@gmx.de> <83lgjep3p9.fsf@gnu.org> <87mv3rhbtm.fsf@gmx.de> Date: Wed, 17 Jan 2018 11:05:12 +0100 In-Reply-To: <87mv3rhbtm.fsf@gmx.de> (Michael Albinus's message of "Sun, 12 Nov 2017 14:21:41 +0100") Message-ID: <87h8rkssvb.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:9zrv1YPranzrUHtL1YK5lmDRAWLE+/pykZzJPGBjg7M4zmS6phu TTDgf+dOQACrS9KZcyNJ/ztZ4m9AQHIeA+oVWG4fB2WmHS1Ld2gzFyk2l312VEou/kpe/bZ cpoBrp/2nmzyXFeTHnKXDS1NIzCovVx0VTh9LPBQ2UQTHrk6zWhZ/OJLAiipf77TPSs39Bd gdbC00RWSpg6/+B8Z/GXg== X-UI-Out-Filterresults: notjunk:1;V01:K0:je7B1ag854o=:3qptMW19rIXTqWIbAChQmX N9ziss8EFKdA7ZOt7jV6NztKlWnt5+D080zB1ja9BECnVKMsCuWuFoVay2dsOzJbDJnosw+su GLTNSh/9LJUmuTaKGD7hNtty1EkcI94Fu3g6yszdP1yqjcKEjgTon/DKpPVjN3iZq+/ISpd38 DOSm0AZrdK8OhW695KxyW/Wb9dNryJ5thvM1H9qo98wkblNM+bGmbzP9/uRDpYGYKpfIIyd0+ Ocja7d2Lj9zXMeEq17ETqJdZpJ0x8fUzCnxHpuTYPbVv+kpFfS7Zwou4wMdEiARIkM33T9D+k kQgxgJvQrtJKBEjvVa4UYnH66VWQp2MambUo3VZC0UYkbn22QGa907BaAqMuxOLdkarfs6Pu7 wDOxHp00TEu3NzehMcnTf/mRxPZvSEZZ2LQ5Y8AxPR3zbmZt/Medlt1SDzv2ThyugwcO7YsU4 mPo865BeYiQ/ibtVfhB4mbwd6rBRrIAeKMZxUNaKb7lPikLWi3reTAaxBtPpCKqP9Kcdpx5ty gG8asI7n/AB+IVaBCE3YMk6J474GWaGDJQYt1fsyztJN/uA3i5OyJn3Sw+RtrsQA9VYAQE9ss hu62ZldSdb5gPrWH7iw6gms89Ng/74T/2uMawjTuizZfhBIZLu4+p5cfFL3JEwrzTHfiJaGKE dRLRmisgY95EIjLqXsLnaL1myVXKEP3U9VsbMrcrdrO9Q1ZzsM2MhRKklLkZPJlMJGm6Y8f4o c285GePk1HWUPvsAblSzoVXSOSgA4g3PTwueL7QsRQ343LVFHfoMWI3JHiRXHcXXSNkLJD+tg tXWltFoOHcJGosUfqC9FZmQAMUL5fVe97BCHURPLOu5GdFxlP4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29225-done Cc: 29225-done@debbugs.gnu.org, shuguang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 26.1 Michael Albinus writes: > I've committed the patch to the emacs-26 branch. Shuguang, do you have a > chance to check this? No News Are Good News. I'm closing the bug. Best regards, Michael. From unknown Sun Jun 22 07:57:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Feb 2018 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator