Subject: Re: [bug#29221] [PATCH 05/19] gnu: Add java-mail.

From: ng0 <[email-masked]>
Date: Wed, 8 Nov 2017 23:03:19 +0000

[email-masked] transcribed 3.8K bytes:
> From: Julien Lepiller <[email-masked]>
> 
> * gnu/packages/java.scm (java-mail): New variable.

I didn't follow any of the past Java commits, but
shouldn't this mention:

> * gnu/packages/java.scm (java-jboss-jms-api-spec): New variable.

as well? Only recently I learned that python with python2 variants
in the same commit should mention both, so I guess this
applies here aswell if java-mail can not build without
the java-jboss-jms-api-spec.
However, just from reading the definitions it's not clear to
me why the 2 were bundled.

> ---
>  gnu/packages/java.scm | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 37e3f5180..67805bae7 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -6949,3 +6949,80 @@ done to the IDE or continuous integration servers which simplifies adoption.")
>         ("reflect" ,java-powermock-reflect)
>         ("support" ,java-powermock-api-support)
>         ("cglib" ,java-cglib)))))
> +
> +(define-public java-jboss-jms-api-spec
> +  (package
> +    (name "java-jboss-jms-api-spec")
> +    (version "2.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/jboss/jboss-jms-api_spec/"
> +                                  "archive/jboss-jms-api_" version
> +                                  "_spec-1.0.1.Final.tar.gz"))
> +              (sha256
> +               (base32
> +                "07bqblw9kq2i8q92bz70fvavq5xjfkaixl8xa0m0cypjgy82rb7m"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:jar-name "java-jboss-jms-api_spec.jar"
> +       #:jdk ,icedtea-8
> +       #:source-dir "."
> +       #:tests? #f)); no tests
> +    (home-page "https://github.com/jboss/jboss-jms-api_spec")
> +    (synopsis "Java Message Service API specification")
> +    (description "Java Message Service (JMS) API is used to send messages
> +messages between two or more clients.  It is a messaging standard that allows
> +application components to create, send, receive, and read messages.")
> +    ; either gpl2 only with GPL Classpath Exception, or cddl.
> +    (license (list license:gpl2 license:cddl1.0))))
> +
> +(define-public java-mail
> +  (package
> +    (name "java-mail")
> +    (version "1.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/javaee/javamail/archive/"
> +                                  "JAVAMAIL-1_6_0.tar.gz"))
> +              (sha256
> +               (base32
> +                "1b4rg7fpj50ld90a71iz2m4gm3f5cnw18p3q3rbrrryjip46kx92"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:jar-name "java-mail.jar"
> +       #:jdk ,icedtea-8
> +       #:source-dir "mail/src/main/java"
> +       #:test-dir "mail/src/test"
> +       #:test-exclude
> +       (list "**/CollectorFormatterTest.java"
> +             "**/CompactFormatterTest.java"
> +             "**/DurationFilterTest.java"
> +             "**/MailHandlerTest.java"
> +             "**/GetLocalAddressTest.java"
> +             ;; FIXME: both end with:
> +             ;; java.lang.ClassNotFoundException:
> +             ;; javax.mail.internet.MimeMultipartParseTest
> +             "**/MimeMultipartParseTest.java"
> +             "**/SearchTermSerializationTest.java")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'move-version.java
> +           (lambda _
> +             (copy-file "mail/src/main/resources/javax/mail/Version.java"
> +                        "mail/src/main/java/javax/mail/Version.java")))
> +         (add-before 'build 'copy-resources
> +           (lambda _
> +             (copy-recursively "mail/src/main/resources/META-INF"
> +                               "build/classes/META-INF")
> +             #t)))))
> +    (native-inputs
> +     `(("junit" ,java-junit)
> +       ("hamcrest" ,java-hamcrest-core)))
> +    (home-page "https://javaee.github.io/javamail/")
> +    (synopsis "Mail-related functionnalities in Java")
> +    (description "The JavaMail API provides a platform-independent and
> +protocol-independent framework to build mail and messaging applications.")
> +    ;; General Public License Version 2 only ("GPL") or the Common Development
> +    ;; and Distribution License("CDDL")
> +    (license (list license:cddl1.1
> +                   license:gpl2)))); with classpath exception
> -- 
> 2.15.0
> 
> 
> 
> 
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
  WWW: https://ng0.infotropique.org