GNU bug report logs - #29206
Make xref-show-xrefs-function a defcustom

Previous Next

Package: emacs;

Reported by: Fritz Stelzer <brotzeitmacher <at> gmail.com>

Date: Wed, 8 Nov 2017 09:44:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 29206 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>, Fritz Stelzer <brotzeitmacher <at> gmail.com>
Cc: 29206 <at> debbugs.gnu.org
Subject: Re: bug#29206: Make xref-show-xrefs-function a defcustom
Date: Sun, 19 Nov 2017 01:42:17 +0200

On 11/18/17 12:14 PM, Eli Zaretskii wrote:

>> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer
>> -  "Function to display a list of xrefs.")
>> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
>> +  "Function to display a list of xrefs."
>> +  :type 'function)
>>   
>>   (defvar xref--read-identifier-history nil)
> 
> Dmitry, any comments on this?  (If accepted, the defcustom should have
> a :version tag.)

I don't really see the point, yet: we don't offer any alternative 
functions, and if the user is going to write one, `setq' is just as easy 
to do.

Further, applying this kind of minor change (and finding it important) 
seems like it would indicate that xref is kind of "stable", which it is 
not, so far.
This bug report was last modified 6 years and 50 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.