From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Fritz Stelzer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29206@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151013422023391 (code B ref -1); Wed, 08 Nov 2017 09:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2017 09:43:40 +0000 Received: from localhost ([127.0.0.1]:57603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCMtY-00065D-Ha for submit@debbugs.gnu.org; Wed, 08 Nov 2017 04:43:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCMtX-000651-Et for submit@debbugs.gnu.org; Wed, 08 Nov 2017 04:43:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCMtR-00045Z-6o for submit@debbugs.gnu.org; Wed, 08 Nov 2017 04:43:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCMtR-00045T-3b for submit@debbugs.gnu.org; Wed, 08 Nov 2017 04:43:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCMtP-00072f-Ur for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 04:43:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCMtP-00044g-0t for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 04:43:31 -0500 Received: from mail-yw0-x22a.google.com ([2607:f8b0:4002:c05::22a]:47967) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCMtO-00044I-SN for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 04:43:30 -0500 Received: by mail-yw0-x22a.google.com with SMTP id u142so1782289ywg.4 for ; Wed, 08 Nov 2017 01:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=0KpXWE75X6dGmRXaenEO8HOPUcH2RXFm/mn3AJJqeWc=; b=g53GpTbzg/ckj0yMjKaj/bw6mN5CIVJ5L4rIZBCwoluUFwFSZlL012x2eHkFumWtZn Kss09vbNTtqsqMPekw3dynWNcZJHxDjioYgAsjSqkoGkY/32w5pAva0S5zhaxWeCPHX+ 06WziJYowyvxkJ7iuN1sZcsL+hpLQ3R0l2NqEj9NlII5CCOjKDL8TVblQAnTgFkg0Xlk nD5GQMYPfEB+pr3tYMcjEBo+ukWTGhbmSmuGwijEXq7Phcm93L7EfA3e09Pu0VA/TOva Fk4gWKzIFx74SQyLed8OO5PZMqZV3algUTrLirsJUev0REu4xv3aNAKVJDkvAwhbfb2t N0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=0KpXWE75X6dGmRXaenEO8HOPUcH2RXFm/mn3AJJqeWc=; b=JLLykuQyRrqd/yz0t+Be5fjs77WYqVsX4b2EoXDblTk0LxflAOC7HOHWBbHZ+bxVtT f8YtdM4IX2b2zT8FM5UTJMfBhBKyhGU6sHctIYT2t2QNUHsiJN5VJ58+e0hJa3hdicTw lpT2UNE1TrhTO3/awUTxPjrgdu2xfM+en/CkdDkM3W3Y+ryEOQ2Ce5J79GrTmznzeRbr WSPCob8kjSgFcKE5RAtC4oafPedjZX+zFfkplwEbWAaIctbVCp53QRUZTW2y09jCg5Hj Yfzy52tOp2w8PaVli0moGI7eI55nnM920FU4m+eimAofnfF62/2/zvwC/Au88ODRJNm5 umvA== X-Gm-Message-State: AJaThX44HUAQYX6dPzbsUD8DmWjoS+KHIlgZSONWGMcBsVpUcwRGWws6 MnWumqQunPMODGktRd++96RCt1g7LleqsScTbJnvZg== X-Google-Smtp-Source: ABhQp+R1qakW55VVIUgG6tLFG/gQMT1z4iWC2Z/U/pFqt7105UKnwA53eLS9Mf45CAevyJfhFkO5K+WhovOm0npFRLQ= X-Received: by 10.37.164.200 with SMTP id g66mr945026ybi.28.1510134209707; Wed, 08 Nov 2017 01:43:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.41.85 with HTTP; Wed, 8 Nov 2017 01:43:29 -0800 (PST) From: Fritz Stelzer Date: Wed, 8 Nov 2017 10:43:29 +0100 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c13ad1e2202ec055d758548" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --94eb2c13ad1e2202ec055d758548 Content-Type: text/plain; charset="UTF-8" master c89870d7ef8b59febba9060f0da25b24403c2e08 Author: brotzeit AuthorDate: Wed Nov 8 10:39:57 2017 +0100 Commit: brotzeit CommitDate: Wed Nov 8 10:39:57 2017 +0100 Parent: 83dc3f0e9b * lisp/net/tramp-cmds.el, lisp/allout.el: Avoid custom-set-variables Merged: master Containing: master Follows: emacs-25.1 (130661) Make xref-show-xrefs-function a defcustom 1 file changed, 3 insertions(+), 2 deletions(-) lisp/progmodes/xref.el | 5 +++-- modified lisp/progmodes/xref.el @@ -738,8 +738,9 @@ xref--show-xref-buffer ;; The controversial multiple definitions case is handed off to ;; xref-show-xrefs-function. -(defvar xref-show-xrefs-function 'xref--show-xref-buffer - "Function to display a list of xrefs.") +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer + "Function to display a list of xrefs." + :type 'function) (defvar xref--read-identifier-history nil) --94eb2c13ad1e2202ec055d758548 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
master c89870d7ef8b59febba9060f0da25b24403c2e08
Author:= =C2=A0=C2=A0=C2=A0=C2=A0 brotzeit <brotzeitmacher@gmail.com>
AuthorDate: Wed Nov 8 10:39:57 2= 017 +0100
Commit:=C2=A0=C2=A0=C2=A0=C2=A0 brotzeit <brotzeitmacher@gmail.com>
CommitDate: = Wed Nov 8 10:39:57 2017 +0100

Parent:=C2=A0=C2=A0=C2=A0=C2=A0 83dc3f= 0e9b * lisp/net/tramp-cmds.el, lisp/allout.el: Avoid custom-set-variablesMerged:=C2=A0=C2=A0=C2=A0=C2=A0 master
Containing: master
Follows:= =C2=A0=C2=A0=C2=A0 emacs-25.1 (130661)

Make xref-show-xrefs-function= a defcustom

1 file changed, 3 insertions(+), 2 deletions(-)
lisp= /progmodes/xref.el | 5 +++--

modified=C2=A0=C2=A0 lisp/progmodes/xre= f.el
@@ -738,8 +738,9 @@ xref--show-xref-buffer
=C2=A0;; The controve= rsial multiple definitions case is handed off to
=C2=A0;; xref-show-xref= s-function.
=C2=A0
-(defvar xref-show-xrefs-function 'xref--show-= xref-buffer
-=C2=A0 "Function to display a list of xrefs.")+(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
+=C2= =A0 "Function to display a list of xrefs."
+=C2=A0 :type '= function)
=C2=A0
=C2=A0(defvar xref--read-identifier-history nil)
= =C2=A0
--94eb2c13ad1e2202ec055d758548-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 14:57:00 2017 Received: (at control) by debbugs.gnu.org; 9 Nov 2017 19:57:00 +0000 Received: from localhost ([127.0.0.1]:60836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCswd-0005Hy-Sq for submit@debbugs.gnu.org; Thu, 09 Nov 2017 14:57:00 -0500 Received: from mail-wr0-f170.google.com ([209.85.128.170]:49359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCswc-0005Hm-Ev for control@debbugs.gnu.org; Thu, 09 Nov 2017 14:56:58 -0500 Received: by mail-wr0-f170.google.com with SMTP id o88so6654378wrb.6 for ; Thu, 09 Nov 2017 11:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=nWF6lthTUqQWAN3QAuEoR81ABlNiTvyvgCwSe+pBIls=; b=t9mgNue4+kIiJEgvnpUp2M4xDyyeYvCkRbHqcv8/Z2KNPUZvW/fKyqp9Iw5rCNI0+8 Q98k5GlZbTy0K+/WAtKyAtQdPZDvtwBmrRjDzpF1jJG8X202fwb7/0li1AKM+V7J8/CB kxBiGEBMwVvIde4ob8kftW3vqtcEtXYvf9eCCr0tG0hXksHa06BV5Yx/+hmMmGpKHbTe 65OfUSvRzWo0WuEYFA/AITXOfx4+UWvrDZMSzkhqwaQ/PkN0rliJuf1ERBl5Top7JxBC yN83/jIPbttM+Q/0VRlkqFsj6OZK5FSqYYtBpPY6Nzk8MN5cHDNj1t9qyL08JSfEXgtM AgCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=nWF6lthTUqQWAN3QAuEoR81ABlNiTvyvgCwSe+pBIls=; b=F+FjoPUQ/sNy3HoT6g5xcpiTdMDc33T+bUEU/4ItKqg19Gu4pfHw7w+QpMNDCoSdqk GVFtChE2nacfdwOfUzxC4Mm2tB0E44xNNuiRL0999/jx21nSXV5gaN5a8aL8uvDENXPf QSeI+sBvTea/7p+3yGQK7Ms/X0BfcZn3BIui/6NcnY4eArgqiENvPvtPN4pA0yKfYkfB sFTJIqRGcyozQD1CGtGcTFfzJyEJq/sPdYXfXIvHKaOcZqNvXVXFE7OaD6usFeEiWKHh yuQG/EvfWcdiHQebcxod9JXD+JsAdec9wYheNyWnvmez83bDxcGKhVCKwp3d8ZDqxdPO X70A== X-Gm-Message-State: AJaThX40skfCwABiIZokFkdx2aaLMubysK+hr/xw0kU8BH/dl5u05J39 ejUjeADF1DgxbBdJxknaeCErxNxcYc89I5abdP97BA== X-Google-Smtp-Source: ABhQp+Tg4ibmn+xRq6Ertj9PyX8ByOZAMMKyIW1nva5ZkjNrN8zve5GXkLu2g7wAle/yvdg2EGcBYpQl/IZFBUgBqdg= X-Received: by 10.223.189.13 with SMTP id j13mr1482527wrh.94.1510257412663; Thu, 09 Nov 2017 11:56:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.146.227 with HTTP; Thu, 9 Nov 2017 11:56:52 -0800 (PST) From: Noam Postavsky Date: Thu, 9 Nov 2017 14:56:52 -0500 X-Google-Sender-Auth: DVypzX4AQMQKNCUeVnw91NGc8GE Message-ID: Subject: Bug#29206: Make xref-show-xrefs-function a defcustom To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) tags 29206 + patch From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2017 10:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Fritz Stelzer , Dmitry Gutov Cc: 29206@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.15110001131449 (code B ref 29206); Sat, 18 Nov 2017 10:16:02 +0000 Received: (at 29206) by debbugs.gnu.org; 18 Nov 2017 10:15:13 +0000 Received: from localhost ([127.0.0.1]:45564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG09Z-0000NI-7M for submit@debbugs.gnu.org; Sat, 18 Nov 2017 05:15:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG09Y-0000N6-Al for 29206@debbugs.gnu.org; Sat, 18 Nov 2017 05:15:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eG09P-0006h5-Jg for 29206@debbugs.gnu.org; Sat, 18 Nov 2017 05:15:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eG09P-0006h1-G2; Sat, 18 Nov 2017 05:15:03 -0500 Received: from [176.228.60.248] (port=4531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eG09N-0008RO-Bf; Sat, 18 Nov 2017 05:15:02 -0500 Date: Sat, 18 Nov 2017 12:14:48 +0200 Message-Id: <83wp2ngag7.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fritz Stelzer on Wed, 8 Nov 2017 10:43:29 +0100) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Fritz Stelzer > Date: Wed, 8 Nov 2017 10:43:29 +0100 > > master c89870d7ef8b59febba9060f0da25b24403c2e08 > Author: brotzeit > AuthorDate: Wed Nov 8 10:39:57 2017 +0100 > Commit: brotzeit > CommitDate: Wed Nov 8 10:39:57 2017 +0100 > > Parent: 83dc3f0e9b * lisp/net/tramp-cmds.el, lisp/allout.el: Avoid custom-set-variables > Merged: master > Containing: master > Follows: emacs-25.1 (130661) > > Make xref-show-xrefs-function a defcustom > > 1 file changed, 3 insertions(+), 2 deletions(-) > lisp/progmodes/xref.el | 5 +++-- > > modified lisp/progmodes/xref.el > @@ -738,8 +738,9 @@ xref--show-xref-buffer > ;; The controversial multiple definitions case is handed off to > ;; xref-show-xrefs-function. > > -(defvar xref-show-xrefs-function 'xref--show-xref-buffer > - "Function to display a list of xrefs.") > +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer > + "Function to display a list of xrefs." > + :type 'function) > > (defvar xref--read-identifier-history nil) Dmitry, any comments on this? (If accepted, the defcustom should have a :version tag.) From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2017 23:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Fritz Stelzer Cc: 29206@debbugs.gnu.org Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.151104854824208 (code B ref 29206); Sat, 18 Nov 2017 23:43:01 +0000 Received: (at 29206) by debbugs.gnu.org; 18 Nov 2017 23:42:28 +0000 Received: from localhost ([127.0.0.1]:46622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGCkm-0006IO-FE for submit@debbugs.gnu.org; Sat, 18 Nov 2017 18:42:28 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:46480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGCkk-0006IB-Uj for 29206@debbugs.gnu.org; Sat, 18 Nov 2017 18:42:27 -0500 Received: by mail-wm0-f48.google.com with SMTP id u83so4061456wmb.5 for <29206@debbugs.gnu.org>; Sat, 18 Nov 2017 15:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C7/aiovS1TvP9UbsUBD2hRGZ690gX4ae4pPqaXXLiMo=; b=TVnXtYitIVgXM2xdV3Uoq+0tBl0SI8+SHlsl+qxOdmq07aentHDWvbehtsz/4UIqpb px0MRf7OgUwc1bWwjpW7qiU5Kpc8016rf4eOHGi0iQDlR0OHfP6eKYVj6QqNKRTg9p40 3qn9bTAsdPYhOwzeIgB7FHpUEy7Z0eWGX8I3ke2k5+Q9qYmUMwS4nvQOZmxeiF0zS6g9 7MTUicbgg3hTqruEuNucRwiMCNDudCk3vHK4bByTezvi+nQTtby/KSj7EAaGAE8cwHwX dBki01tEbH9HrIZ0MXUCxnKzSrWwH6GZNwMGncCI2sxSl0QpQo5rcESNbo5O6nFhvQMD /c2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C7/aiovS1TvP9UbsUBD2hRGZ690gX4ae4pPqaXXLiMo=; b=g7RhLNncdl4JT+92QguZHrAWpv+Mf2yWzgG4Lrg3sS2d7rcW8AUx2y8Dwjgivwu4Wd qLG71iRlFuR0FD1vxueJX659NJEm3FcPkHPhOgDoiz5JGQKHCrkvp/a/FCl8setdhf0P lwN1peoC3zeoy93xga/OnLCTfpJ0CbBse2s37rYzJero3u0vb+bNKuzqJFYGjQE/0fMb 5N5fhtEP4gIX3xojQBn9N/wUUZXhw3tZtE3h5J1sVL5hkZ9+lQawWwjsMoWrr0pgQ8ws N3fcxuVTd+2Z45bqUFkdDOUc1JsFLrz2axr2vwY3KHGw6b9WBOBr8LRTknqkMjDJ3ZDD STqQ== X-Gm-Message-State: AJaThX40S3U1i1eySBCa4uqB8J5Ixs+IE5vwN3yUtIxSuN7DDN9CemeQ DFx6D0Iz3MilxGyxZJt0YQ4q8nGw X-Google-Smtp-Source: AGs4zMbEUcSW/cldrCLUgWQSwir+yYUim4zLeoxv8msVQ2tPQpO+JQQhdPTN6+PsEwjFsbac39iAOQ== X-Received: by 10.28.13.212 with SMTP id 203mr6923499wmn.141.1511048540844; Sat, 18 Nov 2017 15:42:20 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id k5sm7771238wmg.21.2017.11.18.15.42.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2017 15:42:19 -0800 (PST) References: <83wp2ngag7.fsf@gnu.org> From: Dmitry Gutov Message-ID: <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> Date: Sun, 19 Nov 2017 01:42:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 MIME-Version: 1.0 In-Reply-To: <83wp2ngag7.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 11/18/17 12:14 PM, Eli Zaretskii wrote: >> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer >> - "Function to display a list of xrefs.") >> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer >> + "Function to display a list of xrefs." >> + :type 'function) >> >> (defvar xref--read-identifier-history nil) > > Dmitry, any comments on this? (If accepted, the defcustom should have > a :version tag.) I don't really see the point, yet: we don't offer any alternative functions, and if the user is going to write one, `setq' is just as easy to do. Further, applying this kind of minor change (and finding it important) seems like it would indicate that xref is kind of "stable", which it is not, so far. From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2017 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: brotzeitmacher@gmail.com, 29206@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.15111053023120 (code B ref 29206); Sun, 19 Nov 2017 15:29:02 +0000 Received: (at 29206) by debbugs.gnu.org; 19 Nov 2017 15:28:22 +0000 Received: from localhost ([127.0.0.1]:47668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGRW9-0000oG-QU for submit@debbugs.gnu.org; Sun, 19 Nov 2017 10:28:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGRW7-0000o0-RX for 29206@debbugs.gnu.org; Sun, 19 Nov 2017 10:28:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGRVz-0002j9-EW for 29206@debbugs.gnu.org; Sun, 19 Nov 2017 10:28:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGRVz-0002j2-2O; Sun, 19 Nov 2017 10:28:11 -0500 Received: from [176.228.60.248] (port=1914 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eGRVy-0004U5-HV; Sun, 19 Nov 2017 10:28:10 -0500 Date: Sun, 19 Nov 2017 17:28:00 +0200 Message-Id: <837eumffun.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> (message from Dmitry Gutov on Sun, 19 Nov 2017 01:42:17 +0200) References: <83wp2ngag7.fsf@gnu.org> <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 29206@debbugs.gnu.org > From: Dmitry Gutov > Date: Sun, 19 Nov 2017 01:42:17 +0200 > > On 11/18/17 12:14 PM, Eli Zaretskii wrote: > > >> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer > >> - "Function to display a list of xrefs.") > >> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer > >> + "Function to display a list of xrefs." > >> + :type 'function) > >> > >> (defvar xref--read-identifier-history nil) > > > > Dmitry, any comments on this? (If accepted, the defcustom should have > > a :version tag.) > > I don't really see the point, yet: we don't offer any alternative > functions, and if the user is going to write one, `setq' is just as easy > to do. > > Further, applying this kind of minor change (and finding it important) > seems like it would indicate that xref is kind of "stable", which it is > not, so far. Fine with me, then please close as "wontfix". From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2017 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: brotzeitmacher@gmail.com, 29206@debbugs.gnu.org Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.15112163118794 (code B ref 29206); Mon, 20 Nov 2017 22:19:01 +0000 Received: (at 29206) by debbugs.gnu.org; 20 Nov 2017 22:18:31 +0000 Received: from localhost ([127.0.0.1]:49598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGuOc-0002Hl-P5 for submit@debbugs.gnu.org; Mon, 20 Nov 2017 17:18:30 -0500 Received: from mail-wr0-f171.google.com ([209.85.128.171]:40097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGuOb-0002HX-1f for 29206@debbugs.gnu.org; Mon, 20 Nov 2017 17:18:29 -0500 Received: by mail-wr0-f171.google.com with SMTP id s41so4073687wrc.7 for <29206@debbugs.gnu.org>; Mon, 20 Nov 2017 14:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d/QpRDEOHQpwKaMqHT2LvVICE65onq/di4Ud2oIcOzs=; b=dgQ/e4P/6SpQOJlffRaxi6OLCOyTylPvvg4xVHWPQKIQb5/s0gRJRzsDxESEzzrtPc or5+mBvOBUACGSerQqYbPtEabVTud2n72ix+DaFHh5NREdleULrdg2YOOXvaj6STQ1y+ WVh3NvTobk7rufOsoaBraGV/IqDtfulzvsuIA+Fy6SKryosy4ttNUxnA4fPZrTwE6ilS GncfrK3em7ApWyi8OQ/reuuCTQd4TAOUgc89fMLQwiHOjMx16Rde8fFUDjxhxkW4O3kC eptFMbmJ+kfCUpKfJ+zXBnMdkCKUXckp5RKdO4+u6YubeiwHkmYkG7RfS+DAS3Fv3LHt lZlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d/QpRDEOHQpwKaMqHT2LvVICE65onq/di4Ud2oIcOzs=; b=N3TyyI7tPbqvlrOivPsxUbYinqbkWRWyqEjjhNIJH9f4PJLe0jG9uROqv92WajETLn PvH4pMTb6pUX3Fh6lz1tFWVS7/Tn5+MP2h58vrPniT61iezz71fVpT/ztJlPlIEMovcP ixXSXAFdNv4MwIV234uN8PURIVpBU3qU79+bqQLo85LJESGMLcK6zYl3I9CyZdWqonzf +62x7wl36dWC41pRVw4rfmWHgImp+uMYy2ULtLoDv5FrDeLTHibGsDqWt9WjGjx+tDX0 6EoGUweCsdf7em5KKbOseOKYhUpxivibiKir0In9hbO3vUpjI3GcT0Tlq3SgGIMeGnv1 FX3w== X-Gm-Message-State: AJaThX48OuoWjUlXl4odNSmD7F79GK0gm3c7/rQyjusF+jixCqsR6Lrv pcPbvuOeFb6gGL7+AiW+9z19Jcob X-Google-Smtp-Source: AGs4zMYpGqVQ6owxLzY2r1/o/MCUlZSlFXMJE/M1Dr9BAgui2XHQAWAnKRQaPvG2qN+mTgPz4tpgwA== X-Received: by 10.223.190.134 with SMTP id i6mr13758354wrh.177.1511216302959; Mon, 20 Nov 2017 14:18:22 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id d9sm4411108wrf.45.2017.11.20.14.18.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2017 14:18:21 -0800 (PST) References: <83wp2ngag7.fsf@gnu.org> <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> <837eumffun.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Tue, 21 Nov 2017 00:18:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Thunderbird/57.0 MIME-Version: 1.0 In-Reply-To: <837eumffun.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) On 11/19/17 5:28 PM, Eli Zaretskii wrote: > Fine with me, then please close as "wontfix". If you don't mind, I'd rather keep it open for now. And close it if the situation doesn't change, say, within the next development cycle. From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: brotzeitmacher@gmail.com, Eli Zaretskii , 29206@debbugs.gnu.org Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.156140830214451 (code B ref 29206); Mon, 24 Jun 2019 20:32:01 +0000 Received: (at 29206) by debbugs.gnu.org; 24 Jun 2019 20:31:42 +0000 Received: from localhost ([127.0.0.1]:58126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfVcq-0003kz-GR for submit@debbugs.gnu.org; Mon, 24 Jun 2019 16:31:42 -0400 Received: from quimby.gnus.org ([80.91.231.51]:36056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfVco-0003kp-16 for 29206@debbugs.gnu.org; Mon, 24 Jun 2019 16:31:38 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfVcj-0007Pj-Rm; Mon, 24 Jun 2019 22:31:36 +0200 From: Lars Ingebrigtsen References: <83wp2ngag7.fsf@gnu.org> <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> <837eumffun.fsf@gnu.org> Date: Mon, 24 Jun 2019 22:31:33 +0200 In-Reply-To: (Dmitry Gutov's message of "Tue, 21 Nov 2017 00:18:19 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > On 11/19/17 5:28 PM, Eli Zaretskii wrote: > >> Fine with me, then please close as "wontfix". > > If you don't mind, I'd rather keep it open for now. And close it if > the situation doesn't change, s [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 11/19/17 5:28 PM, Eli Zaretskii wrote: > >> Fine with me, then please close as "wontfix". > > If you don't mind, I'd rather keep it open for now. And close it if > the situation doesn't change, say, within the next development cycle. That was a year and a half ago -- what's your opinion now? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 23:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: brotzeitmacher@gmail.com, Eli Zaretskii , 29206@debbugs.gnu.org Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.156141939225794 (code B ref 29206); Mon, 24 Jun 2019 23:37:02 +0000 Received: (at 29206) by debbugs.gnu.org; 24 Jun 2019 23:36:32 +0000 Received: from localhost ([127.0.0.1]:58372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfYVi-0006hx-Vz for submit@debbugs.gnu.org; Mon, 24 Jun 2019 19:36:32 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:46037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfYVh-0006he-PD for 29206@debbugs.gnu.org; Mon, 24 Jun 2019 19:36:30 -0400 Received: by mail-wr1-f46.google.com with SMTP id f9so15646199wre.12 for <29206@debbugs.gnu.org>; Mon, 24 Jun 2019 16:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pmC6UK3joVcYK2Wdv2PuFzm/Lj2gsBIhl7XPKfJsqIk=; b=vQoPezyRNYv9n5wxQue2hwVg1cZ4OCc+xUnOjvkXHFHEJVyKMOK5jZZEyv2MAFyKvC Mr0E+DOoDNl9PZB4r4zAB6rkyOgcXDmoZAOM672kkE2E6vnwUhWdvJc57gQGf/qy1dcx /lMZesxuNCBclorYqhD7ddS70kYBBCzCLKgPM1zYpz+6zMWnBVR3oynca6Pdn/mwXQYF welXQtIEb9uueIxL0y4Du0SfMtxf7m1FzytMd4p9k4jCInWu8+v7aMdt5MgwucSMGAfn avYtetmd5TvYQbYCR9m4ByaOMlUl0AGLA0NfeVEFx47/Es/MvI5Cjh1sPSzzyP2hwROE S4nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pmC6UK3joVcYK2Wdv2PuFzm/Lj2gsBIhl7XPKfJsqIk=; b=bYSn8Zx1laNfmZg2ud5I0iqmuzLGuTNBbjlPqgbjzQR2zC98kTgvSGLMcVjjy7rTnO EJjRP6F7wtoSZ9NWFwX6MfLSYmiBOxLqlANfiT45nMSWcIQplaAowfvPFuHBfziQQp9e 7B7Fd45BGD3oZkh7glBMZIdpUcNG1XpghzPfjM/62V8ZeIZPPMySR6hxbt/KSiZC8RFv hKlWiiB3mmMfpg32AMp5GINlteyehJ4phnIfX5Xq7vTI7ezBwGjVdG0TlEFq1nNkc+N1 3HvCSYT7T89kBJ+sar5hFGiRfW0PtHVwkdBEFyU8bD/6f0Z3QBHD+OTdWuKFsWl763Hc T1dw== X-Gm-Message-State: APjAAAU47S3wBUzb7X2ZG+qrSBQKs/lkByogmgENViH5U23SMeIrRNy9 bfUQJh5kgrdf/l0YxUmwcb1bMuSQRcI= X-Google-Smtp-Source: APXvYqzE7yOMlfxNqmnuysIMxSYpQmXQ57uPb3NJi/Iz7SAU5Fh7TzmKQWdFyJGd+CN9qNOQ3qgpEg== X-Received: by 2002:a5d:5386:: with SMTP id d6mr15857453wrv.207.1561419383561; Mon, 24 Jun 2019 16:36:23 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id l17sm13590479wrq.37.2019.06.24.16.36.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 16:36:22 -0700 (PDT) References: <83wp2ngag7.fsf@gnu.org> <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> <837eumffun.fsf@gnu.org> From: Dmitry Gutov Message-ID: <0229b8a6-37b9-bfec-8f65-6f34ec596e72@yandex.ru> Date: Tue, 25 Jun 2019 02:36:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 24.06.2019 23:31, Lars Ingebrigtsen wrote: > That was a year and a half ago -- what's your opinion now? I'd be fine with it now. Though the surrounding code has changed a bit and the patch doesn't apply anymore. The same change would need to be made for xref-show-definitions-function as well, I think. From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 11:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: brotzeitmacher@gmail.com, Eli Zaretskii , 29206@debbugs.gnu.org Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.15614610003745 (code B ref 29206); Tue, 25 Jun 2019 11:10:02 +0000 Received: (at 29206) by debbugs.gnu.org; 25 Jun 2019 11:10:00 +0000 Received: from localhost ([127.0.0.1]:58729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjKq-0000yJ-2c for submit@debbugs.gnu.org; Tue, 25 Jun 2019 07:10:00 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjKo-0000yB-CS for 29206@debbugs.gnu.org; Tue, 25 Jun 2019 07:09:58 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfjKk-0007H6-OR; Tue, 25 Jun 2019 13:09:57 +0200 From: Lars Ingebrigtsen References: <83wp2ngag7.fsf@gnu.org> <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> <837eumffun.fsf@gnu.org> <0229b8a6-37b9-bfec-8f65-6f34ec596e72@yandex.ru> Date: Tue, 25 Jun 2019 13:09:54 +0200 In-Reply-To: <0229b8a6-37b9-bfec-8f65-6f34ec596e72@yandex.ru> (Dmitry Gutov's message of "Tue, 25 Jun 2019 02:36:21 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > I'd be fine with it now. Though the surrounding code has changed a bit > and the patch doesn't apply anymore. > > The same change would need to be made for > xref-show-definitions-function as well, [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > I'd be fine with it now. Though the surrounding code has changed a bit > and the patch doesn't apply anymore. > > The same change would need to be made for > xref-show-definitions-function as well, I think. OK; I've now made these changes. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 07:10:04 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 11:10:04 +0000 Received: from localhost ([127.0.0.1]:58733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjKu-0000z5-Ax for submit@debbugs.gnu.org; Tue, 25 Jun 2019 07:10:04 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfjKs-0000ye-AK for control@debbugs.gnu.org; Tue, 25 Jun 2019 07:10:02 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfjKp-0007HG-QR for control@debbugs.gnu.org; Tue, 25 Jun 2019 13:10:01 +0200 Date: Tue, 25 Jun 2019 13:09:59 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #29206 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 29206 fixed close 29206 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 29206 fixed close 29206 27.1 quit From unknown Thu Sep 11 03:11:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29206: Make xref-show-xrefs-function a defcustom Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Lars Ingebrigtsen Cc: brotzeitmacher@gmail.com, 29206@debbugs.gnu.org Received: via spool by 29206-submit@debbugs.gnu.org id=B29206.156146957218307 (code B ref 29206); Tue, 25 Jun 2019 13:33:02 +0000 Received: (at 29206) by debbugs.gnu.org; 25 Jun 2019 13:32:52 +0000 Received: from localhost ([127.0.0.1]:58957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflZ6-0004lD-0u for submit@debbugs.gnu.org; Tue, 25 Jun 2019 09:32:52 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:54528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflZ3-0004kz-9U for 29206@debbugs.gnu.org; Tue, 25 Jun 2019 09:32:49 -0400 Received: by mail-wm1-f51.google.com with SMTP id g135so2852902wme.4 for <29206@debbugs.gnu.org>; Tue, 25 Jun 2019 06:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=x2hRgy5a2CQG7uN1r+8mUvI+fTaJ+r86IJHeSHhZl5M=; b=DJtriDHIBy6/jYSftM9hRM+KYEbc28wVo07AK9sNJ3OO6qiGyfiIE0nIBD1HO22zDf mZoUcXt8TI5EpxZm4XASEycHVRA7WNLMOB2i1jlrFF88PbXH3D8D2ANxWyHIrmIdGOgU i2TVJxFNl9m9e/M/NMJfsNH3yx7/mLKEwkfv+cYUin8mD8g6YJKJ5sXslbAO9nqIwhI6 MHrJcyl8FiYVoRWiqVYIcDyLWvHVrHnqy3Na3FrYfcnUes8VwFkXEsgIBem8+o8Oy0nl 0zn3CtwvytldE46ApZpYJFJP1XEHWpFPEZ902/IyeCCy7/CWESFAmnN8SnBo7o/0yKAh N1qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x2hRgy5a2CQG7uN1r+8mUvI+fTaJ+r86IJHeSHhZl5M=; b=EbV+o7gPO5ng1SP0MqGRCbK68tATssj4X6qjuubMRPrDQogZJRvjAPx0HIZ5dqpkKS zJnsS/+xOH6iZjVTsJVyMv0AbnLJGMBcAE+VLqSZ01z2m1jTAjNi/sn7lEsccAo0K7TZ mlQE/0Rw3ZwNSldqVVaUS5gluaJ7ppy9/H9UaJQHDyX1b6R1SVeJ59ct/S5RRh06Q7wC YfIr6nCFGyhmF/b410duQZe5c/oiVBtWNQm5DwCsdNLBFnVJ+3cjkBjJwXcSq04D67X0 +L83C/QkYX39ZOuSzZO89sNFFl3NIX/wDhm4Ebrm/AMe3qff7sKBrwdaG0+FndJgK+vq X7Fg== X-Gm-Message-State: APjAAAXk8jk8QoKQ8zDYzP6N8Vf3cdcuWiRkDtDdrzSM3UGnmTwsETUd 4Fnu9b0Bu/y44FhS5gxmptTHpdIW/ak= X-Google-Smtp-Source: APXvYqz1HzMFbx80qiA3NIHIL3wu3MOQNq+71/zJiBtFRbys0z+n3K95UjLO0CKqFWbVVKHE44sGjA== X-Received: by 2002:a1c:b189:: with SMTP id a131mr20527670wmf.7.1561469563200; Tue, 25 Jun 2019 06:32:43 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id l1sm40485811wrf.46.2019.06.25.06.32.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 06:32:41 -0700 (PDT) References: <83wp2ngag7.fsf@gnu.org> <9392204e-7185-6ae7-137e-d0ccdfa773cc@yandex.ru> <837eumffun.fsf@gnu.org> <0229b8a6-37b9-bfec-8f65-6f34ec596e72@yandex.ru> From: Dmitry Gutov Message-ID: Date: Tue, 25 Jun 2019 16:32:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 25.06.2019 14:09, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> I'd be fine with it now. Though the surrounding code has changed a bit >> and the patch doesn't apply anymore. >> >> The same change would need to be made for >> xref-show-definitions-function as well, I think. > > OK; I've now made these changes. Nice. Thank you.