From unknown Wed Sep 10 05:37:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29201 <29201@debbugs.gnu.org> To: bug#29201 <29201@debbugs.gnu.org> Subject: Status: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB Reply-To: bug#29201 <29201@debbugs.gnu.org> Date: Wed, 10 Sep 2025 12:37:58 +0000 retitle 29201 26.0.90; Flymake skips indicator when a backend reports a dia= gnostic at EOB reassign 29201 emacs submitter 29201 Dmitry Gutov severity 29201 normal tag 29201 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 07 18:27:12 2017 Received: (at submit) by debbugs.gnu.org; 7 Nov 2017 23:27:12 +0000 Received: from localhost ([127.0.0.1]:57212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCDGy-0003Ek-Fo for submit@debbugs.gnu.org; Tue, 07 Nov 2017 18:27:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCDGw-0003EY-Uf for submit@debbugs.gnu.org; Tue, 07 Nov 2017 18:27:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCDGr-0003tY-4j for submit@debbugs.gnu.org; Tue, 07 Nov 2017 18:27:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50077) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCDGr-0003tS-1V for submit@debbugs.gnu.org; Tue, 07 Nov 2017 18:27:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCDGp-00031A-US for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 18:27:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCDGm-0003s9-RB for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 18:27:03 -0500 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:47212) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCDGm-0003rq-Jk for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 18:27:00 -0500 Received: by mail-wr0-x229.google.com with SMTP id k61so793607wrc.4 for ; Tue, 07 Nov 2017 15:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=qVE6pgH9HtSZxfH+ygbOxKqIHPhy1yK0+j5C8ytmtNk=; b=DExgeg4i4gjrPygHP+6fpTWm9J8xnbBsALKZFIP+P5wUXgSgGD6BOzsQamD0l8gTf9 bIZwXsIlNiV2BJKdibooLAarv5lh8kaaeioTtrWBoqsK7zoCCHqTLSAV6/7u3sh6NkA1 LlLenm9UJpEVjkJRr5uN2F8j9xicVpk4sNfT7GhNGkFkUTtYforkrUv7Ri0qzMdVC9ZJ C2/R6aOWv/Boc3e0JNiRfeN527YHjQ9JQmQJ9Gx+F+FvWtiZKLGAqsbD2QU2T/c0iB0Z urXNOLz5B1QJRk/Qye6hJDyiL117hxHSSEfxjjTYHZ4z0SvxHuoLAYjlgqlIki8w+ist OaTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=qVE6pgH9HtSZxfH+ygbOxKqIHPhy1yK0+j5C8ytmtNk=; b=A7OJ0Wg5I5PAO4jLq/djtJr3cSftLr/4LhARTzUkNGlaWXIz5vj166QC4KYhaL5Tdn 4N7+Im7xSaWhvBEiVDmxz6Nduj7HP14oKjh5ojXM9aCpcc1D19iYNUF2EnjzaJPs5kD6 VKe/CLTkK/AfdZLvCQhLgLnpW9m3IyOK1+7iJXK0mKbkUSL5iKpxW9O9hTH89Z0Dx8DO FPAei5LWsloP5zWweuJWUrMsgO8e/aEZjytst8/j2GpeMhQQedeY+CwjIzxsUjjZDTIz QZuBhi952yJNCvpwk77hE8Jl5QntC55g0MNMNIftsw0OFPT6231VLh6P76CYKotYGx1a 8NFA== X-Gm-Message-State: AJaThX7ckW369Nj8IkTtrwJl1owq6VUw7a5VTw7dNImPKZMqPyA4M0/h iSYEetfdYMAhr4/v8XU3d0rbtYe3 X-Google-Smtp-Source: ABhQp+R1wSZ2YMIVWlXK7DYam5IPfE/0JCYea0AaNP6TrMMi7SEzYmdP89KzDFDwTkpSUqHh7ScM4A== X-Received: by 10.223.164.206 with SMTP id h14mr256306wrb.25.1510097219107; Tue, 07 Nov 2017 15:26:59 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id 69sm4562871wmp.37.2017.11.07.15.26.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2017 15:26:57 -0800 (PST) To: bug-gnu-emacs@gnu.org From: Dmitry Gutov Subject: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB Message-ID: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> Date: Wed, 8 Nov 2017 01:26:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) ...and the diagnostics buffer doesn't show anything either. Only the mode-line indicator does. Example: Rubocop reports the "E: unexpected token $end" errors with line and column corresponding to the last position in the buffer. flymake-diag-region translates that pair into a (EOB . (1+ EOB)) region. And, apparently, flymake--highlight-line creates an evaporating overlay with these buffer positions. Maybe flymake-diag-region should check for (eob) and maybe backtrack a little. Flycheck, in such situations, highlights the last symbol of the buffer. ++ In GNU Emacs 26.0.90 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-11-07 built on zappa Repository revision: ca2d94ba61dee678f85bfc7299d167e7219e6d8f Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Ubuntu 17.04 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 16:18:51 2017 Received: (at 29201) by debbugs.gnu.org; 9 Nov 2017 21:18:52 +0000 Received: from localhost ([127.0.0.1]:60921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCuDr-0002ge-MY for submit@debbugs.gnu.org; Thu, 09 Nov 2017 16:18:51 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:56811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCuDq-0002fy-AG for 29201@debbugs.gnu.org; Thu, 09 Nov 2017 16:18:50 -0500 Received: by mail-wm0-f45.google.com with SMTP id z3so20466860wme.5 for <29201@debbugs.gnu.org>; Thu, 09 Nov 2017 13:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=9csmN2jsURTjpWc5WEZvYogxaFBPMz0B9W/feqP4+zk=; b=G1Z90m2irS4MQUBaEEGVHA6+pLs8gJFDOGFrLkkY7VYglzO6hb44E6UpXXR+l5qifa VurFmW9gCuYLGG/xHhjrzHHdWBVgPPrO3SO/UwsSAEZJGhPDxQ7E+cmiC/qy/fk8rIaW c7WGoWozdiCMpZk9Xhd3oa071OLVxycWekhE2NN/rVQFWWSUbDgpFMk7f7PBJ3PlKwmw Rg2TuFMS8M+B14ReiknpAEnWQPRCgeWOOBiCPn9DB3bmjW/fowjNUh6fedl3uWTnz4OS 0wfNKabvzNSuIRLjPrtLI5ID4jlXPVa9ZVSCT3gAIMpVPJfT3qZg4tkhw9ak4/rCyqCm 4Qng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=9csmN2jsURTjpWc5WEZvYogxaFBPMz0B9W/feqP4+zk=; b=HWkigkhZf5pkfKXCVhO2r38Tlsnb2uqu4/ZxgarFVpOzWLxks7L4IZMWg9bvx/Ysom JLdC5Ij3qvB3zn97mGcgx/+qIBGLMED+YTTruBxRV0P0abCyKsn3/mxzQZtx80SAQd27 S0zd1i6vk1ecCoNKnzoHt/PMm61E4nIJRUd7KebNuIhG24W/hFf/yK8nQSxasfVcK/SM E+ka3U9eJKhpi8b5jB9LhQ5wOADrxlXOtZArlGQeeJxsexpH9/0f6o14ZbVKXzBqhcK5 NC8debPd07z+SoZW4nxq+0gAk3uQbee5OqWPugDF/8SM7AasFZS2ZvrLj+BiQ/D0b6v3 slTA== X-Gm-Message-State: AJaThX6UieoWmzSQfWZwW1S+v/jKK5OQgikhGEIWNYjOe1erWDBzzvnS CuhVQau94z7oAq5wYV1+is5KgJOE0UM= X-Google-Smtp-Source: ABhQp+RoQoN3JuisrGSXuZTV6tsBOvvpvNZQkEAfjG9z6VL+SKvT2++kP/TcPdKcjP1W5fcvMnlgKg== X-Received: by 10.80.185.68 with SMTP id m62mr2477223ede.239.1510262324484; Thu, 09 Nov 2017 13:18:44 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id h51sm6720782eda.56.2017.11.09.13.18.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Nov 2017 13:18:43 -0800 (PST) From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) To: Dmitry Gutov Subject: Re: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB References: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> Date: Thu, 09 Nov 2017 21:18:41 +0000 In-Reply-To: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Nov 2017 01:26:55 +0200") Message-ID: <87vaiji21a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29201 Cc: 29201@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dmitry Gutov writes: > Maybe flymake-diag-region should check for (eob) and maybe backtrack a > little. Flycheck, in such situations, highlights the last symbol of > the buffer. "Backtracking a little" sounds OK but highlighting the last symbol is a little more contentious and harder to do (though I'm open to that argument). Anyway, this is a simple bug because my original idea was to make this case behave like the case where the last line is referenced but without a column indication. Inside flymake-diag-region, this should funnel into fallback-eol but in this particular case it wasn't doind that because I forgot that (goto-char one-trillion) doesn't error. Fixed in 535688a4181ae4052db354ce2b877507f11c9e66. Thanks, Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 16:19:16 2017 Received: (at control) by debbugs.gnu.org; 9 Nov 2017 21:19:16 +0000 Received: from localhost ([127.0.0.1]:60927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCuEG-0002hh-2n for submit@debbugs.gnu.org; Thu, 09 Nov 2017 16:19:16 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:47288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCuEE-0002hV-MC for control@debbugs.gnu.org; Thu, 09 Nov 2017 16:19:14 -0500 Received: by mail-wm0-f54.google.com with SMTP id b14so4693380wme.2 for ; Thu, 09 Nov 2017 13:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject:mime-version :content-transfer-encoding; bh=G4hwqj9WaMgCE8jKOlftuiJgu18NBhY4eaJSpZtyO6k=; b=mnQ/ID4jSDOM/WDFQcTe0KC+khAkMiahbTbR+3zHdULiniXbtZypkfWHnDVgwY+p5l 29HSDsMWl3E4siDbIQzFxDM2Avdq3/uGFXPMRfrbg0mZqql7l4jWpC0L7ntUc/w+27gk NqstrBZRxL6CPPVxqwi4MqD8Ii3GARXlT8wAL3ZCnEn+0Xz1EVNqOrxFfNw4I6uGlgLv jy35rBNk/t5ZMonWNVYkzXZFcVuNHByN1Oz1IFqnTbxbgWB3uRtLglF0+ixpTMV2vYJP N7PcfgXodFT9P5t2We4AyCcC5wCMJqwkT2GLs3c7qbmaWBFrsfB2LjkL1MOvXYlWC0y7 is6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject:mime-version :content-transfer-encoding; bh=G4hwqj9WaMgCE8jKOlftuiJgu18NBhY4eaJSpZtyO6k=; b=Sp6KPII3RRpVTopv2f98RXMvXJhOli8e7VNeldWpoqoYVvxoMv9+rFET8D0ZHutrfr 2cT+XBXhCtIW/9xk14AuzACM5XHPMMqUkgJXPoc4JVc3XmNmS9PicUSKjwEgoVwfv+e/ HguhAJRcKPKcZLfnatF2snOClGU1qpc/izn6wZgoBTS9dumSaaeZX761f0dnEoDB8KDH g+EYGHfty5pl/wDIsZp1boz07ScYFlqXzFEzKuE2u9ZeKYe5AVwYFgZYxeavPhpoCOxu 8+8k53tX75Ob/E4wnDHnShwW1eWW/frMwdGfmz4qCzl0NVcIveQmCafmeuiDabcoigeb AsSg== X-Gm-Message-State: AJaThX7ZbOhEDGATyiUG43/X4vxDFjCqctLiE2Ij4DmGylHBn2xIzFiF vbEHovvCV/grhNcXaUcBP7VwApiP894= X-Google-Smtp-Source: ABhQp+Twwdk3vqidvNUGcXsgvYXVEGmuFkSakEpbn77ZiMSmK9iOwOdvhKNaXobV2Q7EVtlOmFKjwQ== X-Received: by 10.80.130.67 with SMTP id 61mr2491317edf.3.1510262348923; Thu, 09 Nov 2017 13:19:08 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id r1sm6412402edm.22.2017.11.09.13.19.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Nov 2017 13:19:08 -0800 (PST) Date: Thu, 09 Nov 2017 21:19:07 +0000 Message-Id: <87tvy3i20k.fsf@gmail.com> To: control@debbugs.gnu.org From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Subject: control message for bug #29201 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 29201 fixed close 29201 26.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 09 19:02:17 2017 Received: (at 29201) by debbugs.gnu.org; 10 Nov 2017 00:02:17 +0000 Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCwm0-00025o-MI for submit@debbugs.gnu.org; Thu, 09 Nov 2017 19:02:16 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:50208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCwlx-00025Z-9b for 29201@debbugs.gnu.org; Thu, 09 Nov 2017 19:02:13 -0500 Received: by mail-wm0-f52.google.com with SMTP id b9so222191wmh.5 for <29201@debbugs.gnu.org>; Thu, 09 Nov 2017 16:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yH02GVgmRZS3aMF9yzzBgQ4BTnEyWAWB68ZI5u+yT8Q=; b=M2f1g2kVPrCKM8qED9xAJzNQvh8II8XGpqmDfzLbyv/ZntU+7rnQJy/Fd9CWHTGROl ez8OEA47G6QFOvBXimd4wVOE5hBX9RPK0VifpKvb845g59W1ta26DtEdtT+iGu+S574x 9ybse/V/GCnDR1YvRJmKrFXLrphHAVmTADgBQ4QJVoNPOOmmzM/BW/mZEtIlpFkC/bWX p9CaDP10KQXwV/j6+Y7TIPUlnH5CoRJMPa6JDOcrFIbsun2Ksu0a6Ue4Bto4TUgmjGZ4 LFCaoplNmdpmhHJPeqRZhWHcZPQkQ/OK74K9FHPyp6mXDI3kqDAolXvbmB6e/pPvlyyQ SZcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yH02GVgmRZS3aMF9yzzBgQ4BTnEyWAWB68ZI5u+yT8Q=; b=kv7g7lao5r7Df+ViFFJNSQJdj6YIIz9IDb0ZIqP++Jj/ditXrrQRLrVGgp5y74/RU/ rC3n+vPkjXfwJ2JyCdFRY08TR9+ZOltrTU3S6NWB+el5aE6XfSvrHB/zvL6i1yS411MZ 44N3Jqr4zCaxZZOuxI/5KYmRdzNyjplKqTZ9GGcRWc8fmuZuy9DIgB7ZGk8VCX03KMQb suoVCVuWCAZUYnRV3IgtljlkQxi9FbIAHDR8cZkvfzl9dbNtdmG1PnbURMMBolcSA2Xb VXtWDEQEeFqTNdLZuSv3LBu41VxdiNPtZgIRVVVCXtx4BOK3ktwmd8IslV9p/J1samzB OWOQ== X-Gm-Message-State: AJaThX4ljrqr1MwQNaJrmiOc6aaAn77nlqjU062G1FMjjC5+w78DP1yz hcrn02/7pegZqVxLI8NU9ZyNn6Wk X-Google-Smtp-Source: AGs4zMaxJu6yezsgOr/wmMK9Td0GS2kglEjIvlcioTfl6wPWmtPy9jTuHtjvUjhFYxing08UvbBo2Q== X-Received: by 10.28.87.206 with SMTP id l197mr1130556wmb.45.1510272127389; Thu, 09 Nov 2017 16:02:07 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id d4sm171672wmh.35.2017.11.09.16.02.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Nov 2017 16:02:06 -0800 (PST) Subject: Re: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> <87vaiji21a.fsf@gmail.com> From: Dmitry Gutov Message-ID: <638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru> Date: Fri, 10 Nov 2017 02:02:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 MIME-Version: 1.0 In-Reply-To: <87vaiji21a.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 29201 Cc: 29201@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 11/9/17 11:18 PM, João Távora wrote: > "Backtracking a little" sounds OK but highlighting the last symbol is a > little more contentious and harder to do (though I'm open to that > argument). That's okay. > Anyway, this is a simple bug because my original idea was to make this > case behave like the case where the last line is referenced but without > a column indication. Inside flymake-diag-region, this should funnel into > fallback-eol but in this particular case it wasn't doind that because I > forgot that (goto-char one-trillion) doesn't error. > > Fixed in 535688a4181ae4052db354ce2b877507f11c9e66. The idea sounds fine, but it doesn't work when the last line of the buffer is empty (e.g. when the file ends with a newline, like with require-final-newline set to t): highlighting the last line still ends up creating a zero-size overlay. So I think the important point is to skip the trailing whitespace first. Maybe this calls for a test case or two. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 10 00:32:28 2017 Received: (at 29201) by debbugs.gnu.org; 10 Nov 2017 05:32:28 +0000 Received: from localhost ([127.0.0.1]:33057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD1vY-0004Zz-GR for submit@debbugs.gnu.org; Fri, 10 Nov 2017 00:32:28 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD1vW-0004Zl-6k for 29201@debbugs.gnu.org; Fri, 10 Nov 2017 00:32:26 -0500 Received: by mail-wm0-f45.google.com with SMTP id y80so339549wmd.0 for <29201@debbugs.gnu.org>; Thu, 09 Nov 2017 21:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=pYOd4Mh+N6jkCw0JXdhJuDehnXa18JZ2bwbO9iapfFE=; b=N7TGJb5MNE1uuxSuUCcWAbzm1CCWsIhEfLhV56ewMaIWfakBWLUTMpPLCqe6fmVaNR xa0jr7IbewyamYhxLms/elT0hQAKj3kqPj3CJc2OKZcN107yHZFXpby7MT1L2NCQwacB S69WhuOvZ65u/8rGem3OqdtrTm092WudZcoGWI0Cnze2KmzxjkiU8PeNXTH9OsxkkNIj AtPY2E2tveDD7npKvggKoko7jAA1p39dHUktVv3hlPxJnd90s1c/2s6MQubkW8oJTWzZ nwpUcEpCgScflLjzqBODFz2YBG5Ge5XeYqjf8sPOuKyNMJECd74NW6t0lg68NXrnBkDk z5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=pYOd4Mh+N6jkCw0JXdhJuDehnXa18JZ2bwbO9iapfFE=; b=djt5hKs4LwBxBiNH9A0d4KMImZX0uoxkHS3cgYX5vL4rwlfjLgqwLb6VzWNw0qyAMT e4qFjqu+XxPYgBTjuaczVzC1JgsHqD4E+s7LEk64jyVtyt8sNdyZsW7x3kUGAknggH13 +ZrXrxO6clpaWxg1geNaa04I9k1Q3o9t36XcTxYZAVggeVoe5n1sJwAUkkCSbFS1NXOB TopTj+obYWXSy/Yy0TQeficyNamHQA9iFzt5b2JR260SnXwJQeY7EQ6lJSZtPQ+OvWVY AFeshRJFsflS81Gn+3ZPc34NsbJ7hz4CJletV+3+l9N/2kTOB2OiIpLIIDq6PbaVKsnk D8QQ== X-Gm-Message-State: AJaThX6ihVWHUDCkDgnGHNl5WZSjRyLB18TdWI3scinR9dL7HbDvzBAC eBjUUFFs2E+xiT6kqll3dqV+aKLH X-Google-Smtp-Source: ABhQp+RDBunDoR7y39IcecwOOxkoyKrgJmsb3xYSGHuN4W7xM48+tEBXKw9qPlz/2Bi9I9FIX+N4pQ== X-Received: by 10.80.213.131 with SMTP id v3mr912080edi.256.1510291940165; Thu, 09 Nov 2017 21:32:20 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id 3sm6629285edv.50.2017.11.09.21.32.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Nov 2017 21:32:18 -0800 (PST) From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) To: Dmitry Gutov Subject: Re: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB In-Reply-To: <638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru> (Dmitry Gutov's message of "Fri, 10 Nov 2017 02:02:04 +0200") References: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> <87vaiji21a.fsf@gmail.com> <638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Date: Fri, 10 Nov 2017 05:32:17 +0000 Message-ID: <87k1yyitr2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29201 Cc: 29201@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dmitry Gutov writes: > So I think the important point is to skip the trailing whitespace > first. Maybe this calls for a test case or two. Indeed, the tests to flymake-diag-region should be 6-fold though. Two tests, with and without column indication, where eob is being pointed to, for each of these buffer fixtures w/o trailing newline -> highlight last line of visible chars with trailing newline -> highlight last line of visible chars with two trailing newlines -> highlight wide last line of whitespace ...but I'm too lazy at this time of night to do the tests, though I do have the patch I think should fix them :-) Thanks, Jo=C3=A3o diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index b4ab7f223f..241ea00d64 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -318,7 +318,11 @@ flymake-diag-region (goto-char (point-min)) (forward-line (1- line)) (cl-flet ((fallback-bol - () (progn (back-to-indentation) (point))) + () + (back-to-indentation) + (if (eobp) + (line-beginning-position 0) + (point))) (fallback-eol (beg) (progn @@ -335,11 +339,11 @@ flymake-diag-region (not (=3D sexp-end beg)) sexp-end) (and (< (goto-char (1+ beg)) (point-max)) - (point)))) - (safe-end (or end - (fallback-eol beg)))) - (cons (if end beg (fallback-bol)) - safe-end)) + (point))))) + (if end + (cons beg end) + (cons (setq beg (fallback-bol)) + (fallback-eol beg)))) (let* ((beg (fallback-bol)) (end (fallback-eol beg))) (cons beg end))))))) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 10 06:20:03 2017 Received: (at 29201) by debbugs.gnu.org; 10 Nov 2017 11:20:03 +0000 Received: from localhost ([127.0.0.1]:33231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD7Lv-0004nl-8t for submit@debbugs.gnu.org; Fri, 10 Nov 2017 06:20:03 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:51442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD7Lu-0004nE-8o for 29201@debbugs.gnu.org; Fri, 10 Nov 2017 06:20:02 -0500 Received: by mail-wm0-f43.google.com with SMTP id b9so2039333wmh.0 for <29201@debbugs.gnu.org>; Fri, 10 Nov 2017 03:20:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6GClQjVK2KlPIny/HQB+wmsQiKV6oAjzLrf1bCv0jd8=; b=c2PfIqfh3SMHS7XEw148AmoG+JUDFRWNxb3Z0JweZiT2YvTBZxH8EMi5e9jABr5iIi K+kgaS5mFA1uFBPdiDR/zzKj5AK4Ubq2W7mHCoaTkoylOWs7PlM+rneCyJ9C33qKIPC+ te9xjQiD1X0f/UVgmeG/eW2YPg91lmpFL9T+EPEn2ripHlIHoNPIrbox0CrrN9oD7Me+ IPxFHKX6Y7IrPUQOIBFzoCffX7tsutFaXL5Hu2Qn9PYQy2eZx6NtJeLEAAkh9d5je7c7 oP0mTp4CkWm4nxwYl+X645PhyqhnvTpMUmDO9GaemVwWkR/MrcP4J5ZDuFTRYlFFLiRC BGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6GClQjVK2KlPIny/HQB+wmsQiKV6oAjzLrf1bCv0jd8=; b=oJSTtMV/z7Xt4xUZitZjq5mwDptQRIuRdEtAnEYg6PQthLyrgOmzLPhA1ZZXBVHzMV fEvgtTyhvtJ2oi8KeT5gjTctyXfLA7QyWzkrLeNC4l1Aucwzlm4ojz2U32Crt8g4TCyM /cJzdammID1g1K4mCMLeGVefq71nq3B8dKKuyzKIii2Ik1UKPBBDmtSw2yADT/yRhogi PNV9gK2HOdDcjHf2N2eKHjQn/BkiatSnB479Zs7Scl7NVJsSR0nS4kwjuAjaLIzFf3jv maAmvUe68ReSFmO8vm3h8y16tJlpcLkjENcl4j3n+qSn4tIkjWnIyaLujyLDCzl1pV76 31Fw== X-Gm-Message-State: AJaThX4oSgfnca3N5RyNoGXa0sKTDdULkiIz/mYG2yQOJJC09HrJrH9I iFPa/tMTdc0AxT0a5bLOrJvSY6Pw X-Google-Smtp-Source: AGs4zMZg9Aumkyr5d7Xfdyi9mA4QcRmrK10seiNuNnNE8NfFw8cu3x7bS5LJheiZlUke+QeQSJT41g== X-Received: by 10.80.221.11 with SMTP id t11mr8160edk.84.1510312796234; Fri, 10 Nov 2017 03:19:56 -0800 (PST) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id c7sm8079543edc.26.2017.11.10.03.19.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Nov 2017 03:19:54 -0800 (PST) Subject: Re: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> <87vaiji21a.fsf@gmail.com> <638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru> <87k1yyitr2.fsf@gmail.com> From: Dmitry Gutov Message-ID: <566e01f9-b539-fde9-af43-e3683f09e395@yandex.ru> Date: Fri, 10 Nov 2017 13:19:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 MIME-Version: 1.0 In-Reply-To: <87k1yyitr2.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 29201 Cc: 29201@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 11/10/17 7:32 AM, João Távora wrote: > ...but I'm too lazy at this time of night to do the tests, though I > do have the patch I think should fix them :-) This one works, thanks! > with two trailing newlines -> highlight wide last line of whitespace This is a bit questionable, but good enough, considering one shouldn't have multilple trailing newlines anyway. From unknown Wed Sep 10 05:37:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Dec 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator