From unknown Mon Jun 23 04:10:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29193 <29193@debbugs.gnu.org> To: bug#29193 <29193@debbugs.gnu.org> Subject: Status: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Reply-To: bug#29193 <29193@debbugs.gnu.org> Date: Mon, 23 Jun 2025 11:10:18 +0000 retitle 29193 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region = might be suboptimal reassign 29193 emacs submitter 29193 Dmitry Gutov severity 29193 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 07 10:28:30 2017 Received: (at submit) by debbugs.gnu.org; 7 Nov 2017 15:28:30 +0000 Received: from localhost ([127.0.0.1]:56726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC5ng-0004OB-Ku for submit@debbugs.gnu.org; Tue, 07 Nov 2017 10:28:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC5ne-0004Ny-S3 for submit@debbugs.gnu.org; Tue, 07 Nov 2017 10:28:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC5nY-00043o-QB for submit@debbugs.gnu.org; Tue, 07 Nov 2017 10:28:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eC5nY-00043b-Nw for submit@debbugs.gnu.org; Tue, 07 Nov 2017 10:28:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC5nU-0003l4-Kd for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 10:28:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC5nP-0003xi-Br for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 10:28:16 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:45976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eC5nP-0003xP-4g for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 10:28:11 -0500 Received: by mail-wm0-x22e.google.com with SMTP id y80so4537311wmd.0 for ; Tue, 07 Nov 2017 07:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=JIHXf6KZYlvvHLzvqwd9MSkiJ/DOSftOFUXJ9IGLtsw=; b=lY/SfaKvlAK82LFe/nuxQ9dw1VIyDRWulmU6TQ+yxqxVXm5MoLDVyIHMOvltYt5WEt qS6SS8NM0Io3nSscKp8U/O17o4Um+wTCF6MT18/Z0uFJSXf4rOGyaiqzlqKK2rQ0Sa4z o/P6Fpa2mv4LqbV8SfS6407jFs6K97xVdOEG33vn9ChzsAv2z9Apa/6N+P7QNDPggyFz lvmrxleBg+6BAhh4RiA9LxX2eQZbTxRQpUOHWjwNwnos6btQV6rFa5RrPZYUJTcAWUK5 f2ZWk0qIsaq+Q4DBUMXaPKgYfZqmmbp4iTHVSBn/9sd1VLeA01krxLupPdcR1PhM/yhi vonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=JIHXf6KZYlvvHLzvqwd9MSkiJ/DOSftOFUXJ9IGLtsw=; b=gHWDSaaq1sMYFsJ42SrYrhi3Ecdchko3Kc3X5xgGiiUYH+lc+WAc1Ff4ZKkvV8tMc3 j9dgoW+Mb4rXqya7QzzmH/Vji3dhrUNSUQZe40uEVSXqjqTFMsKYqr8kf9zIuIxzjga6 XUMTtYEVLACzItF4KTFBjL1/3/7ejw2kihwrhc2zIFLOzbbJsfZE3JhxYe0zPZAvh9C0 m0zKrfnsP1KjO3d+jreYZ1NhRHpJWtVArtuAWAKS3AQbTYobot8OiN/Ue5ZmDnSvTUMU 8UcDrHGheb5/24287wouz57bzBGkRI8l8e+GmryqtcaFMBgTqJHlghrKir1Rd4oRcRJT 4qGg== X-Gm-Message-State: AMCzsaV1kjGqKlURj7zVO+CDuleryOCIrClcLNesa7o9e55/Pt2xBuXA 2juugYUxvzUGwUIAtG7aJe299zaT X-Google-Smtp-Source: ABhQp+RKZRg0cK1SWmOZ+yUBZ22XRJiR1cVzet9VEhu1ae2rAl0s+qyF6u5oNEsUT4zAI+5hULEdJQ== X-Received: by 10.80.204.154 with SMTP id q26mr25554809edi.108.1510068489487; Tue, 07 Nov 2017 07:28:09 -0800 (PST) Received: from [192.168.0.133] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id h51sm1613028eda.56.2017.11.07.07.28.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2017 07:28:08 -0800 (PST) To: bug-gnu-emacs@gnu.org From: Dmitry Gutov Subject: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Message-ID: Date: Tue, 7 Nov 2017 17:28:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Example: Rubocop can report warning when 'end' is at wrong column. It just reports the beginning column, of course. In ruby-mode, (thing-at-point 'sexp) signals an error at this position. I'm not sure exactly whether it's a problem in ruby-mode. But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the whole 'end' token gets highlighted (which is probably what we expect). In contrast, Flymake only highlights its first character ('e'). ++ In GNU Emacs 26.0.90 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-11-07 built on zappa Repository revision: ca2d94ba61dee678f85bfc7299d167e7219e6d8f Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Ubuntu 17.04 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 06:39:29 2020 Received: (at 29193) by debbugs.gnu.org; 12 Dec 2020 11:39:29 +0000 Received: from localhost ([127.0.0.1]:44072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko3FI-0003EY-P7 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 06:39:29 -0500 Received: from quimby.gnus.org ([95.216.78.240]:46040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ko3FG-0003EK-14 for 29193@debbugs.gnu.org; Sat, 12 Dec 2020 06:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IzX19bzlZHAHAW8Cv7E7lFu3vTRN8pcvNAuGzQzbY0o=; b=PgO3mgsb9TpmbAzIqg/rKdQ9ck ZSfWMzOrVa8QaaU+mruP6SElkhVUsTsu1trjwYPA4o6pYImS91v77RP5JT8KBnH5qtcVcCOZKYdE2 Rasg3pddXxQwdiNBCGrETO1+u1S09ZzmO2PXJzz9si7cnfe9MSyoum3lSqddplcjBViY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ko3F7-0005A8-HD; Sat, 12 Dec 2020 12:39:20 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal References: X-Now-Playing: Sacred Paws's _Run Around The Sun_: "Shame On Me" Date: Sat, 12 Dec 2020 12:39:16 +0100 In-Reply-To: (Dmitry Gutov's message of "Tue, 7 Nov 2017 17:28:06 +0200") Message-ID: <87sg8b5k4b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > Rubocop can report warning when 'end' is at wrong column. It just > reports the beginning column, of course. > > In ruby-mode, (thing-at-point 'sexp) signals an error at this position. > I'm not sur [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > Rubocop can report warning when 'end' is at wrong column. It just > reports the beginning column, of course. > > In ruby-mode, (thing-at-point 'sexp) signals an error at this position. > I'm not sure exactly whether it's a problem in ruby-mode. > > But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the > whole 'end' token gets highlighted (which is probably what we expect). > > In contrast, Flymake only highlights its first character ('e'). I had a look at the current `flymake-diag-region', and it does not use (thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp), though. So is this problem still present? There was no recipe for reproduction, so it's not immediately clear. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 12 18:56:28 2020 Received: (at 29193) by debbugs.gnu.org; 12 Dec 2020 23:56:28 +0000 Received: from localhost ([127.0.0.1]:47129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koEkW-00036c-87 for submit@debbugs.gnu.org; Sat, 12 Dec 2020 18:56:28 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koEkP-00036E-Uy for 29193@debbugs.gnu.org; Sat, 12 Dec 2020 18:56:27 -0500 Received: by mail-wr1-f50.google.com with SMTP id t4so12727582wrr.12 for <29193@debbugs.gnu.org>; Sat, 12 Dec 2020 15:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fKBprFj5wYRe6eAAI2MvS6nXAHfUA1CY6yp+UkAOgF0=; b=pTrU9S3jtV1tA7vMQDh2/b84P9FZyKdlJiceBxpdcNS1wEyWMUfdV3um5Wdy9b8qvU 0K8rL8t1tHMF2ki5vXt2aoWH6MkNEZpWcoB/KOoj9WllPD3gnD1IUlzfYGWNeUoLFJnm 881Gaf3am8E2eAWMWPfHCu6ZOQ21GAxIoSzUGI91tnGg7apwkbmGxj+wp6xbB4f3fPMy AZAjiPXYgETV9ruudTxjAMy83MRFyTwVeu/BcLo5S2V4TTUA93/CNOjTJF1BlVkW1+dn 8NCScjYnsXuaubCwtO25WjrwxeAwVH6EB4JO0FeMxHliD8U/tUDmZvEDz30JV1i6IL6c tvcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fKBprFj5wYRe6eAAI2MvS6nXAHfUA1CY6yp+UkAOgF0=; b=Gh41HbbH94GJTwFVel2OZrQrEWxC7BGLVtM3zX3Ayrb3nTgglBF3raeeTvWLGwKoip 3+j+/T82NQcsPWPKDxit04mVIoH24M8D2oBxTh0be7hw39N4KrbzQWG4KxHWC1OvlJTY j9xB4SkUvqoUvRg8aCQHWF20I7xKuSXLkHao+l4baFH5QHPvESm6H7xDBusx9y9Ko5Nx dpIS2xR1OpFIzAFvwNaHuW9zpwSZpGyJg7EQbZqqheYmS/YwpHDLufvxpDuQZLk2LvpA OtxWiWweX+ig2InITtr43sJxmnL6fAQIyqa13Z8eo6cev4lbxudwncD5HFmU1DmAdQx4 25wA== X-Gm-Message-State: AOAM530w6NJMW6tjXO6j5i2SshWGSTpFHh1O6ujXS/ekgRS1hmR6Nqrn 5ptlQ4VmMcJDa772dX5F50kQ359TvCKkFw== X-Google-Smtp-Source: ABdhPJzqB9jZSoVn8wHm3/bNKBcf48HLx1up/mlL27Y1ohapI/OfWWSTJ3qmjYh3KdUzs4eUAHbMdQ== X-Received: by 2002:adf:9e4c:: with SMTP id v12mr20752040wre.22.1607817375548; Sat, 12 Dec 2020 15:56:15 -0800 (PST) Received: from [192.168.0.5] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j2sm22860478wrt.35.2020.12.12.15.56.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Dec 2020 15:56:14 -0800 (PST) Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: Lars Ingebrigtsen References: <87sg8b5k4b.fsf@gnus.org> From: Dmitry Gutov Message-ID: <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> Date: Sun, 13 Dec 2020 01:56:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87sg8b5k4b.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29193 Cc: 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 12.12.2020 13:39, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> Rubocop can report warning when 'end' is at wrong column. It just >> reports the beginning column, of course. >> >> In ruby-mode, (thing-at-point 'sexp) signals an error at this position. >> I'm not sure exactly whether it's a problem in ruby-mode. >> >> But Flycheck uses (thing-at-poing 'symbol) for the same purpose, and the >> whole 'end' token gets highlighted (which is probably what we expect). >> >> In contrast, Flymake only highlights its first character ('e'). > > I had a look at the current `flymake-diag-region', and it does not use > (thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp), > though. The behavior is the same: when 'end' is misindented, only 'e' in 'end' is highlighted. Whereas the message is: Layout/EndAlignment: ‘end‘ at 23, 3 is not aligned with ‘class‘ at 5, 4. That highlighting is not too hard to interpret, but we could do better, probably. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 07:52:07 2020 Received: (at 29193) by debbugs.gnu.org; 13 Dec 2020 12:52:07 +0000 Received: from localhost ([127.0.0.1]:47644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koQr9-0004c1-Kg for submit@debbugs.gnu.org; Sun, 13 Dec 2020 07:52:07 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koQr7-0004bN-Rn for 29193@debbugs.gnu.org; Sun, 13 Dec 2020 07:52:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BSw3Tyv68O7ctIdPjw7asnGgWiYX8QWpPeHHS9wP24U=; b=E8/ccM+vNVz+NB3MSS5+5Vcd60 zQ/b8rCnbFuE0RyWsyzCN6nTd5VTIHkM11CXhNVv6oriykN0KRx3SMvTOwG0iJadTZFfrV+hGJfKg xmWzo3caBZoFUdqz1CXi/bdPdEIHt8LFkAXi8KGW7UUFgc/442RzUVQkpLA40vwmuGhM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koQqz-0004zr-Ho; Sun, 13 Dec 2020 13:51:59 +0100 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal References: <87sg8b5k4b.fsf@gnus.org> <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUnKjFIWW55hYZX Ym+RmZyMd4beO1DQtL/MydHqHjSzucl8quv////g3T9KAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QM DQwbKg0MPcAAAAGjSURBVDjLbdFLbsIwEAZgrmDcCxBygcSpVHVpoqrqtmXBvg2EA5DQAxCLAwR5 XzXWdN37dfyIY1MGCYb5/DtOMpvN5nmSJEv9tSCJrxmC/5OR+U1YEkJuQoaQ3wAdIBSblPMyBB3Q kbTUZUA3nJs5obwc4c4uWVgg6QSm4ZmD+RWsCIkiHjIPRQRTgNAIpoDbywEP5vbyDhYZu4pY4Czc ihYeVixMUOaBZZSxac4KBytmyozZfVW95g7sPNMPPW27ppYfqQFul+MUoGla0aEYWOBilrzAGWBo jMj+Tb8PyvJSCSFAB7CEONbvCJRmz8LOh62R5tRXCAUr9Bw3+tlIU31V9QgPehsT+JVj1VsNnQvA xoNsDeyVHsPTNL8IDeKwv5rL1kInq/W6kmFA2IsfZVy7EU7xvBcW8Ke+DrhEHNGBEaLIdgIQhyDQ ejiD6qKzjoB3p6YTtxFAFwcMAOCzVZsoYEGps1LuxD1eUAilEB71Tkq5E++ww1OKEbC+bUAoUBEM Q20C5tVAmAC8yf4TZ/gBFQKeeDv2EAIcbeA/fF18C38TwJZnmmD7qQAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMC0xMi0xM1QxMjoyNzo0MiswMDowMOcXzaIAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAt MTItMTNUMTI6Mjc6NDErMDA6MDCnom+DAAAAAElFTkSuQmCC X-Now-Playing: Colleen's _A Flame My Love, A Frequency_: "The Stars Vs Creatures" Date: Sun, 13 Dec 2020 13:51:56 +0100 In-Reply-To: <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> (Dmitry Gutov's message of "Sun, 13 Dec 2020 01:56:13 +0200") Message-ID: <87wnxl50nn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: >> I had a look at the current `flymake-diag-region', and it does not >> use >> (thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp), >> though. > > The behavior is the same: when 'end' [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: 29193@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: >> I had a look at the current `flymake-diag-region', and it does not >> use >> (thing-at-point 'sexp) at present. It does use (end-of-thing 'sexp), >> though. > > The behavior is the same: when 'end' is misindented, only 'e' in 'end' > is highlighted. > > Whereas the message is: > > Layout/EndAlignment: =E2=80=98end=E2=80=98 at 23, 3 is not aligned with = =E2=80=98class=E2=80=98 at 5, 4. > > That highlighting is not too hard to interpret, but we could do > better, probably. OK, adding Jo=C3=A3o to the Cc's. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 08:19:26 2020 Received: (at 29193) by debbugs.gnu.org; 13 Dec 2020 13:19:26 +0000 Received: from localhost ([127.0.0.1]:47733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koRHa-0008Dv-0Y for submit@debbugs.gnu.org; Sun, 13 Dec 2020 08:19:26 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:54752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koRHX-0008DW-9B for 29193@debbugs.gnu.org; Sun, 13 Dec 2020 08:19:24 -0500 Received: by mail-wm1-f52.google.com with SMTP id d3so11394477wmb.4 for <29193@debbugs.gnu.org>; Sun, 13 Dec 2020 05:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=1VAKQ0Fp3Y2BJEZk74zRHR6MycB3qWUEjwpJPhZlWQ8=; b=UrNtfaRNjKA3+l8+mm6BxhMTRGhQ6ANXhCPyE9t4FRszb7fe/nYBf9dzhbbJmszvR1 AFaHFShZpp/RtcVdNyh7xGzp6MFA7gPulqBHc9y8khtjg4y2PfQzFXfl0c4ZHEYJM1uE TpTQOYUuwXK5h4Aq69hJitz6isw1JJrEfAX7PmuaD77K8wZOY2JBZrRRNG5ZWl3JQ9Xv SaVLj5xVI/VIjrEG8PnjVyLpo10d+KthdyNXyazGOqN+BIa98F+BhXtbSKcWntLtomgu Ux3IhtN3ra9wNnHp2TuM8MZnSILPR3m4kwL2gfoYtT9ct6tECN+MPhASvh1JOMmguLIb vaag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=1VAKQ0Fp3Y2BJEZk74zRHR6MycB3qWUEjwpJPhZlWQ8=; b=SGYOre1xEuuXN8G+p1xP0xtEdzd+tT6uX3TXlcG4DzZEh4BtVkmq+THrgsbuieygR+ ch2VzekBjoDShVM1Xf33/xCo53ZDaK9rmEbJV+XqEusUwtpMB2PoCdht91meh+4M8p1K jaBELIebBV5ZP0/sC8kzQmORgDfzZ8YU2Qh63NBsDyf4TQBrtx78VjdAs1XxVr6iAT12 Q5u2D3uNsFlZEKtfX6gjLazGW5mK6RVh8DMFPtU5bcntERhnJ9JN7Uhm5PK2G5sEbsmd K2DiVJ9iyy2k+punVWq6YGbaiTs2QBGZc6s09gtQFdPjYiOueO4Xigo3JrPNSPWHpW06 XPKA== X-Gm-Message-State: AOAM531uFe1JzmRYD0ihh4v9LXJj0zH9YI3H/jsNwnXGGJbIbWCS0sPw R4rO6+bLYPXJxQCRNZoCL+6YukuJ3Lk= X-Google-Smtp-Source: ABdhPJwk6y9l/U2lZ8pdI436kVKDRDf1VGd1vuJkvnKXc7nls+JaTi65hrPgNI3cIDCEeX3ia+6alw== X-Received: by 2002:a1c:4c14:: with SMTP id z20mr23324655wmf.149.1607865552027; Sun, 13 Dec 2020 05:19:12 -0800 (PST) Received: from krug (a94-133-30-26.cpe.netcabo.pt. [94.133.30.26]) by smtp.gmail.com with ESMTPSA id w18sm6868836wrn.2.2020.12.13.05.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Dec 2020 05:19:11 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Lars Ingebrigtsen Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal References: <87sg8b5k4b.fsf@gnus.org> <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> <87wnxl50nn.fsf@gnus.org> Date: Sun, 13 Dec 2020 13:19:08 +0000 In-Reply-To: <87wnxl50nn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Dec 2020 13:51:56 +0100") Message-ID: <87r1ntzvw3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: 29193@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > OK, adding Jo=C3=A3o to the Cc's. Not sure why 'symbol and 'sexp don't reference the same "thing", or at least stuff consistent in terms of nesting. In my testing (thing-at-point 'sexp) at the "e" got me nothing, but at the "n" or "d" got me the whole sexp. Similar strange situation with "begin". "b" sees the whole sexp, any of "egin" doesn't. This seems to resist different indentations. In the end flymake-diag-region tries its best to guess a region from limited line/col stuff and asks thingatpt.el for help, which in turn will probably ask the major-mode for syntactic navigation. So I wouldn't say the problem is in flymake.el, but in whom is untimately providing the (broken) goods. Then again maybe this untested patch would work and not break much stuff for other backends... diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index efa7b2ffbf..6c3e0a1981 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -437,7 +437,8 @@ flymake-diag-region (if (and col (cl-plusp col)) (let* ((beg (progn (forward-char (1- col)) (point))) - (sexp-end (ignore-errors (end-of-thing 'sexp))) + (sexp-end (or (ignore-errors (end-of-thing 'sexp)) + (ignore-errors (end-of-thing 'symbo= l)))) (end (or (and sexp-end (not (=3D sexp-end beg)) sexp-end) Other than that, I don't have much to add. I don't have the resources to debug ruby-mode and/or install rubocop right now. Good luck. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 13 15:55:52 2020 Received: (at 29193) by debbugs.gnu.org; 13 Dec 2020 20:55:52 +0000 Received: from localhost ([127.0.0.1]:50550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koYPI-0005mU-4O for submit@debbugs.gnu.org; Sun, 13 Dec 2020 15:55:52 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:44496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koYPG-0005lk-8D for 29193@debbugs.gnu.org; Sun, 13 Dec 2020 15:55:50 -0500 Received: by mail-ed1-f41.google.com with SMTP id p22so15019598edu.11 for <29193@debbugs.gnu.org>; Sun, 13 Dec 2020 12:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zTOBWhMlFKQZ5XPAmhpXLopeexFlIUv+ShuVBPZkaJM=; b=NAl5D+Bn1dsxj09z9pJ7oCrheRF/Fa186Ilc5HM9dJXdZDYCJPeh6KsOyLSjjDiGoS L1tWgzL8+k0s2PyF68wcvYmlcrPW5UwkqKyGLP0iybDmgqMe6cunxBqqV+G0VUM6uEIx vWf/WzskwdVaF8dzM+vauWvEGxTg01yITYIsDn1zQqgO2m4hDr1QzMxbqfzaTozwC+EA YL8DjMRrMzBL1umpAQBwmTT4dQYZKAxsMDD0zxk/zmvwmeB+vUTE00fUbRnn4Ogyl4gj o3iDLbm/ffT+mA7SQmkDF6mcGZBquTDqeJhqyKg5i0JuGqtbpFmHFTsW5JlVx0WrzOzE fC+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zTOBWhMlFKQZ5XPAmhpXLopeexFlIUv+ShuVBPZkaJM=; b=aGxJOy9h51gjywmbUB3CirIWUW7cXCOhV4fqci+flb7GsP0QF3eGu2RtNppOmnKG+2 aN/sj6yNS9IiS3XDnnGhoz44zeqeFmnQV2sqElJslHVIEXhtdmQ8DyuFagWc05d3mzVw TOc827UALPfFXAhUJJBHGgNLBstdMcYPih6zcSsWIApL+AX+YtkX/p6MSZUeE7qnvc8T 3Z1MXfpJaTo3UqIrZWOqk+78YmY7v+HoxfKZ5su+KbLltZcO3H2ciSqO96pRlNnVtSEF CtmsMSKgNIfy6kJkOX/sdbtzgjtGZh3ma1EMkRf5eMs3NSxHao+JkfUFMygiy55SyIbE heRA== X-Gm-Message-State: AOAM532GkmN29iYLMc45JlkxeZ9kZYYmKC7xS++kVI9ymJs53tOdISRO bSbFMq47aaCuzrWBJ+3KAxkMTgDNOed60Q== X-Google-Smtp-Source: ABdhPJy+3P1wkS1OvKovXTnWs886Q6f+V+ltPaVFsq7O+dvaApHYvadGYqcSo2/ojVeLcv3B4Ev2EA== X-Received: by 2002:aa7:dac5:: with SMTP id x5mr22454605eds.198.1607892944433; Sun, 13 Dec 2020 12:55:44 -0800 (PST) Received: from [192.168.0.5] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r1sm12069658eje.51.2020.12.13.12.55.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Dec 2020 12:55:43 -0800 (PST) Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Lars Ingebrigtsen References: <87sg8b5k4b.fsf@gnus.org> <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> <87wnxl50nn.fsf@gnus.org> <87r1ntzvw3.fsf@gmail.com> From: Dmitry Gutov Message-ID: Date: Sun, 13 Dec 2020 22:55:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87r1ntzvw3.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29193 Cc: 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 13.12.2020 15:19, João Távora wrote: > - (sexp-end (ignore-errors (end-of-thing 'sexp))) > + (sexp-end (or (ignore-errors (end-of-thing 'sexp)) > + (ignore-errors (end-of-thing 'symbol)))) That seems to fix it, thank you. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 14 06:03:33 2020 Received: (at 29193) by debbugs.gnu.org; 14 Dec 2020 11:03:33 +0000 Received: from localhost ([127.0.0.1]:51366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koldd-0008KJ-BW for submit@debbugs.gnu.org; Mon, 14 Dec 2020 06:03:33 -0500 Received: from mail-il1-f173.google.com ([209.85.166.173]:34159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koldb-0008K4-8I for 29193@debbugs.gnu.org; Mon, 14 Dec 2020 06:03:31 -0500 Received: by mail-il1-f173.google.com with SMTP id x15so15455584ilq.1 for <29193@debbugs.gnu.org>; Mon, 14 Dec 2020 03:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mMaUPGLDrCoJt17fQpoyn8ol7vbm5GYmigktVQDuxus=; b=XRoIRfxdHq/XWt98gLeuNy53vckCgPEAYdCyYpJwHE5ljGv7xMMd0zslsWalU24NI9 vM7GAJ5XBWLJWdy3YzLz0Ej97E7bjjKaMlHNZdtuITrxcEviyU1VyHubTxNjHEnVP6VB Ka2syun6H6GUF1vcW9GLfgikKrJUf0u+TKe8MBXlopRJ2O4mrHVCAKUbVO5DMXCVo6WD g8Bf8S0ZQ0eiDRH3YP+ToseLHVY1thCc54Bh45iDfQZEmeIPbcXCPLCkO2lAt+VAr5uI Y01pgeY6mp1f6NCr8i89zT0TnNL0ve5CczPZMlF9z/QLKsvZr/yt62C25A+SZDL9P0UD p98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mMaUPGLDrCoJt17fQpoyn8ol7vbm5GYmigktVQDuxus=; b=taNU3EWcDAXyXA+DGtJQoBJzR+2piUgRQkvwQmK9Oyn9DroRt3vcf7oSiRLlXyrO1W Ia20iEgMgekPK3qh5UQcDMZ1ZM3vtHY8DFVbk1ySlllDmgnYwejYaNOC9ofh2JF7IXBJ qUpOWYiMabBNeDKNmoulZlbe4mAVxqt6MW/VFtEbULIrRB5sHHQ2kSia/IceIEJtm+Cy Vq6gIRvKk3L61eYr5XcEsSK5QPScIpp05yyPPsmaNnVEB3uCnlMBokb4bPYxsDMleRth MoSfHaJakhk8s/jlibRTjFuw2Sdkn9k9AjUQyoD+vLoZfFldwIPNX75Vhub0696jCsdK ogKQ== X-Gm-Message-State: AOAM531OLgDNA4bGDp8FHbrED2ibUEl2/1SAgVXUmMyBna/nHCzdsA+m nM9d5rf+kySH72rkUxk9x/EGrOWhof+soKFd0yk= X-Google-Smtp-Source: ABdhPJyjlVHtX84aHj5xUXc3cFG9fUdJB2/D1h2LeAXOV3ajvM2AeYwT73syQ8A1Uazv+puFM0iaYRQUv5ksOi96Gy4= X-Received: by 2002:a92:a804:: with SMTP id o4mr34638444ilh.125.1607943804529; Mon, 14 Dec 2020 03:03:24 -0800 (PST) MIME-Version: 1.0 References: <87sg8b5k4b.fsf@gnus.org> <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> <87wnxl50nn.fsf@gnus.org> <87r1ntzvw3.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 14 Dec 2020 11:03:13 +0000 Message-ID: Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: Lars Ingebrigtsen , 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Dec 13, 2020 at 8:55 PM Dmitry Gutov wrote: > > On 13.12.2020 15:19, Jo=C3=A3o T=C3=A1vora wrote: > > - (sexp-end (ignore-errors (end-of-thing 'sexp)= )) > > + (sexp-end (or (ignore-errors (end-of-thing 's= exp)) > > + (ignore-errors (end-of-thing 's= ymbol)))) > > That seems to fix it, thank you. Feel free to push if you can't come up with anything better in ruby-mode. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 15 19:56:07 2020 Received: (at 29193-done) by debbugs.gnu.org; 16 Dec 2020 00:56:07 +0000 Received: from localhost ([127.0.0.1]:59486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpL6t-0006ev-ML for submit@debbugs.gnu.org; Tue, 15 Dec 2020 19:56:07 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:38446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpL6n-0006eN-Ra for 29193-done@debbugs.gnu.org; Tue, 15 Dec 2020 19:56:06 -0500 Received: by mail-wm1-f41.google.com with SMTP id g185so859720wmf.3 for <29193-done@debbugs.gnu.org>; Tue, 15 Dec 2020 16:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hGRbEbzStSsW7vbncO6ZUcIf00uO2WjE9Hccop1lZo8=; b=E4PA0K8ndC7RrJxm8+9CSPJxASptp6fbf4++n6AMsovkILMKOqdtNFULERdqXk3HND zy7d+V3lVidneyUTOf9O9sJ3k/SsBz8RofEBSbaSI8Xrmdy0vx61LODl47ewLQOrPcQm SZvFqmadQT97+X3sC/vqg4gK2Z9CUPGHJ84ziTODahUX5rFWuyTc0WA2iwTx/ubzxJb4 Totb97aaTZNebicQ02AbINb8sQmF1WAJEV5Nvx6NUyDKSJ6BispTHdz1hwZ5mCNq/FS1 EkN9JTgbqr7qIbNhHRy9vPxaRWUDShzmq4CoLb9tcRA+OPPqQ5q9/TjmfWyfL4CGesqH +DtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hGRbEbzStSsW7vbncO6ZUcIf00uO2WjE9Hccop1lZo8=; b=N9STcFRKGXYRljhOr9oZ9l7bGfqagVDYXE7z5fP5aTuoXANA+WW+7mr82vv2Of8lJ7 ymCgYQMAtgWytKVjrmZBcJqySdFLbxc1QlK5LXwiZ+7g8HBqSgtua1b/qUWwHfnyvWiD hjRaf1QoZd2zpPZXqI5xofjHdhITfEQBicibmYF4u9b4mc5kb9LtmdEI/36AqXg4LDSF K94Uiw5RvjZRfBVv8c6r+x3TY+aglrWx+JjiHsnDc8jRSORpQHH3VyaFkMqFhzSxvBva 8Dx1yJPViApn2JaaYtQMj8eaHgpsPLsD8fPNhHoQxpvwbLTJIpNckXWd3rZQOOWljDFC PHjg== X-Gm-Message-State: AOAM530H2pHLg6BiG6B2Y+6Fz+/AerWeyIBo56kGmkZI028bn2NdL/kP ypuEVe8zrxoGI57EmC1rqWgiW/XQsEYEGg== X-Google-Smtp-Source: ABdhPJwlEp31BsBNQBwz3GZOz3EgGt1zQrrYK04EQsez4nUKcZhsaskizVQT/t5CsYlbyh68SH3ADg== X-Received: by 2002:a7b:ca47:: with SMTP id m7mr935679wml.33.1608080155366; Tue, 15 Dec 2020 16:55:55 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j13sm171112wmi.36.2020.12.15.16.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 16:55:54 -0800 (PST) Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <87sg8b5k4b.fsf@gnus.org> <49481d0c-b101-8527-b468-ff295105c028@yandex.ru> <87wnxl50nn.fsf@gnus.org> <87r1ntzvw3.fsf@gmail.com> From: Dmitry Gutov Message-ID: Date: Wed, 16 Dec 2020 02:55:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29193-done Cc: Lars Ingebrigtsen , 29193-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 14.12.2020 13:03, João Távora wrote: > Feel free to push if you can't come up with anything better in ruby-mode. Pushed, and closing, thanks. Regarding "doing the fix in the proper place", the alternative would be changing the implementation of thing-at-point--end-of-sexp. But I'm not sure it's a well-defined function. It clearly special-cases characters with class "closing paren". And there's no clear counterpart for 'end' (even though it's a sexp closer in ruby-mode's syntax). From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 17 18:25:36 2020 Received: (at 29193) by debbugs.gnu.org; 17 Dec 2020 23:25:36 +0000 Received: from localhost ([127.0.0.1]:37308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq2eO-0002hE-Bz for submit@debbugs.gnu.org; Thu, 17 Dec 2020 18:25:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq2eK-0002gu-Kk for 29193@debbugs.gnu.org; Thu, 17 Dec 2020 18:25:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34473) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq2eF-0001oF-F7; Thu, 17 Dec 2020 18:25:27 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kq2eA-0004gJ-VU; Thu, 17 Dec 2020 18:25:23 -0500 From: Glenn Morris To: 29193@debbugs.gnu.org Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal References: X-Spook: Rand Corporation Lightening explosive FEMA Armed X-Ran: z)@&8/radroz-9>AY6{`P48>;B"gekEp[UGGRyZ`v>G451EP2ohS_yGlJ8qvNx;VWu9-!F X-Hue: cyan X-Attribution: GM Date: Thu, 17 Dec 2020 18:25:09 -0500 In-Reply-To: (GNU bug Tracking System's message of "Wed, 16 Dec 2020 00:57:02 +0000") Message-ID: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29193 Cc: Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) fda9a2 causes a test failure. Ref eg: https://hydra.nixos.org/build/132986117 (Are people trying to run foo-tests.el before pushing changes to foo.el?) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 17 21:06:19 2020 Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 02:06:19 +0000 Received: from localhost ([127.0.0.1]:37368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq59v-00038P-73 for submit@debbugs.gnu.org; Thu, 17 Dec 2020 21:06:19 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:36729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq59q-00038A-NS for 29193@debbugs.gnu.org; Thu, 17 Dec 2020 21:06:18 -0500 Received: by mail-wm1-f49.google.com with SMTP id y23so833719wmi.1 for <29193@debbugs.gnu.org>; Thu, 17 Dec 2020 18:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=myMmEUIv+5rfBHyaeCT2dC5wTShkfv7a3ieXX19OU+8=; b=mH+MjGXVAPdxfll6CnhkHb3QYm+C3eFS1YPmH/VPukMROdxDaG74huMcFWnQF1y+RF 2kHx2nixBh8LZircv4wW2UGfVE0FHt8p3CcdClZwTvrIRWi4wtoRpir+2LJiz2iTcU0+ tQ9u0AN7eg0qqxFdimq3zjSxfzgYI7VcE+hoIRVy8UYkAvti8Yud6svGkWrHELcfjwo7 6sCxma8D18URRAaXatfzSyqqPXMalWQnZAMxs0xsTLmrIumBGA5s7FglOOQ+k5Bj8em2 JqxlRfl81jLA6MKo8XuiWAJwWlGqRKeURyi4jI+qFlA7eBq779KWSgMmVWRHruP2Pl3+ hYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=myMmEUIv+5rfBHyaeCT2dC5wTShkfv7a3ieXX19OU+8=; b=pMJub7Guf3lrJu9ogGOsHlxV9jpge06SdLXUltqCxbesSF+5zepn+8AiY3Yg83oymT BIDnUxqLipycvqjnPeWomrB53huHMEGAECRIN39MHq72FXOTBayrfHvnUUTOSTcIdknZ OdS+N7pGJ6yeyvCChJ3JLvqkyZ8pIHq8WMwGtZVngvneHhxDx9/5siJwATteerhvNjqi O7MtpRCTVscDQvuSNCZeTUkY0ReFteWmiWfPxk32baycpqiwlpMP/2rdhXG3cTCDFdYR tZKl82WWJTZ3RqTadvksh5fGpDCvb07+gRkfptAagiWNvZ5Pkak8LTS6tLHbJbqZwRa+ G45A== X-Gm-Message-State: AOAM533v02x9QjUBzPrcT8vimM+izF3wwcgNZNAH8f93I6OhK13Xf9iT W6H268JqKa0zdBIs79dswEXCzg+VbB1+Rw== X-Google-Smtp-Source: ABdhPJziaH6ja4sNQjwIGCNjN1BB+s1VRLg6R2bq5tzLScI3HeL4HDhbMUg2SxHFpImbrblxEJzgDw== X-Received: by 2002:a7b:c4d5:: with SMTP id g21mr1977693wmk.92.1608257168544; Thu, 17 Dec 2020 18:06:08 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t1sm12122413wro.27.2020.12.17.18.06.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Dec 2020 18:06:07 -0800 (PST) Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: Glenn Morris , 29193@debbugs.gnu.org References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> From: Dmitry Gutov Message-ID: <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> Date: Fri, 18 Dec 2020 04:06:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29193 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.12.2020 01:25, Glenn Morris wrote: > fda9a2 causes a test failure. > > Ref eg:https://hydra.nixos.org/build/132986117 Thanks! It was a curious bug: one would expect that some highlighting's boundaries might change. What changed, however, is one's _type_. I've pushed a fix, and I'll let the Flymake's maintainer sort out at his leisure whether flymake-diag-region can be relied on not to change match data, as several of its clients seem to assume. > (Are people trying to run foo-tests.el before pushing changes to foo.el?) Some of us are spoiled enough to expect an email from the CI when some breakage occurs. (Sorry.) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 06:42:22 2020 Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 11:42:22 +0000 Received: from localhost ([127.0.0.1]:37867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqE9O-0000a5-Af for submit@debbugs.gnu.org; Fri, 18 Dec 2020 06:42:22 -0500 Received: from mail-il1-f176.google.com ([209.85.166.176]:37285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqE9L-0000Zq-Ey for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 06:42:21 -0500 Received: by mail-il1-f176.google.com with SMTP id k8so1877614ilr.4 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 03:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YMKe4U3DY3VedbySMCCsimJ6QvPB7cRNJ7hTfPeZeAE=; b=vGiAIs279XmrKFnLrKJAKaNNvMkpQHrAI3OqlwQ4zh10lCawo70acf5xiSiAF2etbd MjH6Bn553lEawPywBZHjkpxCUp3bVmlHxP0hUbLhJ/UrjjWgFOdqCDLdkqtXm5+N10UQ SmzD/RV1vVj+a5U2GayefmGh9scIO3haUHMt90xSQZfeFxBJH+dRYKeHStH9E7nL6T+O aL506rirG2J3MC84zjT2Sl+QzFDd0OgzhplsBR+DzEfD6VCCu1px2hw3mB1Tlo3+gf8Q 1vvTOt/GWQ1IzQrnGVy5h5pbrH5SZx7emG1zC437edmMvN9pch6rwzv3vZG5GedEExCj +UkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YMKe4U3DY3VedbySMCCsimJ6QvPB7cRNJ7hTfPeZeAE=; b=L9HxYNT7wft9R/k/4NtgwHKqM055Q1xyeW07MWYxNdiw6qu4BTna/7TGdrMuVy7EJ6 wz2snyq5b/CUzYXp/zEn8C9M3kcjScLlbE26jH+UGhcUckUvgCYlpAJCQGI3pTgJnWtj OIvwFrzsAyADeQuIh5437Cuwmes3knOmOMS4dawBkZWoZxx8Mat46QafiButOU7BOigq to2wrAgHcwhn5u6qOgrQ6GXwXeGOQU+6u24PlTY2ZOKHKJcDj1u0b92rIXuj84YjwWM0 VQMCQhVQ9nZ4roY70gvpzSLCWwjxXiw0q2BNP9hcSm5AwdUlcLyLaonr0VTTo5I76WlL mi9w== X-Gm-Message-State: AOAM531fajX+313x1N23djqmmjh3sAll8npDWcPyb8iy+gXH9hltQmi+ t47bx4jj74zXy76hQIGFMcd7nuf9gMYtp/RPkcc= X-Google-Smtp-Source: ABdhPJwKzSqcUi5wRnE5qSA7GnMjeGfgkkJL6yMz5dqAutFOMyKvfElJAmNtsTPEQlzySvywEjvrvCYzM+OBmJ5A9XU= X-Received: by 2002:a92:da82:: with SMTP id u2mr3428201iln.137.1608291733746; Fri, 18 Dec 2020 03:42:13 -0800 (PST) MIME-Version: 1.0 References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> In-Reply-To: <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 18 Dec 2020 11:42:02 +0000 Message-ID: Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: Glenn Morris , 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Dec 18, 2020 at 2:07 AM Dmitry Gutov wrote: > > On 18.12.2020 01:25, Glenn Morris wrote: > > fda9a2 causes a test failure. > > > > Ref eg:https://hydra.nixos.org/build/132986117 > > Thanks! It was a curious bug: one would expect that some highlighting's > boundaries might change. What changed, however, is one's _type_. > > I've pushed a fix, and I'll let the Flymake's maintainer sort out at his > leisure whether flymake-diag-region can be relied on not to change match > data, as several of its clients seem to assume. I think this is rather a thingatpt.el issue, which makes no mention of match-data destruction. Regardless, it's decent enough to do that in flymake-diag-region so I pushed save-match-data a bit higher. Thanks, Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 10:22:29 2020 Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:22:29 +0000 Received: from localhost ([127.0.0.1]:39643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHaP-0004RR-JG for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:22:29 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:34422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHaN-0004RA-KK for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:22:27 -0500 Received: by mail-wm1-f47.google.com with SMTP id g25so6134021wmh.1 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SCRDPkVoBOgO8Ja6MCAnh+Cz+8aMm9+PGS9qNhCttiE=; b=i/YPhrFnc/dO2hpqrT8HJkP1jZUxu2hsVGW845zc//LiX0+3jrr6XTORbunE+VC7tI JFFD5SNt25qu7LY54uWI7amXEaSV/eNc0bn8NJQwQmB8Eh8VGiCLZDj1jmcR+yXNZtS2 ncR9BHgwukbRFhrbtvWzY1g7WPk/ISEDw5LGj8VIlYrck3jZ0w/v7mPO7LGU6XN1TM9W Lltj14/CVQZaPOJv8LK9gZblTRhA5OMj2RoyyfsLq9e88bhLB+mZ4w+i5J89LJYfmiue 00yExMt7EVCNbNtgnzUbf63THERbBzhlGiAW1IJsL/0cTntUEhT85LgZ2uInL91m6Aj4 Jltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SCRDPkVoBOgO8Ja6MCAnh+Cz+8aMm9+PGS9qNhCttiE=; b=b28RijNLnxsQyZirliBLnwX4evp+2wt1M4+u1o4jwUMH95bWm/Fuj0uO5nBnNujRUX wTOlJ3yIPvM6q/hf84MWaVqo/7WlACKmtRKPHGfI83TFcoy+j8gFUfcgHAfsW0p7MAgC X9CM/IrkIGt7VHnF/Gzke9kmnnNd3YpIrdcvfYxjwT3QdiSozOZgngXAe3Sv9IUGuqCM pDKFi8JLEKoW3asd2zb8JKliTRBvrHn3MpauD+fkptAJ9nTDCZ1ogdMW7BxoKG7gfNd3 P17mwAGT47XnOJZ82WuUYF4bgn11vQ1RpGTxANkNZgo69yDLhcXlPgEI/2gVd9U7l9EH L13A== X-Gm-Message-State: AOAM532hgncFhntUL/wHBXXZOQa/xemoyZG9mGY1HH2K5CPz/EjFjENH JFXWCEoee5L1T/+RiIDObQJHMUOpWo+FiQ== X-Google-Smtp-Source: ABdhPJytBMa2bkJ+DQ7QJj+YT1LQQt5266yTjlDcR+2GZERQ6FTBTavMoxmiSYxyYdvjYQusSVzxLA== X-Received: by 2002:a7b:cf37:: with SMTP id m23mr4676488wmg.37.1608304941502; Fri, 18 Dec 2020 07:22:21 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v4sm10550066wrw.42.2020.12.18.07.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Dec 2020 07:22:20 -0800 (PST) Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> From: Dmitry Gutov Message-ID: <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> Date: Fri, 18 Dec 2020 17:22:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29193 Cc: Glenn Morris , 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.12.2020 13:42, João Távora wrote: > I think this is rather a thingatpt.el issue, which makes no mention of > match-data destruction. Regardless, it's decent enough to do that in > flymake-diag-region so I pushed save-match-data a bit higher. By default we assume that any function can destroy match-data (and only a certain set doesn't). But it's an easy mistake to make, especially given the fairly opaque implementation of (end-of-thing 'symbol). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 10:26:45 2020 Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:26:45 +0000 Received: from localhost ([127.0.0.1]:39651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHeX-0004Xs-4v for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:26:45 -0500 Received: from mail-il1-f170.google.com ([209.85.166.170]:35630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHeV-0004Xf-CA for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:26:43 -0500 Received: by mail-il1-f170.google.com with SMTP id t9so2483052ilf.2 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=telQXT8uWTTl+vj0rG8UZuLnXGwq0NLsJ7cKUwLChm0=; b=V53/7odS4ljusNrmtmMMVfzlTqk5Y2gyXPMVtHD5bH8Y/d/+dzAVwKvO4I04TFY5IO bjKUWTdKZuhL7S1kTID4Ax3rhwPjhgdTJ2G4sZGdHNx9JS24/RC6BpAgKnj/9I1QBNIi Id7DAX1go/z6xIhBLk4lo5Gc3uUGWs1UJoW6hpA+LsDa6GVLkG+ZAp7KVX2T1RjrVUtQ BqK8yMrYdfeVqU8/oycUHjS3xBfYY0vM6OFmdH1VvTOVlDM2uH9rXXtvz4eon3UFn/z+ bWrCix6nNq011IEXNSIyAmH838jnEhywTIRzdG67QO8Ia6UEsOo6vR4Th5R8HfMawXOE 5sDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=telQXT8uWTTl+vj0rG8UZuLnXGwq0NLsJ7cKUwLChm0=; b=tnfy9fwn8bp2jms25EjmEt/+dUEWOcCtxKbOJi/uys+cJIUIqr6IG5D/HNhOlPeJ73 1h/5JMxXJIktAHSwpw35iP2SHJyEGRo5oE0uYGRODZLPV5Yl9SMbsOuKPEQLOBlbNerP uHOQL24ceSNHhNvJt+DMlUUJnapYCvmGeiRQTruuMaQpOca8ztNl4DhZkfXETfYFiT1u PhbE6Teb+eB+TaTl2fgeatQfFr6ui0/qk4Im0/rwpYZuF83vWTFRRmHKxY7nnjHPvhoK KrtXESBGIbj7i1oM5YRshGE7JV/gizypVfU3aFVv3LuwxZ9b4ZUYk3iG6PJ5L7JG2HP4 PPLw== X-Gm-Message-State: AOAM530BDsqO8aZ5o4Lplk5FHMLsnXBNtsG1WGk0rWcYoHyS2XqeTnMn kHQYvbWrifWxBgdCOGMkHQz1YPPbP9JgX5WPLHM= X-Google-Smtp-Source: ABdhPJy7C5Rx0uNNoPnQeQ+WIaM3FCuRzjXFT7wkgDbNUPPoaPUKf5xA+95+yUJdaaARi5FVa6M6HTt6P2IYZ3lWBcM= X-Received: by 2002:a92:c682:: with SMTP id o2mr4353434ilg.97.1608305197632; Fri, 18 Dec 2020 07:26:37 -0800 (PST) MIME-Version: 1.0 References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> In-Reply-To: <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 18 Dec 2020 15:26:26 +0000 Message-ID: Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: Glenn Morris , 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Dec 18, 2020 at 3:22 PM Dmitry Gutov wrote: > > On 18.12.2020 13:42, Jo=C3=A3o T=C3=A1vora wrote: > > > I think this is rather a thingatpt.el issue, which makes no mention of > > match-data destruction. Regardless, it's decent enough to do that in > > flymake-diag-region so I pushed save-match-data a bit higher. > > By default we assume that any function can destroy match-data (and only > a certain set doesn't). By that reasoning the problem should be solved in whoever called flymake-diag-region and wrongly assumed it would keep match data. Doesn't a seem very friendly API tho (and no idea who it was, anyway). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 10:29:59 2020 Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:29:59 +0000 Received: from localhost ([127.0.0.1]:39659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHhe-0004ck-Sv for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:29:59 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:38842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHhc-0004cV-QC for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:29:57 -0500 Received: by mail-wm1-f44.google.com with SMTP id g185so2959414wmf.3 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=x+yJjtSJXgNw14HDUncaQINV8Op6FHtLQCRmw2y1zGw=; b=F3wzTzkLyt3MmgGX6dDfMMyBxKNb302XE+x6OLjoDGfw7LLfLISuezNkvvW1rSRfqV +fFcM2/OfEFgflc7JSp5bvrLegE6na+C1A6kqCwkUxN4rQEPskp7Wfwib39lxmTB9sMq CbCyw3Mj3XsCo1t6MVWjePfIcLY3Nn+I99AA87GFvX1aIpJCH9XtEhSwmWGHZPhQ9Bkw Wz/NVZdUBJKR34JXklf6mJzH4xi/P4Y9ohRfs6mDPDgd+M/DKeiDoshkCbkJxWvIK8R0 S9WEsshT/ILqz9c0p2qb9lj+wp7k6WdltfMoa+Qwwom8a+EX+8Eo/rnoE45uAzeeq88n PgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=x+yJjtSJXgNw14HDUncaQINV8Op6FHtLQCRmw2y1zGw=; b=XlQ0XtKpu3ja4vs32hdgGE6aNR2P0NHzl+wRTf9Tc737R5dN1EOkamLMj7WcZD4s1X wFdmP9TMiA4Qhb1A/CIa8FzI292kfe5U4BRNG4RiTldE9i/hbR8ARpCsuRJ0Wf5RJH66 WCf6LVBTet4xsfe+FsFDoMwX3H4sJ8FGEbAcwTT3zZ7bT3Sb/mDuMkcFq1lDzaa4oWpF B7cWYVJBxWqvfk0FK7TnXatsIn/01/QtkuiA+W4hrTOxc0vxnxwTeRMCk4vfbZzEGFLv FohodbIREzvCkgLAqfiml7OhCLYteCR3r3fxdlVQC0wa4mPxJKe49HyGlm0t9K1xXRvi jgaA== X-Gm-Message-State: AOAM530/3nYyZNOfes91KwEbN+G3dvVBFa2J4QQcnxYynScdnr/G1MVe t4hSyqy9EgGJWVULSjXqzRByNbopgVbNcA== X-Google-Smtp-Source: ABdhPJyjaA94Yv1PNWTWc2ppacgiFqfNt/BhZgmhG1kDBqdmYdK7gA6dkGuXJLyZvBipIno8ox6S6A== X-Received: by 2002:a1c:dd07:: with SMTP id u7mr4796307wmg.51.1608305390796; Fri, 18 Dec 2020 07:29:50 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l1sm14560449wrq.64.2020.12.18.07.29.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Dec 2020 07:29:50 -0800 (PST) Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> From: Dmitry Gutov Message-ID: <8d49fda7-289f-46c9-d8d9-35e73bdf2912@yandex.ru> Date: Fri, 18 Dec 2020 17:29:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29193 Cc: Glenn Morris , 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 18.12.2020 17:26, João Távora wrote: > On Fri, Dec 18, 2020 at 3:22 PM Dmitry Gutov wrote: >> >> On 18.12.2020 13:42, João Távora wrote: >> >>> I think this is rather a thingatpt.el issue, which makes no mention of >>> match-data destruction. Regardless, it's decent enough to do that in >>> flymake-diag-region so I pushed save-match-data a bit higher. >> >> By default we assume that any function can destroy match-data (and only >> a certain set doesn't). > > By that reasoning the problem should be solved in whoever called > flymake-diag-region and wrongly assumed it would keep match data. Yes. > Doesn't a seem very friendly API tho (and no idea who it was, anyway). Also true. So we can document that flymake-diag-region does indeed preserve match data. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 18 10:39:26 2020 Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:39:26 +0000 Received: from localhost ([127.0.0.1]:39674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHqo-0004s5-8H for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:39:26 -0500 Received: from mail-il1-f173.google.com ([209.85.166.173]:35985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHqm-0004rs-Tp for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:39:25 -0500 Received: by mail-il1-f173.google.com with SMTP id u12so2517830ilv.3 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LKNT0XR4oK0Bbm7c2KLbONlVBQH+R4M14xJTCtrZ7/c=; b=hxdFIgdnQKCfT/dHWdbBxf3fJZ5lsSjj7BpVuOUBWwix4tVJCowqXrPokZ9oE+pTPn TS72q+RXOK7mrvfRPI9beZ7tbV0lrVy+/yuSQ6B/WHfuc2gdd96Wx3j0OQOaBx6y/VSX z/QGG0QXXa/LI57v9XmSahut841FJu6rj7K0PU2AGUE0wyoCRibVAMupUBVI2bqtqky4 ZCQSAoNJQzl/qg/ag/4Ie5fX8yKj5dsLUS3kLI8ysyMTm5vt4KH+h9Qt912yPOlgLbbH g16iznkcuqhwU55AnQjnVSHYb6Rm2U09p6JpBDy+hP20wRTSy1pwe0oZN0xtrrz/fhTv 5YgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LKNT0XR4oK0Bbm7c2KLbONlVBQH+R4M14xJTCtrZ7/c=; b=TQulPNd/yYc5XlhHkrNyOYccgcU6n3SC05MbOHlPFq0oaGdbiMKghm+lpTHWNvQcL0 l/yqwsp2FIZkx08wVqPWwCXcI4NP6qUrtPFSdM/AQICE38IMcFQmFDr5qulUBCYWuSE7 mXCocC7kM1iMiGwEl2Qkflcif9/oT5no+9FxLAWKXnSd+zwkfkXoJYR76iSZ7QqTm76M F8ajgISANyXd/V9IJQDHRFeemZqmP4dENZdaEqR24Vb2uY52tGlaa2HQ0HhYA/72QqwX 5Z6YazaeZ2/mmD1cJWCZbYy/ijFrhcgieAeaFtnLpuJB9FAMSg6CF63jwxH7bnqxBuVN 1H4A== X-Gm-Message-State: AOAM531oiHQkANsrYIFTdE7mGuaOs/9DWm+S3lgZ8TZPmxcq6mJBY2EG h3Sm/dqSzmh4adLVTR/InEChVK8v/mRV9crJ2yQ= X-Google-Smtp-Source: ABdhPJwELxChZRGTzhE9cxeZKXyA7j7ar2PPkpswWgqZQ8xJnGkdRuG97BAE/px1/vLa7wFGydcIzp4lLr+QDZ5ak4U= X-Received: by 2002:a05:6e02:14ce:: with SMTP id o14mr4426624ilk.9.1608305959124; Fri, 18 Dec 2020 07:39:19 -0800 (PST) MIME-Version: 1.0 References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> <8d49fda7-289f-46c9-d8d9-35e73bdf2912@yandex.ru> In-Reply-To: <8d49fda7-289f-46c9-d8d9-35e73bdf2912@yandex.ru> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 18 Dec 2020 15:39:07 +0000 Message-ID: Subject: Re: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29193 Cc: Glenn Morris , 29193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Dec 18, 2020 at 3:29 PM Dmitry Gutov wrote: > > Doesn't a seem very friendly API tho (and no idea who it was, anyway). > Also true. So we can document that flymake-diag-region does indeed > preserve match data. Done From unknown Mon Jun 23 04:10:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Jan 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator