From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2017 09:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29189@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15100454263582 (code B ref -1); Tue, 07 Nov 2017 09:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Nov 2017 09:03:46 +0000 Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBznO-0000vi-Ge for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBznM-0000vT-Mr for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBznB-0003Ni-S4 for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBznB-0003Nc-Op for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBznA-0004XJ-IK for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 04:03:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBzn4-0003L8-Gh for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 04:03:32 -0500 Received: from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]:55929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBzn4-0003Kh-CH for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 04:03:26 -0500 Received: by mail-qt0-x22d.google.com with SMTP id v41so14283723qtv.12 for ; Tue, 07 Nov 2017 01:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=fCrDoI5LnrhC6ZNRENdWk7nW/DnvR6xE94FXYREVKxc=; b=PcFfLz/iGam64nWl4vq8p19iABjHgcztfZZ3frIADPecep4Tjhy6DLULIVvbHiHj+i 42qm29m5kWYZ0iI0deGYwjDiP0e1CIRe/uWTyAenzkKHiuEA9juFy42lNHKlVNOnAbqq se8AZgCrK3kA29C7KHJGyjC8P/xtXESLtF0ECTgs/l0PTMKxPbNu7xFTmrkJX6+GRaib SrGF4DvZClIhnAweR+7P+Q8sUoCwwFge8nbuc2NoRRIrH8dbEjdwIAg8VjuNmU+jQPU1 oZixUvYSVEH1p/Q0hRIM9hUvzpnjoIpw3T89+wDWO5HF7EObEaiIDbb0tATGsuvZkuLZ FHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fCrDoI5LnrhC6ZNRENdWk7nW/DnvR6xE94FXYREVKxc=; b=MuwspMNVDlTs3TMmf1BbbFadWVjDpLGI245qzSCDYmwysYGWKb7dvpIicPT4SHhr3X MrmUVZhsaAcXUasEw//Rsd5iUxtpPHiJNLyuYs/txkMOMFehSR6xyFSDG+6jh1nJGd19 DQ3Ht7O1+wEVwrTHeqro3XTvT4PwTQpu65JWeyFbbT+N6ERz4EQtZDW12001EtUcMmYc M6cODhx4MnnGVDWRSKiwcoYXMNiokv7/fS5MdFeSR9ernsvat78tswWHl5RGPos7bY8T hm6SL+rtGju85pFOC7Uc9sZyyuI/Iut3Exf/IbIeldnjjK1pJrbXvq6r8yJOWdM1/915 /lQw== X-Gm-Message-State: AMCzsaXfLsCYuaGQ3SX/8Bt+VZk1QEU2Xd7bwQUm9hxeT42pws5v29l9 nPWIKvi65bVRC5FtIxjnu9uQOCKQr4BFQtuzDCW9izh6 X-Google-Smtp-Source: ABhQp+RXheoIwLPYWz79KRJnuidU3zjj0G0l9oST9Mz+qLADD8FxgikSoPA4AT/VgpkCmp+VU6cirDBw9NRQmBXVg5Q= X-Received: by 10.200.47.194 with SMTP id m2mr28366565qta.81.1510045405304; Tue, 07 Nov 2017 01:03:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.19.10 with HTTP; Tue, 7 Nov 2017 01:03:24 -0800 (PST) From: Allen Li Date: Tue, 7 Nov 2017 01:03:24 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Dired does not work with binary filenames For example, create such a file with Bash: touch $'\265' 1. Navigate to the directory containing said file with Dired 2. Mark file for deletion with d 3. x Expected: File deleted Actual: (file-error Removing old name No such file or directory /home/bob/tmp/\300\265) In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2017 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 29189@debbugs.gnu.org Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.15100488188825 (code B ref 29189); Tue, 07 Nov 2017 10:01:02 +0000 Received: (at 29189) by debbugs.gnu.org; 7 Nov 2017 10:00:18 +0000 Received: from localhost ([127.0.0.1]:55195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC0g6-0002IH-5l for submit@debbugs.gnu.org; Tue, 07 Nov 2017 05:00:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:60486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC0g3-0002I7-O8 for 29189@debbugs.gnu.org; Tue, 07 Nov 2017 05:00:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 73EAEAC6F; Tue, 7 Nov 2017 10:00:13 +0000 (UTC) From: Andreas Schwab References: X-Yow: I want the presidency so bad I can already taste the hors d'oeuvres. Date: Tue, 07 Nov 2017 11:00:13 +0100 In-Reply-To: (Allen Li's message of "Tue, 7 Nov 2017 01:03:24 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Nov 07 2017, Allen Li wrote: > Dired does not work with binary filenames > > For example, create such a file with Bash: > > touch $'\265' > > 1. Navigate to the directory containing said file with Dired > 2. Mark file for deletion with d > 3. x > > Expected: > > File deleted It works if you add b to dired-listing-switches, though the buffer isn't properly updated afterwards. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Nov 2017 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151007452526943 (code B ref 29189); Tue, 07 Nov 2017 17:09:01 +0000 Received: (at 29189) by debbugs.gnu.org; 7 Nov 2017 17:08:45 +0000 Received: from localhost ([127.0.0.1]:56835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC7Mj-00070V-16 for submit@debbugs.gnu.org; Tue, 07 Nov 2017 12:08:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eC7Mh-00070J-QS for 29189@debbugs.gnu.org; Tue, 07 Nov 2017 12:08:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC7MY-00052X-QN for 29189@debbugs.gnu.org; Tue, 07 Nov 2017 12:08:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC7MY-00052K-Np; Tue, 07 Nov 2017 12:08:34 -0500 Received: from [176.228.60.248] (port=4186 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eC7MY-0007vf-5m; Tue, 07 Nov 2017 12:08:34 -0500 Date: Tue, 07 Nov 2017 19:08:42 +0200 Message-Id: <83h8u6rp7p.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Andreas Schwab on Tue, 07 Nov 2017 11:00:13 +0100) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Andreas Schwab > Date: Tue, 07 Nov 2017 11:00:13 +0100 > Cc: 29189@debbugs.gnu.org > > > touch $'\265' > > > > 1. Navigate to the directory containing said file with Dired > > 2. Mark file for deletion with d > > 3. x > > > > Expected: > > > > File deleted > > It works if you add b to dired-listing-switches, though the buffer isn't > properly updated afterwards. Here (with the latest emacs-26 branch) it doesn't produce any error messages, and the buffer is updated to remove the name of that file, but 'g' brings it back, so it wasn't really deleted. I stepped into Fdelete_file, and saw that the file name is correctly encoded before calling 'unlink'. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 05:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Andreas Schwab , 29189@debbugs.gnu.org Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151011795529852 (code B ref 29189); Wed, 08 Nov 2017 05:13:01 +0000 Received: (at 29189) by debbugs.gnu.org; 8 Nov 2017 05:12:35 +0000 Received: from localhost ([127.0.0.1]:57428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCIfC-0007lP-4X for submit@debbugs.gnu.org; Wed, 08 Nov 2017 00:12:34 -0500 Received: from mail-qt0-f176.google.com ([209.85.216.176]:44734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCIfA-0007lB-C6 for 29189@debbugs.gnu.org; Wed, 08 Nov 2017 00:12:32 -0500 Received: by mail-qt0-f176.google.com with SMTP id 8so1944072qtv.1 for <29189@debbugs.gnu.org>; Tue, 07 Nov 2017 21:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kXtwu+V4OQOpl2CIWtPqW+W3XFlasC2kEAVx7FVZhYY=; b=uP0D/oXWudYVXxbWaMNa0iJvcrXPkGAcBe4Pt2LhhanRyadFDWA19I0YBaFasHTdGI iHHrDOIR+hKRzdf1tYWF1JIoCw/R/WS8Sk0eE/KDgNaOab/zjhU9c1/36Hi+1HgKWx5a U4q2ao7x9jjHNnipgrNX3T98hxGvZmN+ihwsDZ6UnAtbg/gpccXcMycag1QNs4Yh6PZ8 5YSNBhxFRuqiC2oXYzlP3IoWTClwRU9neT+EH7NFYxC+Dm+OxnEhOPs2LEMIvLmlLTxg 9l8wdHNLSBlUuNI4dkK19rpHyYEiwjkPvj71bMTcSps3kL175I20OLJtnbPrE/DFbR5s G9oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kXtwu+V4OQOpl2CIWtPqW+W3XFlasC2kEAVx7FVZhYY=; b=YhmzegAbk7+XU4TSWIRhvN5fnWrUigeKDb6+cR65cwoTKLyIg+AiM0OndDL63FB2ML HLuQWPQZj7qlrCxOY0LtmOMqG3eLK6iZNQ1/vY4ajvwEZGaB8gqAkhgkuPxQiwmSfA5n hw4SRDRROh3VMvbyAs4EU6HJjDdby++pXAgRCaCggTbzVJIgvVoR+E0ElbFAfN4s9Ppl LzzZFT28IJvjOvGEYKwSWG8fcPqfOwai494LObgYzmCdtnVbbYP55Pq+JCE8FxM9aCY4 fl11bSZqRBl/OV8Pyt5SqAe/leshVTpG3473aEpIi8vFY7rvOZDl979alWZoDI0X3LvU qhig== X-Gm-Message-State: AJaThX6HgUIFnHYd9qeOoyTNBE+KxzE2g8G2ZqWPgtbZkte/7T3mES6T nU7TQf+EOaPeB8ZzkE00h4f5xLijzUgpOsXWTEg= X-Google-Smtp-Source: ABhQp+QDERg4Qz7JCyXj4qJKIP3PLJJmvKPpM0WWT+AxBbiQxradmeG5JfE/v8t5221WlqzcgCs6KzsUH1MMLzf2VNM= X-Received: by 10.200.47.194 with SMTP id m2mr1804259qta.81.1510117946713; Tue, 07 Nov 2017 21:12:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.19.10 with HTTP; Tue, 7 Nov 2017 21:12:26 -0800 (PST) In-Reply-To: <83h8u6rp7p.fsf@gnu.org> References: <83h8u6rp7p.fsf@gnu.org> From: Allen Li Date: Tue, 7 Nov 2017 21:12:26 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Nov 7, 2017 at 9:08 AM, Eli Zaretskii wrote: >> From: Andreas Schwab >> It works if you add b to dired-listing-switches, though the buffer isn't >> properly updated afterwards. > > Here (with the latest emacs-26 branch) it doesn't produce any error > messages, and the buffer is updated to remove the name of that file, > but 'g' brings it back, so it wasn't really deleted. > > I stepped into Fdelete_file, and saw that the file name is correctly > encoded before calling 'unlink'. I can confirm the behavior Andreas describes on Emacs 25. There is a slight bug where the buffer is not updated after the delete, but the delete itself works I do not know about Emacs 26, but it sounds like there's a regression. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 06:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 29189@debbugs.gnu.org Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.15101221294100 (code B ref 29189); Wed, 08 Nov 2017 06:23:02 +0000 Received: (at 29189) by debbugs.gnu.org; 8 Nov 2017 06:22:09 +0000 Received: from localhost ([127.0.0.1]:57469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCJkX-000143-3o for submit@debbugs.gnu.org; Wed, 08 Nov 2017 01:22:09 -0500 Received: from mail-qk0-f181.google.com ([209.85.220.181]:47418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCJkV-00013p-K5 for 29189@debbugs.gnu.org; Wed, 08 Nov 2017 01:22:07 -0500 Received: by mail-qk0-f181.google.com with SMTP id m189so2060055qke.4 for <29189@debbugs.gnu.org>; Tue, 07 Nov 2017 22:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vPU/9L5PyI5WaOIHhIY03ysUE45AXTL2eU+nQiHGiXs=; b=SXmMIY1KfyMnbm/XFv/gc+03b6JHE4tCNF59SEp1LuQCDaNoKOy/WE3ui0GiCs3HOx tdkUZYImNvSrBfAI4t9EgUln3vw+1P70tO82bqFWl+kUa8WMMIPKfGb/Ci2g+UUCTycv Vcva5+NWFNizA364u3S9qzmM9KedG771p4DCHA6X2E6LTw7Gs28bn25IlVmIZNtk94ez 2RJB48s8rOr+5yegJO3916zwtXHMCud5ZyKNWxmr1pZig+L7cIcDAx/vnLp2NXrpphjf 4No/QI+mOeX1X1DwRQlPyX+emrwUNE3sRGySBuqHJG/zfg45tNmdWgoL0sikqvAMtf8s AuaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vPU/9L5PyI5WaOIHhIY03ysUE45AXTL2eU+nQiHGiXs=; b=X/ukkPYhCQwVY8Rdy4uDULZDK0tJHRV6bxtB8JGo+hq5bZaJVA8IL99W4lomJSfJmH 9JUV7YUGLuD+t/ovU/XK/y9cLQ3Y+r9ocOMCShwY9XuMVGo3iiJiOIrweuEHmDLSKoQT vi3NSRruAvvlL2MQigt50mXUZyXLVhsq1FfmUHIXTfC3HWRl5bOAKcgRF5hkNCWI5zu7 CGvI1sQbgEmOU0zstPg0HM1P5SCPvTQnu3D0sr1ZjfQPzRnoSqaFS8HKpDIIS/tvP8GW PkfwhQCTd6BA8KGQsTWxE1MUZnV1DxCyZfkH74riOM4LlMq8dfkYssZMmPbXVz0VXLh4 aX9w== X-Gm-Message-State: AJaThX7z0/PL8fgy8nbC/C3PYM+yQ8IKqyKEsmIFU7rSKHUqmYn71Gvi /Lh6KYlV7I1ZcBrBSh+HhwanTEbObeWVn8LcL98= X-Google-Smtp-Source: ABhQp+QlHrsFGT5LBGvIVccVpl0OvoLH96arORf0fBhlvS0q6wChbIrRdMgIHy/JeVQoT7ndgKfj+eMPXhjqcbQzyXI= X-Received: by 10.55.77.214 with SMTP id a205mr1803678qkb.196.1510122122059; Tue, 07 Nov 2017 22:22:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.19.10 with HTTP; Tue, 7 Nov 2017 22:22:01 -0800 (PST) In-Reply-To: References: From: Allen Li Date: Tue, 7 Nov 2017 22:22:01 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Tue, Nov 7, 2017 at 2:00 AM, Andreas Schwab wrote: > On Nov 07 2017, Allen Li wrote: > >> Dired does not work with binary filenames >> >> For example, create such a file with Bash: >> >> touch $'\265' >> >> 1. Navigate to the directory containing said file with Dired >> 2. Mark file for deletion with d >> 3. x >> >> Expected: >> >> File deleted > > It works if you add b to dired-listing-switches, though the buffer isn't > properly updated afterwards. I just discovered that -b does not play well with wdired. Should I file a separate bug for that? From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Nov 2017 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29189@debbugs.gnu.org, vianchielfaura@gmail.com, schwab@suse.de X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Allen Li , Andreas Schwab X-Debbugs-Original-Cc: 29189@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151013070517659 (code B ref -1); Wed, 08 Nov 2017 08:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2017 08:45:05 +0000 Received: from localhost ([127.0.0.1]:57543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCLyr-0004ak-81 for submit@debbugs.gnu.org; Wed, 08 Nov 2017 03:45:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCLyq-0004Zy-3D for submit@debbugs.gnu.org; Wed, 08 Nov 2017 03:45:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCLyj-0005mR-Q6 for submit@debbugs.gnu.org; Wed, 08 Nov 2017 03:44:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCLyj-0005mB-Nf for submit@debbugs.gnu.org; Wed, 08 Nov 2017 03:44:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCLyi-00066P-Ic for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 03:44:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCLyf-0005ks-EK for bug-gnu-emacs@gnu.org; Wed, 08 Nov 2017 03:44:56 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCLyf-0005kl-A5; Wed, 08 Nov 2017 03:44:53 -0500 Received: from [176.12.255.151] (port=25889 helo=[10.208.246.51]) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eCLye-0005Vq-FL; Wed, 08 Nov 2017 03:44:53 -0500 Date: Wed, 08 Nov 2017 10:44:47 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Eli Zaretskii Message-ID: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On November 8, 2017 8:22:01 AM GMT+02:00, Allen Li wrote: > On Tue, Nov 7, 2017 at 2:00 AM, Andreas Schwab wrote: > > On Nov 07 2017, Allen Li wrote: > > > >> Dired does not work with binary filenames > >> > >> For example, create such a file with Bash: > >> > >> touch $'\265' > >> > >> 1=2E Navigate to the directory containing said file with Dired > >> 2=2E Mark file for deletion with d > >> 3=2E x > >> > >> Expected: > >> > >> File deleted > > > > It works if you add b to dired-listing-switches, though the buffer > isn't > > properly updated afterwards=2E >=20 > I just discovered that -b does not play well with wdired=2E Should I > file a separate bug for that? I don't understand why -b should be used at all=2E In my testing, it wasn't needed=2E Maybe this depends on the locale? What's yours? From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2017 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: schwab@suse.de, 29189@debbugs.gnu.org X-Debbugs-Original-Cc: Andreas Schwab , bug-gnu-emacs@gnu.org, 29189@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151038360813544 (code B ref -1); Sat, 11 Nov 2017 07:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2017 07:00:08 +0000 Received: from localhost ([127.0.0.1]:34624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDPlw-0003WO-0t for submit@debbugs.gnu.org; Sat, 11 Nov 2017 02:00:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDPlv-0003Ud-2B for submit@debbugs.gnu.org; Sat, 11 Nov 2017 02:00:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDPlp-0007WD-52 for submit@debbugs.gnu.org; Sat, 11 Nov 2017 02:00:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eDPlp-0007W9-2D for submit@debbugs.gnu.org; Sat, 11 Nov 2017 02:00:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDPlo-0003HG-3x for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2017 02:00:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDPln-0007VA-By for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2017 02:00:00 -0500 Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]:51158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eDPll-0007U4-Vb; Sat, 11 Nov 2017 01:59:58 -0500 Received: by mail-qk0-x22b.google.com with SMTP id p7so14442643qkd.7; Fri, 10 Nov 2017 22:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7G+roxp1JZIkNPTDboE4Jh1XLxWHUXAYMFNjxXH1pds=; b=QgIzpzlbv17JazqQZ/fjkCgrKtsdCo/hWQC/nG+V0LNN91Uw2AHDPQTRxKBtXXGFeg TCYg7wNwZw9NdaMEHPkcsdlNjMRZR3MolPjEsxxmvwtVqTtiTzwz7slRXbxdw5ohGRcg ZJfd9avJ9o4l+693E3z/Z6NU4JTibB++csNJeux7lMagWLH+qLEFNrLxN21xFO5KKyFK b74IHSmZSzHLjNsQhNtHYGka3FoLb3YY13nbbF+pTVPUaXo1DIwWFvxZhF+Bsp2FPO02 QbnD07U4iTGHyFEEbWjeIkVUZZjTmnmRjzma6zfD6GqwHriqbGQ612s37fxO+gGc0PVz IMLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7G+roxp1JZIkNPTDboE4Jh1XLxWHUXAYMFNjxXH1pds=; b=itwWDQT4a4cAO8HDweAbSRf1bUIWdZj5mZohyrGBC+hC87ksXHaf9DgKQ6jBzkY8Ny hXzApT05BvH+ntZyR8xpbJ4DZEbCm18lFn7ExGy/06694T50lrM5YLnhdbzGqybgnxRH PPtoYNwHBDK59XDBqvXNMag5bUT2sE3XYJCQeXb3dl7aobucowGUaGqH8HSXD3AwDA1K X73oIIDkjShKQwPSjQ2sKL+iESL4f6mb4fm6G/rZiBRcNZIbk1FbLnfW6+zb4J6jycnw uEEbxJc/sb4KvI6AN5CXfPl4YWvW7FWIMdVmlcIR2eP7MHG5shoS2f+lJZAFc5dcv+WC Y3bA== X-Gm-Message-State: AJaThX6tk8usOq0qmN8YKG20KguWvscjAiIetMq+5Bmdr/QLU3drazOb gsX7ocr3z84kUeTa6gJpXqNf7yOTV6+DOs+UlTbQcAzm X-Google-Smtp-Source: AGs4zMZyU+YUyoG+MTwtoZEj5R0KOc6U2qzQc1Gj83asJYNsg/5ba1kms6Ajf3LgLCrr0+nijhsfg6NE97JYZ8N7O30= X-Received: by 10.55.122.135 with SMTP id v129mr4099703qkc.171.1510383596881; Fri, 10 Nov 2017 22:59:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.19.10 with HTTP; Fri, 10 Nov 2017 22:59:56 -0800 (PST) In-Reply-To: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> From: Allen Li Date: Fri, 10 Nov 2017 22:59:56 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) On Wed, Nov 8, 2017 at 12:44 AM, Eli Zaretskii wrote: > I don't understand why -b should be used at all. In my testing, it > wasn't needed. Maybe this depends on the locale? What's yours? en_US.UTF-8 Without -b, the filename in Dired is two binary characters, \300 and \265. With -b, the filename in Dired is four characters, \265 I'm using Emacs 25.3.1 and ls (GNU coreutils) 8.28 It sounds like Andreas is seeing the same behavior as me. What behavior are you seeing when deleting the file with -b vs no -b? From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2017 08:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: schwab@suse.de, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151038844521002 (code B ref 29189); Sat, 11 Nov 2017 08:21:02 +0000 Received: (at 29189) by debbugs.gnu.org; 11 Nov 2017 08:20:45 +0000 Received: from localhost ([127.0.0.1]:34690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDR1x-0005Sg-JE for submit@debbugs.gnu.org; Sat, 11 Nov 2017 03:20:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDR1w-0005SQ-In for 29189@debbugs.gnu.org; Sat, 11 Nov 2017 03:20:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDR1o-0001Ls-AP for 29189@debbugs.gnu.org; Sat, 11 Nov 2017 03:20:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDR1o-0001Ln-6W; Sat, 11 Nov 2017 03:20:36 -0500 Received: from [176.228.60.248] (port=1742 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eDR1n-0006An-Ih; Sat, 11 Nov 2017 03:20:36 -0500 Date: Sat, 11 Nov 2017 10:20:36 +0200 Message-Id: <83a7ztp6p7.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Allen Li on Fri, 10 Nov 2017 22:59:56 -0800) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Allen Li > Date: Fri, 10 Nov 2017 22:59:56 -0800 > Cc: bug-gnu-emacs@gnu.org, Andreas Schwab , 29189@debbugs.gnu.org > > On Wed, Nov 8, 2017 at 12:44 AM, Eli Zaretskii wrote: > > I don't understand why -b should be used at all. In my testing, it > > wasn't needed. Maybe this depends on the locale? What's yours? > > en_US.UTF-8 > > Without -b, the filename in Dired is two binary characters, \300 and > \265. With -b, the filename in Dired is four characters, \265 Sorry, it seems I was confused. You didn't originally say what file name you expected to see in Dired. If the expected file name is \265, a single byte, but you see \300\265 instead, then the problem is not in deletion, the problem is in how Dired prepares file names for display. I will look into that when I have time, if no one beats me to it. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2017 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: vianchielfaura@gmail.com, Kenichi Handa Cc: schwab@suse.de, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151040991129981 (code B ref 29189); Sat, 11 Nov 2017 14:19:02 +0000 Received: (at 29189) by debbugs.gnu.org; 11 Nov 2017 14:18:31 +0000 Received: from localhost ([127.0.0.1]:34842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDWcA-0007nV-SI for submit@debbugs.gnu.org; Sat, 11 Nov 2017 09:18:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDWc9-0007nJ-HG for 29189@debbugs.gnu.org; Sat, 11 Nov 2017 09:18:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDWc3-0007Fr-9Q for 29189@debbugs.gnu.org; Sat, 11 Nov 2017 09:18:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDWbz-0007Et-Fz; Sat, 11 Nov 2017 09:18:19 -0500 Received: from [176.228.60.248] (port=2134 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eDWbz-0000q1-3O; Sat, 11 Nov 2017 09:18:19 -0500 Date: Sat, 11 Nov 2017 16:18:20 +0200 Message-Id: <83k1ywoq4z.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83a7ztp6p7.fsf@gnu.org> (message from Eli Zaretskii on Sat, 11 Nov 2017 10:20:36 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 11 Nov 2017 10:20:36 +0200 > From: Eli Zaretskii > Cc: schwab@suse.de, 29189@debbugs.gnu.org > > > Without -b, the filename in Dired is two binary characters, \300 and > > \265. With -b, the filename in Dired is four characters, \265 > > Sorry, it seems I was confused. You didn't originally say what file > name you expected to see in Dired. If the expected file name is \265, > a single byte, but you see \300\265 instead, then the problem is not > in deletion, the problem is in how Dired prepares file names for > display. I will look into that when I have time, if no one beats me > to it. The problem is in insert-directory. It manually decodes each file name which was output by 'ls', and that produces strangely inconsistent results when the file name includes raw bytes: sometimes we get the 2-byte sequence starting with \300, sometimes the original byte survives unchanged, and sometimes I see the sequence \301\200 instead of a lone \300 in the file name. I'm trying to understand what's going on and find a solution to that. CC'ing Handa-san in the hope that he could comment on this or provide some suggestions. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2017 15:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: vianchielfaura@gmail.com Cc: handa@gnu.org, 29189@debbugs.gnu.org, schwab@suse.de Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.15104136944138 (code B ref 29189); Sat, 11 Nov 2017 15:22:02 +0000 Received: (at 29189) by debbugs.gnu.org; 11 Nov 2017 15:21:34 +0000 Received: from localhost ([127.0.0.1]:35493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDXbB-00014f-OD for submit@debbugs.gnu.org; Sat, 11 Nov 2017 10:21:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDXbA-00014S-F1 for 29189@debbugs.gnu.org; Sat, 11 Nov 2017 10:21:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDXb4-00087h-Eg for 29189@debbugs.gnu.org; Sat, 11 Nov 2017 10:21:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDXaz-000858-62; Sat, 11 Nov 2017 10:21:21 -0500 Received: from [176.228.60.248] (port=2428 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eDXay-0006I0-JK; Sat, 11 Nov 2017 10:21:21 -0500 Date: Sat, 11 Nov 2017 17:21:21 +0200 Message-Id: <83h8u0on7y.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83k1ywoq4z.fsf@gnu.org> (message from Eli Zaretskii on Sat, 11 Nov 2017 16:18:20 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 11 Nov 2017 16:18:20 +0200 > From: Eli Zaretskii > Cc: schwab@suse.de, 29189@debbugs.gnu.org > > The problem is in insert-directory. It manually decodes each file > name which was output by 'ls', and that produces strangely > inconsistent results when the file name includes raw bytes: sometimes > we get the 2-byte sequence starting with \300, sometimes the original > byte survives unchanged, and sometimes I see the sequence \301\200 > instead of a lone \300 in the file name. I'm trying to understand > what's going on and find a solution to that. Can you please try the patch below? (You will need to re-dump Emacs after patching files.el.) diff --git a/lisp/files.el b/lisp/files.el index b47411f..43198bc 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -6803,10 +6803,13 @@ insert-directory val (get-text-property (point) 'dired-filename)) (goto-char (next-single-property-change (point) 'dired-filename nil (point-max))) - ;; Force no eol conversion on a file name, so - ;; that CR is preserved. - (decode-coding-region pos (point) - (if val coding-no-eol coding)) + (let ((fn (buffer-substring-no-properties pos (point)))) + (delete-region pos (point)) + (insert + ;; Force no eol conversion on a file name, so + ;; that CR is preserved. + (decode-coding-string (string-make-unibyte fn) + (if val coding-no-eol coding)))) (if val (put-text-property pos (point) 'dired-filename t))))))) From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2017 06:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: handa@gnu.org, 29189@debbugs.gnu.org, Andreas Schwab Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151081391715326 (code B ref 29189); Thu, 16 Nov 2017 06:32:02 +0000 Received: (at 29189) by debbugs.gnu.org; 16 Nov 2017 06:31:57 +0000 Received: from localhost ([127.0.0.1]:42473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFDiO-0003z7-9X for submit@debbugs.gnu.org; Thu, 16 Nov 2017 01:31:57 -0500 Received: from mail-qt0-f173.google.com ([209.85.216.173]:57343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFDiM-0003yu-J6 for 29189@debbugs.gnu.org; Thu, 16 Nov 2017 01:31:54 -0500 Received: by mail-qt0-f173.google.com with SMTP id r39so23845081qtr.13 for <29189@debbugs.gnu.org>; Wed, 15 Nov 2017 22:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/3F8ngCcsWMLgKjYQvfRqCtjJgGv2YvED0gmwAsxP6s=; b=efN1zzf7t+xsBnYi090QRX7/2VQ4eTa/dYgBtIsFYHaga+LsU3vIRfWmmKd73q95RL 9GvZK0jKl+YjlmquY0BAMXKwzufmEDBC9cpeKpd0KwU00e0x6tQ6qMaTRN8pDVo/d7yt vVu0Lamt7ZKH0cmO9L2jgVxczvoxJfJJE1uu9s2ExwOJcbrt2OXutZrfA6gBPVsiLatU kLv+z4Bpp7GVY7lgUVrg8RsQijmtYGA8s/3sUZnWAe8masFClTmMBcDUanGfAHtHORQ0 c2ERPDBIC0Bvt7rPPBRkQonxLnaCBGpNA403RKPqFeJeSBFTTTVQYj1gMRzFXEkCp802 jNvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/3F8ngCcsWMLgKjYQvfRqCtjJgGv2YvED0gmwAsxP6s=; b=F2HRN4G5GjmJCG806S1RuiJLm/gINqVDxjTmU9tYw7c/2GcRrBLEaPZdkOR1cO2FYc R2G2iRrInVIvAZTg0vmwRznkdKLOdiqxV9QYXXrNRaYNiQlN5iE1+ZJ1NCt/HAMzCmH+ 3lXAZS8cqTEIY2gKdNboBPp695DQd+NBJ2nWdqKZertpVWmQ1QUJ5YLDifdDKc4in8SJ zttdFZdgy6J1zp54Xk82+OnVwxoYMyp6fM7tdlvK1rlmkDTkVpgDFneMb//X83SC80TN IVayD/KMFo06LzJXtgFwpaCsB27zIVpuxDAxG7iwNw82sbsKPSKxSenu1U05X7wJ6UIN RbPw== X-Gm-Message-State: AJaThX7ADtJzRN/zPRTKcdxm7j/j+CuEGoZcnoNqADfgB5G5sRFCbFBr cUVUNj0IjMj605L+ux7moSRwpDvWg2efzwwH+2Q= X-Google-Smtp-Source: AGs4zMbK0HQsfwx5etADxS5ka23LejbEHIyk3tj5XJXAz/hkg8MiDgwfPCshXRg9eCDin4eJOntjfTbohxRh5XSRSuI= X-Received: by 10.55.54.146 with SMTP id d140mr891066qka.39.1510813909065; Wed, 15 Nov 2017 22:31:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.53.92 with HTTP; Wed, 15 Nov 2017 22:31:48 -0800 (PST) In-Reply-To: <83h8u0on7y.fsf@gnu.org> References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> From: Allen Li Date: Wed, 15 Nov 2017 22:31:48 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, Nov 11, 2017 at 7:21 AM, Eli Zaretskii wrote: >> Date: Sat, 11 Nov 2017 16:18:20 +0200 >> From: Eli Zaretskii >> Cc: schwab@suse.de, 29189@debbugs.gnu.org >> >> The problem is in insert-directory. It manually decodes each file >> name which was output by 'ls', and that produces strangely >> inconsistent results when the file name includes raw bytes: sometimes >> we get the 2-byte sequence starting with \300, sometimes the original >> byte survives unchanged, and sometimes I see the sequence \301\200 >> instead of a lone \300 in the file name. I'm trying to understand >> what's going on and find a solution to that. > > Can you please try the patch below? (You will need to re-dump Emacs > after patching files.el.) > > diff --git a/lisp/files.el b/lisp/files.el > index b47411f..43198bc 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -6803,10 +6803,13 @@ insert-directory > val (get-text-property (point) 'dired-filename)) > (goto-char (next-single-property-change > (point) 'dired-filename nil (point-max))) > - ;; Force no eol conversion on a file name, so > - ;; that CR is preserved. > - (decode-coding-region pos (point) > - (if val coding-no-eol coding)) > + (let ((fn (buffer-substring-no-properties pos (point)))) > + (delete-region pos (point)) > + (insert > + ;; Force no eol conversion on a file name, so > + ;; that CR is preserved. > + (decode-coding-string (string-make-unibyte fn) > + (if val coding-no-eol coding)))) > (if val > (put-text-property pos (point) > 'dired-filename t))))))) This patch works for me. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2017 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: handa@gnu.org, 29189@debbugs.gnu.org, schwab@suse.de Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151084805611375 (code B ref 29189); Thu, 16 Nov 2017 16:01:02 +0000 Received: (at 29189) by debbugs.gnu.org; 16 Nov 2017 16:00:56 +0000 Received: from localhost ([127.0.0.1]:43749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFMb2-0002xP-DW for submit@debbugs.gnu.org; Thu, 16 Nov 2017 11:00:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFMb0-0002xB-VX for 29189@debbugs.gnu.org; Thu, 16 Nov 2017 11:00:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFMas-0003p8-3q for 29189@debbugs.gnu.org; Thu, 16 Nov 2017 11:00:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFMan-0003jb-Fy; Thu, 16 Nov 2017 11:00:41 -0500 Received: from [176.228.60.248] (port=1959 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eFMam-0002AX-SV; Thu, 16 Nov 2017 11:00:41 -0500 Date: Thu, 16 Nov 2017 18:00:55 +0200 Message-Id: <83po8ii56w.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Allen Li on Wed, 15 Nov 2017 22:31:48 -0800) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Allen Li > Date: Wed, 15 Nov 2017 22:31:48 -0800 > Cc: handa@gnu.org, Andreas Schwab , 29189@debbugs.gnu.org > > > diff --git a/lisp/files.el b/lisp/files.el > > index b47411f..43198bc 100644 > > --- a/lisp/files.el > > +++ b/lisp/files.el > > @@ -6803,10 +6803,13 @@ insert-directory > > val (get-text-property (point) 'dired-filename)) > > (goto-char (next-single-property-change > > (point) 'dired-filename nil (point-max))) > > - ;; Force no eol conversion on a file name, so > > - ;; that CR is preserved. > > - (decode-coding-region pos (point) > > - (if val coding-no-eol coding)) > > + (let ((fn (buffer-substring-no-properties pos (point)))) > > + (delete-region pos (point)) > > + (insert > > + ;; Force no eol conversion on a file name, so > > + ;; that CR is preserved. > > + (decode-coding-string (string-make-unibyte fn) > > + (if val coding-no-eol coding)))) > > (if val > > (put-text-property pos (point) > > 'dired-filename t))))))) > > This patch works for me. Thanks for testing. I'm still worried that we need to force text to be unibyte in order for the decoding to work. So I'd like to dig into the code to understand why, and maybe try to fix it if I find some problems there. If I succeed, the result will work faster, because the above patch is less efficient that decode-coding-region. Let me look into this and get back to you in a few days. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2017 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org, schwab@suse.de Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151101617332110 (code B ref 29189); Sat, 18 Nov 2017 14:43:01 +0000 Received: (at 29189) by debbugs.gnu.org; 18 Nov 2017 14:42:53 +0000 Received: from localhost ([127.0.0.1]:45665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG4Kb-0008Lq-F6 for submit@debbugs.gnu.org; Sat, 18 Nov 2017 09:42:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG4KZ-0008Lc-KX for 29189@debbugs.gnu.org; Sat, 18 Nov 2017 09:42:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eG4KT-0000XW-Cy for 29189@debbugs.gnu.org; Sat, 18 Nov 2017 09:42:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eG4KM-0000WO-KY; Sat, 18 Nov 2017 09:42:38 -0500 Received: from [176.228.60.248] (port=4801 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eG4KL-00069A-M6; Sat, 18 Nov 2017 09:42:38 -0500 Date: Sat, 18 Nov 2017 16:42:22 +0200 Message-Id: <83lgj3fy29.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83po8ii56w.fsf@gnu.org> (message from Eli Zaretskii on Thu, 16 Nov 2017 18:00:55 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Thu, 16 Nov 2017 18:00:55 +0200 > From: Eli Zaretskii > Cc: 29189@debbugs.gnu.org, schwab@suse.de > > > From: Allen Li > > Date: Wed, 15 Nov 2017 22:31:48 -0800 > > Cc: handa@gnu.org, Andreas Schwab , 29189@debbugs.gnu.org > > > > > diff --git a/lisp/files.el b/lisp/files.el > > > index b47411f..43198bc 100644 > > > --- a/lisp/files.el > > > +++ b/lisp/files.el > > > @@ -6803,10 +6803,13 @@ insert-directory > > > val (get-text-property (point) 'dired-filename)) > > > (goto-char (next-single-property-change > > > (point) 'dired-filename nil (point-max))) > > > - ;; Force no eol conversion on a file name, so > > > - ;; that CR is preserved. > > > - (decode-coding-region pos (point) > > > - (if val coding-no-eol coding)) > > > + (let ((fn (buffer-substring-no-properties pos (point)))) > > > + (delete-region pos (point)) > > > + (insert > > > + ;; Force no eol conversion on a file name, so > > > + ;; that CR is preserved. > > > + (decode-coding-string (string-make-unibyte fn) > > > + (if val coding-no-eol coding)))) > > > (if val > > > (put-text-property pos (point) > > > 'dired-filename t))))))) > > > > This patch works for me. > > Thanks for testing. I'm still worried that we need to force text to > be unibyte in order for the decoding to work. So I'd like to dig into > the code to understand why, and maybe try to fix it if I find some > problems there. If I succeed, the result will work faster, because > the above patch is less efficient that decode-coding-region. Let me > look into this and get back to you in a few days. I found that the alternative patch below solves the original problem without any changes needed in files.el, and without introducing any performance hits. Does anyone see a problem with this proposed patch? Kenichi? diff --git a/src/coding.c b/src/coding.c index d790ad0..eaad0d7 100644 --- a/src/coding.c +++ b/src/coding.c @@ -7423,10 +7423,21 @@ decode_coding (struct coding_system *coding) while (nbytes-- > 0) { - int c = *src++; + int c; - if (c & 0x80) - c = BYTE8_TO_CHAR (c); + /* Copy raw bytes in their 2-byte forms as single characters. */ + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) + { + c = STRING_CHAR_ADVANCE (src); + nbytes--; + } + else + { + c = *src++; + + if (c & 0x80) + c = BYTE8_TO_CHAR (c); + } coding->charbuf[coding->charbuf_used++] = c; } produce_chars (coding, Qnil, 1); From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2017 09:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Kenichi Handa , 29189@debbugs.gnu.org, vianchielfaura@gmail.com Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151117129425195 (code B ref 29189); Mon, 20 Nov 2017 09:49:01 +0000 Received: (at 29189) by debbugs.gnu.org; 20 Nov 2017 09:48:14 +0000 Received: from localhost ([127.0.0.1]:48308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGigW-0006YH-A0 for submit@debbugs.gnu.org; Mon, 20 Nov 2017 04:48:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:40569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGigU-0006Y8-J8 for 29189@debbugs.gnu.org; Mon, 20 Nov 2017 04:48:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8A47FAC63; Mon, 20 Nov 2017 09:48:09 +0000 (UTC) From: Andreas Schwab References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> X-Yow: Didn't KIERKEGAARD wear out his TIRES in VIENNA during a SNOWSTORM of FREUD's unpaid DENTAL BILLS? Date: Mon, 20 Nov 2017 10:48:09 +0100 In-Reply-To: <83lgj3fy29.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Nov 2017 16:42:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Nov 18 2017, Eli Zaretskii wrote: > I found that the alternative patch below solves the original problem > without any changes needed in files.el, and without introducing any > performance hits. Does anyone see a problem with this proposed patch? > Kenichi? > > diff --git a/src/coding.c b/src/coding.c > index d790ad0..eaad0d7 100644 > --- a/src/coding.c > +++ b/src/coding.c > @@ -7423,10 +7423,21 @@ decode_coding (struct coding_system *coding) > > while (nbytes-- > 0) > { > - int c = *src++; > + int c; > > - if (c & 0x80) > - c = BYTE8_TO_CHAR (c); > + /* Copy raw bytes in their 2-byte forms as single characters. */ > + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > + { > + c = STRING_CHAR_ADVANCE (src); CHAR_BYTE8_HEAD_P and STRING_CHAR_ADVANCE are only valid for multibyte strings. I don't think it makes sense to use them for unibyte strings. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2017 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab , handa@gnu.org Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151120178018386 (code B ref 29189); Mon, 20 Nov 2017 18:17:02 +0000 Received: (at 29189) by debbugs.gnu.org; 20 Nov 2017 18:16:20 +0000 Received: from localhost ([127.0.0.1]:49337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGqcG-0004mD-Ek for submit@debbugs.gnu.org; Mon, 20 Nov 2017 13:16:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGqcE-0004gz-TG for 29189@debbugs.gnu.org; Mon, 20 Nov 2017 13:16:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGqc3-0007jO-Kb for 29189@debbugs.gnu.org; Mon, 20 Nov 2017 13:16:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGqbz-0007hS-Kv; Mon, 20 Nov 2017 13:16:03 -0500 Received: from [176.228.60.248] (port=3001 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eGqbz-0000n4-65; Mon, 20 Nov 2017 13:16:03 -0500 Date: Mon, 20 Nov 2017 20:15:55 +0200 Message-Id: <831skserz8.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Andreas Schwab on Mon, 20 Nov 2017 10:48:09 +0100) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Andreas Schwab > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org > Date: Mon, 20 Nov 2017 10:48:09 +0100 > > > + /* Copy raw bytes in their 2-byte forms as single characters. */ > > + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > + { > > + c = STRING_CHAR_ADVANCE (src); > > CHAR_BYTE8_HEAD_P and STRING_CHAR_ADVANCE are only valid for multibyte > strings. I don't think it makes sense to use them for unibyte strings. Right you are, thanks. Updated patch below. diff --git a/src/coding.c b/src/coding.c index d790ad0..ac55f87 100644 --- a/src/coding.c +++ b/src/coding.c @@ -7423,10 +7423,23 @@ decode_coding (struct coding_system *coding) while (nbytes-- > 0) { - int c = *src++; + int c; - if (c & 0x80) - c = BYTE8_TO_CHAR (c); + /* Copy raw bytes in their 2-byte forms from multibyte + text as single characters. */ + if (coding->src_multibyte + && CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) + { + c = STRING_CHAR_ADVANCE (src); + nbytes--; + } + else + { + c = *src++; + + if (c & 0x80) + c = BYTE8_TO_CHAR (c); + } coding->charbuf[coding->charbuf_used++] = c; } produce_chars (coding, Qnil, 1); From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Nov 2017 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kenichi Handa Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151151357020500 (code B ref 29189); Fri, 24 Nov 2017 08:53:02 +0000 Received: (at 29189) by debbugs.gnu.org; 24 Nov 2017 08:52:50 +0000 Received: from localhost ([127.0.0.1]:54671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eI9j7-0005Ka-Of for submit@debbugs.gnu.org; Fri, 24 Nov 2017 03:52:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eI9j6-0005KJ-Dx for 29189@debbugs.gnu.org; Fri, 24 Nov 2017 03:52:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eI9j0-0000R3-4F for 29189@debbugs.gnu.org; Fri, 24 Nov 2017 03:52:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eI9iw-0000N4-UH; Fri, 24 Nov 2017 03:52:38 -0500 Received: from [176.228.60.248] (port=2635 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eI9iw-0005OZ-Fw; Fri, 24 Nov 2017 03:52:38 -0500 Date: Fri, 24 Nov 2017 10:52:19 +0200 Message-Id: <83o9ns9hz0.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <831skserz8.fsf@gnu.org> (message from Eli Zaretskii on Mon, 20 Nov 2017 20:15:55 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <831skserz8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ping! Kenichi, any comments on this issue or the proposed patch? > Date: Mon, 20 Nov 2017 20:15:55 +0200 > From: Eli Zaretskii > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > From: Andreas Schwab > > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > Date: Mon, 20 Nov 2017 10:48:09 +0100 > > > > > + /* Copy raw bytes in their 2-byte forms as single characters. */ > > > + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > > + { > > > + c = STRING_CHAR_ADVANCE (src); > > > > CHAR_BYTE8_HEAD_P and STRING_CHAR_ADVANCE are only valid for multibyte > > strings. I don't think it makes sense to use them for unibyte strings. > > Right you are, thanks. Updated patch below. > > diff --git a/src/coding.c b/src/coding.c > index d790ad0..ac55f87 100644 > --- a/src/coding.c > +++ b/src/coding.c > @@ -7423,10 +7423,23 @@ decode_coding (struct coding_system *coding) > > while (nbytes-- > 0) > { > - int c = *src++; > + int c; > > - if (c & 0x80) > - c = BYTE8_TO_CHAR (c); > + /* Copy raw bytes in their 2-byte forms from multibyte > + text as single characters. */ > + if (coding->src_multibyte > + && CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > + { > + c = STRING_CHAR_ADVANCE (src); > + nbytes--; > + } > + else > + { > + c = *src++; > + > + if (c & 0x80) > + c = BYTE8_TO_CHAR (c); > + } > coding->charbuf[coding->charbuf_used++] = c; > } > produce_chars (coding, Qnil, 1); > > > > From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Dec 2017 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: handa@gnu.org Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151211774016986 (code B ref 29189); Fri, 01 Dec 2017 08:43:02 +0000 Received: (at 29189) by debbugs.gnu.org; 1 Dec 2017 08:42:20 +0000 Received: from localhost ([127.0.0.1]:38967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKgto-0004Pu-Ie for submit@debbugs.gnu.org; Fri, 01 Dec 2017 03:42:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKgtm-0004Ph-Qu for 29189@debbugs.gnu.org; Fri, 01 Dec 2017 03:42:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eKgtg-0004wb-P1 for 29189@debbugs.gnu.org; Fri, 01 Dec 2017 03:42:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eKgtb-0004tB-Gd; Fri, 01 Dec 2017 03:42:07 -0500 Received: from [176.228.60.248] (port=1820 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eKgta-0002aU-Ue; Fri, 01 Dec 2017 03:42:07 -0500 Date: Fri, 01 Dec 2017 10:41:47 +0200 Message-Id: <83k1y63kms.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83o9ns9hz0.fsf@gnu.org> (message from Eli Zaretskii on Fri, 24 Nov 2017 10:52:19 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <831skserz8.fsf@gnu.org> <83o9ns9hz0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ping! Ping! I'd _really_ like to fix this for Emacs 26, but I'm bothered by the potential adverse consequences of making changes in such a central piece of code. Still hoping to get comments from Handa-san. > Date: Fri, 24 Nov 2017 10:52:19 +0200 > From: Eli Zaretskii > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > Ping! Kenichi, any comments on this issue or the proposed patch? > > > Date: Mon, 20 Nov 2017 20:15:55 +0200 > > From: Eli Zaretskii > > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > > From: Andreas Schwab > > > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > Date: Mon, 20 Nov 2017 10:48:09 +0100 > > > > > > > + /* Copy raw bytes in their 2-byte forms as single characters. */ > > > > + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > > > + { > > > > + c = STRING_CHAR_ADVANCE (src); > > > > > > CHAR_BYTE8_HEAD_P and STRING_CHAR_ADVANCE are only valid for multibyte > > > strings. I don't think it makes sense to use them for unibyte strings. > > > > Right you are, thanks. Updated patch below. > > > > diff --git a/src/coding.c b/src/coding.c > > index d790ad0..ac55f87 100644 > > --- a/src/coding.c > > +++ b/src/coding.c > > @@ -7423,10 +7423,23 @@ decode_coding (struct coding_system *coding) > > > > while (nbytes-- > 0) > > { > > - int c = *src++; > > + int c; > > > > - if (c & 0x80) > > - c = BYTE8_TO_CHAR (c); > > + /* Copy raw bytes in their 2-byte forms from multibyte > > + text as single characters. */ > > + if (coding->src_multibyte > > + && CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > + { > > + c = STRING_CHAR_ADVANCE (src); > > + nbytes--; > > + } > > + else > > + { > > + c = *src++; > > + > > + if (c & 0x80) > > + c = BYTE8_TO_CHAR (c); > > + } > > coding->charbuf[coding->charbuf_used++] = c; > > } > > produce_chars (coding, Qnil, 1); > > > > > > > > > > > > From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 05:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Andreas Schwab , 29189@debbugs.gnu.org, handa@gnu.org Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151219208611379 (code B ref 29189); Sat, 02 Dec 2017 05:22:01 +0000 Received: (at 29189) by debbugs.gnu.org; 2 Dec 2017 05:21:26 +0000 Received: from localhost ([127.0.0.1]:40867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL0Ev-0002xS-7F for submit@debbugs.gnu.org; Sat, 02 Dec 2017 00:21:25 -0500 Received: from mail-qk0-f172.google.com ([209.85.220.172]:39351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL0Er-0002xE-CH for 29189@debbugs.gnu.org; Sat, 02 Dec 2017 00:21:21 -0500 Received: by mail-qk0-f172.google.com with SMTP id u184so15771412qkd.6 for <29189@debbugs.gnu.org>; Fri, 01 Dec 2017 21:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CPqbeYTyFQaOA3VKe/JoB3Y5ff38Qwio3oQJuZztT3E=; b=K9ec5emnWwTq4tx4+NB6lbhZ0zIbXKeOFpy4PDCReiAI37diGKtfW0gGgTaUt0j/Vv Fh92GCoZdYwlZOAUu2fZvmF3uzb6ZOsz0CXGm7eJ2GdU22pIWRVPV88LACtWCCEMEfxa r2yWwUNib51l0LVjYXTDH5yn03syC0ahwYIp8rphYh+3swbWhz+ExEtDQRsVE5CK5rr5 7KEZdYs/RbAsAE74d+6Kp7HTcz+81ap6s0KWe2zVZqmO5gxVQGpKta/Azc1XFHEA1gBu 5sy7UjVJLgiSSsFDI2XTo9yLBsw2Qdmx/Q65VEeOXNIpVvsIhE3EFSw6HwuAVwXJrw5y BLUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CPqbeYTyFQaOA3VKe/JoB3Y5ff38Qwio3oQJuZztT3E=; b=fFseazAK2DQrNZz1+rvtGy3Q7YoxoJh7WFJPqlDsXpAYAPR5xnl4CHr0iLVi4tkfLD VRQUo/QUDoZN/98kyBTqiN1ZVqIBGEsBiHosxTsERz1+F87j9AE5m08tOr9KZ9nLyOZ7 CQhWzfqpWENvnAYxpMcUYh/ClVvggRaV1JIqXvuIOe9TTkQEQYAY3bCftgub6ntl/Sxf ZHrRM9u+NF0U9DX1Is4HS5f7f2zt3OWwjHCh8tQ4cjueZwrhnaj7gQiAEt/71WnVh+Jc Hi0TG3XVWf8NvUv1MpCOYRsP5dUvs/X/4bJFerViYSbBydoXQ9+WK5kHWvTgJoDazl4T FR7A== X-Gm-Message-State: AKGB3mKxkuLelON1Lf3oKK/K7M0nvK1MJrjlUPtP1BiDT6v/o39B7031 MOBXBJfS+sBHykg+TmA/QoaFSazYrwTUEqCodPc= X-Google-Smtp-Source: AGs4zMbMu55CWCBmCfpr7xWR8GxU3FcIB/Z2FoCqDhHG7kiQMYpz/urYp2g4m44waG9hhZw6TaCojBoR5iAHWGYZdNw= X-Received: by 10.55.18.134 with SMTP id 6mr11610690qks.136.1512192075547; Fri, 01 Dec 2017 21:21:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Fri, 1 Dec 2017 21:21:14 -0800 (PST) In-Reply-To: <831skserz8.fsf@gnu.org> References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <831skserz8.fsf@gnu.org> From: Allen Li Date: Fri, 1 Dec 2017 21:21:14 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, Nov 20, 2017 at 10:15 AM, Eli Zaretskii wrote: > Right you are, thanks. Updated patch below. > > diff --git a/src/coding.c b/src/coding.c > index d790ad0..ac55f87 100644 > --- a/src/coding.c > +++ b/src/coding.c > @@ -7423,10 +7423,23 @@ decode_coding (struct coding_system *coding) > > while (nbytes-- > 0) > { > - int c = *src++; > + int c; > > - if (c & 0x80) > - c = BYTE8_TO_CHAR (c); > + /* Copy raw bytes in their 2-byte forms from multibyte > + text as single characters. */ > + if (coding->src_multibyte > + && CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > + { > + c = STRING_CHAR_ADVANCE (src); > + nbytes--; > + } > + else > + { > + c = *src++; > + > + if (c & 0x80) > + c = BYTE8_TO_CHAR (c); > + } > coding->charbuf[coding->charbuf_used++] = c; > } > produce_chars (coding, Qnil, 1); I applied this patch to master (0b6f4f2c60) and it fixes the bug and doesn't crash Emacs immediately. The code also looks right, but I am not familiar with Emacs's C code. A few questions. Why do we have to handle multibyte strings in this function decode_coding? (I found the answer in the docs) Can you briefly explain how Emacs internally stores unibyte and multibyte strings? (I found the answer in character.h) After doing the above research, I can more confidently say this is right, but having an expert opinion would be nice. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: schwab@suse.de, 29189@debbugs.gnu.org, handa@gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151220529031372 (code B ref 29189); Sat, 02 Dec 2017 09:02:02 +0000 Received: (at 29189) by debbugs.gnu.org; 2 Dec 2017 09:01:30 +0000 Received: from localhost ([127.0.0.1]:40971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL3fu-00089w-9T for submit@debbugs.gnu.org; Sat, 02 Dec 2017 04:01:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL3fs-00089k-QT for 29189@debbugs.gnu.org; Sat, 02 Dec 2017 04:01:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eL3fm-0006Mf-Sx for 29189@debbugs.gnu.org; Sat, 02 Dec 2017 04:01:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eL3fj-0006ID-8C; Sat, 02 Dec 2017 04:01:19 -0500 Received: from [176.228.60.248] (port=3877 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eL3fi-0007iM-OT; Sat, 02 Dec 2017 04:01:19 -0500 Date: Sat, 02 Dec 2017 11:01:01 +0200 Message-Id: <83indp1p2q.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Allen Li on Fri, 1 Dec 2017 21:21:14 -0800) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <831skserz8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Allen Li > Date: Fri, 1 Dec 2017 21:21:14 -0800 > Cc: Andreas Schwab , handa@gnu.org, 29189@debbugs.gnu.org > > I applied this patch to master (0b6f4f2c60) and it fixes the bug and > doesn't crash Emacs immediately. The code also looks right, but I am > not familiar with Emacs's C code. A few questions. > > Why do we have to handle multibyte strings in this function > decode_coding? (I found the answer in the docs) decode_coding needs to work when a series of raw bytes is inserted into a multibyte buffer (which happens in the Dired case). > Can you briefly explain how Emacs internally stores unibyte and > multibyte strings? (I found the answer in character.h) Right, the details are in that header file. > After doing the above research, I can more confidently say this is > right, but having an expert opinion would be nice. Thanks for proofreading the patch and testing it. I'm waiting for Handa-san to comment on it. From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Dec 2017 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: handa@gnu.org Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.1512810268444 (code B ref 29189); Sat, 09 Dec 2017 09:05:02 +0000 Received: (at 29189) by debbugs.gnu.org; 9 Dec 2017 09:04:28 +0000 Received: from localhost ([127.0.0.1]:53108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNb3b-000075-MZ for submit@debbugs.gnu.org; Sat, 09 Dec 2017 04:04:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNb3Z-00006s-H3 for 29189@debbugs.gnu.org; Sat, 09 Dec 2017 04:04:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNb3T-00049G-BH for 29189@debbugs.gnu.org; Sat, 09 Dec 2017 04:04:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNb3P-00047m-Lv; Sat, 09 Dec 2017 04:04:15 -0500 Received: from [176.228.60.248] (port=4257 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eNb3O-0000l3-Vw; Sat, 09 Dec 2017 04:04:15 -0500 Date: Sat, 09 Dec 2017 11:03:57 +0200 Message-Id: <83efo4uvb6.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83k1y63kms.fsf@gnu.org> (message from Eli Zaretskii on Fri, 01 Dec 2017 10:41:47 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <831skserz8.fsf@gnu.org> <83o9ns9hz0.fsf@gnu.org> <83k1y63kms.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ping! Ping! Ping! > Date: Fri, 01 Dec 2017 10:41:47 +0200 > From: Eli Zaretskii > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > Ping! Ping! I'd _really_ like to fix this for Emacs 26, but I'm > bothered by the potential adverse consequences of making changes in > such a central piece of code. > > Still hoping to get comments from Handa-san. > > > Date: Fri, 24 Nov 2017 10:52:19 +0200 > > From: Eli Zaretskii > > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > Ping! Kenichi, any comments on this issue or the proposed patch? > > > > > Date: Mon, 20 Nov 2017 20:15:55 +0200 > > > From: Eli Zaretskii > > > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > > > > From: Andreas Schwab > > > > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > Date: Mon, 20 Nov 2017 10:48:09 +0100 > > > > > > > > > + /* Copy raw bytes in their 2-byte forms as single characters. */ > > > > > + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > > > > + { > > > > > + c = STRING_CHAR_ADVANCE (src); > > > > > > > > CHAR_BYTE8_HEAD_P and STRING_CHAR_ADVANCE are only valid for multibyte > > > > strings. I don't think it makes sense to use them for unibyte strings. > > > > > > Right you are, thanks. Updated patch below. > > > > > > diff --git a/src/coding.c b/src/coding.c > > > index d790ad0..ac55f87 100644 > > > --- a/src/coding.c > > > +++ b/src/coding.c > > > @@ -7423,10 +7423,23 @@ decode_coding (struct coding_system *coding) > > > > > > while (nbytes-- > 0) > > > { > > > - int c = *src++; > > > + int c; > > > > > > - if (c & 0x80) > > > - c = BYTE8_TO_CHAR (c); > > > + /* Copy raw bytes in their 2-byte forms from multibyte > > > + text as single characters. */ > > > + if (coding->src_multibyte > > > + && CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > > + { > > > + c = STRING_CHAR_ADVANCE (src); > > > + nbytes--; > > > + } > > > + else > > > + { > > > + c = *src++; > > > + > > > + if (c & 0x80) > > > + c = BYTE8_TO_CHAR (c); > > > + } > > > coding->charbuf[coding->charbuf_used++] = c; > > > } > > > produce_chars (coding, Qnil, 1); > > > > > > From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2017 09:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: handa@gnu.org Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.15133290039752 (code B ref 29189); Fri, 15 Dec 2017 09:10:03 +0000 Received: (at 29189) by debbugs.gnu.org; 15 Dec 2017 09:10:03 +0000 Received: from localhost ([127.0.0.1]:34596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePm0I-0002X3-Dm for submit@debbugs.gnu.org; Fri, 15 Dec 2017 04:10:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePm0G-0002Wh-OU for 29189@debbugs.gnu.org; Fri, 15 Dec 2017 04:10:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePm0A-0004TB-KC for 29189@debbugs.gnu.org; Fri, 15 Dec 2017 04:09:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePm05-0004QN-Sj; Fri, 15 Dec 2017 04:09:49 -0500 Received: from [176.228.60.248] (port=4499 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ePm05-000841-CA; Fri, 15 Dec 2017 04:09:49 -0500 Date: Fri, 15 Dec 2017 11:09:48 +0200 Message-Id: <83efnwtl0j.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83efo4uvb6.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Dec 2017 11:03:57 +0200) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <831skserz8.fsf@gnu.org> <83o9ns9hz0.fsf@gnu.org> <83k1y63kms.fsf@gnu.org> <83efo4uvb6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ping! Ping! Ping! Ping! > Date: Sat, 09 Dec 2017 11:03:57 +0200 > From: Eli Zaretskii > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > Ping! Ping! Ping! > > > Date: Fri, 01 Dec 2017 10:41:47 +0200 > > From: Eli Zaretskii > > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > Ping! Ping! I'd _really_ like to fix this for Emacs 26, but I'm > > bothered by the potential adverse consequences of making changes in > > such a central piece of code. > > > > Still hoping to get comments from Handa-san. > > > > > Date: Fri, 24 Nov 2017 10:52:19 +0200 > > > From: Eli Zaretskii > > > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > > > Ping! Kenichi, any comments on this issue or the proposed patch? > > > > > > > Date: Mon, 20 Nov 2017 20:15:55 +0200 > > > > From: Eli Zaretskii > > > > Cc: vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > > > > > > From: Andreas Schwab > > > > > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org > > > > > Date: Mon, 20 Nov 2017 10:48:09 +0100 > > > > > > > > > > > + /* Copy raw bytes in their 2-byte forms as single characters. */ > > > > > > + if (CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > > > > > + { > > > > > > + c = STRING_CHAR_ADVANCE (src); > > > > > > > > > > CHAR_BYTE8_HEAD_P and STRING_CHAR_ADVANCE are only valid for multibyte > > > > > strings. I don't think it makes sense to use them for unibyte strings. > > > > > > > > Right you are, thanks. Updated patch below. > > > > > > > > diff --git a/src/coding.c b/src/coding.c > > > > index d790ad0..ac55f87 100644 > > > > --- a/src/coding.c > > > > +++ b/src/coding.c > > > > @@ -7423,10 +7423,23 @@ decode_coding (struct coding_system *coding) > > > > > > > > while (nbytes-- > 0) > > > > { > > > > - int c = *src++; > > > > + int c; > > > > > > > > - if (c & 0x80) > > > > - c = BYTE8_TO_CHAR (c); > > > > + /* Copy raw bytes in their 2-byte forms from multibyte > > > > + text as single characters. */ > > > > + if (coding->src_multibyte > > > > + && CHAR_BYTE8_HEAD_P (*src) && nbytes > 0) > > > > + { > > > > + c = STRING_CHAR_ADVANCE (src); > > > > + nbytes--; > > > > + } > > > > + else > > > > + { > > > > + c = *src++; > > > > + > > > > + if (c & 0x80) > > > > + c = BYTE8_TO_CHAR (c); > > > > + } > > > > coding->charbuf[coding->charbuf_used++] = c; > > > > } > > > > produce_chars (coding, Qnil, 1); > > > > > > > > > > > > From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jan 2018 22:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Kenichi Handa , 29189@debbugs.gnu.org, schwab@suse.de, vianchielfaura@gmail.com Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.15151905994899 (code B ref 29189); Fri, 05 Jan 2018 22:17:02 +0000 Received: (at 29189) by debbugs.gnu.org; 5 Jan 2018 22:16:39 +0000 Received: from localhost ([127.0.0.1]:37395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXaI2-0001Gw-Qt for submit@debbugs.gnu.org; Fri, 05 Jan 2018 17:16:39 -0500 Received: from pmta21.teksavvy.com ([76.10.157.36]:49782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXaI0-0001Gj-Re for 29189@debbugs.gnu.org; Fri, 05 Jan 2018 17:16:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2HgGQCc+E9a/yyKSC1cHAEBAQQBAQoBAYM+gVqOQ48DggKZP4VFAoQxQxQBAQEBAQEBAQEDaCiFJQEEAXkFCwsNJxIUGDGKOgi0CyECiiMBAQEBBgIBJYQUghWGbYp6IAWTOJAkoUgoh1KYTzYjgVAyGggwgmiEdCOKJAEBAQ X-IPAS-Result: A2HgGQCc+E9a/yyKSC1cHAEBAQQBAQoBAYM+gVqOQ48DggKZP4VFAoQxQxQBAQEBAQEBAQEDaCiFJQEEAXkFCwsNJxIUGDGKOgi0CyECiiMBAQEBBgIBJYQUghWGbYp6IAWTOJAkoUgoh1KYTzYjgVAyGggwgmiEdCOKJAEBAQ X-IronPort-AV: E=Sophos;i="5.46,320,1511845200"; d="scan'208";a="16933156" Received: from unknown (HELO pastel.home) ([45.72.138.44]) by smtp.teksavvy.com with ESMTP; 05 Jan 2018 17:16:31 -0500 Received: by pastel.home (Postfix, from userid 20848) id E1825606C5; Fri, 5 Jan 2018 17:16:30 -0500 (EST) From: Stefan Monnier Message-ID: References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> Date: Fri, 05 Jan 2018 17:16:30 -0500 In-Reply-To: <83lgj3fy29.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Nov 2017 16:42:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I found that the alternative patch below solves the original problem > without any changes needed in files.el, and without introducing any > performance hits. Does anyone see a problem with this proposed patch? [ With Andreas's adjustment] It looks sane to me. Decoding applied to multibyte text is a rather odd situation (tho I'm surprised this problem hasn't been noticed until now). It should very much come with a few tests to verify that (decode-coding-string (string-to-multibyte (encode-coding-string X))) is just a more expensive alternative to (decode-coding-string (encode-coding-string X))). I'd also be tempted to additionally signal an error if a non-byte (i.e. a char that's neither ASCII nor eight-bit-byte) is found since "decoding" in that case is meaningless. Tho this is obviously not for the emacs-26 branch. Stefan From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2018 16:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: handa@gnu.org, 29189@debbugs.gnu.org, schwab@suse.de, vianchielfaura@gmail.com Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151525473725058 (code B ref 29189); Sat, 06 Jan 2018 16:06:01 +0000 Received: (at 29189) by debbugs.gnu.org; 6 Jan 2018 16:05:37 +0000 Received: from localhost ([127.0.0.1]:38325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqyW-0006W6-TH for submit@debbugs.gnu.org; Sat, 06 Jan 2018 11:05:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXqyW-0006Vs-6P for 29189@debbugs.gnu.org; Sat, 06 Jan 2018 11:05:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXqyQ-00044G-4J for 29189@debbugs.gnu.org; Sat, 06 Jan 2018 11:05:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXqyG-0003z2-39; Sat, 06 Jan 2018 11:05:20 -0500 Received: from [176.228.60.248] (port=2670 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eXqyE-0003b4-V9; Sat, 06 Jan 2018 11:05:19 -0500 Date: Sat, 06 Jan 2018 18:04:56 +0200 Message-Id: <83608f9dnb.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Stefan Monnier on Sat, 06 Jan 2018 10:20:38 -0500) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <83h8rz9x6k.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: handa@gnu.org, vianchielfaura@gmail.com, 29189-don@debbugs.gnu.org, schwab@suse.de > Date: Sat, 06 Jan 2018 10:20:38 -0500 > > > Situations where file names are not valid byte sequences for the > > locale's codeset are rare. > > Hmm... then I think I have misunderstood something: why doesn't this > problem show up with a valid name like "λ" ? Because "λ" will be inserted by 'ls' as a valid UTF-8 sequence of raw bytes, and will be correctly decoded. By contrast, \265 is not a valid UTF-8 sequence, so we need it to produce a string of a single raw byte. > >> I'd also be tempted to additionally signal an error if a non-byte > >> (i.e. a char that's neither ASCII nor eight-bit-byte) is found since > >> "decoding" in that case is meaningless. > > I don't think I understand. A given byte sequence can either > > represent a decodable character or be a raw byte. What third > > possibility did you have in mind? > > If the input is from a multibyte text, the input is not a byte sequence > but a character sequence, so the third possibility is to have a non-byte > in those characters. Input that is from multibyte text can include raw bytes in their multibyte representation. What is a "non-byte"? From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jan 2018 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: handa@gnu.org, 29189@debbugs.gnu.org, schwab@suse.de, vianchielfaura@gmail.com Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151533841531342 (code B ref 29189); Sun, 07 Jan 2018 15:21:02 +0000 Received: (at 29189) by debbugs.gnu.org; 7 Jan 2018 15:20:15 +0000 Received: from localhost ([127.0.0.1]:39739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYCkB-00089S-4d for submit@debbugs.gnu.org; Sun, 07 Jan 2018 10:20:15 -0500 Received: from pmta11.teksavvy.com ([76.10.157.34]:50311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYCk8-00089F-PF for 29189@debbugs.gnu.org; Sun, 07 Jan 2018 10:20:13 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2FkbQCiOVJa/yyKSC1cGwEBAQEDAQEBCQEBAYM/gVqEOIURhHqOcYICmT+FPAkChDJDFAEBAQEBAQEBAQNoKIUlAQQBI1YFCwsNDQIYDgICFBgxijwIsU2CJyECig0BAQEHAiaBD4Umhm2INYJFIAWTOZAllzwBig8oh1OYUzYjgVAyGggwgmiCUB+CBSOKTgEBAQ X-IPAS-Result: A2FkbQCiOVJa/yyKSC1cGwEBAQEDAQEBCQEBAYM/gVqEOIURhHqOcYICmT+FPAkChDJDFAEBAQEBAQEBAQNoKIUlAQQBI1YFCwsNDQIYDgICFBgxijwIsU2CJyECig0BAQEHAiaBD4Umhm2INYJFIAWTOZAllzwBig8oh1OYUzYjgVAyGggwgmiCUB+CBSOKTgEBAQ X-IronPort-AV: E=Sophos;i="5.46,326,1511845200"; d="scan'208";a="17568912" Received: from unknown (HELO pastel.home) ([45.72.138.44]) by smtp.teksavvy.com with ESMTP; 07 Jan 2018 10:20:06 -0500 Received: by pastel.home (Postfix, from userid 20848) id A46146049F; Sun, 7 Jan 2018 10:20:06 -0500 (EST) From: Stefan Monnier Message-ID: References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <83h8rz9x6k.fsf@gnu.org> <83608f9dnb.fsf@gnu.org> Date: Sun, 07 Jan 2018 10:20:06 -0500 In-Reply-To: <83608f9dnb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jan 2018 18:04:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Input that is from multibyte text can include raw bytes in their > multibyte representation. What is a "non-byte"? `=CE=BB`? `=C3=A9`? `=C2=B2`? Stefan From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jan 2018 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: handa@gnu.org, 29189@debbugs.gnu.org, schwab@suse.de, vianchielfaura@gmail.com Reply-To: Eli Zaretskii Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.151534764312506 (code B ref 29189); Sun, 07 Jan 2018 17:55:02 +0000 Received: (at 29189) by debbugs.gnu.org; 7 Jan 2018 17:54:03 +0000 Received: from localhost ([127.0.0.1]:39819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYF91-0003Fe-DD for submit@debbugs.gnu.org; Sun, 07 Jan 2018 12:54:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYF8y-0003F9-V4 for 29189@debbugs.gnu.org; Sun, 07 Jan 2018 12:54:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYF8s-00008V-Nj for 29189@debbugs.gnu.org; Sun, 07 Jan 2018 12:53:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYF8m-0008Uq-IJ; Sun, 07 Jan 2018 12:53:48 -0500 Received: from [176.228.60.248] (port=1708 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eYF8l-0000cP-VT; Sun, 07 Jan 2018 12:53:48 -0500 Date: Sun, 07 Jan 2018 19:53:33 +0200 Message-Id: <83d12l8siq.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Stefan Monnier on Sun, 07 Jan 2018 10:20:06 -0500) References: <3CE09384-E9D6-4DB9-853A-11088CF8DF80@gnu.org> <83a7ztp6p7.fsf@gnu.org> <83k1ywoq4z.fsf@gnu.org> <83h8u0on7y.fsf@gnu.org> <83po8ii56w.fsf@gnu.org> <83lgj3fy29.fsf@gnu.org> <83h8rz9x6k.fsf@gnu.org> <83608f9dnb.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: handa@gnu.org, vianchielfaura@gmail.com, 29189@debbugs.gnu.org, schwab@suse.de > Date: Sun, 07 Jan 2018 10:20:06 -0500 > > > Input that is from multibyte text can include raw bytes in their > > multibyte representation. What is a "non-byte"? > > `λ`? `é`? `²`? These are characters, so they will never end up in the code fragment that was the subject of this big, because that code deals specifically with the unprocessed tail of byte stream that could not be decoded. They will be decoded with the rest of the text before we get to the code being discussed. And even if you would like to add there assertion for "cannot happen" stuff, how would you identify such "non-bytes"? Their byte sequences depend on the original encoding, so detecting them sounds like your favorite Turing stopping problem, no? From unknown Mon Jun 23 23:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29189: 25.3; Dired does not work with binary filenames Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Sep 2018 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29189@debbugs.gnu.org Received: via spool by 29189-submit@debbugs.gnu.org id=B29189.153645309224379 (code B ref 29189); Sun, 09 Sep 2018 00:32:01 +0000 Received: (at 29189) by debbugs.gnu.org; 9 Sep 2018 00:31:32 +0000 Received: from localhost ([127.0.0.1]:50710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyndU-0006L9-4z for submit@debbugs.gnu.org; Sat, 08 Sep 2018 20:31:32 -0400 Received: from mail-io1-f49.google.com ([209.85.166.49]:42993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyndT-0006Kx-6u for 29189@debbugs.gnu.org; Sat, 08 Sep 2018 20:31:31 -0400 Received: by mail-io1-f49.google.com with SMTP id n18-v6so4293567ioa.9 for <29189@debbugs.gnu.org>; Sat, 08 Sep 2018 17:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=h0FLjYVf1m42uHfSJGrw9f2eWfXi3nzzEI4W4eS1Jp8=; b=FhWTHh+sJY/jbx7trh2E3k3kJs4+/anUfUzJk/DbmTNS+35nrJ87oqqEDH6PwLTiJN CXKXUt/5CLORbdUsMW/j6SSGb6RNTc8rUvQTUs9nlWWbhcZFCZMRy3PyIHoXch1S483L fawqj/QkQAaHwhYRjyzQM26IQkRrniS8Fdja9khmSviRf+g+4b7DBmIh9KiN8PZjgmDZ V4UYCquKznsSvU0DFl+hajVVVSxNxKGJp/QOT8B7NLD9ijytB5l8z57OIYDM2ptrTb/A 9BrQ2XDaXHawvw0Co927UG5dL7ig7YSre9cFyQpG/iQFINUsp0lEFQmNCRkRk7oXzIZs cyXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=h0FLjYVf1m42uHfSJGrw9f2eWfXi3nzzEI4W4eS1Jp8=; b=fkMKRdwrW1oAQWVVU8kzlx2Gj1ytOPaQT/+Ixxoma2fJNAo1Gpvjc92Y/iMsFOFAhV FgOAf6Zvvey2ONRHWqAj6hdX1VGLen13I3lkXudIDcoSCGcDVE3uvLMDLP2u6Oeq8oMT fnV3pnJ30CeG+Em3wZFErYjYgNGTOtAOEWRS8k9mS2JuMkL8cgQNYVtK1pHekr9PyT2a AnTPiCfi94EbOyZ3OuLaAZ124G6Gc97N/31c3x7hT/ZQapgF8x7fxRodFfqwmiuXvKcp dNNaj1uaCqCGRdMWFvu0WFCimoL6iixtNfcVPsBSqTgdszqxxzwgouaB2SmXJAfgXIp6 Q76w== X-Gm-Message-State: APzg51A+S3+H388cmJyY+f5KMf5yYpHEDr8z/UBn0VpEFflGBD61mHdG 3ubCsHHCZ+OEx4r7sSLgWCZGx8Qt+xY2M5t0gPr4PpxNNzQ= X-Google-Smtp-Source: ANB0VdZIWxeghMd13v3IIu4cTkxol6joWHTQbzyJqA5fxh3V2wOg3o06l4seQt5QIbMA8E0VvloOIYA+dvimqbKrmOY= X-Received: by 2002:a6b:ce19:: with SMTP id p25-v6mr12478403iob.243.1536453085506; Sat, 08 Sep 2018 17:31:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Allen Li Date: Sat, 8 Sep 2018 17:31:14 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I believe this bug was fixed in 26? From unknown Mon Jun 23 23:54:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Allen Li Subject: bug#29189: closed (Re: bug#29189: 25.3; Dired does not work with binary filenames) Message-ID: References: <83musrqjw3.fsf@gnu.org> X-Gnu-PR-Message: they-closed 29189 X-Gnu-PR-Package: emacs Reply-To: 29189@debbugs.gnu.org Date: Sun, 09 Sep 2018 06:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1536473582-24720-1" This is a multi-part message in MIME format... ------------=_1536473582-24720-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29189: 25.3; Dired does not work with binary filenames which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29189@debbugs.gnu.org. --=20 29189: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29189 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1536473582-24720-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29189-done) by debbugs.gnu.org; 9 Sep 2018 06:12:40 +0000 Received: from localhost ([127.0.0.1]:50796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fysxY-0006Q6-DD for submit@debbugs.gnu.org; Sun, 09 Sep 2018 02:12:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fysxW-0006Pt-Gb for 29189-done@debbugs.gnu.org; Sun, 09 Sep 2018 02:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fysxN-0008I9-5b for 29189-done@debbugs.gnu.org; Sun, 09 Sep 2018 02:12:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fysxL-0008Ey-MJ; Sun, 09 Sep 2018 02:12:25 -0400 Received: from [176.228.60.248] (port=3624 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fysxL-00076x-9B; Sun, 09 Sep 2018 02:12:23 -0400 Date: Sun, 09 Sep 2018 09:12:28 +0300 Message-Id: <83musrqjw3.fsf@gnu.org> From: Eli Zaretskii To: Allen Li In-reply-to: (message from Allen Li on Sat, 8 Sep 2018 17:31:14 -0700) Subject: Re: bug#29189: 25.3; Dired does not work with binary filenames References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29189-done Cc: 29189-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Allen Li > Date: Sat, 8 Sep 2018 17:31:14 -0700 > > I believe this bug was fixed in 26? Yes. I even sent a message to that effect at the time I pushed the changes, but I see now that I goofed with the bug address, so neither the message nor the instruction to close the bug made it to the bug tracker. Reproducing the important part below: > From: Stefan Monnier > Cc: Kenichi Handa , vianchielfaura@gmail.com, 29189@debbugs.gnu.org, schwab@suse.de > Date: Fri, 05 Jan 2018 17:16:30 -0500 > > > I found that the alternative patch below solves the original problem > > without any changes needed in files.el, and without introducing any > > performance hits. Does anyone see a problem with this proposed patch? > > [ With Andreas's adjustment] It looks sane to me. I'd still want Handa-san's review of the patch, but I went ahead and pushed it to the emacs-26 branch, and I'm closing the bug. Thanks for pointing out this blunder. ------------=_1536473582-24720-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Nov 2017 09:03:46 +0000 Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBznO-0000vi-Ge for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBznM-0000vT-Mr for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBznB-0003Ni-S4 for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBznB-0003Nc-Op for submit@debbugs.gnu.org; Tue, 07 Nov 2017 04:03:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBznA-0004XJ-IK for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 04:03:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBzn4-0003L8-Gh for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 04:03:32 -0500 Received: from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]:55929) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBzn4-0003Kh-CH for bug-gnu-emacs@gnu.org; Tue, 07 Nov 2017 04:03:26 -0500 Received: by mail-qt0-x22d.google.com with SMTP id v41so14283723qtv.12 for ; Tue, 07 Nov 2017 01:03:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=fCrDoI5LnrhC6ZNRENdWk7nW/DnvR6xE94FXYREVKxc=; b=PcFfLz/iGam64nWl4vq8p19iABjHgcztfZZ3frIADPecep4Tjhy6DLULIVvbHiHj+i 42qm29m5kWYZ0iI0deGYwjDiP0e1CIRe/uWTyAenzkKHiuEA9juFy42lNHKlVNOnAbqq se8AZgCrK3kA29C7KHJGyjC8P/xtXESLtF0ECTgs/l0PTMKxPbNu7xFTmrkJX6+GRaib SrGF4DvZClIhnAweR+7P+Q8sUoCwwFge8nbuc2NoRRIrH8dbEjdwIAg8VjuNmU+jQPU1 oZixUvYSVEH1p/Q0hRIM9hUvzpnjoIpw3T89+wDWO5HF7EObEaiIDbb0tATGsuvZkuLZ FHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fCrDoI5LnrhC6ZNRENdWk7nW/DnvR6xE94FXYREVKxc=; b=MuwspMNVDlTs3TMmf1BbbFadWVjDpLGI245qzSCDYmwysYGWKb7dvpIicPT4SHhr3X MrmUVZhsaAcXUasEw//Rsd5iUxtpPHiJNLyuYs/txkMOMFehSR6xyFSDG+6jh1nJGd19 DQ3Ht7O1+wEVwrTHeqro3XTvT4PwTQpu65JWeyFbbT+N6ERz4EQtZDW12001EtUcMmYc M6cODhx4MnnGVDWRSKiwcoYXMNiokv7/fS5MdFeSR9ernsvat78tswWHl5RGPos7bY8T hm6SL+rtGju85pFOC7Uc9sZyyuI/Iut3Exf/IbIeldnjjK1pJrbXvq6r8yJOWdM1/915 /lQw== X-Gm-Message-State: AMCzsaXfLsCYuaGQ3SX/8Bt+VZk1QEU2Xd7bwQUm9hxeT42pws5v29l9 nPWIKvi65bVRC5FtIxjnu9uQOCKQr4BFQtuzDCW9izh6 X-Google-Smtp-Source: ABhQp+RXheoIwLPYWz79KRJnuidU3zjj0G0l9oST9Mz+qLADD8FxgikSoPA4AT/VgpkCmp+VU6cirDBw9NRQmBXVg5Q= X-Received: by 10.200.47.194 with SMTP id m2mr28366565qta.81.1510045405304; Tue, 07 Nov 2017 01:03:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.19.10 with HTTP; Tue, 7 Nov 2017 01:03:24 -0800 (PST) From: Allen Li Date: Tue, 7 Nov 2017 01:03:24 -0800 Message-ID: Subject: 25.3; Dired does not work with binary filenames To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Dired does not work with binary filenames For example, create such a file with Bash: touch $'\265' 1. Navigate to the directory containing said file with Dired 2. Mark file for deletion with d 3. x Expected: File deleted Actual: (file-error Removing old name No such file or directory /home/bob/tmp/\300\265) In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix ------------=_1536473582-24720-1--