GNU bug report logs - #29187
flymake ruby and perl tests fail on rhel7.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: joaotavora <at> gmail.com (João Távora)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29187: closed (flymake ruby and perl tests fail on rhel7.4)
Date: Thu, 09 Nov 2017 20:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 09 Nov 2017 20:21:26 +0000
with message-id <87inejjj95.fsf <at> gmail.com>
and subject line Re: bug#29187: flymake ruby and perl tests fail on rhel7.4
has caused the debbugs.gnu.org bug report #29187,
regarding flymake ruby and perl tests fail on rhel7.4
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29187: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29187
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: flymake ruby and perl tests fail on rhel7.4
Date: Mon, 06 Nov 2017 18:44:38 -0500

Package: emacs
Version: 26.0.90

Hi,

The flymake tests added in 58bb346 for Ruby and Perl fail on RHEL7.4.
I guess it's again due to different versions of an external tool
reporting errors/warnings differently.

perl version: v5.16.3
ruby version: 2.0.0p648

Test perl-backend condition:
    (ert-test-failed
     ((should
       (eq 'flymake-error
           (face-at-point)))
      :form
      (eq flymake-error flymake-warning)
      :value nil))
   FAILED  4/8  perl-backend

Test ruby-backend condition:
    (ert-test-failed
     ((should
       (eq 'flymake-warning
           (face-at-point)))
      :form
      (eq flymake-warning nil)
      :value nil))
   FAILED  6/8  ruby-backend

[Message part 3 (message/rfc822, inline)]

From: joaotavora <at> gmail.com (João Távora)
To: Glenn Morris <rgm <at> gnu.org>
Cc: 29187-done <at> debbugs.gnu.org, 29187 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#29187: flymake ruby and perl tests fail on rhel7.4
Date: Thu, 09 Nov 2017 20:21:26 +0000

Glenn Morris <rgm <at> gnu.org> writes:

> João Távora wrote:
>
>> Thanks. Hmmm, trying to decide if this should be done just for the tests
>> or in the ruby backend in general. I lean towards your solution, since
>> this is appars to be a ruby bug anyway. WDYT?
>
> I'd say just for ruby.

I think you meant "just for the ruby tests", since that's what your
patch contained, and that's what I just commited in
0da08f2f8ef1946978f0974e9e8cdb87fece018c, which also contains the perl
fix.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.