GNU bug report logs - #29171
nsterm.m - unnecessary definition

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Riccardo Mottola <riccardo.mottola <at> libero.it>
Subject: bug#29171: closed (Re: bug#29171: nsterm.m - unnecessary definition)
Date: Mon, 06 Nov 2017 20:16:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29171: nsterm.m - unnecessary definition

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29171 <at> debbugs.gnu.org.

-- 
29171: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29171
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alan Third <alan <at> idiocy.org>
To: Riccardo Mottola <riccardo.mottola <at> libero.it>
Cc: 29171-done <at> debbugs.gnu.org
Subject: Re: bug#29171: nsterm.m - unnecessary definition
Date: Mon, 6 Nov 2017 20:15:06 +0000

On Mon, Nov 06, 2017 at 08:08:25PM +0000, Alan Third wrote:
> On Mon, Nov 06, 2017 at 04:13:32PM +0100, Riccardo Mottola wrote:
> > for GNUstep, the definition:
> > 
> > NSString *NSMenuDidBeginTrackingNotification;
> > 
> > at line 72 of nsterm.m is not needed, actually it results in:
> 
> We’re not defining that anywhere in our code, and certainly not on
> line 72 of nsterm.m which looks like:

Sorry, spoke too soon. The definition is in Emacs 25, but it’s already
been removed in Emacs 26.

Please try the Emacs 26 pre‐release.
-- 
Alan Third

[Message part 3 (message/rfc822, inline)]

From: Riccardo Mottola <riccardo.mottola <at> libero.it>
To: bug-gnu-emacs <at> gnu.org
Subject: nsterm.m - unnecessary definition
Date: Mon, 6 Nov 2017 16:13:32 +0100

Hi,

for GNUstep, the definition:

NSString *NSMenuDidBeginTrackingNotification;

at line 72 of nsterm.m is not needed, actually it results in:
nsterm.m:72:18: error: conflicting type qualifiers for 
'NSMenuDidBeginTrackingNotification'
 extern NSString *NSMenuDidBeginTrackingNotification;
                  ^
In file included from /System/Library/Headers/AppKit/AppKit.h:90:0,
                 from nsgui.h:34,
                 from dispextern.h:76,
                 from nsterm.h:21,
                 from nsterm.m:48:
/System/Library/Headers/AppKit/NSMenu.h:823:31: note: previous 
declaration of 'NSMenuDidBeginTrackingNotification' was here 
APPKIT_EXPORT NSString* const NSMenuDidBeginTrackingNotification;
                               ^
Makefile:381: recipe for target 'nsterm.o' failed

Thus either leave it only for MacOS (e.g. #ifndef GNUSTEP) or remove it 
totally if it is not needed on mac.

Thanks - Riccardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.