GNU bug report logs - #29168
[PATCH] gnu: linux: Fix kconfig selection.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29168 in the body.
You can then email your comments to 29168 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] gnu: linux: Fix kconfig selection.
Date: Mon,  6 Nov 2017 12:19:10 +0100

* gnu/packages/linux.scm (make-linux-libre): When cross-compiling,
  "kconfig" field is in native-inputs variable. So config is always #f
  when cross-compiling linux.
---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0ee2d60..40b3207 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -319,7 +319,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
              (setenv "EXTRA_VERSION" ,extra-version)
 
              (let ((build  (assoc-ref %standard-phases 'build))
-                   (config (assoc-ref inputs "kconfig")))
+                   (config (assoc-ref (or native-inputs inputs) "kconfig")))
 
                ;; Use a custom kernel configuration file or a default
                ;; configuration file.
@@ -368,7 +368,7 @@ It has been modified to remove all non-free binary blobs.")
 
 (define %intel-compatible-systems '("x86_64-linux" "i686-linux"))
 
-(define %linux-libre-version "4.13.11")
+(define %linux-libre-version "4.14.16")
 (define %linux-libre-hash "1x2q80s27qcp3skjhqb36xhhcnrjgsq49g7l1ggc3rb3f9cshm59")
 
 (define-public linux-libre
-- 
2.7.4

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: linux: Fix kconfig selection.
Date: Mon, 06 Nov 2017 12:35:00 +0100

> -(define %linux-libre-version "4.13.11")
> +(define %linux-libre-version "4.14.16")

^
Oops this isn't part of the patch, sorry !

Mathieu

Message #11 received at 29168 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 29168 <at> debbugs.gnu.org
Subject: Re: [bug#29168] [PATCH] gnu: linux: Fix kconfig selection.
Date: Tue, 07 Nov 2017 17:47:37 +0100

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * gnu/packages/linux.scm (make-linux-libre): When cross-compiling,
>   "kconfig" field is in native-inputs variable. So config is always #f
>   when cross-compiling linux.
> ---
>  gnu/packages/linux.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 0ee2d60..40b3207 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -319,7 +319,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
>               (setenv "EXTRA_VERSION" ,extra-version)
>  
>               (let ((build  (assoc-ref %standard-phases 'build))
> -                   (config (assoc-ref inputs "kconfig")))
> +                   (config (assoc-ref (or native-inputs inputs) "kconfig")))
>  
>                 ;; Use a custom kernel configuration file or a default
>                 ;; configuration file.

This part LGTM!

Thanks,
Ludo’.

Message #16 received at 29168-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29168-done <at> debbugs.gnu.org
Subject: Re: [bug#29168] [PATCH] gnu: linux: Fix kconfig selection.
Date: Tue, 07 Nov 2017 18:16:40 +0100

> This part LGTM!

Thanks, pushed !

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.