From unknown Mon Aug 18 02:32:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29167 <29167@debbugs.gnu.org> To: bug#29167 <29167@debbugs.gnu.org> Subject: Status: tests/ls/readdir-mountpoint-inode.sh is unstable and should require root privileges Reply-To: bug#29167 <29167@debbugs.gnu.org> Date: Mon, 18 Aug 2025 09:32:24 +0000 retitle 29167 tests/ls/readdir-mountpoint-inode.sh is unstable and should r= equire root privileges reassign 29167 coreutils submitter 29167 Thomas Deutschmann severity 29167 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 05:42:42 2017 Received: (at submit) by debbugs.gnu.org; 6 Nov 2017 10:42:42 +0000 Received: from localhost ([127.0.0.1]:53024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBerZ-000719-Sz for submit@debbugs.gnu.org; Mon, 06 Nov 2017 05:42:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBerY-00070w-8Z for submit@debbugs.gnu.org; Mon, 06 Nov 2017 05:42:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBerR-0007EN-Pq for submit@debbugs.gnu.org; Mon, 06 Nov 2017 05:42:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56298) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBerR-0007EG-MX for submit@debbugs.gnu.org; Mon, 06 Nov 2017 05:42:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBerQ-0003HA-Cb for bug-coreutils@gnu.org; Mon, 06 Nov 2017 05:42:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBerP-0007DK-5D for bug-coreutils@gnu.org; Mon, 06 Nov 2017 05:42:32 -0500 Received: from woodpecker.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:60837 helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBerO-0007Ct-V4 for bug-coreutils@gnu.org; Mon, 06 Nov 2017 05:42:31 -0500 Received: from [IPv6:2001:4dd7:beb5:0:c482:20cb:f2e1:ae80] (2001-4dd7-beb5-0-c482-20cb-f2e1-ae80.ipv6dyn.netcologne.de [IPv6:2001:4dd7:beb5:0:c482:20cb:f2e1:ae80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: whissi) by smtp.gentoo.org (Postfix) with ESMTPSA id EE9B734165D for ; Mon, 6 Nov 2017 10:42:27 +0000 (UTC) To: bug-coreutils@gnu.org From: Thomas Deutschmann Subject: tests/ls/readdir-mountpoint-inode.sh is unstable and should require root privileges Message-ID: <55bb5c11-d0e3-1889-2860-879eed1ff8e8@gentoo.org> Date: Mon, 6 Nov 2017 11:42:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) Hi, test "tests/ls/readdir-mountpoint-inode.sh" is unstable and should require root privileges because it will fail when it encounters permissions like > # df --local --out=target | sed -n '/^\/./p' > /dev > /run > /dev/shm > /sys/fs/cgroup > /boot > /usr/portage > /usr/portage/distfiles > /var/log > /backup > /srv > /srv/mysql Where "/srv" isn't readable for the user currently running the test: > # stat --format=%A /srv > drwxr-x--x > # stat --format=%A /srv/mysql/ > drwxrwx--- Test output: > +++ dirname /srv/mysql > ++ parent_dir=/srv > ++ eval 'ls -i -I '\''.?*'\'' -I '\''mysql?*'\'' -I '\''mysq[^l]*'\'' -I '\''????'\'' -I '\''mys[^q]*'\'' -I '\''???'\'' -I '\''my[^s]*'\'' -I '\''??'\'' -I '\''m[^y]*'\'' -I '\''?'\'' -I '\''[^m]*'\'' '\''/srv'\''' > ++ sed 's/ .*//' > +++ ls -i -I '.?*' -I 'mysql?*' -I 'mysq[^l]*' -I '????' -I 'mys[^q]*' -I '???' -I 'my[^s]*' -I '??' -I 'm[^y]*' -I '?' -I '[^m]*' /srv > ls: cannot open directory '/srv': Permission denied > + readdir_inode= > + test 0 = 77 > ++ timeout 1 stat --format=%i /srv/mysql > + stat_inode=96 > + case $stat_inode in > + test '' = 96 > + fail=1 Full test output: https://paste.pound-python.org/show/VRD8hTfErxNtrqkZ3Muj Tested with coreutils-8.28. Suggested patch: diff --git a/tests/ls/readdir-mountpoint-inode.sh b/tests/ls/readdir-mountpoint-inode.sh index b4ca9e46e..57ec74740 100755 --- a/tests/ls/readdir-mountpoint-inode.sh +++ b/tests/ls/readdir-mountpoint-inode.sh @@ -18,6 +18,7 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ ls +require_root_ # We use --local here so as to not activate # potentially very many remote mounts. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 07:06:53 2017 Received: (at 29167) by debbugs.gnu.org; 6 Nov 2017 12:06:53 +0000 Received: from localhost ([127.0.0.1]:53092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBgB3-0000lH-7M for submit@debbugs.gnu.org; Mon, 06 Nov 2017 07:06:53 -0500 Received: from smtp.gentoo.org ([140.211.166.183]:41700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBgAz-0000l0-R2 for 29167@debbugs.gnu.org; Mon, 06 Nov 2017 07:06:50 -0500 Received: from [IPv6:2001:4dd7:beb5:0:c482:20cb:f2e1:ae80] (2001-4dd7-beb5-0-c482-20cb-f2e1-ae80.ipv6dyn.netcologne.de [IPv6:2001:4dd7:beb5:0:c482:20cb:f2e1:ae80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: whissi) by smtp.gentoo.org (Postfix) with ESMTPSA id C8F3F34165C for <29167@debbugs.gnu.org>; Mon, 6 Nov 2017 12:06:42 +0000 (UTC) Subject: Re: bug#29167: Acknowledgement (tests/ls/readdir-mountpoint-inode.sh is unstable and should require root privileges) To: 29167@debbugs.gnu.org References: <55bb5c11-d0e3-1889-2860-879eed1ff8e8@gentoo.org> From: Thomas Deutschmann Message-ID: <9c49a949-6937-7080-592e-88e3caaed975@gentoo.org> Date: Mon, 6 Nov 2017 13:06:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29167 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, here's a better fix (from Sebastian Kühn via https://bugs.gentoo.org/353164): diff --git a/tests/ls/readdir-mountpoint-inode.sh b/tests/ls/readdir-mountpoint-inode.sh index b4ca9e46e..5270df079 100755 --- a/tests/ls/readdir-mountpoint-inode.sh +++ b/tests/ls/readdir-mountpoint-inode.sh @@ -55,7 +55,10 @@ inode_via_readdir() esac opts=$(ls_ignore_options "$base") parent_dir=$(dirname "$mount_point") - eval "ls -i $opts '$parent_dir'" | sed 's/ .*//' + ls_out=$(eval "ls -i $opts '$parent_dir'") + test $? -eq 0 || \ + skip_ "'$parent_dir' is not readable for current user" + echo $ls_out | sed 's/ .*//' } while read dir; do -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 07 00:37:31 2017 Received: (at 29167-done) by debbugs.gnu.org; 7 Nov 2017 05:37:31 +0000 Received: from localhost ([127.0.0.1]:55057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBwZn-0004J1-8Y for submit@debbugs.gnu.org; Tue, 07 Nov 2017 00:37:31 -0500 Received: from mail.magicbluesmoke.com ([82.195.144.49]:48328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBwZk-0004Ir-Qu for 29167-done@debbugs.gnu.org; Tue, 07 Nov 2017 00:37:29 -0500 Received: from localhost.localdomain (c-73-158-116-184.hsd1.ca.comcast.net [73.158.116.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 13191114; Tue, 7 Nov 2017 05:37:26 +0000 (GMT) Subject: Re: bug#29167: Acknowledgement (tests/ls/readdir-mountpoint-inode.sh is unstable and should require root privileges) To: Thomas Deutschmann , 29167-done@debbugs.gnu.org References: <55bb5c11-d0e3-1889-2860-879eed1ff8e8@gentoo.org> <9c49a949-6937-7080-592e-88e3caaed975@gentoo.org> From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <9793b374-0b21-eaaa-46c9-f276bb825c7f@draigBrady.com> Date: Mon, 6 Nov 2017 21:37:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <9c49a949-6937-7080-592e-88e3caaed975@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29167-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 06/11/17 04:06, Thomas Deutschmann wrote: > Hi, > > here's a better fix (from Sebastian Kühn via > https://bugs.gentoo.org/353164): > > diff --git a/tests/ls/readdir-mountpoint-inode.sh > b/tests/ls/readdir-mountpoint-inode.sh > index b4ca9e46e..5270df079 100755 > --- a/tests/ls/readdir-mountpoint-inode.sh > +++ b/tests/ls/readdir-mountpoint-inode.sh > @@ -55,7 +55,10 @@ inode_via_readdir() > esac > opts=$(ls_ignore_options "$base") > parent_dir=$(dirname "$mount_point") > - eval "ls -i $opts '$parent_dir'" | sed 's/ .*//' > + ls_out=$(eval "ls -i $opts '$parent_dir'") > + test $? -eq 0 || \ > + skip_ "'$parent_dir' is not readable for current user" > + echo $ls_out | sed 's/ .*//' > } > > while read dir; do Pushed at: https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.28-29-gaebefc2 Marking this as done. thanks, Pádraig From unknown Mon Aug 18 02:32:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 05 Dec 2017 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator