From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 01:57:46 2017 Received: (at submit) by debbugs.gnu.org; 6 Nov 2017 06:57:46 +0000 Received: from localhost ([127.0.0.1]:52914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBbLs-0001Uv-Ch for submit@debbugs.gnu.org; Mon, 06 Nov 2017 01:57:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBbLq-0001Uf-IQ for submit@debbugs.gnu.org; Mon, 06 Nov 2017 01:57:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBbLk-0000JC-6f for submit@debbugs.gnu.org; Mon, 06 Nov 2017 01:57:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBbLk-0000Ih-35 for submit@debbugs.gnu.org; Mon, 06 Nov 2017 01:57:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBbLi-0006MW-19 for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 01:57:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBbLd-0008Uv-89 for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 01:57:34 -0500 Received: from mail-qt0-x229.google.com ([2607:f8b0:400d:c0d::229]:51869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBbLd-0008Tu-2E for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 01:57:29 -0500 Received: by mail-qt0-x229.google.com with SMTP id h4so9708106qtk.8 for ; Sun, 05 Nov 2017 22:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=permabit.com; s=google; h=from:to:subject:date:message-id:user-agent:mime-version; bh=ywykzxbFSZhlRYS5WDdfalCdVmxVDhe1yujfuPE7KO0=; b=VK4BBUnJhZr6Af+e84aYLjYpZob+ECwPDNlWqYh5PoT+YamqM5OAzPVcnm/iqXiNBA STgxICb080YkDxPj7+oyCBWBcMruZbXDf7eFRMjSq+3pX6d6UAOLy6nMlQqDUjLmxhHE bNZdRZY3nM6h61DGkJSrAENv/mcU5C/5oYjYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=ywykzxbFSZhlRYS5WDdfalCdVmxVDhe1yujfuPE7KO0=; b=tHW2HqdAWAmpE3jof2l3Ru7bIVqY45405cQykVFvYVXqH8m8RYd3fjFHUQ9eUi5Dh+ ADw7Bi5mU2sLpkn16XgWXmuK5WE0iozr3o5lJwPQ9sIxFSjPwprrZbIvqeaumi1wdYLB zkznDu8gcbAfMYbYbOFpscu+p789uZ3q0ITm5XahMP64F77Y65MbgBhF9a8GnkA6CJ9Z tCMOynRiKRpITuJUPcjQ1uzNh2TZ/6im0aYNoqFEo7M4yC9kvEfL0JbDrl0szsCiny9U W+Rz7lqXZzxC0JVbYvdmk5UMmhu4wQrTekIiZmX+VQR2fEKeyYLmCoXioXVyHv0BbC0g 7Inw== X-Gm-Message-State: AMCzsaXu1pYK2XE/+7iyvCPMgOx/TMOcyEvXZb8xaIapHu8jHzzEBjVT 182AcpIQ7cZdoaE9ZwoX+WCP/w== X-Google-Smtp-Source: ABhQp+RertEOhh9G4sEOFDeNpYNLfEPnpQDPomqaw9uyt3pDG6DYBFG31MDLGKvKvA/55BFEFtW1Fw== X-Received: by 10.200.56.83 with SMTP id r19mr20718656qtb.293.1509951448011; Sun, 05 Nov 2017 22:57:28 -0800 (PST) Received: from just-testing.permabit.com (96-86-89-185-static.hfc.comcastbusiness.net. [96.86.89.185]) by smtp.gmail.com with ESMTPSA id n50sm8140003qtc.44.2017.11.05.22.57.26 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 05 Nov 2017 22:57:26 -0800 (PST) From: Ken Raeburn To: bug-gnu-emacs@gnu.org Subject: 26.0.90; can't use some code byte-compiled under emacs 24 Date: Mon, 06 Nov 2017 01:57:25 -0500 Message-ID: <6eh8u7x5be.fsf@just-testing.permabit.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Create a file with the contents: (require 'cl) (defun* foobar (init-fun test-fun cleanup-fun &optional &key (test #'eql) (size 65)) "Blah blah blah" (list 'x init-fun test-fun cleanup-fun test size)) Use Emacs 24.3 to byte-compile the file. Start the Emacs 26 pretest, and load the .elc file. Type into the scratch buffer: (foobar 1 2 3 :test 4) And use eval-last-sexp to try to evaluate it. You should get a list back. I get an invalid-function error instead. With the debugger enabled, I see: Debugger entered--Lisp error: (invalid-function #f(compiled-function (init-fun test-fun cleanup-fun &optional &rest --cl-rest--) "Blah blah blah" #)) foobar(1 2 3 :test 4) eval((foobar 1 2 3 :test 4) nil) elisp--eval-last-sexp(nil) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) call-interactively(eval-last-sexp nil nil) command-execute(eval-last-sexp) It appears that the eval.c code of 26.0.90 doesn't like to see &optional and &rest together in the argument list of a compiled function. But in this case, the byte compiler from version 24 does generate that. In version 25, only &rest is put into the list. In GNU Emacs 26.0.90 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2017-10-27 built on just-testing.permabit.com Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 System Description: Ubuntu 14.04.4 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Loading /tmp/foo.elc...done Entering debugger... Back to top level Configured using: 'configure --prefix=/u1/ken/install/emacs-26.0.90 --with-x-toolkit=lucid --enable-checking --without-sound --without-gif' Configured features: XAW3D XPM JPEG TIFF PNG RSVG DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 Important settings: locale-coding-system: nil Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu cl-print byte-opt bytecomp byte-compile cconv debug cl gv cl-loaddefs cl-lib elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 98378 10227) (symbols 48 20669 1) (miscs 40 45 197) (strings 32 29669 1021) (string-bytes 1 765521) (vectors 16 14315) (vector-slots 8 495072 6314) (floats 8 53 146) (intervals 56 314 138) (buffers 992 12) (heap 1024 32780 1041)) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 07:44:58 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 12:44:58 +0000 Received: from localhost ([127.0.0.1]:53118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBglt-0003Zq-T4 for submit@debbugs.gnu.org; Mon, 06 Nov 2017 07:44:58 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:44199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBgls-0003ZW-56; Mon, 06 Nov 2017 07:44:56 -0500 Received: by mail-io0-f169.google.com with SMTP id m16so15552197iod.1; Mon, 06 Nov 2017 04:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Zj7Hezz8zgwiOhZQDOYfrtDhOGIJgc2Rh+JvkABAa8U=; b=myZSQZ2Gh1mRdddaK1qRqjyP15scDN2yYaYb8kKGY5sEKuV8n+kSUWGYw8xNZYiLU4 9p+1VQ5w46MNKl49ahjHm/wiYK930oEeSOi0loBRbQeATr0noaP8P7YeZKo2iWf9X1vR nvSxSVkWGBwBIRZeAABLzp1d4rkXRTLg9vepTjqOwB+CK84zrrcQ8l4W3rK2rXnNi7uR Ap0FZKIhJAy6kXC5vX7xHGFP1D0A6hBjnr6RHY/D7Pw6ZGz2REXu1FUoeSryCHeHiBwW OY7FY4QC0QUaXUdX8rGsiAPOMA6vIvDYm+x/CmT1v+/a+d0mvCfbmsiTCtyRwE52Uekt Wrvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Zj7Hezz8zgwiOhZQDOYfrtDhOGIJgc2Rh+JvkABAa8U=; b=uMAcbKarovA/LD+Gx/7JylUW7gOW2nTHGLzviTn3q0iOEVzbo3eu7R8jMHVUZKskHY /a/15TTQyRzcCgvYTeGLKPzDFw2v2eAK3J2kpZOljKEiqaTnqAyjr7Y1cIRl0z/KNvZO 670ulC+F12hdlruVF0V6hgfo0T8Z9fe3Xk07Hcu/VEDk/fJhqE/G2yFpWYOntvSP49SX +dYcCSmEMgdCTSdYpk0KZQsQTiF1oYoyqSUZjiDR4C25BGYGcfzuUC1Uuzgd2BRg/Xxz dtChHxLiTZJ7bq8WdAtRRK5ocZHipqbPAf9Khy6ct5rxpG3rxNgCtdefPLvXplkrzM3y ga/w== X-Gm-Message-State: AJaThX7gcSJIxSUj082H864Q2LUTsAXywlbQanwYvVu0g/Kn+NaUtuT6 /DVYmlMGcddPki9NkkcbisnJ2A== X-Google-Smtp-Source: ABhQp+SueHSJeyF1ECirfSwRqdxzicsXHTR1DTK944A3cBtyIKyfDON8tPKnMrz3Lplp74llGlHpQQ== X-Received: by 10.107.53.42 with SMTP id c42mr19644209ioa.254.1509972290037; Mon, 06 Nov 2017 04:44:50 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q191sm6130998itb.1.2017.11.06.04.44.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Nov 2017 04:44:48 -0800 (PST) From: Noam Postavsky To: Ken Raeburn Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> Date: Mon, 06 Nov 2017 07:44:47 -0500 In-Reply-To: <6eh8u7x5be.fsf@just-testing.permabit.com> (Ken Raeburn's message of "Mon, 06 Nov 2017 01:57:25 -0500") Message-ID: <87375r7f0g.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 29165 Cc: Philipp Stephani , 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 29165 + notabug quit Ken Raeburn writes: > (defun* foobar (init-fun test-fun cleanup-fun > &optional &key > Use Emacs 24.3 to byte-compile the file. > > Start the Emacs 26 pretest, and load the .elc file. > Debugger entered--Lisp error: (invalid-function #f(compiled-function (init-fun test-fun cleanup-fun &optional &rest --cl-rest--) "Blah blah blah" > It appears that the eval.c code of 26.0.90 doesn't like to see &optional > and &rest together in the argument list of a compiled function. Yes, see Bug#24912 and Bug#24913. > But in this case, the byte compiler from version 24 does generate > that. In version 25, only &rest is put into the list. It's not the byte compiler specifically, the defun* macro (aka cl-defun) expands &key into &rest, so the expansion has &optional &rest. At any rate, using &optional is meaningless there, so the solution is just to remove it. We should perhaps put something about throwing error on '&option &rest' into NEWS though. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 09:24:16 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 14:24:16 +0000 Received: from localhost ([127.0.0.1]:53174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBiK0-0007xM-Bt for submit@debbugs.gnu.org; Mon, 06 Nov 2017 09:24:16 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBiJy-0007x8-KW for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 09:24:15 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vA6EO7X3006435 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2017 14:24:08 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA6EO6Vq014513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2017 14:24:07 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vA6EO5Jm023610; Mon, 6 Nov 2017 14:24:06 GMT MIME-Version: 1.0 Message-ID: <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> Date: Mon, 6 Nov 2017 06:24:04 -0800 (PST) From: Drew Adams To: Noam Postavsky , Ken Raeburn Subject: RE: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> In-Reply-To: <87375r7f0g.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4600.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: 29165 Cc: Philipp Stephani , 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) > It's not the byte compiler specifically, the defun* macro (aka cl-defun) > expands &key into &rest, so the expansion has &optional &rest. At any > rate, using &optional is meaningless there, so the solution is just to > remove it. >=20 > We should perhaps put something about throwing error on '&option &rest' > into NEWS though. I don't understand. In Common Lisp it is perfectly correct to use both &optional and &rest. If Emacs's emulation of CL's `defun' is defective in this regard, is that not a bug? https://www.cs.cmu.edu/Groups/AI/html/cltl/clm/node64.html Or are you saying that there was a bug in Emacs 24's handling of the CL `defun' emulation, where it expanded &key into &rest, producing multiple &optional or &rest, and that now this has been fixed - hence Emacs 24 byte-code does not work in Emacs 26? If you do add something to NEWS, please make clear just what the problem is/was. Does Emacs now correctly emulate CL `defun' wrt &* keywords? Is it an error to repeat &optional or &rest? If not, what is the behavior in that case? Whatever the explanation is, please make it very clear in NEWS. Thx. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 09:35:39 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 14:35:39 +0000 Received: from localhost ([127.0.0.1]:53180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBiV1-0008EK-Dk for submit@debbugs.gnu.org; Mon, 06 Nov 2017 09:35:39 -0500 Received: from mail-wr0-f180.google.com ([209.85.128.180]:47662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBiUz-0008E4-PP for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 09:35:38 -0500 Received: by mail-wr0-f180.google.com with SMTP id k61so2967519wrc.4 for <29165@debbugs.gnu.org>; Mon, 06 Nov 2017 06:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+B5eaK3onRChWOFZYYXB2JTYDx2Rftn9H4p/B/lpPCo=; b=eQxsnORUoYCuJAwxDu7/OPln4zgkaywEM/XrgRgdjj6gyJsuHbSYEmyYfilrQSDrVn nXhqtBAX9gL+BDXO5a/6Xi6GyHlae2JOk0OcuJBKGrQIly6jDnGOPB+oFhG1PiXB91Fn YjRa1BQXi4cgiWzEhZfy/fZ6Q9wB6/i9zw+0Am/UeWMFCB3sAkXON8R3ntRmRv8GeVPi YfT7ZfYLRw/PDkPMKfUIwR40BPDcl1cL1XRIiY9vZNkQ5BgV3p6DXD3O3T5ZLeF2mRIL /+TK1DhChQY8GvIciKEwEEeK4C3y8x1H6Xb5bwGjsKVj8GACj3agzNLkPu0WalKEXIxr E3tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+B5eaK3onRChWOFZYYXB2JTYDx2Rftn9H4p/B/lpPCo=; b=Eo3R4t9yuga8CpbXDgNh4DLTNO91zZRMovrJjlwBm2J4eC0C085EdQobnROOBUyec5 7T5xI3zAfbIbAGRoo6rpsSVxeUI5c+z31FIBaUJ+av90cO767MvUkV0MNeOkP/qaO1AG lSluncgonHWN/FwRfU43b7CuQ+VZFqaGP2jw/6BcNfDKfxE24hojTqiaHc4YqcOfP3ex PINOqfn3+f6grQeSx8uQPkGBI5vKrcsgSMm403XzF9QnoCLxTBxUdP48frNX4SZpdvtL c9Fzx7rkpxy0mXQz0y1VTISmPH8W981rFYn1RiaAl1bP4jlV4VMyf+hN2MH16xHV2Hi9 Rd4Q== X-Gm-Message-State: AMCzsaXz8HmJV+Ji+rGBzhwzQ7td8sTjcswpQzTwLKeKX7G9qabhhz6v ehYd12J0+MubDtbbc47OIg6uDIpGfkREdYOFiic= X-Google-Smtp-Source: ABhQp+TrU2g8aPr398z5MF76e86+u0wUYQpJStKLHV/v0DE1aPg7DoLzTVRBw4uxgMjt3XNDdNLij/B+Kzk4mX9pQxA= X-Received: by 10.223.189.13 with SMTP id j13mr13613948wrh.94.1509978931423; Mon, 06 Nov 2017 06:35:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.146.227 with HTTP; Mon, 6 Nov 2017 06:35:31 -0800 (PST) In-Reply-To: <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> From: Noam Postavsky Date: Mon, 6 Nov 2017 09:35:31 -0500 X-Google-Sender-Auth: jbWQkHpTUjpkqtU6pTflEqHTNNQ Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , Philipp Stephani , 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On Mon, Nov 6, 2017 at 9:24 AM, Drew Adams wrote: >> We should perhaps put something about throwing error on '&option &rest' >> into NEWS though. > > I don't understand. In Common Lisp it is perfectly correct > to use both &optional and &rest. What's rejected is (&optional &rest other-vars), whereas (&optional var1 &rest other-vars) is okay. Does CL accept the first form (and if yes, what does it mean)? I couldn't tell from the page you linked to. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 09:41:09 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 14:41:09 +0000 Received: from localhost ([127.0.0.1]:53184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBiaL-0008MN-1U for submit@debbugs.gnu.org; Mon, 06 Nov 2017 09:41:09 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBiaJ-0008MB-Sk for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 09:41:08 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vA6Ef10b027374 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2017 14:41:01 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA6Ef031009456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2017 14:41:01 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vA6Eexle000940; Mon, 6 Nov 2017 14:41:00 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 6 Nov 2017 06:40:58 -0800 (PST) From: Drew Adams To: Noam Postavsky Subject: RE: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4600.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , Philipp Stephani , 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) > >> We should perhaps put something about throwing error on '&option &rest= ' > >> into NEWS though. > > > > I don't understand. In Common Lisp it is perfectly correct > > to use both &optional and &rest. >=20 > What's rejected is (&optional &rest other-vars), whereas (&optional > var1 &rest other-vars) is okay. Does CL accept the first form (and if > yes, what does it mean)? I couldn't tell from the page you linked to. CL accepts a single variable after &rest. And there must be a variable after &optional. (&optional foo &rest bar) is OK. (&optional &rest foo) is not OK. (&optional foo &rest bar toto titi) is not OK. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 11:08:06 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 16:08:06 +0000 Received: from localhost ([127.0.0.1]:54418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBjwU-0002Jn-2E for submit@debbugs.gnu.org; Mon, 06 Nov 2017 11:08:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBjwS-0002JK-VM for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 11:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBjwI-00023D-Mb for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 11:07:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBjwI-000233-Jr; Mon, 06 Nov 2017 11:07:54 -0500 Received: from [176.228.60.248] (port=2910 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eBjwI-0004YZ-1J; Mon, 06 Nov 2017 11:07:54 -0500 Date: Mon, 06 Nov 2017 18:08:00 +0200 Message-Id: <83wp33s84f.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87375r7f0g.fsf@users.sourceforge.net> (message from Noam Postavsky on Mon, 06 Nov 2017 07:44:47 -0500) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29165 Cc: raeburn@permabit.com, p.stephani2@gmail.com, 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Mon, 06 Nov 2017 07:44:47 -0500 > Cc: Philipp Stephani , 29165@debbugs.gnu.org > > We should perhaps put something about throwing error on '&option &rest' > into NEWS though. Please do, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 12:20:40 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 17:20:40 +0000 Received: from localhost ([127.0.0.1]:54446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBl4h-00045P-HY for submit@debbugs.gnu.org; Mon, 06 Nov 2017 12:20:39 -0500 Received: from mail-qk0-f174.google.com ([209.85.220.174]:47789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBl4g-000455-NU for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 12:20:38 -0500 Received: by mail-qk0-f174.google.com with SMTP id m189so11868462qke.4 for <29165@debbugs.gnu.org>; Mon, 06 Nov 2017 09:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XPAnLK2C5CIvC1bO13+LXllSbEaqz0afi3AZPuwf+GE=; b=WhVchnj8Tod0CBb3cNeP2JCZMVAZuaL5DuZzrcBPFu4mJ4G1YdXxryO2OK9G+AzuvR +9kwzgx9LSI/elgx9C8J+papXGT7nsVp7lJdQ1JpMoXgVxSPGVqsMP63n7zeuUzpX1P0 lWkHVIJSwgq8Zhopq0aKlmWfN7QW6XssZxltzkjdkyYp2ICpE0USIei2NZ/36dKvFQ7+ +QOqgO+uyPO7Da7F/m2AyzLB1IEXtGCWxMNJfGl9cnDDXQbfW8rsAS5q3V0KLxLcaRzy +pNYG52DVA+kmAgqo9+vUpaoRziMq3bnNHidaJUlgTqOLcNIS1VQSzumvSCvdNPbKFyb qLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XPAnLK2C5CIvC1bO13+LXllSbEaqz0afi3AZPuwf+GE=; b=PcrwpBMzNwq6mNoWhGfADcvFqTM325t85RwG1VZA16Dsg4h+Rmbhm3HggOOHeuxjPQ j0d4BdRngs8m4/c7FHl4gf/jD5AhJSYvcb/kR2PxIrna6zmGgWYjqrNp8Iu/Q3bx52UP TCx9op2whk4pQVpY9+oLguvWiY59FeYH2Y99XCdZGqwcSpCgwrtRkD/VCw4myzxMIk2C g84AqZOWnsqPbHcW3VAlnh1IHTXa4N+rd6HLbL4ThVlPMCeYIQ5YFsaENfypUV254Exq g/Ne2WTxoG8CyGov7UFrbEmYxqxY9E6Wc7UiPEQBvmoAY7ZeQqJzDlZVSv0RSZtujNKt jJ/w== X-Gm-Message-State: AJaThX6ugj40pPf3JUPqlT7hb+RpUxeL8vq6fDmd5lZ7A2aDtj4P/GuT X4iRz+kjR5G/oKuQw0OGrOjHyOvbmlse0KOmIO8= X-Google-Smtp-Source: ABhQp+S+jtinPSh/2myMm0+s3YFjkr9H0EunBU5L7TzRTkqr2zz5gaP7BBm2Ggjbwr3cPs7uQl7/60/tqIvI1WraHRg= X-Received: by 10.55.90.66 with SMTP id o63mr5432346qkb.74.1509988833053; Mon, 06 Nov 2017 09:20:33 -0800 (PST) MIME-Version: 1.0 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> In-Reply-To: From: Philipp Stephani Date: Mon, 06 Nov 2017 17:20:22 +0000 Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Drew Adams Content-Type: multipart/alternative; boundary="001a114c8da6024f71055d53ac13" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , 29165@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --001a114c8da6024f71055d53ac13 Content-Type: text/plain; charset="UTF-8" Drew Adams schrieb am Mo., 6. Nov. 2017 um 15:41 Uhr: > > >> We should perhaps put something about throwing error on '&option > &rest' > > >> into NEWS though. > > > > > > I don't understand. In Common Lisp it is perfectly correct > > > to use both &optional and &rest. > > > > What's rejected is (&optional &rest other-vars), whereas (&optional > > var1 &rest other-vars) is okay. Does CL accept the first form (and if > > yes, what does it mean)? I couldn't tell from the page you linked to. > > CL accepts a single variable after &rest. And there must be > a variable after &optional. (&optional foo &rest bar) is OK. > > (&optional &rest foo) is not OK. > (&optional foo &rest bar toto titi) is not OK. > That should match the current behavior in Emacs Lisp now. --001a114c8da6024f71055d53ac13 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Drew A= dams <drew.adams@oracle.com= > schrieb am Mo., 6. Nov. 2017 um 15:41=C2=A0Uhr:
> >> We should perhaps put something about throw= ing error on '&option &rest'
> >> into NEWS though.
> >
> > I don't understand.=C2=A0 In Common Lisp it is perfectly corr= ect
> > to use both &optional and &rest.
>
> What's rejected is (&optional &rest other-vars), whereas (= &optional
> var1 &rest other-vars) is okay. Does CL accept the first form (and= if
> yes, what does it mean)? I couldn't tell from the page you linked = to.

CL accepts a single variable after &rest. And there must be
a variable after &optional.=C2=A0 (&optional foo &rest bar) is = OK.

(&optional &rest foo) is not OK.
(&optional foo &rest bar toto titi) is not OK.

That should match the current behavior in Emacs Lisp now.= =C2=A0
--001a114c8da6024f71055d53ac13-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 12:25:34 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 17:25:34 +0000 Received: from localhost ([127.0.0.1]:54454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBl9R-0004DU-Rv for submit@debbugs.gnu.org; Mon, 06 Nov 2017 12:25:34 -0500 Received: from mail-qt0-f182.google.com ([209.85.216.182]:49290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBl9P-0004DH-Qc for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 12:25:32 -0500 Received: by mail-qt0-f182.google.com with SMTP id k31so11872454qta.6 for <29165@debbugs.gnu.org>; Mon, 06 Nov 2017 09:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=permabit.com; s=google; h=subject:mime-version:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KqQc5cGe8WvJhSHeRllt3iXDO0My+ySu8pcdxYRFVmU=; b=cyHOHv5ZkBID/CItq4wBrl9xUr/ksgNloZIj3+QzW55qHVUTuB9ldvj3sVaoRlmG8b BsYcwi0XCp7hHIgqqb0wFoLxPpbr+sHknwZpfyJkfvencLJ1HNQJJu7xz3/3Iw+Zuc8R TAuF1bRf6onVG8yKLUyCaPcK/xN4TYK8d0Qd0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KqQc5cGe8WvJhSHeRllt3iXDO0My+ySu8pcdxYRFVmU=; b=E3Z+9mnfp9FyvU0Wo1o/pijxi/dDGox1r0Twf+1+FabVXOYNhKlfyERjT9CrtxnN1m wvZcqRKC2/SRHHyOtTrrrb3ZUZDP5tRwGd4bm22zUV69tfq3N/rDFPo/syEQsp1CAvFV rcRB8t4JZofNbuG9+ivyoFrh5OWCQGOiaeJNw0O+QdmN1vaZ1dZ6f2bOebBZI+ufQQv+ 3/yQzs+QC1WyEPYSFmXIb1FDpr8w/YO1Av7MXpi5Ji/9e+dfWDL8qXmYg1J6yl/R0qXv 0d0PXUT6y5I43EYgeH8bXvKWne4FHkQj9FXyoHPslqVAgfn+Ez8epQZPumLVK6RafaeA ZUDw== X-Gm-Message-State: AMCzsaWOr4vxZnvOmaUSuI2zJACLnmAVRsdJybN+Eox68FXqt1a1kTJ6 IHXhPO34/XO8wyOCTyHQlyEdaw== X-Google-Smtp-Source: ABhQp+T8B20H65iE6fw+cP2ITpfWGTcW+Wxic7zEjncB2MZVp2W3UfDL6iwrJ0kFWmnw1jbMv722bA== X-Received: by 10.200.46.114 with SMTP id s47mr23591359qta.165.1509989126445; Mon, 06 Nov 2017 09:25:26 -0800 (PST) Received: from [192.168.23.135] (c-73-253-167-23.hsd1.ma.comcast.net. [73.253.167.23]) by smtp.gmail.com with ESMTPSA id z13sm8968565qtb.97.2017.11.06.09.25.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 09:25:25 -0800 (PST) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=utf-8 From: Ken Raeburn X-Priority: 3 In-Reply-To: Date: Mon, 6 Nov 2017 12:25:24 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> To: Drew Adams X-Mailer: Apple Mail (2.3273) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 29165 Cc: Philipp Stephani , 29165@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On Nov 6, 2017, at 09:40, Drew Adams wrote: >>>> We should perhaps put something about throwing error on '&option = &rest' >>>> into NEWS though. >>>=20 >>> I don't understand. In Common Lisp it is perfectly correct >>> to use both &optional and &rest. >>=20 >> What's rejected is (&optional &rest other-vars), whereas (&optional >> var1 &rest other-vars) is okay. Does CL accept the first form (and if >> yes, what does it mean)? I couldn't tell from the page you linked to. >=20 > CL accepts a single variable after &rest. And there must be > a variable after &optional. (&optional foo &rest bar) is OK. >=20 > (&optional &rest foo) is not OK. > (&optional foo &rest bar toto titi) is not OK. Is this CL in general or a particular CL implementation? The web page = you sent the URL for earlier reads like a specification, and from its = use of =E2=80=9C*=E2=80=9D looks to me like it allows the (admittedly = useless) form of &optional with no variables. Ken= From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 13:10:34 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 18:10:34 +0000 Received: from localhost ([127.0.0.1]:54479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBlqz-0005Lu-WD for submit@debbugs.gnu.org; Mon, 06 Nov 2017 13:10:34 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:49816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBlqy-0005Lm-Us for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 13:10:33 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yW0wR60rWz1qsD2; Mon, 6 Nov 2017 19:10:31 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yW0wR5Hg9z1s37T; Mon, 6 Nov 2017 19:10:31 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id e0DbzH1J8gkG; Mon, 6 Nov 2017 19:10:30 +0100 (CET) X-Auth-Info: jDs5VJEAaLJIBijpxL6kAQcSmlJHNoSsXpgnIZe4mhhgagMeO3BbRz6lE3JdzYe0 Received: from localhost (ppp-188-174-158-58.dynamic.mnet-online.de [188.174.158.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 6 Nov 2017 19:10:30 +0100 (CET) Received: by localhost (Postfix, from userid 1000) id 421B62C132C; Mon, 6 Nov 2017 19:10:30 +0100 (CET) From: Andreas Schwab To: Ken Raeburn Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> X-Yow: .. ich bin in einem dusenjet ins jahr 53 vor chr... ich lande im antiken Rom... einige gladiatoren spielen scrabble... ich rieche PIZZA... Date: Mon, 06 Nov 2017 19:10:30 +0100 In-Reply-To: <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> (Ken Raeburn's message of "Mon, 6 Nov 2017 12:25:24 -0500") Message-ID: <87efpb46sp.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29165 Cc: Philipp Stephani , 29165@debbugs.gnu.org, Drew Adams , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Nov 06 2017, Ken Raeburn wrote: > On Nov 6, 2017, at 09:40, Drew Adams wrote: > >>>>> We should perhaps put something about throwing error on '&option &rest' >>>>> into NEWS though. >>>> >>>> I don't understand. In Common Lisp it is perfectly correct >>>> to use both &optional and &rest. >>> >>> What's rejected is (&optional &rest other-vars), whereas (&optional >>> var1 &rest other-vars) is okay. Does CL accept the first form (and if >>> yes, what does it mean)? I couldn't tell from the page you linked to. >> >> CL accepts a single variable after &rest. And there must be >> a variable after &optional. (&optional foo &rest bar) is OK. >> >> (&optional &rest foo) is not OK. >> (&optional foo &rest bar toto titi) is not OK. > > Is this CL in general or a particular CL implementation? The web page you sent the URL for earlier reads like a specification, and from its use of “*” looks to me like it allows the (admittedly useless) form of &optional with no variables. clisp accepts it. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 14:10:37 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 19:10:37 +0000 Received: from localhost ([127.0.0.1]:54555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBmn7-0000ag-6z for submit@debbugs.gnu.org; Mon, 06 Nov 2017 14:10:37 -0500 Received: from mail-qk0-f176.google.com ([209.85.220.176]:45774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBmn5-0000aT-6W for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 14:10:35 -0500 Received: by mail-qk0-f176.google.com with SMTP id f199so12301088qke.2 for <29165@debbugs.gnu.org>; Mon, 06 Nov 2017 11:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=permabit.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=ScZkrFRlWLzKCDnwiXGdfIwfacdjS8GqJdRB+DNl9W4=; b=e+05dtvmwIYMv9SicB1H6PZI1t/Gwpc5Bzh6Wc+VKtDCGSK/RikeRiskBVBmwYFdDz oEeR8DXMd0fRsZdW0mni1PAtq8C/LLNNOfjuLUhKc3vzFa8XJX7tqeIFQbhOsUgGr0xV WzGyTBfxgd4hL04RpKVQbpU/wXsOfPNl3o81Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=ScZkrFRlWLzKCDnwiXGdfIwfacdjS8GqJdRB+DNl9W4=; b=YX0SP4kjmw62A4/BQHzK5k1Zm/lBpfXGZ0ne7WJqS09C+V4mI/EUeL2ar5ZA+0wNB6 T3kQxQFuUTdRJYGXfdcHOLboMgoO0AoJ+9PfxyuroPtKWGxIplCIXmwOxPwjuXLq3XYt 8p9S6l2S/3I9jzr4vEqvqcg1mAOhK5lEEs8V4hZt/3nr0OAqgREbZlRtL6QBdMzpiyQM KH9BkBul7Mt5hM/MIdhc+xUtFc4mlD2UgsC2cG08KJRG+G9hg7EWQN5gnJak6ErglXmD TjyttsK/OxhkLlfXJGdX5Vs+qnBxA2Ta7bSAukhgmr61db7KEL7U3WBdpNK68v2XKm8E 57gQ== X-Gm-Message-State: AJaThX7QU4n0H0wRNe0xMFpO33x4Lij24pGbpaHRuesLupgFNWoFW7pM zDzRnFlG3dJe8kU1hT7r+yzYNA== X-Google-Smtp-Source: ABhQp+SpvbeGB9NnYvZsQiCX0Qkf4iaFCVAUWHl228y7oRHD1zuYjXDxMI5jdWLWc2y3Rv09WgNREg== X-Received: by 10.55.74.138 with SMTP id x132mr21940749qka.239.1509995429627; Mon, 06 Nov 2017 11:10:29 -0800 (PST) Received: from [192.168.23.135] (c-73-253-167-23.hsd1.ma.comcast.net. [73.253.167.23]) by smtp.gmail.com with ESMTPSA id l20sm9046412qtb.27.2017.11.06.11.10.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 11:10:28 -0800 (PST) Content-Type: multipart/alternative; boundary="Apple-Mail=_EBF5DDDC-A799-493D-9E98-5221A84C7772" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 From: Ken Raeburn In-Reply-To: <87efpb46sp.fsf@linux-m68k.org> Date: Mon, 6 Nov 2017 14:10:27 -0500 Message-Id: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> To: Andreas Schwab X-Mailer: Apple Mail (2.3273) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29165 Cc: Philipp Stephani , 29165@debbugs.gnu.org, Drew Adams , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_EBF5DDDC-A799-493D-9E98-5221A84C7772 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On Nov 6, 2017, at 13:10, Andreas Schwab wrote: > On Nov 06 2017, Ken Raeburn > wrote: >=20 >> On Nov 6, 2017, at 09:40, Drew Adams wrote: >>=20 >>>>>> We should perhaps put something about throwing error on '&option = &rest' >>>>>> into NEWS though. >>>>>=20 >>>>> I don't understand. In Common Lisp it is perfectly correct >>>>> to use both &optional and &rest. >>>>=20 >>>> What's rejected is (&optional &rest other-vars), whereas (&optional >>>> var1 &rest other-vars) is okay. Does CL accept the first form (and = if >>>> yes, what does it mean)? I couldn't tell from the page you linked = to. >>>=20 >>> CL accepts a single variable after &rest. And there must be >>> a variable after &optional. (&optional foo &rest bar) is OK. >>>=20 >>> (&optional &rest foo) is not OK. >>> (&optional foo &rest bar toto titi) is not OK. >>=20 >> Is this CL in general or a particular CL implementation? The web page = you sent the URL for earlier reads like a specification, and from its = use of =E2=80=9C*=E2=80=9D looks to me like it allows the (admittedly = useless) form of &optional with no variables. >=20 > clisp accepts it. It appears that the emacs-26 version of defun* is happy with it (the = original Lisp code I posted, using &optional &key) as well, as long as I = provide the source, or a byte-compiled file from Emacs 25 or 26; it=E2=80=99= s the .elc file generated by the older Emacs that=E2=80=99s causing me a = problem. The (new?) checks are incompatible with the the old compiled = file, even though the Lisp code itself *appears* to be acceptable still.= --Apple-Mail=_EBF5DDDC-A799-493D-9E98-5221A84C7772 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On Nov 6, = 2017, at 13:10, Andreas Schwab <schwab@linux-m68k.org> wrote:

On Nov 06 2017, Ken Raeburn <raeburn@permabit.com> wrote:
On Nov 6, 2017, at 09:40, = Drew Adams <drew.adams@oracle.com> wrote:

We should perhaps put something about throwing error on = '&option &rest'
into NEWS though.

I don't understand.  In = Common Lisp it is perfectly correct
to use both = &optional and &rest.

What's rejected is (&optional &rest other-vars), = whereas (&optional
var1 &rest other-vars) is okay. = Does CL accept the first form (and if
yes, what does it = mean)? I couldn't tell from the page you linked to.

CL accepts a single variable = after &rest. And there must be
a variable after = &optional.  (&optional foo &rest bar) is OK.

(&optional &rest foo) is not OK.
(&optional foo &rest bar toto titi) is not OK.

Is this CL in general or a = particular CL implementation? The web page you sent the URL for earlier = reads like a specification, and from its use of =E2=80=9C*=E2=80=9D = looks to me like it allows the (admittedly useless) form of = &optional with no variables.

clisp accepts it.

It appears = that the emacs-26 version of defun* is happy with it (the original Lisp = code I posted, using &optional &key) as well, as long as I = provide the source, or a byte-compiled file from Emacs 25 or 26; it=E2=80=99= s the .elc file generated by the older Emacs that=E2=80=99s causing me a = problem. The (new?) checks are incompatible with the the old compiled = file, even though the Lisp code itself *appears* to be acceptable = still.= --Apple-Mail=_EBF5DDDC-A799-493D-9E98-5221A84C7772-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 14:16:55 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 19:16:55 +0000 Received: from localhost ([127.0.0.1]:54559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBmtD-0002ba-0w for submit@debbugs.gnu.org; Mon, 06 Nov 2017 14:16:55 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:52891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBmtB-0002WX-DB for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 14:16:53 -0500 Received: by mail-wm0-f53.google.com with SMTP id t139so16459214wmt.1 for <29165@debbugs.gnu.org>; Mon, 06 Nov 2017 11:16:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=ZYiFbs3MepvIs3RKzBNQQmwh/nFwlEXXX/Bvs7xlrgM=; b=V0vR5r2L2oLGdbXmjNqE7xAjEhwmZ2hfU0yskEzFSS/lxrZIThIbwsxwLxXJgYI63e iXkDoCS4ZAmaM6PA+EgmeR5muiaWmq+XyeFDe8qKvQnYvH4Ir9GWL7EI+nt29z9ft+LE qGR4sEzq9h6LirrlRmQadjzC5d8eJkArYiA6d4aRwsYvhH6JjIjoUf8XH8HinO3tjki5 JE+Z7PQcnf8lOGekM//wIbMtQq6qHl/adcAmqX4KADvY2zhHWnr7/vlSycdgGsd6OCgO kXj42jcZrgk3OT+KupGFTDjroIdm24g1eMkgnUqao/mRaEmnMU+K/fOtFASRFBwBuMmO F5Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=ZYiFbs3MepvIs3RKzBNQQmwh/nFwlEXXX/Bvs7xlrgM=; b=WLBdntOWl0WdxVUR6WNU5mF+lU/sIrdrJEZEK4Fyu2j4qWyLPdbWPhwafMoL6PUwL3 mFHW2xYnP48uFoJBYRC4YyLSjXqfHePBH2d3ns3k0o2o8o/leL4M4X15Fe0fMSDc8skU 9CXLLz3ryvyBSMQxGvds4pTu2JMICfEATJBk4T8SfpyV4z6JkZaW5w/fyDfU31k+v9VJ jdYMThhxaHSu/qzHgyW/HGKsaXA1NURXyokHhdJQgShOTk9XMP8q2LIrn3XSSmM5MDmO xzTbHbd5h+Z0RBzlaGc21UFK+Odri/LYKB5OXaaHj1bBT9PR2nONwaxnx5on1jD9viQc utvg== X-Gm-Message-State: AJaThX4hZGCtn1p8xVzzK4Rk4IjPQAETVIDrai76e3f5ptU41m9fof62 CPNODOcMmaImj2CxoTj0d61fttGNfjO0v0yeAYQ= X-Google-Smtp-Source: ABhQp+TgotJkk515MXolLILtRfK1XJ5ZMACmAceR8r4/dGG6mZ/b7rHHo2klnL26HOQFQJ+0p6AbvXrjQzSXBc+ScGo= X-Received: by 10.28.213.143 with SMTP id m137mr5461941wmg.67.1509995807778; Mon, 06 Nov 2017 11:16:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.146.227 with HTTP; Mon, 6 Nov 2017 11:16:47 -0800 (PST) In-Reply-To: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> From: Noam Postavsky Date: Mon, 6 Nov 2017 14:16:47 -0500 X-Google-Sender-Auth: NIad8GPCiJHZSukosFSmi_VzhdM Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Ken Raeburn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On Mon, Nov 6, 2017 at 2:10 PM, Ken Raeburn wrote: > It appears that the emacs-26 version of defun* is happy with it (the > original Lisp code I posted, using &optional &key) as well, as long as I > provide the source, or a byte-compiled file from Emacs 25 or 26; it=E2=80= =99s the > .elc file generated by the older Emacs that=E2=80=99s causing me a proble= m. The > (new?) checks are incompatible with the the old compiled file, even thoug= h > the Lisp code itself *appears* to be acceptable still. It looks like the cl-defun in newer Emacs throws away the &optional for you in this case. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 14:32:04 2017 Received: (at 29165) by debbugs.gnu.org; 6 Nov 2017 19:32:04 +0000 Received: from localhost ([127.0.0.1]:54575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBn7s-00034d-4l for submit@debbugs.gnu.org; Mon, 06 Nov 2017 14:32:04 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:19777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBn7q-000349-Op for 29165@debbugs.gnu.org; Mon, 06 Nov 2017 14:32:03 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vA6JVtoX032667 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2017 19:31:56 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vA6JVtBU029906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2017 19:31:55 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vA6JVsR0015395; Mon, 6 Nov 2017 19:31:54 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 6 Nov 2017 11:31:53 -0800 (PST) From: Drew Adams To: Ken Raeburn Subject: RE: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> In-Reply-To: <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4600.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29165 Cc: Philipp Stephani , 29165@debbugs.gnu.org, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > CL accepts a single variable after &rest. And there must be > > a variable after &optional. (&optional foo &rest bar) is OK. > > > > (&optional &rest foo) is not OK. > > (&optional foo &rest bar toto titi) is not OK. >=20 > Is this CL in general or a particular CL implementation? The web page you > sent the URL for earlier reads like a specification, and from its use of > =E2=80=9C*=E2=80=9D looks to me like it allows the (admittedly useless) f= orm of &optional > with no variables. What I wrote was from memory. What counts is the definition of CL. If it doesn't forbid such constructions then an implementation or emulation) of CL is free to support them. If it doesn't define them then an implementation is free to define them any way it wants. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 13:06:50 2017 Received: (at 29165) by debbugs.gnu.org; 13 Nov 2017 18:06:50 +0000 Received: from localhost ([127.0.0.1]:38803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEJ8E-0003jt-BQ for submit@debbugs.gnu.org; Mon, 13 Nov 2017 13:06:50 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEJ8C-0003je-Nw for 29165@debbugs.gnu.org; Mon, 13 Nov 2017 13:06:49 -0500 Received: by mail-wm0-f53.google.com with SMTP id r68so16609405wmr.1 for <29165@debbugs.gnu.org>; Mon, 13 Nov 2017 10:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=WIuybNEUg7YYeWsaxBeAO8HvTluhgKOcUUFbYRpzHzY=; b=PQJDBRkpSPUOu8py72sCBa3BdevX0VUECLA8/fnzsM4z6ODSA8LkD93y2eBkgxzAaH /VoFhsS+K0LtN5Era0oE+wXo7YFdp9nUH1sxBOjGBkeWgwElJAbnb3Az14fPvFjpSg5W Fq373njAG9IslnNRHSYS/ooRGVCIyr+VdzhwEPE0yIrOBHWj5c7B3Tr1gXHCIf7eoA0Z 7bF/T2uk8xje0tJheDao2h94HyLdepHML+jGoymCt+acIbN8FjffD9Gjw8JQ1ZneOv1k gx4RVKZdBLDW4HvPuYuJfNtynW0KE8iPTH2V7KERsnfDvghnwVlur8eGPrixOZNvZ4Yt RNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=WIuybNEUg7YYeWsaxBeAO8HvTluhgKOcUUFbYRpzHzY=; b=OoxJ7w82XQute3PjSxhtcF+3gzy5hpLpGRurK0L/ytWDlcBTK8WG4W+Rv4OR1KBG9o YNpPzIwcQNTEkTmS0yUHAk0iW/29NRsexxb1cHwuTu7efLNAtoEkjkmcL6VLRIPxJ7WJ WvgtmQ3ecKsplbHrMnwuq1kfqTTE88pBQRnjL9N0C+9x4TzN/E9fVxkJyzJx0w+S3Fq5 tzfsOJ8EQxigSOjfjWYPmVe+SjzAF2xHAptIRWhA3aSckJcoO/+GxGdzm9eIhtppufjL QCHI50aPnwIoZ/PMZcM7fYVE43o6UZbTR3ke5MDHpaplW6P+Ot3Ys4nevk11+6ULKAWy zchw== X-Gm-Message-State: AJaThX6R+3bBG4RDExsebKukxD1GJoarTz3lq9mL3chnX8zmEonK6BJM XpUmkDCH2B92wZnI084kyWo8ifYhO7XkW+vciek= X-Google-Smtp-Source: AGs4zMaZB6uuyNuR18m2aTOPD+mnrXsK9isZj4uaxpDPIOmEfUzFZhsF7f22ilXbCJBSPUZeAFbJ+5ZHYGQD3mqjhTQ= X-Received: by 10.28.99.86 with SMTP id x83mr4916162wmb.114.1510596403102; Mon, 13 Nov 2017 10:06:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.151.116 with HTTP; Mon, 13 Nov 2017 10:06:42 -0800 (PST) In-Reply-To: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> From: Noam Postavsky Date: Mon, 13 Nov 2017 13:06:42 -0500 X-Google-Sender-Auth: z1h227HTLcbAg1MMgjIIRqWudSk Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Ken Raeburn Content-Type: multipart/mixed; boundary="001a1148dfd601b4f4055de122ce" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a1148dfd601b4f4055de122ce Content-Type: text/plain; charset="UTF-8" On Mon, Nov 6, 2017 at 2:16 PM, Noam Postavsky wrote: > On Mon, Nov 6, 2017 at 2:10 PM, Ken Raeburn wrote: > >> It appears that the emacs-26 version of defun* is happy with it (the >> original Lisp code I posted, using &optional &key) as well, as long as I >> provide the source, or a byte-compiled file from Emacs 25 or 26 > > It looks like the cl-defun in newer Emacs throws away the &optional > for you in this case. I think we should make cl-defun reject this kind of code, to be consistent with plain defun. See attached. --001a1148dfd601b4f4055de122ce Content-Type: application/octet-stream; name="v1-0001-Mention-new-strictness-for-optional-rest-in-argli.patch" Content-Disposition: attachment; filename="v1-0001-Mention-new-strictness-for-optional-rest-in-argli.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j9yhy4xp0 RnJvbSA4MmFmNjdiODRhNjYzZmE3NTBiMzc1ZTQ4M2Q0YjNlOGUxZjI2YTZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBNb24sIDEzIE5vdiAyMDE3IDEyOjQ2OjEzIC0wNTAwClN1YmplY3Q6IFtQQVRDSCB2MV0g TWVudGlvbiBuZXcgc3RyaWN0bmVzcyBmb3IgJm9wdGlvbmFsLCAmcmVzdCBpbiBhcmdsaXN0cwog KEJ1ZyMyOTE2NSkKCiogZXRjL05FV1M6IEV4cGxhaW4gdGhhdCAnJm9wdGlvbmFsJyBub3QgZm9s bG93ZWQgYnkgYSB2YXJpYWJsZSBpcyBub3cKYW4gZXJyb3IuCiogbGlzcC9lbWFjcy1saXNwL2Ns LW1hY3MuZWwgKGNsLS10cmFuc2Zvcm0tbGFtYmRhKQooY2wtLWRvLWFyZ2xpc3QpOiBBbHNvIHJl amVjdCAnJm9wdGlvbmFsJyBvciAnJnJlc3QnIG5vdCBmb2xsb3dlZCBieSBhCnZhcmlhYmxlIGZv ciBjb25zaXN0ZW5jeS4KKiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsIChj bC1tYWNzLWJhZC1hcmdsaXN0KTogTmV3CnRlc3QuCi0tLQogZXRjL05FV1MgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8IDExICsrKysrKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvY2wtbWFj cy5lbCAgICAgICAgICAgIHwgMTYgKysrKysrKysrKystLS0tLQogdGVzdC9saXNwL2VtYWNzLWxp c3AvY2wtbWFjcy10ZXN0cy5lbCB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmls ZXMgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGY3OWMyY2IuLmI3YWY2ZTAgMTAwNjQ0Ci0tLSBh L2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xNDY4LDYgKzE0NjgsMTcgQEAgdGhlbSB0aHJv dWdoICdmb3JtYXQnIGZpcnN0LiAgRXZlbiB0aGF0IGlzIGRpc2NvdXJhZ2VkOiBmb3IgRWxEb2MK IHN1cHBvcnQsIHlvdSBzaG91bGQgc2V0ICdlbGRvYy1kb2N1bWVudGF0aW9uLWZ1bmN0aW9uJyBp bnN0ZWFkIG9mCiBjYWxsaW5nICdlbGRvYy1tZXNzYWdlJyBkaXJlY3RseS4KIAorLS0tCisqKiBV c2luZyAnJnJlc3QnIG9yICcmb3B0aW9uYWwnIGluY29ycmVjdGx5IGlzIG5vdyBhbiBlcnJvci4K K0ZvciBleGFtcGxlIGdpdmluZyAnJm9wdGlvbmFsJyB3aXRob3V0IGEgZm9sbG93aW5nIHZhcmlh YmxlLCBvcgorcGFzc2luZyAnJm9wdGlvbmFsJyBtdWx0aXBsZSB0aW1lczoKKworICAgIChkZWZ1 biBmb28gKCZvcHRpb25hbCAmcmVzdCB4KSkKKyAgICAoZGVmdW4gYmFyICgmb3B0aW9uYWwgJm9w dGlvbmFsIHgpKQorCitQcmV2aW91c2x5LCBFbWFjcyB3b3VsZCBqdXN0IGlnbm9yZSB0aGUgZXh0 cmEga2V5d29yZCwgb3IgZ2l2ZQoraW5jb3JyZWN0IHJlc3VsdHMgaW4gY2VydGFpbiBjYXNlcy4K KwogDAogKiBMaXNwIENoYW5nZXMgaW4gRW1hY3MgMjYuMQogCmRpZmYgLS1naXQgYS9saXNwL2Vt YWNzLWxpc3AvY2wtbWFjcy5lbCBiL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCmluZGV4IGUz MTNhZjIuLmZjY2Y2ZGEgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCisr KyBiL2xpc3AvZW1hY3MtbGlzcC9jbC1tYWNzLmVsCkBAIC0yODEsOCArMjgxLDEzIEBAIGNsLS10 cmFuc2Zvcm0tbGFtYmRhCiAgICAgICAgICAgICAgICAgICAob3IgKG5vdCBvcHRpb25hbCkKICAg ICAgICAgICAgICAgICAgICAgICA7OyBPcHRpb25hbCBhcmdzIHdob3NlIGRlZmF1bHQgaXMgbmls IGFyZSBzaW1wbGUuCiAgICAgICAgICAgICAgICAgICAgICAgKG51bGwgKG50aCAxIChhc3NxIChj YXIgYXJncykgKGNkciBjbC0tYmluZC1kZWZzKSkpKSkKLSAgICAgICAgICAgICAgICAgIChub3Qg KGFuZCAoZXEgKGNhciBhcmdzKSAnJm9wdGlvbmFsKSAoc2V0cSBvcHRpb25hbCB0KQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChjYXIgY2wtLWJpbmQtZGVmcykpKSkKKyAgICAgICAgICAg ICAgICAgIChub3QgKGFuZCAoZXEgKGNhciBhcmdzKSAnJm9wdGlvbmFsKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdo ZW4gKG1lbXEgKGNhZHIgYXJncykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICcobmlsICZyZXN0ICZib2R5ICZrZXkgJmF1eCkpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChlcnJvciAiVmFyaWFibGUgbWlzc2luZyBhZnRlciAmb3B0aW9uYWwiKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIG9wdGlvbmFsIHQpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoY2FyIGNsLS1iaW5kLWRlZnMpKSkpKQogICAgICAgICAo cHVzaCAocG9wIGFyZ3MpIHNpbXBsZS1hcmdzKSkKICAgICAgICh3aGVuIG9wdGlvbmFsCiAgICAg ICAgIChpZiBhcmdzIChwdXNoICcmb3B0aW9uYWwgYXJncykpCkBAIC01NTgsOSArNTYzLDEwIEBA IGNsLS1kby1hcmdsaXN0CiAJICAoa2V5cyBuaWwpCiAJICAobGF0ZXJhcmcgbmlsKSAoZXhhY3Rh cmcgbmlsKSBtaW5hcmcpCiAgICAgICAob3IgbnVtIChzZXRxIG51bSAwKSkKLSAgICAgIChzZXRx IHJlc3RhcmcgKGlmIChsaXN0cCAoY2FkciByZXN0YXJnKSkKLSAgICAgICAgICAgICAgICAgICAg ICAgIChtYWtlLXN5bWJvbCAiLS1jbC1yZXN0LS0iKQotICAgICAgICAgICAgICAgICAgICAgIChj YWRyIHJlc3RhcmcpKSkKKyAgICAgIChzZXRxIHJlc3RhcmcgKG9yIChpZiAoY29uc3AgKGNhZHIg cmVzdGFyZykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1ha2Utc3ltYm9sICItLWNs LXJlc3QtLSIpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChjYWRyIHJlc3RhcmcpKQorICAg ICAgICAgICAgICAgICAgICAgICAgKGVycm9yICJWYXJpYWJsZSBtaXNzaW5nIGFmdGVyICZyZXN0 IikpKQogICAgICAgKHB1c2ggKGxpc3QgcmVzdGFyZyBleHByKSBjbC0tYmluZC1sZXRzKQogICAg ICAgKGlmIChlcSAoY2FyIGFyZ3MpICcmd2hvbGUpCiAJICAocHVzaCAobGlzdCAoY2wtLXBvcDIg YXJncykgcmVzdGFyZykgY2wtLWJpbmQtbGV0cykpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1h Y3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy10 ZXN0cy5lbAppbmRleCA1NzVmMTcwLi5lNDNmZjIzIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZW1h Y3MtbGlzcC9jbC1tYWNzLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2NsLW1h Y3MtdGVzdHMuZWwKQEAgLTQ5Nyw0ICs0OTcsMjkgQEAKICAgICAgICAgICAgICAgICAgICAgICAg ICAgdmNvbmNhdCAodmVjdG9yICgxKyB4KSkpCiAgICAgICAgICAgICAgICAgIFsyIDMgNCA1IDZd KSkpCiAKKwwKKzs7OyBjbC1saWIgbGFtYmRhIGxpc3QgaGFuZGxpbmcKKworKGVydC1kZWZ0ZXN0 IGNsLW1hY3MtYmFkLWFyZ2xpc3QgKCkKKyAgIkNoZWNrIHRoYXQgYGNsLWRlZnVuJyBhbmQgZnJp ZW5kcyByZWplY3Qgd2VpcmQgYXJndW1lbnQgbGlzdHMuCitTZWUgQnVnIzI5MTY1LCBhbmQgc2lt aWxhciBgZXZhbC10ZXN0cy0tYnVncy0yNDkxMi1hbmQtMjQ5MTMnIGluCitldmFsLXRlc3RzLmVs LiIKKyAgKGRvbGlzdCAoYXJncyAoY2wtbWFwY2FuCisgICAgICAgICAgICAgICAgIDs7IEZvciBl dmVyeSAmcmVzdCB2YXJpYW50LCBjaGVjayBhbHNvIHRoZSBzYW1lIHRoaW5nCisgICAgICAgICAg ICAgICAgIDs7IHdpdGggJmtleSBpbnN0ZWFkLgorICAgICAgICAgICAgICAgICAobGFtYmRhIChh cmdsaXN0KSAoaWYgKG1lbXEgJyZyZXN0IGFyZ2xpc3QpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGxpc3QgYXJnbGlzdCAoY2wtc3Vic3QgJyZrZXkgJyZyZXN0IGFyZ2xpc3Qp KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCBhcmdsaXN0KSkpCisgICAg ICAgICAgICAgICAgICcoKCZvcHRpb25hbCkgKCZyZXN0KSAoJm9wdGlvbmFsICZyZXN0KSAoJnJl c3QgJm9wdGlvbmFsKQorICAgICAgICAgICAgICAgICAgICgmb3B0aW9uYWwgJnJlc3QgX2EpICgm b3B0aW9uYWwgX2EgJnJlc3QpCisgICAgICAgICAgICAgICAgICAgKCZyZXN0IF9hICZvcHRpb25h bCkgKCZyZXN0ICZvcHRpb25hbCBfYSkKKyAgICAgICAgICAgICAgICAgICAoJm9wdGlvbmFsICZv cHRpb25hbCkgKCZvcHRpb25hbCAmb3B0aW9uYWwgX2EpCisgICAgICAgICAgICAgICAgICAgKCZv cHRpb25hbCBfYSAmb3B0aW9uYWwgX2IpCisgICAgICAgICAgICAgICAgICAgKCZyZXN0ICZyZXN0 KSAoJnJlc3QgJnJlc3QgX2EpCisgICAgICAgICAgICAgICAgICAgKCZyZXN0IF9hICZyZXN0IF9i KSkpKQorICAgIChzaG91bGQtZXJyb3IgKGV2YWwgYChmdW5jYWxsIChjbC1mdW5jdGlvbiAobGFt YmRhICxhcmdzKSkpIHQpKQorICAgIChzaG91bGQtZXJyb3IgKGNsLS10cmFuc2Zvcm0tbGFtYmRh IChjb25zIGFyZ3MgdCkpKQorICAgIChsZXQgKChieXRlLWNvbXBpbGUtZGVidWcgdCkpCisgICAg ICAoc2hvdWxkLWVycm9yIChldmFsIGAoYnl0ZS1jb21waWxlIChjbC1mdW5jdGlvbiAobGFtYmRh ICxhcmdzKSkpIHQpKSkpKQorCiA7OzsgY2wtbWFjcy10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIu Ni4yLndpbmRvd3MuMQoK --001a1148dfd601b4f4055de122ce-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 14:42:27 2017 Received: (at 29165) by debbugs.gnu.org; 13 Nov 2017 19:42:27 +0000 Received: from localhost ([127.0.0.1]:38903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEKcl-00062z-69 for submit@debbugs.gnu.org; Mon, 13 Nov 2017 14:42:27 -0500 Received: from mail-qt0-f172.google.com ([209.85.216.172]:44372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEKcj-00062n-T2 for 29165@debbugs.gnu.org; Mon, 13 Nov 2017 14:42:26 -0500 Received: by mail-qt0-f172.google.com with SMTP id 8so21060094qtv.1 for <29165@debbugs.gnu.org>; Mon, 13 Nov 2017 11:42:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=permabit.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vxT4EpzQeIzbanZuc+aQHk/XdJxF4L9PCC0WGAWRWMw=; b=cykeeZ8pkkgGiME4zwG6E2rKsazPYFP9gn0AD9EgZKGXregqtBMzd0wDLlW7URQnDA pTOACsthIaehbMjZwrd0itSeyQ250CeZLqzgcpy+QoYdKQnrgThVm9IMMh86Skgd7e+u PHAqcmuO0vfUdrr2R55ZpYYIjPiAD95okMz30= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vxT4EpzQeIzbanZuc+aQHk/XdJxF4L9PCC0WGAWRWMw=; b=VqKzD4QU3r+7xf/MgZJYkGU82dlCtHqcXLwMCp1ejlXOvB2LSIv/1++zfG5G407yrS DWREoXssLa+VnJQWGrydb5H94mXhoba4ARt9me8HGsuikSp8bE+tKqkt6ClTmJmoHLGc aQ7W2fYPbagw+sxz3ojTb7PCuCgKmv2/SD1EcfktJLRZ3lIIztnySB+fhtNeBeTRvXPW UvTrzSikHLTjEwHl4H+3HYqL2DO6BTZbHDU1piEhwRc52YuZnUvC2vRIsNUhqyuZc8Dl LV3TM4y1L/vjvwL44gh+XRGZoJLJqPP2hl/bBRVZbH+uMAbprzZKcpJcDcxTPPAO2QyM pJNA== X-Gm-Message-State: AJaThX5OF6PCMxLesoK0d2hKIuHCiAkZJoOOJgdxgVVjonGoc0DC2vXQ joWNHwZk8F1Rbiqurbc+dkpG8g== X-Google-Smtp-Source: AGs4zMabpnZXUWjGiJcItZXVno/ZdrvXC7qjfBQqLLQHGmHHhNl2+8l4OCvlb0haFbUqVvy48kjC2w== X-Received: by 10.200.40.120 with SMTP id 53mr16039696qtr.164.1510602140460; Mon, 13 Nov 2017 11:42:20 -0800 (PST) Received: from [192.168.23.135] (c-73-253-167-23.hsd1.ma.comcast.net. [73.253.167.23]) by smtp.gmail.com with ESMTPSA id g47sm11491501qtk.37.2017.11.13.11.42.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Nov 2017 11:42:19 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 From: Ken Raeburn In-Reply-To: Date: Mon, 13 Nov 2017 14:42:18 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> To: Noam Postavsky X-Mailer: Apple Mail (2.3273) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Nov 13, 2017, at 13:06, Noam Postavsky = wrote: > On Mon, Nov 6, 2017 at 2:16 PM, Noam Postavsky > wrote: >> On Mon, Nov 6, 2017 at 2:10 PM, Ken Raeburn = wrote: >>=20 >>> It appears that the emacs-26 version of defun* is happy with it (the >>> original Lisp code I posted, using &optional &key) as well, as long = as I >>> provide the source, or a byte-compiled file from Emacs 25 or 26 >>=20 >> It looks like the cl-defun in newer Emacs throws away the &optional >> for you in this case. >=20 > I think we should make cl-defun reject this kind of code, to be > consistent with plain defun. See attached. I=E2=80=99m of two minds about it=E2=80=A6 it=E2=80=99s a useless but = harmless degenerate case, and based on the link Drew posted and the test = Andreas did, making it an error would be a gratuitous incompatibility = with CL or at least one implementation. And maybe it=E2=80=99s not = entirely useless if it simplifies someone=E2=80=99s macro so that they = can treat zero-or-more optional variables with a single, simple common = code path. But even if we do make it an error, isn=E2=80=99t there = usually a stage where it=E2=80=99s just a warning? (And if we=E2=80=99re going to make that sort of thing an error, we = should probably check whether empty &key or &aux variable lists are = similarly rejected. I haven=E2=80=99t looked.) Also, what the CL macros do going forward is arguably a separate = question from whether byte-code processing should reject the byte code = generated for the same construct by older releases. That=E2=80=99s what = we=E2=80=99ve got now =E2=80=94 Emacs 26.0.90 accepts the forms for CL = macros but rejects them in byte code, and Emacs 24 CL macros produced = such forms in byte code when given such forms as input. So = currently-acceptable code, or at least code still treated as acceptable = under Emacs 25, when compiled by an older release, is no longer = accepted. If the source isn=E2=80=99t going to be rejected (e.g., if = it=E2=80=99s quietly accepted or only produces a warning), then the = byte-code for it probably ought not to be rejected. Ken= From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 15:05:18 2017 Received: (at 29165) by debbugs.gnu.org; 13 Nov 2017 20:05:18 +0000 Received: from localhost ([127.0.0.1]:38915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEKys-0006a9-3Q for submit@debbugs.gnu.org; Mon, 13 Nov 2017 15:05:18 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:39433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEKyq-0006Zv-1K for 29165@debbugs.gnu.org; Mon, 13 Nov 2017 15:05:16 -0500 Received: by mail-wm0-f47.google.com with SMTP id l8so11715597wmg.4 for <29165@debbugs.gnu.org>; Mon, 13 Nov 2017 12:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=K3Hwdc4VVWNC8583ArkGxSvYf/UdmYSHu5OQDkoj9jI=; b=DN/2jAL6+N/wP1iZ998ZirWsU94NRu0hcTBCLptMYSdaoj7SMdEkCulVLhS5oPZK3n xeKYjtUmTTgY5y2oo58b0RMBzVt9Xi1eeohtHeOuNtg8QHuKbXRl/s47ydMq1iUdVZmj mkzCJyiio12w8DNif2J1hX5VgrKokBSf75cnf4zPwKMRYkiUSYMWVzB0efHTwvPZjz8z gYUQeyatkcYGqjRvQ7B0D3N44A4JCSTq12H/4scCk8Ro96LOB5kwgQt0FmkdV6tgXCON ct10i9iTNB8Z1BR1Xu0H3YrklQ0KdvO2S2yX+lP25JOS6vcJ4WWBFZdAh72PygS+3Y5J EhUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=K3Hwdc4VVWNC8583ArkGxSvYf/UdmYSHu5OQDkoj9jI=; b=UxR5J+obQ08+Fby2aoMyBrwmid26LGU5xKsAxCWPmcIxZqf8DbXS+7eV/i15w805g0 KvOTzmSuIF4ZX4zVdScYivVhuxcb28hGi7IQzbKGxDKgi2HLC7+3Vir2+688hBVbx92o WJp7Cs5WqSsYVwveWwKKOMkvuFmS6eHvE8swkaJvJgfUAWjLTGBgPaePNn3R+0Vj6T0a PVNaVRFO4+FEL/3EzCniZFGDYFmrC3HwR513s5EAZoCDVgrB8xHcHRLzriM56v6d4ohg AhQVwA1wwZw2jCKJGU/kqsqL75617PtdiQWFq4BUM/sZNFadprthy0Hjdqnf6rDMfs2H VuPg== X-Gm-Message-State: AJaThX7z2f5Y102BXXYykbTALX4ltUqf7wG1TaN9mqrMgWRrNmm5zqfE /y4deCo7hiW9T8Vi5LpvwLsewVYf8hBVmxgSDPk= X-Google-Smtp-Source: AGs4zMZ+v03ogJft3/lEUa8yvDw5zcVtTv1ph6HgJl9Dxb9LCJWaF9myo9h3knIl2xVU8TeLPCfayRE9BXqXXJ3ElBs= X-Received: by 10.28.17.77 with SMTP id 74mr6517380wmr.66.1510603510178; Mon, 13 Nov 2017 12:05:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.151.116 with HTTP; Mon, 13 Nov 2017 12:05:09 -0800 (PST) In-Reply-To: <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> From: Noam Postavsky Date: Mon, 13 Nov 2017 15:05:09 -0500 X-Google-Sender-Auth: OLOZtwpGXKNeQgY6mHClCMmypa4 Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Ken Raeburn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Mon, Nov 13, 2017 at 2:42 PM, Ken Raeburn wrote: > But even if we do make it an error, isn=E2=80=99t there usually a stage w= here it=E2=80=99s just a warning? Maybe. There hasn't been this time (for plain defun, I mean). > (And if we=E2=80=99re going to make that sort of thing an error, we shoul= d probably check whether empty &key or &aux variable lists are similarly re= jected. I haven=E2=80=99t looked.) I believe empty &key would be tested in my patch, though not &aux. > If the source isn=E2=80=99t going to be rejected (e.g., if it=E2=80=99s q= uietly accepted or only produces a warning), then the byte-code for it prob= ably ought not to be rejected. Yes, that's why my patch rejects the source as well. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 27 17:24:10 2017 Received: (at 29165) by debbugs.gnu.org; 27 Nov 2017 22:24:10 +0000 Received: from localhost ([127.0.0.1]:33168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJRov-0002hv-Qh for submit@debbugs.gnu.org; Mon, 27 Nov 2017 17:24:09 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJRot-0002hd-UG for 29165@debbugs.gnu.org; Mon, 27 Nov 2017 17:24:08 -0500 Received: by mail-wm0-f44.google.com with SMTP id v186so38007812wma.2 for <29165@debbugs.gnu.org>; Mon, 27 Nov 2017 14:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=boSQGClF0deyk8KqJQ9bgwH4GZ7xMruS9BC32XQXLvQ=; b=jyUUuncG+++KTvymFxyC4L7uXYTPrwWBhpcfJrxjD7dm6jcefNn3eHTKdcnVJxn8PO 6gJUlSXquCaO1i/LrLbN2dkq9VQcEA96/d2/9E9wi4F1xfVR4JhnVurbxNTDMZJ/mG6P eScI7cwwUAueyoYu3E31s9v0i7lEaFd8VUH0Hlq+Pjzu3uIzO2nf07/OvyHKPuJy7HdC QLm4CS1zuDG2/PRV1DgcekETHe+C5gR7LjhKTym0Nl7jdCVlbvwoWIiyE2rhmg2lA1gl fYUe1cNEx8b3yW6O2eYCQo/OXCarza6ujjqiItmpQd4vJZq9pPKcdebF4IxhDXBJRkIu BvCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=boSQGClF0deyk8KqJQ9bgwH4GZ7xMruS9BC32XQXLvQ=; b=ROL+PdoymVxT3XflaFNVtyuUfph89HY6jO+EUWl64j0CxADUGbgn6MI6yemmTPe45d wjjC+rY+VikOJ+cEuNPeuZhlyR8gL0TtfwP40k6Mq4QR+t22YLGL62nkrc8FjMdL5TPd jzd99x6M7Bt8RMlNsxcOoxU6oojm+hgGoIvlENIwCKdumFSyFLfPFWFz+zMr+hoK0Ima fySJwfJjlm773X9ZCTbNdDSMoEQd4IW0O7fbRzQu+v7ebNpuNsXShR31jIhPVqSSGtRE qB7KFcjA74Wpz9DpCRWU3jNcQpLhXkkGiGuMqEs7mkYEzPYqz2aKCNsTWn+Icq/9Jx3H U1wg== X-Gm-Message-State: AJaThX6GpKx9eC/AH29Aa4ro7HBh/suczigQ1dv2p/qvXLvTjvQd3r+x 5FmeKJ5YfaC4d3mYCz89F5uXZbZr44nKlSbFCZI= X-Google-Smtp-Source: AGs4zMYTVklax1x1rXrv9hwRodCQdr2gYuk/PMz3dKdP6f1u4J46NDa4KgDEdlT6Dz4omafQY6IiG0XgJrjtg271p3E= X-Received: by 10.28.156.23 with SMTP id f23mr19372514wme.128.1511821442095; Mon, 27 Nov 2017 14:24:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.151.116 with HTTP; Mon, 27 Nov 2017 14:24:01 -0800 (PST) In-Reply-To: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> From: Noam Postavsky Date: Mon, 27 Nov 2017 17:24:01 -0500 X-Google-Sender-Auth: rm5G3-TZR02F55Z4v0AmZ5vzXd8 Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Ken Raeburn Content-Type: multipart/mixed; boundary="001a114b390005991b055efe5c0c" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a114b390005991b055efe5c0c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 13, 2017 at 3:05 PM, Noam Postavsky wrote: > On Mon, Nov 13, 2017 at 2:42 PM, Ken Raeburn wrote= : > >> But even if we do make it an error, isn=E2=80=99t there usually a stage = where it=E2=80=99s just a warning? > > Maybe. There hasn't been this time (for plain defun, I mean). As another case, there wasn't any warning stage for changing setq to only accept an even number of arguments. >> (And if we=E2=80=99re going to make that sort of thing an error, we shou= ld probably check whether empty &key or &aux variable lists are similarly r= ejected. I haven=E2=80=99t looked.) > > I believe empty &key would be tested in my patch, though not &aux. Updated patch which handles &aux as well. I also tested a bootstrap (doing this I found the previous patch messed up some positive cases). --001a114b390005991b055efe5c0c Content-Type: application/octet-stream; name="v2-0001-Mention-new-strictness-for-optional-rest-in-argli.patch" Content-Disposition: attachment; filename="v2-0001-Mention-new-strictness-for-optional-rest-in-argli.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jairb3k30 RnJvbSAzMTYxNWUyYWNmNmU0NGU3ZTFkODRiODhlNTNkYjc3NTEyODFkMmJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FtIFBvc3RhdnNreSA8bnBvc3RhdnNAZ21haWwuY29tPgpE YXRlOiBNb24sIDEzIE5vdiAyMDE3IDEyOjQ2OjEzIC0wNTAwClN1YmplY3Q6IFtQQVRDSCB2Ml0g TWVudGlvbiBuZXcgc3RyaWN0bmVzcyBmb3IgJm9wdGlvbmFsLCAmcmVzdCBpbiBhcmdsaXN0cwog KEJ1ZyMyOTE2NSkKCiogZXRjL05FV1M6IEV4cGxhaW4gdGhhdCAnJm9wdGlvbmFsJyBub3QgZm9s bG93ZWQgYnkgYSB2YXJpYWJsZSBpcyBub3cKYW4gZXJyb3IuCiogbGlzcC9lbWFjcy1saXNwL2Ns LW1hY3MuZWwgKGNsLS10cmFuc2Zvcm0tbGFtYmRhLCBjbC0tZG8tJmF1eCkKKGNsLS1kby1hcmds aXN0KTogQWxzbyByZWplY3QgJyZvcHRpb25hbCcsICcmcmVzdCcsIG9yICcmYXV4JyBub3QKZm9s bG93ZWQgYnkgYSB2YXJpYWJsZSBmb3IgY29uc2lzdGVuY3kuCiogdGVzdC9saXNwL2VtYWNzLWxp c3AvY2wtbWFjcy10ZXN0cy5lbCAoY2wtbWFjcy1iYWQtYXJnbGlzdCk6IE5ldwp0ZXN0LgotLS0K IGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrCiBs aXNwL2VtYWNzLWxpc3AvY2wtbWFjcy5lbCAgICAgICAgICAgIHwgMzggKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0KIHRlc3QvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MtdGVzdHMu ZWwgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDY5 IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIv ZXRjL05FV1MKaW5kZXggZjdhOWZlYi4uNWI2NjY2MSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysr IGIvZXRjL05FV1MKQEAgLTE0NjIsNiArMTQ2MiwxNyBAQCB0aGVtIHRocm91Z2ggJ2Zvcm1hdCcg Zmlyc3QuICBFdmVuIHRoYXQgaXMgZGlzY291cmFnZWQ6IGZvciBFbERvYwogc3VwcG9ydCwgeW91 IHNob3VsZCBzZXQgJ2VsZG9jLWRvY3VtZW50YXRpb24tZnVuY3Rpb24nIGluc3RlYWQgb2YKIGNh bGxpbmcgJ2VsZG9jLW1lc3NhZ2UnIGRpcmVjdGx5LgogCistLS0KKyoqIFVzaW5nICcmcmVzdCcg b3IgJyZvcHRpb25hbCcgaW5jb3JyZWN0bHkgaXMgbm93IGFuIGVycm9yLgorRm9yIGV4YW1wbGUg Z2l2aW5nICcmb3B0aW9uYWwnIHdpdGhvdXQgYSBmb2xsb3dpbmcgdmFyaWFibGUsIG9yCitwYXNz aW5nICcmb3B0aW9uYWwnIG11bHRpcGxlIHRpbWVzOgorCisgICAgKGRlZnVuIGZvbyAoJm9wdGlv bmFsICZyZXN0IHgpKQorICAgIChkZWZ1biBiYXIgKCZvcHRpb25hbCAmb3B0aW9uYWwgeCkpCisK K1ByZXZpb3VzbHksIEVtYWNzIHdvdWxkIGp1c3QgaWdub3JlIHRoZSBleHRyYSBrZXl3b3JkLCBv ciBnaXZlCitpbmNvcnJlY3QgcmVzdWx0cyBpbiBjZXJ0YWluIGNhc2VzLgorCiAMCiAqIExpc3Ag Q2hhbmdlcyBpbiBFbWFjcyAyNi4xCiAKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jbC1t YWNzLmVsIGIvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKaW5kZXggNTUzNTEwMC4uNmFlZDA2 MCAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL2NsLW1hY3MuZWwKKysrIGIvbGlzcC9lbWFj cy1saXNwL2NsLW1hY3MuZWwKQEAgLTI4MSw4ICsyODEsMTMgQEAgY2wtLXRyYW5zZm9ybS1sYW1i ZGEKICAgICAgICAgICAgICAgICAgIChvciAobm90IG9wdGlvbmFsKQogICAgICAgICAgICAgICAg ICAgICAgIDs7IE9wdGlvbmFsIGFyZ3Mgd2hvc2UgZGVmYXVsdCBpcyBuaWwgYXJlIHNpbXBsZS4K ICAgICAgICAgICAgICAgICAgICAgICAobnVsbCAobnRoIDEgKGFzc3EgKGNhciBhcmdzKSAoY2Ry IGNsLS1iaW5kLWRlZnMpKSkpKQotICAgICAgICAgICAgICAgICAgKG5vdCAoYW5kIChlcSAoY2Fy IGFyZ3MpICcmb3B0aW9uYWwpIChzZXRxIG9wdGlvbmFsIHQpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGNhciBjbC0tYmluZC1kZWZzKSkpKQorICAgICAgICAgICAgICAgICAgKG5vdCAo YW5kIChlcSAoY2FyIGFyZ3MpICcmb3B0aW9uYWwpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKHByb2duCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2hlbiAobWVtcSAoY2Fk ciBhcmdzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyhuaWwg JnJlc3QgJmJvZHkgJmtleSAmYXV4KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGVycm9yICJWYXJpYWJsZSBtaXNzaW5nIGFmdGVyICZvcHRpb25hbCIpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHNldHEgb3B0aW9uYWwgdCkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChjYXIgY2wtLWJpbmQtZGVmcykpKSkpCiAgICAgICAgIChwdXNoIChwb3AgYXJn cykgc2ltcGxlLWFyZ3MpKQogICAgICAgKHdoZW4gb3B0aW9uYWwKICAgICAgICAgKGlmIGFyZ3Mg KHB1c2ggJyZvcHRpb25hbCBhcmdzKSkKQEAgLTUzNCwxNCArNTM5LDE3IEBAIGNsLS1tYWtlLXVz YWdlLWFyZ3MKICAgICAgICAgICAgICAgYXJnbGlzdCkpKSkKIAogKGRlZnVuIGNsLS1kby0mYXV4 IChhcmdzKQotICAod2hpbGUgKGFuZCAoZXEgKGNhciBhcmdzKSAnJmF1eCkgKHBvcCBhcmdzKSkK LSAgICAod2hpbGUgKGFuZCBhcmdzIChub3QgKG1lbXEgKGNhciBhcmdzKSBjbC0tbGFtYmRhLWxp c3Qta2V5d29yZHMpKSkKLSAgICAgIChpZiAoY29uc3AgKGNhciBhcmdzKSkKLSAgICAgICAgICAo aWYgKGFuZCBjbC0tYmluZC1lbnF1b3RlIChjbC1jYWRhciBhcmdzKSkKLSAgICAgICAgICAgICAg KGNsLS1kby1hcmdsaXN0IChjYWFyIGFyZ3MpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBgJywoY2FkciAocG9wIGFyZ3MpKSkKLSAgICAgICAgICAgIChjbC0tZG8tYXJnbGlzdCAoY2Fh ciBhcmdzKSAoY2FkciAocG9wIGFyZ3MpKSkpCi0gICAgICAgIChjbC0tZG8tYXJnbGlzdCAocG9w IGFyZ3MpIG5pbCkpKSkKKyAgKHdoZW4gKGVxIChjYXIgYXJncykgJyZhdXgpCisgICAgKHBvcCBh cmdzKQorICAgICh3aGVuIChudWxsIGFyZ3MpCisgICAgICAoZXJyb3IgIlZhcmlhYmxlIG1pc3Np bmcgYWZ0ZXIgJmF1eCIpKSkKKyAgKHdoaWxlIChhbmQgYXJncyAobm90IChtZW1xIChjYXIgYXJn cykgY2wtLWxhbWJkYS1saXN0LWtleXdvcmRzKSkpCisgICAgKGlmIChjb25zcCAoY2FyIGFyZ3Mp KQorICAgICAgICAoaWYgKGFuZCBjbC0tYmluZC1lbnF1b3RlIChjbC1jYWRhciBhcmdzKSkKKyAg ICAgICAgICAgIChjbC0tZG8tYXJnbGlzdCAoY2FhciBhcmdzKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGAnLChjYWRyIChwb3AgYXJncykpKQorICAgICAgICAgIChjbC0tZG8tYXJnbGlz dCAoY2FhciBhcmdzKSAoY2FkciAocG9wIGFyZ3MpKSkpCisgICAgICAoY2wtLWRvLWFyZ2xpc3Qg KHBvcCBhcmdzKSBuaWwpKSkKICAgKGlmIGFyZ3MgKGVycm9yICJNYWxmb3JtZWQgYXJndW1lbnQg bGlzdCBlbmRzIHdpdGg6ICVTIiBhcmdzKSkpCiAKIChkZWZ1biBjbC0tZG8tYXJnbGlzdCAoYXJn cyBleHByICZvcHRpb25hbCBudW0pICAgOyB1c2VzIGNsLS1iaW5kLSoKQEAgLTU1OCw2ICs1NjYs OSBAQCBjbC0tZG8tYXJnbGlzdAogCSAgKGtleXMgbmlsKQogCSAgKGxhdGVyYXJnIG5pbCkgKGV4 YWN0YXJnIG5pbCkgbWluYXJnKQogICAgICAgKG9yIG51bSAoc2V0cSBudW0gMCkpCisgICAgICAo d2hlbiAoYW5kIHJlc3RhcmcgKG9yIChudWxsIChjZHIgcmVzdGFyZykpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChtZW1xIChjYWRyIHJlc3RhcmcpIGNsLS1sYW1iZGEtbGlzdC1rZXl3 b3JkcykpKQorICAgICAgICAoZXJyb3IgIlZhcmlhYmxlIG1pc3NpbmcgYWZ0ZXIgJnJlc3QiKSkK ICAgICAgIChzZXRxIHJlc3RhcmcgKGlmIChsaXN0cCAoY2FkciByZXN0YXJnKSkKICAgICAgICAg ICAgICAgICAgICAgICAgIChtYWtlLXN5bWJvbCAiLS1jbC1yZXN0LS0iKQogICAgICAgICAgICAg ICAgICAgICAgIChjYWRyIHJlc3RhcmcpKSkKQEAgLTYwOSw3ICs2MjAsMTIgQEAgY2wtLWRvLWFy Z2xpc3QKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYCcsY2wtLWJpbmQt YmxvY2spCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgrICxudW0gKGxlbmd0aCAs cmVzdGFyZykpKSkpCiAgICAgICAgICAgICAgICAgICBjbC0tYmluZC1mb3JtcykpKQotICAgICAg KHdoaWxlIChhbmQgKGVxIChjYXIgYXJncykgJyZrZXkpIChwb3AgYXJncykpCisgICAgICAod2hp bGUgKGVxIChjYXIgYXJncykgJyZrZXkpCisgICAgICAgIChwb3AgYXJncykKKyAgICAgICAgKHdo ZW4gKG9yIChudWxsIGFyZ3MpIChtZW1xIChjYXIgYXJncykgY2wtLWxhbWJkYS1saXN0LWtleXdv cmRzKSkKKyAgICAgICAgICAoZXJyb3IgIk1pc3NpbmcgdmFyaWFibGUgYWZ0ZXIgJmtleSIpKQor ICAgICAgICAod2hlbiBrZXlzCisgICAgICAgICAgKGVycm9yICJNdWx0aXBsZSBvY2N1cnJlbmNl cyBvZiAma2V5IikpCiAJKHdoaWxlIChhbmQgYXJncyAobm90IChtZW1xIChjYXIgYXJncykgY2wt LWxhbWJkYS1saXN0LWtleXdvcmRzKSkpCiAJICAobGV0ICgoYXJnIChwb3AgYXJncykpKQogCSAg ICAob3IgKGNvbnNwIGFyZykgKHNldHEgYXJnIChsaXN0IGFyZykpKQpkaWZmIC0tZ2l0IGEvdGVz dC9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNw L2NsLW1hY3MtdGVzdHMuZWwKaW5kZXggNTc1ZjE3MC4uYmYyZTdlMSAxMDA2NDQKLS0tIGEvdGVz dC9saXNwL2VtYWNzLWxpc3AvY2wtbWFjcy10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZW1hY3Mt bGlzcC9jbC1tYWNzLXRlc3RzLmVsCkBAIC00OTcsNCArNDk3LDM1IEBACiAgICAgICAgICAgICAg ICAgICAgICAgICAgIHZjb25jYXQgKHZlY3RvciAoMSsgeCkpKQogICAgICAgICAgICAgICAgICBb MiAzIDQgNSA2XSkpKQogCisMCis7OzsgY2wtbGliIGxhbWJkYSBsaXN0IGhhbmRsaW5nCisKKyhl cnQtZGVmdGVzdCBjbC1tYWNzLWJhZC1hcmdsaXN0ICgpCisgICJDaGVjayB0aGF0IGBjbC1kZWZ1 bicgYW5kIGZyaWVuZHMgcmVqZWN0IHdlaXJkIGFyZ3VtZW50IGxpc3RzLgorU2VlIEJ1ZyMyOTE2 NSwgYW5kIHNpbWlsYXIgYGV2YWwtdGVzdHMtLWJ1Z3MtMjQ5MTItYW5kLTI0OTEzJyBpbgorZXZh bC10ZXN0cy5lbC4iCisgIChkb2xpc3QgKGFyZ3MgKGNsLW1hcGNhbgorICAgICAgICAgICAgICAg ICA7OyBGb3IgZXZlcnkgJnJlc3QgYW5kICZvcHRpb25hbCB2YXJpYW50LCBjaGVjayBhbHNvCisg ICAgICAgICAgICAgICAgIDs7IHRoZSBzYW1lIHRoaW5nIHdpdGggJmtleSBhbmQgJmF1eCByZXNw ZWN0aXZlbHkKKyAgICAgICAgICAgICAgICAgOzsgaW5zdGVhZC4KKyAgICAgICAgICAgICAgICAg KGxhbWJkYSAoYXJnbGlzdCkKKyAgICAgICAgICAgICAgICAgICAobGV0ICgoYXJnbGlzdHMgKGxp c3QgYXJnbGlzdCkpKQorICAgICAgICAgICAgICAgICAgICAgKHdoZW4gKG1lbXEgJyZyZXN0IGFy Z2xpc3QpCisgICAgICAgICAgICAgICAgICAgICAgIChwdXNoIChjbC1zdWJzdCAnJmtleSAnJnJl c3QgYXJnbGlzdCkgYXJnbGlzdHMpKQorICAgICAgICAgICAgICAgICAgICAgKHdoZW4gKG1lbXEg JyZvcHRpb25hbCBhcmdsaXN0KQorICAgICAgICAgICAgICAgICAgICAgICAocHVzaCAoY2wtc3Vi c3QgJyZhdXggJyZvcHRpb25hbCBhcmdsaXN0KSBhcmdsaXN0cykpCisgICAgICAgICAgICAgICAg ICAgICBhcmdsaXN0cykpCisgICAgICAgICAgICAgICAgICcoKCZvcHRpb25hbCkgKCZyZXN0KSAo Jm9wdGlvbmFsICZyZXN0KSAoJnJlc3QgJm9wdGlvbmFsKQorICAgICAgICAgICAgICAgICAgICgm b3B0aW9uYWwgJnJlc3QgX2EpICgmb3B0aW9uYWwgX2EgJnJlc3QpCisgICAgICAgICAgICAgICAg ICAgKCZyZXN0IF9hICZvcHRpb25hbCkgKCZyZXN0ICZvcHRpb25hbCBfYSkKKyAgICAgICAgICAg ICAgICAgICAoJm9wdGlvbmFsICZvcHRpb25hbCkgKCZvcHRpb25hbCAmb3B0aW9uYWwgX2EpCisg ICAgICAgICAgICAgICAgICAgKCZvcHRpb25hbCBfYSAmb3B0aW9uYWwgX2IpCisgICAgICAgICAg ICAgICAgICAgKCZyZXN0ICZyZXN0KSAoJnJlc3QgJnJlc3QgX2EpCisgICAgICAgICAgICAgICAg ICAgKCZyZXN0IF9hICZyZXN0IF9iKSkpKQorICAgIChlcnQtaW5mbyAoKHByaW4xLXRvLXN0cmlu ZyBhcmdzKSA6cHJlZml4ICJhcmdsaXN0OiAiKQorICAgICAgKHNob3VsZC1lcnJvciAoZXZhbCBg KGZ1bmNhbGwgKGNsLWZ1bmN0aW9uIChsYW1iZGEgLGFyZ3MpKSkgdCkpCisgICAgICAoc2hvdWxk LWVycm9yIChjbC0tdHJhbnNmb3JtLWxhbWJkYSAoY29ucyBhcmdzIHQpKSkKKyAgICAgIChsZXQg KChieXRlLWNvbXBpbGUtZGVidWcgdCkpCisgICAgICAgIChzaG91bGQtZXJyb3IgKGV2YWwgYChi eXRlLWNvbXBpbGUgKGNsLWZ1bmN0aW9uIChsYW1iZGEgLGFyZ3MpKSkgdCkpKSkpKQorCiA7Ozsg Y2wtbWFjcy10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuNi4yLndpbmRvd3MuMQoK --001a114b390005991b055efe5c0c-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 17:36:08 2017 Received: (at 29165) by debbugs.gnu.org; 13 Dec 2017 22:36:08 +0000 Received: from localhost ([127.0.0.1]:60923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePFdI-0008VJ-Bl for submit@debbugs.gnu.org; Wed, 13 Dec 2017 17:36:08 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:45118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePFdH-0008Uu-EQ for 29165@debbugs.gnu.org; Wed, 13 Dec 2017 17:36:07 -0500 Received: by mail-wm0-f41.google.com with SMTP id 9so7895506wme.4 for <29165@debbugs.gnu.org>; Wed, 13 Dec 2017 14:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=Zvllt1BrYoM6ExijeyUylR+5H3YiAJM22u8iMiw0woE=; b=vPSdgiMVsL0CXuARjXApzroiFgbEie525dAJxRY3avWAszQK7IJ6nNSi9JZMqZR7uS 4AAGvS1wNwB/FTO1jTfQksPFlMUY2qxanTv07lVjX0frQav3zYnh+nt00Q+Noxwwjcv9 FDDWqwPz5A+IYt6ln4Cgi+C95EOR3Zg+s4gbKBsfVSSiv/2hEe9ZJuXBd1jAXR/V+BlF UXeXvwuMDiBQ2621909OMOfgP7IemsSjvYERxa/JCFou8BeWVF+LIxYKqq2IxNHHZjkQ WiwaXNoWEQtSQxBaz/ne2H1n49Wn+p1MCHUvopjFqhVpIP67EwdtlVEz63uL0xXFfqe+ Z7bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=Zvllt1BrYoM6ExijeyUylR+5H3YiAJM22u8iMiw0woE=; b=V5XK1zKbWsIb6IoHeiDa7hi9lqrBcI1dNUmdqP3hfmTMw312eYkOhUYPfjJl708+Fy iGAKBO7HRfd7HamEvMTiHrkaJlWMjVQU71OhVNw47wcDxs/Xv26UZw1V79hnBUpcr5BH R/n6lPIe1gehXl52Ij0VHeZtR4qYIQRqlO7oKDd4K1x+T+mbYZldKoLlw320+x7vN/Et zXS4d+Sm5Y4M0OtOrPwHQ3lVHhNj/qaMPNmUKnHiuSmQMv1iKLcnczAhDh3kut5tJVe7 EYyYpDzvdP83jxEcH98HB/9XTWmAuhDbGdyXi2TelUHm2Wj1Ookq3M5zl9G5RFALm4sh G2Lg== X-Gm-Message-State: AKGB3mKerhFyMid7vMbBCShKYAFWWEkEbUJREMJYy6fbBPQBeKHr2j+1 RyhjcRqjzNJKajrmNZueji4guiS0eBrl2k5Atzk= X-Google-Smtp-Source: ACJfBosZyvETUV/UdgX2wh3hQ1nRiwJbydHIGLz15u8Tp76upuVuaQrv8NYrdzcz1LrFpTfIhNvlHV5htQmmty+liU8= X-Received: by 10.28.184.209 with SMTP id i200mr404339wmf.96.1513204561502; Wed, 13 Dec 2017 14:36:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.151.116 with HTTP; Wed, 13 Dec 2017 14:36:01 -0800 (PST) In-Reply-To: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> From: Noam Postavsky Date: Wed, 13 Dec 2017 17:36:01 -0500 X-Google-Sender-Auth: 6NeOtRWtWOs2uG_reERDFI1Mj2c Message-ID: Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: Ken Raeburn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) close 29165 26.1 quit On Mon, Nov 27, 2017 at 5:24 PM, Noam Postavsky wrote: > On Mon, Nov 13, 2017 at 3:05 PM, Noam Postavsky > wrote: >> On Mon, Nov 13, 2017 at 2:42 PM, Ken Raeburn wrot= e: >> >>> But even if we do make it an error, isn=E2=80=99t there usually a stage= where it=E2=80=99s just a warning? >> >> Maybe. There hasn't been this time (for plain defun, I mean). > > As another case, there wasn't any warning stage for changing setq to > only accept an even number of arguments. > >>> (And if we=E2=80=99re going to make that sort of thing an error, we sho= uld probably check whether empty &key or &aux variable lists are similarly = rejected. I haven=E2=80=99t looked.) >> >> I believe empty &key would be tested in my patch, though not &aux. > > Updated patch which handles &aux as well. I also tested a bootstrap > (doing this I found the previous patch messed up some positive cases). Pushed to emacs-26. [1: e7b1111]: 2017-12-13 17:31:27 -0500 Mention new strictness for &optional, &rest in arglists (Bug#29165) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3De7b1111155b3116d= 0c7b137e0e1d312db0f1ca80 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 17:36:47 2017 Received: (at control) by debbugs.gnu.org; 13 Dec 2017 22:36:47 +0000 Received: from localhost ([127.0.0.1]:60926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePFdt-0008WD-LW for submit@debbugs.gnu.org; Wed, 13 Dec 2017 17:36:47 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePFdr-0008Vy-J8 for control@debbugs.gnu.org; Wed, 13 Dec 2017 17:36:44 -0500 Received: by mail-wm0-f42.google.com with SMTP id i11so7994364wmf.4 for ; Wed, 13 Dec 2017 14:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=5w6IvCZG8G9gT7Qzj+K6AfbYRPrY8WzmJ6tIhclRD9U=; b=bM5qK1Yt5bjuf+yPG0RYMROoe8ze7SzjZ9zj5/GGxsGI8EhtYsau3x1+PQC0qtgYAq LXHa4wJMVX7a2luRwSdaHA39YEf0idvvUucnd7+hXqK0umKnlp+FQ2C5hs/nx8yCwdnZ Rcb6FdQiefIIaDriaSKakGxSI2qwcsacx7SZ9FqSqwwWWjNHRs57jKuCh9/rahfvJ8hV zWrToWLxJzxghucVHcRYG4yCzBUA51XsqyDYKsMV1Am5HhqgpA8ex1hCw3AVo2Yqffc9 Z3BjyEUMfl2JByKqLftNEtg+nGWl7N/yJP468yrAoA2bAGAKZOhNqHM3n5lOYU3E6bw0 UDFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=5w6IvCZG8G9gT7Qzj+K6AfbYRPrY8WzmJ6tIhclRD9U=; b=Bf70k6yYuX0iGyXIuOFwKpfOR1E1w0RK+A76Yli8X37cga0kAssrskQ10zftfpvIU9 uJhvJskIy3OBMnrPKNKGd9gK4lsD8AQdSW1P5c8lFusB3sTxh3YGK51dopME9RURvrW/ BMfhnUSBpZuiart+tM6swIcTzh0nF2YUyMfeNY12GFDsfIBayUGa82S36NPvWQUqhIFH HIiojkq90nYq17kV9fMfnOCJlL5CVkBSiOnxAbj8st58SmL1zEjCiw0+L6YpYEq9T7j8 fcXD47gldNjAu+CtYjCHXuMQH6a5+7ThX5AQFroKMTwJTJ3WOU92udOYbQ1vJYWXmBny ZYSQ== X-Gm-Message-State: AKGB3mIOj4AQnQ8Z9SpoP2e0dyyfTB0gNfahSFpef+HZ8MIF6wjs6P0n NDrmb0s3r/+cmgjklH6st9X00l3SJ4yjHUoSfDPojA== X-Google-Smtp-Source: ACJfBot87Rr+vWA3sskuqyW8PyWGmaxo1PGwE8rzFJg3L7p8eAh5JmRAYaGc80b4iBbUomqyBsEAT/tQF8SmvMDr9U4= X-Received: by 10.28.114.13 with SMTP id n13mr459256wmc.146.1513204597904; Wed, 13 Dec 2017 14:36:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.151.116 with HTTP; Wed, 13 Dec 2017 14:36:37 -0800 (PST) From: Noam Postavsky Date: Wed, 13 Dec 2017 17:36:37 -0500 X-Google-Sender-Auth: pzsWW1lMWALjMnYzqNfqs7WnejA Message-ID: Subject: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) # forgot to bcc control before close 29165 26.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 13 18:40:03 2017 Received: (at 29165) by debbugs.gnu.org; 13 Dec 2017 23:40:03 +0000 Received: from localhost ([127.0.0.1]:60989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGd8-0005Xe-8z for submit@debbugs.gnu.org; Wed, 13 Dec 2017 18:40:02 -0500 Received: from pmta11.teksavvy.com ([76.10.157.34]:56750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGd5-0005XH-Ta for 29165@debbugs.gnu.org; Wed, 13 Dec 2017 18:40:00 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HsAgDLuTFa/zyu+M5dGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYM+RoEUg15LixWOEwGBfBQgAZhxCoU1BAIChRJEFAEBAQEBAQE?= =?us-ascii?q?BAQNoKIUlAQQBIzMjBQsLDgwCGA4CAhQYDSSKMwipLoInimABAQgCASWBD4JRi?= =?us-ascii?q?HWFHYMVgmMFimKIRl6PGaEph2aWVhCBOzYjgU4yGggwgmSEcyOKYwEBAQ?= X-IPAS-Result: =?us-ascii?q?A2HsAgDLuTFa/zyu+M5dGQEBAQEBAQEBAQEBAQcBAQEBAYM?= =?us-ascii?q?+RoEUg15LixWOEwGBfBQgAZhxCoU1BAIChRJEFAEBAQEBAQEBAQNoKIUlAQQBI?= =?us-ascii?q?zMjBQsLDgwCGA4CAhQYDSSKMwipLoInimABAQgCASWBD4JRiHWFHYMVgmMFimK?= =?us-ascii?q?IRl6PGaEph2aWVhCBOzYjgU4yGggwgmSEcyOKYwEBAQ?= X-IronPort-AV: E=Sophos;i="5.45,398,1508817600"; d="scan'208";a="14286067" Received: from 206-248-174-60.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.174.60]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2017 18:39:53 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 94866AE0DF; Wed, 13 Dec 2017 18:39:52 -0500 (EST) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Message-ID: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> Date: Wed, 13 Dec 2017 18:39:52 -0500 In-Reply-To: (Noam Postavsky's message of "Mon, 13 Nov 2017 15:05:09 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , Andreas Schwab , Philipp Stephani , 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> (And if we=E2=80=99re going to make that sort of thing an error, we shou= ld >> probably check whether empty &key or &aux variable lists are similarly >> rejected. I haven=E2=80=99t looked.) I recently installed a patch to fix/improve the behavior of &aux with no keyword variable (I bumped into it while working on some Elisp package, tho I can't remember which right now). I think it's usually worth the small extra effort to support &optional not followed by any var (as well as &aux not followed by any var) since it sometimes comes in handy. But not if it costs extra at run-time. > Updated patch which handles &aux as well. I also tested a bootstrap > (doing this I found the previous patch messed up some positive cases). To the extent that &aux is only handled by macro-expansion, accepting an empty &aux never costs anything at run-time, so I think rejecting it is a disservice to our users. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 14 20:16:31 2017 Received: (at 29165) by debbugs.gnu.org; 15 Dec 2017 01:16:31 +0000 Received: from localhost ([127.0.0.1]:34327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePec1-0008DY-0O for submit@debbugs.gnu.org; Thu, 14 Dec 2017 20:16:29 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:35090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePec0-00089A-7H for 29165@debbugs.gnu.org; Thu, 14 Dec 2017 20:16:28 -0500 Received: by mail-it0-f43.google.com with SMTP id f143so15446364itb.0 for <29165@debbugs.gnu.org>; Thu, 14 Dec 2017 17:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4XerAqh7dPT0MZn18hNVLLP+eLDNubMLeEJJ4TXqRMk=; b=cmFs3bOg23vIUPoZrAav96klavkWdSEbOBmE3es0BaAUHILyeH4bm6eooAmwN4H6qo Nxi/gEaRHqql9l/vIwWVWL+A2Fq7KDJrUtZ50fatVh76pFdMpaPjNX4c0GaNqUBk7xLB Q0Ydb8XKzvZ2lwDANoq+uAsQoGWJ0iVTpk18CFVlPYXjv0roxciCBGX23TwAGsJgzN4J Qf8eC/df0X2qnj3o/QXNND0wEXOd7iF0ROICh6k6xuHIKQeUAzoQPO7MwbBYUPa//kb2 BeQ7HNPLdYdYAeBuwguvZwHumeLh/F4X6NcONBTsoOm94GC2wpwtwUiLHa+tswswXBIo zPsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=4XerAqh7dPT0MZn18hNVLLP+eLDNubMLeEJJ4TXqRMk=; b=f72Ocp3yfNbH9ZamG0BNHi+9+dzG7p1J1R5CSHFG0wNcNR9pqL5u5zURMiV0sQelec W5z7z8gLEJd3UBvy3eXqMojRCcnjc+66Xp3GuSx5vE3Z7c17ql7zzGfcpBtfRQjjRs9t m3FJy19RE80GeAGgQn3/U1R5TeEg31AWBB1Ml12YmLY/YJDO/qLGCLDdCZXpzlYO7bha 9UfaJL1aUTZQpgP7kDMRo1BN8GR1SbU8st6Tjxenk/QYBMUrQLZmluEVL/0w2Xc/oW/u YjDrTItzZ96qKysJlWsfrz1R1i0p7TcjklWePjHn5NNmo+cgbW5YclGS+ZXzUH9mwzqP Kf9w== X-Gm-Message-State: AKGB3mIVdAUhC+esWGULU+XZz8qCoonL6FPj2FXOYBz86roRnbOU3v6T /N/ynhAmH1cIA30obLp7vLpCfg== X-Google-Smtp-Source: ACJfBos/jLA/ceBf+Ei8/fR44LhwB/Zc02jHWzHMQ+YHL3thL6ZKas0REygZ6mXxNDsaNBQZlwHsEg== X-Received: by 10.107.175.103 with SMTP id y100mr10504410ioe.48.1513300582595; Thu, 14 Dec 2017 17:16:22 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 140sm9773621itx.3.2017.12.14.17.16.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Dec 2017 17:16:21 -0800 (PST) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> Date: Thu, 14 Dec 2017 20:16:20 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 13 Dec 2017 18:39:52 -0500") Message-ID: <877etodc4b.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Stefan Monnier writes: >>> (And if we=E2=80=99re going to make that sort of thing an error, we sho= uld >>> probably check whether empty &key or &aux variable lists are similarly >>> rejected. I haven=E2=80=99t looked.) > > I recently installed a patch to fix/improve the behavior of &aux with no > keyword variable (I bumped into it while working on some Elisp package, > tho I can't remember which right now). > > I think it's usually worth the small extra effort to support &optional > not followed by any var (as well as &aux not followed by any var) since > it sometimes comes in handy. But not if it costs extra at run-time. I don't think there is any performance penalty (when running byte-compiled code anyway). Although I see that &optional at the end of the arglist has been a compile error for a long time (I tested back to 24.3). E.g., (defun foo (&optional)) fails to compile. (defun foo (&optional &rest)) happened to work, though I wouldn't exactly call that "support". >> Updated patch which handles &aux as well. I also tested a bootstrap >> (doing this I found the previous patch messed up some positive cases). > > To the extent that &aux is only handled by macro-expansion, accepting an > empty &aux never costs anything at run-time, so I think rejecting it is > a disservice to our users. I don't see the use case for empty &aux, but I don't mind reverting that change. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 14 22:04:29 2017 Received: (at 29165) by debbugs.gnu.org; 15 Dec 2017 03:04:29 +0000 Received: from localhost ([127.0.0.1]:34405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePgIW-00026E-TL for submit@debbugs.gnu.org; Thu, 14 Dec 2017 22:04:29 -0500 Received: from pmta31.teksavvy.com ([76.10.157.38]:57227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePgIU-000260-C1 for 29165@debbugs.gnu.org; Thu, 14 Dec 2017 22:04:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HuAgD8OjNa/zyu+M5dGgEBAQEBAgEBA?= =?us-ascii?q?QEIAQEBAYM+gVqPPo4TAYF8NAGYeIU/BAIChHZEFAEBAQEBAQEBAQNoKIUlAQQ?= =?us-ascii?q?BViMFCwsOJhIUGA0kijUIq3aKYwEBAQEGAgElg2WIeIsVBZMqj36XJ4oHh2mWX?= =?us-ascii?q?4FLNiOBTjIaCDCCZIRzI4p/AQEB?= X-IPAS-Result: =?us-ascii?q?A2HuAgD8OjNa/zyu+M5dGgEBAQEBAgEBAQEIAQEBAYM+gVq?= =?us-ascii?q?PPo4TAYF8NAGYeIU/BAIChHZEFAEBAQEBAQEBAQNoKIUlAQQBViMFCwsOJhIUG?= =?us-ascii?q?A0kijUIq3aKYwEBAQEGAgElg2WIeIsVBZMqj36XJ4oHh2mWX4FLNiOBTjIaCDC?= =?us-ascii?q?CZIRzI4p/AQEB?= X-IronPort-AV: E=Sophos;i="5.45,402,1508817600"; d="scan'208";a="13890439" Received: from 206-248-174-60.dsl.teksavvy.com (HELO pastel.home) ([206.248.174.60]) by smtp.teksavvy.com with ESMTP; 14 Dec 2017 22:04:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6F6DC60782; Thu, 14 Dec 2017 22:04:15 -0500 (EST) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Message-ID: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <877etodc4b.fsf@users.sourceforge.net> Date: Thu, 14 Dec 2017 22:04:15 -0500 In-Reply-To: <877etodc4b.fsf@users.sourceforge.net> (Noam Postavsky's message of "Thu, 14 Dec 2017 20:16:20 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I don't see the use case for empty &aux, but I don't mind reverting that > change. It's typically when you define a function from within a macro so you may have something like `(... (cl-defun ,foo (,@args &aux ,@auxargs) ,@body) ...) where `auxargs` can have any length including 0. It's not terribly hard to strip the &aux when `auxargs` is empty, but it's convenient to be able to use the above form without having to worry about a possibly empty `auxargs`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 00:35:11 2017 Received: (at 29165) by debbugs.gnu.org; 15 Dec 2017 05:35:11 +0000 Received: from localhost ([127.0.0.1]:34472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePieL-0005br-2Q for submit@debbugs.gnu.org; Fri, 15 Dec 2017 00:35:11 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:43287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePiNC-0005B5-Cb for 29165@debbugs.gnu.org; Fri, 15 Dec 2017 00:17:27 -0500 Received: by mail-qk0-f179.google.com with SMTP id j207so9052783qke.10 for <29165@debbugs.gnu.org>; Thu, 14 Dec 2017 21:17:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SDr4WzjXuOv5x7t5tE9zYdlKER2RGo4uyqRZUYus7/8=; b=m972cw181YP63LKBanIW8WXE3C4Qmu/hmTA/IE+dpE9EUVwYA+9GFd+N09JCvgvJVa L0KhbYDhh5qUBUpGgXK0FDxxHVYNex4aa2q/pk3jpo2nG9dCoGosFq7BM6rIWb4qmQqF 72LhtCzsu84Z9j+hZNkK7vuX/2djCRmiNY6e/j7usVVHCRbibCtTn567llWDOTj3fu5+ yHpr513QxDWRGVdkHE2GGgOmyjSY8M/1D2QQKOFsZ9LGEZ6VbH1Aa5NkbNImNpPUoIOS B4qCDWjgRf3N5/5iaEN/TpCWDrS4FhM8whVbThccGM+GL+Vbv5yrHNeiKjJKv2HyvQ2n qFXw== X-Gm-Message-State: AKGB3mIhEna7yzcDHXVYX6VGWFVQrNYtCgzeGnroLru4mU/cJL/aHf8S rc0KLiWTGBZmKVLu0DMssW2RJQ== X-Google-Smtp-Source: ACJfBouhLHonFGAfEw9QjAnoAqkfwCYAQyKqVYT3n/ApBHBVZUVmEHwZvXS1PHOKM+ldxZYDqJVHAg== X-Received: by 10.55.174.132 with SMTP id x126mr20684992qke.101.1513315040811; Thu, 14 Dec 2017 21:17:20 -0800 (PST) Received: from [192.168.23.135] (c-73-253-167-23.hsd1.ma.comcast.net. [73.253.167.23]) by smtp.gmail.com with ESMTPSA id 5sm1735880qtv.23.2017.12.14.21.17.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Dec 2017 21:17:19 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 From: Ken Raeburn In-Reply-To: Date: Fri, 15 Dec 2017 00:17:18 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <0E1EB8C9-8692-48F6-BBA0-826DCA7F819B@redhat.com> References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <877etodc4b.fsf@users.sourceforge.net> To: Stefan Monnier X-Mailer: Apple Mail (2.3273) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29165 X-Mailman-Approved-At: Fri, 15 Dec 2017 00:35:07 -0500 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Dec 14, 2017, at 22:04, Stefan Monnier = wrote: >> I don't see the use case for empty &aux, but I don't mind reverting = that >> change. >=20 > It's typically when you define a function from within a macro so you = may > have something like [=E2=80=A6] Why is this different from "=E2=80=A6 &optional ,@optargs=E2=80=9D in a = similar form, when optargs could have no elements? Rejecting that was = (part of) the point of Noam=E2=80=99s change (and the previous change = for bug 24913). I think I=E2=80=99ve already made my objection to that = part plain, but it seems like rejecting an empty &optional and accepting = an empty &aux would be inconsistent. Ken= From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 08:55:00 2017 Received: (at 29165) by debbugs.gnu.org; 15 Dec 2017 13:55:00 +0000 Received: from localhost ([127.0.0.1]:34834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePqS3-0004jX-Rd for submit@debbugs.gnu.org; Fri, 15 Dec 2017 08:55:00 -0500 Received: from pmta21.teksavvy.com ([76.10.157.36]:25703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePqS2-0004jL-1l for 29165@debbugs.gnu.org; Fri, 15 Dec 2017 08:54:58 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GeBADf0jNa/zyu+M5dGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYM+gVqEKYsVjhQBgX80AZkAhT8EAgKEfEQUAQEBAQEBAQEBA2g?= =?us-ascii?q?oQhABhFIBBAEjMyMFCwsaAhgOAgIUGA0kLIoJCKkwgieKYgEBAQcCJoEPglqIe?= =?us-ascii?q?YUdgxWCYwWTLpAIlyiKB4dtlmWBSzYjgU8yGggwgmaEcyOEJoZXAQEB?= X-IPAS-Result: =?us-ascii?q?A2GeBADf0jNa/zyu+M5dGQEBAQEBAQEBAQEBAQcBAQEBAYM?= =?us-ascii?q?+gVqEKYsVjhQBgX80AZkAhT8EAgKEfEQUAQEBAQEBAQEBA2goQhABhFIBBAEjM?= =?us-ascii?q?yMFCwsaAhgOAgIUGA0kLIoJCKkwgieKYgEBAQcCJoEPglqIeYUdgxWCYwWTLpA?= =?us-ascii?q?IlyiKB4dtlmWBSzYjgU8yGggwgmaEcyOEJoZXAQEB?= X-IronPort-AV: E=Sophos;i="5.45,405,1508817600"; d="scan'208";a="13969930" Received: from 206-248-174-60.dsl.teksavvy.com (HELO pastel.home) ([206.248.174.60]) by smtp.teksavvy.com with ESMTP; 15 Dec 2017 08:54:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id 1822461286; Fri, 15 Dec 2017 08:54:52 -0500 (EST) From: Stefan Monnier To: Ken Raeburn Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Message-ID: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <877etodc4b.fsf@users.sourceforge.net> <0E1EB8C9-8692-48F6-BBA0-826DCA7F819B@redhat.com> Date: Fri, 15 Dec 2017 08:54:52 -0500 In-Reply-To: <0E1EB8C9-8692-48F6-BBA0-826DCA7F819B@redhat.com> (Ken Raeburn's message of "Fri, 15 Dec 2017 00:17:18 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29165 Cc: 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Why is this different from "=E2=80=A6 &optional ,@optargs=E2=80=9D in a s= imilar form, when > optargs could have no elements? Rejecting that was (part of) the point of > Noam=E2=80=99s change (and the previous change for bug 24913). It's not, and I also think rejecting it is generally unadvisable unless it has a performance impact. > I think I=E2=80=99ve already made my objection to that part plain, but it > seems like rejecting an empty &optional and accepting an empty &aux > would be inconsistent. Inconsistency is part of life, tho. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 11:49:14 2017 Received: (at 29165) by debbugs.gnu.org; 15 Dec 2017 16:49:14 +0000 Received: from localhost ([127.0.0.1]:35982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePtAg-0000SD-7M for submit@debbugs.gnu.org; Fri, 15 Dec 2017 11:49:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePtAe-0000Rw-Pc for 29165@debbugs.gnu.org; Fri, 15 Dec 2017 11:49:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePtAY-0005Ur-Ro for 29165@debbugs.gnu.org; Fri, 15 Dec 2017 11:49:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePtAH-00059Y-KU; Fri, 15 Dec 2017 11:48:49 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ePtAF-000665-RE; Fri, 15 Dec 2017 11:48:47 -0500 From: Glenn Morris To: Noam Postavsky Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> X-Spook: Mantis North Korea explosion number key Emergency X-Ran: g40QNXvC7MuuXOu*IKV~h1bu=%gboi-NV9AK+i$nM"amJyEy0*}X.twQ2N[/_Md`/Q0w3{ X-Hue: brightwhite X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 15 Dec 2017 11:48:47 -0500 In-Reply-To: (Noam Postavsky's message of "Wed, 13 Dec 2017 17:36:01 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Noam Postavsky wrote: > Pushed to emacs-26. > > [1: e7b1111]: 2017-12-13 17:31:27 -0500 > Mention new strictness for &optional, &rest in arglists (Bug#29165) > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e7b1111155b3116d0c7b137e0e1d312db0f1ca80 When attempting to merge emacs-26 to master, this conflicts with commit cea0bca54f Date: Mon Nov 27 12:45:16 2017 -0500 * lisp/emacs-lisp/cl-macs.el: Fix &key with no key arg Please could someone indicate how this is to be resolved. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 15 23:55:03 2017 Received: (at 29165) by debbugs.gnu.org; 16 Dec 2017 04:55:03 +0000 Received: from localhost ([127.0.0.1]:36333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQ4V5-0004PQ-91 for submit@debbugs.gnu.org; Fri, 15 Dec 2017 23:55:03 -0500 Received: from mail-it0-f42.google.com ([209.85.214.42]:36496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQ4V3-0004Oo-HN; Fri, 15 Dec 2017 23:55:01 -0500 Received: by mail-it0-f42.google.com with SMTP id d16so22348451itj.1; Fri, 15 Dec 2017 20:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=F9eZ4wJkcxhXfc2kOg2ZgiOnYMDO9w1z48mMURuZmlc=; b=JUXuUGytAR6kDi+WmpPFng7idurRtTGUt4qKNV1IizCmNtAZQFBczn55vX82CA7C/P NIcw8GjIqJGoNZn1u2gZRdGywNgsfgx1jnEScLiZ757QMXVTDtg0EzRXVMTQOtrdyusx rwfs3g2/ZPHJnZWBlHgK8U0NgNK/3RR3dJ32sA6E4Ax2tgAfivZqWkwveroKBGMCl2mc sbBTP198MSPvGoj1QuKmFfkJEqKuenq6WF1qa2EsGWktO7bfIi7K4fNNuj90n+CVklMM 3vwYPQZqty/Mu2hUrJOv0hcQdDxVPwnP5oEdR7BJ4wW0RfNy1vO6D+IFOkLKnjsK0hcU 43rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=F9eZ4wJkcxhXfc2kOg2ZgiOnYMDO9w1z48mMURuZmlc=; b=CvbFi9CN4Z8SSrEH4TGjl3XCgDfOYL4G/wDjhxc24eYn/zRLwt+JN/It0d/uJrfNZY f4/oK295xi3G5W+wCqJfj/jsbJKU5UMddCmeiqSj4H1QAGvfjbUlNOFpU3CzoVTQkUbx UZvAnBwp+P7If+4+vUtZiazHMo7Oed3pZfugGKkdWJMYr46nxerkQu9lN77TPOEB8+Mc Os7n3m2y2ylfKGLQ77eKbsGLhNR6XA676YWDaXqPGvIU4jynCHoKe5Pj/OZcOJwupqvP mbeCYKYoa0/1UCNMMfkCDBTb0KQYfNKqYFDFtN+Hfrzsb9mkdPK921pVIuEYZybb8ifG jCAA== X-Gm-Message-State: AKGB3mJuY2OESNCDGPnqRoRPSASt3mwzTzHyAY809lP7zoiU84yc0fEW aX0fWvr8FJsPqclSPEqa+u/8sA== X-Google-Smtp-Source: ACJfBoud/kyQzUwO8aT7YGjx0rGoz1Ev92hDJq8NFOhZO43mfIzmtE4zLBaOL0i3tLOXww0ns7OhOA== X-Received: by 10.36.172.73 with SMTP id m9mr11396071iti.120.1513400095703; Fri, 15 Dec 2017 20:54:55 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id h187sm4295091ioe.17.2017.12.15.20.54.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Dec 2017 20:54:54 -0800 (PST) From: Noam Postavsky To: Glenn Morris Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> Date: Fri, 15 Dec 2017 23:54:53 -0500 In-Reply-To: (Glenn Morris's message of "Fri, 15 Dec 2017 11:48:47 -0500") Message-ID: <87r2rvb7c2.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , Andreas Schwab , Philipp Stephani , 29165@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) reopen 29165 quit Glenn Morris writes: > Noam Postavsky wrote: > >> Pushed to emacs-26. >> >> [1: e7b1111]: 2017-12-13 17:31:27 -0500 >> Mention new strictness for &optional, &rest in arglists (Bug#29165) >> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e7b1111155b3116d0c7b137e0e1d312db0f1ca80 > > When attempting to merge emacs-26 to master, this conflicts with > > commit cea0bca54f > Date: Mon Nov 27 12:45:16 2017 -0500 > > * lisp/emacs-lisp/cl-macs.el: Fix &key with no key arg > > Please could someone indicate how this is to be resolved. I've reverted my cl-lib code changes, so the conflict should be resolved now. As for this bug, it seems the best way forward is to relax the checks so that an empty list of &optional variables is accepted. From unknown Fri Sep 05 20:55:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 26.1 and reopened. Date: Sat, 16 Dec 2017 04:56:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 26.1 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 00:18:20 2017 Received: (at control) by debbugs.gnu.org; 16 Dec 2017 05:18:20 +0000 Received: from localhost ([127.0.0.1]:36343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQ4rc-0006sZ-7f for submit@debbugs.gnu.org; Sat, 16 Dec 2017 00:18:20 -0500 Received: from mail-io0-f173.google.com ([209.85.223.173]:36301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQ4ra-0006sN-Qv for control@debbugs.gnu.org; Sat, 16 Dec 2017 00:18:19 -0500 Received: by mail-io0-f173.google.com with SMTP id l10so4751559ioc.3 for ; Fri, 15 Dec 2017 21:18:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=0hyJHA85/4s3wwBCQu4xmrLks560ODsSc/TiBq1inr4=; b=qHCDroe2n/j7xZhrPzBf8aidbJX/bdzF9P+QXs6uk0ADhacmpeAIu7x5ldXuXKuZtL UEyS7kQMj7XuCS4QZp9Dpq3INL/GYivvGewAOY2UrQHCoUhsgZmHhynrmmr+tbE0dzId cwc0c3qVUB0XEnztPceSWWVwxagFji8K78Y5v1lEHVrMGt/M3zVmv0E53cskGh3I7oNh BR5m9/oViSdkSGYeI0/ym+SFMJ6H0EDBF6fNRy7ZCpCVz7GtgAnFD6j5LYcPpr0n6NLZ Hx49I3P7QhGJLwQUWSc45SQc7O9RAkpKr4W34OUJOtqDM08SkncID3SF+kMGWnoWGOWz zqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=0hyJHA85/4s3wwBCQu4xmrLks560ODsSc/TiBq1inr4=; b=MwHjluhfYmLRxZqm/imcCEt/KGs1360zT1j/+o2kx79r37tZT+jYwknZ9YER1gi8kZ 6/4AzazD1r3Mns7MzJuyY7HsYZ/hFlg53W8LrCWepFolW9ZH8YxrX9KS5o2ZyML1m26+ 2HyMaIG5VKh1ETbg+Ot9s9YvIajKmeBZH1lU/K5EBo06enKsuaHApKexz5LUkQ9Ol1Cd PqFIfIHmA7ytIcVKp1lD/CEr5FQsbsmGqa/4O6Vn/e2onKNtBc9gUbWraYSs0lX+ca5L BkrY8o8rkvUiolSfl3bLxMdflJ2nfXiB7B37EeqWSiiGQXrRhIo7OueOdfj0hgF0QDum d6sg== X-Gm-Message-State: AKGB3mJiHWsqT7aUyshWKwN4ZuYO+WMz2tSsuh3JiUpwkBhLWmfSoGIh yq9YRfWcdjJWagb4rUciynEhIQ== X-Google-Smtp-Source: ACJfBosBW/8IW6DNM0JRgOo4cp8QKGu94tme2Dql068q/JCMIoDeYa9jU4VozueT34lvH+I5AncxDA== X-Received: by 10.107.142.72 with SMTP id q69mr14704513iod.205.1513401493201; Fri, 15 Dec 2017 21:18:13 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o137sm4643110ito.5.2017.12.15.21.18.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Dec 2017 21:18:11 -0800 (PST) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #29165 Date: Sat, 16 Dec 2017 00:18:10 -0500 Message-ID: <87po7fb699.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) found 29165 26.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 17:10:30 2018 Received: (at 29165) by debbugs.gnu.org; 20 Jan 2018 22:10:30 +0000 Received: from localhost ([127.0.0.1]:36406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed1LJ-0001Uz-Ts for submit@debbugs.gnu.org; Sat, 20 Jan 2018 17:10:30 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:46958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed1LH-0001UR-21; Sat, 20 Jan 2018 17:10:27 -0500 Received: by mail-io0-f181.google.com with SMTP id f34so5737549ioi.13; Sat, 20 Jan 2018 14:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=MvfhXFOs5o8BjAjELc4KHgq6i1Fg5QaoABz/bmn9U2E=; b=EvBT7/coM8iJbIW9m5XE+2568kiAiDHqGALwy/E9GJZxLRPcsPFLPlhAE7/R/yZaKe yN475tzSbrpq3MBzYfl/lgpZk2X2iOglOPSvN/st27oIfRx4mGSy8mJ5F211WB8rFXc+ WmnDP6Yqi26cd3JDZGjnXS7EgnyuEbBDF9bum36xOrS6OBbDGlleM8YOaurpzcmR3/KZ bIbcS3PJByn9WAfHJN09B36QyahrQoF0WfajQDkPdnY+qyf6Dephk48ebZfbGMrJLhQw A13zXpQIf+kCZaPRAZtiAgC33hE35YCLn/V4lxMcap9Miv9Vwk95gWSE7YTneb//P/4G Y3xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=MvfhXFOs5o8BjAjELc4KHgq6i1Fg5QaoABz/bmn9U2E=; b=treCedKyqhRyS45WCgrwcCdzqdJ6d2F790gKya34OmY8laEkYhAdwAV0fXimlXzw5Y gqjnz+FvSBxC5qu43H2lGb3xDSv5BmLzEPxCfr0dnpf4lc02jEvaDvtklJd58jKPi3XX 5q/KksPtP1PPUkb/tSWNKG/FI4lWgEViEbV1R//QvdogYtGv7VXqdx2i4dM8AkH12EvH RXhCCqvqK6vz82y/Y1fe1oVt0CpGgYtUo3mRKH3JMxCOF8NwhWw5x7ibtC6Uy2GXgHcc S9OgfT/bcAk9/Gih/LNTQQUYrSY9juekDoXlGiAjeD4+bNoE5t+2PRh6ANFW4chIO7B7 0ddg== X-Gm-Message-State: AKwxytfPDKsxi/1s/XgibciK0kpUJ6bgQ/EwcsC68+ceKstpyNQ2Bj3J IJ18X/Yp6oS80RWa10Tw/M07GQ== X-Google-Smtp-Source: AH8x225v0QpdA4AlCofCO87KWB1jmH+tqeEqYthSQ/ql/5CqtftV98e34AeXPKSjrK0PPS+3183kjg== X-Received: by 10.107.69.3 with SMTP id s3mr3128751ioa.67.1516486221432; Sat, 20 Jan 2018 14:10:21 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id l68sm2226874ith.25.2018.01.20.14.10.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 Jan 2018 14:10:19 -0800 (PST) From: Noam Postavsky To: Glenn Morris Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <87r2rvb7c2.fsf@users.sourceforge.net> Date: Sat, 20 Jan 2018 17:10:17 -0500 In-Reply-To: <87r2rvb7c2.fsf@users.sourceforge.net> (Noam Postavsky's message of "Fri, 15 Dec 2017 23:54:53 -0500") Message-ID: <87po64npva.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain tags 29165 = patch quit Noam Postavsky writes: > I've reverted my cl-lib code changes, so the conflict should be resolved > now. As for this bug, it seems the best way forward is to relax the > checks so that an empty list of &optional variables is accepted. Here's a patch. Details of behaviour changes over versions are in the commit message. I probably should have got around to this before 26.0.91, but I think this should still go to emacs-26 because the patch makes the behaviour closer to what was in v25. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v1-0001-Allow-rest-or-optional-without-following-variable.patch Content-Description: patch >From b019118586204357c3d20541724c63163eed695b Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 20 Jan 2018 11:27:23 -0500 Subject: [PATCH v1] Allow `&rest' or `&optional' without following variable (Bug#29165) This is sometimes convenient when writing macros, so that the empty variable case doesn't need to be handled specially. Older versions of Emacs accepted this in some cases. | arglist | i/c 25 | i/c 26.0.90 | i/c new | |---------------------------+--------+-------------+---------| | (&rest) | y/n | n/n | y/y | | (&rest &rest) | y/n | n/n | n/n | | (&rest &rest x) | y/n | n/n | n/n | | (&rest x &rest) | y/n | n/n | n/n | | (&rest x &rest y) | y/n | n/n | n/n | |---------------------------+--------+-------------+---------| | (&optional) | y/n | n/n | y/y | | (&optional &optional) | y/n | n/n | n/n | | (&optional x &optional) | y/n | n/n | n/n | | (&optional x &optional y) | y/y | n/n | n/n | |---------------------------+--------+-------------+---------| | (&optional &rest) | y/n | n/n | y/y | | (&optional x &rest) | y/n | n/n | y/y | | (&optional &rest y) | y/y | n/n | y/y | |---------------------------+--------+-------------+---------| | (&rest &optional) | y/n | n/n | n/n | | (&rest &optional y) | y/n | n/n | n/n | | (&rest x &optional y) | y/n | n/n | n/n | (require 'bytecomp) (defun ck-args (arglist) (insert (condition-case err (progn (funcall `(lambda ,arglist 'ok)) "y") (error (error-message-string err) "n")) "/" (condition-case err (progn (byte-compile-check-lambda-list arglist) "y") (error (error-message-string err) "n")))) (with-current-buffer (get-buffer-create "*ck-args*") (erase-buffer) (dolist (arglist '((&rest) (&rest &rest) (&rest &rest x) (&rest x &rest) (&rest x &rest y) (&optional) (&optional &optional) (&optional x &optional) (&optional x &optional y) (&optional &rest) (&optional x &rest) (&optional &rest y) (&rest &optional) (&rest &optional y) (&rest x &optional y))) (ck-args arglist) (insert "\n")) (display-buffer (current-buffer))) * src/eval.c (funcall_lambda): * lisp/emacs-lisp/bytecomp.el (byte-compile-check-lambda-list): Don't check for missing variables after `&rest' and `&optional'. * test/src/eval-tests.el (eval-tests--bugs-24912-and-24913) (eval-tests-accept-empty-optional-rest): Update tests accordingly. * etc/NEWS: Update announcement accordingly. --- etc/NEWS | 28 ++++++++++++++++++++++------ lisp/emacs-lisp/bytecomp.el | 11 ++++------- src/eval.c | 10 +++------- test/src/eval-tests.el | 20 +++++++++++++++++--- 4 files changed, 46 insertions(+), 23 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 67915c7024..f5859d7a60 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1493,15 +1493,31 @@ support, you should set 'eldoc-documentation-function' instead of calling 'eldoc-message' directly. --- -** Using '&rest' or '&optional' incorrectly is now an error. -For example giving '&optional' without a following variable, or -passing '&optional' multiple times: +** Emacs is now more consistent about use of '&rest' and '&optional'. + +--- +*** Using them twice is now an error. - (defun foo (&optional &rest x)) (defun bar (&optional &optional x)) + (defun bar (&rest &rest x)) + +Previously, Emacs ignored the extra keyword. + +--- +*** Putting '&optional' after '&rest' is now an error. + + (defun foo (&rest &optional x)) + +Previously, it was only a compilation error, but the interpreter +accepted it. + +--- +*** Omitting variables after '&optional' or '&rest' is now accepted. + + (defun foo (&optional)) -Previously, Emacs would just ignore the extra keyword, or give -incorrect results in certain cases. +Previously, it was accepted only in certain cases, e.g., '&optional' +if it was followed immediately by '&rest'. --- ** The pinentry.el library has been removed. diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index eb00725776..222aca05f2 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -2749,15 +2749,12 @@ byte-compile-check-lambda-list (macroexp--const-symbol-p arg t)) (error "Invalid lambda variable %s" arg)) ((eq arg '&rest) - (unless (cdr list) - (error "&rest without variable name")) (when (cddr list) - (error "Garbage following &rest VAR in lambda-list"))) + (error "Garbage following &rest VAR in lambda-list")) + (when (memq (cadr list) '(&optional &rest)) + (error "%s following &rest in lambda-list" (cadr list)))) ((eq arg '&optional) - (when (or (null (cdr list)) - (memq (cadr list) '(&optional &rest))) - (error "Variable name missing after &optional")) - (when (memq '&optional (cddr list)) + (when (memq '&optional (cdr list)) (error "Duplicate &optional"))) ((memq arg vars) (byte-compile-warn "repeated variable %s in lambda-list" arg)) diff --git a/src/eval.c b/src/eval.c index e05a17f7b4..9ec937f1a2 100644 --- a/src/eval.c +++ b/src/eval.c @@ -2980,7 +2980,6 @@ funcall_lambda (Lisp_Object fun, ptrdiff_t nargs, emacs_abort (); i = optional = rest = 0; - bool previous_optional_or_rest = false; for (; CONSP (syms_left); syms_left = XCDR (syms_left)) { maybe_quit (); @@ -2991,17 +2990,15 @@ funcall_lambda (Lisp_Object fun, ptrdiff_t nargs, if (EQ (next, Qand_rest)) { - if (rest || previous_optional_or_rest) + if (rest) xsignal1 (Qinvalid_function, fun); rest = 1; - previous_optional_or_rest = true; } else if (EQ (next, Qand_optional)) { - if (optional || rest || previous_optional_or_rest) + if (optional || rest) xsignal1 (Qinvalid_function, fun); optional = 1; - previous_optional_or_rest = true; } else { @@ -3025,11 +3022,10 @@ funcall_lambda (Lisp_Object fun, ptrdiff_t nargs, else /* Dynamically bind NEXT. */ specbind (next, arg); - previous_optional_or_rest = false; } } - if (!NILP (syms_left) || previous_optional_or_rest) + if (!NILP (syms_left)) xsignal1 (Qinvalid_function, fun); else if (i < nargs) xsignal2 (Qwrong_number_of_arguments, fun, make_number (nargs)); diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el index 201382da9c..57faa0feae 100644 --- a/test/src/eval-tests.el +++ b/test/src/eval-tests.el @@ -37,8 +37,7 @@ byte-compile-debug (ert-deftest eval-tests--bugs-24912-and-24913 () "Check that Emacs doesn't accept weird argument lists. Bug#24912 and Bug#24913." - (dolist (args '((&optional) (&rest) (&optional &rest) (&rest &optional) - (&optional &rest a) (&optional a &rest) + (dolist (args '((&rest &optional) (&rest a &optional) (&rest &optional a) (&optional &optional) (&optional &optional a) (&optional a &optional b) @@ -47,7 +46,22 @@ byte-compile-debug (should-error (eval `(funcall (lambda ,args)) t) :type 'invalid-function) (should-error (byte-compile-check-lambda-list args)) (let ((byte-compile-debug t)) - (should-error (eval `(byte-compile (lambda ,args)) t))))) + (ert-info ((format "bytecomp: args = %S" args)) + (should-error (eval `(byte-compile (lambda ,args)) t)))))) + +(ert-deftest eval-tests-accept-empty-optional-rest () + "Check that Emacs accepts empty &optional and &rest arglists. +Bug#24912." + (dolist (args '((&optional) (&rest) (&optional &rest) + (&optional &rest a) (&optional a &rest))) + (let ((fun `(lambda ,args 'ok))) + (ert-info ("eval") + (should (eq (funcall (eval fun t)) 'ok))) + (ert-info ("byte comp check") + (byte-compile-check-lambda-list args)) + (ert-info ("bytecomp") + (let ((byte-compile-debug t)) + (should (eq (funcall (byte-compile fun)) 'ok))))))) (dolist (form '(let let*)) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 20 22:02:10 2018 Received: (at 29165) by debbugs.gnu.org; 21 Jan 2018 03:02:10 +0000 Received: from localhost ([127.0.0.1]:36457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed5ta-0002ix-FB for submit@debbugs.gnu.org; Sat, 20 Jan 2018 22:02:10 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:41294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed5tY-0002ip-3c for 29165@debbugs.gnu.org; Sat, 20 Jan 2018 22:02:09 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w0L326oK029768; Sat, 20 Jan 2018 22:02:06 -0500 Received: by pastel.home (Postfix, from userid 20848) id 0BBE2606D4; Sat, 20 Jan 2018 22:02:06 -0500 (EST) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Message-ID: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <87r2rvb7c2.fsf@users.sourceforge.net> <87po64npva.fsf@users.sourceforge.net> Date: Sat, 20 Jan 2018 22:02:06 -0500 In-Reply-To: <87po64npva.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 20 Jan 2018 17:10:17 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6204=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6204> : inlines <6323> : streams <1776637> : uri <2575747> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 29165 Cc: Ken Raeburn , Glenn Morris , Philipp Stephani , Andreas Schwab , 29165@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > Here's a patch. Details of behaviour changes over versions are in the > commit message. LGTM, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 11:04:54 2018 Received: (at 29165) by debbugs.gnu.org; 21 Jan 2018 16:04:54 +0000 Received: from localhost ([127.0.0.1]:37210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edI74-0008Pb-5Y for submit@debbugs.gnu.org; Sun, 21 Jan 2018 11:04:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edI73-0008PO-4M for 29165@debbugs.gnu.org; Sun, 21 Jan 2018 11:04:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edI6x-0007I7-3N for 29165@debbugs.gnu.org; Sun, 21 Jan 2018 11:04:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edI6s-0007FO-MN; Sun, 21 Jan 2018 11:04:42 -0500 Received: from [176.228.60.248] (port=2137 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1edI6p-0008Ns-9j; Sun, 21 Jan 2018 11:04:39 -0500 Date: Sun, 21 Jan 2018 18:04:23 +0200 Message-Id: <83wp0bqjug.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87po64npva.fsf@users.sourceforge.net> (message from Noam Postavsky on Sat, 20 Jan 2018 17:10:17 -0500) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <87r2rvb7c2.fsf@users.sourceforge.net> <87po64npva.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29165 Cc: rgm@gnu.org, 29165@debbugs.gnu.org, raeburn@permabit.com, p.stephani2@gmail.com, schwab@linux-m68k.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Sat, 20 Jan 2018 17:10:17 -0500 > Cc: Ken Raeburn , Andreas Schwab , > Philipp Stephani , 29165@debbugs.gnu.org, > Stefan Monnier > > I probably should have got around to this before 26.0.91, but I think > this should still go to emacs-26 because the patch makes the behaviour > closer to what was in v25. Is it important enough to justify one more pretest, after 26.0.91, and delay the release by a few more weeks? Because that's what would be needed if we install this on the release branch. Besides, this change was introduced more than a year ago, and we did that in clear understanding that it changes behavior. So "closer to Emacs 25" doesn't sound like a convincing argument in this case, because we gave up that similarity up front. Your call. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 11:30:13 2018 Received: (at 29165) by debbugs.gnu.org; 21 Jan 2018 16:30:13 +0000 Received: from localhost ([127.0.0.1]:37236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edIVY-0000Yj-O6 for submit@debbugs.gnu.org; Sun, 21 Jan 2018 11:30:12 -0500 Received: from mail-io0-f179.google.com ([209.85.223.179]:39949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edIVW-0000Xf-SA for 29165@debbugs.gnu.org; Sun, 21 Jan 2018 11:30:11 -0500 Received: by mail-io0-f179.google.com with SMTP id t22so6977377ioa.7 for <29165@debbugs.gnu.org>; Sun, 21 Jan 2018 08:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=H2f47AZj1Y7+axsUtGKOnU2OTVjHE4YQVcTiI7sQWGA=; b=bSsnFz8MFgLVuaIGWvM57FWgIASrp+zuww51jLcRXsqjYLWotd6zjkWZx1Z2jJznTp xxh8Q8tadizPMwXUx9mstPy24NCC67Mov+Ue/LqhiSyMXzA+5PLyNczzEqZcKHMw1BmL paTzvpcNtZmvd7RBT6+YzSBKmoHjTOXCaRJeAkURw3qYVp2mUYzyAvXHO2CpxT/Rm/0f KBUE7uD6c+QQxnrAzzn+C0tG/0IPPmS71D7BDef6k9pBZA6iyj+eF4jEOvoujKAVbxWm 8s6e8ecBm3CVsKwtFzRuVARkBnMSMvpAayoPRe0hR1wEvc4H/Tb5FmWx0SUeE3WktdIf avgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=H2f47AZj1Y7+axsUtGKOnU2OTVjHE4YQVcTiI7sQWGA=; b=HtYGgjPoAdkl4h5RZCt7qG21mSlpiI+Htq+aYm/E5gZ7683AptahVFrWhZkLUydNTq DVSiM1YSanWNtHDMHg3oqBFk+tsq4Jb3RLRpt+XMsF4rMJEIuwjtfJ4CDAMy+P+yR0Qj 3mwH/42rtNPWq2Pw79QBBD1EYZCrVvfo3wwRfCbghAgNaJqmjppGvoov1c09KdyYlUSu 5jMQSATRYcBmtJS6OHvTTRu8bXQsbsNqMFa17YbZNpBd+dglRm18lupkFohQSP1qQOmp SAQ9ah6J44T5eyfHVIcyCsafT0hACaRiHWZ1Nk8W4DIxKho0pPpKh7K1lcT1RlJEPtvW fjlA== X-Gm-Message-State: AKwxytcaAXvZtE26/ZI1JVWoy6s750nUbkqePMXuaxuWsZ0KwMrDK8bR /NjFvGti8NhHmIRINCrV+kc= X-Google-Smtp-Source: AH8x225BqZzvmqkgdpetMq6QHxuR+nA7vl7xbs/1NbK4SGMwz27R9H4ruvCX2UN0nP8zpJeDaOShAA== X-Received: by 10.107.9.208 with SMTP id 77mr5452382ioj.195.1516552205308; Sun, 21 Jan 2018 08:30:05 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 140sm4135003itx.3.2018.01.21.08.30.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 Jan 2018 08:30:04 -0800 (PST) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <87r2rvb7c2.fsf@users.sourceforge.net> <87po64npva.fsf@users.sourceforge.net> <83wp0bqjug.fsf@gnu.org> Date: Sun, 21 Jan 2018 11:30:02 -0500 In-Reply-To: <83wp0bqjug.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 21 Jan 2018 18:04:23 +0200") Message-ID: <87k1wbnpit.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29165 Cc: rgm@gnu.org, 29165@debbugs.gnu.org, raeburn@permabit.com, p.stephani2@gmail.com, schwab@linux-m68k.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Sat, 20 Jan 2018 17:10:17 -0500 >> Cc: Ken Raeburn , Andreas Schwab , >> Philipp Stephani , 29165@debbugs.gnu.org, >> Stefan Monnier >> >> I probably should have got around to this before 26.0.91, but I think >> this should still go to emacs-26 because the patch makes the behaviour >> closer to what was in v25. > > Is it important enough to justify one more pretest, after 26.0.91, and > delay the release by a few more weeks? Because that's what would be > needed if we install this on the release branch. Hmm, no, I think these edge cases are not important enough to delay the release. > Besides, this change was introduced more than a year ago, and we did > that in clear understanding that it changes behavior. So "closer to > Emacs 25" doesn't sound like a convincing argument in this case, > because we gave up that similarity up front. Well, the unfortunate thing about waiting is that we get more strict in v26 and then turn around in v27 and (partially) reverse the decision. But still, as I said above, not worth delaying the release over it. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 13:01:52 2018 Received: (at 29165) by debbugs.gnu.org; 21 Jan 2018 18:01:52 +0000 Received: from localhost ([127.0.0.1]:37308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edJwF-0004gt-P9 for submit@debbugs.gnu.org; Sun, 21 Jan 2018 13:01:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edJwE-0004gZ-9U for 29165@debbugs.gnu.org; Sun, 21 Jan 2018 13:01:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edJw6-0003J6-0o for 29165@debbugs.gnu.org; Sun, 21 Jan 2018 13:01:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edJvv-0003Ai-V4; Sun, 21 Jan 2018 13:01:31 -0500 Received: from [176.228.60.248] (port=2250 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1edJvv-0000dS-6m; Sun, 21 Jan 2018 13:01:31 -0500 Date: Sun, 21 Jan 2018 20:01:16 +0200 Message-Id: <83mv17qefn.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87k1wbnpit.fsf@users.sourceforge.net> (message from Noam Postavsky on Sun, 21 Jan 2018 11:30:02 -0500) Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <87r2rvb7c2.fsf@users.sourceforge.net> <87po64npva.fsf@users.sourceforge.net> <83wp0bqjug.fsf@gnu.org> <87k1wbnpit.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29165 Cc: rgm@gnu.org, 29165@debbugs.gnu.org, raeburn@permabit.com, p.stephani2@gmail.com, schwab@linux-m68k.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: rgm@gnu.org, 29165@debbugs.gnu.org, raeburn@permabit.com, p.stephani2@gmail.com, schwab@linux-m68k.org, monnier@iro.umontreal.ca > Date: Sun, 21 Jan 2018 11:30:02 -0500 > > > Is it important enough to justify one more pretest, after 26.0.91, and > > delay the release by a few more weeks? Because that's what would be > > needed if we install this on the release branch. > > Hmm, no, I think these edge cases are not important enough to delay the > release. > > > Besides, this change was introduced more than a year ago, and we did > > that in clear understanding that it changes behavior. So "closer to > > Emacs 25" doesn't sound like a convincing argument in this case, > > because we gave up that similarity up front. > > Well, the unfortunate thing about waiting is that we get more strict in > v26 and then turn around in v27 and (partially) reverse the decision. > But still, as I said above, not worth delaying the release over it. OK, then please push to master, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 25 11:33:01 2018 Received: (at 29165) by debbugs.gnu.org; 25 Mar 2018 15:33:02 +0000 Received: from localhost ([127.0.0.1]:53080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f07dl-0000SX-IK for submit@debbugs.gnu.org; Sun, 25 Mar 2018 11:33:01 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:54601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f07dj-0000SB-5P; Sun, 25 Mar 2018 11:32:59 -0400 Received: by mail-it0-f42.google.com with SMTP id h143-v6so130500ita.4; Sun, 25 Mar 2018 08:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+zUSF9uMQ8AGtrTiMiv/dyXFWdIyjoEyDB9O1pY4H4c=; b=kmtGSRKfhHUF7SG1mWVFdDdZff+/eYzQKGF+tTyOPOxUW+jjHnkIRCQqDjfY5ddwXS 7WfFOCZ6od8kTzaoDJPZg5lGkuqUOhtUqsT3eGxjn0Fab79uiDXL4dBxhKGBjc5gSj7t niEQWdJexmugYTkUKpQkltNpp4kZhAV2CMeQdNoSaUSjr+G6WUoSLTIY4L4T6j+uuvT3 iNOEn+KqtZ6BVuspKSFs0wSlXuT5NwjyJkpTcCmTTQ+HVALiQZIwMbji4M6E/7sq+P0N tLgSxRCG6tlMBcqis35J3oZhkIBf1hBeptbhbVzqE+7MJfqC3xwMjuqlXTVzIZuNgOWT 4rLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+zUSF9uMQ8AGtrTiMiv/dyXFWdIyjoEyDB9O1pY4H4c=; b=VfonA270hJclwmm+QIg9jURjTXufGD2xz7sHpaDWnw5e3s8Wf20gOt1meJzskD1f0k Wg4yudLuDSBrTXmPvwh9CvFy6ofV3rky21I1RGVgzm9dksQ8EnMmerQ9UEe/tPTjv2yD RnM/qac9UtivJm3Bjh6+HuYjiLs0AriNJOYk8FQEGUiJhRRK06L7MwG/1rUICOJuUAwj M+Uq7jZ/X0AlTRraRwrpZTbZpxDTqf0NVu27G6+xPmAXC/WoKpQSMd3jy0bSGONvOdci 1Zi2ci4LvRPMZNc3nieW+Ih/NVQq69KwaY3K2Jaq15P4oLpDU+YTMRXsqVM+Va3mTL52 ZL9A== X-Gm-Message-State: AElRT7FAaFzzW3g4CnzaJqJAz31nwnOId/acUr9kwHW1qAzYpq5NEIzd NheYZ7DI1QFaETSTVXzKo5DT8Q== X-Google-Smtp-Source: AIpwx4/CiUe/JEGuvuYPwBrX2gXZZS/XRQJpgaBht/BgTYAmRvzbKE49ayryUAz8TDbONj1pQocciw== X-Received: by 2002:a24:d282:: with SMTP id z124-v6mr20711701itf.116.1521991973277; Sun, 25 Mar 2018 08:32:53 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e142-v6sm9652361ite.3.2018.03.25.08.32.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Mar 2018 08:32:52 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> <87r2rvb7c2.fsf@users.sourceforge.net> <87po64npva.fsf@users.sourceforge.net> <83wp0bqjug.fsf@gnu.org> <87k1wbnpit.fsf@users.sourceforge.net> <83mv17qefn.fsf@gnu.org> Date: Sun, 25 Mar 2018 11:32:50 -0400 In-Reply-To: <83mv17qefn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 21 Jan 2018 20:01:16 +0200") Message-ID: <87muywqifx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29165 Cc: rgm@gnu.org, 29165@debbugs.gnu.org, Noam Postavsky , raeburn@permabit.com, p.stephani2@gmail.com, schwab@linux-m68k.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 29165 fixed close 29165 27.1 quit Eli Zaretskii writes: > OK, then please push to master, and thanks. Right, done (finally). [1: 1d47d777ef]: 2018-03-25 07:56:35 -0400 Allow `&rest' or `&optional' without following variable (Bug#29165) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1d47d777ef24c0be9153b0a1c8ba21918fa1025a From unknown Fri Sep 05 20:55:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator