GNU bug report logs - #29156
25.3; eshell/kill does not understand -<signal>

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eric Skoglund <eric <at> pagefault.se>
Cc: 29156 <at> debbugs.gnu.org, npostavs <at> gmail.com, ambrevar <at> gmail.com
Subject: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Sat, 17 Mar 2018 21:33:48 +0200

> From: Eric Skoglund <eric <at> pagefault.se>
> Cc: Noam Postavsky <npostavs <at> gmail.com>, 29156 <at> debbugs.gnu.org,  ambrevar <at> gmail.com
> Date: Sat, 17 Mar 2018 18:43:29 +0100
> 
>      * lisp/eshell/esh-proc.el (eshell/kill):
>      Handle the argument parsing and numeric conversion in function
>      in order to parse -signal and -SIGNALNAME correctly.
> ---
>  doc/misc/eshell.texi    | 2 +-
>  etc/NEWS                | 5 +++++
>  lisp/eshell/esh-proc.el | 9 ++++++---
>  3 files changed, 12 insertions(+), 4 deletions(-)

The commit log should mention changes to all the files you are
changing.

> +*** The function eshell/kill is now able to handle signal switches.
> +Previously eshell/kill would fail if provided a kill signal to send to the
> +process. It now handles both numeric signals and the string version of
          ^^
Two spaces between sentences, please.  Also, I'd rephrase the last
sentence:

  It now accepts signals specified either by name or by its number.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.