GNU bug report logs - #29156
25.3; eshell/kill does not understand -<signal>

Previous Next

Full log

Message #21 received at 29156 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 29156 <at> debbugs.gnu.org, eric <at> pagefault.se, ambrevar <at> gmail.com
Subject: Re: bug#29156: 25.3;
 eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill
 handle -<signal> and -<SIGNALNAME>
Date: Sat, 17 Mar 2018 10:58:32 +0200

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Fri, 16 Mar 2018 20:34:25 -0400
> Cc: Eric Skoglund <eric <at> pagefault.se>, Pierre Neidhardt <ambrevar <at> gmail.com>
> 
> >           ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg)
> > -          (setq signum (abs (string-to-number arg)))))
> > +          (setq signum (make-symbol (substring arg 1 (length arg))))))
> 
> Not sure this `make-symbol' call, should it rather be `intern'?

Yes, I think intern is better here.

> (Maybe we should update signal-process take a string as well a
> symbol.)

Possibly.

Btw, the doc string of eshell/kill should be updated to reflect the
fact we now support symbolic names of Unix signals.  Also, NEWS and
the Eshell manual should be updated.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.