Subject: Re: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>

From: Eli Zaretskii <[email-masked]>
Date: Sat, 17 Mar 2018 10:58:32 +0200

> From: Noam Postavsky <[email-masked]>
> Date: Fri, 16 Mar 2018 20:34:25 -0400
> Cc: Eric Skoglund <[email-masked]>, Pierre Neidhardt <[email-masked]>
> 
> >           ((string-match "\\`-\\([[:upper:]]+\\|[[:lower:]]+\\)\\'" arg)
> > -          (setq signum (abs (string-to-number arg)))))
> > +          (setq signum (make-symbol (substring arg 1 (length arg))))))
> 
> Not sure this `make-symbol' call, should it rather be `intern'?

Yes, I think intern is better here.

> (Maybe we should update signal-process take a string as well a
> symbol.)

Possibly.

Btw, the doc string of eshell/kill should be updated to reflect the
fact we now support symbolic names of Unix signals.  Also, NEWS and
the Eshell manual should be updated.