GNU bug report logs - #29155
[PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland backend.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Rutger Helling <rhelling <at> mykolab.com>
Subject: bug#29155: closed (Re: [bug#29155] [PATCH] gnu: sdl2: Update to
 2.0.7 and enable Wayland	backend.)
Date: Sun, 05 Nov 2017 17:21:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29155: [PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland backend.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29155 <at> debbugs.gnu.org.

-- 
29155: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29155
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Rutger Helling <rhelling <at> mykolab.com>, 29155-done <at> debbugs.gnu.org
Subject: Re: [bug#29155] [PATCH] gnu: sdl2: Update to 2.0.7 and enable
 Wayland	backend.
Date: Sun, 05 Nov 2017 18:20:14 +0100

[Message part 3 (text/plain, inline)]

Rutger Helling <rhelling <at> mykolab.com> writes:

> Hey Guix, 
>
> this patch updates SDL2 to 2.0.7 and enables the Wayland backend.

Excellent!

> From 8121e1100d56cbafa23a255fa6bd4f8c5b4fc7d3 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Sun, 5 Nov 2017 12:01:04 +0100
> Subject: [PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland backend.
>
> * gnu/packages/sdl.scm (sdl2): Update to 2.0.7.
> * gnu/packages/sdl.scm (sdl2)[inputs]: Add wayland, wayland-protocols, libxkbcommon.

This forgot to mention the change to [arguments].

> @@ -94,7 +97,7 @@ joystick, and graphics hardware.")
>  (define-public sdl2
>    (package (inherit sdl)
>      (name "sdl2")
> -    (version "2.0.5")
> +    (version "2.0.7")
>      (source (origin
>               (method url-fetch)
>               (uri
> @@ -102,7 +105,21 @@ joystick, and graphics hardware.")
>                               version ".tar.gz"))
>               (sha256
>                (base32
> -               "11c75qj1qxmx67iwkvf9z4x69phk301pdn86zzr6jncnap7kh824"))))
> +               "0pjdpxla5kh1w1b0shxrx97a116vyy31njxi0jhyvqhk8d6cfdgf"))))
> +    (arguments
> +     '(;; Explicitly link against shared libraries instead of dlopening them.
> +       ;; For X11, ALSA, PulseAudio and Wayland.
> +       ;; OpenGL library is still dlopened at runtime.
> +       #:configure-flags '("--disable-alsa-shared"
> +                           "--disable-pulseaudio-shared"
> +                           "--disable-x11-shared"
> +                           "--disable-wayland-shared"

I changed this section to inherit from 'sdl' and just add the wayland
flag, and updated the commit message accordingly.

> @@ -111,7 +128,10 @@ joystick, and graphics hardware.")
>       (append `(("dbus" ,dbus)
>                 ("fcitx" ,fcitx) ; helps with CJK input
>                 ("glib" ,glib)
> -               ("ibus" ,ibus))
> +               ("ibus" ,ibus)
> +               ("wayland", wayland)
> +               ("wayland-protocols", wayland-protocols)
> +               ("libxkbcommon", libxkbcommon))

And also restored the alphabetical ordering here to please the OCD.

Pushed as 39f2433c39b3cb6d1e4c0f04e8b735c181d6feac, thank you!

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Rutger Helling <rhelling <at> mykolab.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: sdl2: Update to 2.0.7 and enable Wayland backend.
Date: Sun, 05 Nov 2017 12:28:21 +0100

[Message part 6 (text/plain, inline)]

Hey Guix, 

this patch updates SDL2 to 2.0.7 and enables the Wayland backend.

[Message part 7 (text/html, inline)]

[0001-gnu-sdl2-Update-to-2.0.7-and-enable-Wayland-backend.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.