From unknown Mon Jun 23 13:11:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29153 <29153@debbugs.gnu.org> To: bug#29153 <29153@debbugs.gnu.org> Subject: Status: 25.3; Eshell can't quit when read-only commands have been run Reply-To: bug#29153 <29153@debbugs.gnu.org> Date: Mon, 23 Jun 2025 20:11:20 +0000 retitle 29153 25.3; Eshell can't quit when read-only commands have been run reassign 29153 emacs submitter 29153 Pierre Neidhardt severity 29153 minor tag 29153 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 06:18:17 2017 Received: (at submit) by debbugs.gnu.org; 5 Nov 2017 11:18:17 +0000 Received: from localhost ([127.0.0.1]:51250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBIwS-00048j-NL for submit@debbugs.gnu.org; Sun, 05 Nov 2017 06:18:16 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBIwR-00048Y-Uz for submit@debbugs.gnu.org; Sun, 05 Nov 2017 06:18:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBIwL-00011U-MT for submit@debbugs.gnu.org; Sun, 05 Nov 2017 06:18:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBIwL-00011G-HD for submit@debbugs.gnu.org; Sun, 05 Nov 2017 06:18:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBIwK-00015d-Ci for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 06:18:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBIwG-0000zw-95 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 06:18:08 -0500 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:53295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBIwG-0000zf-21 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 06:18:04 -0500 Received: by mail-wr0-x232.google.com with SMTP id u40so6038357wrf.10 for ; Sun, 05 Nov 2017 03:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=iphhyI37ZEbayzytNxl6pXqVN1rS+/qMLBl7tMUvQiA=; b=kecxoc+MwKv9vMieM+tkLnm0yzWiEDgt5Yk8fggKgPCGLbeaMBb2lipxMZmARn3Drz inh3P0ruHAmurYjHO6W2o+BjbX75FngKb82l1wb/tSAVG3CvM4qvgv19+ZON3FzgbF8v rDT0pAXySlPlVaIdGyivwx5yc0BmDOEUQi82te3b9NZpAbfnoROJrPAo7W2L7dwH4Zk9 whhaiT8fP4Ak4w1Yk37H5QEC15G9s6TOmg1l0fDAamwDpGA0UlmdZ1tziuzPf1ML1R80 5BRk1axSaYUHFt9+lukdirdKl7+GKMJjsNfud9V3zBF2stSlfh9Ks8eBtFr9W05AD02W k3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=iphhyI37ZEbayzytNxl6pXqVN1rS+/qMLBl7tMUvQiA=; b=przNwblBEVMss6AT2K5xLHN2vMLryeKCwWIYM6g73DUTwyhSLG5I9rlASufxnqsSZJ T/eM859uItc5czaGGIdn/E5P2fiFwgxjcXcGiMCh5HYDqFgcv8xuSKy0bHWoa600z6RC wZmr2AsXp66pIBNVubTwDYBYIbulTIgKQtZ3JKNJtKZmhUiTZxKAzJ8++DWeQVE+trDf ZQPjFBSq8M46yXkPUG1gbnzo8o3DMmTcxnlIhVr+jUPCDpwrGydjxY/WrgN1L1lZ9PpF TrImuu2ferlORPqDXa3Wg22xjnjQlrMPbMugYd5wrRTKkJDWSAw6nQkUTsn40kvi+hMV KnXQ== X-Gm-Message-State: AMCzsaXbOS+vSJZcPw/z5e7nqtv89xToA62LHds6mqdNuENWhSqS+Mle MMvKFzF0kDHRm2axuI/2DHtX5A== X-Google-Smtp-Source: ABhQp+QDP7w9ghRngRLAQKNOnCFodL8c5fBb4LUZZtw2ZmV/GdmHatyatLJnX0a5oQCVU5ep+czgVA== X-Received: by 10.223.167.76 with SMTP id e12mr9319560wrd.259.1509880682505; Sun, 05 Nov 2017 03:18:02 -0800 (PST) Received: from dhiov23k ([197.0.145.22]) by smtp.gmail.com with ESMTPSA id z192sm2950776wmc.32.2017.11.05.03.17.58 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 03:18:01 -0800 (PST) User-agent: mu4e 0.9.18; emacs 25.3.1 From: Pierre Neidhardt To: bug-gnu-emacs@gnu.org Subject: 25.3; Eshell can't quit when read-only commands have been run Date: Sun, 05 Nov 2017 12:17:53 +0100 Message-ID: <87y3nlrn32.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) - emacs -Q - M-x eshell - M-: (let ((prompt "echo foo")) (add-text-properties 0 (length prompt) '(read-only t font-lock-face eshell-prompt front-sticky (font-lock-face read-only) rear-nonsticky (font-lock-face read-only)) prompt) (insert prompt)) - RET - C-x k: "Text is read-only" Explanation: we run a read-only command and the read-only text is added to history. But in `eshell-write-history', `insert' will hit a wall when following read-only text: (let ((start (point))) (insert (ring-ref ring index) ?\n) And since `eshell-write-history' is run from the `kill-buffer-hook', the buffer cannot be killed. My suggested patch (let ((start (point)) (command (ring-ref ring index))) (remove-text-properties 0 (length command) '(read-only t) command) (insert command ?\n) This bug is especially annoying with a multiline prompt since accidentally pressing RET on any line of the prompt but the last will insert the read-only prompt into the history. In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.16) of 2017-11-05 built on dhiov23k Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 System Description: Gentoo Base System release 2.4.1 Configured using: 'configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/emacs-25.3 --htmldir=/usr/share/doc/emacs-25.3/html --libdir=/usr/lib64 --program-suffix=-emacs-25 --infodir=/usr/share/info/emacs-25 --localstatedir=/var --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp --with-gameuser=:gamestat --without-compress-install --with-file-notification=inotify --enable-acl --without-dbus --without-modules --without-gpm --without-hesiod --without-kerberos --without-kerberos5 --with-xml2 --without-selinux --with-gnutls --without-wide-int --with-zlib --with-sound=alsa --with-x --without-ns --without-gconf --without-gsettings --without-toolkit-scroll-bars --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xpm --with-imagemagick --with-xft --without-cairo --without-libotf --without-m17n-flt --with-x-toolkit=gtk3 --without-xwidgets GENTOO_PACKAGE=app-editors/emacs-25.3 'CFLAGS=-march=ivybridge -O2 -pipe' CPPFLAGS= 'LDFLAGS=-Wl,-O1 -Wl,--as-needed'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2 FREETYPE XFT ZLIB GTK3 X11 Important settings: value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 06:39:52 2017 Received: (at 29153) by debbugs.gnu.org; 5 Nov 2017 11:39:52 +0000 Received: from localhost ([127.0.0.1]:51279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBJHM-0004kv-GI for submit@debbugs.gnu.org; Sun, 05 Nov 2017 06:39:52 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:45524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBJHK-0004kY-38; Sun, 05 Nov 2017 06:39:50 -0500 Received: by mail-it0-f53.google.com with SMTP id n195so2193922itg.0; Sun, 05 Nov 2017 03:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eZlh8M057SVH+T6WQdht8pY16HEcE6cEfGiNTsdCNJk=; b=QzVNGPRZy8qRmPEO4yDi+sQHs9239wZ50WvFbHHMGLo6FFQPw/YAOgHzxTPDz/uZ8C lEZHiWBrSZF6RmFSVE/Y3gdEavJPIk/3+XFy8Y5XjKl1+AjoLTkt7Ng/3O6SWNlPr1my 9t2/ZfHc8blMMabNIjFtq4MvvjqBTRp2nSTrgELFLGmVnX47WoW7dDU8bTs9+0P2Llks C2DLnNne6fPdPXVnmecDzjL0+cu9CDRS0kCyCCvwhnOoG2TDzkypei8MAbsqs9J6OEbw H8sUP6ROh9SwEqb01h+bofN7u6D+pPDRgBKYr4d8MbF4xBESLMi6v9v+d+ySzgjzGXbv lV3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=eZlh8M057SVH+T6WQdht8pY16HEcE6cEfGiNTsdCNJk=; b=S+LcSglmfQ0jiIE5e8pSl3Fhmlcar9NKFGQvYGX6448PJRhzMhn3zzDCf7gCFz4NKJ vQTKmq0kVKNGhbDkhCQ6SYo+S/CzU7WNqM9TbVOuTjzMHGxk/Axf0U9wUOywJ673n2cY jTYZcZ0TuxeernYqwzxkJTf2i6LvgstTmhlVLF4DgAiDMxh1oEMrGZyGIBIzIVaHbWr9 PjDHaYov0+gIHa+Z7JDAv2gGH5Ty0b+xHpMOTR4Y0z6MUtqdB5Us93m58FiS4ZjaYg/O rTMFeMzZyyf6RAqVmTwQ2wM1r0tRSLVHisrm/dw5JyaZxA8MzXUMwkQKByGEG9GslvJS YxCg== X-Gm-Message-State: AJaThX6heUY5QhrM+zojctKuuObSXxLPb90/umOVRj9O8anryg47Z2o7 YcJOT1DcexlcuuPzF831Z9tsFA== X-Google-Smtp-Source: ABhQp+Tboy3/5uMDopRSAJNGA44Lw+QwI0EN5bAkFF/px3iw6UyZ25JxFOeDkviPCEV3/50lZNmuyw== X-Received: by 10.36.83.137 with SMTP id n131mr6018573itb.82.1509881984065; Sun, 05 Nov 2017 03:39:44 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id j71sm4142141itj.2.2017.11.05.03.39.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 03:39:43 -0800 (PST) From: Noam Postavsky To: Pierre Neidhardt Subject: Re: bug#29153: 25.3; Eshell can't quit when read-only commands have been run References: <87y3nlrn32.fsf@gmail.com> Date: Sun, 05 Nov 2017 06:39:42 -0500 In-Reply-To: <87y3nlrn32.fsf@gmail.com> (Pierre Neidhardt's message of "Sun, 05 Nov 2017 12:17:53 +0100") Message-ID: <87vaip6jk1.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29153 Cc: 29153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) close 29153 severity 29153 minor merge 29153 28700 quit Pierre Neidhardt writes: > - emacs -Q > > - M-x eshell > > - M-: > (let ((prompt "echo foo")) > (add-text-properties 0 (length prompt) > '(read-only t > font-lock-face eshell-prompt > front-sticky (font-lock-face read-only) > rear-nonsticky (font-lock-face read-only)) > prompt) > (insert prompt)) > > - RET > > - C-x k: "Text is read-only" This has been reported and fixed in #28700 "Cannot kill Eshell buffer". From unknown Mon Jun 23 13:11:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator