GNU bug report logs - #29152
[PATCH] gnu: uboot: Fix same-arch? check.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <m.othacehe <at> gmail.com>

Date: Sun, 5 Nov 2017 11:07:02 UTC

Severity: normal

Tags: fixed, patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29152 in the body.
You can then email your comments to 29152 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#29152; Package guix-patches. (Sun, 05 Nov 2017 11:07:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mathieu Othacehe <m.othacehe <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 05 Nov 2017 11:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] gnu: uboot: Fix same-arch? check.
Date: Sun,  5 Nov 2017 12:06:13 +0100

* gnu/packages/bootloaders.scm (make-u-boot-package): Compare %current-system
  to system associated to given triplet. Comparing a system and a triplet
  didn't make sense.
---
 gnu/packages/bootloaders.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index be3ea18fb..179e101fd 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -333,7 +333,8 @@ also initializes the boards (RAM etc).")
 
 (define (make-u-boot-package board triplet)
   "Returns a u-boot package for BOARD cross-compiled for TRIPLET."
-  (let ((same-arch? (if (string-prefix? (%current-system) triplet)
+  (let ((same-arch? (if (string-prefix? (%current-system)
+                                        (gnu-triplet->nix-system triplet))
                       `#t
                       `#f)))
     (package
-- 
2.15.0
Information forwarded to guix-patches <at> gnu.org:
bug#29152; Package guix-patches. (Sun, 05 Nov 2017 15:39:01 GMT) Full text and rfc822 format available.

Message #8 received at 29152 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 29152 <at> debbugs.gnu.org
Subject: Re: [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check.
Date: Sun, 5 Nov 2017 16:38:10 +0100

Good catch! LGTM!
Information forwarded to guix-patches <at> gnu.org:
bug#29152; Package guix-patches. (Mon, 06 Nov 2017 18:55:02 GMT) Full text and rfc822 format available.

Message #11 received at 29152 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 29152 <at> debbugs.gnu.org
Subject: Re: [bug#29152] [PATCH] gnu: uboot: Fix same-arch? check.
Date: Mon, 06 Nov 2017 19:54:36 +0100

> Good catch! LGTM!

Thanks Danny, pushed as 2ac42fe51fcbd9b9f36fcfce350da2d483dc0cc9.
Added tag(s) fixed. Request was from Mathieu Othacehe <m.othacehe <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 06 Nov 2017 19:05:03 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 29152 <at> debbugs.gnu.org and Mathieu Othacehe <m.othacehe <at> gmail.com> Request was from Mathieu Othacehe <m.othacehe <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 06 Nov 2017 19:05:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 05 Dec 2017 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 201 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.