GNU bug report logs - #29137
[PATCH] gnu: Add python-clf.

Previous Next

Full log

Message #8 received at 29137 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 29137 <at> debbugs.gnu.org
Subject: Re: [bug#29137] [PATCH] gnu: Add python-clf.
Date: Sun, 05 Nov 2017 17:16:45 +0100

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> * gnu/packages/web.scm (python-clf): New variable.

[...]

> +(define-public python-clf
> +  (package
> +    (name "python-clf")
> +    (version "0.5.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "clf" version))
> +       (sha256
> +        (base32
> +         "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-docopt" ,python-docopt)
> +       ("python-pygments" ,python-pygments)
> +       ("python-requests" ,python-requests)))
> +    (home-page "https://github.com/ncrocfer/clf")

I noticed in the '.travis.yml' that it has a test suite that can be run
with 'nosetests'.  Can you try overriding the check phase with one that
runs it?  That way we are likely to catch regressions early.

> +    (synopsis "Search code snippets on @url{commandlinefu.com}")
> +    (description "@code{clf} is a command line tool for searching code
> +snippets on @url{commandlinefu.com}")

Note: descriptions should end with a punctuation.  I think I'd also add
http:// to the @url{}s here for clarity.

The rest LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.