GNU bug report logs - #29137
[PATCH] gnu: Add python-clf.

Previous Next

Full log

Message #17 received at 29137 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29137 <at> debbugs.gnu.org
Subject: Re: [bug#29137] [PATCH] gnu: Add python-clf.
Date: Sun, 19 Nov 2017 18:14:28 +0100

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> Hello Marius,
>
> Apologies for the late reply and thank you for review!
>
> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>>
>>> * gnu/packages/web.scm (python-clf): New variable.
>>
>> [...]
>>
>>> +(define-public python-clf
>>> +  (package
>>> +    (name "python-clf")
>>> +    (version "0.5.7")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (pypi-uri "clf" version))
>>> +       (sha256
>>> +        (base32
>>> +         "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
>>> +    (build-system python-build-system)
>>> +    (propagated-inputs
>>> +     `(("python-docopt" ,python-docopt)
>>> +       ("python-pygments" ,python-pygments)
>>> +       ("python-requests" ,python-requests)))
>>> +    (home-page "https://github.com/ncrocfer/clf")
>>
>> I noticed in the '.travis.yml' that it has a test suite that can be run
>> with 'nosetests'.  Can you try overriding the check phase with one that
>> runs it?  That way we are likely to catch regressions early.
>
> Release tarball from pypi doesn't include test_clf.py.  So I pulled it
> from git master branch.  Almost all tests require internet connection.

Odd that this file would be taken out.  Anyway thanks for including it.
I wouldn't bother binding the package in a let for a variable that's
only used once as a native-input, but no strong opinion.  LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.