GNU bug report logs - #29104
[PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings

Previous Next

Full log

View this message in rfc822 format

From: Olaf Rogalsky <olaf.rogalsky <at> t-online.de>
To: 29104 <at> debbugs.gnu.org
Subject: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings
Date: Wed, 01 Nov 2017 14:45:32 +0100

1. emacs -Q -nw
2. M-x xterm-mouse-mode RET
3. mouse-1 click on the `*scratch*' string of the modeline.
4. Nothing happens. Expected behaviour would be, to change to the next buffer `*Messages*'.

This seems to be a bug in `keyboard.c:read_key_sequence'. After reading
the first characters of the xterm click event, they are remapped with
`keyremap_step' at line 9605 using the `input-decode-map'. The result of
this is a mouse-1 event structure, which carries the correct click
position. Unfortunately, this position isn't used, but instead, at line
9035, the position of the variable `first_event' is used.

The following patch sets `first_event' (after a key translation /
remapping) to the remapped event.

diff --git a/src/keyboard.c b/src/keyboard.c
index ee353d2b07..acb9c6be95 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -9607,6 +9607,8 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt,
 	  if (done)
 	    {
 	      mock_input = diff + max (t, mock_input);
+              first_event = mock_input > 0 ? keybuf[0] : Qnil;
+
 	      goto replay_sequence;
 	    }
 	}
@@ -9647,6 +9649,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt,
 		/* Adjust the input-decode-map counters.  */
 		indec.end += diff;
 		indec.start += diff;
+                first_event = mock_input > 0 ? keybuf[0] : Qnil;
 
 		goto replay_sequence;
 	      }
@@ -9669,6 +9672,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt,
 	      indec.start += diff;
 	      fkey.end += diff;
 	      fkey.start += diff;
+              first_event = mock_input > 0 ? keybuf[0] : Qnil;
 
 	      goto replay_sequence;
 	    }


-- 
Olaf Rogalsky
Schwörhausgasse 5
89073 Ulm
Germany

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.