From unknown Tue Jun 17 01:35:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29104 <29104@debbugs.gnu.org> To: bug#29104 <29104@debbugs.gnu.org> Subject: Status: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Reply-To: bug#29104 <29104@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:35:42 +0000 retitle 29104 [PATCH]: xterm-mouse-mode clicks in the modeline dont use the= keymap properties of the modeline strings reassign 29104 emacs submitter 29104 Olaf Rogalsky severity 29104 normal tag 29104 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 09:46:05 2017 Received: (at submit) by debbugs.gnu.org; 1 Nov 2017 13:46:05 +0000 Received: from localhost ([127.0.0.1]:45125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9tLJ-0005aP-I4 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:46:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9tLI-0005Zh-Fw for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9tLC-0004wB-4P for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:45:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9tLC-0004vq-27 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 09:45:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9tLA-0004af-Ux for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:45:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9tL7-0004p4-To for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:45:57 -0400 Received: from mailout11.t-online.de ([194.25.134.85]:60336) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9tL7-0004nO-Lv for bug-gnu-emacs@gnu.org; Wed, 01 Nov 2017 09:45:53 -0400 Received: from fwd26.aul.t-online.de (fwd26.aul.t-online.de [172.20.26.131]) by mailout11.t-online.de (Postfix) with SMTP id B8BAE4249F53 for ; Wed, 1 Nov 2017 14:45:50 +0100 (CET) Received: from blaubaer (E2uzUeZLwhZATZTdMxvJg7gvcPxXLD+Ffb+qTKuHbkwIkqftbd6F5vXGdTOYKuKZtN@[84.57.184.143]) by fwd26.t-online.de with (TLSv1.2:DHE-RSA-AES256-SHA256 encrypted) esmtp id 1e9tKz-40Rxh20; Wed, 1 Nov 2017 14:45:45 +0100 From: Olaf Rogalsky To: bug-gnu-emacs@gnu.org Subject: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Date: Wed, 01 Nov 2017 14:45:32 +0100 Message-ID: <87zi869koz.fsf@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-ID: E2uzUeZLwhZATZTdMxvJg7gvcPxXLD+Ffb+qTKuHbkwIkqftbd6F5vXGdTOYKuKZtN X-TOI-MSGID: fcdab738-b6a1-4e21-a03c-3a5f6af1f585 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) 1. emacs -Q -nw 2. M-x xterm-mouse-mode RET 3. mouse-1 click on the `*scratch*' string of the modeline. 4. Nothing happens. Expected behaviour would be, to change to the next bu= ffer `*Messages*'. This seems to be a bug in `keyboard.c:read_key_sequence'. After reading the first characters of the xterm click event, they are remapped with `keyremap_step' at line 9605 using the `input-decode-map'. The result of this is a mouse-1 event structure, which carries the correct click position. Unfortunately, this position isn't used, but instead, at line 9035, the position of the variable `first_event' is used. The following patch sets `first_event' (after a key translation / remapping) to the remapped event. diff --git a/src/keyboard.c b/src/keyboard.c index ee353d2b07..acb9c6be95 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -9607,6 +9607,8 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize= , Lisp_Object prompt, if (done) { mock_input =3D diff + max (t, mock_input); + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; + goto replay_sequence; } } @@ -9647,6 +9649,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize= , Lisp_Object prompt, /* Adjust the input-decode-map counters. */ indec.end +=3D diff; indec.start +=3D diff; + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 goto replay_sequence; } @@ -9669,6 +9672,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize= , Lisp_Object prompt, indec.start +=3D diff; fkey.end +=3D diff; fkey.start +=3D diff; + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 goto replay_sequence; } --=20 Olaf Rogalsky Schw=C3=B6rhausgasse 5 89073 Ulm Germany From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 18:48:19 2017 Received: (at submit) by debbugs.gnu.org; 6 Nov 2017 23:48:19 +0000 Received: from localhost ([127.0.0.1]:54894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBr7r-0000P8-BG for submit@debbugs.gnu.org; Mon, 06 Nov 2017 18:48:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBr7o-0000Ou-Dp for submit@debbugs.gnu.org; Mon, 06 Nov 2017 18:48:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBr7i-0000C0-93 for submit@debbugs.gnu.org; Mon, 06 Nov 2017 18:48:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBr7i-0000Bw-67 for submit@debbugs.gnu.org; Mon, 06 Nov 2017 18:48:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBr7g-00026O-MI for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 18:48:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBr7b-0000A4-Oz for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 18:48:08 -0500 Received: from mailout10.t-online.de ([194.25.134.21]:33976) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eBr7b-00009A-HV for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 18:48:03 -0500 Received: from fwd21.aul.t-online.de (fwd21.aul.t-online.de [172.20.27.66]) by mailout10.t-online.de (Postfix) with SMTP id F245741C2E5D for ; Tue, 7 Nov 2017 00:47:59 +0100 (CET) Received: from blaubaer (rAQ4LUZ6QhBN2ER9XyqZxIVc6vq8GOrgDI10HBjaR5IST1PTIpfiAC4p+4T4fzlZGC@[84.57.184.143]) by fwd21.t-online.de with (TLSv1.2:DHE-RSA-AES256-SHA256 encrypted) esmtp id 1eBr7T-0DtWE40; Tue, 7 Nov 2017 00:47:55 +0100 References: <87zi869koz.fsf@t-online.de> From: Olaf Rogalsky To: bug-gnu-emacs@gnu.org Subject: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings In-reply-to: <87zi869koz.fsf@t-online.de> Date: Tue, 07 Nov 2017 00:47:28 +0100 Message-ID: <877ev3nf5b.fsf@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-ID: rAQ4LUZ6QhBN2ER9XyqZxIVc6vq8GOrgDI10HBjaR5IST1PTIpfiAC4p+4T4fzlZGC X-TOI-MSGID: 1452233c-fb10-433c-a658-061bfe5838b5 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, I would like to give some more details on the patch and which problem it tries to solve. Ultimately I try to get better support of the mouse under xterm. The following features currently do not work with the mouse under xterm: 1. Mouse clicks on menu-bar always brings up the left-most menu, but not the menu under the spot. =20 2. A mouse click on the mode-line activates the window, but does not trigger the local-map property on the spot. 3. When moving the mouse over some text with a mouse-face property or help-echo property nothing happens, because xterm-mouse-mode does not receive any mouse motion events from the controlling xterm (except during dragging operations). I haven't looked into (1), but I am testing a solution for (2) and (3). This patch (#29104) addresses (2). It does not implement a new feature, but tries to make a bugfix to keyboard.c:read_key_sequence. This function is a 900 lines nightmare of spaggheti code, full of global state and goto's. At least it is somehow documented. But here we go, this is what I understood so far: The function reads input characters until some keybinding is found or until the sequence does not form a prefix key sequence anymore. If the trailing characters, which have been read so far, form a sequence in a translation keymap (input-decode-map, key-translation-map, local-function-key-map), those trailing characters are replaced by the binding of the translation map. Thereafter a jump back close to the beginning of the function is made and all events up to the replacement event are reinterpreted again. Such jumps ("goto replay_sequence;") take place immediately after the lines, which I introduced in the patch. When replaying the sequence, the variable "first_event" will be used to select the currently active keymaps (line 9035). In case, that the first characters are bound in a key translation map, first_event still holds (incrorrectly, as I presume) the first character of the translation sequence and not its binding. My patch takes place after a key translation has been performed. It checks, that the key translation is not empty, (or more precisely, that the current event sequence is not empty), first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 ^^^^^^^^^^^^^^ and if so, sets the variable first_event to the first event in the sequence. first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 ^^^^^^^^^ Here, all key translations where allready replaced by their corresponding binding. If the current event sequence is empty, first_event is set to Qnil, which means that the default active keymaps should be used. This would be the case, if the raw key sequence was bound to an empty vector in a translation map. first_event =3D mock_input > 0 ? keybuf[0] : Qnil; =20 ^^^^ Now back to my original problem: mouse clicks in the mode line do not work correctly. xterm-mouse-mode uses the input-decode-map to translate special character sequences coming from xterm (starting with "\e[") into proper mouse events. Without the patch, first_event is set to ?\e. Therefore the esc-map is used to find a binding for the mouse event, which of cause does not work as intended. With the patch, first_event is set to the mouse event and the binding in the local-map property will be found. Et vola, mouse clicks in the mode line will work :-) Olaf PS: You might ask, why I check for empty key translations. I need those for (3). --=20 Olaf Rogalsky Schw=C3=B6rhausgasse 5 89073 Ulm Germany From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 11 04:44:37 2017 Received: (at 29104) by debbugs.gnu.org; 11 Nov 2017 09:44:37 +0000 Received: from localhost ([127.0.0.1]:34730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDSL7-0007ZL-FQ for submit@debbugs.gnu.org; Sat, 11 Nov 2017 04:44:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDSL5-0007Z5-PB for 29104@debbugs.gnu.org; Sat, 11 Nov 2017 04:44:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDSKx-0004j9-C2 for 29104@debbugs.gnu.org; Sat, 11 Nov 2017 04:44:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDSKx-0004j5-8U; Sat, 11 Nov 2017 04:44:27 -0500 Received: from [176.228.60.248] (port=1860 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eDSKw-0000jg-0u; Sat, 11 Nov 2017 04:44:26 -0500 Date: Sat, 11 Nov 2017 11:44:25 +0200 Message-Id: <83375lp2ti.fsf@gnu.org> From: Eli Zaretskii To: Olaf Rogalsky In-reply-to: <877ev3nf5b.fsf@t-online.de> (message from Olaf Rogalsky on Tue, 07 Nov 2017 00:47:28 +0100) Subject: Re: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29104 Cc: 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Olaf Rogalsky > Date: Tue, 07 Nov 2017 00:47:28 +0100 > > My patch takes place after a key translation has been performed. It > checks, that the key translation is not empty, (or more precisely, that > the current event sequence is not empty), > > first_event = mock_input > 0 ? keybuf[0] : Qnil; > ^^^^^^^^^^^^^^ > > and if so, sets the variable first_event to the first event in the > sequence. > > first_event = mock_input > 0 ? keybuf[0] : Qnil; > ^^^^^^^^^ > > Here, all key translations where allready replaced by their > corresponding binding. If the current event sequence is empty, > first_event is set to Qnil, which means that the default active keymaps > should be used. This would be the case, if the raw key sequence was > bound to an empty vector in a translation map. > > first_event = mock_input > 0 ? keybuf[0] : Qnil; > ^^^^ > > Now back to my original problem: mouse clicks in the mode line do not > work correctly. xterm-mouse-mode uses the input-decode-map to translate > special character sequences coming from xterm (starting with "\e[") into > proper mouse events. Without the patch, first_event is set to ?\e. > Therefore the esc-map is used to find a binding for the mouse event, > which of cause does not work as intended. With the patch, first_event is > set to the mouse event and the binding in the local-map property will be > found. > > Et vola, mouse clicks in the mode line will work :-) Thanks for the detailed explanations, they help a lot. I have a few questions. First, why did you need this hunk: > @@ -9669,6 +9672,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt, > indec.start += diff; > fkey.end += diff; > fkey.start += diff; > + first_event = mock_input > 0 ? keybuf[0] : Qnil; > > goto replay_sequence; > } This is no longer about input-decode-map, it's about key-translation-map. And xterm-mouse-mode doesn't use key-translation-map, so why change this part? The next question is whether this patch caters correctly to features other than xterm-mouse-mode. The input-decode-map is used by terminal-specific support in xterm.el and rxvt.el -- does it still make sense to use keybuf[0] as first_event for replaying their sequences? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 06:33:28 2017 Received: (at 29104) by debbugs.gnu.org; 13 Nov 2017 11:33:28 +0000 Received: from localhost ([127.0.0.1]:37767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eECzY-0000pb-6M for submit@debbugs.gnu.org; Mon, 13 Nov 2017 06:33:28 -0500 Received: from mailout01.t-online.de ([194.25.134.80]:45720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eECzU-0000pO-3N for 29104@debbugs.gnu.org; Mon, 13 Nov 2017 06:33:24 -0500 Received: from fwd32.aul.t-online.de (fwd32.aul.t-online.de [172.20.26.144]) by mailout01.t-online.de (Postfix) with SMTP id 8B68F4293D43; Mon, 13 Nov 2017 12:33:22 +0100 (CET) Received: from spica03.aul.t-online.de (bHYbvkZ68hkJoNR50CK18AhEPjB7R1-rce2f3Rx73OYWwL7ZMuynBSMmDbFgHF0wbk@[172.20.102.123]) by fwd32.aul.t-online.de with esmtp id 1eECzR-3XCB6G0; Mon, 13 Nov 2017 12:33:21 +0100 Received: from 217.110.38.73:59486 by cmpweb22.aul.t-online.de with HTTP/1.1 (Lisa V5-0-9-0.14224 on API V5-9-1-0) Received: from 172.20.102.139:17985 by spica03.aul.t-online.de:8080; Mon, 13 Nov 2017 12:33:21 +0100 (CET) Date: Mon, 13 Nov 2017 12:33:21 +0100 (CET) From: "olaf.rogalsky@t-online.de" To: Eli Zaretskii Message-ID: <1510572801278.7660021.f3bdf04b3d0dd2a87536d25ce5112b1444520733@spica.telekom.de> In-Reply-To: <83375lp2ti.fsf@gnu.org> References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> Subject: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Importance: normal X-MSMail-Priority: normal X-Priority: 3 X-UMS: email X-ID: bHYbvkZ68hkJoNR50CK18AhEPjB7R1-rce2f3Rx73OYWwL7ZMuynBSMmDbFgHF0wbk@t-dialin.net X-TOI-MSGID: 5dced8b6-182a-4d85-a8cf-7c209ae25667 X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 29104 Cc: "29104@debbugs.gnu.org" <29104@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "olaf.rogalsky@t-online.de" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > This is no longer about input-decode-map, it's about > key-translation-map. And xterm-mouse-mode doesn't use > key-translation-map, so why change this part? This hunk, and the hunk @@ -9647,6 +9649,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt, /* Adjust the input-decode-map counters. */ indec.end +=3D diff; indec.start +=3D diff; + first_event =3D mock_input > 0 ? keybuf[0] : Qnil; goto replay_sequence; } are actually unrelated to xterm-mouse and where included for symmetry, only. But I still think, its correct to do so: After initialization, the only place where first_event is set, is at line 9282: if (NILP (first_event)) { first_event =3D key; Unfortunately, this line is not reached during the replay of a key translation (either input-decode-map or key-translation-map). So after a key translation, ideally one should check, if the first key of the key sequence was translated, and set first_event accordingly. But since keybuf[0] holds the first event in any case, I set first_event unconditionally to keybuf[0]. The reason, why this bug has not been recognized so far is, that the only use of first_event is as an argument to the function active_maps. In that function, first_event is ignored, if it is not a mouse event. Afaik,translations, which result in mouse events, are only generated xterm-mouse. Summarizing, I believe, it does no harm to also set first_event after a key-translation-map, but I included these to hunks for consistency only. I would understand you, if you fear, that we might not fully understand its consequences. > The next question is whether this patch caters correctly to features > other than xterm-mouse-mode. The input-decode-map is used by > terminal-specific support in xterm.el and rxvt.el -- does it still > make sense to use keybuf[0] as first_event for replaying their > sequences? Yes I think so. As mentioned before, the only use of first_event is, in active_maps(first_event), which prepends the active maps with the local-map property after a mouse click. If first_event is not a mouse event, its particular value is ignored. xterm.el and rxvt.el do not generate mouse events and are therefore not affected (but even if they did, setting first_event to keybuf[0] would still be the right thing). Just for reference, this is the definition of active_maps(): static Lisp_Object active_maps (Lisp_Object first_event) { Lisp_Object position =3D CONSP (first_event) ? CAR_SAFE (XCDR (first_event)) : Qnil; | | | check for compound get mouse position otherwise ignor= e event (mouse click) first_event return Fcons (Qkeymap, Fcurrent_active_maps (Qt, position)); } Olaf =EF=BB=BF ---------------------------------------------------------------- Gesendet mit Telekom Mail - kostenlos= und sicher f=C3=BCr alle! From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 13 08:57:59 2017 Received: (at 29104) by debbugs.gnu.org; 13 Nov 2017 13:57:59 +0000 Received: from localhost ([127.0.0.1]:37870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEFFP-00064Y-5T for submit@debbugs.gnu.org; Mon, 13 Nov 2017 08:57:59 -0500 Received: from mailout01.t-online.de ([194.25.134.80]:44520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEFFN-00064Q-6G for 29104@debbugs.gnu.org; Mon, 13 Nov 2017 08:57:57 -0500 Received: from fwd07.aul.t-online.de (fwd07.aul.t-online.de [172.20.27.150]) by mailout01.t-online.de (Postfix) with SMTP id EB44742B79F7; Mon, 13 Nov 2017 14:57:54 +0100 (CET) Received: from spica10.aul.t-online.de (Zwe5AyZ6YhNu0py5jvVjLcdh4uAH8ls5dE31dzFb2Yx7QC5UsCACuKJl+Y3Bm0+wR2@[172.20.102.125]) by fwd07.aul.t-online.de with esmtp id 1eEFFK-3fwRXs0; Mon, 13 Nov 2017 14:57:54 +0100 Received: from 217.110.38.73:64857 by cmpweb22.aul.t-online.de with HTTP/1.1 (Lisa V5-0-9-0.14224 on API V5-9-1-0) Received: from 172.20.102.126:51841 by spica10.aul.t-online.de:8080; Mon, 13 Nov 2017 14:57:54 +0100 (CET) Date: Mon, 13 Nov 2017 14:57:54 +0100 (CET) From: "olaf.rogalsky@t-online.de" To: Eli Zaretskii Message-ID: <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> In-Reply-To: <83375lp2ti.fsf@gnu.org> References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> Subject: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Importance: normal X-MSMail-Priority: normal X-Priority: 3 X-UMS: email X-ID: Zwe5AyZ6YhNu0py5jvVjLcdh4uAH8ls5dE31dzFb2Yx7QC5UsCACuKJl+Y3Bm0+wR2@t-dialin.net X-TOI-MSGID: 7afdce47-d9f2-4abe-a547-fff0f6f3b0b2 X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 29104 Cc: "29104@debbugs.gnu.org" <29104@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "olaf.rogalsky@t-online.de" Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In a more radical approach and instead of my original patch, one can get ri= d off with the variable first_event all together, see patch below. It simplifies = the code a little bit, but of course is more risky. Olaf diff --git a/src/keyboard.c b/src/keyboard.c index ee353d2..8df43b8 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -8916,7 +8916,6 @@ static void process_tool_bar_item (Lisp_Object, Lisp_= Object, Lisp_Object, ptrdiff_t keys_start; =20 Lisp_Object current_binding =3D Qnil; - Lisp_Object first_event =3D Qnil; =20 /* Index of the first key that has no binding. It is useless to try fkey.start larger than that. */ @@ -9032,7 +9031,7 @@ static void process_tool_bar_item (Lisp_Object, Lisp_= Object, Lisp_Object, keybuf with its symbol, or if the sequence starts with a mouse click and we need to switch buffers, we jump back here to rebuild the initial keymaps from the current buffer. */ - current_binding =3D active_maps (first_event); + current_binding =3D active_maps (mock_input > 0 ? keybuf[0] : Qnil); =20 /* Start from the beginning in keybuf. */ t =3D 0; @@ -9279,10 +9278,9 @@ static void process_tool_bar_item (Lisp_Object, Lisp= _Object, Lisp_Object, } } =20 - if (NILP (first_event)) + if (t =3D=3D 0) { - first_event =3D key; - /* Even if first_event does not specify a particular + /* Even if key does not specify a particular window/position, it's important to recompute the maps here since a long time might have passed since we entered read_key_sequence, and a timer (or process-filter or @@ -9292,7 +9290,7 @@ static void process_tool_bar_item (Lisp_Object, Lisp_= Object, Lisp_Object, && (XBUFFER (XWINDOW (selected_window)->contents) !=3D current_buffer)) Fset_buffer (XWINDOW (selected_window)->contents); - current_binding =3D active_maps (first_event); + current_binding =3D active_maps (key); } =20 GROW_RAW_KEYBUF; =EF=BB=BF ---------------------------------------------------------------- Gesendet mit Telekom Mail - kostenlos= und sicher f=C3=BCr alle! From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 18 04:53:22 2017 Received: (at 29104) by debbugs.gnu.org; 18 Nov 2017 09:53:22 +0000 Received: from localhost ([127.0.0.1]:45559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFzoQ-0008K6-8Z for submit@debbugs.gnu.org; Sat, 18 Nov 2017 04:53:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFzoN-0008Js-T7 for 29104@debbugs.gnu.org; Sat, 18 Nov 2017 04:53:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFzoE-0003f4-Sr for 29104@debbugs.gnu.org; Sat, 18 Nov 2017 04:53:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFzoE-0003ey-Oj; Sat, 18 Nov 2017 04:53:10 -0500 Received: from [176.228.60.248] (port=4491 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eFzoD-0005N2-MF; Sat, 18 Nov 2017 04:53:10 -0500 Date: Sat, 18 Nov 2017 11:52:56 +0200 Message-Id: <83y3n3gbgn.fsf@gnu.org> From: Eli Zaretskii To: Olaf Rogalsky , Stefan Monnier In-reply-to: <877ev3nf5b.fsf@t-online.de> (message from Olaf Rogalsky on Tue, 07 Nov 2017 00:47:28 +0100) Subject: Re: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29104 Cc: 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Olaf Rogalsky > Date: Tue, 07 Nov 2017 00:47:28 +0100 > > I would like to give some more details on the patch and which problem it > tries to solve. > > Ultimately I try to get better support of the mouse under xterm. The > following features currently do not work with the mouse under xterm: > > 1. Mouse clicks on menu-bar always brings up the left-most menu, but not > the menu under the spot. > > 2. A mouse click on the mode-line activates the window, but does not > trigger the local-map property on the spot. > > 3. When moving the mouse over some text with a mouse-face property or > help-echo property nothing happens, because xterm-mouse-mode does not > receive any mouse motion events from the controlling xterm (except > during dragging operations). > > I haven't looked into (1), but I am testing a solution for (2) and (3). > > This patch (#29104) addresses (2). It does not implement a new feature, > but tries to make a bugfix to keyboard.c:read_key_sequence. This > function is a 900 lines nightmare of spaggheti code, full of global > state and goto's. At least it is somehow documented. > > But here we go, this is what I understood so far: > > The function reads input characters until some keybinding is found or > until the sequence does not form a prefix key sequence anymore. If the > trailing characters, which have been read so far, form a sequence in a > translation keymap (input-decode-map, key-translation-map, > local-function-key-map), those trailing characters are replaced by the > binding of the translation map. Thereafter a jump back close to the > beginning of the function is made and all events up to the replacement > event are reinterpreted again. > > Such jumps ("goto replay_sequence;") take place immediately after the > lines, which I introduced in the patch. When replaying the sequence, > the variable "first_event" will be used to select the currently active > keymaps (line 9035). In case, that the first characters are bound in a > key translation map, first_event still holds (incrorrectly, as I > presume) the first character of the translation sequence and not its > binding. > > My patch takes place after a key translation has been performed. It > checks, that the key translation is not empty, (or more precisely, that > the current event sequence is not empty), > > first_event = mock_input > 0 ? keybuf[0] : Qnil; > ^^^^^^^^^^^^^^ > > and if so, sets the variable first_event to the first event in the > sequence. > > first_event = mock_input > 0 ? keybuf[0] : Qnil; > ^^^^^^^^^ > > Here, all key translations where allready replaced by their > corresponding binding. If the current event sequence is empty, > first_event is set to Qnil, which means that the default active keymaps > should be used. This would be the case, if the raw key sequence was > bound to an empty vector in a translation map. > > first_event = mock_input > 0 ? keybuf[0] : Qnil; > ^^^^ > > Now back to my original problem: mouse clicks in the mode line do not > work correctly. xterm-mouse-mode uses the input-decode-map to translate > special character sequences coming from xterm (starting with "\e[") into > proper mouse events. Without the patch, first_event is set to ?\e. > Therefore the esc-map is used to find a binding for the mouse event, > which of cause does not work as intended. With the patch, first_event is > set to the mouse event and the binding in the local-map property will be > found. > > Et vola, mouse clicks in the mode line will work :-) Stefan, any comments? I'm thinking of installing this on master. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 18 09:43:38 2017 Received: (at 29104) by debbugs.gnu.org; 18 Nov 2017 14:43:39 +0000 Received: from localhost ([127.0.0.1]:45669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG4LK-0008NC-P9 for submit@debbugs.gnu.org; Sat, 18 Nov 2017 09:43:38 -0500 Received: from pmta31.teksavvy.com ([76.10.157.38]:51406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eG4LI-0008Mx-2j for 29104@debbugs.gnu.org; Sat, 18 Nov 2017 09:43:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EeCwDTRRBa/3HQSC1bGwEBAQEDAQEBC?= =?us-ascii?q?QEBAYM8gVSOLI9CgX2Yc4VFAoRnQxQBAQEBAQEBAQEDaCiFIAEEAXkFCwsNJwc?= =?us-ascii?q?LFBgxijAIrB4hAopWAQEBAQYCASWDNIIHhmmLEwWTCI82oH8ohzGXbDYjgXQ0I?= =?us-ascii?q?Qgygy6DEIFsI4tJAQEB?= X-IPAS-Result: =?us-ascii?q?A2EeCwDTRRBa/3HQSC1bGwEBAQEDAQEBCQEBAYM8gVSOLI9?= =?us-ascii?q?CgX2Yc4VFAoRnQxQBAQEBAQEBAQEDaCiFIAEEAXkFCwsNJwcLFBgxijAIrB4hA?= =?us-ascii?q?opWAQEBAQYCASWDNIIHhmmLEwWTCI82oH8ohzGXbDYjgXQ0IQgygy6DEIFsI4t?= =?us-ascii?q?JAQEB?= X-IronPort-AV: E=Sophos;i="5.44,415,1505793600"; d="scan'208";a="9291793" Received: from unknown (HELO pastel.home) ([45.72.208.113]) by smtp.teksavvy.com with ESMTP; 18 Nov 2017 09:43:30 -0500 Received: by pastel.home (Postfix, from userid 20848) id 387B360770; Sat, 18 Nov 2017 09:43:30 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Message-ID: References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83y3n3gbgn.fsf@gnu.org> Date: Sat, 18 Nov 2017 09:43:30 -0500 In-Reply-To: <83y3n3gbgn.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Nov 2017 11:52:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29104 Cc: Olaf Rogalsky , 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> This patch (#29104) addresses (2). It does not implement a new feature, >> but tries to make a bugfix to keyboard.c:read_key_sequence. This >> function is a 900 lines nightmare of spaggheti code, full of global >> state and goto's. At least it is somehow documented. Oh, yes, the number of lines has fluctuated a bit, but it's been a nightmare ever since I first saw it. I'm impressed you found the stamina to dig into it. > Stefan, any comments? I'm thinking of installing this on master. I'll take a look at it later this week-end (it will take some time for me to re-understand the code ;-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 18 23:25:03 2017 Received: (at 29104-done) by debbugs.gnu.org; 19 Nov 2017 04:25:03 +0000 Received: from localhost ([127.0.0.1]:46706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGHAF-00068G-10 for submit@debbugs.gnu.org; Sat, 18 Nov 2017 23:25:03 -0500 Received: from pmta21.teksavvy.com ([76.10.157.36]:45758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGHAD-00067i-0k for 29104-done@debbugs.gnu.org; Sat, 18 Nov 2017 23:25:01 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EDBQCZBhFa/3HQSC1bHAEBAQQBAQoBA?= =?us-ascii?q?YM8gVSdbYF9FJhfCoU7AoRnQxQBAQEBAQEBAQEDaCiFIAEEAXkFCwsNJwcLFBg?= =?us-ascii?q?xijAIq2MhAopPAQEBAQEFAgElgzSCB4ZpixMFkwiPNqB/KIcxljKBOjYjgXQ0I?= =?us-ascii?q?QgySYJlglscGYFsI4w0AQEB?= X-IPAS-Result: =?us-ascii?q?A2EDBQCZBhFa/3HQSC1bHAEBAQQBAQoBAYM8gVSdbYF9FJh?= =?us-ascii?q?fCoU7AoRnQxQBAQEBAQEBAQEDaCiFIAEEAXkFCwsNJwcLFBgxijAIq2MhAopPA?= =?us-ascii?q?QEBAQEFAgElgzSCB4ZpixMFkwiPNqB/KIcxljKBOjYjgXQ0IQgySYJlglscGYF?= =?us-ascii?q?sI4w0AQEB?= X-IronPort-AV: E=Sophos;i="5.44,419,1505793600"; d="scan'208";a="9358894" Received: from unknown (HELO fmsmemgm.homelinux.net) ([45.72.208.113]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2017 23:24:50 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 75E64AE0E4; Sat, 18 Nov 2017 23:24:49 -0500 (EST) From: Stefan Monnier To: "olaf.rogalsky\@t-online.de" Subject: Re: bug#29104: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Message-ID: References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> Date: Sat, 18 Nov 2017 23:24:49 -0500 In-Reply-To: <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> (olaf's message of "Mon, 13 Nov 2017 14:57:54 +0100 (CET)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29104-done Cc: "29104@debbugs.gnu.org" <29104-done@debbugs.gnu.org>, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > In a more radical approach and instead of my original patch, one can > get rid off with the variable first_event all together, see patch > below. It simplifies the code a little bit, but of course is > more risky. Indeed, I got a similar patch (see below) by simply moving your assignment to first_event from "before the `goto replay_sequence`" to after it (i.e. after the replay_sequence label). Your patch looks about as good as mine. I think they're both better than your first patch because they fix the problem in a single place (The Right Place). I installed mine because it's shorter and looks more "obviously safe" to me. Thanks a lot for tracking it down! Stefan diff --git a/src/keyboard.c b/src/keyboard.c index 399149ae97..6b7a6bfa74 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -8919,7 +8919,6 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt, ptrdiff_t keys_start; Lisp_Object current_binding = Qnil; - Lisp_Object first_event = Qnil; /* Index of the first key that has no binding. It is useless to try fkey.start larger than that. */ @@ -9029,6 +9028,7 @@ read_key_sequence (Lisp_Object *keybuf, int bufsize, Lisp_Object prompt, starting_buffer = current_buffer; first_unbound = bufsize + 1; + Lisp_Object first_event = mock_input > 0 ? keybuf[0] : Qnil; /* Build our list of keymaps. If we recognize a function key and replace its escape sequence in From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 19 10:50:35 2017 Received: (at 29104) by debbugs.gnu.org; 19 Nov 2017 15:50:36 +0000 Received: from localhost ([127.0.0.1]:47690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGRrf-0003LC-Nk for submit@debbugs.gnu.org; Sun, 19 Nov 2017 10:50:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGRre-0003Kz-0Z for 29104@debbugs.gnu.org; Sun, 19 Nov 2017 10:50:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGRrW-00047y-7I for 29104@debbugs.gnu.org; Sun, 19 Nov 2017 10:50:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGRrW-00047u-3n; Sun, 19 Nov 2017 10:50:26 -0500 Received: from [176.228.60.248] (port=1943 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eGRrV-00063W-FQ; Sun, 19 Nov 2017 10:50:25 -0500 Date: Sun, 19 Nov 2017 17:50:15 +0200 Message-Id: <83y3n2e094.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sat, 18 Nov 2017 23:24:49 -0500) Subject: Re: bug#29104: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29104 Cc: olaf.rogalsky@t-online.de, 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: Eli Zaretskii , "29104\@debbugs.gnu.org" <29104-done@debbugs.gnu.org> > Date: Sat, 18 Nov 2017 23:24:49 -0500 > > Your patch looks about as good as mine. I think they're both better > than your first patch because they fix the problem in a single place > (The Right Place). > > I installed mine because it's shorter and looks more "obviously safe" > to me. Thanks a lot for tracking it down! Thanks, but why in the world on the release branch?? I said I was thinking of installing this on master, not on emacs-26. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 19 16:14:21 2017 Received: (at 29104-done) by debbugs.gnu.org; 19 Nov 2017 21:14:21 +0000 Received: from localhost ([127.0.0.1]:47992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWuz-0002J0-HC for submit@debbugs.gnu.org; Sun, 19 Nov 2017 16:14:21 -0500 Received: from mailout03.t-online.de ([194.25.134.81]:51388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGWux-0002Ir-Hu for 29104-done@debbugs.gnu.org; Sun, 19 Nov 2017 16:14:19 -0500 Received: from fwd01.aul.t-online.de (fwd01.aul.t-online.de [172.20.27.147]) by mailout03.t-online.de (Postfix) with SMTP id 4294042A915C; Sun, 19 Nov 2017 22:14:18 +0100 (CET) Received: from blaubaer (VOjMx+ZH8heieh5N15GEwKPryoINRgte0S8VVR3GtMDUCxxbr+EX5wm+6auLviXwBB@[88.72.253.221]) by fwd01.t-online.de with (TLSv1.2:DHE-RSA-AES256-SHA256 encrypted) esmtp id 1eGWuv-3tszJI0; Sun, 19 Nov 2017 22:14:17 +0100 References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> From: Olaf Rogalsky To: Stefan Monnier Subject: Re: bug#29104: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings In-reply-to: Date: Sun, 19 Nov 2017 22:14:16 +0100 Message-ID: <877eum55uf.fsf@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ID: VOjMx+ZH8heieh5N15GEwKPryoINRgte0S8VVR3GtMDUCxxbr+EX5wm+6auLviXwBB X-TOI-MSGID: 215173c3-3401-441f-9623-1dc5a29c86e7 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29104-done Cc: "29104@debbugs.gnu.org" <29104-done@debbugs.gnu.org>, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > I installed mine because it's shorter and looks more "obviously safe" > to me. Thanks a lot for tracking it down! Thanks for installing the patch and closing the bug! -- Olaf Rogalsky Schwörhausgasse 5 89073 Ulm Germany From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 08:26:22 2017 Received: (at 29104) by debbugs.gnu.org; 20 Nov 2017 13:26:22 +0000 Received: from localhost ([127.0.0.1]:48374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGm5e-0004xr-5R for submit@debbugs.gnu.org; Mon, 20 Nov 2017 08:26:22 -0500 Received: from pmta21.teksavvy.com ([76.10.157.36]:34722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGm5c-0004xe-SK for 29104@debbugs.gnu.org; Mon, 20 Nov 2017 08:26:21 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2E5ZgCA1xJa/3HQSC1bHAEBAQQBAQoBA?= =?us-ascii?q?YM8gVSOLI9BgX2Yc4VFAoR6QxQBAQEBAQEBAQEDaCiFIAEEAXkFCwsNJwcLFBg?= =?us-ascii?q?xijAIqw0hAopQAQEBAQYCASWDNIIHhmmLEwWTCI82j0OHRgE4iT0ohzGXbDYjg?= =?us-ascii?q?XQ0IQgygy6CWxwZgWwjjAYBAQE?= X-IPAS-Result: =?us-ascii?q?A2E5ZgCA1xJa/3HQSC1bHAEBAQQBAQoBAYM8gVSOLI9BgX2?= =?us-ascii?q?Yc4VFAoR6QxQBAQEBAQEBAQEDaCiFIAEEAXkFCwsNJwcLFBgxijAIqw0hAopQA?= =?us-ascii?q?QEBAQYCASWDNIIHhmmLEwWTCI82j0OHRgE4iT0ohzGXbDYjgXQ0IQgygy6CWxw?= =?us-ascii?q?ZgWwjjAYBAQE?= X-IronPort-AV: E=Sophos;i="5.44,427,1505793600"; d="scan'208";a="9435148" Received: from unknown (HELO pastel.home) ([45.72.208.113]) by smtp.teksavvy.com with ESMTP; 20 Nov 2017 08:26:10 -0500 Received: by pastel.home (Postfix, from userid 20848) id 1B0EE614F0; Mon, 20 Nov 2017 08:26:10 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#29104: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Message-ID: References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> <83y3n2e094.fsf@gnu.org> Date: Mon, 20 Nov 2017 08:26:10 -0500 In-Reply-To: <83y3n2e094.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Nov 2017 17:50:15 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29104 Cc: olaf.rogalsky@t-online.de, 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Thanks, but why in the world on the release branch?? I said I was > thinking of installing this on master, not on emacs-26. Sorry, I didn't notice this part, I just assumed you wanted this on emacs-26, even tho in retrospect I see it's not particularly urgent. Do you want me to move it to master? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 12:15:57 2017 Received: (at 29104) by debbugs.gnu.org; 20 Nov 2017 17:15:57 +0000 Received: from localhost ([127.0.0.1]:49263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGpfp-00021S-IG for submit@debbugs.gnu.org; Mon, 20 Nov 2017 12:15:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGpfo-00021G-AR for 29104@debbugs.gnu.org; Mon, 20 Nov 2017 12:15:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGpff-0004Yc-2j for 29104@debbugs.gnu.org; Mon, 20 Nov 2017 12:15:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGpfe-0004YU-Uy; Mon, 20 Nov 2017 12:15:46 -0500 Received: from [176.228.60.248] (port=2890 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eGpfe-0004KW-93; Mon, 20 Nov 2017 12:15:46 -0500 Date: Mon, 20 Nov 2017 19:15:39 +0200 Message-Id: <83efoseuro.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Mon, 20 Nov 2017 08:26:10 -0500) Subject: Re: bug#29104: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> <83y3n2e094.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29104 Cc: olaf.rogalsky@t-online.de, 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: olaf.rogalsky@t-online.de, 29104@debbugs.gnu.org > Date: Mon, 20 Nov 2017 08:26:10 -0500 > > > Thanks, but why in the world on the release branch?? I said I was > > thinking of installing this on master, not on emacs-26. > > Sorry, I didn't notice this part, I just assumed you wanted this on > emacs-26, even tho in retrospect I see it's not particularly urgent. Mistakes happen. Sorry for not being more clear on that. > Do you want me to move it to master? Yes, please, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 13:06:30 2017 Received: (at 29104) by debbugs.gnu.org; 20 Nov 2017 18:06:30 +0000 Received: from localhost ([127.0.0.1]:49321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGqSi-0003I1-Pg for submit@debbugs.gnu.org; Mon, 20 Nov 2017 13:06:29 -0500 Received: from pmta31.teksavvy.com ([76.10.157.38]:27934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGqSg-0003Hj-UG for 29104@debbugs.gnu.org; Mon, 20 Nov 2017 13:06:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2F8FAAqGRNa/3HQSC1bHAEBAQQBAQoBA?= =?us-ascii?q?YM8gVSDW4pRj0GBfZhzhUUChH9DFAEBAQEBAQEBAQNoKIUgAQQBeQULCw0nBws?= =?us-ascii?q?UGDGKMAiqeyECilIBAQEBBgIBJYM0ggeGaYsTBZMIjzaXCQEYhgyDUSiHMZdsN?= =?us-ascii?q?iOBdDQhCDKDLoMQgWwjjAIBAQE?= X-IPAS-Result: =?us-ascii?q?A2F8FAAqGRNa/3HQSC1bHAEBAQQBAQoBAYM8gVSDW4pRj0G?= =?us-ascii?q?BfZhzhUUChH9DFAEBAQEBAQEBAQNoKIUgAQQBeQULCw0nBwsUGDGKMAiqeyECi?= =?us-ascii?q?lIBAQEBBgIBJYM0ggeGaYsTBZMIjzaXCQEYhgyDUSiHMZdsNiOBdDQhCDKDLoM?= =?us-ascii?q?QgWwjjAIBAQE?= X-IronPort-AV: E=Sophos;i="5.44,429,1505793600"; d="scan'208";a="9431217" Received: from unknown (HELO pastel.home) ([45.72.208.113]) by smtp.teksavvy.com with ESMTP; 20 Nov 2017 13:06:21 -0500 Received: by pastel.home (Postfix, from userid 20848) id DFDF3614F0; Mon, 20 Nov 2017 13:06:20 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#29104: AW: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Message-ID: References: <87zi869koz.fsf@t-online.de> <877ev3nf5b.fsf@t-online.de> <83375lp2ti.fsf@gnu.org> <1510581474048.7762584.ec34b569bff8873067a3b84e08b73b2215d5dd1a@spica.telekom.de> <83y3n2e094.fsf@gnu.org> <83efoseuro.fsf@gnu.org> Date: Mon, 20 Nov 2017 13:06:20 -0500 In-Reply-To: <83efoseuro.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Nov 2017 19:15:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 29104 Cc: olaf.rogalsky@t-online.de, 29104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Yes, please, and thanks. Done, Stefan From unknown Tue Jun 17 01:35:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator