GNU bug report logs - #29102
FAIL: make check-system TESTS="btrfs-root-os" not enough space

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29102 in the body.
You can then email your comments to 29102 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: FAIL: make check-system TESTS="btrfs-root-os" not enough space
Date: Wed, 01 Nov 2017 15:27:39 +0300

[Message part 1 (text/plain, inline)]

Hello Guix,

There is an issue with not enough space:

    $ make check-system TESTS="btrfs-root-os"

I succeed by “double” this:

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
index a80c520ec..0e97de0a8 100644
--- a/gnu/tests/install.scm
+++ b/gnu/tests/install.scm
@@ -202,7 +202,7 @@ reboot\n")
                            #:imported-modules '((gnu services herd)
                                                 (guix combinators))))
                       (installation-disk-image-file-system-type "ext4")
-                      (target-size (* 1200 MiB)))
+                      (target-size (* 2200 MiB)))
   "Run SCRIPT (a shell script following the GuixSD installation procedure) in
 OS to install TARGET-OS.  Return a VM image of TARGET-SIZE bytes containing
 the installed system.  The packages specified in PACKAGES will be appended to
@@ -793,7 +793,7 @@ export GUIX_BUILD_OPTIONS=--no-grafts
 ls -l /run/current-system/gc-roots
 parted --script /dev/vdb mklabel gpt \\
   mkpart primary ext2 1M 3M \\
-  mkpart primary ext2 3M 1G \\
+  mkpart primary ext2 3M 2G \\
   set 1 boot on \\
   set 1 bios_grub on
 mkfs.btrfs -L my-root /dev/vdb2

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 29102 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29102 <at> debbugs.gnu.org
Subject: Re: bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not
 enough space
Date: Sun, 05 Nov 2017 17:05:35 +0100

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> There is an issue with not enough space:
>
>     $ make check-system TESTS="btrfs-root-os"
>
> I succeed by “double” this:

Good catch.

> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
> index a80c520ec..0e97de0a8 100644
> --- a/gnu/tests/install.scm
> +++ b/gnu/tests/install.scm
> @@ -202,7 +202,7 @@ reboot\n")
>                             #:imported-modules '((gnu services herd)
>                                                  (guix combinators))))
>                        (installation-disk-image-file-system-type "ext4")
> -                      (target-size (* 1200 MiB)))
> +                      (target-size (* 2200 MiB)))

Maybe you can even change this one to 'guess?

Otherwise OK to push to master, thank you!

Ludo’.

Message #11 received at 29102 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29102 <at> debbugs.gnu.org
Subject: Re: bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not
 enough space
Date: Tue, 07 Nov 2017 22:44:51 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Thank you for review.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> There is an issue with not enough space:
>>
>>     $ make check-system TESTS="btrfs-root-os"
>>
>> I succeed by “double” this:
>
> Good catch.
>
>> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
>> index a80c520ec..0e97de0a8 100644
>> --- a/gnu/tests/install.scm
>> +++ b/gnu/tests/install.scm
>> @@ -202,7 +202,7 @@ reboot\n")
>>                             #:imported-modules '((gnu services herd)
>>                                                  (guix combinators))))
>>                        (installation-disk-image-file-system-type "ext4")
>> -                      (target-size (* 1200 MiB)))
>> +                      (target-size (* 2200 MiB)))
>
> Maybe you can even change this one to 'guess?

No, because it will fail doing number->string on symbol here:

  (system* "qemu-img" "create" "-f" "qcow2"
           #$output #$(number->string target-size))

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 29102 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29102 <at> debbugs.gnu.org
Subject: Re: bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not
 enough space
Date: Sat, 11 Nov 2017 18:45:38 +0100

Hi,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Hi Oleg,
>>
>> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>>
>>> There is an issue with not enough space:
>>>
>>>     $ make check-system TESTS="btrfs-root-os"
>>>
>>> I succeed by “double” this:
>>
>> Good catch.
>>
>>> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
>>> index a80c520ec..0e97de0a8 100644
>>> --- a/gnu/tests/install.scm
>>> +++ b/gnu/tests/install.scm
>>> @@ -202,7 +202,7 @@ reboot\n")
>>>                             #:imported-modules '((gnu services herd)
>>>                                                  (guix combinators))))
>>>                        (installation-disk-image-file-system-type "ext4")
>>> -                      (target-size (* 1200 MiB)))
>>> +                      (target-size (* 2200 MiB)))
>>
>> Maybe you can even change this one to 'guess?
>
> No, because it will fail doing number->string on symbol here:
>
>   (system* "qemu-img" "create" "-f" "qcow2"
>            #$output #$(number->string target-size))

Good point.  In that case please push the initial patch.

Thank you,
Ludo’.

Message #17 received at 29102 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 29102-done <at> debbugs.gnu.org,
 29102 <at> debbugs.gnu.org
Subject: Re: bug#29102: FAIL: make check-system TESTS="btrfs-root-os" not
 enough space
Date: Wed, 15 Nov 2017 00:53:02 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

ludo <at> gnu.org (Ludovic Courtès) writes:

[...]

>>>> diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
>>>> index a80c520ec..0e97de0a8 100644
>>>> --- a/gnu/tests/install.scm
>>>> +++ b/gnu/tests/install.scm
>>>> @@ -202,7 +202,7 @@ reboot\n")
>>>>                             #:imported-modules '((gnu services herd)
>>>>                                                  (guix combinators))))
>>>>                        (installation-disk-image-file-system-type "ext4")
>>>> -                      (target-size (* 1200 MiB)))
>>>> +                      (target-size (* 2200 MiB)))
>>>
>>> Maybe you can even change this one to 'guess?
>>
>> No, because it will fail doing number->string on symbol here:
>>
>>   (system* "qemu-img" "create" "-f" "qcow2"
>>            #$output #$(number->string target-size))
>
> Good point.  In that case please push the initial patch.

OK, pushed as 5724a14e71f21ccfe865ed6fadae3f7683fc66e2

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.