From unknown Sun Jun 22 11:32:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29100 <29100@debbugs.gnu.org> To: bug#29100 <29100@debbugs.gnu.org> Subject: Status: [PATCH 0/3] Use overlayfs instead of unionfs. Reply-To: bug#29100 <29100@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:32:12 +0000 retitle 29100 [PATCH 0/3] Use overlayfs instead of unionfs. reassign 29100 guix-patches submitter 29100 Hartmut Goebel severity 29100 normal tag 29100 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 04:33:25 2017 Received: (at submit) by debbugs.gnu.org; 1 Nov 2017 08:33:26 +0000 Received: from localhost ([127.0.0.1]:44962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oSj-0002TS-O7 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:33:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oSh-0002TG-U4 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9oSb-0000ll-Lp for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:33:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9oSb-0000lg-If for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:33:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9oSa-00028t-He for guix-patches@gnu.org; Wed, 01 Nov 2017 04:33:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9oSW-0000jz-HN for guix-patches@gnu.org; Wed, 01 Nov 2017 04:33:16 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:49609) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9oSW-0000j5-Ad for guix-patches@gnu.org; Wed, 01 Nov 2017 04:33:12 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yRhLX6qrLz1qsD4 for ; Wed, 1 Nov 2017 09:33:08 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yRhLX5nlsz1qqkr for ; Wed, 1 Nov 2017 09:33:08 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 6bzKOevGevim for ; Wed, 1 Nov 2017 09:33:07 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-85-160.dynamic.mnet-online.de [93.104.85.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Wed, 1 Nov 2017 09:33:07 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 9B7706016C for ; Wed, 1 Nov 2017 09:33:07 +0100 (CET) From: Hartmut Goebel To: guix-patches@gnu.org Subject: [PATCH 0/3] Use overlayfs instead of unionfs. Date: Wed, 1 Nov 2017 09:33:07 +0100 Message-Id: <20171101083307.5214-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) These patches replace the FUSE-based unionfs by the kernel-based overlayfs. For the insallation image this reduces the size of the initrd by ca. 4.3% (487K). I verified this is working by successfiully running make check-system TESTS=installed-os. One thing I did not change: In gnu/system/install.scm (installation-os)[file-systems], /tmp is still mounted to tmpfs. This was introduced in ee03b75dfb3399f41002c38ac512473ab94afa74 for unionfs because FUSE creates .fuse_hiddenXYZ' files for each open file, and this confuses Guix's test suite, for instance (see ). This should no longer be necessary when using overlayfs, since overlayfs uses a separate workdir. However I was not able to trigger bug 23056 while still using unionfs, so I could not verify whether this mount is still needed with overlayfs and I decided to keep it. Hartmut Goebel (3): build: Use overlayfs instead of unionfs. install: Use overlayfs instead of unionfs. gnu: service: Update comment. gnu/build/linux-boot.scm | 43 ++++++++++++--------------------------- gnu/services/base.scm | 2 +- gnu/system/install.scm | 49 ++++++++++++++++++--------------------------- gnu/system/linux-initrd.scm | 4 ++-- 4 files changed, 35 insertions(+), 63 deletions(-) -- 2.13.5 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 04:39:59 2017 Received: (at 29100) by debbugs.gnu.org; 1 Nov 2017 08:40:00 +0000 Received: from localhost ([127.0.0.1]:44972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oZ5-0002cy-LN for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:39:59 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:43036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oZ3-0002cj-Se for 29100@debbugs.gnu.org; Wed, 01 Nov 2017 04:39:58 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yRhVP1tJxz1qsVM for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:56 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yRhVN2ctzz1tSmx for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:56 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 1_8EslWRHRbL for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:55 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-85-160.dynamic.mnet-online.de [93.104.85.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:55 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id C46756016C for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:52 +0100 (CET) From: Hartmut Goebel To: 29100@debbugs.gnu.org Subject: [PATCH 1/3] build: Use overlayfs instead of unionfs. Date: Wed, 1 Nov 2017 09:39:50 +0100 Message-Id: <20171101083952.5376-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.5 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Overlayfs is part of the kernel, while unionfs needs FUSE. This also reduces the size of the initrd by ca. 4.3% (487K). * gnu/build/linux-boot.scm (mount-root-file-system): Remove optional parameter "unionfs"; mount using overlayfs instead of unionfs; new directory layout requied by overlayfs; update documentation; [mark-as-not-killable]: remove now unused function * gnu/system/linux-intrd.scm (file-system-packages): Remove now unused packages "unionfs-fuse/static". (linux-modules): Replace "fuse" by "overlay". --- gnu/build/linux-boot.scm | 43 +++++++++++++------------------------------ gnu/system/linux-initrd.scm | 4 ++-- 2 files changed, 15 insertions(+), 32 deletions(-) diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm index 3712abe91..7f07e8038 100644 --- a/gnu/build/linux-boot.scm +++ b/gnu/build/linux-boot.scm @@ -241,20 +241,10 @@ the last argument of `mknod'." (filter-map string->number (scandir "/proc"))))) (define* (mount-root-file-system root type - #:key volatile-root? (unionfs "unionfs")) + #:key volatile-root?) "Mount the root file system of type TYPE at device ROOT. If VOLATILE-ROOT? -is true, mount ROOT read-only and make it a union with a writable tmpfs using -UNIONFS." - (define (mark-as-not-killable pid) - ;; Tell the 'user-processes' shepherd service that PID must be kept alive - ;; when shutting down. - (mkdir-p "/root/etc/shepherd") - (let ((port (open-file "/root/etc/shepherd/do-not-kill" "a"))) - (chmod port #o600) - (write pid port) - (newline port) - (close-port port))) - +is true, mount ROOT read-only and make it a overlay with a writable tmpfs +using the kernel build-in overlayfs." (if volatile-root? (begin (mkdir-p "/real-root") @@ -262,24 +252,17 @@ UNIONFS." (mkdir-p "/rw-root") (mount "none" "/rw-root" "tmpfs") + ;; Create the upperdir and the workdir of the overlayfs + (mkdir-p "/rw-root/upper") + (mkdir-p "/rw-root/work") + ;; We want read-write /dev nodes. - (mkdir-p "/rw-root/dev") - (mount "none" "/rw-root/dev" "devtmpfs") - - ;; Make /root a union of the tmpfs and the actual root. Use - ;; 'max_files' to set a high RLIMIT_NOFILE for the unionfs process - ;; itself. Failing to do that, we quickly run out of file - ;; descriptors; see . - (unless (zero? (system* unionfs "-o" - "cow,allow_other,use_ino,suid,dev,max_files=65536" - "/rw-root=RW:/real-root=RO" - "/root")) - (error "unionfs failed")) - - ;; Make sure unionfs remains alive till the end. Because - ;; 'fuse_daemonize' doesn't tell the PID of the forked daemon, we - ;; have to resort to 'pidof' here. - (mark-as-not-killable (pidof unionfs))) + (mkdir-p "/rw-root/upper/dev") + (mount "none" "/rw-root/upper/dev" "devtmpfs") + + ;; Make /root a overlay of the tmpfs and the actual root. + (mount "none" "/root" "overlay" 0 + "lowerdir=/real-root,upperdir=/rw-root/upper,workdir=/rw-root/work")) (begin (check-file-system root type) (mount root "/root" type))) diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm index 948c543a1..4168582c4 100644 --- a/gnu/system/linux-initrd.scm +++ b/gnu/system/linux-initrd.scm @@ -236,7 +236,7 @@ FILE-SYSTEMS." (list btrfs-progs/static) '()) ,@(if volatile-root? - (list unionfs-fuse/static) + (list ) ;; nothing requierd in this case '()))) (define* (base-initrd file-systems @@ -308,7 +308,7 @@ loaded at boot time in the order in which they appear." '("isofs") '()) ,@(if volatile-root? - '("fuse") + '("overlay") '()) ,@extra-modules)) -- 2.13.5 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 04:40:00 2017 Received: (at 29100) by debbugs.gnu.org; 1 Nov 2017 08:40:00 +0000 Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oZ5-0002d0-VQ for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:40:00 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:35166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oZ4-0002cl-GJ for 29100@debbugs.gnu.org; Wed, 01 Nov 2017 04:39:58 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yRhVP73yXz1qsVy for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:57 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yRhVP6ycsz1tSmy for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:57 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id dcMTquWfvhGR for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:56 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-85-160.dynamic.mnet-online.de [93.104.85.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:56 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id DA22760798 for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:52 +0100 (CET) From: Hartmut Goebel To: 29100@debbugs.gnu.org Subject: [PATCH 2/3] install: Use overlayfs instead of unionfs. Date: Wed, 1 Nov 2017 09:39:51 +0100 Message-Id: <20171101083952.5376-2-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20171101083952.5376-1-h.goebel@crazy-compilers.com> References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I dediced to keep adding /tmp as tmpfs since I was not able to trigger bug while still using unionfs, so I could not verify whether this mount is still needed with overlayfs. Mapping /tmp to tmpfs does not harm, so we are on the save side. * gnu/system/install.scm (make-cow-store): Mount /gnu/store without additional read-only bind-mount, since in overlayfs the "lower" level is always read-only. Add work-dir required by overlayfs. No need to sleep anymore since now using the mount syscall. [unionfs]: remove now unused function. (%installation-services): Update comment. (installation-os)[file-systems]: Update comment. --- gnu/system/install.scm | 49 +++++++++++++++++++------------------------------ 1 file changed, 19 insertions(+), 30 deletions(-) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index eb362f91a..0c771e81f 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -71,19 +71,6 @@ manual." "Return a gexp that makes the store copy-on-write, using TARGET as the backing store. This is useful when TARGET is on a hard disk, whereas the current store is on a RAM disk." - (define (unionfs read-only read-write mount-point) - ;; Make MOUNT-POINT the union of READ-ONLY and READ-WRITE. - - ;; Note: in the command below, READ-WRITE appears before READ-ONLY so that - ;; it is considered a "higher-level branch", as per unionfs-fuse(8), - ;; thereby allowing files existing on READ-ONLY to be copied over to - ;; READ-WRITE. - #~(fork+exec-command - (list (string-append #$unionfs-fuse "/bin/unionfs") - "-o" - "cow,allow_other,use_ino,max_files=65536,nonempty" - (string-append #$read-write "=RW:" #$read-only "=RO") - #$mount-point))) (define (set-store-permissions directory) ;; Set the right perms on DIRECTORY to use it as the store. @@ -97,23 +84,23 @@ current store is on a RAM disk." (mkdir-p tmpdir) (mount tmpdir "/tmp" "none" MS_BIND)) - (unless (file-exists? "/.ro-store") - (mkdir "/.ro-store") - (mount #$(%store-prefix) "/.ro-store" "none" - (logior MS_BIND MS_RDONLY))) - - (let ((rw-dir (string-append target #$%backing-directory))) + (let* ((rw-dir (string-append target #$%backing-directory)) + ;; FIXME: calculate work-dir from backing-directory: + ;; normpath(backing-directory + "../.overlayfs-workdir") + (work-dir (string-append target "/tmp/.overlayfs-workdir"))) (mkdir-p rw-dir) + (mkdir-p work-dir) (mkdir-p "/.rw-store") #$(set-store-permissions #~rw-dir) #$(set-store-permissions "/.rw-store") - ;; Mount the union, then atomically make it the store. - (and #$(unionfs "/.ro-store" #~rw-dir "/.rw-store") - (begin - (sleep 1) ;XXX: wait for unionfs to be ready - (mount "/.rw-store" #$(%store-prefix) "" MS_MOVE) - (rmdir "/.rw-store")))))) + ;; Mount the overlay, then atomically make it the store. + (mount "none" "/.rw-store" "overlay" 0 + (string-append "lowerdir=" #$(%store-prefix) "," + "upperdir=" rw-dir "," + "workdir=" work-dir)) + (mount "/.rw-store" #$(%store-prefix) "" MS_MOVE) + (rmdir "/.rw-store")))) (define cow-store-service-type (shepherd-service-type @@ -278,7 +265,7 @@ You have been warned. Thanks for being so brave. (allow-empty-passwords? #f) (password-authentication? #t))) - ;; Since this is running on a USB stick with a unionfs as the root + ;; Since this is running on a USB stick with a overlayfs as the root ;; file system, use an appropriate cache configuration. (nscd-service (nscd-configuration (caches %nscd-minimal-caches))) @@ -317,10 +304,12 @@ Use Alt-F2 for documentation. (title 'label) (type "ext4")) - ;; Make /tmp a tmpfs instead of keeping the unionfs. This is - ;; because FUSE creates '.fuse_hiddenXYZ' files for each open file, - ;; and this confuses Guix's test suite, for instance. See - ;; . + ;; Make /tmp a tmpfs instead of keeping the overlayfs. This + ;; originally was used for unionfs because FUSE creates + ;; '.fuse_hiddenXYZ' files for each open file, and this confuses + ;; Guix's test suite, for instance (see + ;; ). We keep this for overlayfs to be + ;; on the save side. (file-system (mount-point "/tmp") (device "none") -- 2.13.5 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 04:40:01 2017 Received: (at 29100) by debbugs.gnu.org; 1 Nov 2017 08:40:01 +0000 Received: from localhost ([127.0.0.1]:44976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oZ7-0002dJ-C9 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 04:40:01 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:41172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9oZ5-0002cx-Gj for 29100@debbugs.gnu.org; Wed, 01 Nov 2017 04:39:59 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yRhVR04cQz1qrN3 for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:59 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yRhVR00T2z1tSmx for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:58 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id GL4yk9dMYB6V for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:58 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-85-160.dynamic.mnet-online.de [93.104.85.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:58 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id EB9ED60799 for <29100@debbugs.gnu.org>; Wed, 1 Nov 2017 09:39:52 +0100 (CET) From: Hartmut Goebel To: 29100@debbugs.gnu.org Subject: [PATCH 3/3] gnu: service: Update comment. Date: Wed, 1 Nov 2017 09:39:52 +0100 Message-Id: <20171101083952.5376-3-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20171101083952.5376-1-h.goebel@crazy-compilers.com> References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/services/base.scm(guix-activation): Update comment. --- gnu/services/base.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index b605614ab..2ba655d94 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -1441,7 +1441,7 @@ failed to register hydra.gnu.org public key: ~a~%" status)))))))) (match config (($ guix build-group build-accounts authorize-key? keys) ;; Assume that the store has BUILD-GROUP as its group. We could - ;; otherwise call 'chown' here, but the problem is that on a COW unionfs, + ;; otherwise call 'chown' here, but the problem is that on a COW overlayfs, ;; chown leads to an entire copy of the tree, which is a bad idea. ;; Optionally authorize hydra.gnu.org's key. -- 2.13.5 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 13:44:17 2017 Received: (at 29100) by debbugs.gnu.org; 2 Nov 2017 17:44:17 +0000 Received: from localhost ([127.0.0.1]:48193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAJXN-00039Z-Ay for submit@debbugs.gnu.org; Thu, 02 Nov 2017 13:44:17 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAJXJ-00039N-LI for 29100@debbugs.gnu.org; Thu, 02 Nov 2017 13:44:16 -0400 Received: from localhost (178.113.129.134.wireless.dyn.drei.com [178.113.129.134]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 2E5DE1CA0565; Thu, 2 Nov 2017 18:44:11 +0100 (CET) Date: Thu, 2 Nov 2017 18:44:05 +0100 From: Danny Milosavljevic To: Hartmut Goebel Subject: Re: [bug#29100] [PATCH 2/3] install: Use overlayfs instead of unionfs. Message-ID: <20171102184405.05a67223@scratchpost.org> In-Reply-To: <20171101083952.5376-2-h.goebel@crazy-compilers.com> References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> <20171101083952.5376-2-h.goebel@crazy-compilers.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 Cc: 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) [...] > - (let ((rw-dir (string-append target #$%backing-directory))) > + (let* ((rw-dir (string-append target #$%backing-directory)) > + ;; FIXME: calculate work-dir from backing-directory: > + ;; normpath(backing-directory + "../.overlayfs-workdir") > + (work-dir (string-append target "/tmp/.overlayfs-workdir"))) What about the FIXME? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 14:20:56 2017 Received: (at 29100) by debbugs.gnu.org; 2 Nov 2017 18:20:56 +0000 Received: from localhost ([127.0.0.1]:48228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAK6q-00042J-8q for submit@debbugs.gnu.org; Thu, 02 Nov 2017 14:20:56 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:49354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAK6o-000428-Ft for 29100@debbugs.gnu.org; Thu, 02 Nov 2017 14:20:54 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3ySYLF30vjz1qsD3; Thu, 2 Nov 2017 19:20:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3ySYLF1nYnz1qqkc; Thu, 2 Nov 2017 19:20:53 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id jN8XqVAOmGFb; Thu, 2 Nov 2017 19:20:52 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-46-244-152-242.dynamic.mnet-online.de [46.244.152.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Thu, 2 Nov 2017 19:20:52 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 1F07560462; Thu, 2 Nov 2017 19:20:52 +0100 (CET) Subject: Re: [bug#29100] [PATCH 2/3] install: Use overlayfs instead of unionfs. To: Danny Milosavljevic References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> <20171101083952.5376-2-h.goebel@crazy-compilers.com> <20171102184405.05a67223@scratchpost.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: Date: Thu, 2 Nov 2017 19:20:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102184405.05a67223@scratchpost.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 Cc: 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am 02.11.2017 um 18:44 schrieb Danny Milosavljevic: > [...] >> - (let ((rw-dir (string-append target #$%backing-directory))) >> + (let* ((rw-dir (string-append target #$%backing-directory)) >> + ;; FIXME: calculate work-dir from backing-directory: >> + ;; normpath(backing-directory + "../.overlayfs-workdir") >> + (work-dir (string-append target "/tmp/.overlayfs-workdir"))) > What about the FIXME? I'll change it into a TODO. Somebody with more knowledge in scheme as to implement this. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 16:05:57 2017 Received: (at 29100) by debbugs.gnu.org; 5 Nov 2017 21:05:57 +0000 Received: from localhost ([127.0.0.1]:52705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBS7B-0000jb-31 for submit@debbugs.gnu.org; Sun, 05 Nov 2017 16:05:57 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:32836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBS7A-0000jT-0k for 29100@debbugs.gnu.org; Sun, 05 Nov 2017 16:05:56 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id F070FE878; Sun, 5 Nov 2017 22:05:55 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mXszvUjDCbDu; Sun, 5 Nov 2017 22:05:55 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CE04BE6B5; Sun, 5 Nov 2017 22:05:54 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Hartmut Goebel Subject: Re: [bug#29100] [PATCH 2/3] install: Use overlayfs instead of unionfs. References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> <20171101083952.5376-2-h.goebel@crazy-compilers.com> <20171102184405.05a67223@scratchpost.org> Date: Sun, 05 Nov 2017 22:05:52 +0100 In-Reply-To: (Hartmut Goebel's message of "Thu, 2 Nov 2017 19:20:51 +0100") Message-ID: <87o9ogmo5r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29100 Cc: Danny Milosavljevic , 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Hartmut, Hartmut Goebel skribis: > Am 02.11.2017 um 18:44 schrieb Danny Milosavljevic: >> [...] >>> - (let ((rw-dir (string-append target #$%backing-directory))) >>> + (let* ((rw-dir (string-append target #$%backing-directory)) >>> + ;; FIXME: calculate work-dir from backing-directory: >>> + ;; normpath(backing-directory + "../.overlayfs-workdir") >>> + (work-dir (string-append target "/tmp/.overlayfs-workdir"= ))) >> What about the FIXME? > > I'll change it into a TODO. Somebody with more knowledge in scheme as to > implement this. What does this comment mean exactly? The =E2=80=9Chas to=E2=80=9D suggests= that it=E2=80=99s important. :-) Perhaps you mean: (canonicalize-path (string-append rw-dir "/../.overlayfs-workdir")) ? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 16:08:55 2017 Received: (at 29100) by debbugs.gnu.org; 5 Nov 2017 21:08:55 +0000 Received: from localhost ([127.0.0.1]:52709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBSA1-0000nb-HK for submit@debbugs.gnu.org; Sun, 05 Nov 2017 16:08:55 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:32845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBS9z-0000nU-PS for 29100@debbugs.gnu.org; Sun, 05 Nov 2017 16:08:52 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C52B9E878; Sun, 5 Nov 2017 22:08:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BeDtuE5P5-UB; Sun, 5 Nov 2017 22:08:52 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id D80A8E6B5; Sun, 5 Nov 2017 22:08:51 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Hartmut Goebel Subject: Re: [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs. References: <20171101083307.5214-1-h.goebel@crazy-compilers.com> <20171101083952.5376-1-h.goebel@crazy-compilers.com> Date: Sun, 05 Nov 2017 22:08:49 +0100 In-Reply-To: <20171101083952.5376-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Wed, 1 Nov 2017 09:39:50 +0100") Message-ID: <87k1z4mo0u.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29100 Cc: 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Heya, Hartmut Goebel skribis: > Overlayfs is part of the kernel, while unionfs needs FUSE. This also red= uces > the size of the initrd by ca. 4.3% (487K). Awesome! It=E2=80=99s definitely an improvement, and I=E2=80=99m happy tha= t it fixes . > * gnu/build/linux-boot.scm (mount-root-file-system): Remove optional para= meter > "unionfs"; mount using overlayfs instead of unionfs; new directory layo= ut > requied by overlayfs; update documentation; > [mark-as-not-killable]: remove now unused function > > * gnu/system/linux-intrd.scm (file-system-packages): Remove now unused ^^^ Typo. > packages "unionfs-fuse/static". > (linux-modules): Replace "fuse" by "overlay". Nitpick: please capitalize sentences, add missing periods. > + ;; Make /root a overlay of the tmpfs and the actual root. s/a/an/ > --- a/gnu/system/linux-initrd.scm > +++ b/gnu/system/linux-initrd.scm > @@ -236,7 +236,7 @@ FILE-SYSTEMS." > (list btrfs-progs/static) > '()) > ,@(if volatile-root? > - (list unionfs-fuse/static) > + (list ) ;; nothing requierd in this case > '()))) You can remove the whole =E2=80=98if=E2=80=99 here. OK with these changes, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 05 16:09:25 2017 Received: (at 29100) by debbugs.gnu.org; 5 Nov 2017 21:09:25 +0000 Received: from localhost ([127.0.0.1]:52713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBSAX-0000om-8W for submit@debbugs.gnu.org; Sun, 05 Nov 2017 16:09:25 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:32849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBSAV-0000od-4n for 29100@debbugs.gnu.org; Sun, 05 Nov 2017 16:09:23 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 31500E878; Sun, 5 Nov 2017 22:09:24 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WkHcNX144cYi; Sun, 5 Nov 2017 22:09:22 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 83405E6B5; Sun, 5 Nov 2017 22:09:22 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Hartmut Goebel Subject: Re: [bug#29100] [PATCH 3/3] gnu: service: Update comment. References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> <20171101083952.5376-3-h.goebel@crazy-compilers.com> Date: Sun, 05 Nov 2017 22:09:20 +0100 In-Reply-To: <20171101083952.5376-3-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Wed, 1 Nov 2017 09:39:52 +0100") Message-ID: <87fu9smnzz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29100 Cc: 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hartmut Goebel skribis: > * gnu/services/base.scm(guix-activation): Update comment. ^ Missing space. Otherwise OK! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 04:33:28 2017 Received: (at 29100) by debbugs.gnu.org; 6 Nov 2017 09:33:28 +0000 Received: from localhost ([127.0.0.1]:52973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBdma-0005Hf-BL for submit@debbugs.gnu.org; Mon, 06 Nov 2017 04:33:28 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:54967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBdmY-0005HX-HP for 29100@debbugs.gnu.org; Mon, 06 Nov 2017 04:33:27 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yVnRn2Lqtz1qsDB; Mon, 6 Nov 2017 10:33:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yVnRn1QbLz1rS7S; Mon, 6 Nov 2017 10:33:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 3RlbnNkLJiWR; Mon, 6 Nov 2017 10:33:24 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-46-244-141-46.dynamic.mnet-online.de [46.244.141.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 6 Nov 2017 10:33:24 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 656AB60173; Mon, 6 Nov 2017 10:33:23 +0100 (CET) Subject: Re: [bug#29100] [PATCH 2/3] install: Use overlayfs instead of unionfs. To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20171101083952.5376-1-h.goebel@crazy-compilers.com> <20171101083952.5376-2-h.goebel@crazy-compilers.com> <20171102184405.05a67223@scratchpost.org> <87o9ogmo5r.fsf@gnu.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: Date: Mon, 6 Nov 2017 10:33:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87o9ogmo5r.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 Cc: Danny Milosavljevic , 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am 05.11.2017 um 22:05 schrieb Ludovic Courtès: > Perhaps you mean: > > (canonicalize-path (string-append rw-dir "/../.overlayfs-workdir")) Exactly :-) Thanks. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 04:40:38 2017 Received: (at 29100) by debbugs.gnu.org; 6 Nov 2017 09:40:38 +0000 Received: from localhost ([127.0.0.1]:52981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBdtW-0005SM-IF for submit@debbugs.gnu.org; Mon, 06 Nov 2017 04:40:38 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:58790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBdtU-0005SD-Qv for 29100@debbugs.gnu.org; Mon, 06 Nov 2017 04:40:37 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yVnc36kJNz1r19d; Mon, 6 Nov 2017 10:40:35 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yVnc35DVDz1rS7d; Mon, 6 Nov 2017 10:40:35 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id zuG9kJwJNVE5; Mon, 6 Nov 2017 10:40:35 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-46-244-141-46.dynamic.mnet-online.de [46.244.141.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Mon, 6 Nov 2017 10:40:35 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 9C4EE60218; Mon, 6 Nov 2017 10:40:34 +0100 (CET) Subject: Re: [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs. To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20171101083307.5214-1-h.goebel@crazy-compilers.com> <20171101083952.5376-1-h.goebel@crazy-compilers.com> <87k1z4mo0u.fsf@gnu.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <8da68ab8-fd42-60f0-c847-9c51bfc10521@crazy-compilers.com> Date: Mon, 6 Nov 2017 10:40:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87k1z4mo0u.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100 Cc: 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am 05.11.2017 um 22:08 schrieb Ludovic Courtès: >> ,@(if volatile-root? >> - (list unionfs-fuse/static) >> + (list ) ;; nothing requierd in this case >> '()))) > You can remove the whole ‘if’ here. Okay. should I remove the then unused #:key volatile-root?, too? This would change the function's signature and may require more changes at other places. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 06 05:30:11 2017 Received: (at 29100) by debbugs.gnu.org; 6 Nov 2017 10:30:12 +0000 Received: from localhost ([127.0.0.1]:53011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBefT-0006ge-PF for submit@debbugs.gnu.org; Mon, 06 Nov 2017 05:30:11 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:34277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBefS-0006gW-Gy for 29100@debbugs.gnu.org; Mon, 06 Nov 2017 05:30:10 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CA116E657; Mon, 6 Nov 2017 11:30:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yCTMRGMBgNEK; Mon, 6 Nov 2017 11:30:09 +0100 (CET) Received: from ribbon (nat-eduroam-36-gw-01-bso.bordeaux.inria.fr [194.199.1.36]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0744FF0D7; Mon, 6 Nov 2017 11:30:08 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Hartmut Goebel Subject: Re: [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs. References: <20171101083307.5214-1-h.goebel@crazy-compilers.com> <20171101083952.5376-1-h.goebel@crazy-compilers.com> <87k1z4mo0u.fsf@gnu.org> <8da68ab8-fd42-60f0-c847-9c51bfc10521@crazy-compilers.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Brumaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 Nov 2017 11:30:06 +0100 In-Reply-To: <8da68ab8-fd42-60f0-c847-9c51bfc10521@crazy-compilers.com> (Hartmut Goebel's message of "Mon, 6 Nov 2017 10:40:34 +0100") Message-ID: <87wp33d7ip.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29100 Cc: 29100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hartmut Goebel skribis: > Am 05.11.2017 um 22:08 schrieb Ludovic Court=C3=A8s: >>> ,@(if volatile-root? >>> - (list unionfs-fuse/static) >>> + (list ) ;; nothing requierd in this case >>> '()))) >> You can remove the whole =E2=80=98if=E2=80=99 here. > > Okay. should I remove the then unused #:key volatile-root?, too? No, I think you can keep it (and also the overlay.ko is added conditionally based on that IIRC.) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 08 12:26:45 2017 Received: (at 29100-close) by debbugs.gnu.org; 8 Nov 2017 17:26:45 +0000 Received: from localhost ([127.0.0.1]:58806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCU7h-0006jt-LA for submit@debbugs.gnu.org; Wed, 08 Nov 2017 12:26:45 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:35473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCU7g-0006jm-R6 for 29100-close@debbugs.gnu.org; Wed, 08 Nov 2017 12:26:45 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yXCrz5kBVz1qshC for <29100-close@debbugs.gnu.org>; Wed, 8 Nov 2017 18:26:43 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yXCrz4c6sz1rcP0 for <29100-close@debbugs.gnu.org>; Wed, 8 Nov 2017 18:26:43 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id QzOyg1s1m3OF for <29100-close@debbugs.gnu.org>; Wed, 8 Nov 2017 18:26:43 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-93-104-87-207.dynamic.mnet-online.de [93.104.87.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <29100-close@debbugs.gnu.org>; Wed, 8 Nov 2017 18:26:43 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id A6CB46063E for <29100-close@debbugs.gnu.org>; Wed, 8 Nov 2017 18:26:42 +0100 (CET) To: 29100-close@debbugs.gnu.org From: Hartmut Goebel Subject: Updated, tested again and merged Organization: crazy-compilers.com Message-ID: <6f18ab70-397c-3ccb-836e-e6b2693813e7@crazy-compilers.com> Date: Wed, 8 Nov 2017 18:26:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29100-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Addressed all concerns and merged as 0af94ad52f65a5a62febd203e431f17642f07577. I re-testet it, based on cd5c3979d (@master) using make check-system TESTS=installed-os From unknown Sun Jun 22 11:32:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Dec 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator