GNU bug report logs - #29099
[PATCH] gnu: Add kodi-cli.

Previous Next

Full log

Message #17 received at 29099 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 29099-done <at> debbugs.gnu.org, 29099 <at> debbugs.gnu.org
Subject: Re: [bug#29099] [PATCH] gnu: Add kodi-cli.
Date: Fri, 03 Nov 2017 06:57:05 +0300

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

[...]

>> Maybe call this item of the feature list as
>> “Send text to the Kodi keyboard”?
>
> "Send text to the Kodi keyboard" is much better, thanks!
>
>> +      (arguments
>> +       `(#:modules ((guix build utils))
>> +         #:builder
>> +         (begin
>> +           (use-modules (guix build utils))
>> +           (copy-recursively (assoc-ref %build-inputs "source") ".")
>> +           (substitute* "kodi-cli"
>> +             (("/bin/bash") (string-append (assoc-ref %build-inputs "bash")
>> +                                           "/bin/bash"))
>> +             (("output=\\$\\((curl)" all curl)
>> +              (string-append "output=$("
>> +                             (assoc-ref %build-inputs "curl")
>> +                             "/bin/" curl))
>> +             (("play_youtube `(mpsyt)" all mpsyt)
>> +              (string-append "play_youtube `"
>> +                             (assoc-ref %build-inputs "mps-youtube")
>> +                             "/bin/" mpsyt)))
>
> FYI, you could also use (which "curl") etc from (guix build utils) here,
> but I usually prefer this form.

Thanks for notice.  I prefer a form used in attached patch, too.

>> +@itemize
>> +@item Play, pause, stop the current playing item.
>> +@item Skip forward or backward in the current playing item.
>
> These should be "currently playing".

Done.

>> +@item Play or queue to the current list YouTube videos.
>
> "... current list of YouTube videos."
>
> (note the "of")

Done.

> LGTM otherwise.  Don't forget to add a copyright line for yourself.

OK.  I think it's fine to merge it now.


Pushed as 72df48dbad95c3bc70a2962f496420ce3363d0de

Oleg,
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.