From unknown Sun Jun 22 17:10:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29099 <29099@debbugs.gnu.org> To: bug#29099 <29099@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add kodi-cli. Reply-To: bug#29099 <29099@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:10:55 +0000 retitle 29099 [PATCH] gnu: Add kodi-cli. reassign 29099 guix-patches submitter 29099 Oleg Pykhalov severity 29099 normal tag 29099 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 02:48:50 2017 Received: (at submit) by debbugs.gnu.org; 1 Nov 2017 06:48:50 +0000 Received: from localhost ([127.0.0.1]:44930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9mpW-0008MP-Gl for submit@debbugs.gnu.org; Wed, 01 Nov 2017 02:48:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9mpU-0008MD-V1 for submit@debbugs.gnu.org; Wed, 01 Nov 2017 02:48:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9mpO-0002n1-He for submit@debbugs.gnu.org; Wed, 01 Nov 2017 02:48:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9mpO-0002mr-DX for submit@debbugs.gnu.org; Wed, 01 Nov 2017 02:48:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9mpN-00017C-1d for guix-patches@gnu.org; Wed, 01 Nov 2017 02:48:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9mpI-0002ca-4d for guix-patches@gnu.org; Wed, 01 Nov 2017 02:48:41 -0400 Received: from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]:49583) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9mpH-0002bt-Sc for guix-patches@gnu.org; Wed, 01 Nov 2017 02:48:36 -0400 Received: by mail-lf0-x235.google.com with SMTP id w21so1415420lfc.6 for ; Tue, 31 Oct 2017 23:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=crBAIEVKIe8BzzBPdUb43+55xKXE6/pD24zrZf5QYtU=; b=VWGQ+8ihihWJGskDCk/L0d1nLVo3g3Dibm7deQQlKge2iv/N/GZQaxSTlJbb32TsZ5 2Yr/IHkg3BY5KDoIiROAMxi9H1qApsMLCd3wMFQdcONG1KeLCZ/GptVBkU7Y5l4yXxIm eyjAAQ6ob7wUjOB47L/2LHyOfpzjJM0sFkH8WeuiLXI9fxxP0UHR7izR5Aa8Mg7jPnKc a8ccZYGITjaFVn7WUgPLySHb1b0UymFoAYF3hoYgi8cAi7esqkXbQV9bcr2qoK5w4s/q RF16FOm2V5U3TmOnJ2TNmzODL3UTP51F9h6vciTzR3FilgmtsGLp8yDtirUvr0dSnohK qsQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=crBAIEVKIe8BzzBPdUb43+55xKXE6/pD24zrZf5QYtU=; b=t0XUG3DaHmTW5spdakm++onmqULvkBOEOnu+hTCUwSUq+lUOEKxxkuQ+z+0awTey6d FzSGW1AY5YT9PDPrd2vDi/3HfvVaSK4tI2cAtHfzis8L9g9cHWETIKiU8jnGN0kEeWYq nv4tJSEPBgon/Ow+5O5iRG75FzWtc2BlQgjE+lXbOiAhbf2lrAzX8tnU10+ncyWeyTM7 wchmlBWX5Q1+i+3e+wXVoH7Z8n3Jis1JZCbV9Ojs0cbb+MweIiqr01iR8JSvYgn/Im6y YYIv1AfEExoh6/jzgLhPtj6tnydTTfJDNleQ66/YRw47l5/d0P93h7L5o6R/6FEw13Dm RnYg== X-Gm-Message-State: AMCzsaVy9JjTMa6kwhXSCsFFxhlArbpqc/rp9WcIYghTsJbMk0D4QxV3 1e8iFwlNoLZPTITvImNWQ6EzFw== X-Google-Smtp-Source: ABhQp+TEfAtM9nFWEo/oSd4yl27PSVPw5SK/cfR43zm3RKlvPi36Y3V/AJ8q/sjUc5PdswWcVP/Bew== X-Received: by 10.46.70.26 with SMTP id t26mr1942440lja.181.1509518914097; Tue, 31 Oct 2017 23:48:34 -0700 (PDT) Received: from magnolia (ppp78-37-142-74.pppoe.avangarddsl.ru. [78.37.142.74]) by smtp.gmail.com with ESMTPSA id s8sm543116lfk.50.2017.10.31.23.48.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Oct 2017 23:48:33 -0700 (PDT) From: Oleg Pykhalov To: guix-patches@gnu.org Subject: [PATCH] gnu: Add kodi-cli. Date: Wed, 01 Nov 2017 09:48:31 +0300 Message-ID: <8760au8pfk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-kodi-cli.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] gnu: Add kodi-cli. From=20741284b1619490859910fb402802ab10b31f0fd2 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Wed, 1 Nov 2017 09:39:05 +0300 Subject: [PATCH] gnu: Add kodi-cli. * gnu/packages/kodi.scm (kodi-cli): New variable. =2D-- gnu/packages/kodi.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/gnu/packages/kodi.scm b/gnu/packages/kodi.scm index c8a65af79..65621e152 100644 =2D-- a/gnu/packages/kodi.scm +++ b/gnu/packages/kodi.scm @@ -25,11 +25,13 @@ #:use-module (guix git-download) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) + #:use-module (guix build-system trivial) #:use-module (gnu packages algebra) #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages avahi) #:use-module (gnu packages base) + #:use-module (gnu packages bash) #:use-module (gnu packages cdrom) #:use-module (gnu packages cmake) #:use-module (gnu packages compression) @@ -426,3 +428,49 @@ plug-in system.") license:public-domain ;cpluff/examples license:bsd-3 ;misc, gtest license:bsd-2))))) ;xbmc/freebsd + +(define-public kodi-cli + (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add support = for + (revision "1")) ; `$HOME/.kodi= rc'. + (package + (name "kodi-cli") + (version (string-append "1.1-" revision "." (string-take commit 7))) + (source (origin + (method git-fetch) + (uri (git-reference (url "https://github.com/nawar/kodi-cl= i") + (commit commit))) + (sha256 + (base32 + "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5p")) + (file-name (string-append name "-" version "-checkout")))) + (build-system trivial-build-system) + (inputs `(("bash" ,bash))) + (propagated-inputs `(("curl" ,curl))) + (arguments + `(#:modules ((guix build utils)) + #:builder + (begin + (use-modules (guix build utils)) + (copy-recursively (assoc-ref %build-inputs "source") ".") + (substitute* "kodi-cli" + (("/bin/bash") (string-append (assoc-ref %build-inputs "bash") + "/bin/bash"))) + (install-file "kodi-cli" (string-append %output "/bin"))))) + (home-page "https://github.com/nawar/kodi-cli") + (synopsis "Bash script to send commands to Kodi using JSON RPC") + (description "@code{kodi-cli} provides the Bash script to send comma= nds to +Kodi using JSON RPC. + +Feautures: + +@itemize +@item Play, pause, stop the current played video. +@item Skip forward or backward in the current played video. +@item Play or queue to the current list YouTube video. +@item Interactive and noninteractive volume control. +@item Interactive navigation. +@item Send text. +@item Toggle fullscreen. +@item Update or clean Kodi libraries. +@end itemize\n") + (license license:gpl2+)))) =2D-=20 2.14.3 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAln5bj8ACgkQckbhHGm3 lWl1UQ/9Fn2x3pQrwY2NhmQ7Fh7la3L+rxhAYcjfy5dhbzwMvT0LcI3fll+De6XG dV+/9dWCXqcy4qbRoWE3jjugVvupO9KKSsasaqxDVPEhSHyht/W7Pl5nPZFAb3VH AiPp3VXxdLKaQc8K96vezuNKQCjFPSkOHCjbrbYroyklrv0Eidzo1xH1ndoduUtf U+LDq6Ns/N7wJZs6IbPrMlKhnoGg+IYggSwS5j+k1FknznUTF3lZ7rtnJQ7VEBtL hTYvJZY7U0VAnrOg4CmXwYXPZK9oa/HKjFgFSw6wXtkY3S192w57kZYIOxeGGiCJ V/OgVxfVD21fqh6S7aUQjuUnhUKuP00i7R0NXogoimpF3Qath0/78u+X8MYc6ZBJ vxbUxeAXQGvXTH/KQs5HrxcRGOo5JvMqV5yENi+BNf5kSqd47PXToz6JFupqQDGv yyUnhO+gqi8C/TSrlxXw0BXLWeL3/olJl0F8wQ0QWi4NuCzkQSTmyvD6Xw5WVFwE QZS2VT8NmUMouO77538sdnMSOJOObgrzpkT6tuHmdIk/fyva1md4d2KqGrGgCpm1 Y3l75iekXN+vMeFvq3T8aMoCKapmDK0R+Ju6xmWAx9m1mdgQF9GJYmiRpoWv8m6U 1cAZncH+yHWKUvwovxnB8hRumJ5CWrx6rMt2fitwPqNntJ/IcrA= =HwGC -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 17:32:43 2017 Received: (at 29099) by debbugs.gnu.org; 1 Nov 2017 21:32:43 +0000 Received: from localhost ([127.0.0.1]:46527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eA0cr-0004A8-DE for submit@debbugs.gnu.org; Wed, 01 Nov 2017 17:32:43 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eA0cn-00049w-Fl for 29099@debbugs.gnu.org; Wed, 01 Nov 2017 17:32:39 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7C1D820C0A; Wed, 1 Nov 2017 17:32:36 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Wed, 01 Nov 2017 17:32:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=yhOXzCRWgtbzH0I7XTsm51jiom46AuOzJNmhS9yUGV8=; b=GeEe9Wq3 kz20Ez62ImXjjWIWM+hihj9YiKhSkxxCPmsTnhWX2q1OntpUxpdT8c3zBk3NMaNg oJ8NCO6K2URjMMV2wA/0DkFlz3fuodddTavJ/eaazy333JbojAGf9CWhauNW5uuw qIr6CiuKPNOg1ilH87mtAkN66m2xFxTfzbdG93GfwXifhSv2O1bx2k97ymM3BBMw 2YaO8ESCcKkwurXJCiWd3kJRnzuyFYCigPNQTgFQpGVMGQCrboMY/EHV753Tmdd4 lEiLiANqtBMatGATca+CHncQn1gJnQiMVzaN7J8IZPVEn8aXnmi7p1meAe8G9Ex4 mfIR6OzDkbz2ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=yhOXzCRWgtbzH0I7XTsm51jiom46A uOzJNmhS9yUGV8=; b=nsZeqg3arNzhgt8xMcn4a1vvCnJHGWCAuyNQ5eNwOogM1 VHp97DpIi4SKBrdIFNqod81uFMMa0Tz8EYQamLEW31Rnu85hoWddE/Dco59qNKW/ +xGkcBVLrVEUku0fLH55EsMn4LIfI9aut12UfkTHD2vIDUtQZm5mxTbn7NOTTjS5 WG56Ab8F/VOQBaAMHof2WsjxCHeS5tBsQaVaT6EAxd6wHpa3VcdsrP6reWo0YxHG vDPHEXCaBqhWvitGGqM+ya5xshfu+l0LWgY7afY1Z1fkR7jrZBYZbLFNMRd4pBEL 7GNecmLDC8BvVZl5F8x7Qq3wRR0NOVJbdAe1v2zoA== X-ME-Sender: Received: from localhost (cm-84.214.173.174.getinternet.no [84.214.173.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 15596244C7; Wed, 1 Nov 2017 17:32:35 -0400 (EDT) From: Marius Bakke To: Oleg Pykhalov , 29099@debbugs.gnu.org Subject: Re: [bug#29099] [PATCH] gnu: Add kodi-cli. In-Reply-To: <8760au8pfk.fsf@gmail.com> References: <8760au8pfk.fsf@gmail.com> User-Agent: Notmuch/0.25.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Wed, 01 Nov 2017 22:32:34 +0100 Message-ID: <87a8054rd9.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29099 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Hello Oleg! Oleg Pykhalov writes: > From 741284b1619490859910fb402802ab10b31f0fd2 Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Wed, 1 Nov 2017 09:39:05 +0300 > Subject: [PATCH] gnu: Add kodi-cli. > > * gnu/packages/kodi.scm (kodi-cli): New variable. Cool! [...] > +(define-public kodi-cli > + (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add support for > + (revision "1")) ; `$HOME/.kodirc'. > + (package > + (name "kodi-cli") > + (version (string-append "1.1-" revision "." (string-take commit 7))) > + (source (origin > + (method git-fetch) > + (uri (git-reference (url "https://github.com/nawar/kodi-cli") > + (commit commit))) > + (sha256 > + (base32 > + "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5p")) > + (file-name (string-append name "-" version "-checkout")))) > + (build-system trivial-build-system) > + (inputs `(("bash" ,bash))) > + (propagated-inputs `(("curl" ,curl))) There is only one reference to `curl` in the script, can you try to substitute it with the absolute path and make it a regular input? It's good to avoid propagation when we can. > + (arguments > + `(#:modules ((guix build utils)) > + #:builder > + (begin > + (use-modules (guix build utils)) > + (copy-recursively (assoc-ref %build-inputs "source") ".") > + (substitute* "kodi-cli" > + (("/bin/bash") (string-append (assoc-ref %build-inputs "bash") > + "/bin/bash"))) > + (install-file "kodi-cli" (string-append %output "/bin"))))) (install-file ...) has an unspecified return value, so please return #t here. > + (home-page "https://github.com/nawar/kodi-cli") > + (synopsis "Bash script to send commands to Kodi using JSON RPC") Maybe just "Control Kodi from the command line". > + (description "@code{kodi-cli} provides the Bash script to send commands to > +Kodi using JSON RPC. Similarly, this sentence can be reduced to something like "@code{kodi-cli} is a tool for sending commands to a Kodi server using JSON-RPC.". Bash is an boring implementation detail IMO. :-) > + > +Feautures: ^ Stray 'u' character. > + > +@itemize > +@item Play, pause, stop the current played video. "currently playing" > +@item Skip forward or backward in the current played video. Same here. Maybe it should be "currently playing item", since I assume this works for music as well. > +@item Play or queue to the current list YouTube video. "List of YouTube videos"? > +@item Interactive and noninteractive volume control. > +@item Interactive navigation. > +@item Send text. What does this mean? Arbitrary commands, or text notifications? > +@item Toggle fullscreen. > +@item Update or clean Kodi libraries. > +@end itemize\n") > + (license license:gpl2+)))) LGTM with some cosmetic improvements. And welcome! By the way, if you use Kodi from Guix, feel free to update the 18 snapshot if you can. My media PC died a while back, and I didn't get a replacement yet, so I have not been able to maintain the Kodi package. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAln6PXIACgkQoqBt8qM6 VPqEGggAuTMBXdXJFLxDxp8MZjux4GAnbW4YaiFM5WoobSMSozTGUZqfteh/EP/6 tpzXIL3IRjgPXGH+rj4HLxynnZaLZIYOKr1I2ct3hwojKr07n3QjQcXNDk6wHQBW JqXvliNbBOkbTh6O6ZRVKsrGGY6gv2M+9Lf5DwX12A/50e29MmknrG1monAKJTW2 woXBrKYyNFh5+Hl2yXYM9VcFBW3qZhkUAJD+lg73WHIJEcAXLE3uHNWMAegwi7SF RqtjBvM+JfOXNFnWdHy6Iw38/d3k+PrRo4XerMjw/pDEVotV7bJv80QmfUnWaSMo D0Q0sp5hGaZAyzTMakr4OB4o10KsYQ== =IuuB -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 05:15:04 2017 Received: (at 29099) by debbugs.gnu.org; 2 Nov 2017 09:15:04 +0000 Received: from localhost ([127.0.0.1]:46894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eABaa-0003vO-8o for submit@debbugs.gnu.org; Thu, 02 Nov 2017 05:15:04 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:54571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eABaY-0003ub-NE for 29099@debbugs.gnu.org; Thu, 02 Nov 2017 05:15:03 -0400 Received: by mail-lf0-f46.google.com with SMTP id a2so5577506lfh.11 for <29099@debbugs.gnu.org>; Thu, 02 Nov 2017 02:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=UqJfXodysEXRMkzLt9SUsQ6nzcVInoXiEcfl6KqVvZs=; b=ImiE0i1MJqmn13lZotnfryPjg14uS8ncYtwfpzoPFFABD5LJa0XV3j+EEYqU7/AQme qfUEHldNfUZs3hjbD0oeMKsVV9tsrEzTCAFtlZYCbVcBF+RoGMl2uXQo01YFkXyY0MLL I93KypyV3PspZHe04wOCdFjAZ5iAKXzQg+KlR0eQraRUPZxIbi3SZ8NSxxkvyg/W0lJY MDCWndUHwAYZX/ecwHg1fd5cT5KLi6u/Apd05gFyJGrkF7AURpo+mIBK29OL6jx3vrz6 Wr54P2B1GKj+FeFrBectLKoXy6PI9dj77vgNw703gCiku/Zao9HLnc/N298LKrhPk8R1 jmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=UqJfXodysEXRMkzLt9SUsQ6nzcVInoXiEcfl6KqVvZs=; b=ahoFwLLBcbm42LyBY58IHPTxRmxrsbQ4ed+jgxdIS5nK7PwLCICes9/sN5rLkhCYOo ueWWWOV7jyhf50acTDPIYLGYWPPHWc+RynYdDcJOc6yJ2tvxxBqzgSuI9zUTKqfOxXOl Crt/DoFi+as986JDVoPpgW+0Ic3w5hiuhjQCIM405w2Tzyyfk/1pM4TwFDQQJLVR8kZq vqtbapGX7KGCtHGwXw9JkMCRfUg8UnhFTn2zwP7C6HiCfxihOQY0iVqoNpQLnyZtX0Pr amM/kBX9jghGzeNHpeLKb+TR8L5eg05iqb28oILeuQaA9JwFN0qdNRrsZ7yK/AjZxi6S K+Cg== X-Gm-Message-State: AMCzsaXTRLC/Q4x2TqkuHZtehXGDhtNgUGQQemQbWEHbfzdQlp5EpZvb JP+riUHZe7Q1Eey6eSD+upWEyg== X-Google-Smtp-Source: ABhQp+ReV1ijvdgQ2JKPFRh/HvjtXWlWpUeaYeRwd0E7sJqLjMQ8KXWtcKgEPtE88xE4bBQM1z7gfw== X-Received: by 10.25.23.90 with SMTP id n87mr1092313lfi.146.1509614096316; Thu, 02 Nov 2017 02:14:56 -0700 (PDT) Received: from magnolia (92-100-139-252.dynamic.avangarddsl.ru. [92.100.139.252]) by smtp.gmail.com with ESMTPSA id 17sm561055ljr.68.2017.11.02.02.14.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 02:14:55 -0700 (PDT) From: Oleg Pykhalov To: Marius Bakke Subject: Re: [bug#29099] [PATCH] gnu: Add kodi-cli. References: <8760au8pfk.fsf@gmail.com> <87a8054rd9.fsf@fastmail.com> Date: Thu, 02 Nov 2017 12:14:54 +0300 Message-ID: <87mv45vy7l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29099 Cc: 29099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Marius, Thank you for review! Marius Bakke writes: >> +(define-public kodi-cli >> + (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add suppo= rt for >> + (revision "1")) ; `$HOME/.k= odirc'. >> + (package >> + (name "kodi-cli") >> + (version (string-append "1.1-" revision "." (string-take commit 7= ))) >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference (url "https://github.com/nawar/kodi= -cli") >> + (commit commit))) >> + (sha256 >> + (base32 >> + "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5p= ")) >> + (file-name (string-append name "-" version "-checkout")= ))) >> + (build-system trivial-build-system) >> + (inputs `(("bash" ,bash))) >> + (propagated-inputs `(("curl" ,curl))) > > There is only one reference to `curl` in the script, can you try to > substitute it with the absolute path and make it a regular input? It's > good to avoid propagation when we can. Done. I also added input mps-youtube and did the same. >> + (arguments >> + `(#:modules ((guix build utils)) >> + #:builder >> + (begin >> + (use-modules (guix build utils)) >> + (copy-recursively (assoc-ref %build-inputs "source") ".") >> + (substitute* "kodi-cli" >> + (("/bin/bash") (string-append (assoc-ref %build-inputs "ba= sh") >> + "/bin/bash"))) >> + (install-file "kodi-cli" (string-append %output "/bin"))))) > > (install-file ...) has an unspecified return value, so please return #t h= ere. Done. >> + (home-page "https://github.com/nawar/kodi-cli") >> + (synopsis "Bash script to send commands to Kodi using JSON RPC") > > Maybe just "Control Kodi from the command line". Done. >> + (description "@code{kodi-cli} provides the Bash script to send co= mmands to >> +Kodi using JSON RPC. > > Similarly, this sentence can be reduced to something like > "@code{kodi-cli} is a tool for sending commands to a Kodi server using > JSON-RPC.". Bash is an boring implementation detail IMO. :-) Done. >> + >> +Feautures: > ^ Stray 'u' character. Done. >> + >> +@itemize >> +@item Play, pause, stop the current played video. > > "currently playing" Done. >> +@item Skip forward or backward in the current played video. > > Same here. Maybe it should be "currently playing item", since I assume > this works for music as well. Done. >> +@item Play or queue to the current list YouTube video. > > "List of YouTube videos"? Done. >> +@item Interactive and noninteractive volume control. >> +@item Interactive navigation. >> +@item Send text. > > What does this mean? Arbitrary commands, or text notifications? From=20my experience this allows you do the following: 1. Open Videos. 2. Add videos=E2=80=A6 3. Select . 4. Enter path by sending a command via 'kodi-cli -t PATH'. Maybe call this item of the feature list as =E2=80=9CSend text to the Kodi keyboard=E2=80=9D? New patch is attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-kodi-cli.patch Content-Transfer-Encoding: quoted-printable From=2082691aa8ec24ebad702867e006014f34eaceeb93 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Wed, 1 Nov 2017 09:39:05 +0300 Subject: [PATCH] gnu: Add kodi-cli. * gnu/packages/kodi.scm (kodi-cli): New variable. =2D-- gnu/packages/kodi.scm | 59 +++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 59 insertions(+) diff --git a/gnu/packages/kodi.scm b/gnu/packages/kodi.scm index c8a65af79..8c49f720a 100644 =2D-- a/gnu/packages/kodi.scm +++ b/gnu/packages/kodi.scm @@ -25,11 +25,13 @@ #:use-module (guix git-download) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) + #:use-module (guix build-system trivial) #:use-module (gnu packages algebra) #:use-module (gnu packages audio) #:use-module (gnu packages autotools) #:use-module (gnu packages avahi) #:use-module (gnu packages base) + #:use-module (gnu packages bash) #:use-module (gnu packages cdrom) #:use-module (gnu packages cmake) #:use-module (gnu packages compression) @@ -426,3 +428,60 @@ plug-in system.") license:public-domain ;cpluff/examples license:bsd-3 ;misc, gtest license:bsd-2))))) ;xbmc/freebsd + +(define-public kodi-cli + (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add support = for + (revision "1")) ; `$HOME/.kodi= rc'. + (package + (name "kodi-cli") + (version (string-append "1.1-" revision "." (string-take commit 7))) + (source (origin + (method git-fetch) + (uri (git-reference (url "https://github.com/nawar/kodi-cl= i") + (commit commit))) + (sha256 + (base32 + "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5p")) + (file-name (string-append name "-" version "-checkout")))) + (build-system trivial-build-system) + (inputs + `(("bash" ,bash) + ("curl" ,curl) + ("mps-youtube" ,mps-youtube))) + (arguments + `(#:modules ((guix build utils)) + #:builder + (begin + (use-modules (guix build utils)) + (copy-recursively (assoc-ref %build-inputs "source") ".") + (substitute* "kodi-cli" + (("/bin/bash") (string-append (assoc-ref %build-inputs "bash") + "/bin/bash")) + (("output=3D\\$\\((curl)" all curl) + (string-append "output=3D$(" + (assoc-ref %build-inputs "curl") + "/bin/" curl)) + (("play_youtube `(mpsyt)" all mpsyt) + (string-append "play_youtube `" + (assoc-ref %build-inputs "mps-youtube") + "/bin/" mpsyt))) + (install-file "kodi-cli" (string-append %output "/bin")) + #t))) + (home-page "https://github.com/nawar/kodi-cli") + (synopsis "Control Kodi from the command line") + (description "@code{kodi-cli} is a tool for sending commands to a Ko= di +server using JSON RPC. + +Features: + +@itemize +@item Play, pause, stop the current playing item. +@item Skip forward or backward in the current playing item. +@item Play or queue to the current list YouTube videos. +@item Interactive and noninteractive volume control. +@item Interactive navigation. +@item Send text. +@item Toggle fullscreen. +@item Update or clean Kodi libraries. +@end itemize\n") + (license license:gpl2+)))) =2D-=20 2.14.3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >> +@item Toggle fullscreen. >> +@item Update or clean Kodi libraries. >> +@end itemize\n") >> + (license license:gpl2+)))) > > LGTM with some cosmetic improvements. And welcome! > > By the way, if you use Kodi from Guix, feel free to update the 18 > snapshot if you can. My media PC died a while back, and I didn't get a > replacement yet, so I have not been able to maintain the Kodi package. OK. I do, but not much. Primarily use it on a =E2=80=9Cmedia tablet=E2=80= =9D. :-) Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAln64g4ACgkQckbhHGm3 lWmIsQ//ZH+Wv9+iApNTUZjYV7cGdnkWHfrTMt/xNj24yKQGi0qlR5x118J8aRFQ WA7b8oep9hy1WBOIXgK3yTsxuXtfq/f2suzPl7ckXrxhtEqUBcqZZtTnGoiGNBdI 2t/DqkKOWlZXOw/DTZaOnY2SlZ9Lqp72bSq663YRmnFuZhgBfpjydc+aJPwNl5np BBViS2CZZc/ii4EK1IqPzkpEtHBUsuXhqX/4CLPmduBUPKD8J1DrA0oTSGqxv4c8 wVYk1jHAvobjtjJvrfimcaf0PAC1+d135Rk1y3n2loWvyhJgyxJfp6pw5Y0eGNaM fP+vY3eVfNoszjJcWakgHRgUdjgabKMMwCm/S+lPYFwximMlDkCUjV5Z4SgMSwGh VsTePZfd0WYYwKwOfxNKhpen1N64Y4v8t8w+LHbgFuBtDZRrIotQVl/Gta4Scwo5 +k7RMxqfE/8uIKYeJ5UwcVWAoCr1mrtngiKyVdRQtswZUEubC2nN3WOEz3LAy/x4 u0vfXbLrnQ7JVHMGaEG4sO2/rhENIQeeC9j+7QLinrYgrtavs2VBCAlPRIyywwFd n3FxzOCG+H1asfFbZGyhyP1b8w1ZSwjsXh8q8uim7Ai9lH3SvkSLwOXUxVnJXIU5 hM5O8/XH3MkaaFo03/TqGx4WZ4TnxXB6ZwZ0IxamTLHsjMnGYkM= =11Ev -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 16:00:20 2017 Received: (at 29099) by debbugs.gnu.org; 2 Nov 2017 20:00:20 +0000 Received: from localhost ([127.0.0.1]:48298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eALf2-0006Pp-2j for submit@debbugs.gnu.org; Thu, 02 Nov 2017 16:00:20 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eALez-0006Pg-A7 for 29099@debbugs.gnu.org; Thu, 02 Nov 2017 16:00:19 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DE2C320C4F; Thu, 2 Nov 2017 16:00:16 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Thu, 02 Nov 2017 16:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=RPepIsWRSYAiU6VNh0J4ndDMs1FQpGMVKJLPjE+nrHc=; b=dHNB0emi 1oXyQqjBoI/NRllQJURvFYXcEecrWVuFSQ3Z0rCDtt39Ql176rlThTBExhLZAem1 vNNPnVgWwuFQ3wKYqNuxGGhksYYhwG72ZoXE2gqKopdWUAI4LkmwzzuIDFQTvpxa qDUZwzFFTyE19OUMB5r8cm6F8/gVfTk3SikYx8xCqmTX+dCtj6GrNg5wg+qdU0gz bfJ5sBAgbwHnAlZZFAQd+3Qn8fj10CLGqP8AdJGi2Q0e8INy1sR3r9WE2IjU4Bnz FCXy/Kgk82COHZHwMN9COaAKJO/DbP8SL6p4ZErZlbywOeD7uPQ5WX8hDZXRTpDJ lIjXMazZM0NvHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=RPepIsWRSYAiU6VNh0J4ndDMs1FQp GMVKJLPjE+nrHc=; b=oI2kyNMN23rkKI0S/RrKbKVY/0q/wDmaIsC/1ciDoBKQo P8bKPlm7nNq9//r8Dcmnu5O3al5qCN2ZPW75phbuucl6IQoEnIU5k4Pnpr5KlS4v imhuS3olcYkyKXnvQVev21dJUI/P6i31UYgaPz7jZvXL3Xg+C8KpxDXeF/L7nTKf tHHzfTAbEsu0gbasEpKY5Q5GAdz/O85BDhdmnFRetMYg+ngz5AqEhdrgPeQNOkFX dA/FHanOZuADqmxyFEO2lBfaecnFYc/18ixp0PxKzZkN2pENSwhAKKOKZFoBxXvf GcGDidljDl9UHRz3l1qxA94ib1/sOMgB5LouEZ+FA== X-ME-Sender: Received: from localhost (cm-84.214.173.174.getinternet.no [84.214.173.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F93B7F8DF; Thu, 2 Nov 2017 16:00:16 -0400 (EDT) From: Marius Bakke To: Oleg Pykhalov Subject: Re: [bug#29099] [PATCH] gnu: Add kodi-cli. In-Reply-To: <87mv45vy7l.fsf@gmail.com> References: <8760au8pfk.fsf@gmail.com> <87a8054rd9.fsf@fastmail.com> <87mv45vy7l.fsf@gmail.com> User-Agent: Notmuch/0.25.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Thu, 02 Nov 2017 21:00:14 +0100 Message-ID: <87zi8430z5.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29099 Cc: 29099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oleg Pykhalov writes: > Hello Marius, > > Thank you for review! > > Marius Bakke writes: > >>> +(define-public kodi-cli >>> + (let ((commit "104dc23b2a993c8e6db8c46f4f8bec24b146549b") ; Add supp= ort for >>> + (revision "1")) ; `$HOME/.= kodirc'. >>> + (package >>> + (name "kodi-cli") >>> + (version (string-append "1.1-" revision "." (string-take commit = 7))) >>> + (source (origin >>> + (method git-fetch) >>> + (uri (git-reference (url "https://github.com/nawar/kod= i-cli") >>> + (commit commit))) >>> + (sha256 >>> + (base32 >>> + "1xjhasc5gngfxpr1dlzy6q24w0wpdfjx12p43fanjppxw4i49n5= p")) >>> + (file-name (string-append name "-" version "-checkout"= )))) >>> + (build-system trivial-build-system) >>> + (inputs `(("bash" ,bash))) >>> + (propagated-inputs `(("curl" ,curl))) >> >> There is only one reference to `curl` in the script, can you try to >> substitute it with the absolute path and make it a regular input? It's >> good to avoid propagation when we can. > > Done. I also added input mps-youtube and did the same. Excellent. >>> +@item Interactive and noninteractive volume control. >>> +@item Interactive navigation. >>> +@item Send text. >> >> What does this mean? Arbitrary commands, or text notifications? > > From my experience this allows you do the following: > > 1. Open Videos. > 2. Add videos=E2=80=A6 > 3. Select . > 4. Enter path by sending a command via 'kodi-cli -t PATH'. > > Maybe call this item of the feature list as > =E2=80=9CSend text to the Kodi keyboard=E2=80=9D? "Send text to the Kodi keyboard" is much better, thanks! > New patch is attached. [...] > + (arguments > + `(#:modules ((guix build utils)) > + #:builder > + (begin > + (use-modules (guix build utils)) > + (copy-recursively (assoc-ref %build-inputs "source") ".") > + (substitute* "kodi-cli" > + (("/bin/bash") (string-append (assoc-ref %build-inputs "bas= h") > + "/bin/bash")) > + (("output=3D\\$\\((curl)" all curl) > + (string-append "output=3D$(" > + (assoc-ref %build-inputs "curl") > + "/bin/" curl)) > + (("play_youtube `(mpsyt)" all mpsyt) > + (string-append "play_youtube `" > + (assoc-ref %build-inputs "mps-youtube") > + "/bin/" mpsyt))) FYI, you could also use (which "curl") etc from (guix build utils) here, but I usually prefer this form. [...] > +@itemize > +@item Play, pause, stop the current playing item. > +@item Skip forward or backward in the current playing item. These should be "currently playing". > +@item Play or queue to the current list YouTube videos. "... current list of YouTube videos." (note the "of") LGTM otherwise. Don't forget to add a copyright line for yourself. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAln7eU8ACgkQoqBt8qM6 VPquawf+KndR6f5zs5LHkM3FzM8W+ero3tgPwAiWZeza+c3os9YZs9NrStOatchE XT6OViWp+rRKQt7viU+qqdBnV5lmREXbFXg+h8Wxzh9MCwpn++Gn80HqukYQSAJk k7Ay5PheaNulh3q2/Ydq+v/I4UpdbIwyJxNXN5KDmo1dMoMOZyJHChHHQ27/Cd26 32ttZxafN6StjJLZDd8S9useW4U3H+E8nzed+4vx0wv/CV2HIXv/qj9ErKfClmj3 30w08qk1iKKrQpOJJhJHqsljgL37sJg1xeB18gCY0V+FgYP/LrQar5dKV3fLp5lH HB4SgJ2ZewTEywCOnM7I/KjSNknuIA== =RL18 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 23:57:14 2017 Received: (at 29099) by debbugs.gnu.org; 3 Nov 2017 03:57:14 +0000 Received: from localhost ([127.0.0.1]:48540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAT6Y-0006gE-Gi for submit@debbugs.gnu.org; Thu, 02 Nov 2017 23:57:14 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:45378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAT6W-0006fv-Sx; Thu, 02 Nov 2017 23:57:13 -0400 Received: by mail-lf0-f54.google.com with SMTP id n69so1705165lfn.2; Thu, 02 Nov 2017 20:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pZLhAWbgOCQ5q60nOd2KSRlTsnvXEZWcOvltQAQXUFg=; b=ZVWOP4GnbhK6G8hxPpdFfozEClKOv6cIXcFlHXeevCBTMUMnlCoip/I4oUkZbce57X Nwul5rajvxXrWYHDMANTouQpRjwXi/wvP5cQtRB9aZnBDnOqtwdfYeQAq5KFqbaF8ADP QrUWRF4Bdj4J4qw3Selh3rOFl0f+YlslPq92A3TcqRvGPFWJzMQqzTA5nY7O5k7Obo9n I74HJt0OgV37vFECCe++uvuByzplYbScSJ7jrzGMN6TG7d6G0MLWOxZgioS4D7BLSDyy 3bEHJTiCkzqP7glipipxH2AtiERygtEKyoJT9h0VIK++DXEWPwzVuf9KpdBy+I3Xhj1f Qi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pZLhAWbgOCQ5q60nOd2KSRlTsnvXEZWcOvltQAQXUFg=; b=bltMSCKeWW42ILcHr9rDWSmUtJhhTx/0A0yrPP97hzmvp07ZI4C27LDJsOXn0DiuN7 u8j1xIoxMIY/SKNUB2qZu4MyVpmOnEVT/n6lUz5lg2ELNhzOyGUGX/gFARB6rsVPDYPx YLIuKGWiXCrx4rA/sBwffVW3Fb9qr/n6gkpBTZeWBHVFCBiMAdGvO3iYFR+g1+HBKtnQ lVy8X1zaJFiwdkopfsLJSKGuZEr2u+bGR/7DwAPgNdTIP5+kzq85FZDWw9psEVEa3XLa 8TNHEyEW82PPZnEC5IJbaSTAjos7WsatYwuYO0DzWS7ojHc3Jo/8ZalEE0XMwtoXkUem Htbg== X-Gm-Message-State: AJaThX6i7+wOY2T4FbFblrOVlvGEHwveuzJzicuZZ5y6/X5rjuySLZG8 R3WLNSMG6C7xoEj0zlpHighV1g== X-Google-Smtp-Source: ABhQp+QbIDaASVwaz44AeCyenQAfAI7IbaBo6UeQEusaX9LV9FOBlv0SbRL0Ap6fykvMX1S0zIiNXw== X-Received: by 10.25.83.133 with SMTP id h5mr1986993lfl.173.1509681426414; Thu, 02 Nov 2017 20:57:06 -0700 (PDT) Received: from magnolia ([178.70.177.246]) by smtp.gmail.com with ESMTPSA id p15sm1010986lje.24.2017.11.02.20.57.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 20:57:05 -0700 (PDT) From: Oleg Pykhalov To: Marius Bakke Subject: Re: [bug#29099] [PATCH] gnu: Add kodi-cli. References: <8760au8pfk.fsf@gmail.com> <87a8054rd9.fsf@fastmail.com> <87mv45vy7l.fsf@gmail.com> <87zi8430z5.fsf@fastmail.com> Date: Fri, 03 Nov 2017 06:57:05 +0300 In-Reply-To: <87zi8430z5.fsf@fastmail.com> (Marius Bakke's message of "Thu, 02 Nov 2017 21:00:14 +0100") Message-ID: <87fu9wggku.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29099 Cc: 29099-done@debbugs.gnu.org, 29099@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius Bakke writes: [...] >> Maybe call this item of the feature list as >> =E2=80=9CSend text to the Kodi keyboard=E2=80=9D? > > "Send text to the Kodi keyboard" is much better, thanks! > >> + (arguments >> + `(#:modules ((guix build utils)) >> + #:builder >> + (begin >> + (use-modules (guix build utils)) >> + (copy-recursively (assoc-ref %build-inputs "source") ".") >> + (substitute* "kodi-cli" >> + (("/bin/bash") (string-append (assoc-ref %build-inputs "ba= sh") >> + "/bin/bash")) >> + (("output=3D\\$\\((curl)" all curl) >> + (string-append "output=3D$(" >> + (assoc-ref %build-inputs "curl") >> + "/bin/" curl)) >> + (("play_youtube `(mpsyt)" all mpsyt) >> + (string-append "play_youtube `" >> + (assoc-ref %build-inputs "mps-youtube") >> + "/bin/" mpsyt))) > > FYI, you could also use (which "curl") etc from (guix build utils) here, > but I usually prefer this form. Thanks for notice. I prefer a form used in attached patch, too. >> +@itemize >> +@item Play, pause, stop the current playing item. >> +@item Skip forward or backward in the current playing item. > > These should be "currently playing". Done. >> +@item Play or queue to the current list YouTube videos. > > "... current list of YouTube videos." > > (note the "of") Done. > LGTM otherwise. Don't forget to add a copyright line for yourself. OK. I think it's fine to merge it now. Pushed as 72df48dbad95c3bc70a2962f496420ce3363d0de Oleg, Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAln76REACgkQckbhHGm3 lWnJnQ//dxqWnZQgjqyKchtZYabT1an0oGWvHSliWbFJBXU+ApwB5m/9LOsErDAe Ainf8Tj/+A4z0nnXtsTxIrpcvCmWljXd9zFNlNg0XqGoM150JhUPtppltWO/2dJ0 uWs3o6FnhcupLIfeSVGVA6tu+56hQ4SPZ/NO5jXz0C6/VbB5ABxEFq7clZhIkYiS IrlZNiE9wpGnkNxL1oVJDtTZFhR5cYE3R/lprZgDhtP4g5E87DnzbEJtgqyeWuI5 iZhSqvEGLgMxHRToIR7Qmu9eDb7c9AFaoE9b71NvP9B8w/5ApLVXynebr4rwaM5W q3qlromKKt+p7+s2Aon1vQquDsAIxNW6qFThOt9ChaknaJpL5aMf8PKHE2NWqN3T sfWK4ITrFZ06ge0YgzRcl/9WUKTDMAtR0qVJKoxwag51kjpuGzCPaDAeNCS/1Anp xToV0+S7YtAOq4ciPR+d9y0wArP1Rr4Lr0+emXIhc1KDAiBdYRcV86axwNdDl8tm VY1U/GxGnUoMvmE1+D+wMbyE9kbELINFn3YhN6hAaXknJXF1Lmpz8Bp4NagiQq4c biX11ACwQGzHZdaa/kxlEIf5Gpr8a4I8VwqrG2sMoM1MxXCicmYMZWuvpiIUWt8u jH47FOZIHXtACUPpI36uuPQV6Hx0PzHlp3+XWGR4CEIC/yQK+eg= =bknp -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 17:10:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Dec 2017 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator