From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 31 15:19:14 2017 Received: (at submit) by debbugs.gnu.org; 31 Oct 2017 19:19:14 +0000 Received: from localhost ([127.0.0.1]:44574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9c49-0004JQ-Qw for submit@debbugs.gnu.org; Tue, 31 Oct 2017 15:19:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9bpz-0003xM-EP for submit@debbugs.gnu.org; Tue, 31 Oct 2017 15:04:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9bpt-0007ZS-Bj for submit@debbugs.gnu.org; Tue, 31 Oct 2017 15:04:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9bpt-0007ZO-9S for submit@debbugs.gnu.org; Tue, 31 Oct 2017 15:04:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9bps-00086k-3t for bug-idutils@gnu.org; Tue, 31 Oct 2017 15:04:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9bpj-0007Sy-SN for bug-idutils@gnu.org; Tue, 31 Oct 2017 15:04:25 -0400 Received: from mail-qt0-x234.google.com ([2607:f8b0:400d:c0d::234]:48121) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9bpj-0007Sj-GI for bug-idutils@gnu.org; Tue, 31 Oct 2017 15:04:19 -0400 Received: by mail-qt0-x234.google.com with SMTP id z50so24304qtj.4 for ; Tue, 31 Oct 2017 12:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=PVPKZgpGkKXi/IqlqYVK8GY7XK73peh6Djye1Fbh3eo=; b=SARzLVJVM4+KB4VNEPn5TTARfA7TTyfCQ9LVJcmQSZL60c2tlyALYgFUWwm0rHfX0z tFA5r9cOKd3g6Am7FAk4tyMr5ye0YtiudhfeYt9Ur5bQRLC3MUrJf/AtAB+eHdsGInEd BwLP+398h0OOAlDaKu+T7x6ZugnA9G90G9DIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PVPKZgpGkKXi/IqlqYVK8GY7XK73peh6Djye1Fbh3eo=; b=t+mC+XkUeKhlKEpe0VOFz5CG+692BoA2kukhwDlx8czV0AFE8RIiYZUz26T8/pVgr6 HiR5oQNezauuhZfsLtzDOPCX/alfMN2NuAx1xYc0anT1myxauL0tn+jpq8OjPrJptoeP oWQBjxDhc6rLvBecg4K3AtWoeRg6FOaSXTmHVVNHi8yfE8r07HCnnux4yZ5q0v+gSDTQ J6/wpAcO3bqWzjnpypKmMqZ/01y8DDj9TbqdyzlZv6xtp4/euoZt9WcuhhjvuA7dPEIF 3AlNfCEZ2Axfwc3PecbvDcI46cx9lS3zW4ZdL8DlJzt48b72yqVQIhO4SzNtADGNPCG0 eqIQ== X-Gm-Message-State: AMCzsaVER3gIZk1BFZELyVegrPdts6EyWzlEsA0ysuzEvbw8vGH52ui/ hzNg0cjc9NBpLwVi/umfMusSQnRxh9A/ernZRZnppFef X-Google-Smtp-Source: ABhQp+QZf/Rc144ZmN4X6H59B5+iYk3FAEIP3xv/0XS15Pgrh9+w6g6F/9tKYSElw16isJrO9U8jOcUiTAdBXJQ7z1Q= X-Received: by 10.200.36.253 with SMTP id t58mr4778981qtt.105.1509476658225; Tue, 31 Oct 2017 12:04:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.37.141 with HTTP; Tue, 31 Oct 2017 12:03:57 -0700 (PDT) From: Curt McDowell Date: Tue, 31 Oct 2017 12:03:57 -0700 Message-ID: Subject: Bug related to 64-bit inodes To: bug-idutils@gnu.org Content-Type: multipart/alternative; boundary="001a113fdc5402bab7055cdc6c23" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 31 Oct 2017 15:19:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a113fdc5402bab7055cdc6c23 Content-Type: text/plain; charset="UTF-8" Hi, I'm running idutils 4.6 on Ubuntu 14.04 to index a large source base that is on an NFS-mounted filesystem that uses 64-bit inodes. mkid incorrectly issues many warnings such as the following: /home/csm/src/idutils-4.6/src/mkid: warning: `/df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py' and `/df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp' are the same file, but yield different scans! It turns out these inodes are equal in the lower 32 bits, but are not equal. % ls -li /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp 33776997256654722 -rwxr-xr-x 1 csm staff 3290 May 22 22:03 /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp 63050394834562946 -rw-r--r-- 1 csm staff 28973 May 22 22:03 /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py The inode numbers in hex are 780000030FEF82 and E00000030FEF82, respectively. I believe the bug is that the inode hash functions should account for the size of the di_ino field in case it is 8 bytes wide, rather than assuming they are always 4 bytes: /****************************************************************************/ /* Hash stuff for `struct dev_ino'. */ static unsigned long dev_ino_hash_1 (void const *key) { unsigned long result = 0; INTEGER_HASH_1 (((struct dev_ino const *) key)->di_dev, result); INTEGER_HASH_1 (((struct dev_ino const *) key)->di_ino, result); return result; } static unsigned long dev_ino_hash_2 (void const *key) { unsigned long result = 0; INTEGER_HASH_2 (((struct dev_ino const *) key)->di_dev, result); INTEGER_HASH_2 (((struct dev_ino const *) key)->di_ino, result); return result; } As an unrelated issue, in order to get idutils 4.6 to compile on Ubuntu 14.0.4 I had to edit lib/stdio.h and change "#if 1" to "#if 0" for the section that deals with the "gets" function (libc 2.19-0ubuntu6.13). Regards, -- Curt McDowell / Pure Storage / FlashBlade csm@purestorage.com --001a113fdc5402bab7055cdc6c23 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I'm running idutils 4.6 on Ubun= tu 14.04 to index a large source base that is on an NFS-mounted filesystem = that uses 64-bit inodes. mkid incorrectly issues many warnings such as the = following:

% ls -li /df-csm/ir-csm7/platform/dot/= ir/component/si5338/si5338.py /df-csm/ir-csm7/hardware/perf/CTRL_systemC/sr= c/demux.hpp
33776997256654722 -rwxr-xr-x 1 csm staff=C2=A0 3290 May 22 22:03 /df-csm/i= r-csm7/hardware/perf/CTRL_systemC/src/demux.hpp
63050394834562946 -rw-r--r-- 1 csm sta= ff 28973 May 22 22:03 /df-csm/ir-csm7/platform/dot/ir/component/si5338/si53= 38.py

The inode numbers in hex are=C2=A0780= 000030FEF82 and=C2=A0E00000030FEF82, respectively.

I believe the bug is that the inode hash functions should account for the = size of the di_ino field in case it is 8 bytes wide, rather than assuming t= hey are always 4 bytes:

/************************************************= ****************************/
/* Hash stuff for `struct dev_ino'.=C2=A0 */<= /div>

<= div>static unsigned long
dev_ino_hash_1= (void const *key)
{
= =C2=A0 unsigned long result =3D 0;
=C2=A0 INTEGER_HASH_1 (((struct dev_ino const *) ke= y)->di_dev, result);
=C2=A0 INTEGER_HASH_1 (((struct dev_ino const *) key)->di_i= no, result);
=C2=A0 return result;
}

st= atic unsigned long
dev_ino_hash_2 (void const *key)
{
=C2=A0 unsigned long result =3D 0;
=C2=A0 INTEGER_HASH_2 (((struc= t dev_ino const *) key)->di_dev, result);
=C2=A0 INTEGER_HASH_2 (((struct dev_ino c= onst *) key)->di_ino, result);
=C2=A0 return result;
}

A= s an unrelated issue, in order to get idutils 4.6 to compile on Ubuntu 14.0= .4 I had to edit lib/stdio.h and change "#if 1" to "#if 0&qu= ot; for the section that deals with the "gets" function (libc=C2= =A02.19-0ubuntu6.13).
=C2=A0
Regards,

--
Curt McDowell / Pure Storage / FlashBlade
csm@purestorage.com<= /a>
--001a113fdc5402bab7055cdc6c23-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 07 16:37:22 2017 Received: (at 29092) by debbugs.gnu.org; 7 Nov 2017 21:37:22 +0000 Received: from localhost ([127.0.0.1]:57167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCBYg-0000g5-Df for submit@debbugs.gnu.org; Tue, 07 Nov 2017 16:37:22 -0500 Received: from mail-qt0-f171.google.com ([209.85.216.171]:47397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCBYd-0000fp-If for 29092@debbugs.gnu.org; Tue, 07 Nov 2017 16:37:19 -0500 Received: by mail-qt0-f171.google.com with SMTP id z50so911106qtj.4 for <29092@debbugs.gnu.org>; Tue, 07 Nov 2017 13:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=gSrYyyMv9YN7xTwoqcZScaX+kJynx3CgdqZUeyCfiMY=; b=XXNN8g2JvgLgj6RRqgUxmQuWASf01+8bq/QwjfXi+yDT9sSNAj/HW+P4uF4bhFUt+/ ex/QRPE7sY4bPZB8UHduVAL0+6ObO9Nd/LWzxb76qKtA0K3EJhmpK/Lk7ONJyNwNp5Wf 32EOrdI+jSvCMHjbmvZHInlHZ0SAt90F7mRfL1d/+Mt/Ixmw047IwI1ASyh2FzWOj0o5 wSYGynJIwW1F8t6P0bNZrkv/DhPuE89xQv7PIyqBmsSKjx9CIbKJDeqWMc32mSFI5Pr3 psOjw2squaj5FdSNDluvHwV9cgnJvAwUEvS5wNzGu5AhZ2FsoLhaykvDb6y5Uggj9VB3 OFhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=gSrYyyMv9YN7xTwoqcZScaX+kJynx3CgdqZUeyCfiMY=; b=GRTIzrbKDa/OOBaG8sik7LSeILFm8EOTyQnNzqmpd1nemaElVS76W+hBTpil1UNVGW Cqk2KAMlgLMlaxLteuO5Fp7l+BUtSJ+hFEgAULDZoQW5LHx5mszkYMaZirRBK0Ut0jIA qHAiXoq1GZJW8pcOxa8pEkdsQ3HrnUyYoA10CJqwgpvjgOlu5RALEyPM5Ubyr0zpVRrX MeOkyJEUobv0WwF8P/X8qQDqCio2ctrxYLIQhx3UNJlNYwLoop+b6W2QtRYHbzrLylnF CJCiL9+jMm40aH2RRnXHjvsGrfZVQwrzDWujucBr4sx9Yy400SW+JP1riCxRJvA5ACcw vzfA== X-Gm-Message-State: AJaThX5bmgSY/T90SyNB2fNy4x8jtrGKRQvZgbfkLikRg5usCarQ1nB5 hFSkPQZzwc5P/5tc7F/DhFERkNq0x58Nbt2zRDI= X-Google-Smtp-Source: ABhQp+RflHyoTQyZQzaHzLOP6fqVFhB5jG8GTMf5pl8Ncx1qHLA81huoFzTUgaBxgPOOK0v46XJWLWGLF2h5ljJqP9o= X-Received: by 10.200.24.50 with SMTP id q47mr270612qtj.290.1510090634069; Tue, 07 Nov 2017 13:37:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.104.74 with HTTP; Tue, 7 Nov 2017 13:36:53 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Tue, 7 Nov 2017 13:36:53 -0800 X-Google-Sender-Auth: F6nOKHh6PDwgCHcEjTg5CPY-dag Message-ID: Subject: Re: [bug-idutils] bug#29092: Bug related to 64-bit inodes To: Curt McDowell Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 29092 Cc: 29092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Tue, Oct 31, 2017 at 12:03 PM, Curt McDowell wrote: > Hi, > > I'm running idutils 4.6 on Ubuntu 14.04 to index a large source base that is > on an NFS-mounted filesystem that uses 64-bit inodes. mkid incorrectly > issues many warnings such as the following: > > /home/csm/src/idutils-4.6/src/mkid: warning: > `/df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py' and > `/df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp' are the same > file, but yield different scans! > > It turns out these inodes are equal in the lower 32 bits, but are not equal. > > % ls -li /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py > /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp > 33776997256654722 -rwxr-xr-x 1 csm staff 3290 May 22 22:03 > /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp > 63050394834562946 -rw-r--r-- 1 csm staff 28973 May 22 22:03 > /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py > > The inode numbers in hex are 780000030FEF82 and E00000030FEF82, > respectively. > > I believe the bug is that the inode hash functions should account for the > size of the di_ino field in case it is 8 bytes wide, rather than assuming > they are always 4 bytes: > > /****************************************************************************/ > /* Hash stuff for `struct dev_ino'. */ > > static unsigned long > dev_ino_hash_1 (void const *key) > { > unsigned long result = 0; > INTEGER_HASH_1 (((struct dev_ino const *) key)->di_dev, result); > INTEGER_HASH_1 (((struct dev_ino const *) key)->di_ino, result); > return result; > } > > static unsigned long > dev_ino_hash_2 (void const *key) > { > unsigned long result = 0; > INTEGER_HASH_2 (((struct dev_ino const *) key)->di_dev, result); > INTEGER_HASH_2 (((struct dev_ino const *) key)->di_ino, result); > return result; > } > > As an unrelated issue, in order to get idutils 4.6 to compile on Ubuntu > 14.0.4 I had to edit lib/stdio.h and change "#if 1" to "#if 0" for the > section that deals with the "gets" function (libc 2.19-0ubuntu6.13). Thank you for the report. That is definitely a bug -- and it is over two decades old! I will fix this shortly, and will soon make a test release. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 16 19:59:13 2017 Received: (at 29092) by debbugs.gnu.org; 17 Dec 2017 00:59:13 +0000 Received: from localhost ([127.0.0.1]:37876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQNIJ-0002Eu-Q6 for submit@debbugs.gnu.org; Sat, 16 Dec 2017 19:59:13 -0500 Received: from mail-qt0-f180.google.com ([209.85.216.180]:34312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQNII-0002EQ-8g for 29092@debbugs.gnu.org; Sat, 16 Dec 2017 19:59:06 -0500 Received: by mail-qt0-f180.google.com with SMTP id 33so16356947qtv.1 for <29092@debbugs.gnu.org>; Sat, 16 Dec 2017 16:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Xdmd5uH4ivJ8+8uPO4/W67wieqmkZl9ai7MZEjxrh+4=; b=odJXC+WDgMvzoAmdaV4RUrlR853ms7hW4NB/0q67dbufbQpAtT8BKfzY94BOXG9qCf qxEtMaP0uO8ny00SKcYZOVPqcvi7XuRFYXLhjMwUweKQvBNBDVkGSbgzYUFSRo9gsqfg EwF2MaTQSN1xvOPciZ+CP8ZDNTVt/tyFq4v8XGeoAgrbdGdLIOL3zPRSDduv2ZFcqKZh Gv4F+dIR4OaGlxhoANxUAUnO7uBT4osheGyXdgAcTBohBhG6m8q6nmDud6Baymq9v9vM K/2JkscE5NMcHE6q0QgMYf6Xv0q9OJc4/HOJ/tmsM7NJ6a7X+ESLOGHRjnOcUQNoBcxw 42tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Xdmd5uH4ivJ8+8uPO4/W67wieqmkZl9ai7MZEjxrh+4=; b=hlwrcfzKcK0fgk6eTFElFb3Eop4TjxMqeDDXZ8Qf/LM9WqtGCQ0e74nSF92nrzQr4S O0Z69Uj7i/KvDmOX1wyLgTfcrcf2a1P2qI1Nv73JYGW0U0ueC5P9e+2cocc7VdukrF+d nrbECG0ItEhtx5l1uACnuxpYXs4oL4tZkumDGKgCOPvzuMins3uNtuLg7YKaYfhQjEX0 zeUf6Xrhvo9IHQU/rUtmwKxjnQu2fi5QoZpOpcQ1wvu6a60mCU3dAr05zQj/NhvAitXg i9XGnS3oz0j3W4X9Rd3DKOtyfbAX+e+9VeM+EoANWWWSqWO9w32tN9mz+meAxhCOX0cL ffsQ== X-Gm-Message-State: AKGB3mKRG/8oibFfmR7Cde98ZtfONlnGHD1JuEGnkxofXhhtrBKzDeYH x6xjxgtIupSOp34LgIA7ySacjIQec3QZag6GWAo= X-Google-Smtp-Source: ACJfBouYnCa/2GOKsGUxg9y32mr9z76D5IopT+mf7zv1uqIQPVRMUQNyj4wESmY2CqLDyWy0cSUnu/onlQ5A4tB98TY= X-Received: by 10.200.48.51 with SMTP id f48mr6347019qte.262.1513472339618; Sat, 16 Dec 2017 16:58:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.9.17 with HTTP; Sat, 16 Dec 2017 16:58:38 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Sat, 16 Dec 2017 16:58:38 -0800 X-Google-Sender-Auth: qrN5pH-UZAItXE7uP3kkMZle1pg Message-ID: Subject: Re: [bug-idutils] bug#29092: bug#29092: Bug related to 64-bit inodes To: Curt McDowell Content-Type: multipart/mixed; boundary="001a1137cf5a2ec67a05607ebdbe" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29092 Cc: 29092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a1137cf5a2ec67a05607ebdbe Content-Type: text/plain; charset="UTF-8" On Tue, Nov 7, 2017 at 1:36 PM, Jim Meyering wrote: > On Tue, Oct 31, 2017 at 12:03 PM, Curt McDowell wrote: >> Hi, >> >> I'm running idutils 4.6 on Ubuntu 14.04 to index a large source base that is >> on an NFS-mounted filesystem that uses 64-bit inodes. mkid incorrectly >> issues many warnings such as the following: >> >> /home/csm/src/idutils-4.6/src/mkid: warning: >> `/df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py' and >> `/df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp' are the same >> file, but yield different scans! >> >> It turns out these inodes are equal in the lower 32 bits, but are not equal. >> >> % ls -li /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py >> /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp >> 33776997256654722 -rwxr-xr-x 1 csm staff 3290 May 22 22:03 >> /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp >> 63050394834562946 -rw-r--r-- 1 csm staff 28973 May 22 22:03 >> /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py >> >> The inode numbers in hex are 780000030FEF82 and E00000030FEF82, >> respectively. >> >> I believe the bug is that the inode hash functions should account for the >> size of the di_ino field in case it is 8 bytes wide, rather than assuming >> they are always 4 bytes: >> >> /****************************************************************************/ >> /* Hash stuff for `struct dev_ino'. */ >> >> static unsigned long >> dev_ino_hash_1 (void const *key) >> { >> unsigned long result = 0; >> INTEGER_HASH_1 (((struct dev_ino const *) key)->di_dev, result); >> INTEGER_HASH_1 (((struct dev_ino const *) key)->di_ino, result); >> return result; >> } >> >> static unsigned long >> dev_ino_hash_2 (void const *key) >> { >> unsigned long result = 0; >> INTEGER_HASH_2 (((struct dev_ino const *) key)->di_dev, result); >> INTEGER_HASH_2 (((struct dev_ino const *) key)->di_ino, result); >> return result; >> } >> >> As an unrelated issue, in order to get idutils 4.6 to compile on Ubuntu >> 14.0.4 I had to edit lib/stdio.h and change "#if 1" to "#if 0" for the >> section that deals with the "gets" function (libc 2.19-0ubuntu6.13). > > Thank you for the report. > That is definitely a bug -- and it is over two decades old! > I will fix this shortly, and will soon make a test release. It wasn't as prompt as I would have liked, but here's a patch. I'll make a snapshot today and post separately to the bug-idutils list. --001a1137cf5a2ec67a05607ebdbe Content-Type: text/plain; charset="US-ASCII"; name="idu-inode-collision.diff" Content-Disposition: attachment; filename="idu-inode-collision.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jba2bgwx0 RnJvbSA2Y2RmZGU1MGQzZGQ4MWUyNDFjZDYyNzAwNTdhYzA3NTc0NjRmMGUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog VHVlLCA3IE5vdiAyMDE3IDIwOjA5OjA0IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gZml4IGhhbmRs aW5nIG9mIDY0LWJpdCBpbm9fdAoKVGhlIGRldi9pbm9kZSBoYXNoaW5nIGNvZGUgdXNlZCBvbmx5 IGZvdXIgYnl0ZXMgb2YgZWFjaCBpbm9kZSBudW1iZXIsCmFuZCB0aHVzIGNvdWxkIG1hbGZ1bmN0 aW9uOgogIG1raWQ6IHdhcm5pbmc6IGBmMScgYW5kIGBmMScgYXJlIHRoZSBzYW1lIGZpbGUsIGJ1 dCB5aWVsZCBkaWZmZXJlbnQgc2NhbnMhCiogbGliaWR1L3dhbGtlci5jIChkZXZfaW5vX2hhc2hf MSwgZGV2X2lub19oYXNoXzIpOiBBZGp1c3QgdG8gdXNlIGFsbCBieXRlcwpvZiBkZXZpY2UgYW5k IGlub2RlIG51bWJlcnMuCiogTkVXUyAoQnVncyk6IE1lbnRpb24gaXQuClJlcG9ydGVkIGJ5IEN1 cnQgTWNEb3dlbGwgaW4gaHR0cHM6Ly9idWdzLmdudS5vcmcvMjkwOTIKLS0tCiBORVdTICAgICAg ICAgICAgfCAgNCArKysrCiBsaWJpZHUvd2Fsa2VyLmMgfCA0NSArKysrKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9u cygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTkVXUyBiL05FV1MKaW5kZXggODFk MTliMS4uNWE4ZTk3OSAxMDA2NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC02LDYgKzYsMTAg QEAgR05VIGlkdXRpbHMgTkVXUyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LSotIG91dGxpbmUgLSotCgogICBsaWQgaXMgbm8gbG9uZ2VyIHN1c2NlcHRpYmxlIHRvIGEgYnVm ZmVyIG92ZXJydW4KCisgIG1raWQgbm8gbG9uZ2VyIG1pc3Rha2VubHkgd2FybnMgdGhhdCBkaWZm ZXJlbnQgZmlsZXMgYXJlIHRoZSBzYW1lIGJ1dAorICB3aXRoICJkaWZmZXJlbnQgc2NhbnMiIGZv ciBmaWxlcyB3aXRoIGNvbGxpZGluZyA2NC1iaXQgaW5vZGUgbnVtYmVycworICBbdGhlIGJ1ZyBk YXRlcyBiYWNrIHRvIHRoZSBpbml0aWFsIGltcGxlbWVudGF0aW9uXQorCgogKiBOb3Rld29ydGh5 IGNoYW5nZXMgaW4gcmVsZWFzZSA0LjYgKDIwMTItMDItMDMpIFtzdGFibGVdCgpkaWZmIC0tZ2l0 IGEvbGliaWR1L3dhbGtlci5jIGIvbGliaWR1L3dhbGtlci5jCmluZGV4IGUzMzIzMDUuLjgyYTIz OTIgMTAwNjQ0Ci0tLSBhL2xpYmlkdS93YWxrZXIuYworKysgYi9saWJpZHUvd2Fsa2VyLmMKQEAg LTExMDcsMjMgKzExMDcsMzYgQEAgbGlua3NfZGVwdGggKHN0cnVjdCBmaWxlX2xpbmsgY29uc3Qg KmZsaW5rKQogLyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCiAvKiBIYXNoIHN0dWZmIGZvciBgc3RydWN0 IGRldl9pbm8nLiAgKi8KCi1zdGF0aWMgdW5zaWduZWQgbG9uZwotZGV2X2lub19oYXNoXzEgKHZv aWQgY29uc3QgKmtleSkKLXsKLSAgdW5zaWduZWQgbG9uZyByZXN1bHQgPSAwOwotICBJTlRFR0VS X0hBU0hfMSAoKChzdHJ1Y3QgZGV2X2lubyBjb25zdCAqKSBrZXkpLT5kaV9kZXYsIHJlc3VsdCk7 Ci0gIElOVEVHRVJfSEFTSF8xICgoKHN0cnVjdCBkZXZfaW5vIGNvbnN0ICopIGtleSktPmRpX2lu bywgcmVzdWx0KTsKLSAgcmV0dXJuIHJlc3VsdDsKLX0KLQotc3RhdGljIHVuc2lnbmVkIGxvbmcK LWRldl9pbm9faGFzaF8yICh2b2lkIGNvbnN0ICprZXkpCi17Ci0gIHVuc2lnbmVkIGxvbmcgcmVz dWx0ID0gMDsKLSAgSU5URUdFUl9IQVNIXzIgKCgoc3RydWN0IGRldl9pbm8gY29uc3QgKikga2V5 KS0+ZGlfZGV2LCByZXN1bHQpOwotICBJTlRFR0VSX0hBU0hfMiAoKChzdHJ1Y3QgZGV2X2lubyBj b25zdCAqKSBrZXkpLT5kaV9pbm8sIHJlc3VsdCk7Ci0gIHJldHVybiByZXN1bHQ7CisvKiBGSVhN RTogY29uc2lkZXIgZHVtcGluZyBhbGwgb2YgdGhpcyBpbiBmYXZvciBvZiBnbnVsaWIncyBkaS1z ZXQgbW9kdWxlLiAgKi8KKy8qIEV4cGFuZCB0byB0aGUgZGVmaW5pdGlvbiBvZiBhIGZ1bmN0aW9u IHRoYXQgaGFzaGVzIGEgZGV2K2lub2RlIHBhaXIsCisgICB3aXRoIGFwcGxpY2F0aW9uIG9mIFhG T1JNLiAgKi8KKyNkZWZpbmUgREVWX0lOT19IQVNIX0RFRlVOKEZOX05BTUUsIFhGT1JNKQkJCQlc CitzdGF0aWMgc2l6ZV90IF9HTF9BVFRSSUJVVEVfUFVSRQkJCQkJXAorRk5fTkFNRSAodm9pZCBj b25zdCAqeCkJCQkJCQkJXAorewkJCQkJCQkJCVwKKyAgc3RydWN0IGRldl9pbm8gY29uc3QgKnAg PSB4OwkJCQkJCVwKKyAgaW5vX3QgaW5vID0gcC0+ZGlfaW5vOwkJCQkJCVwKKwkJCQkJCQkJCVwK KyAgLyogV2hlbiBJTk8gaXMgd2lkZXIgdGhhbiBzaXplX3QsIFhPUiB0aGUgd29yZHMgb2YgSU5P IGludG8gSC4JXAorICAgICBUaGlzIGF2b2lkcyBsb3NzIG9mIGluZm8sIHdpdGhvdXQgYXBwbHlp bmcgJSB0byB0aGUgd2lkZXIgdHlwZSwJXAorICAgICB3aGljaCBjb3VsZCBiZSBxdWl0ZSBzbG93 IG9uIHNvbWUgc3lzdGVtcy4gICovCQkJXAorICBzaXplX3QgaCA9IFhGT1JNIChpbm8pOwkJCQkJ CVwKKyAgdW5zaWduZWQgaW50IG5fd29yZHMgPSBzaXplb2YgaW5vIC8gc2l6ZW9mIGggKyAoc2l6 ZW9mIGlubyAlIHNpemVvZiBoICE9IDApOyBcCisgIGZvciAodW5zaWduZWQgaW50IGkgPSAxOyBp IDwgbl93b3JkczsgaSsrKQkJCQlcCisgICAgaCBePSBYRk9STSAoaW5vID4+IENIQVJfQklUICog c2l6ZW9mIGggKiBpKTsJCQlcCisJCQkJCQkJCQlcCisgIGRldl90IGRldiA9IHAtPmRpX2RldjsJ CQkJCQlcCisgIGggXj0gWEZPUk0gKGRldik7CQkJCQkJCVwKKyAgbl93b3JkcyA9IHNpemVvZiBk ZXYgLyBzaXplb2YgaCArIChzaXplb2YgZGV2ICUgc2l6ZW9mIGggIT0gMCk7CVwKKyAgZm9yICh1 bnNpZ25lZCBpbnQgaSA9IDE7IGkgPCBuX3dvcmRzOyBpKyspCQkJCVwKKyAgICBoIF49IFhGT1JN IChkZXYgPj4gQ0hBUl9CSVQgKiBzaXplb2YgaCAqIGkpOwkJCVwKKwkJCQkJCQkJCVwKKyAgcmV0 dXJuIGg7CQkJCQkJCQlcCiB9CitzdGF0aWMgaW5saW5lIHNpemVfdCB4Zm9ybV9OT1AgKHNpemVf dCBrKSB7IHJldHVybiBrOyB9CitzdGF0aWMgaW5saW5lIHNpemVfdCB4Zm9ybV9OT1QgKHNpemVf dCBrKSB7IHJldHVybiB+azsgfQorREVWX0lOT19IQVNIX0RFRlVOKGRldl9pbm9faGFzaF8xLCB4 Zm9ybV9OT1ApCitERVZfSU5PX0hBU0hfREVGVU4oZGV2X2lub19oYXNoXzIsIHhmb3JtX05PVCkK CiBzdGF0aWMgaW50CiBkZXZfaW5vX2hhc2hfY29tcGFyZSAodm9pZCBjb25zdCAqeCwgdm9pZCBj b25zdCAqeSkKLS0gCjIuMTUuMS4zNTQuZzk1ZWM2YjFiMwoK --001a1137cf5a2ec67a05607ebdbe-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 18 18:31:46 2017 Received: (at 29092) by debbugs.gnu.org; 18 Dec 2017 23:31:46 +0000 Received: from localhost ([127.0.0.1]:40943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR4ss-00004u-8v for submit@debbugs.gnu.org; Mon, 18 Dec 2017 18:31:46 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:37606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR4sq-0008WL-5x for 29092@debbugs.gnu.org; Mon, 18 Dec 2017 18:31:44 -0500 Received: by mail-qk0-f178.google.com with SMTP id p13so4428185qke.4 for <29092@debbugs.gnu.org>; Mon, 18 Dec 2017 15:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=emYAC7COHGcVfa/yPNK7Z55PmiTVveGR0qZByp5GlXM=; b=fOMffLEAkiwR7jTthmHgEoJrN2Kc5SsLMSXhmQ5GCEleqzIJh5EnX3eNAg0/Gdg2V0 oMp/t49FJaRD+pk6NIhJnQ8HOV6fCCRyas/5bkD0ouJOg8b6VwOEUfdzItwFBhDg0HY7 KN82BsDraH01ywTBTBu3ng143vCsjjbBZUyA4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=emYAC7COHGcVfa/yPNK7Z55PmiTVveGR0qZByp5GlXM=; b=OGRS3Pu7r14cuyjawhuR2T1BKtSufF8wqLfg76G2nRUn1I9jElzjBuSoUdUXXrtmCF tN4a8Abgdr6pjhD146v25AdZVai1CZGpo+5zcDgDtrvl66G5yyspblbbKSuimtX7mcLn 5ITkd5yh+q+hpRMamqfrkRqYQNW8opbv8PEB6LBNi0higpD2t1I9ITJXxjx3XvvmvmFt DTSyMWZ85aGSs/0a6vj1L3cOAW5PEkQj9HFoe6hSotWY1qzFeTJxZ3fNC7B/zl44YCNv sqT6tOtWo3ykdDXxkS8FxEXaX6NeC1IZeo2qv+11I62PdFQrOzEoE/cJpcrfs2o67g3C hvCg== X-Gm-Message-State: AKGB3mLhY0BiDj4q96VWuGGSe8h3CWA0kjB6SiO7/mAV7wpvPaZ6zHIM PUzNGQRcTe+bJd6NgwrSIP9aqHcIAAmSVkCCQYVF6jLR X-Google-Smtp-Source: ACJfBovXY6H2BXfSFqnVAM+AJY1Pt0WGV1iaA/loKxM7OBO1hqG33s3lLnK7+kQOKyPYerDfSohXk5rI7jV8VywLq0I= X-Received: by 10.233.235.207 with SMTP id b198mr2285257qkg.55.1513639898419; Mon, 18 Dec 2017 15:31:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.47.210 with HTTP; Mon, 18 Dec 2017 15:31:17 -0800 (PST) In-Reply-To: References: From: Curt McDowell Date: Mon, 18 Dec 2017 15:31:17 -0800 Message-ID: Subject: Re: [bug-idutils] bug#29092: bug#29092: Bug related to 64-bit inodes To: Jim Meyering Content-Type: multipart/alternative; boundary="001a114f1f0276ae770560a5c0c8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29092 Cc: 29092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --001a114f1f0276ae770560a5c0c8 Content-Type: text/plain; charset="UTF-8" Jim, Thanks for getting to this. I applied the patch and was surprised to see it still has the same bug! There is another comparison function that needs fixing. I verified that 64-bit inodes work properly with this additional change: static int dev_ino_hash_compare (void const *x, void const *y) { int result; result = memcmp(&((struct dev_ino const *) x)->di_ino, &((struct dev_ino const *) y)->di_ino, sizeof (ino_t)); if (result) return result; result = memcmp(&((struct dev_ino const *) x)->di_dev, &((struct dev_ino const *) y)->di_dev, sizeof (ino_t)); return result; } On Sat, Dec 16, 2017 at 4:58 PM, Jim Meyering wrote: > On Tue, Nov 7, 2017 at 1:36 PM, Jim Meyering wrote: > > On Tue, Oct 31, 2017 at 12:03 PM, Curt McDowell > wrote: > >> Hi, > >> > >> I'm running idutils 4.6 on Ubuntu 14.04 to index a large source base > that is > >> on an NFS-mounted filesystem that uses 64-bit inodes. mkid incorrectly > >> issues many warnings such as the following: > >> > >> /home/csm/src/idutils-4.6/src/mkid: warning: > >> `/df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py' and > >> `/df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp' are the same > >> file, but yield different scans! > >> > >> It turns out these inodes are equal in the lower 32 bits, but are not > equal. > >> > >> % ls -li /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py > >> /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp > >> 33776997256654722 -rwxr-xr-x 1 csm staff 3290 May 22 22:03 > >> /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp > >> 63050394834562946 -rw-r--r-- 1 csm staff 28973 May 22 22:03 > >> /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py > >> > >> The inode numbers in hex are 780000030FEF82 and E00000030FEF82, > >> respectively. > >> > >> I believe the bug is that the inode hash functions should account for > the > >> size of the di_ino field in case it is 8 bytes wide, rather than > assuming > >> they are always 4 bytes: > >> > >> /*********************************************************** > *****************/ > >> /* Hash stuff for `struct dev_ino'. */ > >> > >> static unsigned long > >> dev_ino_hash_1 (void const *key) > >> { > >> unsigned long result = 0; > >> INTEGER_HASH_1 (((struct dev_ino const *) key)->di_dev, result); > >> INTEGER_HASH_1 (((struct dev_ino const *) key)->di_ino, result); > >> return result; > >> } > >> > >> static unsigned long > >> dev_ino_hash_2 (void const *key) > >> { > >> unsigned long result = 0; > >> INTEGER_HASH_2 (((struct dev_ino const *) key)->di_dev, result); > >> INTEGER_HASH_2 (((struct dev_ino const *) key)->di_ino, result); > >> return result; > >> } > >> > >> As an unrelated issue, in order to get idutils 4.6 to compile on Ubuntu > >> 14.0.4 I had to edit lib/stdio.h and change "#if 1" to "#if 0" for the > >> section that deals with the "gets" function (libc 2.19-0ubuntu6.13). > > > > Thank you for the report. > > That is definitely a bug -- and it is over two decades old! > > I will fix this shortly, and will soon make a test release. > > It wasn't as prompt as I would have liked, but here's a patch. > I'll make a snapshot today and post separately to the bug-idutils list. > -- Curt McDowell / Pure Storage / FlashBlade csm@purestorage.com --001a114f1f0276ae770560a5c0c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Jim,

Thanks for getting to this. I appl= ied the patch and was surprised to see it still has the same bug! There is = another comparison function that needs fixing. I verified that 64-bit inode= s work properly with this additional change:

= static int
dev_ino_hash_compare (void const *x, void const *y)
{
=C2=A0 int result;
=C2=A0 result =3D memcmp(&= amp;((struct dev_ino const *) x)->di_ino,
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &((struct dev_ino const *) y= )->di_ino, sizeof (ino_t));
=C2=A0 if (result)
=C2= =A0 =C2=A0 return result;
=C2=A0 result =3D memcmp(&((struct = dev_ino const *) x)->di_dev,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &((struct dev_ino const *) y)->di_de= v, sizeof (ino_t));
=C2=A0 return result;
}
=

On Sat, Dec= 16, 2017 at 4:58 PM, Jim Meyering <jim@meyering.net> wrote:<= br>
On Tue, Nov 7, 2017 at 1:36 PM, Jim Meyer= ing <jim@meyering.net> wrote:=
> On Tue, Oct 31, 2017 at 12:03 PM, Curt McDowell <csm@purestorage.com> wrote:
>> Hi,
>>
>> I'm running idutils 4.6 on Ubuntu 14.04 to index a large sourc= e base that is
>> on an NFS-mounted filesystem that uses 64-bit inodes. mkid incorre= ctly
>> issues many warnings such as the following:
>>
>> /home/csm/src/idutils-4.6/src/mkid: warning:
>> `/df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py&#= 39; and
>> `/df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hp= p' are the same
>> file, but yield different scans!
>>
>> It turns out these inodes are equal in the lower 32 bits, but are = not equal.
>>
>> % ls -li /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5= 338.py
>> /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp
>> 33776997256654722 -rwxr-xr-x 1 csm staff=C2=A0 3290 May 22 22:03 >> /df-csm/ir-csm7/hardware/perf/CTRL_systemC/src/demux.hpp
>> 63050394834562946 -rw-r--r-- 1 csm staff 28973 May 22 22:03
>> /df-csm/ir-csm7/platform/dot/ir/component/si5338/si5338.py >>
>> The inode numbers in hex are 780000030FEF82 and E00000030FEF82, >> respectively.
>>
>> I believe the bug is that the inode hash functions should account = for the
>> size of the di_ino field in case it is 8 bytes wide, rather than a= ssuming
>> they are always 4 bytes:
>>
>> /***********************************************************<= wbr>*****************/
>> /* Hash stuff for `struct dev_ino'.=C2=A0 */
>>
>> static unsigned long
>> dev_ino_hash_1 (void const *key)
>> {
>>=C2=A0 =C2=A0unsigned long result =3D 0;
>>=C2=A0 =C2=A0INTEGER_HASH_1 (((struct dev_ino const *) key)->di_= dev, result);
>>=C2=A0 =C2=A0INTEGER_HASH_1 (((struct dev_ino const *) key)->di_= ino, result);
>>=C2=A0 =C2=A0return result;
>> }
>>
>> static unsigned long
>> dev_ino_hash_2 (void const *key)
>> {
>>=C2=A0 =C2=A0unsigned long result =3D 0;
>>=C2=A0 =C2=A0INTEGER_HASH_2 (((struct dev_ino const *) key)->di_= dev, result);
>>=C2=A0 =C2=A0INTEGER_HASH_2 (((struct dev_ino const *) key)->di_= ino, result);
>>=C2=A0 =C2=A0return result;
>> }
>>
>> As an unrelated issue, in order to get idutils 4.6 to compile on U= buntu
>> 14.0.4 I had to edit lib/stdio.h and change "#if 1" to &= quot;#if 0" for the
>> section that deals with the "gets" function (libc 2.19-0= ubuntu6.13).
>
> Thank you for the report.
> That is definitely a bug -- and it is over two decades old!
> I will fix this shortly, and will soon make a test release.

It wasn't as prompt as I would have liked, but here's a patch.
I'll make a snapshot today and post separately to the bug-idutils list.=



--
Curt McDowell / Pure Storage / Fl= ashBlade
--001a114f1f0276ae770560a5c0c8-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 18 23:37:23 2017 Received: (at 29092) by debbugs.gnu.org; 19 Dec 2017 04:37:23 +0000 Received: from localhost ([127.0.0.1]:41031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR9ed-0000nG-7D for submit@debbugs.gnu.org; Mon, 18 Dec 2017 23:37:23 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:38188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR9eb-0000n4-RI for 29092@debbugs.gnu.org; Mon, 18 Dec 2017 23:37:22 -0500 Received: by mail-qk0-f171.google.com with SMTP id i190so692463qka.5 for <29092@debbugs.gnu.org>; Mon, 18 Dec 2017 20:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0lO4lzOIFl2ezR7EGajHKQCCMN+cWI80DhylPH0CBdQ=; b=Cp7Z1PrFGzbuRJlBPLHsZVSuxocduLm8HMlPIUNKRCY2hQ5TMxJVxsBvM5nUE5JhBp A079rGLYVSGWb6+tz/9u+SOcbtO9azaXNDTxhIe0RWcsGpoZDwNebcD6MVnLu6lZMapc RtCLBxLwarehGrTKEv3O4b9iUdKCeauQHuGhQ42PXvdVV57mlP0wmVOzFF9l2j9ZwwK9 vCr/pqhWpCWLPjAQyJxIFdeQzElNdYokvzz81M9ZOLTax0BcYP4os45jC5kJ6evMS2Iy o1fik6h7DVXieKpK62dSa1I9hd4KTz2eVuz/K7unm+sVEZ5W2KAs2DtEuAW+JYi23pSx fhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=0lO4lzOIFl2ezR7EGajHKQCCMN+cWI80DhylPH0CBdQ=; b=EqkVgGFX+DzndYUA4uyNrPKsObXTNQNTCCwdxyAIJERlhcXz6fj4Hd5X+h+sc1wbLY n88aYxLkYfPKwaS8GbpO7XNB7sjym/j6BtRpTOIhR64Icg7GaOr3zVfLdzyxhPhebunG V3taafgXJzbOmQHrYBRjTHTYRRNQDIKlMN61fmHzmJytXGAtkS9GCxqyVAu4/vqywisc bpmXCWWa+hIvAtckxthdPBBuSCFxSF5dqDTtSfxDfucI/JZFt5VlPNJhR54Tj5NPWqmc OQAGH2IxV0asPzDQeNeF50ALG9joeW9tIJDwbCQSftKhKci8B46IL6zBz9T4S8l4fbk4 qAkA== X-Gm-Message-State: AKGB3mK4uc92Vghj/YXSp9KneLIkTR7NKRbURRwbwnhVJQtNVIa2HJH9 EH76hq6Sz8GYT2Otz09bHYIZWZkWIwD+vKVJgIs= X-Google-Smtp-Source: ACJfBovOXWVrQCyFb+Sn0Pe6/3PcUNWAm/T/IHAZRqQmIz2/UA+xWzKziKSs6a0naHEe3Tx4qrvQh1drw0JSvmL1c+4= X-Received: by 10.55.214.144 with SMTP id p16mr3002575qkl.299.1513658236223; Mon, 18 Dec 2017 20:37:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.164.10 with HTTP; Mon, 18 Dec 2017 20:36:55 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Mon, 18 Dec 2017 20:36:55 -0800 X-Google-Sender-Auth: 8ROFFigf35gllNzZjD5jldPuC2o Message-ID: Subject: Re: [bug-idutils] bug#29092: bug#29092: Bug related to 64-bit inodes To: Curt McDowell Content-Type: multipart/mixed; boundary="001a114797fc7b68260560aa05e6" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29092 Cc: 29092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a114797fc7b68260560aa05e6 Content-Type: text/plain; charset="UTF-8" On Mon, Dec 18, 2017 at 3:31 PM, Curt McDowell wrote: > Jim, > > Thanks for getting to this. I applied the patch and was surprised to see it > still has the same bug! There is another comparison function that needs > fixing. I verified that 64-bit inodes work properly with this additional > change: > > static int > dev_ino_hash_compare (void const *x, void const *y) > { > int result; > result = memcmp(&((struct dev_ino const *) x)->di_ino, > &((struct dev_ino const *) y)->di_ino, sizeof (ino_t)); > if (result) > return result; > result = memcmp(&((struct dev_ino const *) x)->di_dev, > &((struct dev_ino const *) y)->di_dev, sizeof (ino_t)); > return result; > } Thank you for the quick testing and patch. I've simplified that but left it in your name. However, since it's still in your name, yet modified, I'll wait for your ACK before pushing (check both author-name+email and wording of the commit log as well as the actual patch, since we treat master-pushed commits as immutable): --001a114797fc7b68260560aa05e6 Content-Type: text/plain; charset="US-ASCII"; name="idu-inode-collision-2.diff" Content-Disposition: attachment; filename="idu-inode-collision-2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jbd4yy3s0 RnJvbSBjMTJjMmI2YjNlZGU1MWNhYmY1OTA5MmIzZDA5YmQyMTcxNTM0ZGRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDdXJ0IE1jRG93ZWxsIDxjc21AcHVyZXN0b3JhZ2UuY29tPgpE YXRlOiBNb24sIDE4IERlYyAyMDE3IDIwOjMyOjE4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gY29t cGFyZSBmdWxsIDgtYnl0ZSBpbm9kZXMgaW4gb25lIG1vcmUgcGxhY2UKCiogbGliaWR1L3dhbGtl ci5jIChkZXZfaW5vX2hhc2hfY29tcGFyZSk6IFJld3JpdGUgdG8gY29tcGFyZSBib3RoCmRldmlj ZSBhbmQgZnVsbCBpbm9kZS4KLS0tCiBsaWJpZHUvd2Fsa2VyLmMgfCAxMyArKysrLS0tLS0tLS0t CiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpYmlkdS93YWxrZXIuYyBiL2xpYmlkdS93YWxrZXIuYwppbmRleCA4MmEyMzkyLi5h MjFlMjM5IDEwMDY0NAotLS0gYS9saWJpZHUvd2Fsa2VyLmMKKysrIGIvbGliaWR1L3dhbGtlci5j CkBAIC0xMTM5LDE2ICsxMTM5LDExIEBAIERFVl9JTk9fSEFTSF9ERUZVTihkZXZfaW5vX2hhc2hf MSwgeGZvcm1fTk9QKQogREVWX0lOT19IQVNIX0RFRlVOKGRldl9pbm9faGFzaF8yLCB4Zm9ybV9O T1QpCgogc3RhdGljIGludAotZGV2X2lub19oYXNoX2NvbXBhcmUgKHZvaWQgY29uc3QgKngsIHZv aWQgY29uc3QgKnkpCitkZXZfaW5vX2hhc2hfY29tcGFyZSAodm9pZCBjb25zdCAqeHYsIHZvaWQg Y29uc3QgKnl2KQogewotICBpbnQgcmVzdWx0OwotICBJTlRFR0VSX0NPTVBBUkUgKCgoc3RydWN0 IGRldl9pbm8gY29uc3QgKikgeCktPmRpX2lubywKLQkJICAgKChzdHJ1Y3QgZGV2X2lubyBjb25z dCAqKSB5KS0+ZGlfaW5vLCByZXN1bHQpOwotICBpZiAocmVzdWx0KQotICAgIHJldHVybiByZXN1 bHQ7Ci0gIElOVEVHRVJfQ09NUEFSRSAoKChzdHJ1Y3QgZGV2X2lubyBjb25zdCAqKSB4KS0+ZGlf ZGV2LAotCQkgICAoKHN0cnVjdCBkZXZfaW5vIGNvbnN0ICopIHkpLT5kaV9kZXYsIHJlc3VsdCk7 Ci0gIHJldHVybiByZXN1bHQ7CisgIHN0cnVjdCBkZXZfaW5vIGNvbnN0ICp4ID0geHY7CisgIHN0 cnVjdCBkZXZfaW5vIGNvbnN0ICp5ID0geXY7CisgIHJldHVybiB4LT5kaV9pbm8gPT0geS0+ZGlf aW5vICYmIHgtPmRpX2RldiA9PSB5LT5kaV9kZXY7CiB9CgogI2VuZGlmCi0tIAoyLjE1LjEuMzU0 Lmc5NWVjNmIxYjMKCg== --001a114797fc7b68260560aa05e6-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 05 23:28:20 2018 Received: (at 29092) by debbugs.gnu.org; 6 Jan 2018 04:28:20 +0000 Received: from localhost ([127.0.0.1]:37497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXg5k-0003QW-0Y for submit@debbugs.gnu.org; Fri, 05 Jan 2018 23:28:20 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:44955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXg5h-0003QJ-UZ for 29092@debbugs.gnu.org; Fri, 05 Jan 2018 23:28:18 -0500 Received: by mail-qk0-f193.google.com with SMTP id v188so8394252qkh.11 for <29092@debbugs.gnu.org>; Fri, 05 Jan 2018 20:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=w+hHRnGdZQGF/TdPd3xihxi0hxoa+sgW5tCsrHC2DMc=; b=eZwHNDrCXvnEUMp9I0JbTIoXZ+VbicAsAGSDJcG/GF9D2S7cHhvxjhLonvr9b7AvTJ A/hV0sGFzfZeVERNLaa0NUPEi4GCC6ha36c0aF2ecvITuei+GbMa7+6c71V7Td/8Z+fh XgGmE4wnAAh05jCvkBh3mBtHfocnIp62ixGWER93B6QcZxuxmk1yykJyXNXldUJPI1XW OMV2TmGMu5cfKn9hSe0L56MslN0h/eecZFZrEGCSepexWMrqzYMYZexDiLgrAKP7+rwD n+40j3o3vB/0l7a7HcdrQJrp4faVSrYL+oo5I2cC9jLnikV2wox6fY6vPkABL+pNXZDi WNbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=w+hHRnGdZQGF/TdPd3xihxi0hxoa+sgW5tCsrHC2DMc=; b=BXPnt/SP0eEkdWcy1v3tn3kPRr7QAJw/CFYtN8Ha/EPUGj06zYsQ4JNLhamj1jEczC XUGAqXtOcLmFGfupI2Bh4NBOvgq1buLpm8L5qKz9WrnTodnFPPTwJrIAwa3OW/uLU7lJ yEZVKjvGwRzgDfFNWd+Tqv4n/PDolDdGADTWxclwiYybM419cEChLO8DdupKdn+NPoWp MBHXaPZ1UspueBpH/Ftcm+zuG2Q+857cIw7SeNCznFfzBECWLsqicv37B38lTiTShc2+ vmwuYrzYc++64rk7VFDrV6PYKI0jqOXoF5AL2WtnJu/5vChBMqJ92CerIhFh2yDPSbGw iGsA== X-Gm-Message-State: AKGB3mILRBvYCyj2no9h/h4e5Bd0uhUNQYrDt6bpauXlLK0Eid0EwWAu QIkkEtdY6X7A7iyfhHqR2X9LzayPSyYj+Syy2a4= X-Google-Smtp-Source: ACJfBovX9y2tS62UIwjQkRY/csfogwWeqz17KDtZE4S4Mp3xdkBCwSNPyF56v4bWp1tqVsyRKIQG00byoISe2pb6QuM= X-Received: by 10.55.102.216 with SMTP id a207mr7363841qkc.75.1515212892365; Fri, 05 Jan 2018 20:28:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.164.10 with HTTP; Fri, 5 Jan 2018 20:27:51 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Fri, 5 Jan 2018 20:27:51 -0800 X-Google-Sender-Auth: ilE25TqN6pxwtJgqbMZk-xCQM4g Message-ID: Subject: Re: [bug-idutils] bug#29092: bug#29092: Bug related to 64-bit inodes To: Curt McDowell Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29092 Cc: 29092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Mon, Dec 18, 2017 at 8:36 PM, Jim Meyering wrote: > On Mon, Dec 18, 2017 at 3:31 PM, Curt McDowell wrote: >> Jim, >> >> Thanks for getting to this. I applied the patch and was surprised to see it >> still has the same bug! There is another comparison function that needs >> fixing. I verified that 64-bit inodes work properly with this additional >> change: >> >> static int >> dev_ino_hash_compare (void const *x, void const *y) >> { >> int result; >> result = memcmp(&((struct dev_ino const *) x)->di_ino, >> &((struct dev_ino const *) y)->di_ino, sizeof (ino_t)); >> if (result) >> return result; >> result = memcmp(&((struct dev_ino const *) x)->di_dev, >> &((struct dev_ino const *) y)->di_dev, sizeof (ino_t)); >> return result; >> } > > Thank you for the quick testing and patch. > > I've simplified that but left it in your name. However, since it's > still in your name, yet modified, I'll wait for your ACK before > pushing (check both author-name+email and wording of the commit log as > well as the actual patch, since we treat master-pushed commits as > immutable): Ping? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 06 19:56:58 2018 Received: (at 29092) by debbugs.gnu.org; 7 Jan 2018 00:56:59 +0000 Received: from localhost ([127.0.0.1]:38581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXzGk-0007dP-Ms for submit@debbugs.gnu.org; Sat, 06 Jan 2018 19:56:58 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:41337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXzGi-0007dA-5D for 29092@debbugs.gnu.org; Sat, 06 Jan 2018 19:56:56 -0500 Received: by mail-qk0-f194.google.com with SMTP id a8so10330944qkb.8 for <29092@debbugs.gnu.org>; Sat, 06 Jan 2018 16:56:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uF9RqRg5EdDWAt3w3xfD896LgjVHzhu1N8i5mJUmh34=; b=f6s+3ZACoGCvjHeohK8T2ZpQwnAfBe/NQStrHPYurmt5X5AqS+mlFDmXWVbOG+3zK2 g9fVw9CmsAQl/qotNQWirtzjOMD4OBDpjDxB9e/H7gT4SgLmeupxgSEfOT4N/RwRhQvn D7dFyZH4swMQmVKWHoynRC4GbhiTZfhl+BK+VHN+0IORVAIZ8T7kcGQtIvCvxRnU9xEh se/J8UTB44jaBp9b1GFgjLGbb4Myocrl4Yt3nRdgOMPiVQ99Gh1BzC5DtED4ekxSo1wa PT3JrKbqcxPpTudBYNjhMGv1bz1biWB3J2B7vFCSBhrnTlD5j5U9fEqujj8QdUvhffc2 1J3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=uF9RqRg5EdDWAt3w3xfD896LgjVHzhu1N8i5mJUmh34=; b=p0gm44qzxPpxKZWV/OK3zdYh5FIWe0nmciIoiApXyygR+qBlYgrty/wIUAH0b5HMNC L20Pd9KV5du33EJS+ro1vWFZi68NpHAMpBjYabUfd3t8jwwu4x9LCmoWtGcBRHqAPDG2 pq/6DADzfx+CR18gZ8SrZNIIi3JjvYd8utLQ6yu5b7tr5W+lZ0F2nGZmltMf2v3AHx2G LdV5BgayGwp8wjN5b5TLa7bsmKVQ7yyDdIuVL98ZMGtqYKW4ZqKYQRQxam3/6abDTqN+ 1s6dBxeuVYLtJ4WedzPuvK3JpeQsDaFwf0Km4bBFwmoH5ZrGythUviql27J7h+JfkISv 54vA== X-Gm-Message-State: AKwxytdDXATsJvwlw/aosDy+HVHFKfKlC/l/4m1HA4ADOEDVGL1bZqmF 4Oj5nT/tLlu68bPiaFX2UJGhlJSWW9Kib3prJ88= X-Google-Smtp-Source: ACJfBovD56H/kv+64XKJQrSJ5W07pD+Z5eL7H0ysuW1bQ+c29xPiJfGLUkX4l105Y4oLlQ/VFFowS/Farbal4c+tMCo= X-Received: by 10.55.88.2 with SMTP id m2mr10677162qkb.63.1515286610507; Sat, 06 Jan 2018 16:56:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.164.10 with HTTP; Sat, 6 Jan 2018 16:56:29 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Sat, 6 Jan 2018 16:56:29 -0800 X-Google-Sender-Auth: mKS_LI7DFtKNagLpO8MS0j9YDPo Message-ID: Subject: Re: [bug-idutils] bug#29092: bug#29092: bug#29092: Bug related to 64-bit inodes To: Curt McDowell Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29092 Cc: 29092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Fri, Jan 5, 2018 at 8:27 PM, Jim Meyering wrote: > On Mon, Dec 18, 2017 at 8:36 PM, Jim Meyering wrote: >> On Mon, Dec 18, 2017 at 3:31 PM, Curt McDowell wrote: >>> Jim, >>> >>> Thanks for getting to this. I applied the patch and was surprised to see it >>> still has the same bug! There is another comparison function that needs >>> fixing. I verified that 64-bit inodes work properly with this additional >>> change: >>> >>> static int >>> dev_ino_hash_compare (void const *x, void const *y) >>> { >>> int result; >>> result = memcmp(&((struct dev_ino const *) x)->di_ino, >>> &((struct dev_ino const *) y)->di_ino, sizeof (ino_t)); >>> if (result) >>> return result; >>> result = memcmp(&((struct dev_ino const *) x)->di_dev, >>> &((struct dev_ino const *) y)->di_dev, sizeof (ino_t)); >>> return result; >>> } >> >> Thank you for the quick testing and patch. >> >> I've simplified that but left it in your name. However, since it's >> still in your name, yet modified, I'll wait for your ACK before >> pushing (check both author-name+email and wording of the commit log as >> well as the actual patch, since we treat master-pushed commits as >> immutable): > > Ping? Pushed, in spite of no reply. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 06 20:03:10 2018 Received: (at 29092-done) by debbugs.gnu.org; 7 Jan 2018 01:03:10 +0000 Received: from localhost ([127.0.0.1]:38585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXzMk-0007n6-EO for submit@debbugs.gnu.org; Sat, 06 Jan 2018 20:03:10 -0500 Received: from mail-qk0-f174.google.com ([209.85.220.174]:35523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXzMj-0007mu-7p for 29092-done@debbugs.gnu.org; Sat, 06 Jan 2018 20:03:09 -0500 Received: by mail-qk0-f174.google.com with SMTP id w184so2155744qka.2 for <29092-done@debbugs.gnu.org>; Sat, 06 Jan 2018 17:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/U/uJ2pPI6SLO6zVxLbhOkMNdch+EQbhl6Hk+2WbPUg=; b=nzWBcULEs6sWdBHuWDnfVo0fWQf9mKRnGsQpd2DSljJf6LVWhJFwOPmVz0J22sHw0M i9udgsycVsOsZmkDLd44Zx4WvZ1xlLf+STWWW4Mn/ltSIl30mBlQZWvDRc/1YiEHP7id g13Cl7Q82+mCfEg5lErjVu63uTWPEF3r78FKWwGKYIRfzPC72oqn2gYb7RmFeIG52JwZ a6kwpQV8w8/5ukokvDOtQLqe8kPvXLUuGv8pa6Rz/Nl33RrNM13PkJ0xtUdsBiasrBaS ePlvQBZdqvCeVPGa+ut8yDT4zR8pxKcBJkTcZDg/UxXQXnDl2+5dTfzvI+O+v3NlSpe8 oNGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/U/uJ2pPI6SLO6zVxLbhOkMNdch+EQbhl6Hk+2WbPUg=; b=fieETHqo3kUjMMobl5GFuS2HTtFhXWOocErmLajUXTgJN8c2dr/4zGMcRwsBXc+dSj kJHX40Y7dAmdomrglALImO6ZhzQ700UXC4BR3UeG0RVoWmFi1oCveZ21H58uJG2rC90N 0DXR0qFykUb+pptBN/xkGD2nex1aV4YumHGG8e5EhdP5vbm1ewg/rZMqV6LF2h/A2KWD hPUBNvKoi1hsQvv8wt6GLZtbPiA3Ai5j9aL8e0HTOFx6xfS+Tb2wbQGXpwXbDOExcOoh G8zNHzKvU6jeo18vYOcDKwnbHFiMfUCjNFs2kGe8H+AmjqPSDC3US3i7Ls7KB47zdQNM +ReQ== X-Gm-Message-State: AKwxyte2y+1gZTt8V4cVCrisQwrI0NuS4NxGkgUg9PjQhMWeTu4aoxJt XfB/7Nyu6Ro5DFet7aF2cRSngOuniyaJusat0a0= X-Google-Smtp-Source: ACJfBotCuswwuAfOwDClunfiPOEw2R4ufuJAp/GAUB0E06WIppMTYKBI4/8r/hJx4cZEkLc5wMnABJuOJe62H4RQizU= X-Received: by 10.55.163.75 with SMTP id m72mr10375772qke.299.1515286983754; Sat, 06 Jan 2018 17:03:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.55.164.10 with HTTP; Sat, 6 Jan 2018 17:02:43 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Sat, 6 Jan 2018 17:02:43 -0800 X-Google-Sender-Auth: 72Z385qcjSCo3NXHqe-pVZErfC8 Message-ID: Subject: Re: [bug-idutils] bug#29092: bug#29092: bug#29092: bug#29092: Bug related to 64-bit inodes To: Curt McDowell Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29092-done Cc: 29092-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, Jan 6, 2018 at 4:56 PM, Jim Meyering wrote: > On Fri, Jan 5, 2018 at 8:27 PM, Jim Meyering wrote: >> On Mon, Dec 18, 2017 at 8:36 PM, Jim Meyering wrote: >>> On Mon, Dec 18, 2017 at 3:31 PM, Curt McDowell wrote: >>>> Jim, >>>> >>>> Thanks for getting to this. I applied the patch and was surprised to see it >>>> still has the same bug! There is another comparison function that needs >>>> fixing. I verified that 64-bit inodes work properly with this additional >>>> change: >>>> >>>> static int >>>> dev_ino_hash_compare (void const *x, void const *y) >>>> { >>>> int result; >>>> result = memcmp(&((struct dev_ino const *) x)->di_ino, >>>> &((struct dev_ino const *) y)->di_ino, sizeof (ino_t)); >>>> if (result) >>>> return result; >>>> result = memcmp(&((struct dev_ino const *) x)->di_dev, >>>> &((struct dev_ino const *) y)->di_dev, sizeof (ino_t)); >>>> return result; >>>> } >>> >>> Thank you for the quick testing and patch. >>> >>> I've simplified that but left it in your name. However, since it's >>> still in your name, yet modified, I'll wait for your ACK before >>> pushing (check both author-name+email and wording of the commit log as >>> well as the actual patch, since we treat master-pushed commits as >>> immutable): >> >> Ping? > > Pushed, in spite of no reply. Incidentally, I've just updated gnulib and copyright notices, too. Marking this as "done". From unknown Sat Jun 14 05:27:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 04 Feb 2018 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator