GNU bug report logs - #29081
25.1; define-globalized-minor-mode does not respect :variable of original mode

Previous Next

Package: emacs;

Reported by: k <at> rdw.se (Chris Stj)

Date: Tue, 31 Oct 2017 15:41:02 UTC

Severity: normal

Tags: confirmed, easy, fixed

Found in version 25.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: k <at> rdw.se (Chris Stj)
Cc: 29081 <at> debbugs.gnu.org
Subject: bug#29081: 25.1; define-globalized-minor-mode does not respect :variable of original mode
Date: Sat, 02 Dec 2017 14:04:26 -0500

tags 29081 + confirmed easy
quit

k <at> rdw.se (Chris Stj) writes:

> The problem lies in the "if ,mode" condition. This assumes the minor
> mode variable has the same name as the minor mode itself; which is
> clearly not true when something else is specified with the :variable
> keyword in the minor mode definition.

> I guess the best solution may be to allow users of
> define-globalized-minor-mode to specify the place in which the minor
> mode stores its state, since I can't find a good, generic way to extract
> this from the minor mode definition itself, after the fact.

Makes sense to me.
This bug report was last modified 4 years and 166 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.