GNU bug report logs - #29058
[PATCH] tests: install: Estimate the installation system disk size.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29058 in the body.
You can then email your comments to 29058 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] tests: install: Estimate the installation system disk size.
Date: Sun, 29 Oct 2017 19:52:50 +0100

1500 MiB are too small for a current system, thus use let
system-disk-image estimate the required size.

* gnu/tests/install.scm: (run-install): Pass "#:disk-image-size
  'guess" to system-disk-image.
---
 gnu/tests/install.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
index d0cc08f43..a80c520ec 100644
--- a/gnu/tests/install.scm
+++ b/gnu/tests/install.scm
@@ -219,7 +219,7 @@ packages defined in installation-os."
                        (image  (system-disk-image
                                 (operating-system-with-gc-roots
                                  os (list target))
-                                #:disk-image-size (* 1500 MiB)
+                                #:disk-image-size 'guess
                                 #:file-system-type
                                 installation-disk-image-file-system-type)))
     (define install
-- 
2.13.5

Message #8 received at 29058 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 29058 <at> debbugs.gnu.org
Subject: Re: [bug#29058] [PATCH] tests: install: Estimate the installation
 system disk size.
Date: Sun, 29 Oct 2017 22:33:40 +0100

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> 1500 MiB are too small for a current system, thus use let
> system-disk-image estimate the required size.
>
> * gnu/tests/install.scm: (run-install): Pass "#:disk-image-size
>   'guess" to system-disk-image.

Good idea, LGTM!

Thanks,
Ludo'.

Message #13 received at 29058-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29058-close <at> debbugs.gnu.org
Subject: Re: [bug#29058] [PATCH] tests: install: Estimate the installation
 system disk size.
Date: Mon, 30 Oct 2017 09:14:24 +0100

Pushed as 91496dfc9a4c3a708b5c2604fad3e42e101fea04
after fixing a typo in the commit message,

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.