From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 09:41:29 2017 Received: (at submit) by debbugs.gnu.org; 28 Oct 2017 13:41:29 +0000 Received: from localhost ([127.0.0.1]:38165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8RMf-0002LZ-4i for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:41:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8RMb-0002LK-I4 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:41:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8RMU-0007fn-46 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:41:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLACK autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e8RMT-0007f2-Vt for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:41:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8RMR-0001Uz-Mk for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 09:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8RMP-0007Ui-Ln for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 09:41:15 -0400 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:52319) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8RMP-0007Sa-Cp; Sat, 28 Oct 2017 09:41:13 -0400 Received: by mail-oi0-x22c.google.com with SMTP id c202so14844806oih.9; Sat, 28 Oct 2017 06:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=O0QqNQQOsx1EAkOesHYRTjIZa+gCDHyeETzI/dNMTtc=; b=dWlpGP+1vd/mPlbyorQ60zVbeKNfd+RbjUy2lb8EvysMuEoT5eSoqy7cerN+ULMzbr mmjsjnh9mG90RF/OfzvZTn/4HfZqa2Iy/t2Ra6kQT8vP0Hd/O/sxBVcwL0YD0rD1bJKk 6xfyua/EorGE8sLBOZl4OkY+QhssTlCcbEexWe+v8FgEDtTtMxkdwwqmQlL3WQCr++YF /x3NWjxckfFbsok4g53XExwhIAqLRwIiJjfd25/zRG8PfDejIlxZUYN4bj5WQpqCZFxY YExvST6VwNZFPppHS3EiWwrdqS6E+zMwzY/HzAhkS0dryuwFeQKC1Ni11KB3+34fkFWv rNLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O0QqNQQOsx1EAkOesHYRTjIZa+gCDHyeETzI/dNMTtc=; b=n6N7EFlSkFL3sP8W8U03W+MUoZYWtx4dwwv8HOUwXH7vJDBadtILaFkvAF/D1H1ZIu YeastMfRZofrapR4j2upEBaJdzJ+52fYjiaaxJd4ZH5LExR+QX0dPpv+4eQXkbGAEkdM Pol4QPGw78wkbgTT5YCwL3CU6C2x3a5mxFJEoRXK6pFfV3lExLzMn25aN0OGG0qegMsK Iy/H0YqFcvPqEc1DsgYpAsMEY3lsAajErbZJfI5djTcVMRs1SG24nYOnP0wWRNaFhylr erGV2YRWB6BxuiFdEWGnhPr3vLXCVIl+26PtLnP7Lo1fyAPF44MLr9yGEPpiXd6uyt1I 5LwQ== X-Gm-Message-State: AMCzsaWELZI7CO0IJdxNNqEoqXMGr6583GHbm9MRzIXkgHLzQe5tDmVa BQC+00sYpXdWcBFiYh8UsKQnB6Ng97t2x8WqSCU0VQ== X-Google-Smtp-Source: ABhQp+Tv7NRhXyB02PHCbkuxlOqDWielkXeq8IRK2ppAfaKYC5fPL36l55yGTAhqXKbpazaaos2GhNW6cCxEsDetlWU= X-Received: by 10.202.11.3 with SMTP id 3mr1985940oil.71.1509198072334; Sat, 28 Oct 2017 06:41:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Sat, 28 Oct 2017 06:40:41 -0700 (PDT) From: Richard Copley Date: Sat, 28 Oct 2017 14:40:41 +0100 Message-ID: Subject: emacs-26 crash due to misaligned longjmp buffer in 64-bit MSYS2/MinGW-W64 build To: "bug-gnu-emacs@gnu.org" , Eli Zaretskii Content-Type: multipart/mixed; boundary="089e0824839cff71c5055c9b8e75" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --089e0824839cff71c5055c9b8e75 Content-Type: text/plain; charset="UTF-8" When I build from the current emacs-26 branch with the current 64-bit mingw-w64 toolchain from MSYS2, with optimization, Emacs sometimes crashes with a segfault on typing C-g. As far as I can tell, the current 64-bit pretest is not affected. The attached file "servicelistpage.txt" helps to reproduce the crash. It was created by the OP in this thread on help-gnu-emacs: To reproduce the build with the 64-bit MinGW-W64 toolchain from MSYS2, * Save a backup of your MSYS2 installation, if it is in working order. * Update MSYS2. * In MSYS2 MINGW64 shell in the emacs repo: git reset --hard 68182a47 git clean -xfd ./autogen.sh ./configure --with-modules --without-pop 'CFLAGS=-O1 -ggdb3' make -j8 -O Then, to reproduce the crash from "src/emacs -Q servicelistpage.txt": * Wait for the buffer to be displayed. * Type [C-g]. Partial GDB backtrace (full backtrace attached): Thread 1 (Thread 5480.0x1e9c): #0 0x00007ffaa1b693a0 in ntdll!RtlCaptureContext () from C:\WINDOWS\SYSTEM32\ntdll.dll No symbol table info available. #1 0x00007ffaa1ad8f27 in ntdll!RtlUnwindEx () from C:\WINDOWS\SYSTEM32\ntdll.dll No symbol table info available. #2 0x00007ffaa0671f4a in msvcrt!_setjmpex () from C:\WINDOWS\System32\msvcrt.dll No symbol table info available. #3 0x00000004000b1a9a in quit_throw_to_read_char ( from_signal=from_signal@entry=false) at keyboard.c:10548 No locals. The faulting instruction in ntdll!RtlCaptureContext (frame #0) is 0x00007ffaa1b693a0 <+384>: movaps 0x60(%rax),%xmm0 The memory operand should be 16-byte aligned but it is not. That is the cause of the segfault. I think the following extract from the GDB session shows the problem. The value in %rax is 0x4005CDAE8 (not 16-byte aligned). (gdb) p $rax $1 = 17185954536 (gdb) up #1 0x00007ffaa1ad8f27 in ntdll!RtlUnwindEx () from C:\WINDOWS\SYSTEM32\ntdll.dll (gdb) up #2 0x00007ffaa0671f4a in msvcrt!_setjmpex () from C:\WINDOWS\System32\msvcrt.dll (gdb) up #3 0x00000004000b1a9a in quit_throw_to_read_char ( from_signal=from_signal@entry=false) at keyboard.c:10548 10548 sys_longjmp (getcjmp, 1); (gdb) p &getcjmp $2 = (sys_jmp_buf *) 0x4005cdae8 In the help-gnu-emacs thread, Eli said: [...] we should ask the MinGW64 developers for advice about using longjmp. Most probably, something in that area has changed in recent releases of their runtime [...] Eli, my apologies, but I don't think I understand the issues well enough to have a productive discussion with the MinGW-W64 developers myself. --089e0824839cff71c5055c9b8e75 Content-Type: text/plain; charset="UTF-16LE"; name="servicelistpage-1.txt" Content-Disposition: attachment; filename="servicelistpage-1.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j9bcxzbh0 //4iAGgAZQBsAGwAbwAiADoAIgAH6CIADQAKAA== --089e0824839cff71c5055c9b8e75 Content-Type: text/plain; charset="US-ASCII"; name="backtrace.txt" Content-Disposition: attachment; filename="backtrace.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j9bcy6v51 JCBnZGIgLS1xdWlldCAtZXggcnVuIC0tYXJncyBzcmMvZW1hY3MuZXhlIC1RICJDOlxVc2Vyc1xi dXN0ZXJcQXBwRGF0YVxMb2NhbFxUZW1wXHNlcnZpY2VsaXN0cGFnZS0xLnR4dCINClJlYWRpbmcg c3ltYm9scyBmcm9tIHNyYy9lbWFjcy5leGUuLi5kb25lLg0KU3RhcnRpbmcgcHJvZ3JhbTogQzpc cHJvamVjdHNcZW1hY3Ncc3JjXGVtYWNzLmV4ZSAtUSBDOlxVc2Vyc1xidXN0ZXJcQXBwRGF0YVxM b2NhbFxUZW1wXHNlcnZpY2VsaXN0cGFnZS0xLnR4dA0KW05ldyBUaHJlYWQgNTQ4MC4weDFlOWNd DQpbTmV3IFRocmVhZCA1NDgwLjB4M2JjY10NCltOZXcgVGhyZWFkIDU0ODAuMHgxZTA0XQ0KW05l dyBUaHJlYWQgNTQ4MC4weDM4YTRdDQpbTmV3IFRocmVhZCA1NDgwLjB4MjhhMF0NCltOZXcgVGhy ZWFkIDU0ODAuMHgyYTJjXQ0KDQpUaHJlYWQgMSByZWNlaXZlZCBzaWduYWwgU0lHU0VHViwgU2Vn bWVudGF0aW9uIGZhdWx0Lg0KMHgwMDAwN2ZmYWExYjY5M2EwIGluIG50ZGxsIVJ0bENhcHR1cmVD b250ZXh0ICgpDQogICBmcm9tIEM6XFdJTkRPV1NcU1lTVEVNMzJcbnRkbGwuZGxsDQooZ2RiKSB0 aHJlYWQgYXBwbHkgYWxsIGJ0IGZ1bGwNCg0KVGhyZWFkIDYgKFRocmVhZCA1NDgwLjB4MmEyYyk6 DQojMCAgMHgwMDAwN2ZmYTlmMDAxMTQ0IGluIHdpbjMydSFOdFVzZXJHZXRNZXNzYWdlICgpDQog ICBmcm9tIEM6XFdJTkRPV1NcU3lzdGVtMzJcd2luMzJ1LmRsbA0KTm8gc3ltYm9sIHRhYmxlIGlu Zm8gYXZhaWxhYmxlLg0KIzEgIDB4MDAwMDdmZmFhMTg2MmRkNiBpbiBVU0VSMzIhR2V0TWVzc2Fn ZVcgKCkNCiAgIGZyb20gQzpcV0lORE9XU1xTeXN0ZW0zMlx1c2VyMzIuZGxsDQpObyBzeW1ib2wg dGFibGUgaW5mbyBhdmFpbGFibGUuDQojMiAgMHgwMDAwMDAwNDAwMTdiMmQ3IGluIHczMl9tc2df cHVtcCAobXNnX2J1Zj1tc2dfYnVmQGVudHJ5PTB4NGJhZmVjMCkNCiAgICBhdCB3MzJmbnMuYzoz MjU1DQogICAgICAgIG1zZyA9IHsNCiAgICAgICAgICBod25kID0gMHgwLA0KICAgICAgICAgIG1l c3NhZ2UgPSAwLA0KICAgICAgICAgIHdQYXJhbSA9IDAsDQogICAgICAgICAgbFBhcmFtID0gMCwN CiAgICAgICAgICB0aW1lID0gMTIxMzkzMzI1MCwNCiAgICAgICAgICBwdCA9IHsNCiAgICAgICAg ICAgIHggPSAxMTM2LA0KICAgICAgICAgICAgeSA9IDEwNjYNCiAgICAgICAgICB9DQogICAgICAg IH0NCiAgICAgICAgcmVzdWx0ID0gPG9wdGltaXplZCBvdXQ+DQogICAgICAgIGZvY3VzX3dpbmRv dyA9IDxvcHRpbWl6ZWQgb3V0Pg0KIzMgIDB4MDAwMDAwMDQwMDE3YjM4OSBpbiB3MzJfbXNnX3dv cmtlciAoYXJnPTxvcHRpbWl6ZWQgb3V0PikNCiAgICBhdCB3MzJmbnMuYzozNDc4DQogICAgICAg IG1zZyA9IHsNCiAgICAgICAgICBod25kID0gMHgwLA0KICAgICAgICAgIG1lc3NhZ2UgPSAwLA0K ICAgICAgICAgIHdQYXJhbSA9IDAsDQogICAgICAgICAgbFBhcmFtID0gMCwNCiAgICAgICAgICB0 aW1lID0gMCwNCiAgICAgICAgICBwdCA9IHsNCiAgICAgICAgICAgIHggPSAwLA0KICAgICAgICAg ICAgeSA9IDANCiAgICAgICAgICB9DQogICAgICAgIH0NCiAgICAgICAgZHVtbXlfYnVmID0gew0K ICAgICAgICAgIG5leHQgPSAweDAsDQogICAgICAgICAgdzMybXNnID0gew0KICAgICAgICAgICAg bXNnID0gew0KICAgICAgICAgICAgICBod25kID0gMHgwLA0KICAgICAgICAgICAgICBtZXNzYWdl ID0gMCwNCiAgICAgICAgICAgICAgd1BhcmFtID0gMCwNCiAgICAgICAgICAgICAgbFBhcmFtID0g MCwNCiAgICAgICAgICAgICAgdGltZSA9IDAsDQogICAgICAgICAgICAgIHB0ID0gew0KICAgICAg ICAgICAgICAgIHggPSAwLA0KICAgICAgICAgICAgICAgIHkgPSAwDQogICAgICAgICAgICAgIH0N CiAgICAgICAgICAgIH0sDQogICAgICAgICAgICBkd01vZGlmaWVycyA9IDAsDQogICAgICAgICAg ICByZWN0ID0gew0KICAgICAgICAgICAgICBsZWZ0ID0gMCwNCiAgICAgICAgICAgICAgdG9wID0g MCwNCiAgICAgICAgICAgICAgcmlnaHQgPSAwLA0KICAgICAgICAgICAgICBib3R0b20gPSAwDQog ICAgICAgICAgICB9DQogICAgICAgICAgfSwNCiAgICAgICAgICByZXN1bHQgPSAwLA0KICAgICAg ICAgIGNvbXBsZXRlZCA9IDANCiAgICAgICAgfQ0KIzQgIDB4MDAwMDdmZmFhMGRhMjc3NCBpbiBL RVJORUwzMiFCYXNlVGhyZWFkSW5pdFRodW5rICgpDQogICBmcm9tIEM6XFdJTkRPV1NcU3lzdGVt MzJca2VybmVsMzIuZGxsDQpObyBzeW1ib2wgdGFibGUgaW5mbyBhdmFpbGFibGUuDQojNSAgMHgw MDAwN2ZmYWExYjMwZDUxIGluIG50ZGxsIVJ0bFVzZXJUaHJlYWRTdGFydCAoKQ0KICAgZnJvbSBD OlxXSU5ET1dTXFNZU1RFTTMyXG50ZGxsLmRsbA0KTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxh YmxlLg0KIzYgIDB4MDAwMDAwMDAwMDAwMDAwMCBpbiA/PyAoKQ0KTm8gc3ltYm9sIHRhYmxlIGlu Zm8gYXZhaWxhYmxlLg0KQmFja3RyYWNlIHN0b3BwZWQ6IHByZXZpb3VzIGZyYW1lIGlubmVyIHRv IHRoaXMgZnJhbWUgKGNvcnJ1cHQgc3RhY2s/KQ0KDQpUaHJlYWQgNSAoVGhyZWFkIDU0ODAuMHgy OGEwKToNCiMwICAweDAwMDA3ZmZhYTFiNjVhMjQgaW4gbnRkbGwhWndEZWxheUV4ZWN1dGlvbiAo KQ0KICAgZnJvbSBDOlxXSU5ET1dTXFNZU1RFTTMyXG50ZGxsLmRsbA0KTm8gc3ltYm9sIHRhYmxl IGluZm8gYXZhaWxhYmxlLg0KIzEgIDB4MDAwMDdmZmE5ZTAzNzI4NyBpbiBTbGVlcEV4ICgpIGZy b20gQzpcV0lORE9XU1xTeXN0ZW0zMlxLZXJuZWxCYXNlLmRsbA0KTm8gc3ltYm9sIHRhYmxlIGlu Zm8gYXZhaWxhYmxlLg0KIzIgIDB4MDAwMDAwMDQwMDFhODljMiBpbiB0aW1lcl9sb29wIChhcmc9 MHg0MDFhZGZkNjAgPHJlYWxfaXRpbWVyPikNCiAgICBhdCB3MzJwcm9jLmM6Mzk3DQogICAgICAg IHNsZWVwX3RpbWUgPSA8b3B0aW1pemVkIG91dD4NCiAgICAgICAgaGFuZGxlciA9IDxvcHRpbWl6 ZWQgb3V0Pg0KICAgICAgICBub3cgPSA8b3B0aW1pemVkIG91dD4NCiAgICAgICAgZXhwaXJlID0g PG9wdGltaXplZCBvdXQ+DQogICAgICAgIHJlbG9hZCA9IDxvcHRpbWl6ZWQgb3V0Pg0KICAgICAg ICBpdGltZXIgPSAweDQwMWFkZmQ2MCA8cmVhbF9pdGltZXI+DQogICAgICAgIHdoaWNoID0gPG9w dGltaXplZCBvdXQ+DQogICAgICAgIGNyaXQgPSAweDQwMWFkZmNhMCA8Y3JpdF9wcm9mPg0KICAg ICAgICBodGggPSAweDANCiMzICAweDAwMDA3ZmZhYTBkYTI3NzQgaW4gS0VSTkVMMzIhQmFzZVRo cmVhZEluaXRUaHVuayAoKQ0KICAgZnJvbSBDOlxXSU5ET1dTXFN5c3RlbTMyXGtlcm5lbDMyLmRs bA0KTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxhYmxlLg0KIzQgIDB4MDAwMDdmZmFhMWIzMGQ1 MSBpbiBudGRsbCFSdGxVc2VyVGhyZWFkU3RhcnQgKCkNCiAgIGZyb20gQzpcV0lORE9XU1xTWVNU RU0zMlxudGRsbC5kbGwNCk5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4NCiM1ICAweDAw MDAwMDAwMDAwMDAwMDAgaW4gPz8gKCkNCk5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4N CkJhY2t0cmFjZSBzdG9wcGVkOiBwcmV2aW91cyBmcmFtZSBpbm5lciB0byB0aGlzIGZyYW1lIChj b3JydXB0IHN0YWNrPykNCg0KVGhyZWFkIDQgKFRocmVhZCA1NDgwLjB4MzhhNCk6DQojMCAgMHgw MDAwN2ZmYWExYjY4YzM0IGluIG50ZGxsIVp3V2FpdEZvcldvcmtWaWFXb3JrZXJGYWN0b3J5ICgp DQogICBmcm9tIEM6XFdJTkRPV1NcU1lTVEVNMzJcbnRkbGwuZGxsDQpObyBzeW1ib2wgdGFibGUg aW5mbyBhdmFpbGFibGUuDQojMSAgMHgwMDAwN2ZmYWExYjAxNTUzIGluIG50ZGxsIVRwUmVsZWFz ZVdvcmsgKCkNCiAgIGZyb20gQzpcV0lORE9XU1xTWVNURU0zMlxudGRsbC5kbGwNCk5vIHN5bWJv bCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4NCiMyICAweDAwMDA3ZmZhYTBkYTI3NzQgaW4gS0VSTkVM MzIhQmFzZVRocmVhZEluaXRUaHVuayAoKQ0KICAgZnJvbSBDOlxXSU5ET1dTXFN5c3RlbTMyXGtl cm5lbDMyLmRsbA0KTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxhYmxlLg0KIzMgIDB4MDAwMDdm ZmFhMWIzMGQ1MSBpbiBudGRsbCFSdGxVc2VyVGhyZWFkU3RhcnQgKCkNCiAgIGZyb20gQzpcV0lO RE9XU1xTWVNURU0zMlxudGRsbC5kbGwNCk5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4N CiM0ICAweDAwMDAwMDAwMDAwMDAwMDAgaW4gPz8gKCkNCk5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2 YWlsYWJsZS4NCkJhY2t0cmFjZSBzdG9wcGVkOiBwcmV2aW91cyBmcmFtZSBpbm5lciB0byB0aGlz IGZyYW1lIChjb3JydXB0IHN0YWNrPykNCg0KVGhyZWFkIDMgKFRocmVhZCA1NDgwLjB4MWUwNCk6 DQojMCAgMHgwMDAwN2ZmYWExYjY4YzM0IGluIG50ZGxsIVp3V2FpdEZvcldvcmtWaWFXb3JrZXJG YWN0b3J5ICgpDQogICBmcm9tIEM6XFdJTkRPV1NcU1lTVEVNMzJcbnRkbGwuZGxsDQpObyBzeW1i b2wgdGFibGUgaW5mbyBhdmFpbGFibGUuDQojMSAgMHgwMDAwN2ZmYWExYjAxNTUzIGluIG50ZGxs IVRwUmVsZWFzZVdvcmsgKCkNCiAgIGZyb20gQzpcV0lORE9XU1xTWVNURU0zMlxudGRsbC5kbGwN Ck5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4NCiMyICAweDAwMDA3ZmZhYTBkYTI3NzQg aW4gS0VSTkVMMzIhQmFzZVRocmVhZEluaXRUaHVuayAoKQ0KICAgZnJvbSBDOlxXSU5ET1dTXFN5 c3RlbTMyXGtlcm5lbDMyLmRsbA0KTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxhYmxlLg0KIzMg IDB4MDAwMDdmZmFhMWIzMGQ1MSBpbiBudGRsbCFSdGxVc2VyVGhyZWFkU3RhcnQgKCkNCiAgIGZy b20gQzpcV0lORE9XU1xTWVNURU0zMlxudGRsbC5kbGwNCk5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2 YWlsYWJsZS4NCiM0ICAweDAwMDAwMDAwMDAwMDAwMDAgaW4gPz8gKCkNCk5vIHN5bWJvbCB0YWJs ZSBpbmZvIGF2YWlsYWJsZS4NCkJhY2t0cmFjZSBzdG9wcGVkOiBwcmV2aW91cyBmcmFtZSBpbm5l ciB0byB0aGlzIGZyYW1lIChjb3JydXB0IHN0YWNrPykNCg0KVGhyZWFkIDIgKFRocmVhZCA1NDgw LjB4M2JjYyk6DQojMCAgMHgwMDAwN2ZmYWExYjY4YzM0IGluIG50ZGxsIVp3V2FpdEZvcldvcmtW aWFXb3JrZXJGYWN0b3J5ICgpDQogICBmcm9tIEM6XFdJTkRPV1NcU1lTVEVNMzJcbnRkbGwuZGxs DQpObyBzeW1ib2wgdGFibGUgaW5mbyBhdmFpbGFibGUuDQojMSAgMHgwMDAwN2ZmYWExYjAxNTUz IGluIG50ZGxsIVRwUmVsZWFzZVdvcmsgKCkNCiAgIGZyb20gQzpcV0lORE9XU1xTWVNURU0zMlxu dGRsbC5kbGwNCk5vIHN5bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4NCiMyICAweDAwMDA3ZmZh YTBkYTI3NzQgaW4gS0VSTkVMMzIhQmFzZVRocmVhZEluaXRUaHVuayAoKQ0KICAgZnJvbSBDOlxX SU5ET1dTXFN5c3RlbTMyXGtlcm5lbDMyLmRsbA0KTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxh YmxlLg0KIzMgIDB4MDAwMDdmZmFhMWIzMGQ1MSBpbiBudGRsbCFSdGxVc2VyVGhyZWFkU3RhcnQg KCkNCiAgIGZyb20gQzpcV0lORE9XU1xTWVNURU0zMlxudGRsbC5kbGwNCk5vIHN5bWJvbCB0YWJs ZSBpbmZvIGF2YWlsYWJsZS4NCiM0ICAweDAwMDAwMDAwMDAwMDAwMDAgaW4gPz8gKCkNCk5vIHN5 bWJvbCB0YWJsZSBpbmZvIGF2YWlsYWJsZS4NCkJhY2t0cmFjZSBzdG9wcGVkOiBwcmV2aW91cyBm cmFtZSBpbm5lciB0byB0aGlzIGZyYW1lIChjb3JydXB0IHN0YWNrPykNCg0KVGhyZWFkIDEgKFRo cmVhZCA1NDgwLjB4MWU5Yyk6DQojMCAgMHgwMDAwN2ZmYWExYjY5M2EwIGluIG50ZGxsIVJ0bENh cHR1cmVDb250ZXh0ICgpDQogICBmcm9tIEM6XFdJTkRPV1NcU1lTVEVNMzJcbnRkbGwuZGxsDQpO byBzeW1ib2wgdGFibGUgaW5mbyBhdmFpbGFibGUuDQojMSAgMHgwMDAwN2ZmYWExYWQ4ZjI3IGlu IG50ZGxsIVJ0bFVud2luZEV4ICgpDQogICBmcm9tIEM6XFdJTkRPV1NcU1lTVEVNMzJcbnRkbGwu ZGxsDQpObyBzeW1ib2wgdGFibGUgaW5mbyBhdmFpbGFibGUuDQojMiAgMHgwMDAwN2ZmYWEwNjcx ZjRhIGluIG1zdmNydCFfc2V0am1wZXggKCkNCiAgIGZyb20gQzpcV0lORE9XU1xTeXN0ZW0zMlxt c3ZjcnQuZGxsDQpObyBzeW1ib2wgdGFibGUgaW5mbyBhdmFpbGFibGUuDQojMyAgMHgwMDAwMDAw NDAwMGIxYTlhIGluIHF1aXRfdGhyb3dfdG9fcmVhZF9jaGFyICgNCiAgICBmcm9tX3NpZ25hbD1m cm9tX3NpZ25hbEBlbnRyeT1mYWxzZSkgYXQga2V5Ym9hcmQuYzoxMDU0OA0KTm8gbG9jYWxzLg0K IzQgIDB4MDAwMDAwMDQwMDBiM2RiNSBpbiBrYmRfYnVmZmVyX2dldF9ldmVudCAoZW5kX3RpbWU9 MHgwLA0KICAgIHVzZWRfbW91c2VfbWVudT0weDAsIGticD08c3ludGhldGljIHBvaW50ZXI+KSBh dCBrZXlib2FyZC5jOjM3OTANCiAgICAgICAgb2JqID0gPG9wdGltaXplZCBvdXQ+DQojNSAgcmVh ZF9ldmVudF9mcm9tX21haW5fcXVldWUgKHVzZWRfbW91c2VfbWVudT0weDAsIGxvY2FsX2dldGNq bXA9MHhiZmYyNTgsDQogICAgZW5kX3RpbWU9MHgwKSBhdCBrZXlib2FyZC5jOjIxNTENCiAgICAg ICAgYyA9IHsNCiAgICAgICAgICBpID0gMA0KICAgICAgICB9DQogICAgICAgIHNhdmVfanVtcCA9 IHt7DQogICAgICAgICAgICBQYXJ0ID0gezAsIDB9DQogICAgICAgICAgfSA8cmVwZWF0cyAxNiB0 aW1lcz59DQogICAgICAgIGtiID0gPG9wdGltaXplZCBvdXQ+DQojNiAgcmVhZF9kZWNvZGVkX2V2 ZW50X2Zyb21fbWFpbl9xdWV1ZSAodXNlZF9tb3VzZV9tZW51PTB4MCwgcHJldl9ldmVudD0uLi4s DQogICAgbG9jYWxfZ2V0Y2ptcD0weGJmZjI1OCwgZW5kX3RpbWU9MHgwKSBhdCBrZXlib2FyZC5j OjIyMTQNCk5vIGxvY2Fscy4NCiM3ICByZWFkX2NoYXIgKGNvbW1hbmRmbGFnPTEyMCwgY29tbWFu ZGZsYWdAZW50cnk9MSwgbWFwPS4uLiwgbWFwQGVudHJ5PS4uLiwNCiAgICBwcmV2X2V2ZW50PS4u LiwgdXNlZF9tb3VzZV9tZW51PTB4MCwgdXNlZF9tb3VzZV9tZW51QGVudHJ5PTB4YmZmNDRiLA0K ICAgIGVuZF90aW1lPWVuZF90aW1lQGVudHJ5PTB4MCkgYXQga2V5Ym9hcmQuYzoyODAyDQogICAg ICAgIGMgPSA8b3B0aW1pemVkIG91dD4NCiAgICAgICAgam1wY291bnQgPSAwDQogICAgICAgIGxv Y2FsX2dldGNqbXAgPSB7ew0KICAgICAgICAgICAgUGFydCA9IHsxMjU3OTYyNCwgMTcxODU0NTI5 Njl9DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHsxMjU3ODMwNCwgMTI1Nzk2 MjR9DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHsxNzE4NTQ2MTE4NCwgMTcx ODU4NjE2MDB9DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHs1MzQ1MjgsIDN9 DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHswLCAwfQ0KICAgICAgICAgIH0s IHsNCiAgICAgICAgICAgIFBhcnQgPSB7MTcxODA2MDE5OTYsIDM4NDM5OTU3MzgwMTZ9DQogICAg ICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHswLCAwfQ0KICAgICAgICAgIH0sIHsNCiAg ICAgICAgICAgIFBhcnQgPSB7MCwgMH0NCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0 ID0gezAsIDB9DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHswLCAwfQ0KICAg ICAgICAgIH0sIHsNCiAgICAgICAgICAgIFBhcnQgPSB7MCwgMH0NCiAgICAgICAgICB9LCB7DQog ICAgICAgICAgICBQYXJ0ID0gezAsIDB9DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFy dCA9IHswLCAwfQ0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIFBhcnQgPSB7MCwgMH0NCiAg ICAgICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0ID0gezAsIDB9DQogICAgICAgICAgfSwgew0K ICAgICAgICAgICAgUGFydCA9IHswLCAwfQ0KICAgICAgICAgIH19DQogICAgICAgIHNhdmVfanVt cCA9IHt7DQogICAgICAgICAgICBQYXJ0ID0gezE3MTg1OTA3NTIwLCAxNzE4NTg2OTMyOH0NCiAg ICAgICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0ID0gezYxNzY4LCA4MDM4OTE2OH0NCiAgICAg ICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0ID0gezIsIDE3MTg1MTMxMDE2fQ0KICAgICAgICAg IH0sIHsNCiAgICAgICAgICAgIFBhcnQgPSB7MTI1NzkyOTYsIDB9DQogICAgICAgICAgfSwgew0K ICAgICAgICAgICAgUGFydCA9IHswLCAxNzE4MTAwNTgwNX0NCiAgICAgICAgICB9LCB7DQogICAg ICAgICAgICBQYXJ0ID0gezAsIDE3MTg1OTA3NTIwfQ0KICAgICAgICAgIH0sIHsNCiAgICAgICAg ICAgIFBhcnQgPSB7MzU4NDAsIDE3MTg4MjQwNTQ0fQ0KICAgICAgICAgIH0sIHsNCiAgICAgICAg ICAgIFBhcnQgPSB7NjE3NjgsIDEyMH0NCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0 ID0gezE3MTg1MTMxMDE2LCAxMjU3OTI5Nn0NCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBQ YXJ0ID0gezAsIDE3MTgxMDA5MDM3fQ0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIFBhcnQg PSB7MCwgODAzODkxNjh9DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHsxLCAx NX0NCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0ID0gezUsIDE3MTg4ODgwMjg4fQ0K ICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIFBhcnQgPSB7MzAwMjM2OCwgMTcxODA5Mzk2NDZ9 DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgUGFydCA9IHswLCA4MDM4OTE2OH0NCiAgICAg ICAgICB9LCB7DQogICAgICAgICAgICBQYXJ0ID0gezAsIDE1fQ0KICAgICAgICAgIH19DQogICAg ICAgIHRlbSA9IDxvcHRpbWl6ZWQgb3V0Pg0KICAgICAgICBzYXZlID0gPG9wdGltaXplZCBvdXQ+ DQogICAgICAgIHByZXZpb3VzX2VjaG9fYXJlYV9tZXNzYWdlID0gew0KICAgICAgICAgIGkgPSAw DQogICAgICAgIH0NCiAgICAgICAgYWxzb19yZWNvcmQgPSB7DQogICAgICAgICAgaSA9IDANCiAg ICAgICAgfQ0KICAgICAgICByZXJlYWQgPSBmYWxzZQ0KICAgICAgICByZWNvcmRlZCA9IGZhbHNl DQogICAgICAgIHBvbGxpbmdfc3RvcHBlZF9oZXJlID0gdHJ1ZQ0KICAgICAgICBvcmlnX2tib2Fy ZCA9IDB4MQ0KIzggIDB4MDAwMDAwMDQwMDBiNjFhMyBpbiByZWFkX2tleV9zZXF1ZW5jZSAoa2V5 YnVmPWtleWJ1ZkBlbnRyeT0weGJmZjU4MCwNCiAgICBidWZzaXplPWJ1ZnNpemVAZW50cnk9MzAs IHByb21wdD0uLi4sIHByb21wdEBlbnRyeT0uLi4sDQogICAgZG9udF9kb3duY2FzZV9sYXN0PWRv bnRfZG93bmNhc2VfbGFzdEBlbnRyeT1mYWxzZSwNCiAgICBjYW5fcmV0dXJuX3N3aXRjaF9mcmFt ZT1jYW5fcmV0dXJuX3N3aXRjaF9mcmFtZUBlbnRyeT10cnVlLA0KICAgIGZpeF9jdXJyZW50X2J1 ZmZlcj1maXhfY3VycmVudF9idWZmZXJAZW50cnk9dHJ1ZSwNCiAgICBwcmV2ZW50X3JlZGlzcGxh eT1wcmV2ZW50X3JlZGlzcGxheUBlbnRyeT1mYWxzZSkgYXQga2V5Ym9hcmQuYzo5MTQ3DQogICAg ICAgIGludGVycnVwdGVkX2tib2FyZCA9IDB4NDFjNGM1MA0KICAgICAgICBpbnRlcnJ1cHRlZF9m cmFtZSA9IDB4NDAwYTNmYTIwIDxkdW1wZWRfZGF0YSs0NTk0MDgwPg0KICAgICAgICBrZXkgPSA8 b3B0aW1pemVkIG91dD4NCiAgICAgICAgdXNlZF9tb3VzZV9tZW51ID0gZmFsc2UNCiAgICAgICAg ZWNob19sb2NhbF9zdGFydCA9IDANCiAgICAgICAgbGFzdF9yZWFsX2tleV9zdGFydCA9IDANCiAg ICAgICAga2V5c19sb2NhbF9zdGFydCA9IDxvcHRpbWl6ZWQgb3V0Pg0KICAgICAgICBuZXdfYmlu ZGluZyA9IDxvcHRpbWl6ZWQgb3V0Pg0KICAgICAgICB0ID0gMA0KICAgICAgICBlY2hvX3N0YXJ0 ID0gMA0KICAgICAgICBrZXlzX3N0YXJ0ID0gMA0KICAgICAgICBjdXJyZW50X2JpbmRpbmcgPSB7 DQogICAgICAgICAgaSA9IDE3MTg4MDcyMDUxDQogICAgICAgIH0NCiAgICAgICAgZmlyc3RfZXZl bnQgPSB7DQogICAgICAgICAgaSA9IDANCiAgICAgICAgfQ0KICAgICAgICBmaXJzdF91bmJvdW5k ID0gMzENCiAgICAgICAgbW9ja19pbnB1dCA9IDANCiAgICAgICAgZmtleSA9IHsNCiAgICAgICAg ICBwYXJlbnQgPSB7DQogICAgICAgICAgICBpID0gMTcxODc0NDMxNzENCiAgICAgICAgICB9LA0K ICAgICAgICAgIG1hcCA9IHsNCiAgICAgICAgICAgIGkgPSAxNzE4NzQ0MzE3MQ0KICAgICAgICAg IH0sDQogICAgICAgICAgc3RhcnQgPSAwLA0KICAgICAgICAgIGVuZCA9IDANCiAgICAgICAgfQ0K ICAgICAgICBrZXl0cmFuID0gew0KICAgICAgICAgIHBhcmVudCA9IHsNCiAgICAgICAgICAgIGkg PSAxNzE4NjE2OTQ5MQ0KICAgICAgICAgIH0sDQogICAgICAgICAgbWFwID0gew0KICAgICAgICAg ICAgaSA9IDE3MTg2MTY5NDkxDQogICAgICAgICAgfSwNCiAgICAgICAgICBzdGFydCA9IDAsDQog ICAgICAgICAgZW5kID0gMA0KICAgICAgICB9DQogICAgICAgIGluZGVjID0gew0KICAgICAgICAg IHBhcmVudCA9IHsNCiAgICAgICAgICAgIGkgPSAxNzE4NzQ0MzE4Nw0KICAgICAgICAgIH0sDQog ICAgICAgICAgbWFwID0gew0KICAgICAgICAgICAgaSA9IDE3MTg3NDQzMTg3DQogICAgICAgICAg fSwNCiAgICAgICAgICBzdGFydCA9IDAsDQogICAgICAgICAgZW5kID0gMA0KICAgICAgICB9DQog ICAgICAgIHNoaWZ0X3RyYW5zbGF0ZWQgPSBmYWxzZQ0KICAgICAgICBkZWxheWVkX3N3aXRjaF9m cmFtZSA9IHsNCiAgICAgICAgICBpID0gMA0KICAgICAgICB9DQogICAgICAgIG9yaWdpbmFsX3Vw cGVyY2FzZSA9IHsNCiAgICAgICAgICBpID0gMA0KICAgICAgICB9DQogICAgICAgIG9yaWdpbmFs X3VwcGVyY2FzZV9wb3NpdGlvbiA9IC0xDQogICAgICAgIGR1bW15ZmxhZyA9IGZhbHNlDQogICAg ICAgIHN0YXJ0aW5nX2J1ZmZlciA9IDB4NGNhYTQzMA0KICAgICAgICBmYWtlX3ByZWZpeGVkX2tl eXMgPSB7DQogICAgICAgICAgaSA9IDANCiAgICAgICAgfQ0KIzkgIDB4MDAwMDAwMDQwMDBiNmVl MyBpbiBjb21tYW5kX2xvb3BfMSAoKSBhdCBrZXlib2FyZC5jOjEzNjgNCiAgICAgICAgY21kID0g PG9wdGltaXplZCBvdXQ+DQogICAgICAgIGtleWJ1ZiA9IHt7DQogICAgICAgICAgICBpID0gMA0K ICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAxNzE4MTAwNTgwNQ0KICAgICAgICAgIH0s IHsNCiAgICAgICAgICAgIGkgPSAyMTM5MjUwNjI1NzQwODA3OA0KICAgICAgICAgIH0sIHsNCiAg ICAgICAgICAgIGkgPSAxNzE4NTkwODg2NA0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkg PSAzNzE4NA0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAxNzE4ODI0MDU0NA0KICAg ICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAwDQogICAgICAgICAgfSwgew0KICAgICAgICAg ICAgaSA9IDEyMA0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAxNzE4NTEzMTAxNg0K ICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAxMjU4MDM1Mg0KICAgICAgICAgIH0sIHsN CiAgICAgICAgICAgIGkgPSAxNzE4NjQ3OTM5NQ0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAg IGkgPSAxNzE4MTAwOTAzNw0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAxNDYwNzI4 DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgaSA9IDANCiAgICAgICAgICB9LCB7DQogICAg ICAgICAgICBpID0gMTcxODU4NjE2MDANCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBpID0g MQ0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSA1DQogICAgICAgICAgfSwgew0KICAg ICAgICAgICAgaSA9IDM3MTg0DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgaSA9IDANCiAg ICAgICAgICB9LCB7DQogICAgICAgICAgICBpID0gMTcxODYxOTA4MjENCiAgICAgICAgICB9LCB7 DQogICAgICAgICAgICBpID0gMA0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAxNzE4 NTg2MTYwMA0KICAgICAgICAgIH0sIHsNCiAgICAgICAgICAgIGkgPSAzDQogICAgICAgICAgfSwg ew0KICAgICAgICAgICAgaSA9IDE3MTg3NzY1MjAzDQogICAgICAgICAgfSwgew0KICAgICAgICAg ICAgaSA9IDE3MTg1ODYxNjAwDQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgaSA9IDEyNTgw NjA4DQogICAgICAgICAgfSwgew0KICAgICAgICAgICAgaSA9IDANCiAgICAgICAgICB9LCB7DQog ICAgICAgICAgICBpID0gMTcxODEwMjQ5OTcNCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBp ID0gMTcxODU4NjE2MDANCiAgICAgICAgICB9LCB7DQogICAgICAgICAgICBpID0gNjQzMTIzNjgN CiAgICAgICAgICB9fQ0KICAgICAgICBpID0gPG9wdGltaXplZCBvdXQ+DQogICAgICAgIHByZXZf bW9kaWZmID0gMA0KICAgICAgICBwcmV2X2J1ZmZlciA9IDB4MA0KIzEwIDB4MDAwMDAwMDQwMDEx NWQ3YSBpbiBpbnRlcm5hbF9jb25kaXRpb25fY2FzZSAoDQogICAgYmZ1bj1iZnVuQGVudHJ5PTB4 NDAwMGI2YWVjIDxjb21tYW5kX2xvb3BfMT4sIGhhbmRsZXJzPS4uLiwNCiAgICBoYW5kbGVyc0Bl bnRyeT0uLi4sIGhmdW49aGZ1bkBlbnRyeT0weDQwMDBhZDFiYiA8Y21kX2Vycm9yPikNCiAgICBh dCBldmFsLmM6MTMzMg0KICAgICAgICB2YWwgPSB7DQogICAgICAgICAgaSA9IDE3MTg1OTU0NTM2 DQogICAgICAgIH0NCiAgICAgICAgYyA9IDB4M2Q1NTQzMA0KIzExIDB4MDAwMDAwMDQwMDBhOWE4 NyBpbiBjb21tYW5kX2xvb3BfMiAoaWdub3JlPS4uLikgYXQga2V5Ym9hcmQuYzoxMTEwDQogICAg ICAgIHZhbCA9IDxvcHRpbWl6ZWQgb3V0Pg0KIzEyIDB4MDAwMDAwMDQwMDExNWNlYiBpbiBpbnRl cm5hbF9jYXRjaCAodGFnPS4uLiwgdGFnQGVudHJ5PS4uLiwNCiAgICBmdW5jPWZ1bmNAZW50cnk9 MHg0MDAwYTlhNjMgPGNvbW1hbmRfbG9vcF8yPiwgYXJnPWFyZ0BlbnRyeT0uLi4pDQogICAgYXQg ZXZhbC5jOjEwOTcNCiAgICAgICAgdmFsID0gew0KICAgICAgICAgIGkgPSAxNzE4NTk1NDUzNg0K ICAgICAgICB9DQogICAgICAgIGMgPSAweDNkNTUyYTANCiMxMyAweDAwMDAwMDA0MDAwYTk5YjQg aW4gY29tbWFuZF9sb29wICgpIGF0IGtleWJvYXJkLmM6MTA4OQ0KTm8gbG9jYWxzLg0KIzE0IDB4 MDAwMDAwMDAwMDAwMDAwMCBpbiA/PyAoKQ0KTm8gc3ltYm9sIHRhYmxlIGluZm8gYXZhaWxhYmxl Lg0KQmFja3RyYWNlIHN0b3BwZWQ6IHByZXZpb3VzIGZyYW1lIGlubmVyIHRvIHRoaXMgZnJhbWUg KGNvcnJ1cHQgc3RhY2s/KQ0KKGdkYikNCg== --089e0824839cff71c5055c9b8e75-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 09:56:04 2017 Received: (at submit) by debbugs.gnu.org; 28 Oct 2017 13:56:04 +0000 Received: from localhost ([127.0.0.1]:39328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Ral-0004sq-SG for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:56:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Rai-0004sT-GI for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:56:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8Rac-00052B-7I for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:55:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40072) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e8Rac-000525-4h for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:55:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8Raa-0007aG-Sz for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 09:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8RaX-0004zh-Rr for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 09:55:52 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8RaX-0004zd-Ns; Sat, 28 Oct 2017 09:55:49 -0400 Received: from [176.228.60.248] (port=4819 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e8RaX-0003te-5o; Sat, 28 Oct 2017 09:55:49 -0400 Date: Sat, 28 Oct 2017 16:55:45 +0300 Message-Id: <83efpn5qce.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Sat, 28 Oct 2017 14:40:41 +0100) Subject: Re: emacs-26 crash due to misaligned longjmp buffer in 64-bit MSYS2/MinGW-W64 build References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Richard Copley > Date: Sat, 28 Oct 2017 14:40:41 +0100 > > In the help-gnu-emacs thread, Eli said: > > [...] we should ask the MinGW64 developers for advice about using > longjmp. Most probably, something in that area has changed in recent > releases of their runtime [...] > > Eli, my apologies, but I don't think I understand the issues well > enough to have a productive discussion with the MinGW-W64 developers > myself. Just ask them to read this bug report and ask questions if they don't understand the issue well enough. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 09:56:54 2017 Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 13:56:54 +0000 Received: from localhost ([127.0.0.1]:39331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Rba-0004tv-4w for submit@debbugs.gnu.org; Sat, 28 Oct 2017 09:56:54 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:55438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8RbY-0004tj-6D for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 09:56:52 -0400 Received: by mail-oi0-f48.google.com with SMTP id g125so14901632oib.12 for <29040@debbugs.gnu.org>; Sat, 28 Oct 2017 06:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kGLkHRP06/LG8Audg0W0VoxQiC/o/A+YaUWsJZ2JTT8=; b=lA8RRwLOmAQjA+ue6k1RCUY71WEMm5npvbcKbMhr5X2i8pT8xobnpD9xJPuX6gZeUe nG+7seuU5xg+dIq7Wvo7VY3JO19+h56a7RJnE5mssJoxbTWiS8ZC100g5H3Ua4I6AWaS 04mE6dVdk6VX/livcnE2csYwAaUH4X83FQy2au0YLxt9AnPnejN6pY/8CyJYaTmo8RK4 rRsjUHbooJGDGmH3uUt6sgJR+KVw3ldUXaYeBtsRHX7AtXRjx4zwUdQtwnmtTOJKxNxF jgfS/2uJHeaQ2kiRVxfRJNlEvv3pX+Hn3dIdNvGIWiuPoBpIhpAlFvxKQ6Zo2JZiJP2K C5jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kGLkHRP06/LG8Audg0W0VoxQiC/o/A+YaUWsJZ2JTT8=; b=a61IdWptLrkZuEK+F2EL1d9UmB7uWlHdqzK1K9ljkRxxE4lZ+k8vHn0NVvL3wcWVh2 GpoJukdCtcDSeN9tjToibql6rh80Ju69WKvrAXq6peLEBN99oA9Bh+KwEZZCkKjlGufr taVYePxzPxBNyhfJVAeKmRx7e3G9U3T0OdrohSLaXXJANqK2Ttn+UGpys8sysNbw3QHk poCwju3roy1ILmhADfv1S4AeYJ5YiyASzLetKQ5HWoCWhLMIA02GbF9zKBaPeXkAxI7r aK20tYiHdbLyz1/3V8iOl9x9hRxAwpnCtGhOoX7SzxjRyQnPXum1o+TYh4aD8at9H2rr 13rQ== X-Gm-Message-State: AMCzsaWDR1PMTCAjr3WNYoULw424Ey8rAdkuzGCaxJPPtvVmlNGswTBW Lvb2nGv7kqchrwYEB060pFGdFJweWiuDts+VVQ6Zp/2w X-Google-Smtp-Source: ABhQp+To7Ll18AYO9u2tP/OuqwOfqYDa3+juTDv8FplRROHLFAFwKDdBjWE1p9dhisc4wOfutMDeHUc9Nb75+0IcsSg= X-Received: by 10.202.108.79 with SMTP id h76mr2034465oic.1.1509199006348; Sat, 28 Oct 2017 06:56:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Sat, 28 Oct 2017 06:56:15 -0700 (PDT) In-Reply-To: <83fua35tem.fsf@gnu.org> References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> From: Richard Copley Date: Sat, 28 Oct 2017 14:56:15 +0100 Message-ID: Subject: Re: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: "help-gnu-emacs@gnu.org" , 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Eli Zaretskii wrote: > (And this discussion should have moved to bug-gnu-emacs ages ago.) #29040 (CC'd). >> (gdb) p $rax >> $1 = 17185954536 > > p/x $rax is usually more useful. Much better, thank you. > So my guess was correct, and we should ask the MinGW64 developers for > advice about using longjmp. Most probably, something in that area has > changed in recent releases of their runtime, because otherwise I > cannot explain to myself why these issues pop up only now. I thought Paul was of a differing opinion (see ) but perhaps I'm mixing up different issues. Do I take it we don't get to allocate the jmp_buf ourselves? > Thanks. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 10:11:11 2017 Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 14:11:11 +0000 Received: from localhost ([127.0.0.1]:39337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8RpP-0005Gd-Cx for submit@debbugs.gnu.org; Sat, 28 Oct 2017 10:11:11 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:52562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8RpN-0005GQ-Ip for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 10:11:09 -0400 Received: by mail-oi0-f52.google.com with SMTP id c202so14953104oih.9 for <29040@debbugs.gnu.org>; Sat, 28 Oct 2017 07:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=MNaAredkl780s43qhYUZdONi5471xJQKEX6Ix8XNyxg=; b=DI4memCffS1PtJFWjluOiFVRTuz92srzQ/eqH/z+nxfmsJnUp+Oy3TvWva8UoYxOzV qgrDCVkXaF1v9YBo6wLT0AmGG0KndMx+zZP+11lwJtqGTjKntnYTXBilu08OzR5cFVE+ ZZrnWon4glnIsx2cU8KWPiIBIidTH5Y7Yhbr8YhXFjo9z3IA3p4OLIfFMuoH+P9TK847 t2CrnwYskSQRs5rGtThTBaHapzbrOmcEcyq/30P2J4V7tXBmaXtWh27W6lqshJfKX5+P oIFwZx6X46mVccdG2Qx6TkgK3skzfxFrz5PQd0sLMYt5vVxenGm1xxoziv03f3HFWWC5 4lBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=MNaAredkl780s43qhYUZdONi5471xJQKEX6Ix8XNyxg=; b=iYVzX9/cmp+AQZomL0BmPys/W6MKJxaqRKRD8J1r+lTvvO3dnegsqML59agHKV0eIQ nkk4JSj2YHgNTlM5ByhQweRTIj4C+6ZbsC9gYWR0Ji3vRl/mB1NoaZscKBmmPfJnS1E2 uiDnQA2+v/TeefXbixi+BuHVV69meKXgx7JN3/vD2DmoYj2mcTuAElC2ix8xs8pWMCTb dGAEff6AhVPS8hOBmVggUBHbIiBR73PXC1jWkMRiy8f2ZOEFVmgiqgf444CxJU5zOiyF +Ek1b6wGFJDWJBhcju7wkG/ad+pajmf4GFhNE1ShVET4HpujzfHPfikGzapDkz261nzZ zG4A== X-Gm-Message-State: AMCzsaWGksWE9Go9j323tvzXofgUP0Doet6TvhXzc6+h7d2KajaXmU6v +X9/SU9fK9O3w0IRaPHHgmClwkBpzFwOJQ3TgKE= X-Google-Smtp-Source: ABhQp+TZg9sPA0RDgIJVlBj1UQnGJ/ZobviJYF67jxDxMwexZk1V3PmDeT4zNSTkGH1Hxq1r7P6H9rlPllo2cyNrNLg= X-Received: by 10.202.243.85 with SMTP id r82mr1998203oih.82.1509199864028; Sat, 28 Oct 2017 07:11:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Sat, 28 Oct 2017 07:10:33 -0700 (PDT) From: Richard Copley Date: Sat, 28 Oct 2017 15:10:33 +0100 Message-ID: Subject: Trouble with misaligned jmp_buf in 64-bit MinGW-64 runtime, in Emacs 26 To: mingw-w64-public@lists.sourceforge.net, 29040@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29040 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello MinGW-W64, I'm writing on behalf of the Emacs developers. They are keen to have your advice on the proper way to call setjmp with the current version of the 64-bit MinGW-W64 runtime. I tried to summarise the current issue in Emacs bug #29040. Would you mind having a look at the report, please? I have CC'd the bug's email address on the Emacs bug tracker. Warm regards, Richard. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 10:14:32 2017 Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 14:14:32 +0000 Received: from localhost ([127.0.0.1]:39341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Rsd-0005Ls-RS for submit@debbugs.gnu.org; Sat, 28 Oct 2017 10:14:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Rsc-0005Lf-5F for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 10:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8RsS-0003j5-66 for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 10:14:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8RsS-0003iq-2s; Sat, 28 Oct 2017 10:14:20 -0400 Received: from [176.228.60.248] (port=4873 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e8RsR-0002Ef-BA; Sat, 28 Oct 2017 10:14:19 -0400 Date: Sat, 28 Oct 2017 17:14:14 +0300 Message-Id: <83d1575phl.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Sat, 28 Oct 2017 14:56:15 +0100) Subject: Re: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Richard Copley > Date: Sat, 28 Oct 2017 14:56:15 +0100 > Cc: "help-gnu-emacs@gnu.org" , 29040@debbugs.gnu.org > > > So my guess was correct, and we should ask the MinGW64 developers for > > advice about using longjmp. Most probably, something in that area has > > changed in recent releases of their runtime, because otherwise I > > cannot explain to myself why these issues pop up only now. > > I thought Paul was of a differing opinion (see > ) > but perhaps I'm mixing up different issues. I'm not saying that this is a GCC bug. But maybe you are right, and the changes in d7038020 exposed this problem. I would have thought it was the other way around: the mis-alignment should have been fixed by those changes, but the fact that the pretest doesn't have this problem tells otherwise. > Do I take it we don't get to allocate the jmp_buf ourselves? It is a member of struct thread_state, and the struct itself should be correctly aligned on the emacs-26 branch, AFAIU. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 11:58:52 2017 Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 15:58:52 +0000 Received: from localhost ([127.0.0.1]:39371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8TVc-0007tz-49 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 11:58:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8TVa-0007tk-A1 for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 11:58:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8TVQ-00008P-CX for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 11:58:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8TVQ-00007z-8B; Sat, 28 Oct 2017 11:58:40 -0400 Received: from [176.228.60.248] (port=1059 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e8TVO-0000Km-2v; Sat, 28 Oct 2017 11:58:39 -0400 Date: Sat, 28 Oct 2017 18:58:28 +0300 Message-Id: <83a80b5knv.fsf@gnu.org> From: Eli Zaretskii To: rcopley@gmail.com In-reply-to: <83d1575phl.fsf@gnu.org> (message from Eli Zaretskii on Sat, 28 Oct 2017 17:14:14 +0300) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 28 Oct 2017 17:14:14 +0300 > From: Eli Zaretskii > Cc: 29040@debbugs.gnu.org > > I'm not saying that this is a GCC bug. But maybe you are right, and > the changes in d7038020 exposed this problem. Actually, I think it was caused by 015f0bb. Does the patch below fix the problem? Please actually check the alignment of getcjmp, not just that the crashes went away. diff --git a/src/thread.c b/src/thread.c index 6f12d79..2520771 100644 --- a/src/thread.c +++ b/src/thread.c @@ -26,7 +26,11 @@ along with GNU Emacs. If not, see . */ #include "coding.h" #include "syssignal.h" -static struct thread_state alignas (GCALIGNMENT) main_thread; +#define COMMON_MULTIPLE(a, b) \ + ((a) % (b) == 0 ? (a) : (b) % (a) == 0 ? (b) : (a) * (b)) +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALIGNMENT) + +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; struct thread_state *current_thread = &main_thread; From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 12:16:52 2017 Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 16:16:52 +0000 Received: from localhost ([127.0.0.1]:39384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Tn2-0008Mh-0N for submit@debbugs.gnu.org; Sat, 28 Oct 2017 12:16:52 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:54974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Tn0-0008MR-PW for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 12:16:51 -0400 Received: by mail-oi0-f44.google.com with SMTP id a132so15243612oih.11 for <29040@debbugs.gnu.org>; Sat, 28 Oct 2017 09:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BJbpldwBY9vKLMCRrWvdhuGkHjHBzHfYDlrIC6Ue2RA=; b=JTkeBjmXXYjLGrwoXiBQ8xEznc3+scK0lYYaW9dqrqRJfEfc0cvyHQB7hZ5XMURwZO V2raab5qzs+WVL7W8zGzxMhhWNFGEkf1YHNdsT+nC2owwU9/ahmiOZiaVbaYKvdsi0UN CXbBQ5gVYQRROmkrJ843x7BQMTWm2otJuh2P3gdnQFGarBIo1v9urt4m5HOlLdOZn3P6 28PDow6uT1uPiGTUDcXVDb0uLPMg6NvLwgjEL2AqJLgHfTy7L2g2gC2u3BgdbWn7RQE3 mRoUNm9DB6HxeHohXhgb9CwAStTTcdCRTQMDoVj7v1U897TeT5r0YQDuwznYdG1p2XqN uDzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BJbpldwBY9vKLMCRrWvdhuGkHjHBzHfYDlrIC6Ue2RA=; b=ogOwhYoLuAv4ATw1GWDgdZvA1h6ci8V9KvzOy9d5x/OXsNeYatLBNIeBCxCk1YvMTB cV0n+Z+JwFiq7D42YV1pg9/h376ANYYkFZMJtFgTh5zmyGt7+6bj2R4zNpUw/dIoPJqv GfvXVLvkQy8oRQOE3AgK6C6LswVdP918CdEnZDCrkHz0StFuQ35Q8NEPevcENXHMj0rc OqHsyqRsBTV10HN9FrAHBjT8A4wQKTqj67PgSB2XyY3tg/sff6lAJRqJ1pj2Pqwz7lxf CbcA89riQbRtWUf9Z9sLRdL4gUyaWF1WCo6vQrq7c1xnkBw2Oj0AStql+zWfyqUIQhsU QfAA== X-Gm-Message-State: AMCzsaWhvgdtVe9UcwJ/BmY4nTLEtDCelN9QIo/V7vpyebiTxdfUK2KB QErNvU7bPbijKfINEzCvWs8FPAPsI4XjVJ468mZJghU4 X-Google-Smtp-Source: ABhQp+ScS/8wSgKdzihWPRsi5VqjrhsooIiLbXT1UhdsAeyuqf0N2DGwS7rfjDm/C3NQVsBLbVvj7SuKBXOOOqlTjCE= X-Received: by 10.157.48.124 with SMTP id w57mr2431945otd.440.1509207404739; Sat, 28 Oct 2017 09:16:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Sat, 28 Oct 2017 09:16:14 -0700 (PDT) In-Reply-To: <83a80b5knv.fsf@gnu.org> References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> <83a80b5knv.fsf@gnu.org> From: Richard Copley Date: Sat, 28 Oct 2017 17:16:14 +0100 Message-ID: Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 28 October 2017 at 16:58, Eli Zaretskii wrote: >> Date: Sat, 28 Oct 2017 17:14:14 +0300 >> From: Eli Zaretskii >> Cc: 29040@debbugs.gnu.org >> >> I'm not saying that this is a GCC bug. But maybe you are right, and >> the changes in d7038020 exposed this problem. > > Actually, I think it was caused by 015f0bb. Does the patch below fix > the problem? Please actually check the alignment of getcjmp, not just > that the crashes went away. > > diff --git a/src/thread.c b/src/thread.c > index 6f12d79..2520771 100644 > --- a/src/thread.c > +++ b/src/thread.c > @@ -26,7 +26,11 @@ along with GNU Emacs. If not, see . */ > #include "coding.h" > #include "syssignal.h" > > -static struct thread_state alignas (GCALIGNMENT) main_thread; > +#define COMMON_MULTIPLE(a, b) \ > + ((a) % (b) == 0 ? (a) : (b) % (a) == 0 ? (b) : (a) * (b)) > +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALIGNMENT) > + > +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; > > struct thread_state *current_thread = &main_thread; Looks good. There's no crash and getcjmp is aligned: Thread 1 hit Breakpoint 3, quit_throw_to_read_char ( from_signal=from_signal@entry=false) at keyboard.c:10548 10548 sys_longjmp (getcjmp, 1); (gdb) p &getcjmp $1 = (sys_jmp_buf *) 0x4005cdaf0 My message to MinGW-W64 was held up for moderation. I have cancelled it. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 12:41:55 2017 Received: (at 29040) by debbugs.gnu.org; 28 Oct 2017 16:41:55 +0000 Received: from localhost ([127.0.0.1]:39399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8UBF-0000ZN-L3 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 12:41:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8UBE-0000ZA-2v for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 12:41:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8UB4-00024l-34 for 29040@debbugs.gnu.org; Sat, 28 Oct 2017 12:41:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8UB3-00024f-Vj; Sat, 28 Oct 2017 12:41:42 -0400 Received: from [176.228.60.248] (port=1086 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e8UB2-0002BI-St; Sat, 28 Oct 2017 12:41:41 -0400 Date: Sat, 28 Oct 2017 19:41:33 +0300 Message-Id: <838tfv5io2.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Sat, 28 Oct 2017 17:16:14 +0100) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> <83a80b5knv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Richard Copley > Date: Sat, 28 Oct 2017 17:16:14 +0100 > Cc: 29040@debbugs.gnu.org > > > Actually, I think it was caused by 015f0bb. Does the patch below fix > > the problem? Please actually check the alignment of getcjmp, not just > > that the crashes went away. > > > > diff --git a/src/thread.c b/src/thread.c > > index 6f12d79..2520771 100644 > > --- a/src/thread.c > > +++ b/src/thread.c > > @@ -26,7 +26,11 @@ along with GNU Emacs. If not, see . */ > > #include "coding.h" > > #include "syssignal.h" > > > > -static struct thread_state alignas (GCALIGNMENT) main_thread; > > +#define COMMON_MULTIPLE(a, b) \ > > + ((a) % (b) == 0 ? (a) : (b) % (a) == 0 ? (b) : (a) * (b)) > > +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALIGNMENT) > > + > > +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; > > > > struct thread_state *current_thread = &main_thread; > > Looks good. There's no crash and getcjmp is aligned: > > Thread 1 hit Breakpoint 3, quit_throw_to_read_char ( > from_signal=from_signal@entry=false) at keyboard.c:10548 > 10548 sys_longjmp (getcjmp, 1); > (gdb) p &getcjmp > $1 = (sys_jmp_buf *) 0x4005cdaf0 Thanks, I installed that. If the problem doesn't come back, please close the bug. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 14:11:12 2017 Received: (at 29040) by debbugs.gnu.org; 29 Oct 2017 18:11:12 +0000 Received: from localhost ([127.0.0.1]:40851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8s3E-0002T4-Iv for submit@debbugs.gnu.org; Sun, 29 Oct 2017 14:11:12 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:48817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8s3C-0002Sp-DW for 29040@debbugs.gnu.org; Sun, 29 Oct 2017 14:11:10 -0400 Received: by mail-oi0-f42.google.com with SMTP id m198so17957867oig.5 for <29040@debbugs.gnu.org>; Sun, 29 Oct 2017 11:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dCQ5lPGHZxsFTpJziH2jBPFb8Qls56t0vTK4/NRTrks=; b=qqu05Y67EdrejafaTJBcfeFcPRbee/0sXrNPd7XxJiXbpGWb208WlyZudIv5yK+me+ W6KP71wdSoV0vqoEmGfy7krkK1MBzW8g6Xz3k8fufm00Y9hKqW2c1wZ/KOEZEi0pLZ2s OI7ZRoM7YyOEckT7LznBOwLrfp7J8qbLFuz19JfYm9m4C2pUsB32gNROo3s6V8/wYyJM pEKwnxzxc7ok4TQZab36uBbPssjokVC+dIhZONG5QfRLwH5/T50VpMy5uQ+R7f4ucysB fe3ex38j5DN1OeDET/A3lnXkCayqTEz5RHDPFV/8n7XVXS53bPUiJo6qFyPYnfueEKCG cj4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dCQ5lPGHZxsFTpJziH2jBPFb8Qls56t0vTK4/NRTrks=; b=D7nBxRM4E+MpWxczTmX8vxL73QRvMsFi/fUgChT6MynHro9EgXTR96662nsbY/74Fx ZRo14NcEASsb/Vf/85FqCHTlhl9aA9u5BOHzCCYNZSS2t6VHGYCoJ+RyKZBM/pfak+89 HoizLclzkz43fP1Kp+RjsPD3eMlCr7VxeUg+LHYHpL09orvP/sjcHPF94iyZ30LuWaCO 1vL3FO5Kh+Bz0OZgmlVzStgzn+0I7lPpYPYXJ0SFxDXwAlYf/EwNxBMPe5lF1bvR+zEV gTKgIYXJl9Qj1Ei0VTesIXQUripOC5VKnKe8lpta3Jgv7+0tnXlvqaIAjdvsZ+QRl/Tf NzQA== X-Gm-Message-State: AMCzsaVYAMwJGCHzG79pBLFyJ1suc/u2LdIzpym7NG+sFKBu+i80ckWb yJCLtcH3s2uWp3+WcBzdOJtpr+i2Fn/KlsZBu2w= X-Google-Smtp-Source: ABhQp+SJKdswtzNhBOZBCYYWNthopdCW4LKkzeqceZ9caidjuVeJNCtuat0H8w71otLyUwYoSYJEzC7FM8/nOwtaxS8= X-Received: by 10.157.82.73 with SMTP id q9mr4093385otg.31.1509300664786; Sun, 29 Oct 2017 11:11:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Sun, 29 Oct 2017 11:10:34 -0700 (PDT) In-Reply-To: <838tfv5io2.fsf@gnu.org> References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> <83a80b5knv.fsf@gnu.org> <838tfv5io2.fsf@gnu.org> From: Richard Copley Date: Sun, 29 Oct 2017 18:10:34 +0000 Message-ID: Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > If the problem doesn't come back, please close the bug. Not sure yet. There was a crash, but no opportunity to attach the debugger. I'm running in the debugger now but there has not been another crash so far. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 01 15:17:27 2017 Received: (at 29040) by debbugs.gnu.org; 1 Nov 2017 19:17:28 +0000 Received: from localhost ([127.0.0.1]:46397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9yVz-0005Tu-No for submit@debbugs.gnu.org; Wed, 01 Nov 2017 15:17:27 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:47879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9yVw-0005Tb-7g; Wed, 01 Nov 2017 15:17:24 -0400 Received: by mail-oi0-f41.google.com with SMTP id h200so6102088oib.4; Wed, 01 Nov 2017 12:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=izr1f4Q3+QZTg8nm6Vxb8U5PEpZ8Ld3CnvYpOyoF79k=; b=JYxhbFSM41of7/6Yr2t0f0CfEfUO9z+d9yIiVI0Yy3p7ybf8u8Hg87zaIQHkcYG//U 2RdIQ1W3GS2OQVgLA6ibBu1PG2HfO3zYzlPAxrkCpJ1Az76DKjVH76nu9vTrC6+GfqP3 8Ep2TjAL3KJ7bRnVlx+aEa3Na7DbpDmSrmQ42SGYZTJSZ5RM+U625yHpxF1owj2qIUPJ kSRuwkG8BJmAZpzZjViTy0Bc8rQivawHJJdoqZvr2Fv0dmFAZyvD8sDRLUbOzlFjf+4C en5lLAor3UsqncA7OqJvArJYB5WzJwbKcK0+mMObOu6tfURWxUa6M/EahHOClZJSB9w2 XYNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=izr1f4Q3+QZTg8nm6Vxb8U5PEpZ8Ld3CnvYpOyoF79k=; b=izUOis70kvDbTw3C1ehCdDcFQFBvYKZgDawtpHohK84WCCYvAQM8NIQkhqJMatHEQY 8CVcIRTNYDCrlom+7QO3FNJxmEiXeGdJ7wTY09Isv0X0LBaCOS1R2xuSeFg3fqoEX1VA nPMlweM0SpkMHVVNR3LrUpm1HUMYgy876Hr/ylO+9lRf5q9QIAHGGjkX+4MOINK0mJbP bOVVk6OCQhldiPBa3a+0lOkIc7sAhUR//nJKiVxMLH0ohFjODdaymdcYqEc7lEUlIBfb sD8Bua2KUMU0KOROYuL0/Un9mHLuRVlD+jnbPlI6LXV2LqX/2TpnL7GDFOKGC2vLTY4B QBug== X-Gm-Message-State: AJaThX5na4ixBaZ1QvJX45O3vktqFM58DvJQtJuoDnrCStICQ+CpumxZ 3dLA/7OOWjz1kiehyeZZ+5TvT/Ndu8R2bxMc+8A= X-Google-Smtp-Source: ABhQp+QWGjZe8acX5b5XNv5MZQTZrSgTOmv/1EfjCiEbQpqCLn2ii7Ixab30DSk7097HaUctX++3WdBvbwX3NIK29e8= X-Received: by 10.157.86.195 with SMTP id b3mr477289otj.122.1509563838446; Wed, 01 Nov 2017 12:17:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Wed, 1 Nov 2017 12:16:48 -0700 (PDT) In-Reply-To: References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> <83a80b5knv.fsf@gnu.org> <838tfv5io2.fsf@gnu.org> From: Richard Copley Date: Wed, 1 Nov 2017 19:16:48 +0000 Message-ID: Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii , GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 29040 fixed close 29040 thanks On 29 October 2017 at 18:10, Richard Copley wrote: >> If the problem doesn't come back, please close the bug. > > Not sure yet. There was a crash, but no opportunity to attach > the debugger. I'm running in the debugger now but there has > not been another crash so far. Seems fine now, probably I was mistaken. Thanks very much. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 02:02:56 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 06:02:56 +0000 Received: from localhost ([127.0.0.1]:46750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eA8ac-0005Ur-EW for submit@debbugs.gnu.org; Thu, 02 Nov 2017 02:02:56 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eA8aY-0005UY-Jc for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 02:02:52 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 955EA160D35; Wed, 1 Nov 2017 23:02:44 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Z2yfr24JdLrr; Wed, 1 Nov 2017 23:02:43 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8EBA8160D3D; Wed, 1 Nov 2017 23:02:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id E-IAenrlw0v2; Wed, 1 Nov 2017 23:02:43 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6C515160D35; Wed, 1 Nov 2017 23:02:43 -0700 (PDT) To: Eli Zaretskii From: Paul Eggert Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file Organization: UCLA Computer Science Department Message-ID: Date: Wed, 1 Nov 2017 23:02:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALI= GNMENT) > + > +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; Three questions: The Gnulib manual=20 says,=20 "Some compilers require the operand of _Alignas/alignas to be a single in= teger=20 constant, not an expression: MSVC 7.0 through at least 10.0." (Also,=20 = =20 suggests that this issue may also occur with VS2013, though VS2015 should= be OK=20 since it supports alignas.) Are any of these older compilers of concern w= hen=20 building Emacs? If so, the above change won't work for them. Why does the above code use 'alignof (max_align_t)' rather than 'alignof = (struct=20 thread_state)'? Doesn't the latter suffice? C11 requires that a compiler must issue a diagnostic for a declaration li= ke=20 'struct thread_state alignas (8) foo;' if the alignment of plain 'struct = state'=20 is greater than 8. Can I take it from this bug report that the Microsoft=20 compilers do not conform to that part of the standard? If so, we should a= dd=20 checks to verify this requirement where it is assumed elsewhere. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 03:40:08 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 07:40:08 +0000 Received: from localhost ([127.0.0.1]:46794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAA6i-000850-3E for submit@debbugs.gnu.org; Thu, 02 Nov 2017 03:40:08 -0400 Received: from mail-ot0-f176.google.com ([74.125.82.176]:53040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAA6f-000849-F8; Thu, 02 Nov 2017 03:40:05 -0400 Received: by mail-ot0-f176.google.com with SMTP id v105so806314ota.9; Thu, 02 Nov 2017 00:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=v25HyLnYQtmF+ngXSVHHq5WuHUUtNcOro9/Baqul2iY=; b=i1GroOxLLS97K7RKp6rnD2k7WO7foCVsRG0Wem4JcANtKovs1r/blYsL5k1PtzoM/w wg8Xxmuzc/ddAWQnBtpe9CaLyTpz7wn6USP8gLUU5WoJ4SH4UyXFxgp0iOGsu8BqCkw5 9HMyqAuwONebo6+bXwk6Jp5D4Sl8ojNSuPp063efqffoCP25V2IWD1pKFGlYHS4aeZjQ 74auLsNTv9VBEeFOogHrFc0GD9xo5RPlRI9Dsp4eUZGcCVR3uhFKgcMyLn9olH7vHpQX S5scCGtCzEKcKb0X1GyWa8DhHSd1mJQ5Qtl2k8ZnR9klIDr3IeeHEY5mu/HTGtnN3oHF Mclg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=v25HyLnYQtmF+ngXSVHHq5WuHUUtNcOro9/Baqul2iY=; b=gDDyuBeB2oN/RkR38AQ31e3XEKpK4uWWXBQb90rp+YtzG6ZQ4XczOOYyvu8i828orE d1hnfrkJXdcGN+xANkBre0au0L93qWmVm0p5UjFwX2/RtmwTsTuqUdUbxjTwizvuu+Qq mXELAEQpF5KXkBZA0mqh9P1BvtOGNl8M9vwxwEvyjAuF4k1mMwEgvsoybGR8IO0pPqb5 +Njz0q4btIY+JBsrPu9lH8FomlfRYLqXFw83DzqFVATZBcGKjHbI3gsNdTq0ynjfJpE6 JRdVxd/VEBP7JBk35MFJ8lYlgOYhU03mwdcMl0yNqL0hatjLZWoSs2ERUQN3guDgMAg4 JqHg== X-Gm-Message-State: AJaThX44dAOXkQQgQUK9qoinWNcRS5grNFIYHLPoNXvyaICD8sh0tkzU /stgIPnkasnrAcDHoL1E8N3K7IAUpht2IzqATYE= X-Google-Smtp-Source: ABhQp+RWEw55gByrQcYeNmL+TBU/I7ty+Dx4532yuXyhIlIy3vSgAmIXFrSgtBNht8gHtFcGJKDJN5ugNNQfS10vVys= X-Received: by 10.157.86.195 with SMTP id b3mr1425573otj.122.1509608399823; Thu, 02 Nov 2017 00:39:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Thu, 2 Nov 2017 00:39:29 -0700 (PDT) In-Reply-To: References: <837evrerok.fsf@gnu.org> <83mv4b5x0y.fsf@gnu.org> <83inez5uta.fsf@gnu.org> <83fua35tem.fsf@gnu.org> <83d1575phl.fsf@gnu.org> <83a80b5knv.fsf@gnu.org> <838tfv5io2.fsf@gnu.org> From: Richard Copley Date: Thu, 2 Nov 2017 07:39:29 +0000 Message-ID: Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii , GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 1 November 2017 at 19:16, Richard Copley wrote: > tags 29040 fixed > close 29040 > thanks > > On 29 October 2017 at 18:10, Richard Copley wrote: >>> If the problem doesn't come back, please close the bug. >> >> Not sure yet. There was a crash, but no opportunity to attach >> the debugger. I'm running in the debugger now but there has >> not been another crash so far. > > Seems fine now, probably I was mistaken. Yes. I hadn't run "make install". I was still seeing the same crash, in my previous build. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 03:44:12 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 07:44:12 +0000 Received: from localhost ([127.0.0.1]:46804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAAAd-0008BV-OW for submit@debbugs.gnu.org; Thu, 02 Nov 2017 03:44:12 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:45793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAAAc-0008BI-5P for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 03:44:10 -0400 Received: by mail-oi0-f52.google.com with SMTP id f66so7691791oib.2 for <29040@debbugs.gnu.org>; Thu, 02 Nov 2017 00:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sdSJf2o10zFx1geOOrsIA95zHB5WGJjY8FYQv9raSnw=; b=bqCCaZdf6LqitwWMS8MORTuVMKiNpRJ3UzBzY2n8WABEHrmAS4wWrT0RcmeGoeMYSR uQtMW53Zsj/vkA6TnkBrb3qPuot/N31r4nnlzj2cNMLKQu3Rvtf6z6h4tGs9+kNh/wTp vLXTUOVuWYrhJcJHJnToP4morUFh+bnXnGep4Snhy84CB1P4LMbMSoXFHFE23Qsi23N0 rWfRrxGWWrnKvjyqBkCwujIpziakBu3Ibi9Dba/xQf+Nalakc85Tp1Al8iJ+2KPC/79h YG5houZW6P2DbHaCIkEg/ogdO3bPRT1I5FtZHLYzloRe4cKXrfaC51dJ7kFCOXW1PQK7 At1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sdSJf2o10zFx1geOOrsIA95zHB5WGJjY8FYQv9raSnw=; b=E3JBB1KrLGDKhPtkt4Zq5WpfUO55fyy3HIkp4JA1te3hvxjvpVxSAJaBfRatlutTgB VPZ01ulHvfEzQx5L1J/DMeDI2oiMqT9MTAelavXRsIGgQJ724vKjvrSAZ4oz0NxYnz8P u0kbDnSW4WBCjPzYYGEFfuWS3yQ8OsQdenPrhuT91l7mBqQbylil3VBEx3pdHwPBiEzN EFSejkDBsV/YeZUktU0SRzcI5Ds3nc+IixO0z1ojeaYvtUrrggVpk2jLmCrRsNGeJ8D9 QF/VSrsAn/RTfjCsnQLUXmcoG30zTMHEv0yg4XbRDNkl5uQtk62VSdRrIabeoRlax86l jIKg== X-Gm-Message-State: AMCzsaUP7UNZYpjzTvfx6mjKKbf6Lp/BCwmdBjrRWM7RwPpI84d4C8/F nQ5SNM2kFYKnbXvg6sQXx2m/MGBPR07TQQw3TbyvnJMW X-Google-Smtp-Source: ABhQp+QinISfd3YWurNGSj6Y9/37wbzS+wK19u6frYZ89aFmxcRsPR9clxb2fiji0Y772wBODJu0JuxhkJPnAdhmweg= X-Received: by 10.202.11.3 with SMTP id 3mr1474685oil.71.1509608644619; Thu, 02 Nov 2017 00:44:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.64.8 with HTTP; Thu, 2 Nov 2017 00:43:34 -0700 (PDT) In-Reply-To: References: From: Richard Copley Date: Thu, 2 Nov 2017 07:43:34 +0000 Message-ID: Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Paul Eggert Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 29040 Cc: Eli Zaretskii , 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 2 November 2017 at 06:02, Paul Eggert wrote: >> +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), >> GCALIGNMENT) >> + >> +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; > > Three questions: > > The Gnulib manual > > says, "Some compilers require the operand of _Alignas/alignas to be a single > integer constant, not an expression: MSVC 7.0 through at least 10.0." (Also, > > suggests that this issue may also occur with VS2013, though VS2015 should be > OK since it supports alignas.) Are any of these older compilers of concern > when building Emacs? I don't think so. How would one go about building Emacs with MSVC anyway? >If so, the above change won't work for them. > Why does the above code use 'alignof (max_align_t)' rather than 'alignof > (struct thread_state)'? Doesn't the latter suffice? For information, in the 64-bit GCC 7.2 toolchain from MinGW-W64, the two are equal in value. > C11 requires that a compiler must issue a diagnostic for a declaration like > 'struct thread_state alignas (8) foo;' if the alignment of plain 'struct > state' is greater than 8. Can I take it from this bug report that the > Microsoft compilers do not conform to that part of the standard? Microsoft compilers weren't mentioned at all. GCC didn't issue a diagnostic. > If so, we should add checks to verify this requirement where it is assumed elsewhere. I think that is a good idea. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 07:10:29 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 11:10:29 +0000 Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADOG-0006oB-Uh for submit@debbugs.gnu.org; Thu, 02 Nov 2017 07:10:29 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:55479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eADOD-0006nv-5e for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 07:10:25 -0400 Received: by mail-io0-f173.google.com with SMTP id p186so13009898ioe.12 for <29040@debbugs.gnu.org>; Thu, 02 Nov 2017 04:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EjhOaT15TE3mX5pec1l5BDYrlmBxDyRlRavh+b3pxiE=; b=QUoHCBeL5oQ24Ia/ebFcvF5JiwLAs3Pqj89X0/dhhmNzbfEw1RUQtFeGW5qUZ2e7Z0 eM/y95Kf7KrHHimvRiXL054kFudiMjQ1o0CLQXcR8B5BSo8pOtVxs8vKg9lZm0qaecDD ehWcsHeudf830g1/Z1akrigGRk+MdEsVAqIA7efH8nLFb6R5ORm6PqEa+zkdjOffdm9P rQh+fzNV6BSFfS+v8Bn4jLN9+gIAL/jeW1N3N/d69p375aQjKSWZRQwF3oSxhWTwExei c7xeDikVaC4cAcBEOJvmLRfBacgc+zTi0cKyCdhw9fNjXYx5CFuRKdBH2dya28tbb/6v F3LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=EjhOaT15TE3mX5pec1l5BDYrlmBxDyRlRavh+b3pxiE=; b=BUh9+qZcuMVkffb30pw4aQHNnzmpfvhTuzNYW8t+AeWIXYveW93sQmPbKf5pAI7Tu9 eRPh726//heM3n0d13UpnvgTBSQ8MR7yy5bAiQjSEhGSQaAsSHlZhG/xt5cLXI6FOsuJ yUMxbn4r2h1gIuREDIT4f7aCpekyQF5KWjYmHUB3Tr35bg6u79E0za2ddtG9xXNz9vgj VT3oDnWf3L1aFrdrmgMOgVbblvIOoB+JDnnKARRCsX7uMuAZZf55XPddgLRt2ry7EgKE 0zT9BwujI4hGeMW93Kw1Deur9Ba7xAqxOktT9eShdZykrXGrJhE1bkWiaQzWp4+Qm7cf d1dQ== X-Gm-Message-State: AMCzsaVCM8ukgc4pV0vKMzJvXjV6XEPXxMnB/YdVvxV0q6IquhGtY2eh he6oO/es7hIYQpPDJ6DE9xM8Mg== X-Google-Smtp-Source: ABhQp+REe5JPvOfF699Hxhz+EYZ+XgaElNZHNpKN+vYG61RX1gMb8ZQn28bMXR/yMnKwODgyzeMvkA== X-Received: by 10.107.81.20 with SMTP id f20mr3848712iob.274.1509621018331; Thu, 02 Nov 2017 04:10:18 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i71sm1422749iod.59.2017.11.02.04.10.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Nov 2017 04:10:17 -0700 (PDT) From: Noam Postavsky To: Richard Copley Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: Date: Thu, 02 Nov 2017 07:10:16 -0400 In-Reply-To: (Richard Copley's message of "Thu, 2 Nov 2017 07:43:34 +0000") Message-ID: <87shdx7x7r.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 29040 Cc: Eli Zaretskii , Paul Eggert , 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Richard Copley writes: > I don't think so. How would one go about building Emacs with MSVC anyway? AFAIK, it used to be possible via nt/config.bat, but we stopped supporting it in 24.4 and removed the code for it entirely in 25.1. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 11:50:21 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 15:50:22 +0000 Received: from localhost ([127.0.0.1]:48091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAHl7-00009A-IM for submit@debbugs.gnu.org; Thu, 02 Nov 2017 11:50:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAHl6-00008y-47 for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 11:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAHkw-0005i0-N2 for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 11:50:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAHkw-0005hq-Jl; Thu, 02 Nov 2017 11:50:10 -0400 Received: from [176.228.60.248] (port=3050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAHkw-0000pr-3E; Thu, 02 Nov 2017 11:50:10 -0400 Date: Thu, 02 Nov 2017 17:50:01 +0200 Message-Id: <83wp38r87q.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Wed, 1 Nov 2017 23:02:39 -0700) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: rcopley@gmail.com, 29040@debbugs.gnu.org > From: Paul Eggert > Date: Wed, 1 Nov 2017 23:02:39 -0700 > > > +#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALIGNMENT) > > + > > +static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; > > Three questions: > > The Gnulib manual > says, > "Some compilers require the operand of _Alignas/alignas to be a single integer > constant, not an expression: MSVC 7.0 through at least 10.0." (Also, > > suggests that this issue may also occur with VS2013, though VS2015 should be OK > since it supports alignas.) Are any of these older compilers of concern when > building Emacs? If so, the above change won't work for them. We've stopped supporting MSVC long ago. Only GCC is supported for building on MS-Windows. > Why does the above code use 'alignof (max_align_t)' rather than 'alignof (struct > thread_state)'? Doesn't the latter suffice? No special reason, I just did the same as you did in aligning pseudovectors, when we had a similar problem the last time. Feel free to change if you think it's better. > C11 requires that a compiler must issue a diagnostic for a declaration like > 'struct thread_state alignas (8) foo;' if the alignment of plain 'struct state' > is greater than 8. Can I take it from this bug report that the Microsoft > compilers do not conform to that part of the standard? If so, we should add > checks to verify this requirement where it is assumed elsewhere. Again, this is GCC, so what MS compilers do is not interesting. The problem was caused by your changes in 015f0bb, which were for OpenVMS: diff --git a/src/thread.c b/src/thread.c index c03cdda..6f12d79 100644 --- a/src/thread.c +++ b/src/thread.c @@ -26,7 +26,7 @@ along with GNU Emacs. If not, see . */ #include "coding.h" #include "syssignal.h" -static struct thread_state main_thread; +static struct thread_state alignas (GCALIGNMENT) main_thread; struct thread_state *current_thread = &main_thread; This downgraded the alignment on 64-bit MS-Windows hosts, so I upgraded it back. If using alignas with an argument > 8 is non-portable, then I guess we will have to make your OpenVMS fix conditional on just that platform. Or do you see a cleaner fix? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 16:35:29 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 20:35:30 +0000 Received: from localhost ([127.0.0.1]:48320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMD3-0000m6-G8 for submit@debbugs.gnu.org; Thu, 02 Nov 2017 16:35:29 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMD1-0000lr-Jq for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 16:35:28 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A31B0160692; Thu, 2 Nov 2017 13:35:21 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id u26txMDVX8VE; Thu, 2 Nov 2017 13:35:20 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 387731610AF; Thu, 2 Nov 2017 13:35:20 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aoP3MPffdqH5; Thu, 2 Nov 2017 13:35:20 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 18B501610A9; Thu, 2 Nov 2017 13:35:20 -0700 (PDT) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii References: <83wp38r87q.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> Date: Thu, 2 Nov 2017 13:35:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <83wp38r87q.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------606686C1CBDB2F75DF505236" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------606686C1CBDB2F75DF505236 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 11/02/2017 08:50 AM, Eli Zaretskii wrote: > do you see a cleaner fix? Yes, we can stop using alignas entirely, since it doesn't work the way I expected. I thought that it could only increase alignment, and that it was a no-op if it specified a decreased alignment: this is how __attribute__ ((aligned (8))) works. However, I now see that C11 says that a compiler is supposed to report an error if alignas specifies a decreased alignment. So I installed the attached patch to stop using alignas. > We've stopped supporting MSVC long ago. OK. Can we then simplify the source a little bit, in the 'master' branch, as a low-priority task? I was thinking of something like this: * Remove my_endbss_static in lastfile.c, since we no longer need to worry about the Alpha MSVC linker. * Remove the the _MSC_VER-specific code in lisp.h's definitions of ENUM_BF and DEFUN and in regex.c's definition of re_char and const_re_char. --------------606686C1CBDB2F75DF505236 Content-Type: text/x-patch; name="0001-Fix-alignment-portability-problems.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-alignment-portability-problems.patch" >From f8e2d438bfd4923b30ff878e5834e1d8e4061397 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 2 Nov 2017 13:06:38 -0700 Subject: [PATCH] Fix alignment portability problems Do not assume that the natural alignment of Lisp objects is a multiple of GCALIGNMENT. This improves on the portability of the recent fix for Bug#29040. * lib-src/make-docfile.c (close_emacs_globals): * src/buffer.c (buffer_defaults, buffer_local_symbols): * src/lisp.h (DEFUN): * src/thread.c (main_thread): Use GCALIGNED, not alignas (GCALIGNMENT). * src/alloc.c (COMMON_MULTIPLE): Move back here from lisp.h, since it is no longer used elsewhere. * src/lisp.h (GCALIGNMENT): No longer a macro, since we need not worry about MSVC. Omit no-longer-needed consistency check. * src/thread.c (THREAD_ALIGNMENT): Remove. --- lib-src/make-docfile.c | 2 +- src/alloc.c | 6 ++++++ src/buffer.c | 4 ++-- src/lisp.h | 25 ++++++++----------------- src/thread.c | 4 +--- 5 files changed, 18 insertions(+), 23 deletions(-) diff --git a/lib-src/make-docfile.c b/lib-src/make-docfile.c index 69c7f37a17..0ea3f7b6b6 100644 --- a/lib-src/make-docfile.c +++ b/lib-src/make-docfile.c @@ -668,7 +668,7 @@ close_emacs_globals (ptrdiff_t num_symbols) "extern\n" "#endif\n" "struct {\n" - " struct Lisp_Symbol alignas (GCALIGNMENT) s;\n" + " struct Lisp_Symbol GCALIGNED s;\n" "} lispsym[%td];\n"), num_symbols); } diff --git a/src/alloc.c b/src/alloc.c index ff93956109..0fc79fe68a 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -621,6 +621,12 @@ buffer_memory_full (ptrdiff_t nbytes) #endif } +/* A common multiple of the positive integers A and B. Ideally this + would be the least common multiple, but there's no way to do that + as a constant expression in C, so do the best that we can easily do. */ +#define COMMON_MULTIPLE(a, b) \ + ((a) % (b) == 0 ? (a) : (b) % (a) == 0 ? (b) : (a) * (b)) + #ifndef XMALLOC_OVERRUN_CHECK #define XMALLOC_OVERRUN_CHECK_OVERHEAD 0 #else diff --git a/src/buffer.c b/src/buffer.c index 9635733fcf..15735a298a 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -61,7 +61,7 @@ struct buffer *all_buffers; Setting the default value also goes through the alist of buffers and stores into each buffer that does not say it has a local value. */ -struct buffer alignas (GCALIGNMENT) buffer_defaults; +struct buffer GCALIGNED buffer_defaults; /* This structure marks which slots in a buffer have corresponding default values in buffer_defaults. @@ -84,7 +84,7 @@ struct buffer buffer_local_flags; /* This structure holds the names of symbols whose values may be buffer-local. It is indexed and accessed in the same way as the above. */ -struct buffer alignas (GCALIGNMENT) buffer_local_symbols; +struct buffer GCALIGNED buffer_local_symbols; /* Return the symbol of the per-buffer variable at offset OFFSET in the buffer structure. */ diff --git a/src/lisp.h b/src/lisp.h index 43b3ec618f..bf9db591bd 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -228,14 +228,12 @@ extern bool suppress_checking EXTERNALLY_VISIBLE; USE_LSB_TAG not only requires the least 3 bits of pointers returned by malloc to be 0 but also needs to be able to impose a mult-of-8 alignment - on the few static Lisp_Objects used: lispsym, all the defsubr, and - the two special buffers buffer_defaults and buffer_local_symbols. */ + on the few static Lisp_Objects used, all of which are aligned via + the GCALIGN macro defined below. */ enum Lisp_Bits { - /* 2**GCTYPEBITS. This must be a macro that expands to a literal - integer constant, for MSVC. */ -#define GCALIGNMENT 8 + GCALIGNMENT = 1 << GCTYPEBITS, /* Number of bits in a Lisp_Object value, not counting the tag. */ VALBITS = EMACS_INT_WIDTH - GCTYPEBITS, @@ -247,10 +245,6 @@ enum Lisp_Bits FIXNUM_BITS = VALBITS + 1 }; -#if GCALIGNMENT != 1 << GCTYPEBITS -# error "GCALIGNMENT and GCTYPEBITS are inconsistent" -#endif - /* The maximum value that can be stored in a EMACS_INT, assuming all bits other than the type bits contribute to a nonnegative signed value. This can be used in #if, e.g., '#if USE_LSB_TAG' below expands to an @@ -277,18 +271,15 @@ DEFINE_GDB_SYMBOL_END (VALMASK) error !; #endif +/* Declare an object to have an address that is a multiple of + GCALIGNMENT. alignas is not suitable here, as it fails if the + object's natural alignment exceeds GCALIGNMENT. */ #ifdef HAVE_STRUCT_ATTRIBUTE_ALIGNED # define GCALIGNED __attribute__ ((aligned (GCALIGNMENT))) #else # define GCALIGNED /* empty */ #endif -/* A common multiple of the positive integers A and B. Ideally this - would be the least common multiple, but there's no way to do that - as a constant expression in C, so do the best that we can easily do. */ -#define COMMON_MULTIPLE(a, b) \ - ((a) % (b) == 0 ? (a) : (b) % (a) == 0 ? (b) : (a) * (b)) - /* Some operations are so commonly executed that they are implemented as macros, not functions, because otherwise runtime performance would suffer too much when compiling with GCC without optimization. @@ -2946,7 +2937,7 @@ CHECK_NUMBER_CDR (Lisp_Object x) #ifdef _MSC_VER #define DEFUN(lname, fnname, sname, minargs, maxargs, intspec, doc) \ Lisp_Object fnname DEFUN_ARGS_ ## maxargs ; \ - static struct Lisp_Subr alignas (GCALIGNMENT) sname = \ + static struct Lisp_Subr GCALIGNED sname = \ { { (PVEC_SUBR << PSEUDOVECTOR_AREA_BITS) \ | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)) }, \ { (Lisp_Object (__cdecl *)(void))fnname }, \ @@ -2954,7 +2945,7 @@ CHECK_NUMBER_CDR (Lisp_Object x) Lisp_Object fnname #else /* not _MSC_VER */ #define DEFUN(lname, fnname, sname, minargs, maxargs, intspec, doc) \ - static struct Lisp_Subr alignas (GCALIGNMENT) sname = \ + static struct Lisp_Subr GCALIGNED sname = \ { { PVEC_SUBR << PSEUDOVECTOR_AREA_BITS }, \ { .a ## maxargs = fnname }, \ minargs, maxargs, lname, intspec, 0}; \ diff --git a/src/thread.c b/src/thread.c index 7a670ba410..03f5b31855 100644 --- a/src/thread.c +++ b/src/thread.c @@ -26,9 +26,7 @@ along with GNU Emacs. If not, see . */ #include "coding.h" #include "syssignal.h" -#define THREAD_ALIGNMENT COMMON_MULTIPLE (alignof (max_align_t), GCALIGNMENT) - -static struct thread_state alignas (THREAD_ALIGNMENT) main_thread; +static struct thread_state GCALIGNED main_thread; struct thread_state *current_thread = &main_thread; -- 2.13.6 --------------606686C1CBDB2F75DF505236-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 02 16:46:32 2017 Received: (at 29040) by debbugs.gnu.org; 2 Nov 2017 20:46:32 +0000 Received: from localhost ([127.0.0.1]:48351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMNk-00014B-6s for submit@debbugs.gnu.org; Thu, 02 Nov 2017 16:46:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAMNi-00013y-6z for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 16:46:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAMNY-0006HN-Ix for 29040@debbugs.gnu.org; Thu, 02 Nov 2017 16:46:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAMNY-0006H9-F4; Thu, 02 Nov 2017 16:46:20 -0400 Received: from [176.228.60.248] (port=1308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAMNW-0004NN-RB; Thu, 02 Nov 2017 16:46:19 -0400 Date: Thu, 02 Nov 2017 22:46:11 +0200 Message-Id: <83k1z8wgrw.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> (message from Paul Eggert on Thu, 2 Nov 2017 13:35:16 -0700) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: rcopley@gmail.com, 29040@debbugs.gnu.org > From: Paul Eggert > Date: Thu, 2 Nov 2017 13:35:16 -0700 > > Yes, we can stop using alignas entirely, since it doesn't work the way I > expected. I thought that it could only increase alignment, and that it > was a no-op if it specified a decreased alignment: this is how > __attribute__ ((aligned (8))) works. However, I now see that C11 says > that a compiler is supposed to report an error if alignas specifies a > decreased alignment. So I installed the attached patch to stop using > alignas. Thanks, but I think the resulting code is confusing. E.g.: static struct thread_state GCALIGNED main_thread; This looks like we ask main_thread to be 8-byte aligned, which would bring back the problems we had before. Requiring readers to read the C Standard is not a good thing. Can we come up with a clearer code, please? > * Remove my_endbss_static in lastfile.c, since we no longer need to > worry about the Alpha MSVC linker. I don't know anything about that code, and I don't think anyone does. Who will tell us that the comment is still accurate? > * Remove the the _MSC_VER-specific code in lisp.h's definitions of > ENUM_BF and DEFUN and in regex.c's definition of re_char and const_re_char. I don't think ENUM_BF is only for MSVC. The condition there mentions other compilers. Anything that is conditioned by _MSC_VER can go. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 01:03:27 2017 Received: (at 29040) by debbugs.gnu.org; 3 Nov 2017 05:03:27 +0000 Received: from localhost ([127.0.0.1]:48557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAU8c-0008L6-UH for submit@debbugs.gnu.org; Fri, 03 Nov 2017 01:03:27 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAU8b-0008Kt-8h for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 01:03:26 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 697D51600EA; Thu, 2 Nov 2017 22:03:19 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1d3KGTJ16-zh; Thu, 2 Nov 2017 22:03:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 033A91605ED; Thu, 2 Nov 2017 22:03:18 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id x9lV1XAMbLGT; Thu, 2 Nov 2017 22:03:17 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CE8A81600EA; Thu, 2 Nov 2017 22:03:17 -0700 (PDT) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> <83k1z8wgrw.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> Date: Thu, 2 Nov 2017 22:03:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <83k1z8wgrw.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------3B112DF735F0C4818F4BDA87" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------3B112DF735F0C4818F4BDA87 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Eli Zaretskii wrote: > Thanks, but I think the resulting code is confusing. E.g.: >=20 > static struct thread_state GCALIGNED main_thread; >=20 > This looks like we ask main_thread to be 8-byte aligned, which would > bring back the problems we had before. I attempted to clarify this by installing the first attached patch into t= he=20 emacs-26 branch. This patch adds a comment to the definition of GCALIGNED= . If=20 the name "GCALIGNED" itself is confusing, we can systematically change th= e name=20 to something else. (The name doesn't confuse me, but perhaps I'm too clo= se to=20 the code.) > I don't know anything about that code, and I don't think anyone does. > Who will tell us that the comment is still accurate? Since MSVC is no longer relevant, it doesn't matter whether the comment a= bout=20 MSVC is accurate, and we can remove it. > Anything that is conditioned by _MSC_VER can go. I did that by installing the second attached patch into 'master'. This af= fects=20 only the mainline code; I didn't fiddle with the MS-Windows-only files si= nce I=20 can't easily test them. --------------3B112DF735F0C4818F4BDA87 Content-Type: text/x-patch; name="0001-src-lisp.h-GCALIGNED-Clarify-comment-Bug-29040.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-src-lisp.h-GCALIGNED-Clarify-comment-Bug-29040.patch" =46rom a87ce5c4b41ca8146c764b1186a6162c069b1933 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 2 Nov 2017 20:04:25 -0700 Subject: [PATCH] * src/lisp.h (GCALIGNED): Clarify comment (Bug#29040). --- src/lisp.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lisp.h b/src/lisp.h index bf9db59..a71ba22 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -272,8 +272,9 @@ error !; #endif =20 /* Declare an object to have an address that is a multiple of - GCALIGNMENT. alignas is not suitable here, as it fails if the - object's natural alignment exceeds GCALIGNMENT. */ + GCALIGNMENT. This is a no-op if the object's natural alignment is + already a multiple of GCALIGNMENT. alignas is not suitable here, + as it fails if the object's natural alignment exceeds GCALIGNMENT. *= / #ifdef HAVE_STRUCT_ATTRIBUTE_ALIGNED # define GCALIGNED __attribute__ ((aligned (GCALIGNMENT))) #else --=20 2.7.4 --------------3B112DF735F0C4818F4BDA87 Content-Type: text/x-patch; name="0001-Simplify-by-assuming-_MSC_VER.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Simplify-by-assuming-_MSC_VER.patch" =46rom 5b4ff53ab4579532b1b9eba233c135fee274d674 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 2 Nov 2017 21:54:23 -0700 Subject: [PATCH] Simplify by assuming !_MSC_VER. Emacs has not been portable to MSVC for some time (Bug#29040#57). * admin/CPP-DEFINES (_MSC_VER): Remove. * src/lisp.h (ENUM_BF, DEFUN): * src/regex.c (re_char): Simplify by assuming _MSC_VER is not defined. * src/regex.c (const_re_char): Remove. All uses replaced by re_char. --- admin/CPP-DEFINES | 1 - src/lastfile.c | 3 --- src/lisp.h | 16 ++-------------- src/regex.c | 32 +++++++++++++------------------- 4 files changed, 15 insertions(+), 37 deletions(-) diff --git a/admin/CPP-DEFINES b/admin/CPP-DEFINES index 10b558d..eb3eadf 100644 --- a/admin/CPP-DEFINES +++ b/admin/CPP-DEFINES @@ -19,7 +19,6 @@ __DJGPP_MINOR__ Minor version number of the DJGPP libra= ry; used only in msdos.c DOS_NT Compiling for either the MS-DOS or native MS-Windows port. WINDOWSNT Compiling the native MS-Windows (W32) port. __MINGW32__ Compiling the W32 port with the MinGW or MinGW-w64 ports of = GCC. -_MSC_VER Compiling the W32 port with the Microsoft C compiler. MINGW_W64 Compiling the W32 port with the MinGW-w64 port of GCC. DARWIN_OS Compiling on macOS or pure Darwin (and using s/darwin.h). SOLARIS2 diff --git a/src/lastfile.c b/src/lastfile.c index 2901f14..1302279 100644 --- a/src/lastfile.c +++ b/src/lastfile.c @@ -49,9 +49,6 @@ char my_edata[] =3D "End of Emacs initialized data"; isn't always a separate section in NT executables). */ char my_endbss[1]; =20 -/* The Alpha MSVC linker globally segregates all static and public bss - data, so we must take both into account to determine the true extent - of the bss area used by Emacs. */ static char _my_endbss[1]; char * my_endbss_static =3D _my_endbss; =20 diff --git a/src/lisp.h b/src/lisp.h index a71ba22..1a8c3a0 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -418,9 +418,8 @@ error !; #define case_Lisp_Int case Lisp_Int0: case Lisp_Int1 =20 /* Idea stolen from GDB. Pedantic GCC complains about enum bitfields, - MSVC doesn't support them, and xlc and Oracle Studio c99 complain - vociferously about them. */ -#if (defined __STRICT_ANSI__ || defined _MSC_VER || defined __IBMC__ \ + and xlc and Oracle Studio c99 complain vociferously about them. */ +#if (defined __STRICT_ANSI__ || defined __IBMC__ \ || (defined __SUNPRO_C && __STDC__)) #define ENUM_BF(TYPE) unsigned int #else @@ -2935,23 +2934,12 @@ CHECK_NUMBER_CDR (Lisp_Object x) =20 /* This version of DEFUN declares a function prototype with the right arguments, so we can catch errors with maxargs at compile-time. */ -#ifdef _MSC_VER -#define DEFUN(lname, fnname, sname, minargs, maxargs, intspec, doc) \ - Lisp_Object fnname DEFUN_ARGS_ ## maxargs ; \ - static struct Lisp_Subr GCALIGNED sname =3D \ - { { (PVEC_SUBR << PSEUDOVECTOR_AREA_BITS) \ - | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)) }, \ - { (Lisp_Object (__cdecl *)(void))fnname }, = \ - minargs, maxargs, lname, intspec, 0}; \ - Lisp_Object fnname -#else /* not _MSC_VER */ #define DEFUN(lname, fnname, sname, minargs, maxargs, intspec, doc) \ static struct Lisp_Subr GCALIGNED sname =3D \ { { PVEC_SUBR << PSEUDOVECTOR_AREA_BITS }, \ { .a ## maxargs =3D fnname }, \ minargs, maxargs, lname, intspec, 0}; \ Lisp_Object fnname -#endif =20 /* defsubr (Sname); is how we define the symbol for function `name' at start-up time. */= diff --git a/src/regex.c b/src/regex.c index 330f2f7..d3d910d 100644 --- a/src/regex.c +++ b/src/regex.c @@ -519,13 +519,7 @@ ptrdiff_t emacs_re_safe_alloca =3D MAX_ALLOCA; #endif =20 /* Type of source-pattern and string chars. */ -#ifdef _MSC_VER -typedef unsigned char re_char; -typedef const re_char const_re_char; -#else typedef const unsigned char re_char; -typedef re_char const_re_char; -#endif =20 typedef char boolean; =20 @@ -2403,7 +2397,7 @@ do { \ } while (0) =20 static reg_errcode_t -regex_compile (const_re_char *pattern, size_t size, +regex_compile (re_char *pattern, size_t size, #ifdef emacs # define syntax RE_SYNTAX_EMACS bool posix_backtracking, @@ -3728,7 +3722,7 @@ insert_op2 (re_opcode_t op, unsigned char *loc, int= arg1, int arg2, unsigned cha least one character before the ^. */ =20 static boolean -at_begline_loc_p (const_re_char *pattern, const_re_char *p, reg_syntax_t= syntax) +at_begline_loc_p (re_char *pattern, re_char *p, reg_syntax_t syntax) { re_char *prev =3D p - 2; boolean odd_backslashes; @@ -3769,7 +3763,7 @@ at_begline_loc_p (const_re_char *pattern, const_re_= char *p, reg_syntax_t syntax) at least one character after the $, i.e., `P < PEND'. */ =20 static boolean -at_endline_loc_p (const_re_char *p, const_re_char *pend, reg_syntax_t sy= ntax) +at_endline_loc_p (re_char *p, re_char *pend, reg_syntax_t syntax) { re_char *next =3D p; boolean next_backslash =3D *next =3D=3D '\\'; @@ -3813,7 +3807,7 @@ group_in_compile_stack (compile_stack_type compile_= stack, regnum_t regnum) Return -1 if fastmap was not updated accurately. */ =20 static int -analyze_first (const_re_char *p, const_re_char *pend, char *fastmap, +analyze_first (re_char *p, re_char *pend, char *fastmap, const int multibyte) { int j, k; @@ -4555,7 +4549,7 @@ static int bcmp_translate (re_char *s1, re_char *s2= , /* If the operation is a match against one or more chars, return a pointer to the next operation, else return NULL. */ static re_char * -skip_one_char (const_re_char *p) +skip_one_char (re_char *p) { switch (*p++) { @@ -4597,7 +4591,7 @@ skip_one_char (const_re_char *p) =20 /* Jump over non-matching operations. */ static re_char * -skip_noops (const_re_char *p, const_re_char *pend) +skip_noops (re_char *p, re_char *pend) { int mcnt; while (p < pend) @@ -4628,7 +4622,7 @@ skip_noops (const_re_char *p, const_re_char *pend) character (i.e. without any translations). UNIBYTE denotes whether c= is unibyte or multibyte character. */ static bool -execute_charset (const_re_char **pp, unsigned c, unsigned corig, bool un= ibyte) +execute_charset (re_char **pp, unsigned c, unsigned corig, bool unibyte)= { re_char *p =3D *pp, *rtp =3D NULL; bool not =3D (re_opcode_t) *p =3D=3D charset_not; @@ -4692,8 +4686,8 @@ execute_charset (const_re_char **pp, unsigned c, un= signed corig, bool unibyte) =20 /* Non-zero if "p1 matches something" implies "p2 fails". */ static int -mutually_exclusive_p (struct re_pattern_buffer *bufp, const_re_char *p1,= - const_re_char *p2) +mutually_exclusive_p (struct re_pattern_buffer *bufp, re_char *p1, + re_char *p2) { re_opcode_t op2; const boolean multibyte =3D RE_MULTIBYTE_P (bufp); @@ -4931,8 +4925,8 @@ WEAK_ALIAS (__re_match_2, re_match_2) /* This is a separate function so that we can force an alloca cleanup afterwards. */ static regoff_t -re_match_2_internal (struct re_pattern_buffer *bufp, const_re_char *stri= ng1, - size_t size1, const_re_char *string2, size_t size2, +re_match_2_internal (struct re_pattern_buffer *bufp, re_char *string1, + size_t size1, re_char *string2, size_t size2, ssize_t pos, struct re_registers *regs, ssize_t stop) { /* General temporaries. */ @@ -6222,10 +6216,10 @@ re_match_2_internal (struct re_pattern_buffer *bu= fp, const_re_char *string1, bytes; nonzero otherwise. */ =20 static int -bcmp_translate (const_re_char *s1, const_re_char *s2, register ssize_t l= en, +bcmp_translate (re_char *s1, re_char *s2, ssize_t len, RE_TRANSLATE_TYPE translate, const int target_multibyte) { - register re_char *p1 =3D s1, *p2 =3D s2; + re_char *p1 =3D s1, *p2 =3D s2; re_char *p1_end =3D s1 + len; re_char *p2_end =3D s2 + len; =20 --=20 2.7.4 --------------3B112DF735F0C4818F4BDA87-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 04:37:57 2017 Received: (at 29040) by debbugs.gnu.org; 3 Nov 2017 08:37:57 +0000 Received: from localhost ([127.0.0.1]:48644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAXUD-000557-95 for submit@debbugs.gnu.org; Fri, 03 Nov 2017 04:37:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAXUB-00054s-5M for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 04:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAXU1-0007Xx-DZ for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 04:37:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAXU1-0007Xi-9g; Fri, 03 Nov 2017 04:37:45 -0400 Received: from [176.228.60.248] (port=1579 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAXTz-0004NO-JS; Fri, 03 Nov 2017 04:37:44 -0400 Date: Fri, 03 Nov 2017 10:37:41 +0200 Message-Id: <83d14zwyei.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> (message from Paul Eggert on Thu, 2 Nov 2017 22:03:17 -0700) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> <83k1z8wgrw.fsf@gnu.org> <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: rcopley@gmail.com, 29040@debbugs.gnu.org > From: Paul Eggert > Date: Thu, 2 Nov 2017 22:03:17 -0700 > > > I don't know anything about that code, and I don't think anyone does. > > Who will tell us that the comment is still accurate? > > Since MSVC is no longer relevant, it doesn't matter whether the comment about > MSVC is accurate, and we can remove it. Alpha was never relevant for the MS-Windows builds, either, but we still had this code since about forever. But my point was that I'm not sure this isn't needed for the GCC build on Windows. I don't know enough about how GNU ld generates MS-Windows executables to tell whether this could be so. If you feel strongly about getting rid of those 2 lines, I guess it's okay to try that on master. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 04:48:39 2017 Received: (at 29040) by debbugs.gnu.org; 3 Nov 2017 08:48:39 +0000 Received: from localhost ([127.0.0.1]:48663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAXeY-0007Ez-QB for submit@debbugs.gnu.org; Fri, 03 Nov 2017 04:48:38 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAXeX-0007Em-7N for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 04:48:37 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D20AA1600EA; Fri, 3 Nov 2017 01:48:31 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dSRHJ-h1bT0M; Fri, 3 Nov 2017 01:48:31 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 269641605ED; Fri, 3 Nov 2017 01:48:31 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id igUX5wQntYrM; Fri, 3 Nov 2017 01:48:31 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 051D61600EA; Fri, 3 Nov 2017 01:48:31 -0700 (PDT) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> <83k1z8wgrw.fsf@gnu.org> <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> <83d14zwyei.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <0e83d707-b858-60c9-f6f7-359bc94f90be@cs.ucla.edu> Date: Fri, 3 Nov 2017 01:48:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <83d14zwyei.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: rcopley@gmail.com, 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Eli Zaretskii wrote: > If you feel strongly > about getting rid of those 2 lines, I guess it's okay to try that on > master. I don't feel that strongly. I left the code alone, and merely deleted the comment about the Alpha MSVC (which is obsolete and no longer relevant). From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 04:50:51 2017 Received: (at 29040) by debbugs.gnu.org; 3 Nov 2017 08:50:51 +0000 Received: from localhost ([127.0.0.1]:48667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAXgh-0007I7-5E for submit@debbugs.gnu.org; Fri, 03 Nov 2017 04:50:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAXgg-0007Hv-1R for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 04:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAXgX-00074Z-H0 for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 04:50:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAXgX-00074H-B9; Fri, 03 Nov 2017 04:50:41 -0400 Received: from [176.228.60.248] (port=1626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAXgW-0007OI-Gv; Fri, 03 Nov 2017 04:50:40 -0400 Date: Fri, 03 Nov 2017 10:50:38 +0200 Message-Id: <83bmkjwxsx.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> (message from Paul Eggert on Thu, 2 Nov 2017 22:03:17 -0700) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> <83k1z8wgrw.fsf@gnu.org> <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: rcopley@gmail.com, 29040@debbugs.gnu.org > From: Paul Eggert > Date: Thu, 2 Nov 2017 22:03:17 -0700 > > I attempted to clarify this by installing the first attached patch into the > emacs-26 branch. This patch adds a comment to the definition of GCALIGNED. If > the name "GCALIGNED" itself is confusing, we can systematically change the name > to something else. (The name doesn't confuse me, but perhaps I'm too close to > the code.) Seems like this causes trouble to some versions of GCC. Compiling the current master on fencepost.gnu.org with GCC 4.8.4 fails with the following diagnostic: In file included from lisp.h:783:0, from vm-limit.c:21: globals.h:1095:10: error: requested alignment is not an integer constant struct Lisp_Symbol GCALIGNED s; ^ In file included from vm-limit.c:21:0: lisp.h:1149:3: error: requested alignment is not an integer constant }; ^ lisp.h:1262:3: error: requested alignment is not an integer constant }; ^ This GCC identifies itself as $ gcc --version gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 Copyright (C) 2013 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 05:25:27 2017 Received: (at 29040) by debbugs.gnu.org; 3 Nov 2017 09:25:27 +0000 Received: from localhost ([127.0.0.1]:48717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAYEB-00087f-E8 for submit@debbugs.gnu.org; Fri, 03 Nov 2017 05:25:27 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAYE9-00087R-T9 for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 05:25:26 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E90AD1600EA; Fri, 3 Nov 2017 02:25:18 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sAPhXOQZQ7Fh; Fri, 3 Nov 2017 02:25:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 872081605ED; Fri, 3 Nov 2017 02:25:17 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id X1EbS0UauAhH; Fri, 3 Nov 2017 02:25:17 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2D2BB1600EA; Fri, 3 Nov 2017 02:25:17 -0700 (PDT) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file To: Eli Zaretskii References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> <83k1z8wgrw.fsf@gnu.org> <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> <83bmkjwxsx.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <367b0f8e-a575-7230-055e-88594d9ff356@cs.ucla.edu> Date: Fri, 3 Nov 2017 02:25:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <83bmkjwxsx.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------E7C1637ABA18D9353C9E2760" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------E7C1637ABA18D9353C9E2760 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > globals.h:1095:10: error: requested alignment is not an integer constant > struct Lisp_Symbol GCALIGNED s; > ^ Ouch, I had thought that only older MSVC had the problem. Sorry about that. I installed the attached into emacs-26 and merged it to master. --------------E7C1637ABA18D9353C9E2760 Content-Type: text/x-patch; name="0001-Change-GCALIGNMENT-back-to-an-integer-literal.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Change-GCALIGNMENT-back-to-an-integer-literal.patch" >From c911b27aff8dd15cd47a063dc958e6dae74dde06 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 3 Nov 2017 02:20:15 -0700 Subject: [PATCH] Change GCALIGNMENT back to an integer literal * src/lisp.h (GCALIGNMENT): Change it back to a macro that expands to a literal integer constant, for older GCC. I had mistakenly thought that only MSVC had the problem. Problem repored by Eli Zaretskii (Bug#29040#69). --- src/lisp.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lisp.h b/src/lisp.h index a71ba22..4dd4720 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -233,7 +233,9 @@ extern bool suppress_checking EXTERNALLY_VISIBLE; enum Lisp_Bits { - GCALIGNMENT = 1 << GCTYPEBITS, + /* 2**GCTYPEBITS. This must be a macro that expands to a literal + integer constant, for older versions of GCC (through at least 4.9). */ +#define GCALIGNMENT 8 /* Number of bits in a Lisp_Object value, not counting the tag. */ VALBITS = EMACS_INT_WIDTH - GCTYPEBITS, @@ -245,6 +247,10 @@ enum Lisp_Bits FIXNUM_BITS = VALBITS + 1 }; +#if GCALIGNMENT != 1 << GCTYPEBITS +# error "GCALIGNMENT and GCTYPEBITS are inconsistent" +#endif + /* The maximum value that can be stored in a EMACS_INT, assuming all bits other than the type bits contribute to a nonnegative signed value. This can be used in #if, e.g., '#if USE_LSB_TAG' below expands to an -- 2.7.4 --------------E7C1637ABA18D9353C9E2760-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 03 06:03:11 2017 Received: (at 29040) by debbugs.gnu.org; 3 Nov 2017 10:03:11 +0000 Received: from localhost ([127.0.0.1]:48744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAYoe-0000aG-W4 for submit@debbugs.gnu.org; Fri, 03 Nov 2017 06:03:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAYod-0000Zp-PJ for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 06:03:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAYoV-0003ru-Lk for 29040@debbugs.gnu.org; Fri, 03 Nov 2017 06:03:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAYoV-0003rq-JS; Fri, 03 Nov 2017 06:02:59 -0400 Received: from [176.228.60.248] (port=1711 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAYoU-00047C-SV; Fri, 03 Nov 2017 06:02:59 -0400 Date: Fri, 03 Nov 2017 12:02:57 +0200 Message-Id: <83shdvvfvy.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <367b0f8e-a575-7230-055e-88594d9ff356@cs.ucla.edu> (message from Paul Eggert on Fri, 3 Nov 2017 02:25:17 -0700) Subject: Re: bug#29040: Emacs 25 hangs on windows arbitrarily during search of a unicode file References: <83wp38r87q.fsf@gnu.org> <136c8415-5027-e149-b8b1-5b08da5815f3@cs.ucla.edu> <83k1z8wgrw.fsf@gnu.org> <8d805311-7837-681b-55c0-32e61c8a3b60@cs.ucla.edu> <83bmkjwxsx.fsf@gnu.org> <367b0f8e-a575-7230-055e-88594d9ff356@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29040 Cc: 29040@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 29040@debbugs.gnu.org > From: Paul Eggert > Date: Fri, 3 Nov 2017 02:25:17 -0700 > > Eli Zaretskii wrote: > > globals.h:1095:10: error: requested alignment is not an integer constant > > struct Lisp_Symbol GCALIGNED s; > > ^ > > > Ouch, I had thought that only older MSVC had the problem. Sorry about that. I > installed the attached into emacs-26 and merged it to master. Thanks, this fixed the build on fencepost. From unknown Wed Jun 25 09:10:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator