GNU bug report logs - #29039
`iter-do' doesn't instrument its body

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Subject: bug#29039: closed (Re: bug#29039: `iter-do' doesn't instrument
 its body)
Date: Fri, 03 Nov 2017 13:53:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29039: `iter-do' doesn't instrument its body

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29039 <at> debbugs.gnu.org.

-- 
29039: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29039
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Pogonyshev <pogonyshev <at> gmail.com>
Cc: 29039-done <at> debbugs.gnu.org
Subject: Re: bug#29039: `iter-do' doesn't instrument its body
Date: Fri, 03 Nov 2017 15:51:51 +0200

> From: Paul Pogonyshev <pogonyshev <at> gmail.com>
> Date: Sat, 28 Oct 2017 14:48:14 +0200
> Cc: 29039 <at> debbugs.gnu.org
> 
> Because it allows debugging generator functions with `iter2' package.
> `iter2' replaces only `iter-defun' and `iter-lambda', but uses all the
> rest of infrastructure (`iter-yield', `iter-next', `iter-do' and so
> on).
> 
> I'm 100% sure this change cannot break anything in `generator' and is
> logical in itself.

Thanks, pushed.

[Message part 3 (message/rfc822, inline)]

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: `iter-do' doesn't instrument its body
Date: Sat, 28 Oct 2017 13:07:00 +0200

[Message part 4 (text/plain, inline)]

Attached trivial patch simply adds `(declare (debug ...))' to the
macro. I believe it is perfectly safe and trivial, no mention in NEWS
etc. is needed. I would ask to merge it to branch 26 if possible.

Note that it doesn't quite let you debug generators anyway because of
bug #28725, but the change makes sense regardless. In particular, with
`iter2' package you should be able to debug generator functions called
from `iter-do'.

Paul

[0001-Add-missing-debug-declaration-to-iter-do.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.