From unknown Wed Jun 25 03:53:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29039: `iter-do' doesn't instrument its body Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2017 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29039@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150918883419676 (code B ref -1); Sat, 28 Oct 2017 11:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Oct 2017 11:07:14 +0000 Received: from localhost ([127.0.0.1]:38095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8OxN-00057I-Ul for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8OxK-000571-DN for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8OxE-0001zK-CE for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e8OxE-0001zC-8L for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8OxD-0002cl-84 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 07:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8OxC-0001y0-DR for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 07:07:03 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:48774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8OxC-0001xN-62 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 07:07:02 -0400 Received: by mail-pg0-x241.google.com with SMTP id v78so7272078pgb.5 for ; Sat, 28 Oct 2017 04:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=WXqoucm8GlS+iC2ZTkz7bGHhHysWmGsQ1Qw0KjiX1e0=; b=sHrBmXQxqAC5e7s+xRU8al+Kxo5/2GJkE9YneiJ0lCzDiuSloWPbtmJlmfymcKxtup swXXKLnsYEtQrRq4ENOmjt+1J1AOc8GAkUwmhaNR9PrKVGMPZPn+mER/nFWzQCRBk/0U dkTb6JCXHhNrM8p/LKjjUf3bvfaZUz4ZjiogscypH8c28Z1xMuPT28M+iatDtmzJhicc QKohi0OgDwVADpcU5GDGeRCDNk8qSyxX2oD6bCudspjEEGVrRgPvpYNEDxyUB1AwGwms Kykj68En1Yb5EHWUl1pEi0nv+hdeDd66DwI5oSzzPRd1MFaoxiI/ZlPzS6GTQ8HdDK6R R7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WXqoucm8GlS+iC2ZTkz7bGHhHysWmGsQ1Qw0KjiX1e0=; b=dsaqeTnb8bvea7dxIhAXtrb+tiZEpvxpOsd6qPQtaLeQomY2sEQ+hzHrBrwhFU82HB QTOBI5cS+RY6sj8NzKG3rE8f8ntbTk+v1ESpIP+aGclbpbk3O+La1yajzJUcxesCKbPJ o2gogn7Rfx29ZIsiC6pzF3SwljXv/jtpvNpcJEFyPlCC9Za7B17RYQFKWz2qcwGvu9vl kXbukCkZExJ/NX+rYhPhnzeNYLnM7vED7ZR+jGZd3fFLIJiirqOwWJiQXp5hA+OFX/PS ueqL+NRl18+rDWFW/KvvA6yRNgHLsTrPAczNoiroRSdHR8ES2e0qpyLOSfTweOaViOFg ZqUA== X-Gm-Message-State: AMCzsaW2M4lrfJozIN2a/pJ+bwXj0Wgm756TNH3cTyw23sJe9HYuD7sw RMf7P5G5ZqG2oJEhn6is/56J1MWCM0YuEmROfhuK X-Google-Smtp-Source: ABhQp+T56pSSrG5H7rxG4xm2T1o/TjUZsSEoBftPbAjn/n2qm8PHHwv/7UiHWgdKRWz7YaxYANVNhcj5zpCakjo2Z6w= X-Received: by 10.98.14.195 with SMTP id 64mr3139576pfo.197.1509188820685; Sat, 28 Oct 2017 04:07:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.162.238 with HTTP; Sat, 28 Oct 2017 04:07:00 -0700 (PDT) From: Paul Pogonyshev Date: Sat, 28 Oct 2017 13:07:00 +0200 Message-ID: Content-Type: multipart/mixed; boundary="001a1145904e8e6ea8055c996731" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1145904e8e6ea8055c996731 Content-Type: text/plain; charset="UTF-8" Attached trivial patch simply adds `(declare (debug ...))' to the macro. I believe it is perfectly safe and trivial, no mention in NEWS etc. is needed. I would ask to merge it to branch 26 if possible. Note that it doesn't quite let you debug generators anyway because of bug #28725, but the change makes sense regardless. In particular, with `iter2' package you should be able to debug generator functions called from `iter-do'. Paul --001a1145904e8e6ea8055c996731 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-missing-debug-declaration-to-iter-do.patch" Content-Disposition: attachment; filename="0001-Add-missing-debug-declaration-to-iter-do.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j9b80gff0 RnJvbSA0MGM2MjU2ZWI3Yjc0Y2FkZWZlNjVmMjNjYjZiNzkzMzZlNWIwNmMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIFBvZ29ueXNoZXYgPHBvZ29ueXNoZXZAZ21haWwuY29t PgpEYXRlOiBTYXQsIDI4IE9jdCAyMDE3IDEzOjAxOjUxICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIG1pc3NpbmcgZGVidWcgZGVjbGFyYXRpb24gdG8gYGl0ZXItZG8nCgotLS0KIGxpc3AvZW1h Y3MtbGlzcC9nZW5lcmF0b3IuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9nZW5lcmF0 b3IuZWwgYi9saXNwL2VtYWNzLWxpc3AvZ2VuZXJhdG9yLmVsCmluZGV4IDQxMGU0ZWRjYzkuLmVm NmNmYmE0MjAgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9nZW5lcmF0b3IuZWwKKysrIGIv bGlzcC9lbWFjcy1saXNwL2dlbmVyYXRvci5lbApAQCAtNzE4LDcgKzcxOCw4IEBAIGl0ZXItY2xv c2UKICAgIkxvb3Agb3ZlciB2YWx1ZXMgZnJvbSBhbiBpdGVyYXRvci4KIEV2YWx1YXRlIEJPRFkg d2l0aCBWQVIgYm91bmQgdG8gZWFjaCB2YWx1ZSBmcm9tIElURVJBVE9SLgogUmV0dXJuIHRoZSB2 YWx1ZSB3aXRoIHdoaWNoIElURVJBVE9SIGZpbmlzaGVkIGl0ZXJhdGlvbi4iCi0gIChkZWNsYXJl IChpbmRlbnQgMSkpCisgIChkZWNsYXJlIChpbmRlbnQgMSkKKyAgICAgICAgICAgKGRlYnVnICgo c3ltYm9scCBmb3JtKSBib2R5KSkpCiAgIChsZXQgKChkb25lLXN5bWJvbCAoY3BzLS1nZW5zeW0g Iml0ZXItZG8taXRlcmF0b3ItZG9uZSIpKQogICAgICAgICAoY29uZGl0aW9uLXN5bWJvbCAoY3Bz LS1nZW5zeW0gIml0ZXItZG8tY29uZGl0aW9uIikpCiAgICAgICAgIChpdC1zeW1ib2wgKGNwcy0t Z2Vuc3ltICJpdGVyLWRvLWl0ZXJhdG9yIikpCi0tIAoyLjE0LjIKCg== --001a1145904e8e6ea8055c996731-- From unknown Wed Jun 25 03:53:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29039: `iter-do' doesn't instrument its body Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2017 11:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Pogonyshev Cc: 29039@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29039-submit@debbugs.gnu.org id=B29039.150919035529315 (code B ref 29039); Sat, 28 Oct 2017 11:33:02 +0000 Received: (at 29039) by debbugs.gnu.org; 28 Oct 2017 11:32:35 +0000 Received: from localhost ([127.0.0.1]:38106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8PLv-0007cl-8a for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:32:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8PLu-0007cZ-Eh for 29039@debbugs.gnu.org; Sat, 28 Oct 2017 07:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8PLm-00075E-7G for 29039@debbugs.gnu.org; Sat, 28 Oct 2017 07:32:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8PLm-00075A-48; Sat, 28 Oct 2017 07:32:26 -0400 Received: from [176.228.60.248] (port=4587 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e8PLl-0001Xg-Hh; Sat, 28 Oct 2017 07:32:25 -0400 Date: Sat, 28 Oct 2017 14:32:21 +0300 Message-Id: <83lgjv5wze.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Paul Pogonyshev on Sat, 28 Oct 2017 13:07:00 +0200) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Pogonyshev > Date: Sat, 28 Oct 2017 13:07:00 +0200 > > Attached trivial patch simply adds `(declare (debug ...))' to the > macro. I believe it is perfectly safe and trivial, no mention in NEWS > etc. is needed. I would ask to merge it to branch 26 if possible. Why do you want it on the emacs-26 branch? Thanks. From unknown Wed Jun 25 03:53:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29039: `iter-do' doesn't instrument its body Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2017 12:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 29039@debbugs.gnu.org Received: via spool by 29039-submit@debbugs.gnu.org id=B29039.15091949033973 (code B ref 29039); Sat, 28 Oct 2017 12:49:01 +0000 Received: (at 29039) by debbugs.gnu.org; 28 Oct 2017 12:48:23 +0000 Received: from localhost ([127.0.0.1]:38132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8QXG-000121-N4 for submit@debbugs.gnu.org; Sat, 28 Oct 2017 08:48:22 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:53456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8QXF-00011n-5u for 29039@debbugs.gnu.org; Sat, 28 Oct 2017 08:48:21 -0400 Received: by mail-pf0-f177.google.com with SMTP id t188so6946366pfd.10 for <29039@debbugs.gnu.org>; Sat, 28 Oct 2017 05:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+pzWHaFGB+JzJyNS/IGGGNh9lHzSSnWcG5/7ra0D9gQ=; b=Qw9dylpJsSwCZxL8e9gft+r+dwuncm4ZI4SK6U+pVdkTpgj8krVVM3x0QHFR0lQcfr WezuI44swpWjOz5qsnmtAA99I8V0Z/JYw6tQifUE3xmnavwZYFbnmyYaMAdyZxcYXIzT xH0zCMw2qV0qjPzHccWKUjH7DHHdoNYq4r6iXGCkXCfM/VG7obKWfKpA0FS+A2lXq+PG e3+eSqDTiDJzVIo2eGSFu4mXXUQfDXxqvuqPFch3wgWs6DeFu3QbiNyjEZcqbANeO7Tc c+qmoi6PpqgPlvUvCRaJEiNZos4WvzYvQe1v7POhAYvFbrOgPbMapi2Us4G9Ekgseocf o2Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+pzWHaFGB+JzJyNS/IGGGNh9lHzSSnWcG5/7ra0D9gQ=; b=CPrYRqKRAWdKsJ996oqMjS+tNsVCqzK69iHX5tWiARTTFg17OUyEOZSieZdp//Oywt +KoCW//UC9vwDlPTipRI5ElGO7R7aLe+IP9Do51nPz8ChqkE9bYAtPhVSYGJl21YuEt4 ndxsGR/FTANB5rRGKvE9tMFhv+/MrRTR4ybMMKLBFxAzS6xMDozJoEAniaK2XapMhKo7 7kDNMHDfJZh9iyEe5rY0Sl19pWxHRWt6EEt78UeNdmeqBL0pCeGst2qGJlo+DunVs1bU hk6wn66v3ykrMwh3IC5EbGKe1KJGErUvlY405e23nRA4MhivVglNGzGrHapkkI6VehN2 THCQ== X-Gm-Message-State: AMCzsaV5iUfgd06bTvugfpeG/tkk59sRE50jnqkDCNo1BD7p1RHp/g/M sPAMzy06e2dGrL5dAsptjl61kVMD41bV4foF6g== X-Google-Smtp-Source: ABhQp+QIz4HhBNnbyXBBzwwQvPS2E5FjPFiRqID8k49RvzYXpZ4NFyX70YlyaOEmuOCPePCNv3F8jaB7MrHWlAmlYsM= X-Received: by 10.84.169.1 with SMTP id g1mr2863837plb.349.1509194894782; Sat, 28 Oct 2017 05:48:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.162.238 with HTTP; Sat, 28 Oct 2017 05:48:14 -0700 (PDT) In-Reply-To: <83lgjv5wze.fsf@gnu.org> References: <83lgjv5wze.fsf@gnu.org> From: Paul Pogonyshev Date: Sat, 28 Oct 2017 14:48:14 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Because it allows debugging generator functions with `iter2' package. `iter2' replaces only `iter-defun' and `iter-lambda', but uses all the rest of infrastructure (`iter-yield', `iter-next', `iter-do' and so on). I'm 100% sure this change cannot break anything in `generator' and is logical in itself. Paul On 28 October 2017 at 13:32, Eli Zaretskii wrote: >> From: Paul Pogonyshev >> Date: Sat, 28 Oct 2017 13:07:00 +0200 >> >> Attached trivial patch simply adds `(declare (debug ...))' to the >> macro. I believe it is perfectly safe and trivial, no mention in NEWS >> etc. is needed. I would ask to merge it to branch 26 if possible. > > Why do you want it on the emacs-26 branch? > > Thanks. From unknown Wed Jun 25 03:53:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Pogonyshev Subject: bug#29039: closed (Re: bug#29039: `iter-do' doesn't instrument its body) Message-ID: References: <83k1z7v5ag.fsf@gnu.org> X-Gnu-PR-Message: they-closed 29039 X-Gnu-PR-Package: emacs Reply-To: 29039@debbugs.gnu.org Date: Fri, 03 Nov 2017 13:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1509717182-6229-1" This is a multi-part message in MIME format... ------------=_1509717182-6229-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29039: `iter-do' doesn't instrument its body which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29039@debbugs.gnu.org. --=20 29039: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29039 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1509717182-6229-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29039-done) by debbugs.gnu.org; 3 Nov 2017 13:52:04 +0000 Received: from localhost ([127.0.0.1]:48905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcOC-0001bC-IE for submit@debbugs.gnu.org; Fri, 03 Nov 2017 09:52:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAcOB-0001ah-1r for 29039-done@debbugs.gnu.org; Fri, 03 Nov 2017 09:52:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eAcO2-0003YT-UX for 29039-done@debbugs.gnu.org; Fri, 03 Nov 2017 09:51:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eAcO2-0003YH-R7; Fri, 03 Nov 2017 09:51:54 -0400 Received: from [176.228.60.248] (port=2073 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eAcO2-00054K-4Z; Fri, 03 Nov 2017 09:51:54 -0400 Date: Fri, 03 Nov 2017 15:51:51 +0200 Message-Id: <83k1z7v5ag.fsf@gnu.org> From: Eli Zaretskii To: Paul Pogonyshev In-reply-to: (message from Paul Pogonyshev on Sat, 28 Oct 2017 14:48:14 +0200) Subject: Re: bug#29039: `iter-do' doesn't instrument its body References: <83lgjv5wze.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29039-done Cc: 29039-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Pogonyshev > Date: Sat, 28 Oct 2017 14:48:14 +0200 > Cc: 29039@debbugs.gnu.org > > Because it allows debugging generator functions with `iter2' package. > `iter2' replaces only `iter-defun' and `iter-lambda', but uses all the > rest of infrastructure (`iter-yield', `iter-next', `iter-do' and so > on). > > I'm 100% sure this change cannot break anything in `generator' and is > logical in itself. Thanks, pushed. ------------=_1509717182-6229-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Oct 2017 11:07:14 +0000 Received: from localhost ([127.0.0.1]:38095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8OxN-00057I-Ul for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8OxK-000571-DN for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8OxE-0001zK-CE for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e8OxE-0001zC-8L for submit@debbugs.gnu.org; Sat, 28 Oct 2017 07:07:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8OxD-0002cl-84 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 07:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8OxC-0001y0-DR for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 07:07:03 -0400 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:48774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8OxC-0001xN-62 for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2017 07:07:02 -0400 Received: by mail-pg0-x241.google.com with SMTP id v78so7272078pgb.5 for ; Sat, 28 Oct 2017 04:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=WXqoucm8GlS+iC2ZTkz7bGHhHysWmGsQ1Qw0KjiX1e0=; b=sHrBmXQxqAC5e7s+xRU8al+Kxo5/2GJkE9YneiJ0lCzDiuSloWPbtmJlmfymcKxtup swXXKLnsYEtQrRq4ENOmjt+1J1AOc8GAkUwmhaNR9PrKVGMPZPn+mER/nFWzQCRBk/0U dkTb6JCXHhNrM8p/LKjjUf3bvfaZUz4ZjiogscypH8c28Z1xMuPT28M+iatDtmzJhicc QKohi0OgDwVADpcU5GDGeRCDNk8qSyxX2oD6bCudspjEEGVrRgPvpYNEDxyUB1AwGwms Kykj68En1Yb5EHWUl1pEi0nv+hdeDd66DwI5oSzzPRd1MFaoxiI/ZlPzS6GTQ8HdDK6R R7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WXqoucm8GlS+iC2ZTkz7bGHhHysWmGsQ1Qw0KjiX1e0=; b=dsaqeTnb8bvea7dxIhAXtrb+tiZEpvxpOsd6qPQtaLeQomY2sEQ+hzHrBrwhFU82HB QTOBI5cS+RY6sj8NzKG3rE8f8ntbTk+v1ESpIP+aGclbpbk3O+La1yajzJUcxesCKbPJ o2gogn7Rfx29ZIsiC6pzF3SwljXv/jtpvNpcJEFyPlCC9Za7B17RYQFKWz2qcwGvu9vl kXbukCkZExJ/NX+rYhPhnzeNYLnM7vED7ZR+jGZd3fFLIJiirqOwWJiQXp5hA+OFX/PS ueqL+NRl18+rDWFW/KvvA6yRNgHLsTrPAczNoiroRSdHR8ES2e0qpyLOSfTweOaViOFg ZqUA== X-Gm-Message-State: AMCzsaW2M4lrfJozIN2a/pJ+bwXj0Wgm756TNH3cTyw23sJe9HYuD7sw RMf7P5G5ZqG2oJEhn6is/56J1MWCM0YuEmROfhuK X-Google-Smtp-Source: ABhQp+T56pSSrG5H7rxG4xm2T1o/TjUZsSEoBftPbAjn/n2qm8PHHwv/7UiHWgdKRWz7YaxYANVNhcj5zpCakjo2Z6w= X-Received: by 10.98.14.195 with SMTP id 64mr3139576pfo.197.1509188820685; Sat, 28 Oct 2017 04:07:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.162.238 with HTTP; Sat, 28 Oct 2017 04:07:00 -0700 (PDT) From: Paul Pogonyshev Date: Sat, 28 Oct 2017 13:07:00 +0200 Message-ID: Subject: `iter-do' doesn't instrument its body To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="001a1145904e8e6ea8055c996731" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1145904e8e6ea8055c996731 Content-Type: text/plain; charset="UTF-8" Attached trivial patch simply adds `(declare (debug ...))' to the macro. I believe it is perfectly safe and trivial, no mention in NEWS etc. is needed. I would ask to merge it to branch 26 if possible. Note that it doesn't quite let you debug generators anyway because of bug #28725, but the change makes sense regardless. In particular, with `iter2' package you should be able to debug generator functions called from `iter-do'. Paul --001a1145904e8e6ea8055c996731 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-missing-debug-declaration-to-iter-do.patch" Content-Disposition: attachment; filename="0001-Add-missing-debug-declaration-to-iter-do.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j9b80gff0 RnJvbSA0MGM2MjU2ZWI3Yjc0Y2FkZWZlNjVmMjNjYjZiNzkzMzZlNWIwNmMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIFBvZ29ueXNoZXYgPHBvZ29ueXNoZXZAZ21haWwuY29t PgpEYXRlOiBTYXQsIDI4IE9jdCAyMDE3IDEzOjAxOjUxICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIG1pc3NpbmcgZGVidWcgZGVjbGFyYXRpb24gdG8gYGl0ZXItZG8nCgotLS0KIGxpc3AvZW1h Y3MtbGlzcC9nZW5lcmF0b3IuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9nZW5lcmF0 b3IuZWwgYi9saXNwL2VtYWNzLWxpc3AvZ2VuZXJhdG9yLmVsCmluZGV4IDQxMGU0ZWRjYzkuLmVm NmNmYmE0MjAgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9nZW5lcmF0b3IuZWwKKysrIGIv bGlzcC9lbWFjcy1saXNwL2dlbmVyYXRvci5lbApAQCAtNzE4LDcgKzcxOCw4IEBAIGl0ZXItY2xv c2UKICAgIkxvb3Agb3ZlciB2YWx1ZXMgZnJvbSBhbiBpdGVyYXRvci4KIEV2YWx1YXRlIEJPRFkg d2l0aCBWQVIgYm91bmQgdG8gZWFjaCB2YWx1ZSBmcm9tIElURVJBVE9SLgogUmV0dXJuIHRoZSB2 YWx1ZSB3aXRoIHdoaWNoIElURVJBVE9SIGZpbmlzaGVkIGl0ZXJhdGlvbi4iCi0gIChkZWNsYXJl IChpbmRlbnQgMSkpCisgIChkZWNsYXJlIChpbmRlbnQgMSkKKyAgICAgICAgICAgKGRlYnVnICgo c3ltYm9scCBmb3JtKSBib2R5KSkpCiAgIChsZXQgKChkb25lLXN5bWJvbCAoY3BzLS1nZW5zeW0g Iml0ZXItZG8taXRlcmF0b3ItZG9uZSIpKQogICAgICAgICAoY29uZGl0aW9uLXN5bWJvbCAoY3Bz LS1nZW5zeW0gIml0ZXItZG8tY29uZGl0aW9uIikpCiAgICAgICAgIChpdC1zeW1ib2wgKGNwcy0t Z2Vuc3ltICJpdGVyLWRvLWl0ZXJhdG9yIikpCi0tIAoyLjE0LjIKCg== --001a1145904e8e6ea8055c996731-- ------------=_1509717182-6229-1--