GNU bug report logs - #29038
df hangs on fifos/named pipes

Previous Next

Full log

Message #11 received at 29038 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigbrady.com>
Cc: 29038 <at> debbugs.gnu.org, Martijn Dekker <martijn <at> inlv.org>,
 Stephane Chazelas <stephane.chazelas <at> gmail.com>
Subject: Re: bug#29038: df hangs on fifos/named pipes
Date: Sun, 29 Oct 2017 16:21:52 -0700

On Sun, Oct 29, 2017 at 3:34 PM, Pádraig Brady <P <at> draigbrady.com> wrote:
...
>> That was discovered by Martijn Dekker, CCed, when looking for a
>> portable way to identify the file system of an arbitrary file.
>
> Yes we shouldn't hang.
>
> RE side effects, open() is a fairly innocuous operation,
> and we expect stat() to have side effects to auto mount.
> (Note we avoid stat() with non specified arguments if possible due to this):
> https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.27-92-ga19ff5d
>
> I suppose we could stat() and if that succeeds && !fifo, only then call open() ?
> Patch to do that is attached.

Sounds good. Patch looks fine to me. Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.