From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 27 16:40:58 2017 Received: (at submit) by debbugs.gnu.org; 27 Oct 2017 20:40:58 +0000 Received: from localhost ([127.0.0.1]:37700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8BQw-0000Mc-J1 for submit@debbugs.gnu.org; Fri, 27 Oct 2017 16:40:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8BQt-0000MO-Sw for submit@debbugs.gnu.org; Fri, 27 Oct 2017 16:40:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8BQn-0000zd-6k for submit@debbugs.gnu.org; Fri, 27 Oct 2017 16:40:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e8BQn-0000zU-3D for submit@debbugs.gnu.org; Fri, 27 Oct 2017 16:40:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8BQl-0001eu-BH for guix-patches@gnu.org; Fri, 27 Oct 2017 16:40:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8BQh-0000qD-Uj for guix-patches@gnu.org; Fri, 27 Oct 2017 16:40:39 -0400 Received: from esa1.cray.iphmx.com ([68.232.142.33]:25235) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1e8BQR-0000Kf-56 for guix-patches@gnu.org; Fri, 27 Oct 2017 16:40:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cray.com; i=@cray.com; q=dns/txt; s=cray1024; t=1509137633; x=1540673633; h=from:to:subject:date:message-id:mime-version; bh=VB2yAN4JLv1KPlOrVcX8THSZJUJoY8QAe8NfgtiILZg=; b=Jh/hadx+NRtxyMvMgGwDbLpuLZ6t5XQjCOTx0qaZHpm5UDvGw7Ls/oh9 eyQT89TcpXw/lPtQXYLX9VysxsHsbDLnPn/OzNGVKTk7g6I7M9Y+Yc9vM IcOHM1Wbgs1JsN5fYYLekpK0/AO4wYNLt7RJYGfS7tA8Gu1dqXFLqjcqf M=; X-IronPort-AV: E=Sophos;i="5.44,305,1505775600"; d="scan'208";a="15968815" X-Cray-OBMMKR: 1433258124 15968815 Received: from cray-smtp-2.cray.com (HELO CFWEX01.americas.cray.com) ([136.162.34.11]) by esa1.cray.iphmx.com with ESMTP/TLS/AES256-SHA; 27 Oct 2017 21:53:47 +0100 Received: from CFWEXHYBRID.americas.cray.com (172.30.88.178) by CFWEX01.americas.cray.com (172.30.88.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 27 Oct 2017 15:40:15 -0500 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (216.32.180.19) by mail.cray.com (172.30.88.178) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 27 Oct 2017 15:40:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crayinc.onmicrosoft.com; s=selector1-cray-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4j/xxMN0iQ9DY0iTdGulwPEom/NcVv9QgFTkQ+zuPsg=; b=tH924amC2MVgax7qJQFnt36mwn3w2QQ/iARhhjtCJIjFWSyFOjGNi1EqdLUwS2EvFnHFUzvqmXNCJpcvMfstJJHoK/h5IdSrMeqTb0MUdeiBy3ue+V7HjWX4/5iBNvNpHy+wBcAKUXgDQlGubGFluT26YJwmr6uX13oib+/+SsU= Received: from CY4PR11MB1718.namprd11.prod.outlook.com (10.169.255.151) by CY4PR11MB1719.namprd11.prod.outlook.com (10.173.16.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Fri, 27 Oct 2017 20:40:12 +0000 Received: from CY4PR11MB1718.namprd11.prod.outlook.com ([10.169.255.151]) by CY4PR11MB1718.namprd11.prod.outlook.com ([10.169.255.151]) with mapi id 15.20.0178.007; Fri, 27 Oct 2017 20:40:12 +0000 From: Eric Bavier To: "guix-patches@gnu.org" Subject: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO. Thread-Topic: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO. Thread-Index: AQHTT2NO3Ako+4mkb0uT7Xeo7mDrpA== Date: Fri, 27 Oct 2017 20:40:12 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=bavier@cray.com; x-originating-ip: [136.162.2.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR11MB1719; 6:5GZpN+eWmp2kn4WPuDaYvxrdnDBn6Y6H3uPyEqPIwsoTbFf2C+DaJYRfV/VUe9h3xYNiSqmREA9BuYiT/eL0fAOvZe36Eix+jjY3myWK1a2UhSs1Ymkjl9QsNiTFZ1/yO2naNdIswGhri3ZCdQnhqEVaHe0+iFW8jqFbGBoMp1XKcLmWghgOWMJnyBJoEaFGR4L+KKsvUY/TDDRimehvKOzs1+7pVumebR8wjMbg4OQ+uLRHe4xEHZelUoIB8DQYTNUVeHxxh42t3xaCpRr1as30dVkvHp9hutrao6NdsHxGCYLaGKyYMpom7KB0M4vKe6pZYKVTkGUW1lzQM2nxJy27x11xyGNSKf44FDDhgFI=; 5:v/spyEfRrtFTDQbueT6V/7GVtB5FzuOTIVNSHJ4bm0v35/eVd49z4tbaK9u80vlxJ1eRryThuA5QXzZy6lRsq05gl35If89zLUqByLoVpfHQFL/TT3+ns7zG/6plIXfUh5jkTBSNbbVD0/E439iGhRDktfU7u0t3ZuRXIj0jYes=; 24:ZzzvfauTF+cAumJDQ1iBqnsuBQ82Bls32lkB8AVzIGBHmX+D4o7Ht8VVHJXlSBuWDtIRp4/QRqUmtTs0ZJ0ZQwfCVxZVwoU58eA5qiLzYbQ=; 7:vOLC3tWmSBVjGHrD2ANh5M1iiwbdzpP6x+6UTkNGmPFgu+ao4SDh6dmOrKczFAPBrdPSO5wR2wg06yU69LXiFqslXfxYUAoUwvCGpVnttNdEtyFcQVq702JPdJ0QEFv7M6wQjMes62H78hwaUA7jXA85jwnHIy9FDGujfLe1cLZcGW6emgDKcDxnq4CxhUzKQ9kXgzDzN/Bbyo8V+KmFXkbeoMG7E7SHiZPGH4t1+6mh+ngOyLM5iRNXC1ZF/5Zb x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 6ad0b777-2957-410a-8444-08d51d7aebe0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603199)(49563074); SRVR:CY4PR11MB1719; x-ms-traffictypediagnostic: CY4PR11MB1719: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231020)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR11MB1719; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR11MB1719; x-forefront-prvs: 0473A03F3F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(376002)(346002)(189002)(199003)(99286003)(50986999)(230783001)(25786009)(9686003)(5660300001)(5640700003)(3660700001)(53936002)(55016002)(101416001)(14454004)(54356999)(97736004)(316002)(2900100001)(99936001)(86362001)(106356001)(105586002)(2351001)(2501003)(8936002)(305945005)(68736007)(81166006)(33656002)(77096006)(7696004)(2906002)(6506006)(74316002)(6916009)(478600001)(102836003)(7736002)(189998001)(8676002)(3280700002)(3846002)(6116002)(6436002)(66066001)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR11MB1719; H:CY4PR11MB1718.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_CY4PR11MB1718DEC796149A5DE28DC5F1B75A0CY4PR11MB1718namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6ad0b777-2957-410a-8444-08d51d7aebe0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2017 20:40:12.1962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e7b8488a-c0cd-4614-aae1-996bfabec247 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1719 X-OriginatorOrg: cray.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --_002_CY4PR11MB1718DEC796149A5DE28DC5F1B75A0CY4PR11MB1718namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello Guix, On my system, perl-sys-cpu's tests fail because of differences in the infor= mation available in /proc/cpuinfo. Debian's patch for this perl module seemed nice: rather than trying to fix = the related functions, just concede that the module is mostly used just to = read the number of available processors and mark the other tests as "TODO". This patch replaces the test file with debian's using an origin snippet. Eric Bavier, Scientific Libraries, Cray Inc. --_002_CY4PR11MB1718DEC796149A5DE28DC5F1B75A0CY4PR11MB1718namp_ Content-Type: text/x-patch; name="guix-perl-sys-cpu-tests.patch" Content-Description: guix-perl-sys-cpu-tests.patch Content-Disposition: attachment; filename="guix-perl-sys-cpu-tests.patch"; size=2040; creation-date="Fri, 27 Oct 2017 20:40:06 GMT"; modification-date="Fri, 27 Oct 2017 20:40:06 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9wZXJsLnNjbSBiL2dudS9wYWNrYWdlcy9wZXJsLnNj bQppbmRleCA4MTVhMjEyLi43ZDFmZGE3IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvcGVybC5z Y20KKysrIGIvZ251L3BhY2thZ2VzL3Blcmwuc2NtCkBAIC0yLDcgKzIsNyBAQAogOzs7IENvcHly aWdodCDCqSAyMDEyLCAyMDEzLCAyMDE0LCAyMDE1LCAyMDE2LCAyMDE3IEx1ZG92aWMgQ291cnTD qHMgPGx1ZG9AZ251Lm9yZz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxMyBBbmRyZWFzIEVuZ2UgPGFu ZHJlYXNAZW5nZS5mcj4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSwgMjAxNiwgMjAxNyBSaWNhcmRv IFd1cm11cyA8cmVrYWRvQGVsZXBobHkubmV0PgotOzs7IENvcHlyaWdodCDCqSAyMDE1LCAyMDE2 IEVyaWMgQmF2aWVyIDxiYXZpZXJAbWVtYmVyLmZzZi5vcmc+Cis7OzsgQ29weXJpZ2h0IMKpIDIw MTUsIDIwMTYsIDIwMTcgRXJpYyBCYXZpZXIgPGJhdmllckBtZW1iZXIuZnNmLm9yZz4KIDs7OyBD b3B5cmlnaHQgwqkgMjAxNSBFcmljIER2b3JzYWsgPGVyaWNAZHZvcnNhay5mcj4KIDs7OyBDb3B5 cmlnaHQgwqkgMjAxNiBNYXJrIEggV2VhdmVyIDxtaHdAbmV0cmlzLm9yZz4KIDs7OyBDb3B5cmln aHQgwqkgMjAxNiBKb2NoZW0gUmFhdCA8amNobXJ0QHJpc2V1cC5uZXQ+CkBAIC02NjY1LDcgKzY2 NjUsMzQgQEAgc3RhdGVtZW50czogQGNvZGV7c3dpdGNofSBhbmQgQGNvZGV7Y2FzZX0uIikKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiU3lzLUNQVS0iIHZlcnNpb24gIi50YXIu Z3oiKSkKICAgICAgICAgICAgICAgKHNoYTI1NgogICAgICAgICAgICAgICAgKGJhc2UzMgotICAg ICAgICAgICAgICAgICIxcjY5NzZiczg2ajd6cDUxbTV2aDQyeGx5YWg5NTFqZ2Rsa2ltdjIwMjQx M2tqdnFjMmk1IikpKSkKKyAgICAgICAgICAgICAgICAiMXI2OTc2YnM4Nmo3enA1MW01dmg0Mnhs eWFoOTUxamdkbGtpbXYyMDI0MTNranZxYzJpNSIpKQorICAgICAgICAgICAgICAobW9kdWxlcyAn KChndWl4IGJ1aWxkIHV0aWxzKSkpCisgICAgICAgICAgICAgIChzbmlwcGV0CisgICAgICAgICAg ICAgICAnKGJlZ2luCisgICAgICAgICAgICAgICAgICA7OyBSZXBsYWNlIHRlc3Qgd2l0aCBvbmUg dGhhdCBtYXJrcyBjcHVfY2xvY2sgYW5kIGNwdV90eXBlCisgICAgICAgICAgICAgICAgICA7OyBh cyBUT0RPLiAgQm9ycm93ZWQgZnJvbSBEZWJpYW4uCisgICAgICAgICAgICAgICAgICAoY2FsbC13 aXRoLW91dHB1dC1maWxlICJ0L1N5cy1DUFUudCIKKyAgICAgICAgICAgICAgICAgICAgKGxhbWJk YSAocG9ydCkKKyAgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0IHBvcnQgIiMhL3Vzci9iaW4v cGVybAorCit1c2UgVGVzdDo6TW9yZSB0ZXN0cyA9PiA0OworCitCRUdJTiB7IHVzZV9vaygnU3lz OjpDUFUnKTsgfQorCiskbnVtYmVyID0gJlN5czo6Q1BVOjpjcHVfY291bnQoKTsKK29rKCBkZWZp bmVkKCRudW1iZXIpLCBcIkNQVSBDb3VudDogJG51bWJlclwiICk7CisKK1RPRE86IHsKKyAgICBs b2NhbCAkVE9ETyA9IFwiL3Byb2MvY3B1aW5mbyBkb2Vzbid0IGFsd2F5cyByZXBvcnQgJ2NwdSBN SHonIG9yICdjbG9jaycgb3IgJ2JvZ29taXBzJyAuLi5cIjsKKyAgICAkc3BlZWQgPSAmU3lzOjpD UFU6OmNwdV9jbG9jaygpOworICAgIG9rKCBkZWZpbmVkKCRzcGVlZCksIFwiQ1BVIFNwZWVkOiAk c3BlZWRcIiApOworfQorCitUT0RPOiB7CisgICAgbG9jYWwgJFRPRE8gPSBcIi9wcm9jL2NwdWlu Zm8gZG9lc24ndCBhbHdheXMgcmVwb3J0ICdtb2RlbCBuYW1lJyBvciAnbWFjaGluZScgLi4uXCI7 CisgICAgJHR5cGUgPSAmU3lzOjpDUFU6OmNwdV90eXBlKCk7CisgICAgb2soIGRlZmluZWQoJHR5 cGUpLCBcIkNQVSBUeXBlOiAgJHR5cGVcIiApOworfX4lIikpKSkpKSkKICAgICAoYnVpbGQtc3lz dGVtIHBlcmwtYnVpbGQtc3lzdGVtKQogICAgIChzeW5vcHNpcyAiUGVybCBleHRlbnNpb24gZm9y IGdldHRpbmcgQ1BVIGluZm9ybWF0aW9uIikKICAgICAoZGVzY3JpcHRpb24K --_002_CY4PR11MB1718DEC796149A5DE28DC5F1B75A0CY4PR11MB1718namp_-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 28 03:51:32 2017 Received: (at 29030) by debbugs.gnu.org; 28 Oct 2017 07:51:32 +0000 Received: from localhost ([127.0.0.1]:38004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Ltz-0000E2-TS for submit@debbugs.gnu.org; Sat, 28 Oct 2017 03:51:32 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:57893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8Lty-0000Du-3Y for 29030@debbugs.gnu.org; Sat, 28 Oct 2017 03:51:30 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id BF999F5D1; Sat, 28 Oct 2017 09:51:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cDiMSXomJh7u; Sat, 28 Oct 2017 09:51:30 +0200 (CEST) Received: from ribbon (smb-adpcdg1-02.hotspot.hub-one.net [213.174.99.130]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 976B3F559; Sat, 28 Oct 2017 09:51:29 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Eric Bavier Subject: Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO. References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Brumaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 28 Oct 2017 09:51:24 +0200 In-Reply-To: (Eric Bavier's message of "Fri, 27 Oct 2017 20:40:12 +0000") Message-ID: <87po977ls3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29030 Cc: 29030@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Eric, Eric Bavier skribis: > On my system, perl-sys-cpu's tests fail because of differences in the inf= ormation available in /proc/cpuinfo. > > Debian's patch for this perl module seemed nice: rather than trying to fi= x the related functions, just concede that the module is mostly used just t= o read the number of available processors and mark the other tests as "TODO= ". [...] > + (snippet > + '(begin > + ;; Replace test with one that marks cpu_clock and cpu_= type > + ;; as TODO. Borrowed from Debian. Perhaps make it clear in the comment that we do this because the contents of /proc/cpuinfo differ based on different factors. Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 00:29:03 2017 Received: (at 29030-done) by debbugs.gnu.org; 29 Oct 2017 04:29:03 +0000 Received: from localhost ([127.0.0.1]:39664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8fDb-00019d-Bv for submit@debbugs.gnu.org; Sun, 29 Oct 2017 00:29:03 -0400 Received: from mail.centurylink.net ([205.219.233.9]:48052 helo=smtp.centurylink.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8fDa-000199-3s for 29030-done@debbugs.gnu.org; Sun, 29 Oct 2017 00:29:02 -0400 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1509251336; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=mFoB//QfrTpM3s5Rye21FOLpTpw=; b=kZswMYXWN+CobZ1bEAIapZ/e6Jc1G6nFgxgn4gI4pfg2L1YkftuWDEKB4VNRI+Nj 5Lxbtkk1qhkhF1h7WrFTlx9HDttvMNNPETd+ZS9ceikwLahpafRRaqF4YADSoTH5 HTu5cecw7s2OlH5coEaYXyJUmAvhgqbAYbvwizcCg17Ld1DkBY/0npDYdOhcwiH6 Xx/kZHlLJsZRAIUHC7sCdORxwoISyZDugLC+uXpyeSRSCRMCQxgvwmNftP+VwdbM UsBNg0O9QEjzwas3g+KDWyvSB6h4GhKBVhvxoy03+IW6juFX+jGm95ZUCofLs0ox F/RO1D12B4ykVaMPkFk/2Q==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=fcvv8AYF c=1 sm=1 tr=0 a=vYGdbaltFBZNd9BlzHJvqw==:117 a=vYGdbaltFBZNd9BlzHJvqw==:17 a=KGjhK52YXX0A:10 a=IkcTkHD0fZMA:10 a=1x0kU5LsU6YA:10 a=02M-m0pO-4AA:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8 a=kBl-OI3rAAAA:8 a=gDBKWeQDh-HbMoSoX1UA:9 a=QEXdDO2ut3YA:10 a=_FVE-zBwftR9WsbkzFJk:22 a=pLxN2xGgR0OPbCgNAGn6:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp02.agate.dfw.synacor.com smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.109.77] ([97.116.109.77:12822] helo=localhost) by smtp.centurylink.net (envelope-from ) (ecelerity 3.5.1.37854 r(Momo-dev:3.5.1.0)) with ESMTPSA (cipher=AES256-GCM-SHA384) id 14/5C-21442-70955F95; Sun, 29 Oct 2017 00:28:56 -0400 Date: Sat, 28 Oct 2017 18:29:07 -0500 From: Eric Bavier To: ludo@gnu.org (Ludovic =?UTF-8?B?Q291cnTDqHM=?=) Subject: Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO. Message-ID: <20171028182907.60b8629e@centurylink.net> In-Reply-To: <87po977ls3.fsf@gnu.org> References: <87po977ls3.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 29030-done Cc: 29030-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) On Sat, 28 Oct 2017 09:51:24 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hi Eric, >=20 > Eric Bavier skribis: >=20 > > On my system, perl-sys-cpu's tests fail because of differences in the i= nformation available in /proc/cpuinfo. > > > > Debian's patch for this perl module seemed nice: rather than trying to = fix the related functions, just concede that the module is mostly used just= to read the number of available processors and mark the other tests as "TO= DO". =20 >=20 > [...] >=20 > > + (snippet > > + '(begin > > + ;; Replace test with one that marks cpu_clock and cp= u_type > > + ;; as TODO. Borrowed from Debian. =20 >=20 > Perhaps make it clear in the comment that we do this because the > contents of /proc/cpuinfo differ based on different factors. OK. > Otherwise LGTM, thanks! Thanks, pushed in 9de52b56438674c0d0f92be34cebf5f1a38a6bfa. `~Eric From unknown Sun Jun 22 22:43:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Nov 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator