GNU bug report logs - #29023
25.3; newsticker: Inconsistent documentation of newsticker-new-item-functions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ulf Jasper <ulf.jasper <at> web.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29023: closed (25.3; newsticker: Inconsistent documentation
 of newsticker-new-item-functions)
Date: Fri, 27 Oct 2017 11:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 27 Oct 2017 13:30:26 +0200
with message-id <87lgjw96b1.fsf <at> web.de>
and subject line Re: bug#29023: 25.3; newsticker: Inconsistent documentation of newsticker-new-item-functions
has caused the debbugs.gnu.org bug report #29023,
regarding 25.3; newsticker: Inconsistent documentation of newsticker-new-item-functions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29023: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29023
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tim Landscheidt <tim <at> tim-landscheidt.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.3; newsticker: Inconsistent documentation of
 newsticker-new-item-functions
Date: Fri, 27 Oct 2017 05:18:41 +0000

(newsticker) Automatic Processing says:

|    […]

|    In order to do so write a function which takes three arguments

| FEED
|      the name of the corresponding news feed,
| TITLE
|      the title of the headline,
| DESC
|      the decoded description of the headline.

|    and add it to ‘newsticker-new-item-functions’.  […]

newsticker-new-item-functions's docstring says:

| List of functions run after a new headline has been retrieved.
| Each function is called with the following three arguments:
| FEED  the name of the corresponding news feed,
| TITLE the title of the headline,
| DESC  the decoded description of the headline.

However the functions "Hook samples" in newst-backend.el are
all defined as:

| […]
| (defun newsticker-new-item-functions-sample (feed item)
| […]

| (defun newsticker-download-images (feed item)
| […]

| (defun newsticker-download-enclosures (feed item)
| […]

i. e. they take two arguments, not three.

Also, there is no explicit documentation if the functions'
return values matter (AFAIUI they are ignored).

In addition, newsticker-new-item-functions's docstring re-
commends:

| […]

| See ‘newsticker-download-images’, and
| ‘newsticker-download-enclosures’ for sample functions.

| […]

It might be useful to add
newsticker-new-item-functions-*sample* to that list :-).

[Message part 3 (message/rfc822, inline)]

From: Ulf Jasper <ulf.jasper <at> web.de>
To: Tim Landscheidt <tim <at> tim-landscheidt.de>
Cc: 29023 <at> debbugs.gnu.org, 29023-done <at> debbugs.gnu.org
Subject: Re: bug#29023: 25.3; newsticker: Inconsistent documentation of
 newsticker-new-item-functions
Date: Fri, 27 Oct 2017 13:30:26 +0200

Thanks for reporting this.  Fixed on master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.