GNU bug report logs - #29017
[PATCH] gnu: Add gwl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29017 in the body.
You can then email your comments to 29017 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add gwl.
Date: Thu, 26 Oct 2017 22:51:12 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

I would like to add GWL.  For a lack of a better place, I chose the
bioinformatics module because that's where we use this package.

Thanks for your time!

Kind regards,
Roel Janssen

[0001-gnu-Add-gwl.patch (text/x-patch, attachment)]

Message #8 received at 29017 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 29017 <at> debbugs.gnu.org
Subject: Re: [bug#29017] [PATCH] gnu: Add gwl.
Date: Thu, 26 Oct 2017 15:41:42 -0700

Hello!

Roel Janssen <roel <at> gnu.org> skribis:

> I would like to add GWL.  For a lack of a better place, I chose the
> bioinformatics module because that's where we use this package.

Awesome!  \o/

Perhaps that could go to package-management.scm?

> From eaa22755769973ba30600ae96bb92a5d6bad11dd Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Thu, 26 Oct 2017 22:46:50 +0200
> Subject: [PATCH] gnu: Add gwl.
>
> * gnu/packages/bioinformatics.scm (gwl): New variable.

[...]

> +(define-public gwl
> +  (package
> +    (name "gwl")
> +    (version "0.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://git.roelj.com/attachments/"
> +                                  "d804e310-b9c0-44b1-bd18-c7505e9f9d9b"))

Do you have a more “standard” URL, such as a cgit snapshot?  If not
that’s fine.

> +    (inputs
> +     `(("guix" ,guix)
> +       ("guile" ,guile-2.2)
> +       ("guile-commonmark" ,guile-commonmark)))

It might be that you either need to propagate Guix and CommonMark, or to
wrap the binaries that GWL provides (as is done in the ‘guix’ package),
no?

Otherwise LGTM, thank you!

Ludo’.

Message #11 received at 29017 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29017 <at> debbugs.gnu.org
Subject: Re: [bug#29017] [PATCH] gnu: Add gwl.
Date: Fri, 27 Oct 2017 13:26:24 +0200

Ludovic Courtès writes:

> Hello!
>
> Roel Janssen <roel <at> gnu.org> skribis:
>
>> I would like to add GWL.  For a lack of a better place, I chose the
>> bioinformatics module because that's where we use this package.
>
> Awesome!  \o/
>
> Perhaps that could go to package-management.scm?

The new patch adds it to package-management.scm.

>
>> From eaa22755769973ba30600ae96bb92a5d6bad11dd Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Thu, 26 Oct 2017 22:46:50 +0200
>> Subject: [PATCH] gnu: Add gwl.
>>
>> * gnu/packages/bioinformatics.scm (gwl): New variable.
>
> [...]
>
>> +(define-public gwl
>> +  (package
>> +    (name "gwl")
>> +    (version "0.1.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://git.roelj.com/attachments/"
>> +                                  "d804e310-b9c0-44b1-bd18-c7505e9f9d9b"))
>
> Do you have a more “standard” URL, such as a cgit snapshot?  If not
> that’s fine.

This I found a bit weird about Gogs.  Custom-uploaded tarballs get these
weird URLs.  I uploaded the same tarball to guixwl.org, and adjusted the
recipe to use that URL.

>
>> +    (inputs
>> +     `(("guix" ,guix)
>> +       ("guile" ,guile-2.2)
>> +       ("guile-commonmark" ,guile-commonmark)))
>
> It might be that you either need to propagate Guix and CommonMark, or to
> wrap the binaries that GWL provides (as is done in the ‘guix’ package),
> no?

I added guix and guile-commonmark to the propagated-inputs.

>
> Otherwise LGTM, thank you!
>
> Ludo’.

Thanks for your quick response!  I pushed the new patch in 58a308e0b.

Kind regards,
Roel Janssen

Message #16 received at 29017-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29017-done <at> debbugs.gnu.org
Subject: Re: [bug#29017] [PATCH] gnu: Add gwl.
Date: Fri, 27 Oct 2017 16:08:26 +0200

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.