From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 25 20:26:55 2017 Received: (at submit) by debbugs.gnu.org; 26 Oct 2017 00:26:55 +0000 Received: from localhost ([127.0.0.1]:33746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7W0c-0001OW-Mw for submit@debbugs.gnu.org; Wed, 25 Oct 2017 20:26:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7W0a-0001OE-JI for submit@debbugs.gnu.org; Wed, 25 Oct 2017 20:26:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7W0U-0000Uf-5d for submit@debbugs.gnu.org; Wed, 25 Oct 2017 20:26:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7W0U-0000UO-1j for submit@debbugs.gnu.org; Wed, 25 Oct 2017 20:26:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7W0S-00031D-SM for bug-guile@gnu.org; Wed, 25 Oct 2017 20:26:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7W0P-0000Rb-NK for bug-guile@gnu.org; Wed, 25 Oct 2017 20:26:44 -0400 Received: from mail-pg0-x22a.google.com ([2607:f8b0:400e:c05::22a]:53815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7W0P-0000R7-DT for bug-guile@gnu.org; Wed, 25 Oct 2017 20:26:41 -0400 Received: by mail-pg0-x22a.google.com with SMTP id s2so1277162pge.10 for ; Wed, 25 Oct 2017 17:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=OX6+1ieuY3ThmcYPsRvgDzGW6ziJr9QNaH28DLCEMQk=; b=BuV2QNNrqABZNvIzilR5Wc/cjcHHsYJqpLxLcqBeS59Vy3Tn6AtIaFBnVNmO0cS2Mq 7ziyJK5GTDeb2H0Kww84eN69p8jrpsGZq7ncDT/hNyj1RvEikWg8ml+E5yLL43OShfoY a0EuYnUiLoCBtMLLWPce4QctaeXqb18heIrTmBwcP1IpPuh0ZJr2TyBBe5QEpnc512zd E7HWHpWzpGJd0IAfhQZupWGCnreGsm804vCIBw9H80xwgSGDEBw9PwO3d8Efp6kJxgUt TskRXfHtGFGjEzF7A+qbVshgDljFJynhjnvdXyagc6KPArvA0HXN0IQkQGN/y0S6bRN4 NTPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=OX6+1ieuY3ThmcYPsRvgDzGW6ziJr9QNaH28DLCEMQk=; b=dQP44dtNalj7y2vnQXk7nRUlm3PE3wg7PlsvL7sfsdWNvR0FtlN5BSUSBmW4PTixxV j/JdgHNYqeGKCiRBIWbYXk0ce4KukSDPM69DG0EZGhCmS9LNd6xUfsti56MIGQHETgya JFOymji8k7C9J/fqkrSfPCiVEPai89bWnzaVhIorsTaLN8aWpD3EitAAszees7Tw2vxW CVzMzZN9eFp2+ba/PxfdojK/x2fBfhe1x2hRob3pwsQVjl91jJGKckbriEu1cLKEGIKf LwZALnc128K+GzZH5n/QbIhWfFxrSPpmNgKLUQQDvp5TAHrLKqxrya09mC3APRzXNRsB O/lA== X-Gm-Message-State: AMCzsaXuT+VI83zExF417Qb6vwk4B5fthuLZNVrNMHgnxUcW58Y4aGK2 L1VW1iY6gDIHybdtEhldm70JMIvv X-Google-Smtp-Source: ABhQp+TIFjnZKKkg9Qfd56KrM7Y1M3NTx16NZVudfXnjjF9EMA9FOFnGbSh3LI/YVMhDY4xhfXtdUA== X-Received: by 10.98.37.68 with SMTP id l65mr3674288pfl.253.1508977599553; Wed, 25 Oct 2017 17:26:39 -0700 (PDT) Received: from nautilus.championbroadband.com (216-165-229-229.championbroadband.com. [216.165.229.229]) by smtp.gmail.com with ESMTPSA id q13sm471683pgt.73.2017.10.25.17.26.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 17:26:39 -0700 (PDT) From: Matt Wette Content-Type: multipart/alternative; boundary="Apple-Mail=_044EAE10-E63C-4231-A726-19DA0D3914FB" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [wishlist] configure option to disable tmpnam Message-Id: <01E234A3-581D-487B-B928-EEBF26A3DC43@gmail.com> Date: Wed, 25 Oct 2017 17:26:37 -0700 To: bug-guile@gnu.org X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --Apple-Mail=_044EAE10-E63C-4231-A726-19DA0D3914FB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii It would be nice to have a configure option to disable/enable including = the POSIX function tmpnam. It may give Guile a more "code secure" option to have the default be = disabled. I tried to generate a patch, but I could not get it to work both ways = (disable and enable). My autoconf knowledge and skills are lacking.=20 Here is what I tried (THIS DOES NOT WORK) --- libguile/posix.c-orig 2017-10-24 05:28:30.000000000 -0700 +++ libguile/posix.c 2017-10-24 05:28:51.000000000 -0700 @@ -1557,6 +1557,7 @@ } #undef FUNC_NAME =20 +#ifdef ENABLE_TMPNAM #ifdef L_tmpnam =20 SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, 0, @@ -1580,6 +1581,7 @@ #undef FUNC_NAME =20 #endif +#endif =20 SCM_DEFINE (scm_tmpfile, "tmpfile", 0, 0, 0, (void), --- configure.ac-orig 2017-10-24 05:21:56.000000000 -0700 +++ configure.ac 2017-10-25 16:07:34.000000000 -0700 @@ -164,6 +164,10 @@ [ --disable-regex omit regular expression interfaces],, enable_regex=3Dyes) =20 +AC_ARG_ENABLE(tmpnam, + [ --enable-tmpnam enable POSIX tmpnam], + enable_tmpnam=3Dyes, enable_tmpnam=3Dno) + AC_ARG_ENABLE([deprecated], AS_HELP_STRING([--disable-deprecated],[omit deprecated features])) ^--- DOES NOT WORK =20 --Apple-Mail=_044EAE10-E63C-4231-A726-19DA0D3914FB Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii It would be nice to have a configure option to disable/enable = including the POSIX function tmpnam.
It may give Guile a = more "code secure" option to have the default be disabled.

I tried to generate a = patch, but I could not get it to work both ways (disable and enable). =  My autoconf
knowledge and skills are = lacking. 

Here is what I tried (THIS DOES NOT WORK)

--- = libguile/posix.c-orig       2017-10-24 05:28:30.000000000 = -0700
+++ libguile/posix.c    = 2017-10-24 05:28:51.000000000 -0700
@@ = -1557,6 +1557,7 @@
 }
 #undef FUNC_NAME

 

+#ifdef = ENABLE_TMPNAM
 #ifdef L_tmpnam

 

 SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, = 0,
@@ -1580,6 +1581,7 @@
 #undef FUNC_NAME

 

 #endif
+#endif

 

 SCM_DEFINE (scm_tmpfile, "tmpfile", 0, 0, = 0,
             = (void),

--- configure.ac-orig   2017-10-24 05:21:56.000000000 = -0700
+++ configure.ac      =   2017-10-25 16:07:34.000000000 -0700
@@ = -164,6 +164,10 @@
   [  --disable-regex =         omit regular expression = interfaces],,
   = enable_regex=3Dyes)

 

+AC_ARG_ENABLE(tmpnam,
+  = [  --enable-tmpnam         enable POSIX = tmpnam],
+  enable_tmpnam=3Dyes, = enable_tmpnam=3Dno)
+
 AC_ARG_ENABLE([deprecated],
   AS_HELP_STRING([--disable-deprecated],[omit = deprecated features]))

^--- = DOES NOT WORK

 


= --Apple-Mail=_044EAE10-E63C-4231-A726-19DA0D3914FB-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 27 14:14:16 2017 Received: (at 29001) by debbugs.gnu.org; 27 Oct 2017 18:14:16 +0000 Received: from localhost ([127.0.0.1]:37639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8995-0001Tf-Oq for submit@debbugs.gnu.org; Fri, 27 Oct 2017 14:14:16 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:44363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8992-0001TN-PY for 29001@debbugs.gnu.org; Fri, 27 Oct 2017 14:14:14 -0400 Received: by mail-pf0-f175.google.com with SMTP id x7so5500319pfa.1 for <29001@debbugs.gnu.org>; Fri, 27 Oct 2017 11:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=mvYWWlWepvzHOxLXjGwRX75ZdaMUN1IuwzkcsSBgshE=; b=ugFQ2PnkJCk0cHRNg8suOeQSIfxUgeACSbdwpXSiJiS5afmrDoWWiuZ7JKU5Jam74V D1ldz0s8APEaytYwG7/vyd7sdTNLn4DdzglI+OG9KOxD+NJKfzwKLGP6xnkdRilKqHH4 bqBwTBtzhmZXsW/f95Om0dGw7ZzImmvtoy5wWb7lhepME2C9AexkqX9N8HVLpqXoI/0g vWlljLqQ7N1zktdiLPmy/R9D8UrrP9QBrQIp6me1lHd3kt5TnnWzVvCW68Obu1sL7C3F zgZyvQozD6HmwnbVnKmCOtCLrDbwsBFKKVelWEAKL/MmD+6TUY7fAQKnyYUgTRoEc5UI +8aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=mvYWWlWepvzHOxLXjGwRX75ZdaMUN1IuwzkcsSBgshE=; b=AK8ZagcYQqDLQh3cquiQZ3TubBaNWYofvuE4IKYYpJzyUcu0hcVns3MW/tyLZTPT8a Tq8+a7pBowOOeEZ28f/RsYCmdUWVF+Iy8Zopp/5QRNISpJK2ouTqa9MKWU2ruwfJocV+ A7yyfMSBxVVtJPZK2Rm7I7VoG2EJqh5tfZzf//zR7uOM07AbKiBKl7/Lplfl7lAx/uU+ Gea+qDeWo6PxNOQO10vtkypJASO3PexR3maa8yXUeSlBCldUsEEWG8pkEg+9ImPbx6Vj VXs4hDjd2WRlu9Z0Ob9kRXEzoTpWkqICnu4VCd283pbSWfnPyfPDTVbPOznkzHfRJhBO lRug== X-Gm-Message-State: AMCzsaUzm4lj5aawO/nM8QCa5LB9CW2nJxRP1hUiO8Ry4G1WLbiYHuAt siXoVi2F3xbQo+c0L5hhcUE5aDI0 X-Google-Smtp-Source: ABhQp+Rdto7Al/PXIsmppOFbkAVeFVOnX60yQ/z6qZz3xmXlRqRRc7GcDwvAS7qtiIn7aPjEbKdKlQ== X-Received: by 10.98.155.218 with SMTP id e87mr1232655pfk.96.1509128046426; Fri, 27 Oct 2017 11:14:06 -0700 (PDT) Received: from nautilus.championbroadband.com (216-165-229-229.championbroadband.com. [216.165.229.229]) by smtp.gmail.com with ESMTPSA id b23sm17050703pfm.148.2017.10.27.11.14.05 for <29001@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Oct 2017 11:14:05 -0700 (PDT) From: Matt Wette Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: tmpnam option Message-Id: <4630494F-2557-494B-94B6-EEAFF6278681@gmail.com> Date: Fri, 27 Oct 2017 11:14:04 -0700 To: 29001@debbugs.gnu.org X-Mailer: Apple Mail (2.3273) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 29001 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) OK I have it working. Complete patch here, assuming config.h.in is = generated by your autotools. --- libguile/posix.c-orig 2017-10-24 05:28:30.000000000 -0700 +++ libguile/posix.c 2017-10-24 05:28:51.000000000 -0700 @@ -1557,6 +1557,7 @@ } #undef FUNC_NAME =20 +#ifdef ENABLE_TMPNAM #ifdef L_tmpnam =20 SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, 0, @@ -1580,6 +1581,7 @@ #undef FUNC_NAME =20 #endif +#endif =20 SCM_DEFINE (scm_tmpfile, "tmpfile", 0, 0, 0, (void), --- configure.ac-orig 2017-10-24 05:21:56.000000000 -0700 +++ configure.ac 2017-10-27 09:03:20.000000000 -0700 @@ -164,6 +164,10 @@ [ --disable-regex omit regular expression interfaces],, enable_regex=3Dyes) =20 +AC_ARG_ENABLE(tmpnam, + [ --enable-tmpnam enable POSIX tmpnam], + AC_DEFINE(ENABLE_TMPNAM,1,[enable POSIX tmpnam()]),) + AC_ARG_ENABLE([deprecated], AS_HELP_STRING([--disable-deprecated],[omit deprecated features])) =20 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 18 19:48:45 2020 Received: (at 29001) by debbugs.gnu.org; 18 Mar 2020 23:48:45 +0000 Received: from localhost ([127.0.0.1]:41573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEiQX-0005FU-2a for submit@debbugs.gnu.org; Wed, 18 Mar 2020 19:48:45 -0400 Received: from mail-pg1-f176.google.com ([209.85.215.176]:38042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEiQU-0005FA-SZ for 29001@debbugs.gnu.org; Wed, 18 Mar 2020 19:48:43 -0400 Received: by mail-pg1-f176.google.com with SMTP id x7so162784pgh.5 for <29001@debbugs.gnu.org>; Wed, 18 Mar 2020 16:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=hcKUNXe/4j53iR6O9oAqfNRu7223G0uD2NLnzQRGdBM=; b=fvw3xfjymY6JShclxaiDJFTygrCqbsorpf2rdvHVcNxCXr6xhxQyFzQynn/4xsrsLJ 3G4cr1LMWNg/dBGcHXR1xy7Z/oY0uhXylQBLdWBUeClQBkKshkLxD+K92a1EKY+V1KKJ vKaeTK7qfCBoprBZeUgboJhTYSVFaG6pOZi601/jxcQJ0rE5XaHI1jGcHMNiYCxWwW4J dSs2+xqxzm9jJMPLcgBYkTTxwWSbsr3xY++a11Ua8j9Bemf6arYKaVXHoyXDFAjHpnLm QNTL4f+Aa7iUo973Z8S4WcxPxt0fEL3Mjm05QL3bAjQTUJwXQa65lyyRwPQnMWxG2B7v Z04Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=hcKUNXe/4j53iR6O9oAqfNRu7223G0uD2NLnzQRGdBM=; b=eimiUWgx4rLPXoLYDvlHthOFKBInrzqVyTO4iYFpB8sQaSjTHizlaoEnnb9m/uevL3 4QgDp48oDG/8cf6EiN4JVcfviOe2i3g0zhFYOFhdjp2Tf9+Et6aSvvW/n7mOMaKiJrPx WVLtuPYQKNEDBYEsIfKdEQ4CljfnQGRmg7ryAEHxSlyWqOCxrIHMvrFq0qGpmwTSo6FX aWPNJGPsH01MmAUNyNhqHk9rJ02BDxTq6Av1vLyryZfyYUc6SrUJp+43vDEeLsW4JAd9 E91OJEFmPsHlvG2YgWZ2mBd/jl2BSbThvqYcImzZHv9teuCsoYOsYXYg+Uz3yQ90Aa63 a+Zw== X-Gm-Message-State: ANhLgQ2uEVcNVdSeDjcOPMemeR8c5AQrBzIS2Tspj+Ebz+hod24ouOSA x9iRF8A3fk9Zj0QMeFTgCy6WEV45 X-Google-Smtp-Source: ADFU+vt7iIbCJhlisn5bF1qK5goAmWe5nN6Tmt3AkLvmI/4akqMnz+7ml/glqQ55TRa3pjBsSQ7HIg== X-Received: by 2002:a62:ea08:: with SMTP id t8mr834545pfh.71.1584575316812; Wed, 18 Mar 2020 16:48:36 -0700 (PDT) Received: from [192.168.2.183] (64-52-176-132.championbroadband.com. [64.52.176.132]) by smtp.gmail.com with ESMTPSA id t60sm98278pjb.9.2020.03.18.16.48.36 for <29001@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2020 16:48:36 -0700 (PDT) To: 29001@debbugs.gnu.org From: Matt Wette Subject: tmpnam Message-ID: <7cb7bf3f-8afb-8ff2-b9d8-f04a7eb8817a@gmail.com> Date: Wed, 18 Mar 2020 16:48:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29001 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is related to 4075 at debbugs.gnu.org From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 18 20:30:13 2020 Received: (at 29001) by debbugs.gnu.org; 19 Mar 2020 00:30:13 +0000 Received: from localhost ([127.0.0.1]:41597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEj4f-0006OZ-I9 for submit@debbugs.gnu.org; Wed, 18 Mar 2020 20:30:13 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:46086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEj4d-0006OH-IO for 29001@debbugs.gnu.org; Wed, 18 Mar 2020 20:30:12 -0400 Received: by mail-pg1-f178.google.com with SMTP id y30so188947pga.13 for <29001@debbugs.gnu.org>; Wed, 18 Mar 2020 17:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=W/qYgU/mSlXD9bfmVaJpWsYg+RrQzJVQ5Not8NId0wk=; b=k8s2PxAo33JqIm6qqlQsAveoQQhbMCn4gUjGLWuF1YOslT5yz6PdGLA1k9OzSMFlvl LjG+TXBWOL7c4eRyt/byiqWbYy3s7ZSjPlta04dxbWShMQIFJT9TgqRTWp7b2c36Xc2Z NBpxPZV2guLx4S0PNbv8BZ6FfxsN0vGiIP4GzYzjBwssjOTpNgTAEK5k8vL9QOntflPf 7YW30DnxWLj7dh/Ljciid3zP8j0fN9hfNaM+fW2KE5yOPd0Nn2KXfyCfMUq3PxcViM6W 4YEf2pwPmFCyQNktx9mpnC9W6KDwFbBs5wsUgllPEQb5xnSP2ImDsnDbs3s9UckKcftO q7vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=W/qYgU/mSlXD9bfmVaJpWsYg+RrQzJVQ5Not8NId0wk=; b=ZPXQ+G1aRTe8aeVlG1sJpzbCYr4YnFaK0SMlV7JUQtA5J0SoqhdLd0HAHVIWa/RNEt u3df5n8qYhAyL48jU1g4Op71dtDGjYrXP4joTq5UFDgZbRRa4EPaOGDM34ilbq66ApnE nxT7pjDVWbX1MPDfL96fqR6STcRsvTZdLSa2xEa+PYMzfinWtXkyMrlRFl5XHD5TvyhR LchlhpVfG4d+mulOOy/Mf/9/3uu9p5NhY6m78eBr8WkTcPi2yly7De8J6ajDzMu7XnhR RY7mRbP4vsqCghmfOjMIrti2LBH2sKAShReA6w6oemmLNxihofjeK7CNO24y1OTuXJg8 xOnw== X-Gm-Message-State: ANhLgQ3LEIkudMMlgj3wAnbnUeKtPnx5pks0pDoWlwHVFJfuLMKRelE4 aSIdXwnP4W8jYGdyd5T+yLBMAuFr X-Google-Smtp-Source: ADFU+vvmUihB6frKqSzPKe8qiW/FWDejcbJWnh66i48tRrh5gjlrvqtz0u6LqgV3lsgDEsBMtK4ASg== X-Received: by 2002:a62:db85:: with SMTP id f127mr1004884pfg.113.1584577805175; Wed, 18 Mar 2020 17:30:05 -0700 (PDT) Received: from [192.168.2.183] (64-52-176-132.championbroadband.com. [64.52.176.132]) by smtp.gmail.com with ESMTPSA id g10sm182912pfk.90.2020.03.18.17.30.04 for <29001@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2020 17:30:04 -0700 (PDT) Subject: Re: tmpnam From: Matt Wette To: 29001@debbugs.gnu.org References: <7cb7bf3f-8afb-8ff2-b9d8-f04a7eb8817a@gmail.com> Message-ID: <760b6127-9704-041b-23e2-2e3133410490@gmail.com> Date: Wed, 18 Mar 2020 17:30:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <7cb7bf3f-8afb-8ff2-b9d8-f04a7eb8817a@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29001 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/18/20 4:48 PM, Matt Wette wrote: > This is related to 4075 at debbugs.gnu.org \ er  40075 at debbugs.gnu.org working on patch against 3.0.1 going better this time From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 16:22:21 2020 Received: (at 29001) by debbugs.gnu.org; 21 Mar 2020 20:22:21 +0000 Received: from localhost ([127.0.0.1]:48204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFkdR-0002x8-8V for submit@debbugs.gnu.org; Sat, 21 Mar 2020 16:22:21 -0400 Received: from mail-pg1-f176.google.com ([209.85.215.176]:41241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFkdL-0002wf-Hx for 29001@debbugs.gnu.org; Sat, 21 Mar 2020 16:22:20 -0400 Received: by mail-pg1-f176.google.com with SMTP id b1so4933543pgm.8 for <29001@debbugs.gnu.org>; Sat, 21 Mar 2020 13:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=JY7DtZoTi5HAUc7K0xLa+EcWtxqwD3ntP1xxOFRWSjg=; b=T5fQRAkm74dtSH3R+/9A1JnGgU7Mwac9SxnFYIm26y5cOZYE1DYH8CxBUYGtAxjwro NO8KSGmsUVvuf1446cLd1z+oz75Sk14jbVczxl+o/WrNrsf0u3skgVJSQZY+tTaXGLk3 mSowkfofQx4u87we51eBpMbM8tRRQ52D0fhm7V9TG4VTtqhUIUclde0bh0rh8rXpilMJ 3MRZ0PWY+lMFm/m1P/B7GQ24fSZNns1LUSEUxtVwtrjCz0o/xqietVueyPQa1hdUy/u4 iP1mPtaFGFDFFx0YHViCRkkJTdRhUTEKK1JSHkZdlsvIkl/WXa3vKDExJm+CcJAEd8s9 WVzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=JY7DtZoTi5HAUc7K0xLa+EcWtxqwD3ntP1xxOFRWSjg=; b=Mj2jIWdlxOZFv2SQ3zIHlpWh1aACZvxd7+BP/ZX5bKu/Om613hsRo25HvKnpKPIvXk /BSXFcw9PgcqSQSVH+L9/4AglkVgv0/lqer1TjgLSVl5D0O7nsbpuAg0uKk0gmVB+g00 1EfmoHPkIY84972QBpG/hPIvri6OVdWRB04hthMTVqmN0LeK1k959nH4EdHYas8MXbly gpDK8ajEh7pMnxnsGcvoU4KYD8kY+wjdkN7cWPlvtMSA7UT2tr5xKJCtaR0RwWUEEMBm h3DqI5qawlnp82Ty8R48QGlubvJE5AK3pdnWFR6HxV0PVldu+ROyIe7MOCfkuq/bcOXd ZH4Q== X-Gm-Message-State: ANhLgQ1LxBdDykj55dYtV7tYR05XYoRIYBouQoHUPLhFzTT328nJmruV ilshfzUZNUd+QGkC+p8/dIYIi9eM X-Google-Smtp-Source: ADFU+vvo7fo4F8t0IgTMGtJRFB1+s0L2jevOukRuWyhjmFisro+Ws0L5BauJf8xLWID1tjSCLliMtw== X-Received: by 2002:a63:381d:: with SMTP id f29mr8524096pga.49.1584822129034; Sat, 21 Mar 2020 13:22:09 -0700 (PDT) Received: from [192.168.2.183] (64-52-176-132.championbroadband.com. [64.52.176.132]) by smtp.gmail.com with ESMTPSA id b9sm8224966pgi.75.2020.03.21.13.22.08 for <29001@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Mar 2020 13:22:08 -0700 (PDT) To: 29001@debbugs.gnu.org From: Matt Wette Subject: --disable-tmpnam Message-ID: Date: Sat, 21 Mar 2020 13:22:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29001 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "make" and "make check" succeeds on 3.0.1 / Ubuntu 18.04 / x86_64 with 1) --disable-tmpnam 2) --enable-tmpnam 3) neither This updates libguile/posix.c and configure.ac to allow extra configuration option --disable-tmpnam.   This is made available for installations that don't want to allow the insecure tmpnam function.  (Use mkstemp! instead.) --- libguile/posix.c-orig    2020-03-18 16:55:09.349588085 -0700 +++ libguile/posix.c    2020-03-18 17:07:20.860142083 -0700 @@ -65,6 +65,7 @@  #include "async.h"  #include "bitvectors.h" +#include "deprecation.h"  #include "dynwind.h"  #include "extensions.h"  #include "feature.h" @@ -1588,6 +1589,7 @@  }  #undef FUNC_NAME +#ifdef ENABLE_TMPNAM  #ifdef L_tmpnam  SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, 0, @@ -1602,6 +1604,9 @@    char name[L_tmpnam];    char *rv; +  scm_c_issue_deprecation_warning +      ("Use of tmpnam is deprecated.  Use mkstemp! instead."); +    SCM_SYSCALL (rv = tmpnam (name));    if (rv == NULL)      /* not SCM_SYSERROR since errno probably not set.  */ @@ -1611,6 +1616,7 @@  #undef FUNC_NAME  #endif +#endif  SCM_DEFINE (scm_tmpfile, "tmpfile", 0, 0, 0,              (void), --- configure.ac-orig    2020-03-18 17:11:17.977427035 -0700 +++ configure.ac    2020-03-18 17:09:57.850334685 -0700 @@ -166,6 +166,10 @@    [  --disable-regex         omit regular expression interfaces],,    enable_regex=yes) +AC_ARG_ENABLE(tmpnam, +  [  --disable-tmpnam        omit POSIX tmpnam],, +  enable_tmpnam=yes) +  AC_ARG_ENABLE([deprecated],    AS_HELP_STRING([--disable-deprecated],[omit deprecated features])) @@ -909,6 +913,10 @@     AC_DEFINE([ENABLE_REGEX], 1, [Define when regex support is enabled.])  fi +if test "$enable_tmpnam" = yes; then +   AC_DEFINE([ENABLE_TMPNAM], 1, [Define when tmpnam support is enabled.]) +fi +  AC_REPLACE_FUNCS([strerror memmove])  # Reasons for testing: From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 16:25:44 2020 Received: (at 29001) by debbugs.gnu.org; 21 Mar 2020 20:25:44 +0000 Received: from localhost ([127.0.0.1]:48211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFkgh-00033k-V9 for submit@debbugs.gnu.org; Sat, 21 Mar 2020 16:25:44 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:36536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFkgg-00033W-JI for 29001@debbugs.gnu.org; Sat, 21 Mar 2020 16:25:42 -0400 Received: by mail-pg1-f180.google.com with SMTP id z72so4952980pgz.3 for <29001@debbugs.gnu.org>; Sat, 21 Mar 2020 13:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=yVEOleJszYrohEspyJPjrxexqh09KmLdy7jiKxE+74o=; b=Gv430J7k1DDMCAeuc7Xp9iTd3gi8LPbNCeRMmfG/iyRvNnlTTsnU/SVNJJKjtmrwgV /c2Qj/M5Ad059Y2E4o0k7bHXH79Oqj4BOh9BrfB+xzmfrDwUIA1s88U7Bub5i//UbOaI d7ZdjOs0NZQqRGA1DUWcGCS7C+L9M4u2ymdxbGue533I07VzuR9QxJUu6iRpcmeOsjQH UEj9vQ2O9+Noh/+/OKyo8tYrvdgrFMkhuNbefyesn60H0yKDAigGe5jRg7Qe967AhbP3 IQRhL4DyAOEdJhxwHnsFXgwIZDKxLPM00YB2dLljo/8cOhHFOsMIjW51MnlWK5I4H1yo Ztkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=yVEOleJszYrohEspyJPjrxexqh09KmLdy7jiKxE+74o=; b=dZSYGyFnD9gDuIniVqY5fW3QaHmY6BR66lHSufVc338RL7X/pFl9rd+jZwyVB8DgSR LbZMu+8nV/6XPlXNjvgHlO4sdhWLkZYNaIZiKrL3Zr4eZoWwIiTWCb2vF8jpC8BUQ/Pt Bvi5hiolpU7H2Xo3ctHg94wZTFTwJcJfTQ0PULNhg8+chx9P9fIZI3hbcshV3jlsd+mv 6VA7goBllNTYYvWJ6y3HzwzAPu37mNNvR/3NlQY4dELpBt4+is7XO2W6tNLwxIcnOhIQ NsKQO2sd37YoJ1sD+UX6w5yRMHP2Qedz8YFRN4k4u5rWDctkEdAQ5k4x/iqZa8nCiz4b rCPw== X-Gm-Message-State: ANhLgQ00SDz4tyK9xvUE/Mtb7lhc1vCSdjq2RgOIy1YshiZwxAuZsMcU CiQNjJkFVOIZsRg2+FggKjAwwmLw X-Google-Smtp-Source: ADFU+vvUh6Jv3J0h2vKL3AG8erRGVrVbf+QUrOzWpxHowhgIKNE8M90rUWfZL/eZGtqduhqp5s1hgg== X-Received: by 2002:aa7:95a8:: with SMTP id a8mr16701279pfk.61.1584822336475; Sat, 21 Mar 2020 13:25:36 -0700 (PDT) Received: from [192.168.2.183] (64-52-176-132.championbroadband.com. [64.52.176.132]) by smtp.gmail.com with ESMTPSA id s14sm8538564pgl.4.2020.03.21.13.25.35 for <29001@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Mar 2020 13:25:35 -0700 (PDT) To: 29001@debbugs.gnu.org From: Matt Wette Subject: patch Message-ID: <5721f97e-8c44-545b-f4fe-a0109ee86630@gmail.com> Date: Sat, 21 Mar 2020 13:25:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 29001 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Note: The above patch makes tmpnam report that it is deprecated. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 21 17:32:29 2020 Received: (at 29001) by debbugs.gnu.org; 21 Mar 2020 21:32:29 +0000 Received: from localhost ([127.0.0.1]:48296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFljJ-0007C9-Ea for submit@debbugs.gnu.org; Sat, 21 Mar 2020 17:32:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jFljD-0007Bp-Gi for 29001@debbugs.gnu.org; Sat, 21 Mar 2020 17:32:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jFlj8-0006ng-C5; Sat, 21 Mar 2020 17:32:18 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56230 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jFlj7-00067Y-Pu; Sat, 21 Mar 2020 17:32:18 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Matt Wette Subject: Re: bug#29001: --disable-tmpnam References: <01E234A3-581D-487B-B928-EEBF26A3DC43@gmail.com> Date: Sat, 21 Mar 2020 22:32:14 +0100 In-Reply-To: (Matt Wette's message of "Sat, 21 Mar 2020 13:22:07 -0700") Message-ID: <87h7yhxuld.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29001 Cc: 29001@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Matt, Matt Wette skribis: > "make" and "make check" succeeds on 3.0.1 / Ubuntu 18.04 / x86_64 with > 1) --disable-tmpnam > 2) --enable-tmpnam > 3) neither > > This updates libguile/posix.c and configure.ac to allow extra > configuration option --disable-tmpnam.=C2=A0=C2=A0 This is made available > for installations that don't want to allow the insecure tmpnam > function.=C2=A0 (Use mkstemp! instead.) Nice. We should have deprecated =E2=80=98tmpnam=E2=80=99 before 3.0.0, it=E2=80= =99s probably OK to do it now. > +AC_ARG_ENABLE(tmpnam, > +=C2=A0 [=C2=A0 --disable-tmpnam=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 omit POSIX tmpnam],, > +=C2=A0 enable_tmpnam=3Dyes) Could you use =E2=80=98AS_HELP_STRING=E2=80=99 as is done in some other pla= ces? This is the more conventional way to ensure proper formatting of =E2=80=98--help=E2= =80=99. Also, could you send the patch as an attachment (your mail client munged it somehow)? You can create the patch by first committing locally and then running (say) =E2=80=98git format-patch HEAD^=E2=80=99. Bonus points if your commit log follows the GNU ChangeLog style: https://www.gnu.org/prep/standards/html_node/Change-Logs.html You can imitate previous entries shown by =E2=80=98git log=E2=80=99. (I think this patch is acceptable without copyright assignment. Beyond that, we=E2=80=99ll need copyright assignment, as discussed on IRC.) Thanks in advance! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 22 12:20:30 2020 Received: (at 29001) by debbugs.gnu.org; 22 Mar 2020 16:20:30 +0000 Received: from localhost ([127.0.0.1]:50856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jG3Kw-0005qB-Cf for submit@debbugs.gnu.org; Sun, 22 Mar 2020 12:20:30 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:33456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jG3Ku-0005py-GD for 29001@debbugs.gnu.org; Sun, 22 Mar 2020 12:20:29 -0400 Received: by mail-pl1-f176.google.com with SMTP id g18so4816979plq.0 for <29001@debbugs.gnu.org>; Sun, 22 Mar 2020 09:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=0a3TuaY6lPQVW6f3IPJLFS9WokVlUbc7Pi9dtzyZ08I=; b=mBwkmVJ7pHMgAuFhpmNazhvd/0bs2DaS0ypfmDAq83KcD5Y/CIwSk6Bt2sIMCtVHw4 9t3YzzTkXmOC91RllYIvs4kIi/Xre+R4pB/pGLqJ8qmYuir7kyUOL94BiozYLX8Bp/BP HcTc8Zi4z4Tn/qWO+CRg+heAKam3hm7EhWgcV3VtCiqXakTdPlwH2SWJIvhh8/dgY+OV iJXpBUwOSnfaSNwG6P1JwPvS1+10/jCTAFLNzHfkDeSPG+bkk7N0S/b9MbzWzNfzOEvb Qzx30/ZWbuomQ7QcgKpNfLfxh+P1z5bJeFZQaLxItkJ6LXY82ADKX67UX3Y5Zi77V/eK SpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=0a3TuaY6lPQVW6f3IPJLFS9WokVlUbc7Pi9dtzyZ08I=; b=qtijXlSgfFtR6aXnJDXgxjezxnOag+xguY2ufziq2Ze/dkujDWsmXPucp08pm9T31r oT3ywpqZaHxS4kL9vIw6oxQHQLoC2H7CbHzUOS8Uf8YpVzKFaJFiHbmO7JfTI2k9R7h2 20/sRqW02odMN5vEXKVhIcVUcGr0DBaId1gFvWm+UjUmWavOKNeeilp+KQTyHrBO7VFl 1P35/Fvc7iBQdXikgBVkzwyzHym3QjTcy2nHeViIBRBxkamx5ZDlAL0wjb62tecUe2vh PrjAxmr2Qhcj+1uRW232sFOgjnbEycU9EW70IT5QkN8EL4vDUVai4GtG3B+RRRXoEjRW 0nrw== X-Gm-Message-State: ANhLgQ1vQ9NqMyVPYyONGRG/Hb9EQOr4PZBhNMsez2i7YkNaBQVyE8oB 5OfbibZxElHmCgfr0N/Fepb27w2n X-Google-Smtp-Source: ADFU+vtv4Za5/7CagkGRZOA5c+DVm2is6fFng++SRzcPvVpS2PhsCByB+jZTZaWwmAkkOBPRbEnsgQ== X-Received: by 2002:a17:902:82c2:: with SMTP id u2mr13116114plz.125.1584894022284; Sun, 22 Mar 2020 09:20:22 -0700 (PDT) Received: from [192.168.2.183] (64-52-176-132.championbroadband.com. [64.52.176.132]) by smtp.gmail.com with ESMTPSA id bx1sm10012576pjb.5.2020.03.22.09.20.20 for <29001@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2020 09:20:21 -0700 (PDT) To: 29001@debbugs.gnu.org From: Matt Wette Subject: git patch Message-ID: Date: Sun, 22 Mar 2020 09:20:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------C3E175785FE2811E18AB188B" Content-Language: en-US X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 29001 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) This is a multi-part message in MIME format. --------------C3E175785FE2811E18AB188B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Attached is the git patch against the following guile commit: bef5e0b3938cc88e3a1a1ac590b009875cc38162 --------------C3E175785FE2811E18AB188B Content-Type: text/x-patch; charset=UTF-8; name="0001-2020-03-22-Matt-Wette-mwette-alumni.caltech.edu.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-2020-03-22-Matt-Wette-mwette-alumni.caltech.edu.patch" >From 71ff7e79369a4514a961fc5cf76593b254c32d4c Mon Sep 17 00:00:00 2001 From: Matt Wette Date: Sun, 22 Mar 2020 09:12:37 -0700 Subject: [PATCH] 2020-03-22 Matt Wette * configure.ac: Provide new option: --disable-tmpnam This is made available for installations that don't want to allow the insecure POSIX tmpname function. Use mkstemp! instead. * libguile/posix.c tmpnam is deprecated; and enabled by ENABLE_TMPNAM --- configure.ac | 8 ++++++++ libguile/posix.c | 11 +++++++++++ 2 files changed, 19 insertions(+) diff --git a/configure.ac b/configure.ac index 6198c7e..3e96094 100644 --- a/configure.ac +++ b/configure.ac @@ -166,6 +166,10 @@ AC_ARG_ENABLE(regex, [ --disable-regex omit regular expression interfaces],, enable_regex=yes) +AC_ARG_ENABLE(tmpnam, + AS_HELP_STRING([--disable-tmpnam],[omit POSIX tmpnam]),, + enable_tmpnam=yes) + AC_ARG_ENABLE([deprecated], AS_HELP_STRING([--disable-deprecated],[omit deprecated features])) @@ -909,6 +913,10 @@ if test "$enable_regex" = yes; then AC_DEFINE([ENABLE_REGEX], 1, [Define when regex support is enabled.]) fi +if test "$enable_tmpnam" = yes; then + AC_DEFINE([ENABLE_TMPNAM], 1, [Define when tmpnam support is enabled.]) +fi + AC_REPLACE_FUNCS([strerror memmove]) # Reasons for testing: diff --git a/libguile/posix.c b/libguile/posix.c index a1520ab..9b9b476 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -87,6 +87,10 @@ #include "vectors.h" #include "version.h" +#if (SCM_ENABLE_DEPRECATED == 1) +#include "deprecation.h" +#endif + #include "posix.h" #if HAVE_SYS_WAIT_H @@ -1588,6 +1592,8 @@ SCM_DEFINE (scm_environ, "environ", 0, 1, 0, } #undef FUNC_NAME +#if (SCM_ENABLE_DEPRECATED == 1) +#ifdef ENABLE_TMPNAM #ifdef L_tmpnam SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, 0, @@ -1602,6 +1608,9 @@ SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, 0, char name[L_tmpnam]; char *rv; + scm_c_issue_deprecation_warning + ("Use of tmpnam is deprecated. Use mkstemp! instead."); + SCM_SYSCALL (rv = tmpnam (name)); if (rv == NULL) /* not SCM_SYSERROR since errno probably not set. */ @@ -1610,6 +1619,8 @@ SCM_DEFINE (scm_tmpnam, "tmpnam", 0, 0, 0, } #undef FUNC_NAME +#endif +#endif #endif SCM_DEFINE (scm_tmpfile, "tmpfile", 0, 0, 0, -- 2.17.1 --------------C3E175785FE2811E18AB188B-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 22 13:12:09 2020 Received: (at 29001-done) by debbugs.gnu.org; 22 Mar 2020 17:12:09 +0000 Received: from localhost ([127.0.0.1]:50871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jG48v-0007PP-I9 for submit@debbugs.gnu.org; Sun, 22 Mar 2020 13:12:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jG48t-0007P1-6p for 29001-done@debbugs.gnu.org; Sun, 22 Mar 2020 13:12:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jG48n-0001zO-Jv; Sun, 22 Mar 2020 13:12:01 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38310 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jG48m-0000K5-SC; Sun, 22 Mar 2020 13:12:01 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Matt Wette Subject: Re: bug#29001: git patch References: <01E234A3-581D-487B-B928-EEBF26A3DC43@gmail.com> Date: Sun, 22 Mar 2020 18:11:58 +0100 In-Reply-To: (Matt Wette's message of "Sun, 22 Mar 2020 09:20:19 -0700") Message-ID: <877dzcuxep.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29001-done Cc: 29001-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Matt, Matt Wette skribis: >>>From 71ff7e79369a4514a961fc5cf76593b254c32d4c Mon Sep 17 00:00:00 2001 > From: Matt Wette > Date: Sun, 22 Mar 2020 09:12:37 -0700 > Subject: [PATCH] 2020-03-22 Matt Wette > > * configure.ac: > Provide new option: --disable-tmpnam > This is made available for installations that don't want to allow > the insecure POSIX tmpname function. Use mkstemp! instead. > > * libguile/posix.c > tmpnam is deprecated; and enabled by ENABLE_TMPNAM I tweaked the commit log and pushed. Thank you! Ludo=E2=80=99. From unknown Sat Sep 20 04:26:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Apr 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator