GNU bug report logs - #28998
27.0.50; Man--sections is in reverse order

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 28998 <at> debbugs.gnu.org
Subject: bug#28998: 27.0.50; Man--sections is in reverse order
Date: Mon, 06 Nov 2017 19:50:22 -0500

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> -(defsubst Man-build-section-alist ()
> +(defsubst Man-build-section-list ()

Perhaps we should switch to defun while we're at it?

> -  (let ((case-fold-search nil))
> +  (let (case-fold-search)

Personally, I like the more explicit version here.

> AFAICT there is no purpose or benefit to keeping
> Man--sections reversed, other than avoiding a call to
> nreverse, which AFAIK is quite an efficient operation.
>
> Conversely, keeping the sections in their natural order
> (i.e. from (point-min) to (point-max)) both seems more
> natural and is more convenient for users of completion
> frontends like ivy.el.

Makes sense to me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.