GNU bug report logs - #28997
27.0.50; Error in async shell-command process filter

Previous Next

Full log

Message #11 received at 28997 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 28997 <at> debbugs.gnu.org
Subject: Re: bug#28997: 27.0.50; Error in async shell-command process filter
Date: Tue, 31 Oct 2017 06:48:52 -0400

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> The first patch replaces the quoted lambda process filter
> with a closure over the name of output-buffer.  By keeping
> track of this name, a lot of the surrounding
> buffer-name-determining code can be simplified via DRY.

This looks good to me.

> The second patch is purely aesthetic and simplifies the cond
> that is touched by my first patch into an equivalent pcase.

I'm not sure about this one.  There was some contention in the past over
use of pcase, with some suggestions even to make an opposite
transformation, e.g., [1].

[1]: https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00055.html

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.