GNU bug report logs - #28986
[PATCH] gnu: Add r-tgstat.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28986 in the body.
You can then email your comments to 28986 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH] gnu: Add r-tgstat.
Date: Sun, 22 Oct 2017 13:56:07 +0200

* gnu/packages/statistics.scm (r-tgstat): New variable.
---
 gnu/packages/statistics.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index b3ebd5abb..6c8f7b5fa 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -27,6 +27,7 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix hg-download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system r)
@@ -5442,3 +5443,37 @@ the least concave majorant (LCM), for the half-normal and correlation
 distributions, and for computing empirical higher criticism (HC) scores and
 the corresponding decision threshold.")
     (license license:gpl3+)))
+
+(define-public r-tgstat
+  (let ((changeset "4f8e60c03598f49aff6f5beeab40f2b995377e9f")
+        (revision "1"))
+    (package
+      (name "r-tgstat")
+      (version (string-append "1.0.2-" revision "." (string-take changeset 7)))
+      (source
+       (origin
+         (method hg-fetch)
+         (uri (hg-reference
+               (url "https://bitbucket.org/tanaylab/tgstat")
+               (changeset changeset)))
+         (sha256
+          (base32
+           "0ilkkyximy77zbncm91kdfqbxf0qyndg16pd3q3p6a3xc9qcmxvn"))))
+      (build-system r-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'fix-isnan
+             (lambda _
+               (substitute* "src/tgstat.h"
+                 (("#define isnan ::isnan")
+                  "#define isnan std::isnan"))
+               #t)))))
+      (propagated-inputs
+       `(("r-rcpp" ,r-rcpp)))
+      (home-page "https://bitbucket.org/tanaylab/tgstat/")
+      (synopsis "Tanay's group statistical utilities")
+      (description
+       "The goal of tgstat is to provide fast and efficient statistical
+tools.")
+      (license license:gpl2))))
-- 
2.14.1

Message #8 received at 28986 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 28986 <at> debbugs.gnu.org
Subject: Re: [bug#28986] [PATCH] gnu: Add r-tgstat.
Date: Wed, 25 Oct 2017 22:13:48 -0700

Hi,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> * gnu/packages/statistics.scm (r-tgstat): New variable.

[...]

> +      (home-page "https://bitbucket.org/tanaylab/tgstat/")
> +      (synopsis "Tanay's group statistical utilities")
> +      (description
> +       "The goal of tgstat is to provide fast and efficient statistical
> +tools.")

It would be nice to elaborate, but otherwise LGTM.

Thanks,
Ludo’.

Message #11 received at 28986 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 28986 <at> debbugs.gnu.org
Subject: Re: [bug#28986] [PATCH] gnu: Add r-tgstat.
Date: Thu, 26 Oct 2017 09:56:06 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>
>> * gnu/packages/statistics.scm (r-tgstat): New variable.
>
> [...]
>
>> +      (home-page "https://bitbucket.org/tanaylab/tgstat/")
>> +      (synopsis "Tanay's group statistical utilities")
>> +      (description
>> +       "The goal of tgstat is to provide fast and efficient statistical
>> +tools.")
>
> It would be nice to elaborate, but otherwise LGTM.

Yes, I agree.  Like many R packages this is just a bunch of unrelated
functions that are generic enough to get their own package.  Having so
many of these packages is a cultural problem in R…

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #16 received at 28986-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 28986-done <at> debbugs.gnu.org
Subject: Re: [bug#28986] [PATCH] gnu: Add r-tgstat.
Date: Mon, 30 Oct 2017 12:12:04 +0100

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hi,
>>
>> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>>
>>> * gnu/packages/statistics.scm (r-tgstat): New variable.
>>
>> [...]
>>
>>> +      (home-page "https://bitbucket.org/tanaylab/tgstat/")
>>> +      (synopsis "Tanay's group statistical utilities")
>>> +      (description
>>> +       "The goal of tgstat is to provide fast and efficient statistical
>>> +tools.")
>>
>> It would be nice to elaborate, but otherwise LGTM.
>
> Yes, I agree.  Like many R packages this is just a bunch of unrelated
> functions that are generic enough to get their own package.  Having so
> many of these packages is a cultural problem in R…

I pushed it to master as is.  Closing.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.