GNU bug report logs - #28974
[PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Adam Van Ymeren <adam <at> vany.ca>
Subject: bug#28974: closed (Re: [bug#28974] [PATCH 1/1] gnu: syslinux:
 Propagate mtools as syslinux needs it at runtime.)
Date: Thu, 16 Nov 2017 09:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#28974: [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 28974 <at> debbugs.gnu.org.

-- 
28974: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28974
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 28974-done <at> debbugs.gnu.org
Subject: Re: [bug#28974] [PATCH 1/1] gnu: syslinux: Propagate mtools as
 syslinux needs it at runtime.
Date: Thu, 16 Nov 2017 10:45:10 +0100

Hi Adam,

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Adam Van Ymeren <adam <at> vany.ca> skribis:
>
>> When trying to install syslinux to a FAT partition, it requires the
>> mtools (particularly mcopy) to be available at runtime in PATH.
>
> [...]
>
>> +      (propagated-inputs
>> +         `(("mtools" ,mtools)))
>
> A quick inspection showed uses of “mcopy” and “mattrib”.  To avoid
> propagating mtools, I propose the patch below.
>
> Could you check if it works for you?

It LGTM so I pushed it as 0b4dbb401cd94cd04eab3a25f80cbb3fcd3d1daf.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Adam Van Ymeren <adam <at> vany.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at
 runtime.
Date: Tue, 24 Oct 2017 14:59:54 -0400

When trying to install syslinux to a FAT partition, it requires the
mtools (particularly mcopy) to be available at runtime in PATH.

---
 gnu/packages/bootloaders.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 613537a5d..b747ca579 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -44,6 +44,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages virtualization)
+  #:use-module (gnu packages mtools)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
   #:use-module (guix git-download)
@@ -237,6 +238,8 @@ menu to select one of the installed operating systems.")
          ("python-2" ,python-2)))
       (inputs
        `(("libuuid" ,util-linux)))
+      (propagated-inputs
+         `(("mtools" ,mtools)))
       (arguments
        `(#:parallel-build? #f
          #:make-flags
-- 
2.14.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.