From unknown Sun Aug 17 22:00:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28974 <28974@debbugs.gnu.org> To: bug#28974 <28974@debbugs.gnu.org> Subject: Status: [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime. Reply-To: bug#28974 <28974@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:00:59 +0000 retitle 28974 [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs= it at runtime. reassign 28974 guix-patches submitter 28974 Adam Van Ymeren severity 28974 normal tag 28974 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 24 15:00:09 2017 Received: (at submit) by debbugs.gnu.org; 24 Oct 2017 19:00:10 +0000 Received: from localhost ([127.0.0.1]:60182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e74Qr-0000Dt-L1 for submit@debbugs.gnu.org; Tue, 24 Oct 2017 15:00:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e74Qq-0000CW-73 for submit@debbugs.gnu.org; Tue, 24 Oct 2017 15:00:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e74Qk-0007BY-GF for submit@debbugs.gnu.org; Tue, 24 Oct 2017 15:00:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e74Qk-0007BS-D7 for submit@debbugs.gnu.org; Tue, 24 Oct 2017 15:00:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e74Qj-0001ld-B9 for guix-patches@gnu.org; Tue, 24 Oct 2017 15:00:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e74Qe-000788-Gp for guix-patches@gnu.org; Tue, 24 Oct 2017 15:00:01 -0400 Received: from mail2.vany.ca ([142.54.190.254]:47290) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e74Qe-00077k-CQ for guix-patches@gnu.org; Tue, 24 Oct 2017 14:59:56 -0400 Received: from adamvy-laptop (unknown [192.159.178.248]) by mail2.vany.ca (Postfix) with ESMTPSA id D97D3AC05CE for ; Tue, 24 Oct 2017 13:59:54 -0500 (CDT) From: Adam Van Ymeren To: guix-patches@gnu.org Subject: [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime. Date: Tue, 24 Oct 2017 14:59:54 -0400 Message-ID: <87mv4gbcd1.fsf@vany.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) When trying to install syslinux to a FAT partition, it requires the mtools (particularly mcopy) to be available at runtime in PATH. --- gnu/packages/bootloaders.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 613537a5d..b747ca579 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -44,6 +44,7 @@ #:use-module (gnu packages python) #:use-module (gnu packages texinfo) #:use-module (gnu packages virtualization) + #:use-module (gnu packages mtools) #:use-module (guix build-system gnu) #:use-module (guix download) #:use-module (guix git-download) @@ -237,6 +238,8 @@ menu to select one of the installed operating systems.") ("python-2" ,python-2))) (inputs `(("libuuid" ,util-linux))) + (propagated-inputs + `(("mtools" ,mtools))) (arguments `(#:parallel-build? #f #:make-flags -- 2.14.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 26 01:09:29 2017 Received: (at 28974) by debbugs.gnu.org; 26 Oct 2017 05:09:29 +0000 Received: from localhost ([127.0.0.1]:33851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7aQ5-0001j9-Jb for submit@debbugs.gnu.org; Thu, 26 Oct 2017 01:09:29 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:51320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7aQ4-0001j1-Gi for 28974@debbugs.gnu.org; Thu, 26 Oct 2017 01:09:28 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 73CE3E993; Thu, 26 Oct 2017 07:09:28 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PeWeqWCIrTRm; Thu, 26 Oct 2017 07:09:27 +0200 (CEST) Received: from ribbon (node-1w7jr9qot7winqrne9k8b99d1.ipv6.telus.net [IPv6:2001:569:7803:2c00:728:f466:18ad:22a5]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F3D58DB0B; Thu, 26 Oct 2017 07:09:26 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Adam Van Ymeren Subject: Re: [bug#28974] [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime. References: <87mv4gbcd1.fsf@vany.ca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Brumaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 25 Oct 2017 22:09:22 -0700 In-Reply-To: <87mv4gbcd1.fsf@vany.ca> (Adam Van Ymeren's message of "Tue, 24 Oct 2017 14:59:54 -0400") Message-ID: <871slqjy0t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28974 Cc: 28974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Adam, Adam Van Ymeren skribis: > When trying to install syslinux to a FAT partition, it requires the > mtools (particularly mcopy) to be available at runtime in PATH. [...] > + (propagated-inputs > + `(("mtools" ,mtools))) A quick inspection showed uses of =E2=80=9Cmcopy=E2=80=9D and =E2=80=9Cmatt= rib=E2=80=9D. To avoid propagating mtools, I propose the patch below. Could you check if it works for you? Thank you, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 613537a5d..b4372748c 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -236,7 +236,8 @@ menu to select one of the installed operating systems.") ("perl" ,perl) ("python-2" ,python-2))) (inputs - `(("libuuid" ,util-linux))) + `(("libuuid" ,util-linux) + ("mtools" ,mtools))) (arguments `(#:parallel-build? #f #:make-flags @@ -251,11 +252,17 @@ menu to select one of the installed operating systems.") #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-files - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (substitute* (find-files "." "Makefile.*|ppmtolss16") (("/bin/pwd") (which "pwd")) (("/bin/echo") (which "echo")) (("/usr/bin/perl") (which "perl"))) + (let ((mtools (assoc-ref inputs "mtools"))) + (substitute* (find-files "." "\\.c$") + (("mcopy") + (string-append mtools "/bin/mcopy")) + (("mattrib") + (string-append mtools "/bin/mattrib")))) #t)) (delete 'configure) (add-before 'build 'set-permissions --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 04:45:17 2017 Received: (at 28974-done) by debbugs.gnu.org; 16 Nov 2017 09:45:17 +0000 Received: from localhost ([127.0.0.1]:42585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFGjV-0000EJ-2n for submit@debbugs.gnu.org; Thu, 16 Nov 2017 04:45:17 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:45466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFGjQ-0000E9-Us for 28974-done@debbugs.gnu.org; Thu, 16 Nov 2017 04:45:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 690BCC2D9; Thu, 16 Nov 2017 10:45:14 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XeGy-D7aO9GH; Thu, 16 Nov 2017 10:45:13 +0100 (CET) Received: from ribbon (unknown [193.50.110.175]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DF9729A5E; Thu, 16 Nov 2017 10:45:12 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Adam Van Ymeren Subject: Re: [bug#28974] [PATCH 1/1] gnu: syslinux: Propagate mtools as syslinux needs it at runtime. References: <87mv4gbcd1.fsf@vany.ca> <871slqjy0t.fsf@gnu.org> Date: Thu, 16 Nov 2017 10:45:10 +0100 In-Reply-To: <871slqjy0t.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 25 Oct 2017 22:09:22 -0700") Message-ID: <87r2syiml5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28974-done Cc: 28974-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Adam, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Adam Van Ymeren skribis: > >> When trying to install syslinux to a FAT partition, it requires the >> mtools (particularly mcopy) to be available at runtime in PATH. > > [...] > >> + (propagated-inputs >> + `(("mtools" ,mtools))) > > A quick inspection showed uses of =E2=80=9Cmcopy=E2=80=9D and =E2=80=9Cma= ttrib=E2=80=9D. To avoid > propagating mtools, I propose the patch below. > > Could you check if it works for you? It LGTM so I pushed it as 0b4dbb401cd94cd04eab3a25f80cbb3fcd3d1daf. Ludo=E2=80=99. From unknown Sun Aug 17 22:00:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 14 Dec 2017 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator