GNU bug report logs - #28951
The upstream URL of our Synergy package is broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28951 in the body.
You can then email your comments to 28951 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: The upstream URL of our Synergy package is broken
Date: Sun, 22 Oct 2017 22:33:05 -0400

Hello, here's what attempting to fetch the source URL gives us:

--8<---------------cut here---------------start------------->8---
Starting download of /tmp/fileLHAs7Q/upstream-synergy-1.8.8.tar.gz
From https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz...
ERROR: download failed "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz" 404 "Not Found"
failed to download "/tmp/fileLHAs7Q/upstream-synergy-1.8.8.tar.gz" from
"https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz"
--8<---------------cut here---------------end--------------->8---

It seems the repo was reorganized; potentially we should now use
https://github.com/symless/synergy-core instead of
https://github.com/symless/synergy.

Maxim

Message #8 received at 28951 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28951 <at> debbugs.gnu.org
Subject: Re: bug#28951: The upstream URL of our Synergy package is broken
Date: Mon, 23 Oct 2017 16:31:10 -0700

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Hello, here's what attempting to fetch the source URL gives us:
>
> Starting download of /tmp/fileLHAs7Q/upstream-synergy-1.8.8.tar.gz
> From https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz...
> ERROR: download failed "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz" 404 "Not Found"
> failed to download "/tmp/fileLHAs7Q/upstream-synergy-1.8.8.tar.gz" from
> "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz"

Fortunately we get a copy from the mirror:

--8<---------------cut here---------------start------------->8---
$ guix build -S synergy  --no-substitutes
La jenaj derivoj estos konstruataj:
   /gnu/store/l9ya3x5xa8ii4xrhcx0zyhcr5759qpk2-synergy-1.8.8.tar.xz.drv
   /gnu/store/jssil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv
@ build-started /gnu/store/jssil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv - x86_64-linux /var/log/guix/drvs/js//sil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv.bz2

Starting download of /gnu/store/fzqf9apmladp4vg4vrvvnvb7gnrm4wry-synergy-1.8.8.tar.gz
From https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz...
ERROR: download failed "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz" 404 "Not Found"

Starting download of /gnu/store/fzqf9apmladp4vg4vrvvnvb7gnrm4wry-synergy-1.8.8.tar.gz
From http://mirror.hydra.gnu.org/file/synergy-1.8.8.tar.gz/sha256/16vxbly4a33c63da3kmj7j47cam583l7bip33jc43mw173wqihw5...
 ...m583l7bip33jc43mw173wqihw5  12.9MiB 873KiB/s 00:15 [####################] 100.0%
@ build-succeeded /gnu/store/jssil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv -
--8<---------------cut here---------------end--------------->8---

> It seems the repo was reorganized; potentially we should now use
> https://github.com/symless/synergy-core instead of
> https://github.com/symless/synergy.

That will also change the tarball hash.  Could you post a patch?

Thanks for the report!

Ludo’.

Message #11 received at 28951 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28951 <at> debbugs.gnu.org
Subject: [PATCH] Re: bug#28951: The upstream URL of our Synergy package is
 broken
Date: Thu, 26 Oct 2017 08:22:33 -0400

[Message part 1 (text/plain, inline)]

Hello Ludovic!

ludo <at> gnu.org (Ludovic Courtès) writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> Hello, here's what attempting to fetch the source URL gives us:
>>
>> Starting download of /tmp/fileLHAs7Q/upstream-synergy-1.8.8.tar.gz
>> From https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz...
>> ERROR: download failed "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz" 404 "Not Found"
>> failed to download "/tmp/fileLHAs7Q/upstream-synergy-1.8.8.tar.gz" from
>> "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz"
>
> Fortunately we get a copy from the mirror:
>
> $ guix build -S synergy  --no-substitutes
> La jenaj derivoj estos konstruataj:
>    /gnu/store/l9ya3x5xa8ii4xrhcx0zyhcr5759qpk2-synergy-1.8.8.tar.xz.drv
>    /gnu/store/jssil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv
> @ build-started /gnu/store/jssil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv - x86_64-linux /var/log/guix/drvs/js//sil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv.bz2
>
> Starting download of /gnu/store/fzqf9apmladp4vg4vrvvnvb7gnrm4wry-synergy-1.8.8.tar.gz
> From https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz...
> ERROR: download failed "https://github.com/symless/synergy/archive/v1.8.8-stable.tar.gz" 404 "Not Found"
>
> Starting download of /gnu/store/fzqf9apmladp4vg4vrvvnvb7gnrm4wry-synergy-1.8.8.tar.gz
> From http://mirror.hydra.gnu.org/file/synergy-1.8.8.tar.gz/sha256/16vxbly4a33c63da3kmj7j47cam583l7bip33jc43mw173wqihw5...
>  ...m583l7bip33jc43mw173wqihw5  12.9MiB 873KiB/s 00:15 [####################] 100.0%
> @ build-succeeded /gnu/store/jssil3viszqr1m9ddj7j2mszrgk7hcpd-synergy-1.8.8.tar.gz.drv -
>
>> It seems the repo was reorganized; potentially we should now use
>> https://github.com/symless/synergy-core instead of
>> https://github.com/symless/synergy.
>
> That will also change the tarball hash.  Could you post a patch?
>
> Thanks for the report!
>
> Ludo’.

Patch attached. Transcript of my investigation below, as a proof that
due diligence was done in updating the hash. I reused the (fiasco
finder) script:

--8<---------------cut here---------------start------------->8---
[manually changed package's URI to then the one]

synergy verifying package hash...

Starting download of /tmp/file9IHVag/upstream-synergy-1.8.8.tar.gz
From https://github.com/symless/synergy-core/archive/v1.8.8-stable.tar.gz...
following redirection to `https://codeload.github.com/symless/synergy-core/tar.gz/v1.8.8-stable'...
 …-stable  12.9MiB                  1.7MiB/s 00:07 [####################] 100.0%

Starting download of /tmp/file9IHVag/substitute-synergy-1.8.8.tar.gz
From https://berlin.guixsd.org/file/synergy-1.8.8.tar.gz/sha256/16vxbly4a33c63da3kmj7j47cam583l7bip33jc43mw173wqihw5...
 …m583l7bip33jc43mw173wqihw5  12.9MiB 1.7MiB/s 00:07 [####################] 100.0%
Diff saved to /home/maxim/src/guile-hacks/fiasco/tar-diffs/upstream-synergy-1.8.8.tar.gz-substitute-synergy-1.8.8.tar.gz.diff:
Only in /tmp/filetUzluo/archive2: synergy-1.8.8-stable
Only in /tmp/filetUzluo/archive1: synergy-core-1.8.8-stable

synergy Guix hash:     "16vxbly4a33c63da3kmj7j47cam583l7bip33jc43mw173wqihw5"
synergy upstream hash: "052z1yiwck9hlshf8in2dgz6p7jxmq9yfj32mfzjaygpz6mmmr4y"
synergy hash NOK
synergy requires manual verification
The following packages require manual verification:
lxqt-common version 0.9.1
synergy version 1.8.8

Attempting to repair the hashes of 0 packages...
maxim <at> apteryx ~/src/guile-hacks/fiasco$ diff -ru /tmp/filetUzluo/archive2 /tmp/filetUzluo/archive1
Only in /tmp/filetUzluo/archive2: synergy-1.8.8-stable
Only in /tmp/filetUzluo/archive1: synergy-core-1.8.8-stable
maxim <at> apteryx ~/src/guile-hacks/fiasco$ mv /tmp/filetUzluo/archive2/synergy-1.8.8-stable/ /tmp/filetUzluo/archive2/synergy-core-1.8.8-stable/
maxim <at> apteryx ~/src/guile-hacks/fiasco$ diff -ru
/tmp/filetUzluo/archive2 /tmp/filetUzluo/archive1
--8<---------------cut here---------------end--------------->8---

Maxim

[0001-gnu-synergy-Update-repository-URI-and-hash.patch (text/x-patch, attachment)]

Message #16 received at 28951-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28951-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Re: bug#28951: The upstream URL of our Synergy package is
 broken
Date: Thu, 26 Oct 2017 15:24:47 -0700

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 69b6fb09ba7d40a94b6b0fe34677030e3590069e Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Thu, 26 Oct 2017 08:11:38 -0400
> Subject: [PATCH] gnu: synergy: Update repository URI and hash.
>
> * gnu/packages/synergy.scm (synergy)[uri]: Replace synergy by synergy-core.
> [sha256]: Update to reflect the name change of the archive root directory.

Applied, thanks for the careful verification!  It’s good to have a
fiasco detector.  ;-)

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.