GNU bug report logs - #28943
25.2; desktop-kill should not be in kill-emacs-hook

Previous Next

Package: emacs;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Sun, 22 Oct 2017 16:28:01 UTC

Severity: minor

Merged with 21833

Found in versions 24.4, 25.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 28943 <at> debbugs.gnu.org, Pierre Neidhardt <ambrevar <at> gmail.com>
Subject: bug#28943: 25.2; desktop-kill should not be in kill-emacs-hook
Date: Fri, 02 Jul 2021 17:33:43 +0200
martin rudalics <rudalics <at> gmx.at> writes:

>> I suggest either we move `desktop-kill' to `kill-emacs-query-functions'
>> or we define two functions, one with user interaction, the other one
>> unattended.
>
> I think we should just move it to ‘kill-emacs-query-functions’.

It seems like everybody agreed about that, so I've now made this change
in Emacs 28.

> A cursory look reveals that at least ‘eshell-save-some-last-dir’,
> ‘eshell-save-some-history’ and ‘ps-kill-emacs-check’ seem to have the
> same problem.

Ditto.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 12 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.