GNU bug report logs - #28921
[PROPOSED] Fix xdg timestamp error on 32-bit Emacs

Previous Next

Full log

View this message in rfc822 format

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 28921 <at> debbugs.gnu.org
Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs
Date: Sat, 21 Oct 2017 10:26:30 -0400

On 20/10/17 at 08:04pm, Paul Eggert wrote:
> * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp,
> not an integer.  This avoids signaling an error on 32-bit
> Emacs, where timestamps typically do not fit into fixnums.

I had the following sitting in my tree, but I don't feel strongly either
way.

diff --git a/lisp/xdg.el b/lisp/xdg.el
index 76106f4258..f57ed5e683 100644
--- a/lisp/xdg.el
+++ b/lisp/xdg.el
@@ -93,8 +93,8 @@ xdg-thumb-name
   (concat (md5 (xdg-thumb-uri filename)) ".png"))
 
 (defun xdg-thumb-mtime (filename)
-  "Return modification time of FILENAME as integral seconds from the epoch."
-  (floor (float-time (nth 5 (file-attributes filename)))))
+  "Return modification time of FILENAME as seconds from the epoch."
+  (ffloor (float-time (nth 5 (file-attributes filename)))))
 
 
 ;; XDG User Directories

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.